Re: [PATCH 1/4] kunit: Introduce kunit_is_running()

ned-off-by: Michal Wajdeczko Hello! I am good with this. It is definitely a prettier way to access kunit_running. Reviewed-by: Rae Moar Thanks! -Rae > --- > Cc: Daniel Latypov > Cc: David Gow > Cc: Lucas De Marchi > --- > include/kunit/test-bug.h | 12 ++-- &g

Re: [PATCH 2/4] kunit: Add macro to conditionally expose declarations to tests

ways. Reviewed-by: Rae Moar Thanks! -Rae > --- > Cc: Rae Moar > Cc: David Gow > Cc: Lucas De Marchi > --- > include/kunit/visibility.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/kunit/visibility.h b/include/kunit/visibility.h > in

Re: [PATCH 4/4] kunit: Add example with alternate function redirection method

data structures. > > Signed-off-by: Michal Wajdeczko Hello! I really like this test. It provides a great overview of this patch series. I just have a couple comments below. Otherwise, Reviewed-by: Rae Moar Thanks! -Rae > --- > Cc: David Gow > Cc: Daniel Latypov > Cc: Lucas De

Re: [PATCH 3/4] kunit: Allow function redirection outside of the KUnit thread

On Wed, Aug 21, 2024 at 10:43 AM Michal Wajdeczko wrote: > Hello! This is looking good and seems to be working well. I just had some questions below. Thanks! -Rae > Currently, the 'static stub' API only allows function redirection > for calls made from the kthread of the current test, which pre

Re: [PATCH 4/4] kunit: Add example with alternate function redirection method

On Wed, Aug 21, 2024 at 6:00 PM Michal Wajdeczko wrote: > > > > On 21.08.2024 23:22, Rae Moar wrote: > > On Wed, Aug 21, 2024 at 10:43 AM Michal Wajdeczko > > wrote: > >> > >> Add example how to use KUNIT_FIXED_STUB_REDIRECT and compare its > >&

Re: [PATCH v2 3/6] kunit: Add macro to conditionally expose expressions to tests

ding this macro without being used as long as examples on how and why to use it are clearly documented. Thanks! -Rae > --- > Cc: Rae Moar > Cc: David Gow > Cc: Lucas De Marchi > --- > include/kunit/visibility.h | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [PATCH] kunit: Fix kernel-doc for EXPORT_SYMBOL_IF_KUNIT

ng this. We will need to do a patch on making this recognized as a kernel-doc at some point. Reviewed-by: Rae Moar Thanks! -Rae > --- > Cc: Rae Moar > Cc: David Gow > --- > include/kunit/visibility.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/in

Re: [PATCH v3 6/6] kunit: Add some selftests for global stub redirection macros

all thing: I find "selftests" in the title of the patch a bit confusing due to the other main Kernel tests being kselftests. I think I would replace "selftests" with just "tests". > --- > Cc: Rae Moar > Cc: David Gow > Cc: Lucas De Marchi > --- >

Re: [PATCH] kunit: Fix kernel-doc for EXPORT_SYMBOL_IF_KUNIT

On Thu, Aug 29, 2024 at 4:28 PM Michal Wajdeczko wrote: > > > > On 29.08.2024 20:58, Rae Moar wrote: > > On Thu, Aug 29, 2024 at 11:32 AM Michal Wajdeczko > > wrote: > >> > >> While kunit/visibility.h is today not included in any generated > >>

Re: [PATCH v8] Kunit to check the longest symbol length

t. > > The second test, verify that the symbols are created (or > not) in the kernel symbol table. > > [1] https://lore.kernel.org/lkml/20220802015052.10452-6-oj...@kernel.org/ > [2] https://lore.kernel.org/lkml/20240605032120.3179157-1-s...@kernel.org/ > > Tested-by: Martin Rodrigu

Re: [PATCH v5] Kunit to check the longest symbol length

On Sun, Nov 17, 2024 at 2:59 PM Sergio González Collado wrote: > > The longest length of a symbol (KSYM_NAME_LEN) was increased to 512 > in the reference [1]. This patch adds kunit test suite to check the longest > symbol length. These tests verify that the longest symbol length defined > is suppo

Re: [PATCH v6] Kunit to check the longest symbol length

through another branch? Let me know. But other than the need to rebase, this patch looks good to me: Reviewed-by: Rae Moar Thanks! -Rae > --- > V5 -> V6: remove tests with symbols of length KSYM_NAME_LEN+1 > --- > V4 -> V5: fixed typo, added improved description > --

Re: [PATCH v6] Kunit to check the longest symbol length

On Tue, Jan 28, 2025 at 3:56 PM Miguel Ojeda wrote: > > On Tue, Jan 28, 2025 at 1:24 PM Sergio González Collado > wrote: > > > > > > +#include > > > > > > Typo? > > > > #include is needed to be able to read > > KSYM_NAME_LEN: > > https://elixir.bootlin.com/linux/v6.13/source/include/linux/kall

Re: [PATCH v8] Kunit to check the longest symbol length

On Mon, Feb 17, 2025 at 3:30 PM Sergio González Collado wrote: > > Hello, > > On Fri, 7 Feb 2025 at 22:54, Rae Moar wrote: > > > > On Sun, Feb 2, 2025 at 2:24 PM Sergio González Collado > > wrote: > > > > > > The longest length of a symbol (

Re: [PATCH v9] Kunit to check the longest symbol length

defined > is supported. > Hello! Thanks for all the updates! This is now applying cleanly for me and it looks good to me. Reviewed-by: Rae Moar Thanks! -Rae > This test can also help other efforts for longer symbol length, > like [2]. > > The test suite defines one symbol wi

<    1   2