On Tue, Jan 28, 2025 at 3:56 PM Miguel Ojeda
<miguel.ojeda.sando...@gmail.com> wrote:
>
> On Tue, Jan 28, 2025 at 1:24 PM Sergio González Collado
> <sergio.coll...@gmail.com> wrote:
> >
> > > > +#include <linux/kallsysms.h>
> > >
> > > Typo?
> >
> > #include <linux/kallsysms.h> is needed to be able to read
> > KSYM_NAME_LEN: 
> > https://elixir.bootlin.com/linux/v6.13/source/include/linux/kallsyms.h#L18
>
> What I meant is that the `#include` in the patch is:
>
>     kallsysms.h
>
> which is different from:
>
>     kallsyms.h
>
> Does that file build? Or am I missing something?
>
> I just tried, and I indeed get:
>
>       HOSTCC  arch/x86/tools/insn_decoder_test
>     arch/x86/tools/insn_decoder_test.c:13:10: fatal error:
> 'linux/kallsysms.h' file not found
>       13 | #include <linux/kallsysms.h>
>           |          ^~~~~~~~~~~~~~~~~~~
>     1 error generated.
>
> Thanks!
>
> Cheers,
> Miguel

Hi!

Oh yep definitely missed that typo. Thanks for catching this!

Thanks!
-Rae

>
> --
> You received this message because you are subscribed to the Google Groups 
> "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to kunit-dev+unsubscr...@googlegroups.com.
> To view this discussion visit 
> https://groups.google.com/d/msgid/kunit-dev/CANiq72kXG4qURXjnZZTLPMn-k_WwFt0yabR0nfCAzDMqYNJKHg%40mail.gmail.com.

Reply via email to