[PATCH 0/4] kselftests: vdso: conform tests to TAP output

2024-05-29 Thread Muhammad Usama Anjum
Conform individual tests to TAP output. One patch conform one test. With this series, all vDSO tests become TAP conformant. Muhammad Usama Anjum (4): kselftests: vdso: vdso_test_clock_getres: conform test to TAP output kselftests: vdso: vdso_test_correctness: conform test to TAP output kself

[PATCH 1/4] kselftests: vdso: vdso_test_clock_getres: conform test to TAP output

2024-05-29 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- .../selftests/vDSO/vdso_test_clock_getres.c | 68 +-- 1 file changed, 33 insertions(+), 35 deletions(

[PATCH 2/4] kselftests: vdso: vdso_test_correctness: conform test to TAP output

2024-05-29 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- .../selftests/vDSO/vdso_test_correctness.c| 146 +- 1 file changed, 74 insertions(+), 72 deletions(

[PATCH 3/4] kselftests: vdso: vdso_test_getcpu: conform test to TAP output

2024-05-29 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/vDSO/vdso_test_getcpu.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)

[PATCH 4/4] kselftests: vdso: vdso_test_gettimeofday: conform test to TAP output

2024-05-29 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- .../selftests/vDSO/vdso_test_gettimeofday.c | 23 ++- 1 file changed, 12 insertions(+), 11 deletions(

Re: [PATCH HID 03/13] HID: bpf: implement HID-BPF through bpf_struct_ops

2024-05-29 Thread Benjamin Tissoires
On May 28 2024, Alexei Starovoitov wrote: > On Tue, May 28, 2024 at 6:15 AM Benjamin Tissoires wrote: > > > > We do this implementation in several steps to not have the CI failing: > > - first (this patch), we add struct_ops while keeping the existing infra > > available > > - then we change the

Re: [PATCH v2] selftests/vDSO: fix clang build errors and warnings

2024-05-29 Thread Muhammad Usama Anjum
On 5/28/24 2:16 AM, John Hubbard wrote: > When building with clang, via: > > make LLVM=1 -C tools/testing/selftests > > ...there are several warnings, and an error. This fixes all of those and > allows these tests to run and pass. > > 1. Fix linker error (undefined reference to memcpy) by pr

Re: [PATCH] selftests/openat2: Fix build warnings on ppc64

2024-05-29 Thread Michael Ellerman
Muhammad Usama Anjum writes: > I was looking at if we can add this flag for ppc64 for all selftests > somewhere. But there isn't any suitable place other than in KHDR_INCLUDES. > But there is a series already trying to add _GNU_SOURCE to it. IMHO adding other flags to KHDR_INCLUDES is not the rig

[PATCH net-next 4/4] selftests: forwarding: router_mpath_hash: Add a new selftest

2024-05-29 Thread Petr Machata
Add a selftest that exercises the sysctl added in the previous patches. Test that set/get works as expected; that across seeds we eventually hit all NHs (test_mpath_seed_*); and that a given seed keeps hitting the same NHs even across seed changes (test_mpath_seed_stability_*). Signed-off-by: Pet

[PATCH v2] selftests: timers: clocksource-switch: Adapt progress to kselftest framework

2024-05-29 Thread Geert Uytterhoeven
When adapting the test to the kselftest framework, a few printf() calls indicating test progress were not updated. Fix this by replacing these printf() calls by ksft_print_msg() calls. Fixes: ce7d101750ff8450 ("selftests: timers: clocksource-switch: adapt to kselftest framework") Signed-off-by:

Re: [PATCH 2/2] usercopy: Convert test_user_copy to KUnit test

2024-05-29 Thread Ivan Orlov
On 5/19/24 20:12, Kees Cook wrote: Convert the runtime tests of hardened usercopy to standard KUnit tests. Co-developed-by: Vitor Massaru Iha Signed-off-by: Vitor Massaru Iha Link: https://lore.kernel.org/r/20200721174654.72132-1-vi...@massaru.org Signed-off-by: Kees Cook --- Hi Kees, It l

Re: [PATCH net v2] selftests: hsr: Fix "File exists" errors for hsr_ping

2024-05-29 Thread Lukasz Majewski
Hi Geliang, First of all - thanks for spotting and fixing this error. > From: Geliang Tang > > The hsr_ping test reports the following errors: > > INFO: preparing interfaces for HSRv0. > INFO: Initial validation ping. > INFO: Longer ping test. > INFO: Cutting one link. > INFO: Delay the l

Re: [PATCH net v2] selftests: hsr: Fix "File exists" errors for hsr_ping

2024-05-29 Thread Geliang Tang
Hi Lukasz, On Wed, 2024-05-29 at 14:43 +0200, Lukasz Majewski wrote: > Hi Geliang, > > First of all - thanks for spotting and fixing this error. > > > From: Geliang Tang > > > > The hsr_ping test reports the following errors: > > > >  INFO: preparing interfaces for HSRv0. > >  INFO: Initial v

Re: [PATCH v5] kunit: Cover 'assert.c' with tests

2024-05-29 Thread Ivan Orlov
On 5/20/24 22:12, Rae Moar wrote: On Thu, May 16, 2024 at 11:17 PM Ivan Orlov wrote: There are multiple assertion formatting functions in the `assert.c` file, which are not covered with tests yet. Implement the KUnit test for these functions. The test consists of 11 test cases for the followi

Re: [PATCH v2] selftests: livepatch: Test atomic replace against multiple modules

2024-05-29 Thread Miroslav Benes
On Sat, 25 May 2024, Marcos Paulo de Souza wrote: > diff --git a/tools/testing/selftests/livepatch/test-livepatch.sh > b/tools/testing/selftests/livepatch/test-livepatch.sh > index e3455a6b1158..d85405d18e54 100755 > --- a/tools/testing/selftests/livepatch/test-livepatch.sh > +++ b/tools/testing/

[PATCH] selftests: hsr: Extend the hsr_ping.sh test to use fixed MAC addresses

2024-05-29 Thread Lukasz Majewski
Fixed MAC addresses help with debugging as last four bytes identify the network namespace. Signed-off-by: Lukasz Majewski --- tools/testing/selftests/net/hsr/hsr_ping.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/testing/selftests/net/hsr/hsr_ping.sh b/tools/testing/self

[PATCH] selftests: hsr: Extend the hsr_redbox.sh test to use fixed MAC addresses

2024-05-29 Thread Lukasz Majewski
Fixed MAC addresses help with debugging as last four bytes identify the network namespace. Moreover, it allows to mimic the real life setup with for example bridge having the same MAC address on each port. Signed-off-by: Lukasz Majewski --- tools/testing/selftests/net/hsr/hsr_redbox.sh | 15 +++

Re: [PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-29 Thread Mina Almasry
On Tue, May 28, 2024 at 7:42 PM Pavel Begunkov wrote: > > On 5/28/24 18:36, Mina Almasry wrote: > > On Wed, May 22, 2024 at 11:02 PM David Wei wrote: > ... > >>> + */ > >>> + if (!skb_frag_net_iov(frag)) { > >>> + net_err_rateli

Re: [PATCH v4 01/16] selftests/resctrl: Fix closing IMC fds on error and open-code R+W instead of loops

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: The imc perf fd close() calls are missing from all error paths. In addition, get_mem_bw_imc() handles fds in a for loop but close() is based on two fixed indexes READ and WRITE. Open code inner for loops to READ+WRITE entries for clarity and add

Re: [PATCH v4 03/16] selftests/resctrl: Make "bandwidth" consistent in comments & prints

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: Resctrl selftests refer to "bandwidth" currently in two other forms in the code ("B/W" and "band width"). Use "bandwidth" consistently everywhere. While at it, fix also one "over flow" -> "overflow" on a line that is touched by the change. Sugg

Re: [PATCH v4 04/16] selftests/resctrl: Consolidate get_domain_id() into resctrl_val()

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: Both initialize_mem_bw_resctrl() and initialize_llc_occu_resctrl() that are called from resctrl_val() need to determine domain ID to construct resctrl fs related paths. Both functions do it by taking CPU ID which neither needs for any other purpo

Re: [PATCH v4 05/16] selftests/resctrl: Use correct type for pids

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: A few functions receive PIDs through int arguments. PIDs variables should be of type pid_t, not int. Convert pid arguments from int to pid_t. This looks good to me. A couple of places remain that treat pid_t as int ... that is via the %d form

Re: [PATCH v4 06/16] selftests/resctrl: Cleanup bm_pid and ppid usage & limit scope

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: 'bm_pid' and 'ppid' are global variables. As they are used by different processes and in signal handler, they cannot be entirely converted into local variables. The scope of those variables can still be reduced into resctrl_val.c only. As PARENT

Re: [PATCH v4 07/16] selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() & document

2024-05-29 Thread Reinette Chatre
Hi Ilpo, Function name in shortlog does not match the patch. On 5/20/24 5:30 AM, Ilpo Järvinen wrote: measure_val() is awfully generic name so rename it to measure_mem_bw() measure_val() -> measure_vals() to describe better what it does and document the function parameters. Signed-off-by:

Re: [PATCH v4 08/16] selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM tests

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: initialize_mem_bw_resctrl() and set_mbm_path() contain complicated set of conditions, each yielding different file to be opened to measure memory bandwidth through resctrl FS. In practice, only two of them are used. For MBA test, ctrlgrp is alway

Re: [PATCH v4 09/16] selftests/resctrl: Add ->measure() callback to resctrl_val_param

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: The measurement done in resctrl_val() varies depending on test type. The decision for how to measure is decided based on the string compare to test name which is quite inflexible. Add ->measure() callback into the struct resctrl_val_param to all

Re: [PATCH v4 11/16] selftests/resctrl: Simplify bandwidth report type handling

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: bw_report is only needed for selecting the correct value from the values IMC measured. It is a member in the resctrl_val_param struct and is always set to "reads". The value is then checked in resctrl_val() using validate_bw_report_request() that

Re: [PATCH v4 12/16] selftests/resctrl: Make some strings passed to resctrlfs functions const

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: Control group, monitor group and resctrl_val are not mutated and should not be mutated within resctrlfs.c functions. Mark this by using const char * for the arguments. Signed-off-by: Ilpo Järvinen --- Reviewed-by: Reinette Chatre Reinette

Re: [PATCH v4 10/16] selftests/resctrl: Add ->init() callback into resctrl_val_param

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: ... diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h index 5dc3def70669..d3fbb957309d 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -

Re: [PATCH v4 13/16] selftests/resctrl: Convert ctrlgrp & mongrp to pointers

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: The struct resctrl_val_param has control and monitor groups as char arrays but they are not supposed to be mutated within resctrl_val(). Convert the ctrlgrp and mongrp char array within resctrl_val_param to plain const char pointers and adjust t

Re: [PATCH v4 14/16] selftests/resctrl: Remove mongrp from MBA test

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: Nothing during MBA test uses mongrp even if it has been defined ever since the introduction of the MBA test in the commit 01fee6b4d1f9 ("selftests/resctrl: Add MBA test"). Remove the mongrp from MBA test. Signed-off-by: Ilpo Järvinen --- too

Re: [PATCH v4 15/16] selftests/resctrl: Remove mongrp from CMT test

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: The CMT selftest instanciates a monitor group to read LLC occupancy. instanciates -> instantiates Since the test also creates a control group, it is unnecessary to create another one for monitoring because control groups already provide monit

Re: [PATCH v4 16/16] selftests/resctrl: Remove test name comparing from write_bm_pid_to_resctrl()

2024-05-29 Thread Reinette Chatre
Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote: write_bm_pid_to_resctrl() uses resctrl_val to check test name which is not a good interface generic resctrl FS functions should provide. Only MBM and CMT tests define mongrp so the test name check in write_bm_pid_to_resctrl() can be changed to d

[PATCH v4 0/7] mm: multi-gen LRU: Walk secondary MMU page tables while aging

2024-05-29 Thread James Houghton
This patchset makes it possible for MGLRU to consult secondary MMUs while doing aging, not just during eviction. This allows for more accurate reclaim decisions, which is especially important for proactive reclaim. This series makes the necessary MMU notifier changes to MGLRU and then includes opt

[PATCH v4 1/7] mm/Kconfig: Add LRU_GEN_WALKS_SECONDARY_MMU

2024-05-29 Thread James Houghton
Add this option so that one building the kernel can choose whether or not they want to support walking the secondary MMU. We want users to be able to blindly enable all lru_gen features to have the best possible performance most of the time. Walking the secondary MMU is mainly useful for be able t

[PATCH v4 3/7] KVM: Add lockless memslot walk to KVM

2024-05-29 Thread James Houghton
Provide flexibility to the architecture to synchronize as optimally as they can instead of always taking the MMU lock for writing. The immediate application is to allow architectures to implement the test/clear_young MMU notifiers more cheaply. Suggested-by: Yu Zhao Signed-off-by: James Houghton

[PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging

2024-05-29 Thread James Houghton
Secondary MMUs are currently consulted for access/age information at eviction time, but before then, we don't get accurate age information. That is, pages that are mostly accessed through a secondary MMU (like guest memory, used by KVM) will always just proceed down to the oldest generation, and th

[PATCH v4 4/7] KVM: Move MMU lock acquisition for test/clear_young to architecture

2024-05-29 Thread James Houghton
For implementation mmu_notifier_{test,clear}_young, the KVM memslot walker used to take the MMU lock for us. Now make the architectures take it themselves. Don't relax locking for any architecture except powerpc e500; its implementations of kvm_age_gfn and kvm_test_age_gfn simply return false, so

[PATCH v4 5/7] KVM: x86: Relax locking for kvm_test_age_gfn and kvm_age_gfn

2024-05-29 Thread James Houghton
Walk the TDP MMU in an RCU read-side critical section. This requires a way to do RCU-safe walking of the tdp_mmu_roots; do this with a new macro. The PTE modifications are now done atomically, and kvm_tdp_mmu_spte_need_atomic_write() has been updated to account for the fact that kvm_age_gfn can now

[PATCH v4 6/7] KVM: arm64: Relax locking for kvm_test_age_gfn and kvm_age_gfn

2024-05-29 Thread James Houghton
Replace the MMU write locks for read locks. Grabbing the read lock instead of the write lock is safe because the only requirement we have is that the stage-2 page tables do not get deallocated while we are walking them. The stage2_age_walker() callback is safe to race with itself; update the comme

[PATCH v4 7/7] KVM: selftests: Add multi-gen LRU aging to access_tracking_perf_test

2024-05-29 Thread James Houghton
This test now has two modes of operation: 1. (default) To check how much vCPU performance was affected by access tracking (previously existed, now supports MGLRU aging). 2. (-p) To also benchmark how fast MGLRU can do aging while vCPUs are faulting in memory. Mode (1) also ser

Re: [PATCH net-next v9 04/14] netdev: support binding dma-buf to netdevice

2024-05-29 Thread Mina Almasry
On Sat, May 18, 2024 at 11:46 AM David Wei wrote: > > On 2024-05-10 16:21, Mina Almasry wrote: > > +void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding) > > +{ > > + struct netdev_rx_queue *rxq; > > + unsigned long xa_idx; > > + unsigned int rxq_idx; > > + > > +

[PATCH] tools/testing/selftests/livepatch: define max test-syscall processes

2024-05-29 Thread Ryan Sullivan
Define a maximum allowable number of pids that can be livepatched in test-syscall.sh as with extremely large machines the output from a large number of processes overflows the dev/kmsg "expect" buffer in the "check_result" function and causes a false error. Reported-by: CKI Project Signed-off-by:

Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging

2024-05-29 Thread Yu Zhao
On Wed, May 29, 2024 at 12:05 PM James Houghton wrote: > > Secondary MMUs are currently consulted for access/age information at > eviction time, but before then, we don't get accurate age information. > That is, pages that are mostly accessed through a secondary MMU (like > guest memory, used by K

Re: [PATCH] tools/testing/selftests/livepatch: define max test-syscall processes

2024-05-29 Thread Marcos Paulo de Souza
From: mpdeso...@suse.com On Wed, 29 May 2024 16:19:41 -0400 Ryan Sullivan wrote: > Define a maximum allowable number of pids that can be livepatched in > test-syscall.sh as with extremely large machines the output from a > large number of processes overflows the dev/kmsg "expect" buffer in > the

Re: [PATCH v2 1/2] memfd: fix MFD_NOEXEC_SEAL to be non-sealable by default

2024-05-29 Thread Jeff Xu
Hi David and Barnabás On Fri, May 24, 2024 at 7:15 AM David Rheinsberg wrote: > > Hi > > On Fri, May 24, 2024, at 5:39 AM, jef...@chromium.org wrote: > > From: Jeff Xu > > > > By default, memfd_create() creates a non-sealable MFD, unless the > > MFD_ALLOW_SEALING flag is set. > > > > When the MF

Re: [PATCH v2 1/2] memfd: fix MFD_NOEXEC_SEAL to be non-sealable by default

2024-05-29 Thread Barnabás Pőcze
Hi 2024. május 29., szerda 23:30 keltezéssel, Jeff Xu írta: > Hi David and Barnabás > > On Fri, May 24, 2024 at 7:15 AM David Rheinsberg wrote: > > > > Hi > > > > On Fri, May 24, 2024, at 5:39 AM, jef...@chromium.org wrote: > > > From: Jeff Xu > > > > > > By default, memfd_create() creates a

Re: [PATCH v4 3/7] KVM: Add lockless memslot walk to KVM

2024-05-29 Thread Sean Christopherson
On Wed, May 29, 2024, James Houghton wrote: > @@ -686,10 +694,12 @@ static __always_inline int kvm_handle_hva_range(struct > mmu_notifier *mn, > return __kvm_handle_hva_range(kvm, &range).ret; > } > > -static __always_inline int kvm_handle_hva_range_no_flush(struct mmu_notifier > *mn, >

Re: [PATCH v4 4/7] KVM: Move MMU lock acquisition for test/clear_young to architecture

2024-05-29 Thread Sean Christopherson
On Wed, May 29, 2024, James Houghton wrote: > For implementation mmu_notifier_{test,clear}_young, the KVM memslot > walker used to take the MMU lock for us. Now make the architectures > take it themselves. Hmm, *forcing* architectures to take mmu_lock is a step backwards. Rather than add all of t

Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging

2024-05-29 Thread Sean Christopherson
On Wed, May 29, 2024, Yu Zhao wrote: > On Wed, May 29, 2024 at 12:05 PM James Houghton wrote: > > > > Secondary MMUs are currently consulted for access/age information at > > eviction time, but before then, we don't get accurate age information. > > That is, pages that are mostly accessed through

Re: [PATCH v5 02/16] riscv: add ISA extension parsing for Zimop

2024-05-29 Thread Charlie Jenkins
On Fri, May 17, 2024 at 04:52:42PM +0200, Clément Léger wrote: > Add parsing for Zimop ISA extension which was ratified in commit > 58220614a5f of the riscv-isa-manual. > > Signed-off-by: Clément Léger > --- > arch/riscv/include/asm/hwcap.h | 1 + > arch/riscv/kernel/cpufeature.c | 1 + > 2 file

Re: [PATCH v5 01/16] dt-bindings: riscv: add Zimop ISA extension description

2024-05-29 Thread Charlie Jenkins
On Fri, May 17, 2024 at 04:52:41PM +0200, Clément Léger wrote: > Add description for the Zimop (May-Be-Operations) ISA extension which > was ratified in commit 58220614a5f of the riscv-isa-manual. > > Signed-off-by: Clément Léger > --- > Documentation/devicetree/bindings/riscv/extensions.yaml |

Re: [PATCH v5 03/16] riscv: hwprobe: export Zimop ISA extension

2024-05-29 Thread Charlie Jenkins
On Fri, May 17, 2024 at 04:52:43PM +0200, Clément Léger wrote: > Export Zimop ISA extension through hwprobe. > > Signed-off-by: Clément Léger > --- > Documentation/arch/riscv/hwprobe.rst | 4 > arch/riscv/include/uapi/asm/hwprobe.h | 1 + > arch/riscv/kernel/sys_hwprobe.c | 1 + > 3

Re: [PATCH v5 06/16] dt-bindings: riscv: add Zca, Zcf, Zcd and Zcb ISA extension description

2024-05-29 Thread Charlie Jenkins
On Fri, May 17, 2024 at 04:52:46PM +0200, Clément Léger wrote: > Add description for Zca, Zcf, Zcd and Zcb extensions which are part the > Zc* standard extensions for code size reduction. Additional validation > rules are added since Zcb depends on Zca, Zcf, depends on Zca and F, Zcd > depends on Z

Re: [PATCH v5 04/16] RISC-V: KVM: Allow Zimop extension for Guest/VM

2024-05-29 Thread Charlie Jenkins
On Fri, May 17, 2024 at 04:52:44PM +0200, Clément Léger wrote: > Extend the KVM ISA extension ONE_REG interface to allow KVM user space > to detect and enable Zimop extension for Guest/VM. > > Signed-off-by: Clément Léger > --- > arch/riscv/include/uapi/asm/kvm.h | 1 + > arch/riscv/kvm/vcpu_one

Re: [PATCH] selftests/overlayfs: Fix build error on ppc64

2024-05-29 Thread Shuah Khan
On 5/20/24 20:26, Michael Ellerman wrote: Fix build error on ppc64: dev_in_maps.c: In function ‘get_file_dev_and_inode’: dev_in_maps.c:60:59: error: format ‘%llu’ expects argument of type ‘long long unsigned int *’, but argument 7 has type ‘__u64 *’ {aka ‘long unsigned int *’} [-Werro

Re: [PATCH] selftests: cachestat: Fix build warnings on ppc64

2024-05-29 Thread Shuah Khan
On 5/20/24 21:01, Michael Ellerman wrote: Fix warnings like: test_cachestat.c: In function ‘print_cachestat’: test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka ‘long unsigned int’} [-Wformat=] By swi

Re: [PATCH] selftests/openat2: Fix build warnings on ppc64

2024-05-29 Thread Shuah Khan
On 5/20/24 21:03, Michael Ellerman wrote: Fix warnings like: openat2_test.c: In function ‘test_openat2_flags’: openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘long unsigned int’} [-Wformat=] By sw

Re: [PATCH v5 02/16] riscv: add ISA extension parsing for Zimop

2024-05-29 Thread Charlie Jenkins
On Wed, May 29, 2024 at 03:08:39PM -0700, Charlie Jenkins wrote: > On Fri, May 17, 2024 at 04:52:42PM +0200, Clément Léger wrote: > > Add parsing for Zimop ISA extension which was ratified in commit > > 58220614a5f of the riscv-isa-manual. > > > > Signed-off-by: Clément Léger > > --- > > arch/ri

Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging

2024-05-29 Thread Yu Zhao
On Wed, May 29, 2024 at 3:59 PM Sean Christopherson wrote: > > On Wed, May 29, 2024, Yu Zhao wrote: > > On Wed, May 29, 2024 at 12:05 PM James Houghton > > wrote: > > > > > > Secondary MMUs are currently consulted for access/age information at > > > eviction time, but before then, we don't get a

Re: [PATCH v2 1/2] memfd: fix MFD_NOEXEC_SEAL to be non-sealable by default

2024-05-29 Thread Jeff Xu
On Wed, May 29, 2024 at 2:46 PM Barnabás Pőcze wrote: > > Hi > > > 2024. május 29., szerda 23:30 keltezéssel, Jeff Xu írta: > > > Hi David and Barnabás > > > > On Fri, May 24, 2024 at 7:15 AM David Rheinsberg wrote: > > > > > > Hi > > > > > > On Fri, May 24, 2024, at 5:39 AM, jef...@chromium.org

Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging

2024-05-29 Thread Sean Christopherson
On Wed, May 29, 2024, Yu Zhao wrote: > On Wed, May 29, 2024 at 3:59 PM Sean Christopherson wrote: > > > > On Wed, May 29, 2024, Yu Zhao wrote: > > > On Wed, May 29, 2024 at 12:05 PM James Houghton > > > wrote: > > > > > > > > Secondary MMUs are currently consulted for access/age information at >

Re: [PATCH bpf-next v2 1/8] selftests/bpf: Add unshare_netns helper

2024-05-29 Thread Martin KaFai Lau
On 5/15/24 6:13 PM, Geliang Tang wrote: From: Geliang Tang Many BPF selftests create new test network namespaces by using CLONE_NEWNET flag to unshare the network namespace, so that the calling process is moved into a new network namespace which is not shared with any previously existing proces

kselftest/fixes build: 6 builds: 0 failed, 6 passed, 1 warning (v6.10-rc1-7-ge8b8c5264d4e)

2024-05-29 Thread kernelci.org bot
kselftest/fixes build: 6 builds: 0 failed, 6 passed, 1 warning (v6.10-rc1-7-ge8b8c5264d4e) Full Build Summary: https://kernelci.org/build/kselftest/branch/fixes/kernel/v6.10-rc1-7-ge8b8c5264d4e/ Tree: kselftest Branch: fixes Git Describe: v6.10-rc1-7-ge8b8c5264d4e Git Commit: e8b8c5264d4ebd248f

kselftest/fixes kselftest-lkdtm: 6 runs, 1 regressions (v6.10-rc1-7-ge8b8c5264d4e)

2024-05-29 Thread kernelci.org bot
kselftest/fixes kselftest-lkdtm: 6 runs, 1 regressions (v6.10-rc1-7-ge8b8c5264d4e) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions +--+---+--+--

kselftest/fixes kselftest-livepatch: 2 runs, 1 regressions (v6.10-rc1-7-ge8b8c5264d4e)

2024-05-29 Thread kernelci.org bot
kselftest/fixes kselftest-livepatch: 2 runs, 1 regressions (v6.10-rc1-7-ge8b8c5264d4e) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions +--+---+--+--

kselftest/fixes kselftest-seccomp: 6 runs, 2 regressions (v6.10-rc1-7-ge8b8c5264d4e)

2024-05-29 Thread kernelci.org bot
kselftest/fixes kselftest-seccomp: 6 runs, 2 regressions (v6.10-rc1-7-ge8b8c5264d4e) Regressions Summary --- platform | arch | lab | compiler | defconfig | regressions -+---+---+---

Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging

2024-05-29 Thread James Houghton
On Wed, May 29, 2024 at 3:58 PM Sean Christopherson wrote: > > On Wed, May 29, 2024, Yu Zhao wrote: > > On Wed, May 29, 2024 at 3:59 PM Sean Christopherson > > wrote: > > > > > > On Wed, May 29, 2024, Yu Zhao wrote: > > > > On Wed, May 29, 2024 at 12:05 PM James Houghton > > > > wrote: > > > >

[PATCH 1/1] selftest: drivers: Add support its msi hwirq checking

2024-05-29 Thread Joseph Jang
Validate there are no duplicate ITS-MSI hwirqs from the /sys/kernel/irq/*/hwirq. One example log show 2 duplicated MSI entries in the /proc/interrupts. 150: 0 ... ITS-MSI 3355443200 Edge pciehp 152: 0 ... ITS-MSI 3355443200 Edge pciehp Kernel patch ("PCI/MSI: Fix MSI hwirq truncation")

[PATCH 0/1] selftest: drivers: Add support its msi hwirq checking

2024-05-29 Thread Joseph Jang
In order to validate ITS-MSI hwirq entry in the /proc/interrupts, we have created a shell script to check is there any duplicated ITS-MSI hwirq entry. Joseph Jang (1): selftest: drivers: Add support its msi hwirq checking tools/testing/selftests/drivers/irq/Makefile | 5 + .../selftests/

Re: [PATCH] selftests: hsr: Extend the hsr_redbox.sh test to use fixed MAC addresses

2024-05-29 Thread Hangbin Liu
On Wed, May 29, 2024 at 04:22:32PM +0200, Lukasz Majewski wrote: > Fixed MAC addresses help with debugging as last four bytes identify the > network namespace. > > Moreover, it allows to mimic the real life setup with for example bridge > having the same MAC address on each port. > > Signed-off-b

Re: [PATCH] selftests/overlayfs: Fix build error on ppc64

2024-05-29 Thread Michael Ellerman
Shuah Khan writes: > On 5/20/24 20:26, Michael Ellerman wrote: >> Fix build error on ppc64: >>dev_in_maps.c: In function ‘get_file_dev_and_inode’: >>dev_in_maps.c:60:59: error: format ‘%llu’ expects argument of type >>‘long long unsigned int *’, but argument 7 has type ‘__u64 *’ {aka ‘

Re: [PATCH v4 3/7] KVM: Add lockless memslot walk to KVM

2024-05-29 Thread James Houghton
On Wed, May 29, 2024 at 2:51 PM Sean Christopherson wrote: > > On Wed, May 29, 2024, James Houghton wrote: > > @@ -686,10 +694,12 @@ static __always_inline int > > kvm_handle_hva_range(struct mmu_notifier *mn, > > return __kvm_handle_hva_range(kvm, &range).ret; > > } > > > > -static __alwa

Re: [PATCH v4 4/7] KVM: Move MMU lock acquisition for test/clear_young to architecture

2024-05-29 Thread James Houghton
On Wed, May 29, 2024 at 2:55 PM Sean Christopherson wrote: > > On Wed, May 29, 2024, James Houghton wrote: > > For implementation mmu_notifier_{test,clear}_young, the KVM memslot > > walker used to take the MMU lock for us. Now make the architectures > > take it themselves. > > Hmm, *forcing* arch

Re: [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS

2024-05-29 Thread Muhammad Usama Anjum
On 5/10/24 10:56 PM, John Hubbard wrote: > On 5/10/24 4:52 AM, Ryan Roberts wrote: >> On 04/05/2024 05:43, John Hubbard wrote: > ... >> It just occured to me that the bug report I was fixing with my attempt was >> invoking make like this (see [1]): >> >> # tools/testing/selftests/fchmodat2$ make CC

Re: [PATCH v5] kunit: Cover 'assert.c' with tests

2024-05-29 Thread David Gow
On Fri, 17 May 2024 at 05:17, Ivan Orlov wrote: > > There are multiple assertion formatting functions in the `assert.c` > file, which are not covered with tests yet. Implement the KUnit test > for these functions. > > The test consists of 11 test cases for the following functions: > > 1) 'is_liter

Re: [PATCH 1/2] selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS

2024-05-29 Thread John Hubbard
On 5/29/24 8:58 PM, Muhammad Usama Anjum wrote: On 5/10/24 10:56 PM, John Hubbard wrote: On 5/10/24 4:52 AM, Ryan Roberts wrote: On 04/05/2024 05:43, John Hubbard wrote: ... In Make, the arguments to functions include *all* spaces, so it's good practice to not add spaces in most function calls

Re: [PATCH 1/2] selftests/lib.mk: handle both LLVM=1 and CC=clang builds

2024-05-29 Thread Muhammad Usama Anjum
On 5/29/24 7:08 AM, John Hubbard wrote: > The kselftests may be built in a couple different ways: > make LLVM=1 > make CC=clang > > In order to handle both cases, set LLVM=1 if CC=clang. That way,the rest > of lib.mk, and any Makefiles that include lib.mk, can base decisions > solely on wh