Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-11-10 Thread Luis Felipe Hernandez
Hi David, I wanted to follow up on this patch to check if any additional fixes are needed. Additionally, I would like to address Andy Shevchenko's feedback in v2 regarding moving the lib/math/test/* Kunit test Kconfig entries from lib/Kconfig.debug to lib/tests/Kconfig? > > > > --- a/lib/Kconfi

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-11-01 Thread Luis Felipe Hernandez
On Thu, Oct 31, 2024 at 05:39:41PM -0700, Andrew Morton wrote: > > > --- a/lib/math/Makefile > > > +++ b/lib/math/Makefile > > > @@ -9,3 +9,4 @@ obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o > > > obj-$(CONFIG_TEST_DIV64)+= test_div64.o > > > obj-$(CONFIG_TEST_MULDIV64) += te

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-11-01 Thread Andrew Morton
On Thu, 31 Oct 2024 20:25:56 -0600 Shuah Khan wrote: > >>> --- a/lib/math/Makefile > >>> +++ b/lib/math/Makefile > >>> @@ -9,3 +9,4 @@ obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o > >>>obj-$(CONFIG_TEST_DIV64) += test_div64.o > >>>obj-$(CONFIG_TEST_MULDIV64)+= test_mul_u

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Andrew Morton
On Thu, 31 Oct 2024 20:25:56 -0600 Shuah Khan wrote: > > What's this change about? It seems somewhat unrelated to adding a > > single test. I mean, there's an unrelated test listed in > > lib/math/tests/Makefile so what change does this patch have upon that > > one? > > > > I think this is a

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Shuah Khan
On 10/31/24 18:39, Andrew Morton wrote: On Thu, 31 Oct 2024 11:50:16 -0600 Shuah Khan wrote: On 10/30/24 07:43, Luis Felipe Hernandez wrote: Adds test suite for integer based square root function. The test suite is designed to verify the correctness of the int_sqrt() math library function.

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Andrew Morton
On Thu, 31 Oct 2024 11:50:16 -0600 Shuah Khan wrote: > On 10/30/24 07:43, Luis Felipe Hernandez wrote: > > Adds test suite for integer based square root function. > > > > The test suite is designed to verify the correctness of the int_sqrt() > > math library function. > > > > Signed-off-by: Lui

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Shuah Khan
On 10/30/24 07:43, Luis Felipe Hernandez wrote: Adds test suite for integer based square root function. The test suite is designed to verify the correctness of the int_sqrt() math library function. Signed-off-by: Luis Felipe Hernandez --- Changes in v2 - Add new line at the end of int_sqrt_

[PATCH v3] lib/math: Add int_sqrt test suite

2024-10-30 Thread Luis Felipe Hernandez
Adds test suite for integer based square root function. The test suite is designed to verify the correctness of the int_sqrt() math library function. Signed-off-by: Luis Felipe Hernandez --- Changes in v2 - Add new line at the end of int_sqrt_kunit.c - Add explicit header includes for MODULE