On Thu, 31 Oct 2024 11:50:16 -0600 Shuah Khan <sk...@linuxfoundation.org> wrote:
> On 10/30/24 07:43, Luis Felipe Hernandez wrote: > > Adds test suite for integer based square root function. > > > > The test suite is designed to verify the correctness of the int_sqrt() > > math library function. > > > > Signed-off-by: Luis Felipe Hernandez <luis.hernandez...@gmail.com> > > --- > > Changes in v2 > > - Add new line at the end of int_sqrt_kunit.c > > - Add explicit header includes for MODULE_* macros, strscpy, and > > ULONG_MAX > > > > Changes in v3 > > - Remove unnecesary new line after Kconfig entry for INT_SQRT_KUNIT_TEST > > - Correct int_sqrt instances with int_sqrt() in commit message and > > kconfig > > entry desc > > - Fix limits.h header include path > > Adding Andrew to the thread. Thanks. > I think this depends on the other lib kunit > content that is already in next. Actually the patch applies cleanly to 6.12-rc5. > > --- a/lib/math/Makefile > > +++ b/lib/math/Makefile > > @@ -9,3 +9,4 @@ obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o > > obj-$(CONFIG_TEST_DIV64) += test_div64.o > > obj-$(CONFIG_TEST_MULDIV64) += test_mul_u64_u64_div_u64.o > > obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o > > +obj-y += tests/ What's this change about? It seems somewhat unrelated to adding a single test. I mean, there's an unrelated test listed in lib/math/tests/Makefile so what change does this patch have upon that one?
