[PATCH] modified error code when perf_session__new() fail

2014-09-17 Thread taeung
Hi, I modified error code for the requirement as below. Author: taeung Date: Sat Sep 13 16:22:53 2014 +0900 modified error code when perf_session__new() fail Because perf_session__new() could fail for more reasons than just ENOMEM, I modified error code(ENOMEM

[PATCH] modify error code when perf_session__new() fail.

2014-09-22 Thread taeung
Because perf_session__new() could fail for more reasons than just ENOMEM, I modified error code(ENOMEM or EINVAL) into -1. Signed-off-by: taeung --- tools/perf/builtin-annotate.c | 2 +- tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-evlist.c| 2

Re: [PATCH 03/13] perf annotate: Move session handling out of __cmd_annotate()

2014-09-13 Thread taeung
Hi, I modified error code for the requirement as below. Author: taeung Date: Sat Sep 13 16:22:53 2014 +0900 modified error code when perf_session__new() fail Because perf_session__new() could fail for more reasons than just ENOMEM, I modified error code(ENOMEM

Re: [PATCH] perf top: Add a visual cue for toggle zeroing of samples

2014-10-07 Thread taeung
Thanks for answering. I resend a patch according to your advices. And I also added the stdio output to the patch as below. If you have time and check the patch I resend, I'd appreciate it. Thanks, Taeung On 10/07/2014 02:26 PM, Namhyung Kim wrote: Hi Taeung, On Sun, 5 Oct 2014 15:

Re: [PATCH v4 4/5] perf config: Add a option 'list-all' to perf-config

2015-08-06 Thread taeung
Hi, Namhyung On 07/27/2015 05:48 PM, Namhyung Kim wrote: On Mon, Jul 27, 2015 at 12:58:30AM +0900, Taeung Song wrote: A option 'list-all' is to display both current config variables and all possible config variables with default values. The syntax examples are like below p

Re: [PATCH 2/4] perf tools: Add functions which can get or set perf config variables.

2015-05-10 Thread taeung
7, 2015 at 03:34:24PM +0900, Taeung Song wrote: This patch consists of functions which can get, set specific config variables. For the syntax examples, perf config [options] [section.subkey[=value] ...] display key-value pairs of specific config variables # perf config report.

[PATCH] perf config : Adding a command 'config' with a option '--list' and a document for it.

2015-03-07 Thread Taeung
p + + # graph (graph absolute), flat, fractal (graph relative) + print-type = fractal + + # caller, callee + order = caller + + # function, address + sort-key = function + +[report] + percent-limit = 1 + children = false + +[top] +

Re: [PATCH v2 4/5] perf mem: Fill in the missing freeing a session after an error occur

2015-06-30 Thread taeung
On 07/01/2015 04:57 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 01, 2015 at 12:18:45AM +0900, Taeung Song escreveu: When an error occur a error value is just returned without freeing the session. So allocating and freeing session have to be matched as a pair even if an error occur

[PATCH] perf session: Fill in the missing freeing a session after an error occur

2015-06-27 Thread taeung
In some cases some sessions aren't freed. For example, a session is allocated and then if an error occur, just a error value is returned without freeing the session. So allocating and freeing session have to be matched as a pair even if an error occur. Signed-off-by: taeung --- tools

[PATCH v7 3/7] perf config: Add default section and item arrays for 'colors' config

2016-07-20 Thread Taeung Song
ui/browser.c because of setting default values of actual variables for 'colors' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 15 +++ tools/perf/util/con

[PATCH v7 2/7] perf config: Add macros assigning key-value pairs to default_config_item

2016-07-20 Thread Taeung Song
: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.h | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 1fd8e4c..613900f 100644 --- a/tools/perf/util/config.h +++ b/tools

[PATCH v7 1/7] perf config: Introduce default_config_section and default_config_item for default config key-value pairs

2016-07-20 Thread Taeung Song
amatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.h | 29 + 1 file changed, 29 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 6f813d4..1fd8e4c 100644 --- a/tools/perf/util/config.h +++ b/too

[RFC PATCH v7 0/7] perf config: Introduce default config key-value pairs arrays

2016-07-20 Thread Taeung Song
noate' section because waiting for other opinions. If you review this patchset, I'd appreciate it :-) Thanks, Taeung v7: - rebased on current acme/perf/core v6: - rename 'fore_back_colors' to simple 'colors' of ui_browser_colorset (Namhyung) - remove unnecss

[PATCH v7 6/7] perf config: Add default section and item arrays for 'annotate' config

2016-07-20 Thread Taeung Song
annoate.c because of setting default values of actual variables for 'annotate' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 11 +++ tools/perf/util/config.h | 11 ++

[PATCH v7 7/7] perf config: Initialize annotate_browser__opts with default config items

2016-07-20 Thread Taeung Song
Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 16 tools/perf/util/config.h | 3 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/perf

[PATCH v7 4/7] perf config: Use combined {fore,back}ground colors value instead of each two color

2016-07-20 Thread Taeung Song
f values (as just one). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 53 +++-- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/too

[PATCH v7 5/7] perf config: Initialize ui_browser__colorsets with default config items

2016-07-20 Thread Taeung Song
Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 31e2028..598f434 10

[RFC][PATCH v9 2/3] perf config: Reimplement perf_config() adding perf_config_init() and perf_config_finish()

2016-06-20 Thread Taeung Song
minate allocated config set perf_config_finish() # destroy existing config set and initialize a new config set. perf_config_refresh() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by:

[PATCH v9 3/3] perf config: Reimplement show_config() using config_set__for_each

2016-06-20 Thread Taeung Song
Lately config_set__for_each is added. In order to let show_config() be short and clear, remake this function using config_set__for_each macro Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-config.c

[REFACTORING][PATCH v9 1/3] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-20 Thread Taeung Song
included previous cache.h need only config.h, remove including cache.h. Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-help.c | 2 +- tools/perf/builtin-kmem.c | 2 +- tools/perf

[RFC][PATCH v9 0/3] perf config: Reimplement perf_config() adding perf_config_init() and perf_config_finish()

2016-06-20 Thread Taeung Song
ive work should be avoided but also in near future, it would be smooth to manage perf configs. If you give me any feedback, I'd apprecicated it. :) Thanks, Taeung v9: - add config_set__for_each macro (Arnaldo) - the source files that only need config.h don't include cache.h (Arnaldo)

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__it to

2016-06-20 Thread Taeung Song
Hi, Arnaldo :-D I also discussed this patchset with Namhyung at offline gathering. I sent v9 patchset that contains what Namhyung and you advice me to do. If having your spare time, please review the v9 patchset. If you do, I'd appreciate it :-) Thanks, Taeung On 06/12/2016 05:57 PM, T

Re: [PATCH v6 RESEND 4/7] perf config: Use combined {fore,back}ground colors value instead of each two color

2016-08-08 Thread Taeung Song
Hi, Arnaldo :) On 08/09/2016 03:58 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 02, 2016 at 06:20:46PM +0900, Taeung Song escreveu: To easily set default config values into actual variables for 'colors' config, it would be better that actual variables for each 'colors' c

Re: [PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

2017-08-18 Thread Taeung Song
Hi Arnaldo, On 08/18/2017 12:16 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 15, 2017 at 05:06:31PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Aug 16, 2017 at 12:13:09AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf

[PATCH v3 0/5] perf annotate: Support --show-nr-samples and circulating view

2017-08-18 Thread Taeung Song
7;d appreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples-v3' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v3: - Add --show-nr-samples option in documentation (Arnaldo) - Add a missing --show-total-period in documentation v2: - pe

[PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

2017-08-18 Thread Taeung Song
Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-annotate.txt | 4 tools/perf/builtin-annotate.c | 2 ++ tools/perf/util

[PATCH v3 3/5] perf annotate: Period and samples view can't be used at the same time

2017-08-18 Thread Taeung Song
If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

2017-08-18 Thread Taeung Song
With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-

[PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

2017-08-18 Thread Taeung Song
Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH v3 2/5] perf annotate: Add a missing period option in documentation

2017-08-18 Thread Taeung Song
Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-annotate.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt index 2a5975c..c635eab 100644 --- a/tools/perf

Re: [PATCH 1/3] perf help: Document missing options

2017-11-13 Thread Taeung Song
key-value pair top.children=true [acme@jouet linux]$ Unsure if this is something that got broken by the 'perf config' patches, Taeung? Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel"). Following patch should fix it: Thanks, Namhyung I als

Re: [PATCH 2/3] perf top: Support call-graph display options also

2015-10-22 Thread Taeung Song
gt; > OK. I'll cook a patch to improve help message like this as well as man page. > > >> >> Also note that I think we should sync up the perf config options to be the >> same as >> the option name shortcuts used in this help text. > > Ah, good id

[PATCH v1] perf report: Fix owner error when reading perf.data

2015-10-01 Thread Taeung Song
If perf.data file is owned by some user, it can't be read even if current user is root. A 'st_uid' from fstat() is user ID of the file owner. Therefore use getuid() instead of st_uid to check if user of the calling 'perf' process is root or not. Signed-off-by: Taeung S

Re: [PATCH v1] perf report: Fix owner error when reading perf.data

2015-10-01 Thread Taeung Song
> On Oct 1, 2015, at 6:10 PM, Ingo Molnar wrote: > > > * Taeung Song wrote: > >> If perf.data file is owned by some user, >> it can't be read even if current user is root. > > That's intentional: to keep a malicious local user from passing a pe

[PATCH v7 0/7] perf tools: Add 'perf-config' command

2015-10-04 Thread Taeung Song
ggest this patchset of the perf-config command which can list, get, set, remove perf configs or list with default config values as below. Taeung Song (7): [PATCH v7 1/7] perf tools: Add 'perf-config' command [PATCH v7 2/7] perf config: Add '--system' and &#

[PATCH v7 7/7] perf config: Add a option 'remove' to perf-config

2015-10-04 Thread Taeung Song
A option 'remove' is to remove specific config variables. For the syntax examples, # perf config [] -r | --remove [section.name ...] Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 + tools/perf/builtin-config.c

[PATCH v7 6/7] perf config: normalize a value depending on default type of it

2015-10-04 Thread Taeung Song
ff-by: Taeung Song --- tools/perf/builtin-config.c | 48 - 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index f034c19..680a655 100644 --- a/tools/perf/builtin-config.c +++ b/tools

[PATCH v7 1/7] perf tools: Add 'perf-config' command

2015-10-04 Thread Taeung Song
x27;perf-config' command with '--list' option and a document for it. perf config [options] display current perf config variables. # perf config or # perf config -l | --list Signed-off-by: Taeung Song --- tools/perf/Build | 1 +

[PATCH v7 2/7] perf config: Add '--system' and '--user' options to select which config file is used

2015-10-04 Thread Taeung Song
config file or both are used, list is required to keep and handle config variables and values. Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 14 ++- tools/perf/builtin-config.c | 163 +-- tools/perf/util/cache.h

[PATCH v7 4/7] perf config: Add 'get' functionality

2015-10-04 Thread Taeung Song
This patch consists of functions which can get specific config variables. For the syntax examples, perf config [] [section.name ...] display key-value pairs of specific config variables # perf config report.queue-size report.children Signed-off-by: Taeung Song --- tools/perf

[PATCH v7 5/7] perf config: Add 'set' feature

2015-10-04 Thread Taeung Song
This patch consists of functions which can set specific config variables. For the syntax examples, perf config [] [options] [section.name[=value] ...] set specific config variables # perf config report.queue-size=100M report.children=true Signed-off-by: Taeung Song --- tools/perf

[PATCH v7 3/7] perf config: Add a option 'list-all' to perf-config

2015-10-04 Thread Taeung Song
A option 'list-all' is to display both current config variables and all possible config variables with default values. The syntax examples are like below perf config [] [options] display all perf config with default values. # perf config -a | --list-all Signed-off-by: T

[PATCH v2 2/2] tools/bpftool: Fix segfault case regarding 'pin' arguments

2018-07-18 Thread Taeung Song
f: add bpftool") Reviewed-by: Jakub Kicinski Reported-by: Taehee Yoo Signed-off-by: Taeung Song --- tools/bpf/bpftool/common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index 32f9e397a6c0..3f140eff039f

[PATCH bpf-next] tools/bpftool: ignore build products

2018-07-24 Thread Taeung Song
For untracked things of tools/bpf, add this. Reviewed-by: Quentin Monnet Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH v2 bpf-next] tools/bpftool: ignore build products

2018-07-24 Thread Taeung Song
For untracked things of tools/bpf, add this. Reviewed-by: Jakub Kicinski Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH] samples/bpf: Add BTF build flags to Makefile

2018-07-25 Thread Taeung Song
To smoothly test BTF supported binary on samples/bpf, let samples/bpf/Makefile probe llc, pahole and llvm-objcopy for BPF support and use them like tools/testing/selftests/bpf/Makefile changed from the commit c0fa1b6c3efc ("bpf: btf: Add BTF tests") Cc: Martin KaFai Lau Signed-off-

[Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

2018-07-25 Thread Taeung Song
bbtf.h), BPF developers would more easily use functionalities based on BTF. What do you think about this ? Do you think this is needed ? Or, already implementing something like this ? If it is needed, I want to try to make 'tools/bpf/bpf_dwarf2btf' based on the pahole code. I'd appreciate it, if you reply to this Thanks, Taeung

Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

2018-07-25 Thread Taeung Song
Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool such as 'tools/bpf/bpf_dwarf2btf&#

Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

2018-07-25 Thread Taeung Song
On 07/26/2018 03:27 AM, Taeung Song wrote: Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Taeung Song
Hi Steven, I found a trivial typo "eee" on the commit log title It seems better to change "lib traceeevent" to " lib traceevent", if you want to do it.. Thanks, Taeung On 01/12/2018 09:47 AM, Steven Rostedt wrote:

[PATCH v2 2/4] samples/bpf: Check the result of system()

2018-07-04 Thread Taeung Song
-off-by: Taeung Song --- samples/bpf/trace_event_user.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/samples/bpf/trace_event_user.c b/samples/bpf/trace_event_user.c index 1fa1becfa641..d08046ab81f0 100644 --- a/samples/bpf/trace_event_user.c

[PATCH v2 0/4] samples/bpf: simple fixes

2018-07-04 Thread Taeung Song
v2: - in error cases, do return; instead of break; in loop Hello, This patchset fixes trivial things that I found when testing 'samples/bpf/' sample code. I'd appreciate it, if you review this. Thanks, Taeung Taeung Song (4): samples/bpf: add missing samples/bpf: Check the r

[PATCH v2 1/4] samples/bpf: add missing

2018-07-04 Thread Taeung Song
struct vlan_hdr' in sample code and include if_vlan.h Signed-off-by: Taeung Song --- samples/bpf/parse_varlen.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/samples/bpf/parse_varlen.c b/samples/bpf/parse_varlen.c index 95c16324760c..0b6f22feb2c9 100644 --- a/sample

[PATCH v2 4/4] samples/bpf: add .gitignore file

2018-07-04 Thread Taeung Song
For untracked executables of samples/bpf, add this. Untracked files: (use "git add ..." to include in what will be committed) samples/bpf/cpustat samples/bpf/fds_example samples/bpf/lathist samples/bpf/load_sock_ops ... Signed-off-by: T

[PATCH 2/2] perf tools: Add options 'get', 'set' and 'unset' to 'perf-config'.

2015-04-04 Thread Taeung Song
Add 'get' option that can show value of a specific config variable and 'set' and 'unset' option that can create or replace a config variable. Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 198 too

[PATCH 1/2] perf tools: Add 'perf-config' command

2015-04-04 Thread Taeung Song
patch adds 'perf-config' command with '--list' option and a document for it. Signed-off-by: Taeung Song --- tools/perf/Build| 1 + tools/perf/Documentation/perf-config.txt| 418 tools/perf/Documentation/perfcon

[PATCH 4/4] perf tools: Add a option 'remove' to perf-config.

2015-04-26 Thread Taeung Song
A option 'remove' is to remove specific config variables. For the syntax examples, # perf config -r | --remove [section.subkey ...] Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 tools/perf/builtin-config.c

[PATCH 1/4] perf tools: Add 'perf-config' command

2015-04-26 Thread Taeung Song
This patch adds 'perf-config' command with '--list' option and a document for it. Signed-off-by: Taeung Song --- tools/perf/Build| 1 + tools/perf/Documentation/perf-config.txt| 436 tools/perf/Documentation/perfcon

[PATCH 2/4] perf tools: Add functions which can get or set perf config variables.

2015-04-26 Thread Taeung Song
variables # perf config report.queue-size=100M report.children=true Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 2 + tools/perf/builtin-config.c | 276 ++- tools/perf/util/cache.h | 17 ++ tools/perf/util

[PATCH 3/4] perf tools: Add a option 'all' to perf-config.

2015-04-26 Thread Taeung Song
ned-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 +++ tools/perf/builtin-config.c | 49 tools/perf/util/PERFCONFIG-DEFAULT | 65 tools/perf/util/cache.h | 1 + tools/perf/uti

[PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.

2015-04-09 Thread Taeung Song
key(section.subkey) and value # perf config report.queue set a specific key and value # perf config report.queue=100M remove a specific key # perf config -r | --remove report.queue Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 8 ++ tools/perf

[PATCH 1/2] perf tools: Add 'perf-config' command

2015-04-09 Thread Taeung Song
patch adds 'perf-config' command with '--all' option and a document for it. Signed-off-by: Taeung Song --- tools/perf/Build| 1 + tools/perf/Documentation/perf-config.txt| 433 tools/perf/Documentation/perfcon

[PATCH 1/2] perf tools: Add 'perf-config' command

2015-04-12 Thread Taeung Song
This patch adds 'perf-config' command with '--all' option and a document for it. Signed-off-by: Taeung Song --- tools/perf/Build| 1 + tools/perf/Documentation/perf-config.txt| 433 tools/perf/Documentation/perfcon

[PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.

2015-04-12 Thread Taeung Song
config report.queue=100M remove a specific key # perf config -r | --remove report.queue Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 8 ++ tools/perf/builtin-config.c | 224 ++- tools/perf/util/cache.h

[PATCH v2 1/4] perf tools: Add 'perf-config' command

2015-05-28 Thread Taeung Song
x27;perf-config' command with '--list' option and a document for it. perf config [options] display current perf config variables. # perf config or # perf config -l | --list Signed-off-by: Taeung Song --- tools/perf/Build| 1 +

[PATCH v2 2/4] perf tools: Add functions which can get or set perf config variables.

2015-05-28 Thread Taeung Song
# perf config report.queue-size=100M report.children=true Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 2 + tools/perf/builtin-config.c | 543 ++- tools/perf/util/cache.h | 17 + tools/perf/util/config.c

[PATCH v2 4/4] perf tools: Add a option 'remove' to perf-config.

2015-05-28 Thread Taeung Song
A option 'remove' is to remove specific config variables. For the syntax examples, # perf config -r | --remove [section.name ...] Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 ++ tools/perf/builtin-config.c | 25 ++

[PATCH v2 3/4] perf tools: Add a option 'list-all' to perf-config.

2015-05-28 Thread Taeung Song
A option 'list-all' is to display both current config variables and all possible config variables with default values. The syntax examples are like below perf config [options] display all perf config with default values. # perf config -a | --list-all Signed-off-by: T

[PATCH] perf tools: modify error code when perf_session__new() fail.

2014-09-23 Thread Taeung Song
Because perf_session__new() could fail for more reasons than just ENOMEM, I modified error code(ENOMEM or EINVAL) into -1. Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 +- tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-evlist.c| 2 +- tools/perf/builtin

[PATCH] perf top: Add a visual cue for toggle zeroing of samples

2014-10-04 Thread Taeung Song
When 'perf top' is run, one can't easily find a difference between -z option and normal output. So I added a visual cue to know whether it is the zeroing or not. Signed-off-by: Taeung Song --- tools/perf/ui/browsers/hists.c | 38 ++ 1 f

[PATCH] perf top: Add a visual cue for toggle zeroing of samples

2014-10-04 Thread Taeung Song
When 'perf top' is run, one can't easily find a difference between -z option and normal output. So I added a visual cue to know whether it is the zeroing or not. Signed-off-by: Taeung Song --- tools/perf/PERF-FEATURES | 1 + tools/perf/ui/browse

[PATCH] perf top: Add a visual cue for toggle zeroing of samples

2014-10-04 Thread Taeung Song
When 'perf top' is run, one can't easily find a difference between -z option and normal output. So I added a visual cue to know whether it is the zeroing or not. Signed-off-by: Taeung Song --- tools/perf/ui/browsers/hists.c | 34 -- 1 file changed

[PATCH resend] perf top: Add a visual cue for toggle zeroing of samples

2014-10-07 Thread Taeung Song
below. After: Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z] Overhead Shared Object Symbol 1.42% firefox [.] 0x00011e76 1.32% libpthread-2.17.so [.] pthread_mutex_lock Signed-off-by

[PATCH v4 0/5] perf tools: Add 'perf-config' command

2015-07-26 Thread Taeung Song
So far, it is difficult that the state of perf configs is looked through and there's no knowing what kind of other variables except variables in perfconfig.example. Also perf configs can't be changed without manually modifying $HOME/.perfconfig or $(sysconfdir)/perfconfig file. So I suggest this

[PATCH v4 1/5] perf tools: Add 'perf-config' command

2015-07-26 Thread Taeung Song
x27;perf-config' command with '--list' option and a document for it. perf config [options] display current perf config variables. # perf config or # perf config -l | --list Signed-off-by: Taeung Song --- tools/perf/Build| 1 +

[PATCH v4 4/5] perf config: Add a option 'list-all' to perf-config

2015-07-26 Thread Taeung Song
A option 'list-all' is to display both current config variables and all possible config variables with default values. The syntax examples are like below perf config [options] display all perf config with default values. # perf config -a | --list-all Signed-off-by: T

[PATCH v4 3/5] perf config: Add functions which can get or set perf config variables

2015-07-26 Thread Taeung Song
# perf config report.queue-size=100M report.children=true Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 2 + tools/perf/builtin-config.c | 560 ++- tools/perf/util/cache.h | 17 + tools/perf/util/config.c

[PATCH v4 5/5] perf config: Add a option 'remove' to perf-config

2015-07-26 Thread Taeung Song
A option 'remove' is to remove specific config variables. For the syntax examples, # perf config -r | --remove [section.name ...] Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 ++ tools/perf/builtin-config.c | 25 ++

[PATCH v4 2/5] perf config: Add '--system' and '--global' options to select which config file is used

2015-07-26 Thread Taeung Song
fault config file path is $HOME/.perfconfig. Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 14 +- tools/perf/builtin-config.c | 21 ++--- tools/perf/util/cache.h | 2 ++ tools/perf/util/config.c |

[PATCH v5 0/6] perf tools: Add 'perf-config' command

2015-08-17 Thread Taeung Song
So far, it is difficult that the state of perf configs is looked through and there's no knowing what kind of other variables except variables in perfconfig.example. Also perf configs can't be changed without manually modifying $HOME/.perfconfig or $(sysconfdir)/perfconfig file. So I suggest this

[PATCH v5 1/6] perf tools: Add 'perf-config' command

2015-08-17 Thread Taeung Song
x27;perf-config' command with '--list' option and a document for it. perf config [options] display current perf config variables. # perf config or # perf config -l | --list Signed-off-by: Taeung Song --- tools/perf/Build| 1 +

[PATCH v5 3/6] perf config: Add a option 'list-all' to perf-config

2015-08-17 Thread Taeung Song
A option 'list-all' is to display both current config variables and all possible config variables with default values. The syntax examples are like below perf config [options] display all perf config with default values. # perf config -a | --list-all Signed-off-by: T

[PATCH v5 6/6] perf config: Add a option 'remove' to perf-config

2015-08-17 Thread Taeung Song
A option 'remove' is to remove specific config variables. For the syntax examples, # perf config -r | --remove [section.name ...] Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 ++ tools/perf/builtin-config.c | 26 +++

[PATCH v5 4/6] perf config: Add 'get' functionality

2015-08-17 Thread Taeung Song
This patch consists of functions which can get specific config variables. For the syntax examples, perf config [options] [section.name ...] display key-value pairs of specific config variables # perf config report.queue-size report.children Signed-off-by: Taeung Song --- tools/perf

[PATCH v5 2/6] perf config: Add '--system' and '--user' options to select which config file is used

2015-08-17 Thread Taeung Song
config file path is $HOME/.perfconfig. Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 14 +- tools/perf/builtin-config.c | 23 +-- tools/perf/util/cache.h | 2 ++ tools/perf/util/config.c |

[PATCH v5 5/6] perf config: Add 'set' feature

2015-08-17 Thread Taeung Song
This patch consists of functions which can set specific config variables. For the syntax examples, perf config [options] [section.name[=value] ...] set specific config variables # perf config report.queue-size=100M report.children=true Signed-off-by: Taeung Song --- tools/perf

[PATCH v8 1/4] perf config: Introduce perf_config_set class

2016-04-14 Thread Taeung Song
m Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 173 +++ tools/perf/util/config.h | 26 +++ 2 files changed, 199 insertions(+) create mode 100644 tools/perf/util/config.h diff --git a/tools/perf/util/config.c b/tools

[PATCH v8 4/4] perf config: Initialize perf_config_set with all default configs

2016-04-14 Thread Taeung Song
correct type of a config variable in the near future. Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 11 +++ tools/perf/util/config.c| 39 ++- tools/perf/util/config.h| 7

[PATCH v8 2/4] perf config: Let show_config() work with perf_config_set

2016-04-14 Thread Taeung Song
config --user --list top.children=false # perf config --system --list top.children=true # perf config --list top.children=false Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 39

[RFC][PATCH v8 0/4] Infrastructure code for perf-config

2016-04-14 Thread Taeung Song
this infrastructure code is needed to add new funcationalities for config management of perf-config. If anyone reviews this, I'd appreciate it. Thanks, Taeung v8: - rebased onto the current acme/perf/core v7: - rename 'is_custom' to 'is_allocated' to be proper (Masami)

[PATCH v8 3/4] perf config: Prepare all default configs

2016-04-14 Thread Taeung Song
ed-by: Namhyung Kim Cc: Masami Hiramatsu Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 110 ++- tools/perf/util/config.h | 62 +- 2 files changed, 168 insertions(+), 4 deletions(-) diff --git a/tools/perf

Re: [PATCH v8 3/4] perf config: Prepare all default configs

2016-04-14 Thread Taeung Song
Hi, Arnaldo On 04/14/2016 09:19 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Apr 14, 2016 at 04:53:20PM +0900, Taeung Song escreveu: To precisely manage configs, prepare all default perf's configs that contain default section name, variable name, value and correct type, not string type. I

[PATCH 0/4] perf config: Introduce default config key-value pairs arrays

2016-05-09 Thread Taeung Song
alue 'true'. IMHO, I think it should be needed to use new default config arrays to manage default perf config values more effectively. And this pathset contains patchs for only 'colors' and 'annoate' section because waiting for other opinions. If you review this patchset,

[PATCH 1/4] perf config: Introduce default_config_item for all default config key-value pairs

2016-05-09 Thread Taeung Song
: Namhyung Kim Cc: Masami Hiramatsu Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 150 ++- tools/perf/util/config.h | 46 ++- 2 files changed, 194 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b

[PATCH 3/4] perf config: Initialize ui_browser__colorsets with default config items

2016-05-09 Thread Taeung Song
Set default config values for 'colors' section with 'colors_config_items[]' instead of actual const char * type values. (e.g. using colors_config_item[CONFIG_COLORS_TOP].value instead of "red, default" string value for 'colors.top') Cc: Namhyung Kim C

[PATCH 2/4] perf tools: Separate out code setting ground colors from ui_browser__color_config

2016-05-09 Thread Taeung Song
ui_browser__color_config() set foreground and background colors values in ui_browser__colorsets. But it can be reused by other functions so make ui_browser__config_gcolors() bringing it from ui_browser__color_config(). Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf

[PATCH 4/4] perf config: Initialize annotate_browser__opts with default config items

2016-05-09 Thread Taeung Song
mhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 12 tools/perf/util/config.h | 16 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annota

[PATCH v11 1/1] perf config: Prepare all default configs

2016-05-04 Thread Taeung Song
iable with the default_config_item arrays and etc. Cc: Namhyung Kim Cc: Masami Hiramatsu Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 150 ++- tools/perf/util/config.h | 46 ++- 2 files changed, 194 insertions(

[PATCH v11 0/1] Infrastructure code for perf-config

2016-05-04 Thread Taeung Song
this infrastructure code is needed to add new funcationalities for config management of perf-config. If anyone reviews this, I'd appreciate it. Thanks, Taeung v11: - don't initialize perf_config_set with all default configs and remove the patch for it. - add struct default_config_ite

Re: [PATCH 2/4] perf tools: Separate out code setting ground colors from ui_browser__color_config

2016-05-10 Thread Taeung Song
Hi, Arnaldo :) On 05/10/2016 02:17 AM, Arnaldo Carvalho de Melo wrote: Em Mon, May 09, 2016 at 08:41:47PM +0900, Taeung Song escreveu: ui_browser__color_config() set foreground and background colors values in ui_browser__colorsets. "ground colors" sounds strange, I guess referrei

  1   2   3   4   5   6   7   8   9   >