Actual variable for configs of 'annotate' section is like below. (at ui/browsers/annoate.c) static struct annotate_browser_opt { bool hide_src_code, use_offset, jump_arrows, show_linenr, show_nr_jumps, show_total_period; } annotate_browser__opts = { .use_offset = true, .jump_arrows = true, };
But I suggest using default config arrays for 'annotate' section that contain all default config key-value pairs for it. In near future, this arrays will be used on ui/browsers/annoate.c because of setting default values of actual variables for 'annotate' config. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Wang Nan <wangn...@huawei.com> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/util/config.c | 11 +++++++++++ tools/perf/util/config.h | 11 +++++++++++ 2 files changed, 22 insertions(+) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index a0c0170..d8d5415 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -41,8 +41,19 @@ const struct default_config_item colors_config_items[] = { CONF_END() }; +const struct default_config_item annotate_config_items[] = { + CONF_BOOL_VAR("hide_src_code", false), + CONF_BOOL_VAR("use_offset", true), + CONF_BOOL_VAR("jump_arrows", true), + CONF_BOOL_VAR("show_nr_jumps", false), + CONF_BOOL_VAR("show_linenr", false), + CONF_BOOL_VAR("show_total_period", false), + CONF_END() +}; + const struct default_config_section default_sections[] = { { .name = "colors", .items = colors_config_items }, + { .name = "annotate", .items = annotate_config_items }, }; static int get_next_char(void) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index b9190fe..2fcfd51 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h @@ -75,6 +75,7 @@ enum perf_config_type { enum config_section_idx { CONFIG_COLORS, + CONFIG_ANNOTATE, }; enum colors_config_items_idx { @@ -87,6 +88,15 @@ enum colors_config_items_idx { CONFIG_COLORS_ROOT, }; +enum annotate_config_items_idx { + CONFIG_ANNOTATE_HIDE_SRC_CODE, + CONFIG_ANNOTATE_USE_OFFSET, + CONFIG_ANNOTATE_JUMP_ARROWS, + CONFIG_ANNOTATE_SHOW_NR_JUMPS, + CONFIG_ANNOTATE_SHOW_LINENR, + CONFIG_ANNOTATE_SHOW_TOTAL_PERIOD, +}; + struct default_config_item { const char *name; union { @@ -128,5 +138,6 @@ struct default_config_section { extern const struct default_config_section default_sections[]; extern const struct default_config_item colors_config_items[]; +extern const struct default_config_item annotate_config_items[]; #endif /* __PERF_CONFIG_H */ -- 2.5.0