>From d2be88406fdc1d28a7cf0b1a13ca761d625820a5 Mon Sep 17 00:00:00 2001
From: Denis Cheng <[EMAIL PROTECTED]>
Date: Fri, 4 Jan 2008 14:50:54 +0800
Subject: [PATCH] PROC_FS: get and set the smp affinity of tasks by
read-write /proc//smp_affinity
this adds a read-write /proc//smp_affinity entry,
jus
On Jan 10, 2008 8:33 AM, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Fri, 4 Jan 2008 15:03:41 +0800
> Denis Cheng <[EMAIL PROTECTED]> wrote:
>
> > this adds a read-write /proc//smp_affinity entry,
> > just like what /proc/irq//smp_affinity does,
> > so now we can get and set the affinity of task
From: Denis Cheng <[EMAIL PROTECTED]>
Date: Sat, 19 Jan 2008 13:29:51 +0800
Subject: [PATCH] kernel/params.c: fix the module name length in
param_sysfs_builtin
the original code use KOBJ_NAME_LEN for built-in module name length,
that's defined to 20 in linux/kobject.h, but this is not enough appea
On Jan 23, 2008 7:13 AM, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
> But nf..dada_compat.c gets linked into nf_conntrack_ipv4.ko,
> and that is what is used in /sys/module - and it fits the 20.
> Any place where nf_conntrack_l3proto_ipv4_compat would still be used?
there is a module named nf_conntr
On Nov 29, 2007 7:13 PM, Herbert Xu <[EMAIL PROTECTED]> wrote:
...
> > uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes
> > down to 19,701.
> >
> > inlining is almost always wrong.
>
> I agree. Please do as Andrew suggests and resubmit.
inline disabled.
Cc: Randy Dunlap
---
and I still have questions about this code:
1. Why here kern_mount is needed?
Or the first time user space `mount -t sysfs` won't do that?
2. If root executes many mounts to mount sysfs on /sys and many other places,
are there many instances of struct vfsmount those have only
mn
On Dec 2, 2007 12:48 PM, Greg KH <[EMAIL PROTECTED]> wrote:
...
> > and where is a detailed explaination on kern_mount? could someone give
> > some comments or documentation pointers on this?
>
> See the patches that Eric Biederman just posted to lkml for why this
> structure is a static pointer th
On Nov 26, 2007 3:41 PM, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-11-26 at 15:16 +0800, Denis Cheng wrote:
> > diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
> > index 8d0244c..8f3fc1d 100644
> > --- a/drivers/scsi/ide-scsi.c
> > +++ b/drivers/scsi/ide-scsi.c
> > @@ -28
On Nov 27, 2007 10:58 AM, Richard Knutsson <[EMAIL PROTECTED]> wrote:
...
> > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
> > + 16, 1,
> > + buf, len, 0);
> >
> Not important, but why use '0' instead of 'false'?
after read http://lkml.org/lkml/200
hello, Rusty:
I encountered a problem when modules compiled built-in with bzImage:
open-iscsi is an iSCSI software, it has a userspace daemon(iscsid) and
a userspace mani tool(iscsiadm) and a kernel module
(scsi_transport_iscsi),
recently the kernel module has been accepted into the official kerne
On Jan 16, 2008 8:25 PM, Rusty Russell <[EMAIL PROTECTED]> wrote:
> I'd love to see patches. module_parm showed it's possible, if messy.
>
> Thanks!
> Rusty.
here's the patch, I added .modinfo section to the vmlinux, to collect
built-in module information.
I have just define __MODULE_INFO to ano
On 10/3/07, Rusty Russell <[EMAIL PROTECTED]> wrote:
> Proposed updates for version 2.07 of the boot protocol. This includes:
>
...
> Signed-off-by: Jeremy Fitzhardinge < [EMAIL PROTECTED]>
> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
> Cc: "Eric W. Biederman" < [EMAIL PROTECTED]>
> Cc: H. P
On 10/31/07, Greg KH <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 31, 2007 at 06:34:20PM +0800, Denis Cheng wrote:
> > this is especially useful after /sys/slab introduced, for example:
> >
> > $ ls -l /sys/slab/mm_struct
> > lrwxrwxrwx 1 root root 0 2007-10-31 17:40 /sys/slab/mm_struct -> :448
> >
On 7/20/07, Paul Clements <[EMAIL PROTECTED]> wrote:
Denis Cheng wrote:
> this memcpy looks so strange, in fact it's merely a pointer dereference,
> so I change the parameter's type to refer it more directly,
> this could make the memcpy not needed anymore.
>
> in the function nbd_read_stat where
On 7/18/07, Denis Cheng <[EMAIL PROTECTED]> wrote:
- removed three function declarations from header file to mark them static,
- reduced one file
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
this one is just merging by concatenating, and I'll try to adjust some
function definitions' order
On 7/20/07, David Miller <[EMAIL PROTECTED]> wrote:
Please don't quote a big huge patch just to say one sentence that
doesn't apply to any particular specific part of a patch.
That's wastes bandwidth, annoys people you might actually want
a response from, and is bad netiquette in general.
Thank
On 7/20/07, Dave Young <[EMAIL PROTECTED]> wrote:
> - if (page && zeroing && count < PAGE_SIZE) {
> - void *mapaddr = kmap_atomic(page, KM_USER1);
> - memset(mapaddr, 0, PAGE_SIZE);
> - kunmap_atomic(mapaddr, KM_USER1);
> - }
> + if (pag
On 7/21/07, Simon Arlott <[EMAIL PROTECTED]> wrote:
Changing the code to fix a utility bug is madness. I think it's been
fixed too...
Now I also think it's the utility's bug, that hardly do nothing on
indent the source.
--
Denis Cheng
Linux Application Developer
"One of my most productive days
Why alloc_super use a static variable default_op?
the static struct super_operations default_op is just all zeros, and
just referenced as the initial value of a new allocated super_block,
what does it for?
the filesystem dependent code such as ext2_fill_super would fill this
field eventually,
and
On 7/25/07, Al Viro <[EMAIL PROTECTED]> wrote:
On Wed, Jul 25, 2007 at 11:48:35AM +0800, rae l wrote:
> Why alloc_super use a static variable default_op?
> the static struct super_operations default_op is just all zeros, and
> just referenced as the initial value of a new alloca
On 7/25/07, Al Viro <[EMAIL PROTECTED]> wrote:
On Wed, Jul 25, 2007 at 12:29:17PM +0800, rae l wrote:
> But is it valuable? Compared to a waste of sizeof(struct super_block)
> bytes memory.
It's less that struct super_block, actually.
> When some code want to refer fs_t
On 9/2/07, David Newall <[EMAIL PROTECTED]> wrote:
> Denis Cheng wrote
> > + order = get_bitmask_order(min(max, (unsigned long)UINT_MAX)) - 1;
> >
>
> Why doesn't this clash with the max define, also in linux/kernel.h?
They indeed don't clash,
the cpp included by gcc is intelligent enough, it k
On 9/2/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> On Sun, 2 Sep 2007, Denis Cheng wrote:
>
> > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
> > ---
> > net/ipv4/af_inet.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_
On 7/31/07, Steven Whitehouse <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On Tue, 2007-07-31 at 13:46 +0800, Denis Cheng wrote:
> > these struct *_operations are all method tables, thus should be const.
> >
> > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
> > ---
> > fs/gfs2/eaops.c|8 -
On 8/1/07, Gabriel C <[EMAIL PROTECTED]> wrote:
> I thought the same but ... see
>
> http://marc.info/?l=linux-kernel&m=118440958516205&w=2
> http://marc.info/?l=linux-netdev&m=118442747709230&w=2
That sounds good. Thanks.
--
Denis
-
To unsubscribe from this list: send the line "unsubscribe linux-
On 8/13/07, Denis Cheng <[EMAIL PROTECTED]> wrote:
> the original code could work, but I think this code could work better.
>
> Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
> ---
> fs/gfs2/ops_fstype.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/ops_fs
On 8/16/07, Steven Whitehouse <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On Thu, 2007-08-16 at 16:20 +0800, 程任全 wrote:
> > It seems that gfs2 cannot work well with Samba,
> >
> > I'm using the gfs2 and the new cluster suite(cman with openais),
> >
> > 1. the testing environment is that 1 iscsi target and
On 6/19/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
Denis Cheng wrote:
> From: Denis Cheng <[EMAIL PROTECTED]>
>
> the explicit memset call could be optimized out by data initialization,
> thus all the fill working can be done by the compiler implicitly.
>
How does the generated code chan
On 6/23/07, Oleg Verych <[EMAIL PROTECTED]> wrote:
Why not just show actual objdump output on code (maybe with different
oxygen atoms used in gcc), rather than *talking* about optimization and
standards, hm?
here is the objdump output of the two object files:
As you could see, the older one used
On 7/13/07, Kirill Korotaev <[EMAIL PROTECTED]> wrote:
This doesn't look worth zeroing half of the struct
when it is initialized to non-zeros then.
But why?
My reason to think it's better and faster is that:
1. the code will be shorter if it calls zalloc and then removes the
NULL and zero initi
it makes sense to what it does.
On 5/28/07, Matthias Kaehlcke <[EMAIL PROTECTED]> wrote:
Use list_for_each_entry() instead of list_for_each() in the block
device elevator
Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
--
diff --git a/block/elevator.c b/block/elevator.c
index ce866eb..47
From: Denis Cheng
thus the definition of dst_discard_in and dst_discard_out is the same,
we can define a dst_discard function and map the _in and _out to it,
this can reduce space in vmlinux.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
diff --git a/net/core/dst.c b/net/core/dst.c
index 7
On 5/28/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
Uhm, just replace every invocation of dst_discard_in/_out() directly
by dst_discard ... don't add macros for that.
so that, the trival patch changed to this:
because the definition of dst_discard_in and dst_discard_out are the
same, so they
On 5/28/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
Uhm, just replace every invocation of dst_discard_in/_out() directly
by dst_discard ... don't add macros for that.
merge dst_discard in & out into one, this removed a duplicate function.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
I
On 5/31/07, David Miller <[EMAIL PROTECTED]> wrote:
Your email client has changed all of the tab characters into spaces,
corrupting the patch.
Please configure your email client to not perform any text formatting.
Please test this, by emailing the patch to yourself and trying to
apply it, befo
On 7/18/07, David Miller <[EMAIL PROTECTED]> wrote:
From: Denis Cheng <[EMAIL PROTECTED]>
Date: Wed, 18 Jul 2007 10:41:03 +0800
> Because this function is only called by unregister_netdevice,
> this moving could make this non-global function static,
> and also remove its declaration in netdevice
On 7/18/07, Patrick McHardy <[EMAIL PROTECTED]> wrote:
This could be done in the patch moving it .. anyways,
What?
Denis Cheng wrote:
> +#ifdef CONFIG_PROC_FS
> +static void *dev_mc_seq_start(struct seq_file *seq, loff_t *pos)
If you're interested in doing more work, it would be nice to
ge
On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote:
Could you name "n" as "tmp" (as in the previous code) so that it's clear
that's only a temporary variable. Other than that, this looks good.
Sure. I just use the name "n" as in the declaration of
list_for_each_entry_safe in the header file
I'
On 7/19/07, rae l <[EMAIL PROTECTED]> wrote:
On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote:
> Could you name "n" as "tmp" (as in the previous code) so that it's clear
> that's only a temporary variable. Other than that, this looks good.
Sur
On 6/2/07, Denis Cheng <[EMAIL PROTECTED]> wrote:
they should merged into one
this patch I have checked, it's not corrupted, I wonder someone can
give some comment on this?
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
net/core/dst.c | 17 -
1 files changed, 4 insertio
On 6/6/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Tue, 5 Jun 2007 16:58:57 -0400 (EDT)
"Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
> Replace a couple calls to __get_free_pages() with the corresponding
> calls to __get_dma_pages().
>
> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
>
from this address, I know util-linux-2.12r is the latest:
http://www.kernel.org/pub/linux/utils/util-linux/util-linux-2.12r.lsm
My Dell OptiPlex 320 has 4 HPET timers and no RTC, so the execution of
hwclock has errors:
[EMAIL PROTECTED] ~ $ /sbin/hwclock --show
select() to /dev/rtc to wait for c
On 7/3/07, Luca Tettamanti <[EMAIL PROTECTED]> wrote:
rae l <[EMAIL PROTECTED]> ha scritto:
> from this address, I know util-linux-2.12r is the latest:
> http://www.kernel.org/pub/linux/utils/util-linux/util-linux-2.12r.lsm
>
> My Dell OptiPlex 320 has 4 HPET timers and
On 9/17/07, David Miller <[EMAIL PROTECTED]> wrote:
> From: Denis Cheng <[EMAIL PROTECTED]>
> Date: Sun, 2 Sep 2007 03:45:58 +0800
>
> > with the macro max provided by , so changed its name to a
> > more proper one: limit
> >
> > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
>
> Not strictly nec
On 9/17/07, David Miller <[EMAIL PROTECTED]> wrote:
> From: Denis Cheng <[EMAIL PROTECTED]>
> Date: Sun, 2 Sep 2007 18:30:17 +0800
>
> > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
>
> You already submitted the net/ipv4/af_inet.c case
> seperately, so I had to remove it from this patch for
> it
On 8/17/07, Steven Whitehouse <[EMAIL PROTECTED]> wrote:
...
> > the stack trace of the 'D' state `ls`:
> >
> > ===
> > lsD F89B83F8 2200 12018 1 (NOTLB)
> >f3eeadd4 0082 f6a425c0 f89b83f8 f3eead9c f6a425d4 f6f32d80
> > f573a93c
> >0001000
46 matches
Mail list logo
