r really reporting a DIMM problem or a race condition in
the kernel code handling ECC?
Thanks,
Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Plea
we can clamp window scaling per route.
Something
like the below
ip r a
Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
to this as I've tested the patch, but I'm not
sure if any current kernel developers are following this bug... should I
open a new bug, as I can't change the status from REJECTED/INSUFFICIENT
DATA?
I'm not on list, so a cc on replies would be greatly appreciated
Thanks,
Ph
but on a HPPA (PARISC) box with 32bit kernel.
> Just reported at the parisc-linux kernel mailing list as well:
> http://lists.parisc-linux.org/pipermail/parisc-linux/2006-December/030810.html
Please read the mailing list archives...this has been covered
a number of times in the past few days.
ir use of __attribute__((packed)) to
avoid a gcc warning to review what they have done, especially if they
have tested it only on x86.
Thanks for your attention, and please forgive me if you all know all
this already!
Regards,
Phil.
(You are welcome to cc: me with any replies.)
-
To unsubscribe
Frederik Deweerdt wrote:
On Wed, Dec 06, 2006 at 01:20:41PM +, Phil Endecott wrote:
I used to think that this:
struct foo {
int a __attribute__((packed));
char b __attribute__((packed));
... more fields, all packed ...
};
was exactly the same as this:
struct foo {
int a;
char
Jan Blunck wrote:
On 12/6/06, Phil Endecott <[EMAIL PROTECTED]> wrote:
I used to think that this:
struct foo {
int a __attribute__((packed));
char b __attribute__((packed));
... more fields, all packed ...
};
was exactly the same as this:
struct foo {
int a;
.4byte 5
.space 3
.global w2
.align 2
.type w2, %object
.size w2, 16
w2:
.byte 1
.byte 2
.4byte 3
.byte 4
.space 3
.4byte 5
.space 2
Phil.
-
To unsubscribe from this list: send the lin
Getting an oops on boot here, caused by commit
e81c73596704793e73e6dbb478f41686f15a4b34 titled
"[NET]: Fix MAX_HEADER setting".
Reverting that patch fixes things up for me. Dave?
Phil
Bringing up interface eth0:
skb_over_panic: text:c02af809 len:56 put:16 head:d7e213c0
dat
t but I don't see any actual users
of it yet... I need something like it for my distributed DMA driver,
hence the interest.
Cheers
Phil
> + interrupt-parent = <&mpic>;
> + /* err_irq bell_outb_irq bell_inb_irq
l.org/pub/linux/kernel/v2.6/ChangeLog-2.6.X
where X is decremented from current rev is handy. Please keep them around.
Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel
/dev/md0 --run \
/dev/sda1 /dev/sdb1 missing /dev/sdd1
I don't know if using --create has already trashed your array,
but this is worth a try. You may also want to try --force with
the above.
HTH,
Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-ke
On Wed, May 30, 2007 at 05:50:28PM -0400, Dave Jones wrote:
> On Wed, May 23, 2007 at 06:39:24PM -0400, Ben Collins wrote:
> > Various unusual dev entries accumulated from Ubuntu bug reports.
> >
> > CC: Phil Dibowitz <[EMAIL PROTECTED]>
> > CC: Alan Stern &l
7;ll notify them, and if we can't get them to fix it, blacklist them. We have
more fixed sites than blacklisted sites, so it's at least somewhat successful.
--
Phil Dibowitz [EMAIL PROTECTED]
Open Source software and tech docsInsanity Palace of Metallica
On Mon, Jul 02, 2007 at 09:16:57PM +0200, Krzysztof Oledzki wrote:
>
>
> On Mon, 2 Jul 2007, Phil Dibowitz wrote:
>
>> On Mon, Jul 02, 2007 at 07:04:12PM +0200, Andreas Steinmetz wrote:
>>> Jan Engelhardt wrote:
>>>> Do you really need clampin
Ben Collins wrote:
> Various unusual dev entries accumulated from Ubuntu bug reports.
>
> CC: Phil Dibowitz <[EMAIL PROTECTED]>
NACK. Two fixes I'd like to see fixed.
> +/* SanDisk that has a second LUN for a driver ISO, reported by
> + * Ben Collins <[EMAIL
uhci_hcd:usb2
I do not know if this is a bios problem on this motherboard,
a problem in the r1000 and r8169 drivers for the Realtek nic,
or a problem in the ide drivers that drive the cdrom.
Thanks for any help or clues.
Phil Kaslo
Dept. of Computer Science 520-621/2760
University of Arizo
It is a pata cd drive, attached to the JMicron controller.
I'll look into whether the usb ports power off on shutdown.
Thanks,
Phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordom
On Sat, Apr 28, 2007 at 10:38:45PM +0200, Alessandro Suardi wrote:
> skb_set_timestamp I can figure out, but the rest is a bit
> too hard for me... if anyone has already an idea of how
> to fix this, I'd be most grateful.
Did you ask Cisco?
Phil
-
To unsubscribe from this list:
The 'break' statement after calling ad5933_cmd only breaks out of the
'for' loop, which then unconditionally sets the return value to -EINVAL.
Move the initialisation of 'ret' so we return the correct value.
Signed-off-by: Phil Turnbull
---
drivers/staging/iio/i
ceph_llseek does not correctly return NXIO errors because the 'out' path
always returns 'offset'.
Fixes: 06222e491e66 ("fs: handle SEEK_HOLE/SEEK_DATA properly in all fs's that
define their own llseek")
Signed-off-by: Phil Turnbull
---
fs/ceph/file.c |
y_cycle
0 100 PWM active with 100% duty cycle (constant HIGH)
1 99 PWM active with near full duty cycle
...
991 PWM active with near ZERO duty cycle
1000 PWM disabled => constant LOW
pwm_backlight_power_off() disables the regulator.
So the supply to Backlight disappears, regardless of constant low...
--
Regards
Phil Reid
G'day Peter,
Thanks for the feedback.
+linux-kernel@vger.kernel.org
On 27/07/2016 13:32, Peter Rosin wrote:
On 2016-07-27 05:05, Phil Reid wrote:
The pca9543 can aggregate multiple interrupts from each i2c bus.
However it provides no ability to mask interrupts on each channel.
So if on
On 29/07/2016 13:48, Peter Rosin wrote:
On 2016-07-28 04:44, Phil Reid wrote:
G'day Peter,
Thanks for the feedback.
+linux-kernel@vger.kernel.org
On 27/07/2016 13:32, Peter Rosin wrote:
On 2016-07-27 05:05, Phil Reid wrote:
+static void pca954x_irq_mask(struct irq_data *
On 1/08/2016 16:22, Peter Rosin wrote:
On 2016-08-01 08:25, Phil Reid wrote:
On 29/07/2016 13:48, Peter Rosin wrote:
Ok, I think I get the problem, but I too am at a loss and see no elegant
solution.
One sad thing about your workaround is that it is not working at all unless
there
is an irq
f-by: Colin Ian King
Patch applied.
G'day Linus,
I believe this does the same as Arnd Bergmanns patch from 26 Aug.
[PATCH 1/5] gpio: pca954x: fix undefined error code from remove
IMO Colin's is the cleaner solution.
Arnd's could be removed.
--
Regards
Phil Reid
The check for writing more than cb_max_size bytes does not 'goto out' so
it is a no-op which allows users to vmalloc an arbitrary amount.
Fixes: 03607ace807b ("configfs: implement binary attributes")
Signed-off-by: Phil Turnbull
---
fs/configfs/file.c | 1 +
1 file changed,
ulator and enable it")
Cc: Phil Reid
---
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-g...@vger.kernel.org
drivers/gpio/gpio-pca953x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index cbe2824461eb..b9d31d737dbf
On 19/06/2017 22:13, Florian Fainelli wrote:
> On 06/14/2017 09:29 AM, Phil Elwell wrote:
>> Devices in the BCM2835 AUX block share a common interrupt line, with a
>> register indicating which devices have active IRQs. Expose this as a
>> nested interrupt controller to avoid
l initialisation then the normal retrying of
a deferred probe would also avoid this problem.
3. Would adding the OF_CLK_DECLARE hook prevent the use of the devm_ managed
functions like devm_kzalloc? If not, why doesn't fixed-factor-clock use it?
Thank you for your time,
Phil
cy. In practice,
the combined effect of the two patches is to choose OSC as a source if
an integer divisor can be used, otherwise PLLD_PER is chosen.
Phil Elwell (2):
clk: bcm2835: Limit PCM clock to OSC and PLLD_PER
clk: bcm2835: Minimise clock jitter for PCM clock
drivers/clk/bcm/clk
-off-by: Phil Elwell
---
drivers/clk/bcm/clk-bcm2835.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 0258538..facc346 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -1511,6
jitter. The metric is the ideal rate minus the
worse deviation from that ideal using the nearest integer divisors.
Use this metric for parent selection for clocks requiring low jitter
(currently just PCM).
Signed-off-by: Phil Elwell
---
drivers/clk/bcm/clk-bcm2835.c | 39
/msg191947.html
Cleans up the smbus_alert driver a bit.
note: alert_edge_triggered was removed.
And for OF systems core creates the ara device.
--
Regards
Phil Reid
ecks lan9303_handle_reset() return value.
Probably should be checking lan9303_probe_reset_gpio() instead.
--
Regards
Phil Reid
Replaces Pan Bian patch
"net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional"
Errors need to be prograted back from probe.
Note: I have only compile tested the code as I don't have the hardware.
Phil Reid (2):
net: dsa: lan9303: make lan9303_handle
lan9303_handle_reset never returns anything other than success.
So there's not need for it to return an error code.
Signed-off-by: Phil Reid
---
drivers/net/dsa/lan9303-core.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dsa/lan9303-core.c b/dr
devm_gpiod_get_optional() can return an error in addition to a NULL ptr.
Check for error and propagate that to the probe function. Check return
value in probe. This will now handle EPROBE_DEFER for the reset gpio.
Signed-off-by: Phil Reid
---
drivers/net/dsa/lan9303-core.c | 13 ++---
1
This should fix for soft lockup bugs triggered on slow systems.
Signed-off-by: Phil Sutter
---
lib/test_rhashtable.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 8c1ad1c..63654e3 100644
--- a/lib/test_rhashtable.c
+++ b/lib
: Phil Sutter
---
lib/test_rhashtable.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 63654e3..093cf84 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -244,7 +244,7 @@ static int thread_lookup_test
exact number of objects upon table init won't
suffice as that value is being rounded down to the next power of two -
anticipate this by rounding up to the next power of two in beforehand.
Signed-off-by: Phil Sutter
---
lib/test_rhashtable.c | 8 +---
1 file changed, 5 insertions(
On Fri, Aug 28, 2015 at 01:09:29PM +0200, Thomas Graf wrote:
> On 08/28/15 at 12:28pm, Phil Sutter wrote:
> > After adding cond_resched() calls to threadfunc(), a surprisingly high
> > rate of insert failures occurred probably due to table resizes getting a
> > better chance
On Fri, Aug 28, 2015 at 01:13:20PM +0200, Phil Sutter wrote:
> On Fri, Aug 28, 2015 at 01:09:29PM +0200, Thomas Graf wrote:
> > On 08/28/15 at 12:28pm, Phil Sutter wrote:
> > > After adding cond_resched() calls to threadfunc(), a surprisingly high
> > > rate of insert
On Sat, Aug 29, 2015 at 12:43:03AM +0200, Thomas Graf wrote:
> On 08/28/15 at 03:34pm, Phil Sutter wrote:
> > Quite ugly, IMHO: rhashtable_insert_fast() may return -ENOMEM as
> > non-permanent error, if allocation in GFP_ATOMIC failed. In this case,
> > allocation in GFP
On Sun, Aug 30, 2015 at 03:47:17PM +0800, Herbert Xu wrote:
> Phil Sutter wrote:
> >
> > Should we introduce a new field to struct rhashtable to track the
> > internal state? This might allow to clean up some rather obscure tests,
> > e.g. whether a table resize is i
On Tue, Sep 01, 2015 at 07:43:00PM +0800, Herbert Xu wrote:
> On Mon, Aug 31, 2015 at 01:00:12PM +0200, Phil Sutter wrote:
> >
> > The variable would be used to track if the worker has failed to allocate
> > memory in background.
> >
> > Since the failing inse
On Tue, Sep 01, 2015 at 09:00:57PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 02:46:48PM +0200, Phil Sutter wrote:
> >
> > This is not an inherent behaviour of the implementation but general
> > agreement. The insertion may fail non-permanently (returning -EBUSY),
>
On Tue, Sep 01, 2015 at 09:50:19PM +0800, Herbert Xu wrote:
> On Tue, Sep 01, 2015 at 03:43:11PM +0200, Phil Sutter wrote:
> >
> > Hmm. Since memory allocation is first tried with GFP_ATOMIC set and upon
> > failure retried in background, this seems like a situation which mi
and let it be configured by the distro or user.
But if most distros select 128 to be able to support Xeon Phi, then
there might not be a reason for the additional complexity.
Phil P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Hi Bjorn,
Thanks for the review.
On 16 October 2015 22:34, Bjorn wrote:
> On Fri, Oct 02, 2015 at 11:25:05AM +0100, Phil Edworthy wrote:
> > The R-Car PCIe host controller driver uses pci_common_init_dev(),
> > which is ARM-specific and requires the ARM struct hw_p
Hi Geert,
On 20 October 2015 08:37, Geert wrote:
> On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman wrote:
> > On Mon, Oct 19, 2015 at 06:16:34PM -0500, Bjorn Helgaas wrote:
> >> [+cc Geert]
> >>
> >> On Fri, Oct 02, 2015 at 11:25:03AM +0100, Phil Edworthy wr
Hi Bjorn,
On 20 October 2015 13:50, Bjorn wrote:
> On Tue, Oct 20, 2015 at 08:00:10AM +0000, Phil Edworthy wrote:
> > Hi Geert,
> >
> > On 20 October 2015 08:37, Geert wrote:
> > > On Tue, Oct 20, 2015 at 3:36 AM, Simon Horman
> wrote:
> > > > On
re
related.
Phil Edworthy (4):
PCI: rcar-pcie: Make PCI aware of the IO resources
PCI: rcar-pcie: Remove dependency on ARM-specific struct hw_pci
PCI: rcar-pcie: Set root bus nr to that provided in DT
PCI: rcar-pcie: Fix IO offset for multiple instances
drivers/pci/host/pcie-r
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 7678fe0..27e2c20 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
is based on commit <499733e0cc1a00523c5056a690f65dea7b9da140>
"PCI: generic: Remove dependency on ARM-specific struct hw_pci".
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 76
1 file changed, 48 insertions(+), 28 de
On ARM64, setting the root bus number to -1 causes probe failure.
Moreover, we should use the bus number specified in the DT as we
could have multiple PCIe controllers with different bus ranges.
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 2 +-
1 file changed, 1 insertion
Signed-off-by: Phil Edworthy
---
drivers/pci/host/pcie-rcar.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 8e583c2..f4fa6c5 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie
Hi Andy,
On 29 August 2018 18:11 Andy Shevchenko wrote:
> On Tue, Jul 31, 2018 at 01:10:59PM +0100, Phil Edworthy wrote:
> > Quite a few drivers get an optional clock, e.g. a clock required
> > to access peripheral's registers that is always enabled on some
> > devi
Hi Stephen,
On 25 July 2018 23:37, Stephen Boyd wrote:
> Quoting Phil Edworthy (2018-07-18 06:56:26)
> > On 18 July 2018 14:19, Geert Uytterhoeven wrote:
> > > On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote:
> > > > On Wed, Jul 18, 2018 at 01:57:3
Quite a few drivers get an optional clock, e.g. a clock required
to access peripheral's registers that is always enabled on some
devices.
Phil Edworthy (2):
clk: Add of_clk_get_by_name_optional() function
clk: Add functions to get optional clocks
drivers/clk/clk-devres.c
: Phil Edworthy
---
drivers/clk/clk-devres.c | 18 --
drivers/clk/clkdev.c | 17 +++--
include/linux/clk.h | 29 +
3 files changed, 60 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c
r and allows clk_prepare_enable, etc to be called
on the returned reference without additional checks.
Signed-off-by: Phil Edworthy
---
drivers/clk/clkdev.c | 34 ++
include/linux/clk.h | 1 +
2 files changed, 31 insertions(+), 4 deletions(-)
diff --git a/driver
Hi Geert,
On 30 July 2018 09:56, Geert Uytterhoeven wrote:
> On Mon, Jul 30, 2018 at 10:36 AM Phil Edworthy wrote:
> > Quite a few drivers get an optional clock, e.g. a clock required to
> > access peripheral's registers that is always enabled on some devices.
> >
>
Quite a few drivers get an optional clock, e.g. a clock required
to access peripheral's registers that is always enabled on some
devices.
This function behaves the same as of_clk_get_by_name() except that
it will return NULL instead of -EINVAL.
Signed-off-by: Phil Edworthy
---
v3:
- Fix
Quite a few drivers get an optional clock, e.g. a bus clock required to
access peripheral's registers that is always enabled on some devices.
Phil Edworthy (2):
clk: Add of_clk_get_by_name_optional() function
clk: Add functions to get optional clocks
drivers/clk/clk-devres.c
: Phil Edworthy
---
v3:
- No changes.
---
drivers/clk/clk-devres.c | 18 --
drivers/clk/clkdev.c | 17 +++--
include/linux/clk.h | 29 +
3 files changed, 60 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk-devres.c b
Hi Andy,
On 30 July 2018 17:04, Andy Shevchenko wrote:
> On Mon, 2018-07-30 at 14:31 +0100, Phil Edworthy wrote:
> > Quite a few drivers get an optional clock, e.g. a clock required to
> > access peripheral's registers that is always enabled on some devices.
> >
> >
Hi Geert,
On 20 July 2018 13:12, Geert Uytterhoeven wrote:
> On Fri, Jul 20, 2018 at 2:06 PM Phil Edworthy wrote:
> > On 20 July 2018 12:21, Geert Uytterhoeven wrote:
> > > On Wed, Jul 18, 2018 at 4:34 PM Phil Edworthy wrote:
> > > > To avoid all SoC peripheral
Quite a few drivers get an optional clock, e.g. a bus clock required to
access peripheral's registers that is always enabled on some devices.
Phil Edworthy (2):
clk: Add of_clk_get_by_name_optional() function
clk: Add functions to get optional clocks
drivers/clk/clk-devres.c
Quite a few drivers get an optional clock, e.g. a clock required
to access peripheral's registers that is always enabled on some
devices.
This function behaves the same as of_clk_get_by_name() except that
it will return NULL instead of -ENOENT.
Signed-off-by: Phil Edworthy
---
v4:
: Phil Edworthy
---
v4:
- No changes.
v3:
- No changes.
---
drivers/clk/clk-devres.c | 18 --
drivers/clk/clkdev.c | 17 +++--
include/linux/clk.h | 29 +
3 files changed, 60 insertions(+), 4 deletions(-)
diff --git a/drivers/clk
On 24/07/2018 15:26, Wolfram Sang wrote:
Hi Phil,
So, it is not possible to read SCL status then? Hmm, currently a working
get_scl is required...
...
Well, I don't know much about this IP core and how/where it is used. I
just wonder what happens if another user comes along using an
o.
So while the scl is open drain, there may be hardware in between that isn't.
What would the correct way be to deal with that now?
--
Regards
Phil
rn an invalid gpio number when desc == null
I don't know what the intents are, so don't know if its a "bug" or by design.
--
Regards
Phil Reid
hip_add_data() calls.
But should probably go into stable if it is the fix.
--
Regards
Phil Reid
On 7/01/2018 00:54, Egil Hjelmeland wrote:
Den 13. nov. 2017 09:07, skrev Phil Reid:
Replaces Pan Bian patch
"net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional"
Errors need to be prograted back from probe.
Note: I have only compile tested the code as I don&
Enable an optional bus clock provided by DT.
Signed-off-by: Phil Edworthy
---
v2:
- Fix include order.
- Use a clock name.
- Check errors from clk_prepare_enable()
- Add calls to enable/disable the clock in PM
---
drivers/gpio/gpio-dwapb.c | 20 +++-
1 file changed, 19
Hi Shawn,
On 28 February 2018 01:53, Shawn Lin wrote:
> On 2018/2/27 23:05, Phil Edworthy wrote:
> > On 27 February 2018 14:42, Shawn Lin wrote:
> >> On 2018/2/27 22:31, Phil Edworthy wrote:
> >>> On 27 February 2018 14:28, Shawn Lin wrote:
> >>
)
return err;
+ err = xlp9xx_i2c_smbus_setup(priv, pdev);
+ if (err)
+ dev_info(&pdev->dev, "No active SMBus alert %d\n", err);
+
platform_set_drvdata(pdev, priv);
dev_dbg(&pdev->dev, "I2C bus:%d added\n", priv->adapter.nr);
--
2.1.4
--
Regards
Phil Reid
hat it's the size of L2 that matters
(or, specifically, the hardcoded value that the firmware is using on its
side for the fragments list handling. It overrides a cache-line-size DT
property with that number if present). However, I think L1==L2 cache
line size this should be a safe assumption
On 07/03/2018 12:10, Stefan Wahren wrote:
> Hi Phil,
>> It is the L2 cache line size that matters, but as long as you end up with
>> the numbers Stefan mentioned - 32 on BCM2835, 64 on BCM2836 and BCM2837 -
>> I'm not too bothered how you get there.
Hi Geert,
On 06 April 2018 10:57 Geert Uytterhoeven wrote:
> On Thu, Apr 5, 2018 at 11:42 AM, Phil Edworthy wrote:
> > On 30 March 2018 22:26 Andy Shevchenko wrote:
> >> On Wed, Mar 28, 2018 at 5:22 PM, Phil Edworthy wrote:
> >> > The DesignWare GPIO IP can be
lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
content, but the value gets overwritten before it is returned and the
read goes ahead anyway. Make the read conditional as it should be
and preserve the error code.
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan78xx.c | 3
Hi Andy,
On 05 April 2018 10:43, Phil Edworthy wrote:
> On 30 March 2018 22:26 Andy Shevchenko wrote:
> > On Wed, Mar 28, 2018 at 5:22 PM, Phil Edworthy wrote:
> > > The DesignWare GPIO IP can be configured for either 1 or 32
> > > interrupts,
> >
> > 1 to 3
events directly, relying on
the subsequent deferral of the EVENT_LINK_RESET call to schedule the
work. Take the same precaution with EVENT_STAT_UPDATE to avoid a
totally unnecessary error message.
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan78xx.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi Andrew.
On 11/04/2018 13:57, Andrew Lunn wrote:
> On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote:
>> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
>> content, but the value gets overwritten before it is returned and the
>> read goes a
ansleep().
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai
---
v2:
* Use gpio_set_value_cansleep() to replace gpio_set_value() additionally.
Thanks for Florian and Phil for good advice.
---
drivers/net/dsa/b
a bindings file, adding it to
MAINTAINERS at the same time.
Signed-off-by: Phil Elwell
---
.../devicetree/bindings/net/microchip,lan78xx.txt | 44 ++
MAINTAINERS| 1 +
2 files changed, 45 insertions(+)
create mode 100644
nk100/1000/activity 5=link10/1000/activity
6=link10/100/activity14=off15=on
Also use the presence of the DT property to indicate that the
LEDs should be enabled - necessary in the event that no valid OTP
or EEPROM is available.
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan7
Add two new Device Tree properties:
* microchip,eee-enabled - a boolean to enable EEE
* microchip,tx-lpi-timer - time in microseconds to wait after TX goes
idle before entering the low power state
(default 600)
Signed-off-by: Phil Elwell
reading the MAC address, EEE setting
and LED modes from Device Tree.
Phil Elwell (4):
lan78xx: Read MAC address from DT if present
lan78xx: Read initial EEE setting from Device Tree
lan78xx: Read LED modes from Device Tree
dt-bindings: Document the DT bindings for lan78xx
.../devicetree
There is a standard mechanism for locating and using a MAC address from
the Device Tree. Use this facility in the lan78xx driver to support
applications without programmed EEPROM or OTP. At the same time,
regularise the handling of the different address sources.
Signed-off-by: Phil Elwell
Hi Andrew,
On 12/04/2018 15:04, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote:
>> The Microchip LAN78XX family of devices are Ethernet controllers with
>> a USB interface. Despite being discoverable devices it can be useful to
>> be able t
Hi Andrew,
On 12/04/2018 15:06, Andrew Lunn wrote:
> Hi Phil
>
>> -ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
>> -ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
>> +mac_addr = of_get_mac_address(dev->udev->
Hi Andrew,
On 12/04/2018 15:26, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:35PM +0100, Phil Elwell wrote:
>> Add support for DT property "microchip,led-modes", a vector of two
>> cells (u32s) in the range 0-15, each of which sets the mode for one
>> of the
Hi Andrew,
On 12/04/2018 15:30, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote:
>> The Microchip LAN78XX family of devices are Ethernet controllers with
>> a USB interface. Despite being discoverable devices it can be useful to
>> be able t
Andrew,
On 12/04/2018 15:16, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:34PM +0100, Phil Elwell wrote:
>> Add two new Device Tree properties:
>> * microchip,eee-enabled - a boolean to enable EEE
>> * microchip,tx-lpi-timer - time in microseconds
er chip?
From what I can understand of the code which is admittedly limited.
--
Regards
Phil Reid
s, it will
get as many interrupts as specified in the DT 'interrupts' property.
It doesn't do anything clever with the different interrupts, it just calls
the same handler used for single interrupt hardware.
Signed-off-by: Phil Edworthy
---
v2:
- Replaced interrupt-mask DT
interrupts-extended DT prop.
However, I have no use for this and had to hack some test case for this.
Perhaps the driver should support 1 interrupt or all GPIOa as interrupts?
Phil Edworthy (2):
gpio: dwapb: Add support for 1 interrupt per port A GPIO
mfd: intel_quark_i2c_gpio: Update Syn
101 - 200 of 731 matches
Mail list logo
