RE: [PATCH 1/4] ASoC: simple-card: Fix device node locks

2014-02-23 Thread li.xi...@freescale.com
> @@ -169,22 +164,26 @@ static int asoc_simple_card_parse_of(struct device_node > *node, > /* CPU sub-node */ > ret = -EINVAL; > np = of_get_child_by_name(node, "simple-audio-card,cpu"); > - if (np) > + if (np) { > ret = asoc_simple_card_sub_parse_of(np, priv

RE: [PATCH 2/4] ASoC: simple-card: dynamically allocate the DAI link array

2014-02-23 Thread li.xi...@freescale.com
> @@ -20,7 +20,6 @@ struct simple_card_data { > unsigned int daifmt; > struct asoc_simple_dai cpu_dai; > struct asoc_simple_dai codec_dai; > - struct snd_soc_dai_link snd_link; > }; > > static int __asoc_simple_card_dai_init(struct snd_soc_dai *dai, > @@ -246,7 +245,9 @@

RE: [PATCHv9 Resend 0/4] Add Freescale FTM PWM driver

2014-02-24 Thread li.xi...@freescale.com
Thierry, Ping ? :) > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, February 19, 2014 4:39 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCHv9 Resend 0/4] Add Freescal

RE: [PATCHv3 resend 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-11 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 resend 1/3] ASoC: codec: Simplify ASoC probe code. > > On Tue, Mar 11, 2014 at 12:43:20PM +0800, Xiubo Li wrote: > > For some CODEC drivers like who act as the MFDs children are ignored > > by this patch. > > Applied all, thanks. I'd generally recommend about putting thin

RE: [PATCH v2 3/4] ASoC: simple-card: accept many DAI links

2014-03-11 Thread li.xi...@freescale.com
> Subject: [PATCH v2 3/4] ASoC: simple-card: accept many DAI links > > Some simple audio cards may have many DAI links. > This patch extends the simple-card driver for handling such cards. > > Signed-off-by: Jean-Francois Moine > --- > sound/soc/generic/simple-card.c | 132 +

RE: [PATCH v3 0/4] ASoC: simple-card: multi DAI links extension

2014-03-16 Thread li.xi...@freescale.com
> Subject: [PATCH v3 0/4] ASoC: simple-card: multi DAI links extension > > This patch series extends the simple card driver to handle > many DAI links as this exists in the Cubox audio subsystem. > > -v3 > - remove 'Fix the reference count of device nodes' > which is applied (

RE: [alsa-devel] [RFC][PATCH 1/3] ASoC: core: Move the default regmap I/O setting to snd_soc_register_codec()

2014-03-04 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [RFC][PATCH 1/3] ASoC: core: Move the default regmap > I/O setting to snd_soc_register_codec() > > On 03/04/2014 09:25 AM, Xiubo Li wrote: > > Add the default regmap I/O setting to snd_soc_register_codec() while > > the CODEC is initialising, which will be called by CO

RE: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate().

2014-03-04 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add > snd_soc_dai_set_tdm_slot_xlate(). > > On Sat, Mar 01, 2014 at 02:19:44PM +0100, Lars-Peter Clausen wrote: > > > I'm not quite sure I fully understand what this patch is trying to > > solve. It adds a variant snd_soc_dai_set_tdm_slot() t

RE: [PATCHv9 Resend 4/4] Documentation: Add device tree bindings for Freescale FTM PWM.

2014-02-26 Thread li.xi...@freescale.com
> > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt > b/Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt > [...] > > +- clocks : Must contain a clock specifier for each entry in clock-names, >

RE: [PATCHv9 Resend 1/4] pwm: Add Freescale FTM PWM driver support

2014-02-26 Thread li.xi...@freescale.com
Hi Thierry, Thanks very much, I will fix them all. :) -- Best Regards, Xiubo > Sorry for taking so long to get back to you. Things have been quite busy > lately. A few more comments below, but we're getting there. > > On Wed, Feb 19, 2014 at 04:38:54PM +0800, Xiubo Li wrote: > [...] > > diff -

RE: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.

2014-02-27 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap. > > On Thu, Feb 27, 2014 at 05:49:52PM +0800, Xiubo Li wrote: > > For most CODEC drivers which the REGMAP is used, the soc_probe_codec() > > will do the stuff work of snd_soc_codec_set_cache_io(), which the CODEC > > driver

RE: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.

2014-02-27 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap. > > On Fri, Feb 28, 2014 at 04:00:38AM +0000, li.xi...@freescale.com wrote: > > > I'll send another patches to applied to use this for another CODEC drivers. > > And there almost 80 files, Sh

RE: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.

2014-02-27 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try > regmap. > > On 02/28/2014 06:56 AM, li.xi...@freescale.com wrote: > >> Subject: Re: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap. > >> > >> On Fri,

RE: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.

2014-02-27 Thread li.xi...@freescale.com
> >>>> Subject: Re: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap. > >>>> > >>>> On Fri, Feb 28, 2014 at 04:00:38AM +, li.xi...@freescale.com wrote: > >>>> > >>>>> I'll send another patches to

RE: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.

2014-02-27 Thread li.xi...@freescale.com
> > A quick grep reveals: > mc13783.c:codec->control_data = dev_get_regmap(codec->dev->parent, NULL); > si476x.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL); > wm5102.c: codec->control_data = priv->core.arizona->regmap; > wm5110.c: codec->control_data = priv->c

RE: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.

2014-02-27 Thread li.xi...@freescale.com
> > A quick grep reveals: > mc13783.c:codec->control_data = dev_get_regmap(codec->dev->parent, NULL); > si476x.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL); > wm5102.c: codec->control_data = priv->core.arizona->regmap; > wm5110.c: codec->control_data = priv->c

RE: [alsa-devel] [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> Looks good in general, but try to build these kinds of changes with > CONFIG_COMPILE_TEST=y and CONFIG_SND_SOC_ALL_CODECS=y before sending the > patch. There are a lot of warnings about unused variables caused by this > patch. > @Lars, Oh, yes, these are very low-level errors, I will fix them

RE: [PATCHv2 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> > "Just removing the set_cache_io() call will not work for all > > drivers. There are some MFD child devices which use regmap from the parent > > device. So dev_get_regmap() will return NULL for those." > > This is the sort of thing that I was referring to when talking about > doing the non-bori

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> > static int ak4535_probe(struct snd_soc_codec *codec) > > { > > - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); > > - int ret; > > - > > - codec->control_data = ak4535->regmap; > > - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP); > > - if (ret < 0) {

RE: [PATCHv10 0/4] Add Freescale FTM PWM support

2014-03-18 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv10 0/4] Add Freescale FTM PWM support > > On Thu, Feb 27, 2014 at 05:39:48PM +0800, Xiubo Li wrote: > > Changed in V10: > > Fix some bugs and adjust the code from Thierry's comments. > > > > > > Xiubo Li (4): > > pwm: Add Freescale FTM PWM driver support > > ARM: dts:

RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

2014-03-20 Thread li.xi...@freescale.com
fig > > On Thu, Feb 20, 2014 at 11:44:32AM +0900, Mark Brown wrote: > > On Thu, Feb 20, 2014 at 02:06:20AM +, li.xi...@freescale.com wrote: > > > > > I'm not very sure of this patch, maybe should we add one menu > > > in Kconfig for all visible CPU

RE: [PATCH v2] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-02-10 Thread li.xi...@freescale.com
> Subject: Re: [PATCH v2] ASoC: fsl-sai: convert to use regmap API for Freeacale > SAI > > On Sat, Feb 08, 2014 at 02:38:28PM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > Applied, thanks but I think this needs a select of REGMAP_MMIO in the > Kconfig to ensure that regmap-mmio is act

RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread li.xi...@freescale.com
> > + spdif_priv->big_endian = of_property_read_bool(np, "big-endian"); > > + if (spdif_priv->big_endian) > > + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > Why not just: > if (of_property_read_bool(np, "big-endian")) > fsl_spdif_regmap_confi

RE: [PATCH 2/2] ASoC: fsl-esai: big-endian support

2014-02-10 Thread li.xi...@freescale.com
> > + - big-endian : If this property is absent, the native endian mode will > > +be in use as default, or the big endian mode will be in use for all the > > +device registers. > > > + > > + > > Single blank line should be enough here :) > This will be removed. > > @@ -687,6 +688,1

RE: [PATCH 1/2] ASoC: fsl-spdif: big-endian support

2014-02-10 Thread li.xi...@freescale.com
> > + - big-endian : If this property is absent, the native endian mode will > > + be in use as default, or the big endian mode will be in use for all the > > + device registers. > > + > > @Shawn > Does DT have an existing approach to determine if the current SoC this IP > uses is BE or LE

RE: [alsa-devel] [PATCH v2 1/3] ASoC: binding: add tdm-slot.txt

2014-02-12 Thread li.xi...@freescale.com
> > The current internal API for TDM is very poor, I don't think we want > > to expose that 1 to 1 to the devicetree. Since this means we'd have > > to support that forever. The first thing is that the semantics of > > snd_soc_dai_set_tdm_slot() are very unclear. E.g. some drivers use a > > zero bi

RE: [PATCH 2/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.

2014-02-18 Thread li.xi...@freescale.com
> > @@ -127,9 +127,27 @@ > > VF610_PAD_PTB5__UART1_RX0x21a1 > > >; > > }; > > + > > + pinctrl_sai2: sai2grp { > > To sort it alphabetically, the entry should be added before > pinctrl_uart1. > > > +

RE: [PATCH 1/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610.

2014-02-18 Thread li.xi...@freescale.com
> > 'ARM: dts: vf610: ...' for patch prefix. > > Shawn Please see the next version. Thanks, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

RE: [PATCH 2/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.

2014-02-18 Thread li.xi...@freescale.com
> The patch subject can be a little short like > > ARM: dts: vf610-twr: Enable SAI ALSA SoC DAI device > Yes, that looks better. Thanks, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

RE: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support

2014-02-19 Thread li.xi...@freescale.com
> Subject: RE: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support > > > Subject: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support > > > > The FTM PWM device can be found on Vybrid VF610 Tower and Layerscape LS-1 > > SoCs. > > > > Signed-off-by: Xiubo Li > > --- > > For this patch se

RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

2014-02-19 Thread li.xi...@freescale.com
Hi Mark, I'm not very sure of this patch, maybe should we add one menu in Kconfig for all visible CPU DAIs firstly like for code drivers? Thanks, -- Best Regards, Xiubo > Subject: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in > Kconfig > > For simple card since the who

RE: [PATCH Resend] regmap: fix _regmap_update_bits()

2014-02-20 Thread li.xi...@freescale.com
> Subject: Re: [PATCH Resend] regmap: fix _regmap_update_bits() > > On Thu, Feb 20, 2014 at 08:50:10AM +0800, Xiubo Li wrote: > > > This resend version just rewrites the commit comment. > > I've applied this but I updated the commit log further - part of the > reason this didn't get applied firs

RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

2014-02-20 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be > visible in Kconfig > > On Thu, Feb 20, 2014 at 02:06:20AM +0000, li.xi...@freescale.com wrote: > > > I'm not very sure of this patch, maybe should we add one menu > > in Kconfig for a

RE: [PATCH 6/8] ASoC: simple-card: add tdm slot supports

2014-01-22 Thread li.xi...@freescale.com
Hi David, Firstly thanks for your comment. > > +asoc_simple_card_of_parse_tdm_slot(struct device_node *np, > > + struct device *dev, > > + struct asoc_simple_dai *dai, > > + const char *propname) > > +{ > > +

RE: [PATCH Resend 2/8] ASoC: simple-card: fix __asoc_simple_card_dai_init

2014-01-22 Thread li.xi...@freescale.com
> > diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple- > card.c > > index 6443c87..3b8c9a2 100644 > > --- a/sound/soc/generic/simple-card.c > > +++ b/sound/soc/generic/simple-card.c > > @@ -31,16 +31,21 @@ static int __asoc_simple_card_dai_init(struct > snd_soc_dai *dai, > >

RE: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread li.xi...@freescale.com
> > static int fsl_sai_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > int clk_id, unsigned int freq, int dir) > > { > > - struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); > > int ret; > > > > if (dir == SND_SOC_CLOCK_IN) > > return 0;

RE: [PATCH] ASoC: simple-card: fix simple card widgets routing property name usage

2014-01-23 Thread li.xi...@freescale.com
Hi, I'd like to know the status about this patch. Thanks very much. Best Regards, Xiubo > Subject: [PATCH] ASoC: simple-card: fix simple card widgets routing property > name usage > > Fix the usage of simple card widgets routing property, and make it the > same with simple card routing proper

RE: [PATCH Resend 7/8] ASoC: add snd_soc_of_parse_audio_simple_widgets for DeviceTree

2014-01-23 Thread li.xi...@freescale.com
> > +static struct snd_soc_dapm_widget simple_widgets[] = { > > + SND_SOC_DAPM_MIC("Mic", NULL), > > + SND_SOC_DAPM_LINE("Line", NULL), > > + SND_SOC_DAPM_HP("Hp", NULL), > > + SND_SOC_DAPM_SPK("Spk", NULL), > > +}; > This is the templates for "Microphone XXX", "Line XXX", "Headphone XXX

RE: [PATCH Resend 3/8] ASoC: simple-card: simplify the daifmt code

2014-01-23 Thread li.xi...@freescale.com
> Subject: Re: [PATCH Resend 3/8] ASoC: simple-card: simplify the daifmt code > > On Thu, Jan 23, 2014 at 01:02:45PM +0800, Xiubo Li wrote: > > In the asoc_simple_card_parse_of() will parse the device node's CPU/CODEC > > DAI commone fmts, and then in asoc_simple_card_sub_parse_of() will parse >

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix simple card widgets routing property name usage

2014-01-23 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCH] ASoC: simple-card: fix simple card widgets > routing property name usage > > On Thu, Jan 23, 2014 at 11:00:16AM +0000, li.xi...@freescale.com wrote: > > Hi, > > > > I'd like to know the status about this patch. > > P

RE: [PATCH 1/8] ASoC: fsl: Add VF610 soc audio card Kconfig

2014-01-25 Thread li.xi...@freescale.com
Hi Mark, > > +config SND_SOC_VF610_SGTL5000 > > + tristate "SoC Audio support for VF610 boards with SGTL5000" > > + depends on OF && I2C > > + select SND_SOC_FSL_SAI > > + select SND_SOC_SGTL5000 > > + select SND_SIMPLE_CARD > > ...for simple card since the whole ide

RE: [PATCH] regmap: mmio: Fix the bug of 'offset' value parsing.

2014-04-01 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] regmap: mmio: Fix the bug of 'offset' value parsing. > > On Mon, Mar 31, 2014 at 02:33:31PM +0800, Xiubo Li wrote: > > 'offset = *(u32 *)reg;', this will be okey for 32/64-bit register, but > > for 8/16-bit register, the 'offset' value will overflow. > > This doesn't apply

RE: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support

2014-04-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support > > On Tue, Apr 01, 2014 at 02:24:12AM +0000, li.xi...@freescale.com wrote: > > > Yes, I do think so too and there has already regmap-mmio version patch > > Series about the IMX2 Watchdog driver, but

RE: [PATCH 2/2] regmap: add DT endianness binding support.

2014-04-02 Thread li.xi...@freescale.com
Please discard this patch series: There has some problems about the commit message, I will resend this patch series. > Subject: [PATCH 2/2] regmap: add DT endianness binding support. > > For many drivers which will support rich endianness of CPU<-->Dev > need define DT properties by itself wit

RE: [PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-04-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API. > > On Tue, Apr 01, 2014 at 12:46:38PM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > Cc: Guenter Roeck > > We should probably have some commit log to explain why we need to move > to use regmap API. > Well, y

RE: [PATCHv2 3/3] regmap: add DT endianness binding support.

2014-04-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 3/3] regmap: add DT endianness binding support. > > On Wed, Apr 02, 2014 at 06:09:09PM +0800, Xiubo Li wrote: > > > + ret = of_regmap_get_endian(dev, bus, config, "reg_endian", ®_endian); > > + if (ret) > > + return ERR_PTR(ret); > > + > > + ret = of_regma

RE: [PATCHv2 2/3] regmap: Add the DT binding documentation for endianness

2014-04-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 2/3] regmap: Add the DT binding documentation for > endianness > > On Wed, Apr 02, 2014 at 06:09:08PM +0800, Xiubo Li wrote: > > > +sai2: sai@40031000 { > > + compatible = "fsl,vf610-sai"; > > + reg = <0x40031000 0x1000>; > > + ... > > + val

RE: [PATCHv4 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-04-03 Thread li.xi...@freescale.com
> > + base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(base)) > > + return PTR_ERR(base); > > + > > + imx2_wdt.regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base, > > + &imx2_wdt_regmap_config); > > This patch caus

RE: [PATCHv4 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-04-03 Thread li.xi...@freescale.com
> > This is caused by not compiling the regmap core. > > > > Could you add the following patch to have a try ? > > == > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > index 79d2589..3e55fa9 100644 > > --- a/drivers/watchdog/Kconfig > > +++ b/drivers/w

RE: [PATCH] ASoC: fsl_sai: Fix Bit Clock Polarity configurations

2014-04-04 Thread li.xi...@freescale.com
> Subject: [PATCH] ASoC: fsl_sai: Fix Bit Clock Polarity configurations > > The BCP bit in TCR4/RCR4 register rules as followings: > 0 Bit clock is active high with drive outputs on rising edge > and sample inputs on falling edge. > 1 Bit clock is active low with drive outputs on falling

RE: [PATCH] ASoC: fsl_sai: Fix Bit Clock Polarity configurations

2014-04-04 Thread li.xi...@freescale.com
> > Is that possible for you to test those two clock patches for fsl_sai? > > I think most of us are waiting for your reply to it. And I'd really > like to move on to append clock dividing code into the driver so both > of vybrid and imx can easily enable the DAI master mode. > Certainly, I wi

RE: [PATCH 1/2] ASoC: fsl_sai: Add clock control for SAI

2014-04-04 Thread li.xi...@freescale.com
Hi, I have test this series on my Vybrid-TWR board and it works happily. [...] > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 3847d2a..2d749df 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -428,5 +428,18 @@ static int fsl_sai_startup(struct

RE: [PATCH 1/2] ASoC: fsl_sai: Add clock control for SAI

2014-04-04 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 1/2] ASoC: fsl_sai: Add clock control for SAI > > Hi Xiubo, > > On Fri, Apr 04, 2014 at 05:24:39PM +0800, Xiubo Li-B47053 wrote: > > Hi, > > > > I have test this series on my Vybrid-TWR board and it works happily. > > You just checked the wrong version. I've sent a mail to

RE: [PATCH v2 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform

2014-04-04 Thread li.xi...@freescale.com
> Subject: Re: [PATCH v2 2/2] ARM: dts: Append clock bindings for sai2 on VF610 > platform > > Hi Shawn, > >Thanks for the comments, but... > > On Wed, Apr 02, 2014 at 09:03:04PM +0800, Shawn Guo wrote: > > On Wed, Apr 02, 2014 at 06:10:20PM +0800, Nicolin Chen wrote: > > > Since we added f

RE: [PATCH] pwm: core: Use devm_kzalloc instead of kzalloc

2014-01-07 Thread li.xi...@freescale.com
> > drivers/pwm/core.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > > index 2ca9504..74c9f9a 100644 > > --- a/drivers/pwm/core.c > > +++ b/drivers/pwm/core.c > > @@ -80,7 +80,6 @@ static void free_pwms(struct pwm_ch

RE: [PATCHv9 2/4] ARM: dts: Add Freescale FTM PWM node for VF610.

2014-01-07 Thread li.xi...@freescale.com
> Has the FTM PWM device tree bindings been accepted/merged? Please only > send me DTS changes after that. Also when you send me the DTS changes, > please base on imx/dt or for-next branch of my git tree below. > > git://git.linaro.org/people/shawnguo/linux-2.6.git > Yes, I will resend thes

RE: [PATCH 1/4] ASoC: simple-card: add simple audio card widgets support

2014-01-08 Thread li.xi...@freescale.com
> > For many audio cards there need to add some off-CODEC widgets, and this > > is hard to be supported by dts only, because maybe some widgets need one > > or more call backs, such as wevent. > > The big question here would be why these widgets need to be added > For instance, from the SGTL5000

RE: [PATCH 3/4] ASoC: fsl: Add VF610 simple audio card widgets driver.

2014-01-08 Thread li.xi...@freescale.com
> > This is the SGTL5000 codec based off-CODEC widgets supports. > > > > Signed-off-by: Xiubo Li > > --- > > sound/soc/fsl/Kconfig | 25 ++ > > sound/soc/fsl/Makefile| 3 +++ > > sound/soc/fsl/snd-soc-simple-card-vf610.c | 44 > +++

RE: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support

2014-01-08 Thread li.xi...@freescale.com
> > +static unsigned long fsl_pwm_calculate_period_cycles(struct fsl_pwm_chip > *fpc, > > +unsigned long period_ns, > > +enum fsl_pwm_clk index) > > +{ > > + bool bg = fpc->big_endian; > > + int ret

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-12 Thread li.xi...@freescale.com
Hi Jean-Francois, > > If the original cinfo is not used anymore, the use of its structure to > handle the card information is not a good idea: > > - almost all cinfo information are in the struct snd_soc_card, > > - this cinfo structure cannot be extended to handle many DAI links, > > - it con

RE: [PATCH] ASoC: fsl-sai: Add device tree nodes and its availiable check

2014-01-12 Thread li.xi...@freescale.com
> > + if (!np || !of_device_is_available(np)) > > + return -ENODEV; > > + > > I would expect the of_device_is_available() check to be done by the > driver core rather than by individual drivers - every single driver > should have that check. Is this not happening? The check for np i

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-13 Thread li.xi...@freescale.com
Hi Mark, Jean-Francios > If the original cinfo is not used anymore, the use of its structure to > handle the card information is not a good idea: > > - almost all cinfo information are in the struct snd_soc_card, > > - this cinfo structure cannot be extended to handle many DAI links, > > - it c

RE: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data

2014-01-13 Thread li.xi...@freescale.com
> > Whether the dt is used or not, almost all the simple card information > > for the DAI link and sound card are initialized in the simple card driver. > > > > And for the platform caller, the snd_link and snd_card are of no use, so > > move them from struct asoc_simple_card_info to struct asoc_s

RE: [PATCHv2 5/6] ASoC: fsl: Add VF610 simple audio card widgets driver.

2014-01-14 Thread li.xi...@freescale.com
Hi Mark, I have sent another patch, if that patch is ok, please ignore this patch series. The new patch :" ASoC: add snd_soc_of_parse_audio_simple_widgets for DeviceTree" Thanks, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

RE: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data

2014-01-14 Thread li.xi...@freescale.com
Hi Jean-Francios, I do think split the muti-issues into deferent patches will be easier to upstream code, and the risk will be lower. So this patch is just the first step. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

RE: [PATCHv6 1/4] pwm: Add Freescale FTM PWM driver support

2013-12-13 Thread li.xi...@freescale.com
> > + struct fsl_pwm_chip *fpc; > > + > > + fpc = to_fsl_chip(chip); > > + > > + period_cycles = fsl_rate_to_cycles(fpc, period_ns); > > + if (period_cycles > 0x) { > > + dev_err(chip->dev, "required PWM period cycles(%lu) overflow " > > + "16-bits c

RE: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying to get optional VDDD supply.

2013-12-15 Thread li.xi...@freescale.com
> > 2, If the regulator dt node is exist but the optional VDDD is absent (i.e. > > The external VDDD is not used), a -EPROBE_DEFER will be returned, if > > just return the -EPROBE_DEFER to the probe(and then the probe deferral > > mechanism will do the probe again later, is that right ?), and then

RE: [PATCH 0/2] ASoC: fsl_sai: Two bug fixes for fsl_sai driver

2014-07-17 Thread li.xi...@freescale.com
> -Original Message- > From: Nicolin Chen [mailto:nicoleots...@gmail.com] > Sent: Thursday, July 17, 2014 9:22 PM > To: broo...@kernel.org > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; alsa- > de...@alsa-project.org; ti...@tabi.org; Xiubo Li-B47053; Wang Shengjiu-B02247

RE: [PATCH] clocksource: fix clocksource_mmio_readX_down

2014-04-22 Thread li.xi...@freescale.com
> > diff --git a/drivers/clocksource/mmio.c b/drivers/clocksource/mmio.c > > index c0e2512..f17a0d1 100644 > > --- a/drivers/clocksource/mmio.c > > +++ b/drivers/clocksource/mmio.c > > @@ -27,7 +27,7 @@ cycle_t clocksource_mmio_readl_up(struct clocksource *c) > > > > cycle_t clocksource_mmio_read

RE: [PATCHv2 2/3] regmap: Add the DT binding documentation for endianness

2014-04-22 Thread li.xi...@freescale.com
t; endianness > > On Thu, Apr 03, 2014 at 07:04:00AM +0000, li.xi...@freescale.com wrote: > > > > Generally just not > > > mentioning regmap is better for a binding definition, the binding should > > > be usable by all OSs and not just Linux. > > > H

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-17 Thread li.xi...@freescale.com
Hi Pankaj, One more question: For example: regmap_read() > _regmap_read() > 2112 #ifdef LOG_DEVICE > 2113 if (strcmp(dev_name(map->dev), LOG_DEVICE) == 0) > 2114 dev_info(map->dev, "%x => %x\n", reg, *val);

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
Hi, [...] > > please see regmap_get_val_endian called in regmap_init function. > > static enum regmap_endian regmap_get_val_endian(struct device *dev, > > const struct regmap_bus *bus, > > const struct regmap_config >

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
[...] > > I think there should have been a check for NULL on "dev" in > > "regmap_get_val_endian", so that if dev pointer exist then only it makes > > sense to get > > endianness property from DT. > > > > I will suggest following fix in regmap.c for this. With following fix I > > tested it and it w

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
> > Thanks for testing. In that case I will post this change, as I feel this > > should be > > fixed irrespective of my syscon patch. > > > > > But as Xiubo pointed in another mail, it may still cause other issues. > > > Looking at regmap.c, there're still some other places using the device > > poi

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
[...] > >create child: /dcsr@2000/dcsr-atbrepl@3a8000 > >create child: /dcsr@2000/dcsr-tsgen-ctrl@3a9000 > >create child: /dcsr@2000/dcsr-tsgen-read@3aa000 > >create child: /regulators/regulator@0 > >... > > > > As default the Linux will create all the platform devic

RE: [PATCH] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-21 Thread li.xi...@freescale.com
Hi, > Subject: Re: [PATCH] ARM: ls1021a: add gating clocks to IP blocks. > > On Fri, Sep 19, 2014 at 11:37:27AM +0100, Xiubo Li wrote: > > A given application may not use all the peripherals on the device. > > In this case, it may be desirable to disable unused peripherals. > > DCFG provides a me

RE: Problems with simple-card

2014-01-15 Thread li.xi...@freescale.com
Hi, > I did a mistake in the v1 of my 'ASoC: simple-card: simplify code': I > did not initialize the pointer to the asoc_simple_card_dai_init() > function when DT. Then, I fixed that, and the simple card does not work > for me. > > First, without any 'format' in the DT, I get a fmt for each CPU /

RE: [PATCH] ASoC: simple-card: Add snd_card's name parsing from DT node support

2014-01-16 Thread li.xi...@freescale.com
Hi David, > > sound/soc/generic/simple-card | 0 > > sound/soc/generic/simple-card. | 0 > > sound/soc/generic/simple-card.c | 7 ++- > > 3 files changed, 6 insertions(+), 1 deletion(-) > > create mode 100644 sound/soc/generic/simple-card > > create mode 100644 sound/soc/generic/simple-

RE: [alsa-devel] [PATCH] ASoC: core: Use devm_kzalloc() instead kzalloc()

2014-01-19 Thread li.xi...@freescale.com
Hi Mar, Lars > > I don't like this. I don't think it is a good design pattern to call > > devm function from within (especial non-devm) library functions. It > > creates an asymmetric API. The memory is allocated when > > snd_dmaengine_pcm_register() is called, but it is not freed when > > snd_dm

RE: [PATCH] of: fix of_update_property()

2014-01-19 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] of: fix of_update_property() > > On Thu, Jan 16, 2014 at 10:46 PM, Xiubo Li wrote: > > The of_update_property() is intent to update a property in a node > > s/intent/indended/ > > > and if the property does not exist, will add it to the node. > > > > The second search of

RE: [PATCH v2] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-22 Thread li.xi...@freescale.com
Hi, [...] > > +++ b/arch/arm/mach-imx/clk-ls1021a.c > > @@ -0,0 +1,124 @@ > > +/* > > + * Copyright 2014 Freescale Semiconductor, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by

RE: [PATCH v5] mfd: syscon: Decouple syscon interface from platform devices

2014-09-22 Thread li.xi...@freescale.com
Hi, [...] > +static struct regmap_config syscon_regmap_config = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > }; > > -static int syscon_match_node(struct device *dev, void *data) > +static struct syscon *of_syscon_register(struct device_node *np) > { > - struc

RE: [PATCH v2] watchdog: imx2_wdt: Add power management support.

2014-09-23 Thread li.xi...@freescale.com
Hi, [...] > > +#ifdef CONFIG_PM_SLEEP > > +/* Disable watchdog if it is active or non-active but still running */ > > +static int imx2_wdt_suspend(struct device *dev) > > +{ > > + struct watchdog_device *wdog = dev_get_drvdata(dev); > > + struct imx2_wdt_device *wdev = watchdog_get_drvdata(wd

RE: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs

2014-09-23 Thread li.xi...@freescale.com
Hi, [...] > >>> 4 files changed, 551 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/video/fsl- > sii902x.txt > >>> create mode 100644 drivers/video/fbdev/fsl-sii902x.c > >> > >> I don't know how you picked the names of the people you sent this patch > >> to, but looks

RE: [PATCH v3] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-25 Thread li.xi...@freescale.com
Hi, [...] > > +Required properties: > > +- compatible: Should be "fsl,ls1021a-gate" > > +- reg: Address and length of the register set > > +- #clock-cells:Should be <1> > > + > > +Optional property: > > +- big-endian: If present the gate cl

RE: [PATCH v3] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-25 Thread li.xi...@freescale.com
> > > As the parent of the clocks registered by this function is "dummy" from > > > what I see, what is the point of setting flag CLK_SET_RATE_PARENT then? > > > > > > > + CLK_IGNORE_UNUSED, reg, shift, > > > > > > Why flag CLK_IGNORE_UNUSED? > > > > > > > As the SoC reference

RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

2014-09-25 Thread li.xi...@freescale.com
Hi Russell, I'd like to know the status of this patch. Our Platforms depend on it. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, September 01, 2014 12:42 PM > To: li...@arm.linux.org.uk; linux-arm-ker...@lists.infradead.org > Cc

RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

2014-09-26 Thread li.xi...@freescale.com
[...] > On Fri, Sep 26, 2014 at 05:30:40AM +0000, li.xi...@freescale.com wrote: > > Hi Russell, > > > > I'd like to know the status of this patch. > > > > Our Platforms depend on it. > > I'm not applying it. This option should not be exposed fo

RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

2014-09-26 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs > > On Fri, Sep 26, 2014 at 08:39:04AM +0000, li.xi...@freescale.com wrote: > > [...] > > > On Fri, Sep 26, 2014 at 05:30:40AM +, li.xi...@freescale.com wrote: > > > > Hi Russe

RE: [PATCH] clocksource: Add BE/LE APIs support for clocksource counter reading.

2014-09-10 Thread li.xi...@freescale.com
> Cc: daniel.lezc...@linaro.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] clocksource: Add BE/LE APIs support for clocksource > counter reading. > > On Wed, 10 Sep 2014, Xiubo Li wrote: > > So you add BE/LE APIs according to the subject line, but you fail > again to tell WHY. If that w

RE: [PATCH v2] clocksource: Add BE APIs support for clocksource counter reading.

2014-09-27 Thread li.xi...@freescale.com
Hi, > Subject: Re: [PATCH v2] clocksource: Add BE APIs support for clocksource > counter reading. > > On Fri, 26 Sep 2014, Xiubo Li wrote: > > For now I just added _be() support using ioread{16,32}be. > > And i have a check of the clocksource drivers, didn't find anyone > > using LE mode on one

RE: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-09-28 Thread li.xi...@freescale.com
Hi Mark, > Subject: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing > error. > > Since we cannot make sure the 'val_count' will always be none zero > here, and then if it equals to zero, the kmemdup() will return > ZERO_SIZE_PTR, which equals to ((void *)16). > > So this patch

RE: [PATCH v2] clocksource: Add BE APIs support for clocksource counter reading.

2014-09-29 Thread li.xi...@freescale.com
Hi, > Subject: RE: [PATCH v2] clocksource: Add BE APIs support for clocksource > counter reading. > > On Sun, 28 Sep 2014, li.xi...@freescale.com wrote: > > > Subject: Re: [PATCH v2] clocksource: Add BE APIs support for clocksource > > > counter reading. > > &

RE: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-09-29 Thread li.xi...@freescale.com
Hi, > > > diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c > > index 455a877..3d93e38 100644 > > --- a/drivers/base/regmap/regmap.c > > +++ b/drivers/base/regmap/regmap.c > > @@ -1716,6 +1716,9 @@ out: > > Whatever you're using to generate the patches isn't annotating wit

RE: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs

2014-09-14 Thread li.xi...@freescale.com
Hi Tomi, Thanks very much for your comments. > Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs > > Hi, > > On 05/09/14 07:48, Xiubo Li wrote: > > Some Freescale SoCs, there has an DVI/HDMI controller and a PHY, > > attached to one of their display controller unit's LCD

RE: [PATCH] drm/fb-helper: Do the mode_set.connectors ZERO_SIZE_PTR check

2014-03-09 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] drm/fb-helper: Do the mode_set.connectors ZERO_SIZE_PTR > check > > On Thu, 06 Mar 2014, Xiubo Li wrote: > > Since we cannot make sure the 'max_conn_count' will always be none > > zero from the users, and then if max_conn_count equals to zero, the > > kcalloc() will return

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-09 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. > > On Mon, Mar 03, 2014 at 07:24:36AM +0000, li.xi...@freescale.com wrote: > > > > > /* Default to using ALC auto offset calibration mode. */ > > > > snd_soc

RE: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. > > On 03/10/2014 08:38 AM, Mark Brown wrote: > > On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: > >> On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: > > >

RE: [PATCHv2 2/3] regmap: Add the DT binding documentation for endianness

2014-04-28 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 2/3] regmap: Add the DT binding documentation for > endianness > > On Wed, Apr 23, 2014 at 07:46:34AM +0100, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > --- > > .../bindings/regmap/regmap-endianness.txt | 48 > ++ > > 1 file changed, 48 in

RE: [PATCH 0/3] FTM PWM adds regmap and endianness support.

2014-04-28 Thread li.xi...@freescale.com
> > Xiubo Li (3): > > pwm: ftm-pwm: Clean up the code. > > pwm: ftm-pwm: Convert to direct regmap API usage. > > pwm: ftm-pwm: Add big-endian support > > > > drivers/pwm/pwm-fsl-ftm.c | 96 > > ++- > > 1 file changed, 53 insertions(+), 43 delet

  1   2   3   >