Re: [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe

2020-12-22 Thread Zheng Zengkai
dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai Reviewed-by: Martin Blumenstingl --- drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-meson

Re: [RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe

2020-12-23 Thread Zheng Zengkai
Hi Greg, On Wed, Dec 23, 2020 at 10:13:03AM +0800, Zheng Zengkai wrote: Hi everyone, Friendly ping: Just want to know why this patch was ignored, Right now it is the merge window and we can't do anything with any patches until 5.11-rc1 is out. After that happens, I'll work on c

Re: [PATCH] afs: fix no return statement in function returning non-void

2021-03-30 Thread Zheng Zengkai
eported-by: Hulk Robot Signed-off-by: Zheng Zengkai --- fs/afs/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 17548c1faf02..1795a05b7cb7 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct

[PATCH] afs: fix no return statement in function returning non-void

2021-03-27 Thread Zheng Zengkai
ned-off-by: Zheng Zengkai --- fs/afs/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 17548c1faf02..1795a05b7cb7 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset,

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-09 Thread Zheng Zengkai
Hi Anton and Andrew, Hi Andrew, Ah, oops! Thank you and apologies. Quite right the alternative patch was even better. No need to apply this patch after all... Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense. Best regards, Anton On 1

Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

2020-11-30 Thread Zheng Zengkai
Hi Felipe and Greg, Ping... On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() on one error handling path. This patch fixes that. Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A a

[PATCH] tomoyo: Avoid potential null pointer access

2020-11-25 Thread Zheng Zengkai
Calls to kzalloc() should be null-checked in order to avoid any potential failures or unnecessary code execution. Fix this by adding null checks for _entry_ right after allocation. Fixes: 57c2590fb7fd ("TOMOYO: Update profile structure") Reported-by: Hulk Robot Signed-off-by: Zhe

Re: [PATCH] tomoyo: Avoid potential null pointer access

2020-11-25 Thread Zheng Zengkai
thout tomoyo_warn_oom() is NG. On 2020/11/25 21:10, Zheng Zengkai wrote: Calls to kzalloc() should be null-checked in order to avoid any potential failures or unnecessary code execution. Fix this by adding null checks for _entry_ right after allocation. Fixes: 57c2590fb7fd ("TOMOYO: Update profile

[PATCH] tomoyo: Fix null pointer check

2020-11-26 Thread Zheng Zengkai
) Reported-by: Hulk Robot Suggested-by: Tetsuo Handa Signed-off-by: Zheng Zengkai --- security/tomoyo/common.c | 2 +- security/tomoyo/domain.c | 4 +--- security/tomoyo/memory.c | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/security/tomoyo/common.c b/security/tomoyo/co

[RESEND] usb: dwc3: meson-g12a: disable clk on error handling path in probe

2020-12-14 Thread Zheng Zengkai
dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() on one error handling path. This patch fixes that. Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai Reviewed-

Re: [PATCH] tomoyo: Avoid potential null pointer access

2020-11-26 Thread Zheng Zengkai
Hello Tetsuo, On 2020/11/26 15:33, Zheng Zengkai wrote: As your say,  I found the function tomoyo_assign_namespace( ) in security/tomoyo/domain.c has the similar situation, Can I add __GFP_NOWARN for both and remove the null check for _entry_ in tomoyo_assign_namespace( )? Good catch. Yes

Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

2020-11-26 Thread Zheng Zengkai
Ping... On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() on one error handling path. This patch fixes that. Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") R

Re: [PATCH -next] perf util: Fix memory leak in __parse_regs()

2020-11-26 Thread Zheng Zengkai
Ping... On Fri, Jul 03, 2020 at 05:33:44PM +0800, Zheng Zengkai wrote: when using perf record option '-I' or '--user-regs=' along with argument '?' to list available register names, memory of variable 'os' allocated by strdup() needs to be released

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-11-27 Thread Zheng Zengkai
1' as it is set. Signed-off-by: Zheng Zengkai --- fs/ntfs/logfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c index a0c40f1be7ac..c35fcf389369 100644 --- a/fs/ntfs/logfile.c +++ b/fs/ntfs/logfile.c @@ -507,7 +507,7 @@ bool ntfs_

[PATCH -next] perf util: Fix memory leak in __parse_regs()

2020-07-03 Thread Zheng Zengkai
65ad1 ("perf record: Add ability to name registers to record") Signed-off-by: Zheng Zengkai --- tools/perf/util/parse-regs-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c index

[PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

2020-11-11 Thread Zheng Zengkai
dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() on one error handling path. This patch fixes that. Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai --- drivers/usb

[PATCH] serial: ar933x_uart: disable clk on error handling path in probe

2020-11-11 Thread Zheng Zengkai
ar933x_uart_probe() does not invoke clk_disable_unprepare() on one error handling path. This patch fixes that. Fixes: 9be1064fe524 ("serial: ar933x_uart: add RS485 support") Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai --- drivers/tty/serial/ar933x_uart.c | 6 -- 1 file

[PATCH -next] ACPI: debug: Make two functions static

2020-05-07 Thread Zheng Zengkai
Fix sparse warnings: drivers/acpi/acpi_dbg.c:748:12: warning: symbol 'acpi_aml_init' was not declared. Should it be static? drivers/acpi/acpi_dbg.c:774:13: warning: symbol 'acpi_aml_exit' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Zheng Z

[PATCH net-next] net: phy: Make iproc_mdio_resume static

2020-05-07 Thread Zheng Zengkai
Fix sparse warnings: drivers/net/phy/mdio-bcm-iproc.c:182:5: warning: symbol 'iproc_mdio_resume' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai --- drivers/net/phy/mdio-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)