On 24.04.19 20:25, Pawnikar, Sumeet R wrote:
>> +/*
>> + * If the temperature value in deci-Kelvin is near the absolute
>> + * zero temperature, something is clearly wrong.
>> + */
>> +if (!value || value == 1)
>> +return 0;
> Do you still need to return 0 in case of
R DAEMON
If you're testing with GNOME, notice that UPower does hang pretty badly if
the module is removed at runtime at least on my device. Stop it with
'systemctl stop upower' before removing the module and then restart it
again.
[1] https://github.com/hackbnw/faustus
[2] https://lwn.
: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index ee1fa93708ec..6b736a9375ef 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers
implementation.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 6b736a9375ef..0fbb947b07c4 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b
or a new method passing value 0 for the last
parameter. The new function will be used to control RGB keyboard
backlight.
Signed-off-by: Yurii Pavlovskyi
---
One of current kernel errors:
ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Field [IIA2] at bit offset/
length 64/32 exceeds size o
}
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-nb-wmi.c | 5 +
drivers/platform/x86/asus-wmi.c| 16 +---
drivers/platform/x86/asus-wmi.h| 5 +
3 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers
is quirk is
present in the future.
This patch limits the effect to the specific hardware defined by ASUS7000
device that is used for driver detection by vendor driver of Fx505. The
fallback is also implemented in case initial flush fails.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x
The microphone mute key that is present on FX505GM laptop and possibly
others is missing from sparse keymap. Add the missing code.
Also comment on the fan mode switch key that has the same code as the
already used key.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-nb-wmi.c | 3
The driver has grown (and will more) pretty big which makes it hard to
navigate and understand. Add uniform comments to the code and ensure that
it is sorted into logical sections.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 94 -
1 file
value in addition to 0 K.
* Refactor detection of thermal input availability to a separate function.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 46 -
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86
ad, 08 - awake, 20 - sleep,
echo 2a or ff to set all
echo 2a > /sys/devices/platform/asus-nb-wmi/kbbl/kbbl_flags
echo Save: 1 - permanently, 2 - temporarily, reset after reboot
echo 1 > /sys/devices/platform/asus-nb-wmi/kbbl/kbbl_set
Signed-off-by: Yurii Pavlovskyi
---
.../ABI/te
a quiet mode as CPU
temperature does increase about 10 degrees on maximum load.
Signed-off-by: Yurii Pavlovskyi
---
.../ABI/testing/sysfs-platform-asus-wmi | 10 ++
drivers/platform/x86/asus-wmi.c | 119 --
include/linux/platform_data/x86/asus-wmi.h| 1
The keyboard backlight is disabled when module is unloaded as it is
exposed as LED device. Change this behavior to ignore setting 0 brightness
when the ledclass device is unloading.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 4
1 file changed, 4 insertions
Hi,
sorry, just realized, I've broken the logging. I will re-post patches 04 to 11
as replies to original ones, 1 to 3 were ok.
}
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-nb-wmi.c | 5 +
drivers/platform/x86/asus-wmi.c| 14 --
drivers/platform/x86/asus-wmi.h| 5 +
3 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers
is quirk is
present in the future.
This patch limits the effect to the specific hardware defined by ASUS7000
device that is used for driver detection by vendor driver of Fx505. The
fallback is also implemented in case initial flush fails.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x
The driver has grown (and will more) pretty big which makes it hard to
navigate and understand. Add uniform comments to the code and ensure that
it is sorted into logical sections.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 94 -
1 file
The microphone mute key that is present on FX505GM laptop and possibly
others is missing from sparse keymap. Add the missing code.
Also comment on the fan mode switch key that has the same code as the
already used key.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-nb-wmi.c | 3
value in addition to 0 K.
* Refactor detection of thermal input availability to a separate function.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 45 -
1 file changed, 38 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86
ad, 08 - awake, 20 - sleep,
echo 2a or ff to set all
echo 2a > /sys/devices/platform/asus-nb-wmi/kbbl/kbbl_flags
echo Save: 1 - permanently, 2 - temporarily, reset after reboot
echo 1 > /sys/devices/platform/asus-nb-wmi/kbbl/kbbl_set
Signed-off-by: Yurii Pavlovskyi
---
.../ABI/te
a quiet mode as CPU
temperature does increase about 10 degrees on maximum load.
Signed-off-by: Yurii Pavlovskyi
---
.../ABI/testing/sysfs-platform-asus-wmi | 10 ++
drivers/platform/x86/asus-wmi.c | 119 --
include/linux/platform_data/x86/asus-wmi.h| 1
The keyboard backlight is disabled when module is unloaded as it is
exposed as LED device. Change this behavior to ignore setting 0 brightness
when the ledclass device is unloading.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 4
1 file changed, 4 insertions
On 08.05.19 15:36, Andy Shevchenko wrote:> On Fri, Apr 19, 2019 at 1:08 PM
Yurii Pavlovskyi
> wrote:
>> int rv;
>> + char *wmi_uid;
>
> Keep them in reversed spruce order.
What do you mean by that? Do you mean like this?
+ char *wmi_uid;
int r
On 08.05.19 15:47, Andy Shevchenko wrote:
> On Fri, Apr 19, 2019 at 1:10 PM Yurii Pavlovskyi
> wrote:
>
> It's rather a big change. Can it be split to smaller pieces?
>
I will then split this into refactoring event code handling in separate
methods and actual event queue support patches.
On 08.05.19 15:58, Andy Shevchenko wrote:
> On Fri, Apr 19, 2019 at 1:12 PM Yurii Pavlovskyi
> wrote:
>
>> - if (value == ASUS_WMI_UNSUPPORTED_METHOD || value &
>> 0xFFF8
>> + if (value == ASUS_WMI_UNSUPPORTED_METHOD || (value &
First of all, thanks to Andy for all the review comments!
I will implement all the ones that I didn't directly answer on as well and
update this series shortly.
Regarding this patch,
On 08.05.19 19:12, Pavel Machek wrote:
>> Shouldn't be the LED subsystem driver for this?
>
> Yes, please. We ha
tps://lkml.org/lkml/2019/4/10/973
Thread for V3: https://lkml.org/lkml/2019/4/19/178
Yurii Pavlovskyi (13):
platform/x86: asus-wmi: Fix hwmon device cleanup
platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on
load
platform/x86: asus-wmi: Increase input buffer size of W
.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index f94691615881..62567766bdfb 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers
implementation.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 62567766bdfb..84d7fc6f941c 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b
The new function will be used to control RGB keyboard
backlight.
Signed-off-by: Yurii Pavlovskyi
---
One of current kernel errors:
ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Field [IIA2] at bit offset/
length 64/32 exceeds size of target Buffer (64 bits)
(20190215/dsop
device that declares the
given GUID, to which it is also mapped by other methods of wmi module.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/wmi.c | 19 +++
include/linux/acpi.h | 1 +
2 files changed, 20 insertions(+)
diff --git a/drivers/platform/x86/
))
{
...
Return (Zero)
}
...
// No return
}
K54C (_UID ATK):
Method (WMNB, 3, Serialized)
{ ...
If ((Local0 == 0x53545344))
{
...
Return (0x02)
}
...
Return (0xFFFE)
}
[1] Link: https://lkml.org/lkml/2019/4/11/322
Signed-off-by: Yurii Pavlovskyi
Suggested-by
Refactor WMI event handling into separate functions for getting the event
code and handling the retrieved event code as a preparation for
introduction of WMI event queue support.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 66 +
1 file
https://lkml.org/lkml/2019/4/12/104
Signed-off-by: Yurii Pavlovskyi
Suggested-by: Daniel Drake
---
drivers/platform/x86/asus-wmi.c | 73 ++---
1 file changed, 68 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm
The microphone mute key is missing from sparse keymap. It is present on
FX505GM and possibly other laptops. Add the missing code.
Also, comment on the fan mode switch key, which has the same code as the
already used key.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-nb-wmi.c
Remove exit label as it is only used once from the point in code where no
cleanup is required and return can be called immediately.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/platform/x86
The driver has grown pretty big and will grow more, which makes it hard to
navigate and understand. Add uniform comments to the code and ensure that
it is sorted into logical sections.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 89 +
1
value in addition to 0 K.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index bd9eb00f3a27..ffb4e2530ea4 100644
--- a/drivers/platform
availability according to DSTS.
Modes:
* 0x00 - normal or balanced,
* 0x01 - overboost, increased fan RPM,
* 0x02 - silent, decreased fan RPM
[1] Link: https://lkml.org/lkml/2019/4/12/110
Signed-off-by: Yurii Pavlovskyi
Suggested-by: Daniel Drake
---
.../ABI/testing/sysfs-platform-asus-wmi
The keyboard backlight is automatically disabled when the module is
unloaded as it is exposed as a ledclass device. Change this behavior to
ignore setting brightness when the device is in unloading state.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 4
1 file
before module load, 08 - awake, 20 - sleep,
echo 2a or ff to set all
echo 2a > /sys/devices/platform/asus-nb-wmi/kbbl/kbbl_flags
echo Save: 1 - permanently, 2 - temporarily, reset after reboot
echo 1 > /sys/devices/platform/asus-nb-wmi/kbbl/kbbl_set
Signed-off-by: Yurii Pavlovskyi
---
existing minor issues
(other than quirks, which should be hopefully solved now).
Yurii Pavlovskyi (11):
platform/x86: asus-wmi: Fix hwmon device cleanup
platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on
load
platform/x86: asus-wmi: Increase the input buffer size of WMI
//lkml.org/lkml/2019/4/12/104
Signed-off-by: Yurii Pavlovskyi
Suggested-by: Daniel Drake
---
drivers/platform/x86/asus-wmi.c | 136 +---
1 file changed, 108 insertions(+), 28 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm
The driver has grown pretty big and will grow more, which makes it hard to
navigate and understand. Add uniform comments to the code and ensure that
it is sorted into logical sections.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 94 -
1
The new function will be used to control RGB keyboard
backlight.
Signed-off-by: Yurii Pavlovskyi
---
One of current kernel errors:
ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Field [IIA2] at bit offset/
length 64/32 exceeds size of target Buffer (64 bits)
(20190215/dsop
The keyboard backlight is automatically disabled when the module is
unloaded as it is exposed as a ledclass device. Change this behavior to
ignore setting brightness when the device is in unloading state.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 4
1 file
.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index ee1fa93708ec..d865eb95054c 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers
implementation.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index d865eb95054c..731ffd382426 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b
The microphone mute key is missing from sparse keymap. It is present on
FX505GM and possibly other laptops. Add the missing code.
Also, comment on the fan mode switch key, which has the same code as the
already used key.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-nb-wmi.c
turn (0x02)
}
...
Return (0xFFFE)
}
[1] https://lkml.org/lkml/2019/4/11/322
Signed-off-by: Yurii Pavlovskyi
Suggested-by: Daniel Drake
---
drivers/platform/x86/asus-wmi.c| 20 ++--
drivers/platform/x86/wmi.c | 19 +++
inc
value in addition to 0 K.
* Refactor detection of thermal input availability to a separate function.
Signed-off-by: Yurii Pavlovskyi
---
drivers/platform/x86/asus-wmi.c | 45 -
1 file changed, 38 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86
availability according to DSTS.
Modes:
* 0x00 - normal or balanced,
* 0x01 - overboost, increased fan RPM,
* 0x02 - silent, decreased fan RPM
[1] https://lkml.org/lkml/2019/4/12/110
Signed-off-by: Yurii Pavlovskyi
Suggested-by: Daniel Drake
---
.../ABI/testing/sysfs-platform-asus-wmi
On 11.04.19 10:21, Daniel Drake wrote:
> On Thu, Apr 11, 2019 at 4:21 AM Yurii Pavlovskyi
> wrote:
>>
>> The asus-wmi driver does not clean up the hwmon device on exit or error.
>> To reproduce the bug, repeat rmmod, insmod to verify that device number
>> /sys/devi
wrote:
> On Thu, Apr 11, 2019 at 4:28 AM Yurii Pavlovskyi
> wrote:
>> The DSTS method detection fails, as nothing is returned if method is not
>> defined in WMNB. As a result the control of keyboard backlight is not
>> functional for TUF Gaming series laptops (at the time the
On 12.04.19 09:48, Daniel Drake wrote:
> On Thu, Apr 11, 2019 at 1:44 PM Yurii Pavlovskyi
> wrote:
>> Event codes are expected to be polled from a queue on at least some
>> models.
>
> Maybe avoid the word "poll" since it suggests something else (at least to
On 12.04.19 10:03, Daniel Drake wrote:
> On Thu, Apr 11, 2019 at 1:47 PM Yurii Pavlovskyi
> wrote:
>> * 0x00 - is normal,
>> * 0x01 - is obviously turbo by the amount of noise, might be useful to
>> avoid CPU frequency throttling on high load,
>> * 0x02 - the mea
56 matches
Mail list logo
