On 08.05.19 15:36, Andy Shevchenko wrote:> On Fri, Apr 19, 2019 at 1:08 PM Yurii Pavlovskyi > <yurii.pavlovs...@gmail.com> wrote: >> int rv; >> + char *wmi_uid; > > Keep them in reversed spruce order.
What do you mean by that? Do you mean like this? + char *wmi_uid; int rv; int err; >> +#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS (DCTS) */ > > It's not clear from the description what 'C' stands for. > Is there any specification which describes the difference and actual > abbreviations? > Not that I know of. Daniel had written some research in the previous version thread regarding where it is used, but as I understand from current implementation the functional difference is not really there, as it serves the same purpose as DSTS, just for another hardware. On 09.05.19 08:08, Daniel Drake wrote: > For clarity I think the constants could be renamed as > ASUS_WMI_METHODID_DCTS and ASUS_WMI_METHODID_DSTS. > Agree, that'll be better. Thanks, Yurii
