Re: mm/vmemmap: fix wrong use of virt_to_page

2012-11-26 Thread Yasuaki Ishimatsu
* sizeof(struct page)) >> PAGE_SHIFT; - free_map_bootmem(memmap_page, nr_pages); + free_map_bootmem(memmap, nr_pages); } } Reviewed-by: Yasuaki Ishimatsu -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Yasuaki Ishimatsu
is correctly set at hotplug. But memory range is set by firmware and not changed. So if we set node2 as movable node by movablecore_map, the issue does not occur. Thanks, Yasuaki Ishimatsu -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [Patch v4 00/12] memory-hotplug: hot-remove physical memory

2012-11-27 Thread Yasuaki Ishimatsu
atches are only this patch-set. So we hope that this patch-set is merged into v3.8. In merging this patch-set into v3.8, Linux on x86_64 makes a memory hot plug possible. Thanks, Yasuaki Ishimatsu If you want to know the reason, please read following thread. https://lkml.org/lkml/2012/10/2

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Yasuaki Ishimatsu
een added, or a broken node removed the values would be stale. I don't think so. Even if we hot add/remove node, the memory range of each memory device is not changed. So we don't need to change the boot option. Thanks, Yasuaki Ishimatsu -Tony -- To unsubscribe from this list: s

Re: [PATCH v9 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-29 Thread Yasuaki Ishimatsu
2012/11/29 6:47, Yinghai Lu wrote: > So make init_memory_mapping smaller and readable. > > -v2: use 0 instead of nr_range as input parameter found by Yasuaki Ishimatsu. > > Suggested-by: Ingo Molnar > Signed-off-by: Yinghai Lu > Reviewed-by: Pekka Enberg > Reviewed-b

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-11-29 Thread Yasuaki Ishimatsu
In this case, the page used as PT/PMD can be freed. By the way, why is 0xFD? There is no reason. I just filled the page with unique number. Thanks, Yasuaki Ishimatsu + } + } + + free_pte_table(pmd); + __flush_tlb_all(); +} + +static void vmemmap_pmd_remove(pud_t

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Yasuaki Ishimatsu
atures so it's not a common solution for all architectures. I agree with you. If BIOS and hardware support memory hotplug, OS should use them. But if OS cannot use them, we need to solve in OS. I think that our proposal which used ZONE_MOVABLE is first step for supporting memory hotplug. T

[PATCH] Remove acpi_memory_info->failed bit

2013-03-17 Thread Yasuaki Ishimatsu
Hi Toshi, Sorry for the late reply 2013/03/13 23:50, Toshi Kani wrote: On Wed, 2013-03-13 at 15:54 +0900, Yasuaki Ishimatsu wrote: At http://marc.info/?l=linux-acpi&m=135769405622667&w=2 thread, Toshi Kani mentioned as follows: "I have a question about the change you made in co

Re: [PATCH] Remove acpi_memory_info->failed bit

2013-03-20 Thread Yasuaki Ishimatsu
Hi Toshi, 2013/03/20 0:03, Toshi Kani wrote: On Mon, 2013-03-18 at 11:19 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, Sorry for the late reply 2013/03/13 23:50, Toshi Kani wrote: On Wed, 2013-03-13 at 15:54 +0900, Yasuaki Ishimatsu wrote: At http://marc.info/?l=linux-acpi&m=1357694056226

[Bug fix PATCH v2 1/2] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time

2013-03-20 Thread Yasuaki Ishimatsu
pports hotplug, memory presented at boot-time cannot be hot removed since the memory device's acpi_memory_info->enabled is always 0. This patch changes to set 1 to "acpi_memory_info->enabled" of memory device presented at boot-time for hot removing the memory device. Signed-o

[PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit

2013-03-20 Thread Yasuaki Ishimatsu
acpi_memory_info has enabled bit and failed bit for controlling memory hotplug. But we don't need to keep both bits. The patch removes acpi_memory_info->failed bit. Signed-off-by: yasuaki ishimatsu --- v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge. ---

Re: [Bug fix PATCH v2 1/2] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time

2013-03-20 Thread Yasuaki Ishimatsu
The mail's tab become spaces. So I attached origianl patch. Thanks, Yasuaki Ishimatsu 2013/03/21 13:36, Yasuaki Ishimatsu wrote: At http://marc.info/?l=linux-acpi&m=135769405622667&w=2 thread, Toshi Kani mentioned as follows: "I have a question about the change you made in

Re: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit

2013-03-20 Thread Yasuaki Ishimatsu
The mail's tab become spaces. So I attached origianl patch. Thanks, Yasuaki Ishimatsu 2013/03/21 13:39, Yasuaki Ishimatsu wrote: acpi_memory_info has enabled bit and failed bit for controlling memory hotplug. But we don't need to keep both bits. The patch removes acpi_memory_info-&

Re: [PATCH v2 1/4] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c

2013-02-04 Thread Yasuaki Ishimatsu
ernel/acpi/srat.c | 197 > +++ > arch/x86/mm/srat.c | 197 > --- > 2 files changed, 197 insertions(+), 197 deletions(-) > create mode 100644 arch/x86/kernel/acpi/srat.c > delete mode 100644 arch/x86/mm/srat.c Changes of Makefi

Re: [PATCH v2 2/4] numa: avoid export acpi_numa variable

2013-02-04 Thread Yasuaki Ishimatsu
e/enable numa in acpi > mode which was a bad thing, so, try to > export a fuction to get srat table > enable/disable info. The patch is wrong. By the patch, acpi_numa is set to one of three values, either -1, false(0), 1. By this, x86_acpi_numa_init() goes wrong. How about using bool to

Re: [PATCH v2 3/4] acpi: add clock_domain field to acpi_srat_cpu_affinity

2013-02-04 Thread Yasuaki Ishimatsu
2013/02/05 11:37, liguang wrote: > according to ACPI SPEC v5.0, page 152, > 5.2.16.1 Processor Local APIC/SAPIC Affinity Structure, > the last member of it is clock_domain. > > Signed-off-by: liguang > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu >

Re: [PATCH v2 4/4] remove include asm/acpi.h in process_driver.c

2013-02-04 Thread Yasuaki Ishimatsu
2013/02/05 11:37, liguang wrote: > process_driver.c include linux/acpi.h which already > include asm/acpi.h, so remove it. > > Signed-off-by: liguang > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > drivers/acpi/processor_driver.c |1 - > 1 files

Re: [PATCH v3 2/4] numa: avoid export acpi_numa variable

2013-02-04 Thread Yasuaki Ishimatsu
numa as bool, you should use "acpi_numa = true" instead of "acpi_numa = 1" Thanks, Yasuaki Ishimatsu > arch/x86/include/asm/acpi.h |2 +- > arch/x86/kernel/acpi/srat.c | 17 +++-- > arch/x86/mm/numa.c |2 +- > arch/x86/xen/enlighten.

Re: [PATCH v3 1/4] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c

2013-02-04 Thread Yasuaki Ishimatsu
2013/02/05 16:35, liguang wrote: > srat table should present only on acpi domain, > seems mm/ is not the right place for it. > > Signed-off-by: liguang > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > arch/x86/kernel/acpi/Makefile |1 + > arch/x

Re: [PATCH v3 2/4] numa: avoid export acpi_numa variable

2013-02-05 Thread Yasuaki Ishimatsu
2013/02/05 16:55, Yasuaki Ishimatsu wrote: > 2013/02/05 16:36, liguang wrote: >> acpi_numa is used to prevent srat table >> being parsed, seems a little miss-named, >> if 'noacpi' was specified by cmdline and >> CONFIG_ACPI_NUMA was enabled, acpi_numa >>

Re: [PATCH 2/2] ACPI / scan: Simplify container driver

2013-02-07 Thread Yasuaki Ishimatsu
1 @@ void acpi_memory_hotplug_init(void); #else static inline void acpi_memory_hotplug_init(void) {} #endif +#ifdef ACPI_CONTAINER It should be CONFIG_ACPI_CONTAINER. By this, acpi_container_init() do nothing. When I fix it and test the patch, the patch goes well. If you update the pat

Re: [PATCH 01/02] ACPI: sysfs eject support for ACPI scan handlers

2013-02-07 Thread Yasuaki Ishimatsu
if either acpi_device->driver or acpi_device->handler has pointer. Is it O.K.? I think it should be if (!acpi_device->driver || !acpi_device->handler). Thanks, Yasuaki Ishimatsu > ret = -ENODEV; > goto err; > } > -- > To unsubscribe f

Re: [PATCH 01/02] ACPI: sysfs eject support for ACPI scan handlers

2013-02-07 Thread Yasuaki Ishimatsu
2013/02/08 10:10, Toshi Kani wrote: On Fri, 2013-02-08 at 09:50 +0900, Yasuaki Ishimatsu wrote: Hi Toshi, 2013/02/07 7:50, Toshi Kani wrote: Changed sysfs eject, acpi_eject_store(), to support ACPI scan handlers. Signed-off-by: Toshi Kani --- drivers/acpi/scan.c |2 +- 1 file

Re: [PATCH 0/2] ACPI / scan: Remove useless #ifndef and simplify container driver

2013-02-07 Thread Yasuaki Ishimatsu
[2/2] is an improved version of this (with Toshi's changes folded in). Patch [1/2] is just a cleanup removing a useless #ifndef from acpi_eject_store(). I confimed the patch series works well. Acked-by: Yasuaki Ishimatsu Tested-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu Thanks, R

Re: [PATCH] ACPI / hotplug: Fix concurrency issues and memory leaks

2013-02-12 Thread Yasuaki Ishimatsu
pported event [0x%x]\n", event)); /* non-hotplug event; possibly handled by other handler */ - return; + goto out; } /* Inform firmware that the hotplug operation has completed */ (void) acpi_evaluate_hotplug_ost(handle, event, ost_code, NULL); -

Re: [PATCH] ACPI / hotplug: Fix concurrency issues and memory leaks

2013-02-12 Thread Yasuaki Ishimatsu
Hi Rafael, I have another comment at container.c. 2013/02/13 12:08, Yasuaki Ishimatsu wrote: Hi Rafael, The patch seems good. There is a comment below. 2013/02/13 9:19, Rafael J. Wysocki wrote: From: Rafael J. Wysocki This changeset is aimed at fixing a few different but related problems

Re: [PATCH v3 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit

2013-04-02 Thread Yasuaki Ishimatsu
Hi Rafael, 2013/04/02 21:57, Rafael J. Wysocki wrote: On Tuesday, April 02, 2013 09:12:44 AM Yasuaki Ishimatsu wrote: Hi Rafael, 2013/04/02 8:48, Rafael J. Wysocki wrote: On Thursday, March 28, 2013 08:58:03 AM Yasuaki Ishimatsu wrote: Hi Rafael, 2013/03/26 22:41, Rafael J. Wysocki wrote

Re: [PATCH 1/3] resource: Add __adjust_resource() for internal use

2013-04-02 Thread Yasuaki Ishimatsu
ly while the resource_lock is > held. > > Signed-off-by: Toshi Kani The patch looks good. Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > --- > kernel/resource.c | 35 ++- > 1 file changed, 22 insertions(+), 13 deletio

Re: [PATCH 2/3] resource: Add release_mem_region_adjustable()

2013-04-02 Thread Yasuaki Ishimatsu
if (res->start == start && res->end == end) { > + /* free the whole entry */ > + *p = res->sibling; > + kfree(res); > + } else if (res->start == start && res->e

Re: [PATCH 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable()

2013-04-02 Thread Yasuaki Ishimatsu
ceed as it was the case > with release_mem_region(). release_mem_region(), which is defined > to __release_region(), logs an error message and returns no error > since a void function. > > Signed-off-by: Toshi Kani The patch looks good. Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Is

Re: [PATCH 1/4] ACPI / scan: Introduce struct acpi_scan_handler

2013-01-28 Thread Yasuaki Ishimatsu
socki --- Acked-by: Yasuaki Ishimatsu I have a comment. Please see below. Documentation/acpi/scan_handlers.txt | 77 +++ drivers/acpi/scan.c | 60 --- include/acpi/acpi_bus.h | 14 ++ 3 files cha

Re: [PATCH 4/4] ACPI / platform: Use struct acpi_scan_handler for creating devices

2013-01-28 Thread Yasuaki Ishimatsu
= acpi_create_platform_clks(adev); dev_err(&adev->dev, "failed to create clocks\n"); - return NULL; + return ret; } If (flag & ACPI_PLATFORM_CLK) is true, the acpi_create_platform_device() always retruns with dev_err() messages. Wh

Re: [PATCH 1/4] ACPI / scan: Introduce struct acpi_scan_handler

2013-01-28 Thread Yasuaki Ishimatsu
2013/01/29 11:04, Yasuaki Ishimatsu wrote: Hi Rafael, 2013/01/28 21:59, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Introduce struct acpi_scan_handler for representing objects that will do configuration tasks depending on ACPI device nodes' hardware IDs (HIDs). Currently, those

Re: [Update][PATCH 4/4] ACPI / platform: Use struct acpi_scan_handler for creating devices

2013-01-29 Thread Yasuaki Ishimatsu
2013/01/29 21:30, Rafael J. Wysocki wrote: On Tuesday, January 29, 2013 12:36:35 PM Rafael J. Wysocki wrote: On Tuesday, January 29, 2013 11:20:44 AM Yasuaki Ishimatsu wrote: Hi Rafael, 2013/01/28 22:01, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Currently, the ACPI namespace

Re: [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()

2013-01-30 Thread Yasuaki Ishimatsu
ve no objection. Acked-by: Yasuaki Ishimatsu drivers/acpi/scan.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-pm/drivers/acpi/scan.c === --- linux-pm.orig/drivers/acpi/scan.c +++ linux-pm/drivers/acpi/s

[PATCH 0/4] Fix acpi_bus_get_device() check

2013-01-30 Thread Yasuaki Ishimatsu
Some functions use ACPI_SUCCESS/FAILURE for checking return value of acpi_bus_get_device(). Following patches change not to apply ACPI_SUCCESS/FAILURE to the return value of acpi_bus_get_device(). [PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c [PATCH 2/4] ACPI/d

Re: [PATCH 0/4] Fix acpi_bus_get_device() check

2013-01-30 Thread Yasuaki Ishimatsu
acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/device_pm.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-pm/drivers

Re: [PATCH 0/4] Fix acpi_bus_get_device() check

2013-01-30 Thread Yasuaki Ishimatsu
acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_SUCCESS() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/dock.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/acpi/dock.c

Re: [PATCH 0/4] Fix acpi_bus_get_device() check

2013-01-30 Thread Yasuaki Ishimatsu
acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/pnp/pnpacpi/core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-pm

Re: [PATCH 0/4] Fix acpi_bus_get_device() check

2013-01-30 Thread Yasuaki Ishimatsu
acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/gpu/drm/i915/intel_opregion.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm

[RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c

2013-01-30 Thread Yasuaki Ishimatsu
I fogot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/device_pm.c |6 +++--- 1 file changed, 3

[RESEND PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c

2013-01-30 Thread Yasuaki Ishimatsu
I forgot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_SUCCESS() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/dock.c |2 +- 1 file changed, 1 insertion

[RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c

2013-01-30 Thread Yasuaki Ishimatsu
I forgot to chnage subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/pnp/pnpacpi/core.c | 10 +- 1 file changed

[RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c

2013-01-30 Thread Yasuaki Ishimatsu
I forgot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu --- drivers/gpu/drm/i915/intel_opregion.c |2 +- 1 file

Re: [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent()

2013-01-30 Thread Yasuaki Ishimatsu
2013/01/31 7:04, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Make acpi_bus_get_parent() more straightforward and remove an unnecessary local variable ret from it. Signed-off-by: Rafael J. Wysocki --- Acked-by: Yasuaki Ishimatsu drivers/acpi/scan.c | 16 +--- 1 file

Re: [PATCH V3] suspend: enable freeze timeout configuration through sys

2013-01-30 Thread Yasuaki Ishimatsu
-#define TIMEOUT(20 * HZ) +unsigned int __read_mostly sys_freeze_process_timeout_msecs = 2; 2 does not mean 20 seconds since we can select HZ other than 1000. So (20 * HZ) is better than 20000. Thanks, Yasuaki Ishimatsu static int try_to_freeze_tasks(bool user_only)

Re: [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c

2013-01-31 Thread Yasuaki Ishimatsu
Hi Rafael, 2013/02/01 5:21, Rafael J. Wysocki wrote: On Thursday, January 31, 2013 12:22:14 PM Yasuaki Ishimatsu wrote: I fogot to change subject. So I resend a patch. I have applied patches [1-3/4] to my bleeding-edge branch, Thanks. but please note that something (probably your MUA

[UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c

2013-01-31 Thread Yasuaki Ishimatsu
2013/01/31 19:03, Daniel Vetter wrote: On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: I forgot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of

Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c

2013-01-31 Thread Yasuaki Ishimatsu
2013/02/01 9:50, Yasuaki Ishimatsu wrote: 2013/01/31 19:03, Daniel Vetter wrote: On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: I forgot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply

Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c

2013-01-31 Thread Yasuaki Ishimatsu
2013/02/01 9:53, Yasuaki Ishimatsu wrote: 2013/02/01 9:50, Yasuaki Ishimatsu wrote: 2013/01/31 19:03, Daniel Vetter wrote: On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: I forgot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status

Re: [PATCH V3] suspend: enable freeze timeout configuration through sys

2013-01-31 Thread Yasuaki Ishimatsu
2013/02/01 10:33, Li, Fei wrote: -Original Message- From: Rafael J. Wysocki [mailto:r...@sisk.pl] Sent: Friday, February 01, 2013 6:29 AM To: anish singh; Li, Fei Cc: Yasuaki Ishimatsu; a...@linux-foundation.org; linux-kernel@vger.kernel.org; linux...@vger.kernel.org; Liu, Chuansheng

Re: [PATCH] block: partition: optimize memory allocation in check_partition

2013-02-01 Thread Yasuaki Ishimatsu
truct hd_struct *part; 418 int p, highest, res; 419 rescan: 420 if (state && !IS_ERR(state)) { 421 kfree(state); 422 state = NULL; 423 } At least, you should use release_partitions() instead of kfree() here. Thanks, Yasuaki Ishimatsu >

Re: [PATCH] ACPI / scan: Make it clear that acpi_bus_trim() cannot fail

2013-01-24 Thread Yasuaki Ishimatsu
2013/01/25 7:56, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Since acpi_bus_trim() cannot fail, change its definition to a void function, so that its callers don't check the return value in vain and update the callers. Signed-off-by: Rafael J. Wysocki --- Acked-by: Yasuaki Ishi

Re: [PATCH] ACPI: Add sysfs links from memory device to memblocks

2013-02-24 Thread Yasuaki Ishimatsu
ion_nr)) > + continue; > + > + mem_sect = __nr_to_section(section_nr); > + > + /* skip if the same memblock */ > + if (mem_blk) > + if ((section_nr >= mem_blk->start_section_nr) && >

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Yasuaki Ishimatsu
instead? Where, if set, it would meand "do not autoeject and emit KOBJ_OFFLINE/ONLINE uevents like the old container driver did"? It's good idea. Thanks, Yasuaki Ishimatsu Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Yasuaki Ishimatsu
2013/02/26 10:09, Toshi Kani wrote: On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: 2013/02/26 8:39, Rafael J. Wysocki wrote: On Monday, February 25, 2013 11:07:52 AM Toshi Kani wrote: On Sat, 2013-02-23 at 22:38 +, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple

Re: [Update 4][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-25 Thread Yasuaki Ishimatsu
2013/02/26 12:11, Rafael J. Wysocki wrote: On Tuesday, February 26, 2013 11:02:56 AM Yasuaki Ishimatsu wrote: 2013/02/26 10:09, Toshi Kani wrote: On Tue, 2013-02-26 at 09:40 +0900, Yasuaki Ishimatsu wrote: 2013/02/26 8:39, Rafael J. Wysocki wrote: On Monday, February 25, 2013 11:07:52 AM

Re: [PATCH v2] ACPI: Add sysfs links from memory device to memblocks

2013-02-25 Thread Yasuaki Ishimatsu
ory9 > > Signed-off-by: Toshi Kani > --- I confirmed that the patch has no problem. Feel free to add: Tested-by: Yasuaki Ishimatsu Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > > This patch applies on top of the Rafael's patch below. > https://patchwork.ke

Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!

2013-02-25 Thread Yasuaki Ishimatsu
specification in ACPI spec revision 5.0. But this table does not have hotpluggable information. So we cannot know which memory device can hotplug from this table. Thanks, Yasuaki Ishimatsu Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!

2013-02-26 Thread Yasuaki Ishimatsu
The system would not boot as not enough memory for cover whole system RAM. Even if we solve your above mentions, the system cannot boot. In this case, user should: o add ram to first cpu o decreases hotpluggable ram by : - changing hotpluggable information of

Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!

2013-02-26 Thread Yasuaki Ishimatsu
2013/02/27 11:30, Yinghai Lu wrote: On Tue, Feb 26, 2013 at 4:52 PM, Yasuaki Ishimatsu wrote: 2013/02/27 7:44, Yinghai Lu wrote: that commit is totally broken, and it should be reverted. 1. numa_init is called several times, NOT just for srat. so those nodes_clear(numa_nodes_parsed

Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!

2013-02-26 Thread Yasuaki Ishimatsu
2013/02/27 13:04, Yinghai Lu wrote: On Tue, Feb 26, 2013 at 7:38 PM, Yasuaki Ishimatsu wrote: 2013/02/27 11:30, Yinghai Lu wrote: Do you mean you can not boot one socket system with 1G ram ? Assume socket 0 does not support hotplug, other 31 sockets support hot plug. So we could boot system

Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!

2013-02-26 Thread Yasuaki Ishimatsu
2013/02/27 14:11, Yinghai Lu wrote: On Tue, Feb 26, 2013 at 8:43 PM, Yasuaki Ishimatsu wrote: 2013/02/27 13:04, Yinghai Lu wrote: On Tue, Feb 26, 2013 at 7:38 PM, Yasuaki Ishimatsu wrote: 2013/02/27 11:30, Yinghai Lu wrote: Do you mean you can not boot one socket system with 1G ram

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-18 Thread Yasuaki Ishimatsu
t); - if (ACPI_FAILURE(status)) { - put_device(&acpi_device->dev); - kfree(ej_event); + acpi_evaluate_hotplug_ost(acpi_device->handle, ost_source, + ACPI_OST_SC_EJECT_IN_PROGRESS, NULL); + get_device(&acpi_device-

Re: [PATCH 1/7] ACPI / scan: Introduce acpi_scan_match_handler()

2013-02-18 Thread Yasuaki Ishimatsu
for other purposes going forward). Signed-off-by: Rafael J. Wysocki --- Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu drivers/acpi/scan.c | 53 +++- 1 file changed, 28 insertions(+), 25 deletions(-) Index: test/drivers/acpi

Re: [PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-18 Thread Yasuaki Ishimatsu
2013/02/19 15:43, Yasuaki Ishimatsu wrote: Hi Rafael, I have comments. Please see below. 2013/02/18 0:21, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Multiple drivers handling hotplug-capable ACPI device nodes install notify handlers covering the same types of events in a very similar

Re: [PATCH 4/7] ACPI / scan: Introduce acpi_scan_handler_matching()

2013-02-19 Thread Yasuaki Ishimatsu
other purposes in the future). Signed-off-by: Rafael J. Wysocki --- Acked-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu drivers/acpi/scan.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) Index: test/drivers/acpi/scan.c

Re: [PATCH 7/7] ACPI / scan: Make memory hotplug driver use struct acpi_scan_handler

2013-02-19 Thread Yasuaki Ishimatsu
number is changed as follows: $ ls /sys/bus/acpi/devices/ PNP0C80:00 PNP0C80:03 => hot added memory device PNP0C80:04 => hot added memory device In this case, we cannot know PNP0C80:YY by memoryXX/phys_device file. Thanks, Yasuaki Ishimatsu + + /* Memory not associat

Re: [PATCH 2/2] block: partition: optimize memory allocation in check_partition

2013-02-20 Thread Yasuaki Ishimatsu
lipe Balbi > Signed-off-by: Ming Lei > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > block/partition-generic.c |4 ++-- > block/partitions/check.c | 37 - > block/partitions/check.h |4 +++- > 3 files cha

Re: [PATCH 7/7] ACPI / scan: Make memory hotplug driver use struct acpi_scan_handler

2013-02-20 Thread Yasuaki Ishimatsu
Hi Vasilis, 2013/02/20 19:42, Vasilis Liaskovitis wrote: Hi Yasuaki, On Wed, Feb 20, 2013 at 12:35:48PM +0900, Yasuaki Ishimatsu wrote: Hi Vasilis, 2013/02/20 3:11, Vasilis Liaskovitis wrote: Hi, On Sun, Feb 17, 2013 at 04:27:18PM +0100, Rafael J. Wysocki wrote: From: Rafael J. Wysocki

Re: [Update 3][PATCH 2/7] ACPI / scan: Introduce common code for ACPI-based device hotplug

2013-02-22 Thread Yasuaki Ishimatsu
enabled, it crashes in kobject_uevent() since the device is no longer valid. This patch fixes the problem. Reported-by: Toshi Kani Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/scan.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

Re: [PATCH v2, part1 25/29] mm/x86: use common help functions to free reserved pages

2013-03-12 Thread Yasuaki Ishimatsu
e_reserved_area() as follow: free_reserved_area(addr, end, POISON_FREE_INITMEM, what) Am I wrong? Thanks, Yasuaki Ishimatsu > #endif > } > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 474e28f..2ef81f1 100644 > --- a/arch/x86/mm/init_64

[Bug fix PATCH] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time

2013-03-12 Thread Yasuaki Ishimatsu
evice supports hotplug, memory presented at boot-time cannot be hot removed since the memory device's acpi_memory_info->enabled is always 0. This patch changes to set 1 to "acpi_memory_info->enabled" of memory device presented at boot-time for hot removing the memory device. Sign

Re: [PATCH v4] create sun sysfs file

2012-08-29 Thread Yasuaki Ishimatsu
Hi Len, Three weeks passed after I post the patch. All comments have already been applied to it. And I think there is no comments about it. So I want you to merge it into your tree. Thanks, Yasuaki Ishimatsu 2012/08/07 9:36, Yasuaki Ishimatsu wrote: > Even if a device has _SUN method, there

Re: [RFC v8 PATCH 13/20] memory-hotplug: check page type in get_page_bootmem

2012-09-04 Thread Yasuaki Ishimatsu
Hi Wen, 2012/09/04 12:46, Wen Congyang wrote: Hi, isimatu-san At 09/01/2012 05:30 AM, Andrew Morton Wrote: On Tue, 28 Aug 2012 18:00:20 +0800 we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu There is a possibility that get_page_bootmem() is called to the same page many times. So when

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Yasuaki Ishimatsu
h+0x16/0x1b ... Thanks, Yasuaki Ishimatsu 2012/09/10 17:58, Lai Jiangshan wrote: > A) Introduction: > > This patchset adds MOVABLE-dedicated node and online_movable for > memory-management. > > It is used for anti-fragmentation(hugepage, big-order allocation...), > hot-

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Yasuaki Ishimatsu
Hi Lai, 2012/09/11 10:22, Lai Jiangshan wrote: On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote: Hi Lai, Using memory_online to hot-added node's memory, the following kernel messages were shown. Is this a known issue? Thank you for your report. What operations did you have performed ?

Re: [RFC v9 PATCH 05/21] memory-hotplug: check whether memory is present or not

2012-09-10 Thread Yasuaki Ishimatsu
Hi Wen, 2012/09/11 11:15, Wen Congyang wrote: Hi, ishimatsu At 09/05/2012 05:25 PM, we...@cn.fujitsu.com Wrote: From: Yasuaki Ishimatsu If system supports memory hot-remove, online_pages() may online removed pages. So online_pages() need to check whether onlining pages are present or not

Re: [V4 PATCH 27/27] memory,hotplug: Don't modify the zone_start_pfn outside of zone_span_writelock()

2012-09-11 Thread Yasuaki Ishimatsu
Hi Lai, 2012/09/11 18:44, Lai Jiangshan wrote: On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote: Hi Lai, Using memory_online to hot-added node's memory, the following kernel messages were shown. Is this a known issue? Fixed. Subject: Don't modify the zone_start_pfn

hot-added cpu is not asiggned to the correct node

2012-09-11 Thread Yasuaki Ishimatsu
When I hot-added CPUs and memories simultaneously using container driver, all the hot-added CPUs were mistakenly assigned to node0. Accoding to my DSDT, hot-added CPUs and memorys have PXM#1. So in my system, these devices should be assigned to node1 as follows: --- Expected result ls /sys/device

Re: [PATCH 1/2] mm: refactor out __alloc_contig_migrate_alloc

2012-09-12 Thread Yasuaki Ishimatsu
2012/09/12 10:43, Minchan Kim wrote: > __alloc_contig_migrate_alloc can be used by memory-hotplug so > refactor out(move + rename as a common name) it into > page_isolation.c. > > Cc: Kamezawa Hiroyuki > Cc: Yasuaki Ishimatsu Reviewed-by: Yasuaki Ishimatsu Thanks, Yasua

Re: [PATCH 2/2] memory-hotplug: don't replace lowmem pages with highmem

2012-09-12 Thread Yasuaki Ishimatsu
r+0x0/0x24) from [] > (ret_fast_syscall+0x0/0x30) > " > > Memory-hotplug has same problem with CMA so [1]'s fix could be applied > with memory-hotplug, too. > > Fix it by reusing. > > [1] 6a6dccba2, mm: cma: don't replace lowmem pages with highmem > &g

memory-hotplug : possible circular locking dependency detected

2012-09-12 Thread Yasuaki Ishimatsu
When I offline a memory on linux-3.6-rc5, "possible circular locking dependency detected" messages are shown. Are the messages known problem? [ 201.596363] Offlined Pages 32768 [ 201.596373] remove from free list 14 1024 148000 [ 201.596493] remove from free list 140400 1024 148000 [ 201.5

Re: memory-hotplug : possible circular locking dependency detected

2012-09-13 Thread Yasuaki Ishimatsu
Hi Wen, 2012/09/14 15:02, Wen Congyang wrote: > At 09/13/2012 02:19 PM, Yasuaki Ishimatsu Wrote: >> When I offline a memory on linux-3.6-rc5, "possible circular >> locking dependency detected" messages are shown. >> Are the messages known problem? > > It is

Re: [PATCH RESEND] memory hotplug: fix a double register section info bug

2012-09-14 Thread Yasuaki Ishimatsu
hether your configuration is correct or not. Thus if it is correct, I want a comment of why the node check is needed. In usual configuration, a node does not span the other one. So it is natural that "pfn_to_nid(pfn) is same as "pgdat->node_id". Thus we

Re: [RFC v9 PATCH 00/21] memory-hotplug: hot-remove physical memory

2012-10-01 Thread Yasuaki Ishimatsu
Hi Chen, 2012/10/02 8:45, Ni zhan Chen wrote: On 10/01/2012 12:44 PM, Yasuaki Ishimatsu wrote: Hi Chen, 2012/09/29 17:19, Ni zhan Chen wrote: On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: From: Wen Congyang This patch series aims to support physical memory hot-remove. The patches

Re: [RFC v9 PATCH 01/21] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages()

2012-10-01 Thread Yasuaki Ishimatsu
Hi Kosaki-san, 2012/09/29 7:15, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 11:50 PM, Yasuaki Ishimatsu wrote: Hi Chen, 2012/09/28 11:22, Ni zhan Chen wrote: On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu remove_memory() only try to offline pages. It is

[PATCH 0/2] memory-hotplug : notification of memoty block's state

2012-10-02 Thread Yasuaki Ishimatsu
We are trying to implement a physical memory hot removing function as following thread. https://lkml.org/lkml/2012/9/5/201 But there is not enough review to merge into linux kernel. I think there are following blockades. 1. no physical memory hot removable system 2. huge patch-set If you ha

[Patch 1/2] memory-hotplug : Preparation to notify memory block's state at memory hot remove

2012-10-02 Thread Yasuaki Ishimatsu
Rientjes CC: Jiang Liu CC: Len Brown CC: Christoph Lameter Cc: Minchan Kim CC: Andrew Morton CC: KOSAKI Motohiro Signed-off-by: Wen Congyang Signed-off-by: Yasuaki Ishimatsu --- drivers/base/memory.c |9 +++-- include/linux/memory_hotplug.h |1 + mm/memory_hotp

[Patch 2/2] memory-hotplug : update memory block's state and notfy theinformation to userspace

2012-10-02 Thread Yasuaki Ishimatsu
id Rientjes CC: Jiang Liu CC: Len Brown CC: Christoph Lameter Cc: Minchan Kim CC: Andrew Morton CC: KOSAKI Motohiro Signed-off-by: Wen Congyang Signed-off-by: Yasuaki Ishimatsu --- drivers/base/memory.c | 31 +++ include/linux/memory_hotplug.

Re: [PATCH 0/2] memory-hotplug : notification of memoty block's state

2012-10-02 Thread Yasuaki Ishimatsu
2012/10/02 18:42, Ni zhan Chen wrote: > On 10/02/2012 04:25 PM, Yasuaki Ishimatsu wrote: >> We are trying to implement a physical memory hot removing function as >> following thread. >> >> https://lkml.org/lkml/2012/9/5/201 >> >> But there is not enough rev

Re: [PATCH 0/2] memory-hotplug : notification of memoty block's state

2012-10-02 Thread Yasuaki Ishimatsu
Hi Andrew, 2012/10/03 6:42, Andrew Morton wrote: On Tue, 2 Oct 2012 17:25:06 +0900 Yasuaki Ishimatsu wrote: remove_memory() offlines memory. And it is called by following two cases: 1. echo offline >/sys/devices/system/memory/memoryXX/state 2. hot remove a memory device In the 1st c

Re: [PATCH 0/2] memory-hotplug : notification of memoty block's state

2012-10-02 Thread Yasuaki Ishimatsu
Hi Chen, 2012/10/03 11:12, Ni zhan Chen wrote: On 10/03/2012 09:21 AM, Yasuaki Ishimatsu wrote: Hi Andrew, 2012/10/03 6:42, Andrew Morton wrote: On Tue, 2 Oct 2012 17:25:06 +0900 Yasuaki Ishimatsu wrote: remove_memory() offlines memory. And it is called by following two cases: 1. echo

[PATCH 0/4] acpi,memory-hotplug : implement framework for hot removing memory

2012-10-03 Thread Yasuaki Ishimatsu
We are trying to implement a physical memory hot removing function as following thread. https://lkml.org/lkml/2012/9/5/201 But there is not enough review to merge into linux kernel. I think there are following blockades. 1. no physical memory hot removable system 2. huge patch-set If you ha

Re: [PATCH v4] create sun sysfs file

2012-10-03 Thread Yasuaki Ishimatsu
Hi Len, Ping... Pleae merge the patch into your tree. Thanks, Yasuaki Ishimatsu 2012/09/24 11:31, Yasuaki Ishimatsu wrote: > Hi Len, > > Ping... > I want you to merge the patch into your tree for linux-3.7. > > Thanks, > Yasuaki Ishimatsu > > 2012/08/30 10:34, Yas

[PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-03 Thread Yasuaki Ishimatsu
From: Yasuaki Ishimatsu The memory device can be removed by 2 ways: 1. send eject request by SCI 2. echo 1 >/sys/bus/pci/devices/PNP0C80:XX/eject In the 1st case, acpi_memory_disable_device() will be called. In the 2nd case, acpi_memory_device_remove() will be called. acpi_memory_device_rem

[PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory()

2012-10-03 Thread Yasuaki Ishimatsu
From: Yasuaki Ishimatsu add_memory() hot adds a physical memory. But remove_memory does not hot remove a phsical memory. It only offlines memory. The name confuse us. So the patch renames remove_memory() to offline_memory(). We will use rename_memory() for hot removing memory. CC: David

[PATCH 3/6] acpi,memory-hotplug : add physical memory hotplug code to acpi_memhotplug.c

2012-10-03 Thread Yasuaki Ishimatsu
From: Yasuaki Ishimatsu For hot removing physical memory, the patch adds remove_memory() into acpi_memory_remove_memory(). But we cannot support physical memory hot remove. So remove_memory() do nothinig. CC: David Rientjes CC: Jiang Liu CC: Len Brown CC: Christoph Lameter Cc: Minchan Kim

[PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device

2012-10-03 Thread Yasuaki Ishimatsu
Kim CC: Andrew Morton CC: KOSAKI Motohiro CC: Yasuaki Ishimatsu Signed-off-by: Wen Congyang Signed-off-by: Yasuaki Ishimatsu --- drivers/acpi/acpi_memhotplug.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Index: linux-3.6/drivers/acpi/acpi_memhotplug.c

[PATCH 0/2] acpi,memory-hotplug : remove memory device by acpi_bus_remove()

2012-10-03 Thread Yasuaki Ishimatsu
The patch-set was divided from following thread's patch-set. https://lkml.org/lkml/2012/9/5/201 If you want to know the reason, please read following thread. https://lkml.org/lkml/2012/10/2/83 The patch exports "acpi_bus_remove()" for removing a acpi device from a acpi bus at memory hot plug.

  1   2   3   4   5   6   7   >