On Wed, Nov 28, 2012 at 03:46:08AM +0530, Jiang, Dave wrote:
> The existing code set a value in the PCI_CHANERRMSK_INT register
> for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that
> has been fixed when the hardware was released. There is no need for this
> code.
>
> Signe
On Mon, Mar 04, 2013 at 11:09:24AM +0200, Andy Shevchenko wrote:
> The first approach to get dmatest module more flexible and easier to play
> with.
> The amount of patches could be reduced, but I would like to get a comments
> first on smaller pieces. The entire series creates dmatest.txt file in
On Tue, Feb 19, 2013 at 10:33:53PM +0200, maxin.j...@gmail.com wrote:
> From: "Maxin B. John"
>
> Fix this compiler warning:
> warning: 'td_remove' defined but not used [-Wunused-function]
>
> Signed-off-by: Maxin B. John
Applied, thanks
> ---
> drivers/dma/timb_dma.c |2 +-
> 1 files cha
On Mon, Mar 04, 2013 at 02:36:27PM +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat
> Reviewed-by: Thierry Reding
Applied thanks
> ---
> drivers/dm
On Wed, Mar 06, 2013 at 02:56:05PM -0500, Matt Porter wrote:
> Add a dmaengine API to retrieve slave SG transfer limits.
>
> The API is optionally implemented by dmaengine drivers and when
> unimplemented will return a NULL pointer. A client driver using
> this API provides the required dma channe
On Wed, Mar 06, 2013 at 02:56:04PM -0500, Matt Porter wrote:
> Changes since v3:
> - Change api name to dma_get_slave_sg_limits() to avoid
> confusion with h/w caps which are static.
>
> Changes since v2:
> - Change to a separate slave sg specific api. Drop the
> generi
On Mon, Mar 11, 2013 at 04:30:26PM -0600, Stephen Warren wrote:
> From: Stephen Warren
>
> Tegra only supports, and always enables, device tree. Remove all ifdefs
> and runtime checks for DT support from the driver.
>
> Signed-off-by: Stephen Warren
Applied thanks
--
~Vinod
--
To unsubscribe f
On Tue, Mar 12, 2013 at 08:53:37PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p()
> references)
> the following section mismatch happens:
>
> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference
>
On Sun, Feb 24, 2013 at 04:36:09PM +0100, Markus Pargmann wrote:
> No DMA of-function alters the name, so this patch changes the name arguments
> to be constant. Most drivers will probably request DMA channels using a
> constant name.
>
> Signed-off-by: Markus Pargmann
Applied thanks
--
~Vinod
>
On Mon, Feb 25, 2013 at 04:46:26AM +0530, Syam Sidhardhan wrote:
> kfree on NULL pointer is a no-op.
>
> Signed-off-by: Syam Sidhardhan
Applied thanks
> ---
> drivers/dma/imx-dma.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/
On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote:
> In of_dma_controller_register() routine we are calling of_get_property() as an
> parameter to be32_to_cpup(). In case the property doesn't exist we will get a
> crash.
>
> This patch changes this code to check if we got a valid proper
On Mon, Mar 18, 2013 at 01:30:29PM +, Arnd Bergmann wrote:
> On Monday 18 March 2013, Shevchenko, Andriy wrote:
> > Hello!
> >
> > It seems the one (as I think good) question was left unanswered:
> > http://www.spinics.net/lists/arm-kernel/msg186120.html
> >
> > What is your opinions, comment
On Thu, Mar 21, 2013 at 03:48:50PM +0530, Viresh Kumar wrote:
> On 21 March 2013 15:16, Vinod Koul wrote:
> > On Fri, Mar 15, 2013 at 02:18:20PM +0530, Viresh Kumar wrote:
> >> In of_dma_controller_register() routine we are calling of_get_property()
> >> as an
>
On Thu, Mar 21, 2013 at 11:49:17AM +0200, Andy Shevchenko wrote:
> When we pause the channel after transfer is completed we might stuck in the
> dwc_chan_pause() because the FIFO_EMPTY flag will never be asserted. To avoid
> the endless loop we introduce a timeout here (*). The proper solution is t
On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote:
> Next time, please direct these mails to my Linaro id :)
>
> On Mon, Jan 28, 2013 at 4:34 PM, Andy Shevchenko
> wrote:
> > On some hardware configurations we have got the request line with the
> > offset.
> > The patch introduces con
On Wed, Jan 30, 2013 at 09:32:56AM +0200, Andy Shevchenko wrote:
> On Tue, 2013-01-29 at 20:57 +0530, Viresh Kumar wrote:
> > On Tue, Jan 29, 2013 at 10:52 AM, Mika Westerberg
> > wrote:
> > > We had a discusssion about this with Andy as well. The thing is that there
> > > is no way in current re
On Fri, Feb 08, 2013 at 09:25:11AM +0200, Andy Shevchenko wrote:
> On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar wrote:
> > On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
> > wrote:
> >> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar
> >> wrote:
> >>> On 7 February 2013 21:06, Andy Shevchenko
>
On Tue, Jan 29, 2013 at 05:06:24PM +0200, Andy Shevchenko wrote:
> In some cases we got the device without dma_mask configured. We have to apply
> the default value to avoid crashes during memory mapping.
>
what was this generated against, it fails to apply for me.
> Signed-off-by: Andy Shevchenk
On Thu, Feb 07, 2013 at 05:36:28PM +0200, Andy Shevchenko wrote:
> From: Mika Westerberg
>
> Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
> purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
> from ACPI namespace with ACPI ID INTL9C60.
>
On Thu, Feb 07, 2013 at 02:38:32PM -0700, Dave Jiang wrote:
> There is a race that can hit during __cleanup() when the ioat->head pointer is
> incremented during descriptor submission. The __cleanup() can clear the
> PENDING flag when it does not see any active descriptors. This causes new
> submit
gt; Acked-by: Tony Lindgren
> Acked-by: Arnd Bergmann
Acked-by: Vinod Koul
> ---
> include/linux/dmaengine.h | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index bfcdecb..17d8ffd 10
On Mon, Feb 04, 2013 at 02:47:02PM -0500, Matt Porter wrote:
> Add a dmaengine API to retrieve slave SG transfer capabilities.
>
> The API is optionally implemented by dmaengine drivers and when
> unimplemented will return a NULL pointer. A client driver using
> this API provides the required dma
On Tue, Feb 12, 2013 at 06:43:51PM +0200, Mika Westerberg wrote:
> On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote:
> > On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote:
> > > Next time, please direct these mails to my Linaro id :)
> > >
> &g
On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote:
> On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote:
> > On 01/19/2013 07:06 AM, Cong Ding wrote:
> > > The memory allocated to ofdma might be a leakage when error occurs.
> > >
> > > Signed-off-by: Cong Ding
> >
> > You need t
On Tue, Apr 02, 2013 at 12:44:36PM +0200, Lars-Peter Clausen wrote:
> On 04/02/2013 11:12 AM, PADMAVATHI VENNA wrote:
> >> Use the generic of_dma_xlate_by_chan_id xlate callback instead of a custom
> >> implementation.
Hi Padma,
Can you please fix your MUA to
1) not break the message ids
2) reply
On Sun, Mar 31, 2013 at 06:17:59PM +0200, Anatolij Gustschin wrote:
> Add generic DMA bindings and register the DMA controller
> to DT DMA helpers.
I need someone who understands DT better than me to comment/ack...
Arnd...?
>
> Signed-off-by: Anatolij Gustschin
> ---
> arch/powerpc/boot/dts/mpc
On Mon, Jan 21, 2013 at 01:19:23PM -0500, Matt Porter wrote:
> > b) Sg segment length and numbers: Well these are capabilities, so it tells
> > you what is the maximum I can do. IMO it doesn't make sense to tie it down
> > to
> > burst, width etc. For that configuration you are checking maximum. W
On Fri, Jan 25, 2013 at 11:47:59AM +0200, Andy Shevchenko wrote:
> The patch series is targeted for getting proper residue value.
Applied, thanks
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordom
> On Fri, Jan 18, 2013 at 5:44 PM, Andy Shevchenko
> > The proper place for the main logic of the soft LLP mode is
> > dwc_scan_descriptors. It prevents to get the transfer unexpectedly aborted
> > in
> > case the user calls dwc_tx_status.
Can you rebase this, it failed to apply for me
--
~Vinod
On Fri, Jan 18, 2013 at 05:10:59PM +0200, Andy Shevchenko wrote:
> It's usefull to have the values of the DW_PARAMS and DWC_PARAMS printed when
> debug mode is enabled.
Applied, thanks
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
icit
> error messages can be removed from the failure code paths.
Where is this symbol, applying this results in build failures for me?
>
> Signed-off-by: Thierry Reding
> Cc: Vinod Koul
> ---
> drivers/dma/dw_dmac.c | 7 ---
> drivers/dma/imx-dma.c | 7
On Tue, Feb 26, 2013 at 03:52:05PM -0700, Mark A. Greer wrote:
> [CC'ing more people & lists.]
>
> On Tue, Feb 26, 2013 at 11:36:46AM -0700, Tim Gardner wrote:
> > Whats up with commits 0e87e73f4abe1ada69cf780fe2550c6361a1b53b and
> > b4b87a934c30fb91cbdd18ae028acdc361e1cf0f. As far as I can tell,
On Wed, Feb 27, 2013 at 09:36:03PM +, Arnd Bergmann wrote:
> On Wednesday 27 February 2013, Vinod Koul wrote:
> > Yes we had agreed that I will send it.
> >
> > I have applied this one now, and will send second PULL request to Linus
> > soon.
> >
> >
On Wed, Feb 20, 2013 at 11:26:54AM +0900, Tomoya MORINAGA wrote:
> Hi
>
> Could you review this patch ?
> 8 days have passed...
Sorry looks like I missed it. I have queued it up and will apply after -rc1
--
~Vinod
>
> thanks,
> tomoya
>
> On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA
> wr
On Tue, Feb 19, 2013 at 11:02:24AM +0200, Andy Shevchenko wrote:
> On Mon, 2013-01-28 at 13:04 +0200, Andy Shevchenko wrote:
> > On some hardware configurations we have got the request line with the
> > offset.
> > The patch introduces convert_slave_id() helper for that cases. The request
> > li
On Fri, Feb 15, 2013 at 07:21:48PM +0100, Arnd Bergmann wrote:
> Hi Vinod,
>
> As Andy pointed out today, we don't have a good solution for the
> dw_dmac DT binding in linux-next yet. I have posted my series
> once before and then got distracted after getting feedback from
> Viresh, Andy and Russe
On Wed, Feb 20, 2013 at 09:50:25AM +, Arnd Bergmann wrote:
> On Wednesday 20 February 2013, Vinod Koul wrote:
> > Since there is still churn, would it make sense if I just revert the
> > SPEAr13xx
> > patch (your first patch) and send a pull request to Linus.
> > S
On Thu, Feb 21, 2013 at 09:29:47AM +0100, Philippe De Muyter wrote:
> > 2. If you are not using dmaengine APIs then drivers/dma/ is not a place for
> > you.
>
> What would be the place then for a multi-architecture dma driver. Freescale
> often
> reuses the same blocks for its m68k (coldfire),
ine: ste_dma40: don't allow high priority dest event lines
Sachin Kamat (1):
DMA: PL330: Use devm_* functions
Shiraz Hashim (1):
dmaengine/dmatest: terminate transfers only in case of errors
Tong Liu (1):
dmaengine: ste_dma40: support more than 128 event lines
Vinod Koul (5):
include/mach/
> > directory.
>
> BTW, it'd be easiest for me to take this through the Tegra tree, so it
> can be consolidated with other header re-org changes.
Sure, so here is the ack
Acked-by: Vinod Koul
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the l
ac8a55245a4f2dc174e17
> > Author: Uwe Kleine-König
> > of: add const to struct *of_device_id.data
> > -
>
> Acked-by: Stephen Warren
Acked-by: Vinod Koul
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel
On Thu, 2012-08-23 at 13:41 +0200, Ulf Hansson wrote:
> From: Ulf Hansson
>
> Fixup some errorhandling for clocks during probe and make sure
> to use clk_prepare as well as clk_enable.
>
> Signed-off-by: Ulf Hansson
> Acked-by: Linus Walleij
Applied, thanks
--
~Vinod Ko
t; in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
arch/arm/mach-exynos/dma.c |2 ++
> drivers/dma/pl330.c|1 +
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
this error
> path can be fixed to properly fallback to PIO only or fail to
> initialize as needed.
I didnt see any update on this one, is it okay, if so care to send a
tested-by?
--
~Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
On Fri, 2012-08-31 at 15:28 +, Dan Williams wrote:
>
> On Aug 30, 2012, at 5:30 PM, "Vinod Koul" wrote:
>
> > On Fri, 2012-08-24 at 16:36 -0700, Dave Jiang wrote:
> >> Signed-off-by: Dave Jiang
> > Sounds okay to me, I can carry it once Dan acks
PI on OMAP-L138 EVM and it works great.
> Tested a JFFS2 mount as well as some raw chardev read/write tests.
>
> Tested-by: Sekhar Nori
>
> Thanks,
> Sekhar
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a m
is
> >> implemented.
> > Then this should be enabled for SPI. Care to send a patch
>
> By 'this' you mean the Kconfig select? Then there should be no need of
> a
> new patch for this. It can be part of this patch itself, no?
Either way is okay for me.
--
On Fri, 2012-08-31 at 22:32 +0530, Vinod Koul wrote:
> On Fri, 2012-08-31 at 22:01 +0530, Sekhar Nori wrote:
> > >> Yes, this was the problem. Since the SPI driver now depends on
> > >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in
> > >>
On Tue, 2012-09-11 at 17:21 +0200, Nicolas Ferre wrote:
> s/dma_memcpy/slave_sg/ and it is sg length that we are
> talking about.
>
> Signed-off-by: Nicolas Ferre
> Cc: Stable [2.6.31+]
> ---
> drivers/dma/at_hdmac.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/d
On Mon, 2012-09-03 at 13:46 +0300, Andy Shevchenko wrote:
> There is slave_id field in the generic slave config structure that is
> dedicated
> for the uniq slave number. In our case we have the request lines wired to the
> certain hardware. Therefore the number of the request line is uniq and cou
On Wed, 2012-09-05 at 15:08 +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun
Applied thanks
> ---
> dr
On Thu, 2012-09-06 at 09:19 +0200, Jean Delvare wrote:
> I was checking why this spinlock was never initialized, but it turns
> out it's not used anywhere, so we can drop it.
>
> Signed-off-by: Jean Delvare
> Cc: Vinod Koul
> Cc: Dan Williams
> ---
> I can't e
On Fri, 2012-09-07 at 14:30 +0900, Kukjin Kim wrote:
> Vinod Koul wrote:
> >
> > On Wed, 2012-08-29 at 10:16 +0530, Tushar Behera wrote:
> > > DMA clients pdma0 and pdma1 are internal to the SoC and are used only
> > > by dedicated peripherals. Since they cannot
On Fri, 2012-09-07 at 12:14 +0530, Inderpal Singh wrote:
> The controller clock is being managed at AMBA bus level probe/remove and
> pm_runtime/suspend functions. The existing driver does the clock
> enable/disable
> again in the same code paths, which unneccessarily increments the usage count
>
> drivers/dma/imx-dma.c |2 +-
> drivers/dma/imx-sdma.c |4 +--
Acked-by: Vinod Koul
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.ke
;
> drivers/dma/ep93xx_dma.c | 2 +-
Acked-by: Vinod Koul
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel
; Signed-off-by: Arnd Bergmann
> Cc: Nicolas Ferre
> Cc: Jean-Christophe Plagniol-Villard
> Cc: Vinod Koul
> Cc: Dan Williams
Acked-by: Vinod Koul
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@v
On Thu, 2012-09-13 at 16:37 +0300, Peter Ujfalusi wrote:
> Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
> can receive the no_wakeup request coming from client drivers.
> This feature can be used during audio operation to disable all audio
> related interrupts.
We already
On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote:
> Hi,
>
> Hm... Do you think it would work as well if we implement this by
> setting the
> callback for the descriptor to NULL? If the callback is NULL there is
> nothing to at the end of a transfer/period and the dma engine driver
> may
On Thu, 2012-09-13 at 16:38 +0100, Russell King - ARM Linux wrote:
> On Thu, Sep 13, 2012 at 05:27:09PM +0200, Lars-Peter Clausen wrote:
> > Hm... Do you think it would work as well if we implement this by setting the
> > callback for the descriptor to NULL? If the callback is NULL there is
> > not
On Fri, 2012-09-14 at 10:13 +0200, Lars-Peter Clausen wrote:
> On 09/14/2012 05:26 AM, Vinod Koul wrote:
> > On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote:
> >> Hi,
> >>
> >> Hm... Do you think it would work as well if we implement this by
&g
to get a channel based on above mapping, add new
slave specfic dmanengine channel request/free APIs
Signed-off-by: Vinod Koul
---
this is the first attempt to do the slave dma mapping, we have been discussing
this and we all agree to need for this. This is the same patch which was shown
at KS and
On Fri, 2012-09-14 at 12:28 +0300, Peter Ujfalusi wrote:
> Hi,
>
> On 09/14/2012 11:50 AM, Vinod Koul wrote:
> >> Well, the idea was that the driver would disable interrupts if there is no
> >> callback to call, since there would be nothing to do in the interrupt
>
On Fri, 2012-09-14 at 15:03 +0530, Vinod Koul wrote:
Sorry, this is a RFC, and not a PATCH yet.
> when allocating a channel the dmaengine finds first channel that matches the
> mask and calls filter function
> In slave dmaengine model, there already exists a mapping, either hardwired in
On Fri, 2012-09-14 at 10:41 +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 14, 2012 at 03:03:09PM +0530, Vinod Koul wrote:
> > +/*called under lock held */
> > +static struct dma_chan *dmaengine_get_slave_channel(char *requestor,
> > dma_cap_mask_t *mask)
> &
On Mon, 2012-10-01 at 13:06 +0300, Andy Shevchenko wrote:
> Sometimes memory-to-memory test is failed, that's why we need to choose
> minimum
> data portion between source and destination limits together.
>
> Signed-off-by: Andy Shevchenko
Applied, thanks for taking care of this
--
~Vinod
--
On Mon, 2012-10-01 at 12:39 -0400, Matt Porter wrote:
> Anything you can show at this point? ;) I'd be happy to drop the
> half-hack
> for a real API. If not, I'm going to carry that to v2 atm.
This is what I had done sometime back. Feel free to update
diff --git a/include/linux/dmaengine.h
On Thu, 2012-10-04 at 08:26 +, Koul, Vinod wrote:
> > >
> > > (Dropping stable Cc; Olof/Arnd or Vinod, is it possible you could add
> > > that into the patch description when applying this?)
> > >
> > > Reported-by: Stephen Warren
> > > Acked-by: Stephen Warren
> >
> > Should be no problem.
clusively.
I believe some h/w do have such assignment so would help in doing that.
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-
e much sense here.
BUT would help to keep things simpler if have one definition which
includes all.
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, 2012-10-23 at 13:01 -0700, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, remove it.
>
> CC: Vinod Koul
> CC: Dan Williams
> Sig
imxdma->slots_2d[slot].xsr = d->x;
> imxdma->slots_2d[slot].ysr = d->y;
>
>
> --
Thanks applied
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ing name. Howvere, for arm-pl330.txt, it is explained as ...
>
> That's not the generic bindings. I guess they didn't get merged then. I
> guess we can continue with custom bindings until they are.
Yes they are in topic topic/dmaengine_dt in my tree. Will be merged once
we sort out
dma_pl330_desc *desc;
> struct pl330_info *pi;
> struct resource *res;
> int irq;
> @@ -3015,6 +3023,13 @@ static int __devexit pl330_remove(struct amba_device
> *adev)
> pl330_free_chan_resources(&pch->chan);
> }
>
> + while (!list
if they are in use and
not freed by client your remove wont be called. So this check is
redundant
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
r(&pdmac->ddma);
> +
> amba_set_drvdata(adev, NULL);
>
> list_for_each_entry_safe(pch, _p, &pdmac->ddma.channels,
Ok with this one :)
Tried applying but didn't work out. You would need to regenerate this
one.
Thanks
--
Vinod Koul
Intel Corp.
--
T
;
> probe_err3:
> @@ -3025,6 +3027,7 @@ static int __devexit pl330_remove(struct amba_device
> *adev)
> res = &adev->res;
> release_mem_region(res->start, resource_size(res));
>
> + kfree(pdmac->peripherals);
> kfree(pdmac);
>
> retur
ould also do pm_runtime_allow
here and pm_runtime_forbid in your remove.
> +
> return 0;
>
> probe_err5:
> @@ -3017,6 +3025,8 @@ static int __devexit pl330_remove(struct amba_device
> *adev)
> return -EBUSY;
> }
>
> + pm_runtime_get(pdmac-&
it(void)
> -{
> - pci_unregister_driver(&pch_dma_driver);
> -}
> -
> -module_init(pch_dma_init);
> -module_exit(pch_dma_exit);
> +module_pci_driver(pch_dma_driver);
>
> MODULE_DESCRIPTION("Intel EG20T PCH / LAPIS Semicon ML7213/ML7223/ML7831 IOH
> "
>
in case PCI devices
make life a lot easier am not sure what support will be there for
platform devices in other systems.
Also next version of this h/w on our systems is bringing subtle changes
so having them separate seemed to me a better idea.
--
Vinod Koul
Intel Corp.
--
To unsubscribe fro
_regs.h |2 ++
> 3 files changed, 16 insertions(+), 20 deletions(-)
>
Applied thanks
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
rk.kernel.org/patch/1503171/
>
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
lter routine.
> > - Update binding document
>
> I can see that you applied these patches and they are present in
> linux-next. But i feel
> the order of patches is bad.
Yes looks like I forgot to sort the mbox series :(
since all patches were applied nicely, and they seem fairly
bisect to work.
Done, it should reflect now.
Sorry for the mess.
--
Vinod Koul
Intel Corp.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, 2012-07-24 at 11:00 +0300, Andy Shevchenko wrote:
> Use devm_kzalloc, devm_clk_get, devm_request_irq, and devm_request_and_ioremap
> to reduce the code and to simplify the error path.
>
> Signed-off-by: Andy Shevchenko
> Cc: Viresh Kumar
Applied thanks
--
~Vinod
--
To unsubscribe from
On Wed, 2012-07-25 at 12:59 +0900, Paul Mundt wrote:
> On Wed, May 09, 2012 at 05:09:21PM +0200, Guennadi Liakhovetski wrote:
> > The shdma base library has originally been extracted from the shdma driver,
> > which now can be converted to actually use it.
> >
> > Signed-off-by: Guennadi Liakhovet
On Thu, 2012-07-26 at 15:58 +0900, Paul Mundt wrote:
> On Thu, Jul 26, 2012 at 12:19:21PM +0530, Vinod Koul wrote:
> > On Wed, 2012-07-25 at 12:59 +0900, Paul Mundt wrote:
> > > On Wed, May 09, 2012 at 05:09:21PM +0200, Guennadi Liakhovetski wrote:
> > > > The shd
On Thu, 2012-07-26 at 14:46 +0200, javier Martin wrote:
> Who is responsible of applying this patch?
>
> It seems 3.5 has been released without it.
>
The buck stops here :(
Sorry looks like this got missed while I was on vacation.
Now that 3.5 is released, I will CC stable and apply this to my
On Tue, 2012-07-03 at 15:33 -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> With the new i.MX clock infrastructure we need to request the dma clocks
> seperately: ahb and ipg clocks.
>
> This fixes the following kernel crash and make audio to be functional again:
>
> root@freescale /home$
y tree with your Acked-by, or I can provide
> you with mine for the sh-sci bits if you want to take it via yours. I'm
> planning on sending my next round of updates to Linus in the next couple
> of days.
Looks fine to me as well
Acked-by: Vinod Koul
--
~Vinod
--
To unsubscr
On Mon, 2012-07-30 at 14:38 +0200, javier Martin wrote:
> On 30 July 2012 13:31, javier Martin wrote:
> > Hi,
> >
> > On 27 July 2012 13:37, Fabio Estevam wrote:
> >> On Fri, Jul 27, 2012 at 12:17 AM, Vinod Koul
> >> wrote:
> >>
> >>&
On Fri, 2012-07-27 at 13:42 +0530, Laxman Dewangan wrote:
> On Tuesday 24 July 2012 10:30 AM, Laxman Dewangan wrote:
> > On Tuesday 24 July 2012 10:38 AM, Vinod Koul wrote:
> >> On Fri, 2012-07-20 at 13:31 +0530, Laxman Dewangan wrote:
> >>> Enable the DMA clo
On Fri, 2012-07-20 at 13:31 +0530, Laxman Dewangan wrote:
> Enable the DMA clock when allocating channel and
> disable clock when freeing channels.
>
> Signed-off-by: Laxman Dewangan
Thanks Applied to for-3.7
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
On Tue, 2012-07-31 at 13:46 +0200, javier Martin wrote:
> On 31 July 2012 13:38, Fabio Estevam wrote:
> > On Tue, Jul 31, 2012 at 3:46 AM, Vinod Koul
> > wrote:
> >
> >> This patch will appear in 3.7-rc2 when I send the fixes to Linus post
> >> rc1, I gue
Hi Linus,
Please consider pull to receive few fixes on slave dmanengine.
There are two trivial fixes in pl330 driver and two in at_hdmac driver.
The following changes since commit ffc493062ce9987156945aa21a677d83a179fc0a:
Laxman Dewangan (1):
dma: tegra: enable/disable dma clock
are a
tested the series on ARM (OMAP), x86_32, x86_64 but not for
> ppc
> for sure.
I though patch 1 was part of the series Mark was supposed to apply.
Anyway both look fine to me so:
Both Acked-By: Vinod Koul
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
On Tue, 2012-09-25 at 16:37 +0300, Andy Shevchenko wrote:
> > Perhaps these F: lines instead
> >
> > F:include/linux/dw_dmac.h
> > F:drivers/dma/dw_dmac*
> Might be. There is another idea to move them under drivers/dma/dw/
> folder. So, Viresh, what do you think is better?
I think that a
-dma: fix missing unlock on error in imxdma_xfer_desc()
drivers/dma/imx-dma.c |4 +++-
drivers/dma/sirf-dma.c |4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
--
Vinod Koul
Intel Corp.
signature.asc
Description: This is a digitally signed message part
On Sat, 2012-10-27 at 15:50 +0530, Inderpal Singh wrote:
> Hi Vinod,
>
> On 26 October 2012 10:15, Vinod Koul wrote:
> > On Thu, 2012-10-25 at 16:53 +0530, Inderpal Singh wrote:
> >>
> >> This code will get executed only in case of force removal of the
>
1 - 100 of 4551 matches
Mail list logo
