[PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook

2018-12-12 Thread Vijay Khemka
Added kcs device and lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts

[PATCH v4 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-12 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

Re: [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook

2018-12-13 Thread Vijay Khemka
On 12/12/18, 5:04 PM, "Joel Stanley" wrote: On Thu, 13 Dec 2018 at 07:34, Vijay Khemka wrote: > > Added kcs device and lpc ctrl device to enable LPC clock in Facebook > Tiogapass device tree. As we're going to re-spin, it's a good

[PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-13 Thread Vijay Khemka
Added ADC and other sensor devices in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 33 +-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b

[PATCH 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2018-12-13 Thread Vijay Khemka
Added lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../boot/dts/aspeed-bmc-facebook-tiogapass.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm

[PATCH 3/4] ARM: dts: aspeed: Add KCS for Facebook

2018-12-13 Thread Vijay Khemka
Added kcs device in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook

[PATCH 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-13 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

Re: [Potential Spoof] Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-17 Thread Vijay Khemka
On 12/14/18, 12:42 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 12/14/18, 11:22 AM, "openbmc on behalf of Jae Hyun Yoo" wrote: Hi Vijay, On 12/14/2018 10:11 AM, Vijay Khemka wrote: > On 12/13/18, 2:56 PM

[PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-17 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

[PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook

2018-12-17 Thread Vijay Khemka
Added kcs device in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook

[PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2018-12-17 Thread Vijay Khemka
Added lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../boot/dts/aspeed-bmc-facebook-tiogapass.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm

[PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-17 Thread Vijay Khemka
Added ADC and other sensor devices in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b

Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-14 Thread Vijay Khemka
On 12/13/18, 2:56 PM, "Joel Stanley" wrote: On Fri, 14 Dec 2018 at 06:23, Vijay Khemka wrote: > > Added ADC and other sensor devices in Facebook Tiogapass device tree. > > Signed-off-by: Vijay Khemka > --- > .../dts/aspeed-bmc-fac

Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-14 Thread Vijay Khemka
On 12/14/18, 11:22 AM, "openbmc on behalf of Jae Hyun Yoo" wrote: Hi Vijay, On 12/14/2018 10:11 AM, Vijay Khemka wrote: > On 12/13/18, 2:56 PM, "Joel Stanley" wrote: > > + oemname0 = "MB_P3V3"

[PATCH] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-10 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

[PATCH 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-10 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

[PATCH 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook

2018-12-10 Thread Vijay Khemka
Added kcs device and lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts

Re: [PATCH] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-10 Thread Vijay Khemka
Please ignore this patch as it is duplicate. It is included in list of 2 patches I have sent just before. On 12/10/18, 12:08 PM, "Vijay Khemka" wrote: Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5

[PATCH] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-10 Thread Vijay Khemka
Added ADC and other sensor devices in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 33 +-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b

Re: [PATCH 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-11 Thread Vijay Khemka
Thanks Jay, I will take care of your comments and send next version. Regards -Vijay On 12/11/18, 10:40 AM, "Jae Hyun Yoo" wrote: Hi Vijay, On 12/10/2018 12:07 PM, Vijay Khemka wrote: > Added kcs device support for lpc BMC. > > Signed-o

[PATCH v2 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook

2018-12-11 Thread Vijay Khemka
Added kcs device and lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts

[PATCH v2 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-11 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

[PATCH v3 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-11 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8

[PATCH v3 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook

2018-12-11 Thread Vijay Khemka
Added kcs device and lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 30 +++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts

Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2018-12-20 Thread Vijay Khemka
Joel, Can you please take care of these patches merge. On 12/17/18, 12:04 PM, "Vijay Khemka" wrote: Added lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../boot/dts/aspeed-bmc-facebook-tiogapass

Re: [Potential Spoof] Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-07 Thread Vijay Khemka
Please merge these patches in upstream kernel. Regards -Vijay On 12/20/18, 10:06 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Joel, Can you please take care of these patches merge. On 12/17/18, 12:04 PM, "Vijay Khemka" wrote: Added lpc c

Re: [PATCH net-next] net/ncsi: Add NCSI Mellanox OEM command

2018-10-26 Thread Vijay Khemka
Thanks David On 10/26/18, 10:36 AM, "David Miller" wrote: From: Vijay Khemka Date: Fri, 26 Oct 2018 17:19:49 + > Do you have any timeline when it is going to open next or how do I > know. I always announce net-next openning and closing

[PATCH] ARM: dts: aspeed: Adding Facebook TiogaPass BMC

2018-09-18 Thread Vijay Khemka
machines. This also adds an entry of tiogapass device tree file in Makefile Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/Makefile| 1 + .../dts/aspeed-bmc-facebook-tiogapass.dts | 146 ++ 2 files changed, 147 insertions(+) create mode 100644 arch/arm

[PATCH v3] ARM: dts: aspeed: Adding Facebook TiogaPass BMC

2018-09-18 Thread Vijay Khemka
machines. This also adds an entry of tiogapass device tree file in Makefile Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/Makefile| 1 + .../dts/aspeed-bmc-facebook-tiogapass.dts | 146 ++ 2 files changed, 147 insertions(+) create mode 100644 arch/arm

Re: [Potential Spoof] Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-27 Thread Vijay Khemka
Hi Joel, Can you please apply this below patch to kernel 5.0. Regards -Vijay On 3/18/19, 12:46 PM, "openbmc on behalf of Vijay Khemka" wrote: Hi Joel, Can you please apply this patch as " Documentation/devicetree/bindings/mfd/aspeed-lpc.txt" has already been appl

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH] ARM: dts: aspeed: tiogapass: Enable VUART

2019-03-27 Thread Vijay Khemka
Hi Joel, Please apply this patch. Regards -Vijay On 3/18/19, 12:46 PM, "openbmc on behalf of Vijay Khemka" wrote: Hi Joel, Please apply this patch. Regards -Vijay On 3/5/19, 12:06 PM, "openbmc on behalf of Vijay Khemka" wrote:

Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-02-11 Thread Vijay Khemka
On 2/10/19, 9:22 PM, "Andrew Jeffery" wrote: On Fri, 25 Jan 2019, at 05:59, Vijay Khemka wrote: > > > On 1/24/19, 12:16 AM, "Greg Kroah-Hartman" wrote: > > On Wed, Jan 23, 2019 at 03:06:34PM -0800, Vijay Khemka wrote:

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-18 Thread Vijay Khemka
Hi Joel, Can you please apply this patch as " Documentation/devicetree/bindings/mfd/aspeed-lpc.txt" has already been applied Regards -Vijay On 3/5/19, 4:15 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Joel, Did this patch apply upstream. Somehow I can&

Re: [Potential Spoof] Re: [PATCH] ARM: dts: aspeed: tiogapass: Enable VUART

2019-03-18 Thread Vijay Khemka
Hi Joel, Please apply this patch. Regards -Vijay On 3/5/19, 12:06 PM, "openbmc on behalf of Vijay Khemka" wrote: Please review below patch. Regards -Vijay On 1/30/19, 10:14 AM, "Vijay Khemka" wrote: Enabling vuart fo

Re: [PATCH] net/ncsi: Fix the payload copying for the request coming from Netlink

2019-08-22 Thread Vijay Khemka
request is coming from Netlink. Signed-off-by: Justin Lee Reviewed-by: Vijay Khemka --- net/ncsi/ncsi-cmd.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index eab4346..0187e65 100644

Re: [PATCH v5 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-16 Thread Vijay Khemka
On 8/16/19, 3:20 AM, "openbmc on behalf of John Wang" wrote: Add the driver to monitor Inspur Power System power supplies with hwmon over pmbus. This driver adds sysfs attributes for additional power supply data, including vendor, model, part_number, serial number, fi

Re: [PATCH v2 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-10 Thread Vijay Khemka
incorrect). Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta Reviewed-by: Vijay Khemka --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpi

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfe

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfe

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/11/19, 7:49 AM, "Joel Stanley" wrote: Hi Ben, On Tue, 10 Sep 2019 at 22:05, Florian Fainelli wrote: > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > HW checksum generation is not working for AST2500, specially with IPV6 > > ove

Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-11 Thread Vijay Khemka
On 9/11/19, 5:16 AM, "Linux-aspeed on behalf of Rashmica Gupta" wrote: Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/11/19, 11:34 AM, "Florian Fainelli" wrote: On 9/11/19 11:30 AM, Vijay Khemka wrote: > > > On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: > > > > On 9/10/19, 3:50 PM, "L

[PATCH] net/ncsi: Disable global multicast filter

2019-09-12 Thread Vijay Khemka
then let it disabled for every other types as well. As we are seeing issues with LLDP not working with this enabled filtering. And there are other issues with IPV6. By Disabling this multicast completely, it is working for both IPV6 as well as LLDP. Signed-off-by: Vijay Khemka --- net/ncsi

Re: [PATCH] net/ncsi: Disable global multicast filter

2019-09-16 Thread Vijay Khemka
On 9/15/19, 7:39 PM, "Samuel Mendoza-Jonas" wrote: On Thu, 2019-09-12 at 12:04 -0700, Vijay Khemka wrote: > Disabling multicast filtering from NCSI if it is supported. As it > should not filter any multicast packets. In current code, multicast > filter is

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-09-17 Thread Vijay Khemka
Please review below patch and provide your valuable feedback. Regards -Vijay On 9/11/19, 1:05 PM, "Vijay Khemka" wrote: HW checksum generation is not working for AST2500, specially with IPV6 over NCSI. All TCP packets with IPv6 get dropped. By disabling this it works

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-09-24 Thread Vijay Khemka
Florian/Joel, Can you please look into below patch and let me know who can apply this. Regards -Vijay On 9/17/19, 12:34 PM, "Vijay Khemka" wrote: Please review below patch and provide your valuable feedback. Regards -Vijay On 9/11/19, 1:05 PM, "Vijay

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Vijay Khemka
On 10/8/19, 9:37 PM, "Benjamin Herrenschmidt" wrote: On Wed, 2019-09-11 at 14:48 +, Joel Stanley wrote: > Hi Ben, > > On Tue, 10 Sep 2019 at 22:05, Florian Fainelli > wrote: > > > > On 9/10/19 2:37 PM, Vijay Khemka wrote:

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Vijay Khemka
Resending this patch again. On 9/11/19, 1:05 PM, "Vijay Khemka" wrote: HW checksum generation is not working for AST2500, specially with IPV6 over NCSI. All TCP packets with IPv6 get dropped. By disabling this it works perfectly fine with IPV6. As it works for IPV4

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-11 Thread Vijay Khemka
On 10/10/19, 8:11 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-10 at 19:15 +0000, Vijay Khemka wrote: > Any news on this ? AST2400 has no HW checksum logic in HW, AST2500 > should work for IPV4 fine, we should only selectively disable it fo

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Vijay Khemka
On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with > IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Vijay Khemka
On 10/17/19, 4:15 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-17 at 22:01 +0000, Vijay Khemka wrote: > > On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" wrote: > > On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: &

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Vijay Khemka
On 10/17/19, 5:33 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-18 at 00:06 +0000, Vijay Khemka wrote: > > > This is not a matter of unsupported csum, it is broken hw csum. > > That's why we disable hw checksum. My guess is

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Vijay Khemka
On 10/18/19, 5:03 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-18 at 22:50 +0000, Vijay Khemka wrote: > I don't have much understanding of IP Stack but I went through code details and > you are right and found that it should fallback to SW calcula

[PATCH v3] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-29 Thread Vijay Khemka
Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis. Signed-off-by: Vijay Khemka --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree

Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-29 Thread Vijay Khemka
Thanks Lee, On 1/29/19, 4:30 AM, "Lee Jones" wrote: On Fri, 18 Jan 2019, Vijay Khemka wrote: > Memory-region and flash phandle is not a required parameter, it is > optional to describe in device tree and needed only use basis. > > Signe

Re: [PATCH] misc: aspeed-lpc-ctrl: make memory-region optional

2019-01-16 Thread Vijay Khemka
Sure Joel, I will do v2 and submit for review today. Regards -Vijay On 1/15/19, 4:11 PM, "Joel Stanley" wrote: Hi Vijay, On Tue, 15 Jan 2019 at 12:51, Vijay Khemka wrote: > > Makiing memory-region as optional parameter in device tree if > user

[PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-16 Thread Vijay Khemka
Makiing memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 58 +- 1 file changed, 36 insertions(+), 22

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-17 Thread Vijay Khemka
On 1/16/19, 10:17 PM, "Joel Stanley" wrote: On Thu, 17 Jan 2019 at 09:02, Vijay Khemka wrote: > > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need t

Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-17 Thread Vijay Khemka
On 1/16/19, 6:49 PM, "Joel Stanley" wrote: On Fri, 21 Dec 2018 at 05:06, Vijay Khemka wrote: > > On 12/17/18, 12:04 PM, "Vijay Khemka" wrote: > > Added lpc ctrl device to enable LPC clock in Facebook > Tiogapass device

[PATCH] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-17 Thread Vijay Khemka
Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis. Signed-off-by: Vijay Khemka --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-14 Thread Vijay Khemka
On 1/13/19, 2:39 PM, "Andrew Jeffery" wrote: Hi Vijay, Sorry for providing an opinion so late, however: On Sat, 12 Jan 2019, at 11:03, Vijay Khemka wrote: > Joel, > Please merge these patches as it is required by facebook platform.

[PATCH] misc: aspeed-lpc-ctrl: make memory-region optional

2019-01-14 Thread Vijay Khemka
Makiing memory-region as optional parameter in device tree if user needs to use memory-region then define in devicetree. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-18 Thread Vijay Khemka
, at 08:31, Vijay Khemka wrote: > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need to define in devicetree. > > Signed-off-by: Vijay Khemka > --- > driv

[PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-18 Thread Vijay Khemka
Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis. Signed-off-by: Vijay Khemka --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree

[PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-01-23 Thread Vijay Khemka
Corrected some of return values with appropriate meanings. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c index 332210e06e98

[PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook

2019-01-23 Thread Vijay Khemka
Added lpc control for enabling lpc clock, peci for cpu sensors and lpc snoop devices to Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/aspeed

[PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook

2019-01-23 Thread Vijay Khemka
Added uart2 and uart3 in Facebook Tiogapass for routing serial input from Host to BMC for SoL via LPC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook

Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-01-24 Thread Vijay Khemka
On 1/24/19, 12:16 AM, "Greg Kroah-Hartman" wrote: On Wed, Jan 23, 2019 at 03:06:34PM -0800, Vijay Khemka wrote: > Corrected some of return values with appropriate meanings. > > Signed-off-by: Vijay Khemka > --- > drivers/mi

Re: [PATCH v2] misc: aspeed-lpc-ctrl: Correct return values

2019-05-06 Thread Vijay Khemka
On 5/5/19, 9:24 PM, "Andrew Jeffery" wrote: On Sat, 4 May 2019, at 03:43, Vijay Khemka wrote: > Corrected some of return values with appropriate meanings and reported > relevant messages as debug information. > > Signed-off-by: Vijay Khemk

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-01 Thread Vijay Khemka
Let me send both patches. On 4/30/19, 11:45 PM, "Greg Kroah-Hartman" wrote: On Wed, May 01, 2019 at 05:55:07AM +, Joel Stanley wrote: > On Fri, 18 Jan 2019 at 20:12, Vijay Khemka wrote: > > > > Hi Andrew, > > Thanks for this review, I

[PATCH] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-01 Thread Vijay Khemka
Makiing memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 58 +- 1 file changed, 36 insertions(+), 22

[PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-05-01 Thread Vijay Khemka
Corrected some of return values with appropriate meanings. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c index 332210e06e98

Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-05-03 Thread Vijay Khemka
On 5/1/19, 11:49 PM, "Andrew Jeffery" wrote: On Thu, 2 May 2019, at 16:10, Greg Kroah-Hartman wrote: > On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote: > > Corrected some of return values with appropriate meanings. > >

[PATCH v2] misc: aspeed-lpc-ctrl: Correct return values

2019-05-03 Thread Vijay Khemka
Corrected some of return values with appropriate meanings and reported relevant messages as debug information. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/misc/aspeed-lpc-ctrl.c b

Re: [Potential Spoof] Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-09 Thread Vijay Khemka
On 8/8/19, 3:27 PM, "openbmc on behalf of Tao Ren" wrote: On 8/8/19 2:16 PM, Andrew Lunn wrote: > On Thu, Aug 08, 2019 at 07:02:54PM +, Tao Ren wrote: >> Hi Andrew, >> >> On 8/8/19 6:32 AM, Andrew Lunn wrote: Let me prepare patch v2 using device tree. I'm not

Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device

2019-08-06 Thread Vijay Khemka
Joel, I have added all 3 id in the documentation patch and I am not sure if that patch has been applied or not. Regards -Vijay On 8/1/19, 11:31 PM, "Joel Stanley" wrote: Add pxe1610 as a trivial device On Tue, 23 Jul 2019 at 17:14, Vijay Khemka wrote: &g

Re:[PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Vijay Khemka
Lgtm except one small comment below. On 8/6/19, 5:22 PM, "openbmc on behalf of Tao Ren" wrote: Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic doesn't work for platforms with differen

Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device

2019-07-23 Thread Vijay Khemka
On 7/23/19, 7:53 AM, "Rob Herring" wrote: On Tue, Jul 23, 2019 at 8:50 AM Rob Herring wrote: > > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka wrote: > > > > The pxe1610 is a voltage regulator from Infineon. It also supports > >

Re: [PATCH v2 1/2] hwmon: pmbus: Add Infineon PXE1610 VR driver

2019-06-06 Thread Vijay Khemka
On 6/5/19, 1:47 PM, "Guenter Roeck" wrote: On Thu, May 30, 2019 at 04:11:56PM -0700, Vijay Khemka wrote: > Added pmbus driver for the new device Infineon pxe1610 > voltage regulator. It also supports similar family device > PXE1110 and PXM1310. >

Re: [PATCH v2] soc: aspeed: lpc-ctrl: make parameter optional

2019-06-06 Thread Vijay Khemka
Please update on this patch. On 5/30/19, 1:37 PM, "Vijay Khemka" wrote: Making memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka R

Re: [PATCH] ARM: dts: aspeed: tiogapass: Enable VUART

2019-03-05 Thread Vijay Khemka
Please review below patch. Regards -Vijay On 1/30/19, 10:14 AM, "Vijay Khemka" wrote: Enabling vuart for Facebook tiogapass Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 5 + 1 file changed, 5 insertions(+)

Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-05 Thread Vijay Khemka
Joel, Did this patch apply upstream. Somehow I can't find this patch in linux or linux-next or our obmc dev4.19. Regards -Vijay On 1/17/19, 10:53 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 1/16/19, 10:17 PM, "Joel Stanley" wrote:

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-11 Thread Vijay Khemka
Joel, Please merge these patches as it is required by facebook platform. Regards -Vijay On 1/7/19, 11:25 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Please merge these patches in upstream kernel. Regards -Vijay On 12/20/18, 10:06 AM, "Linux-a

Re: [PATCH] ARM: dts: aspeed: Adding Facebook TioagaPass BMC

2018-09-14 Thread Vijay Khemka
Thanks Andrew, I have revised patch as I found some more changes. Sent a new version. Regards -Vijay On 9/13/18, 1:18 PM, "Andrew Lunn" wrote: > +++ b/arch/arm/boot/dts/Makefile > @@ -1206,4 +1206,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-opp-witherspoon.dtb \ > aspe

[PATCH 1/2] ARM: dt-bindings: aspeed: Facebook TiogaPass BMC

2018-09-19 Thread Vijay Khemka
Initial introduction of Facebook TiogaPass family equipped with Aspeed 2500 BMC SoC. TiogaPass is a x86 server development kit with a ASPEED ast2500 BMC manufactured by Facebook. This adds an entry of Facebook in Documentation for vendor prefix --- Documentation/devicetree/bindings/vendor-prefixe

[PATCH v2 1/2] ARM: dt-bindings: Add vendor prefix for Facebook

2018-09-19 Thread Vijay Khemka
Initial introduction of Facebook TiogaPass family equipped with Aspeed 2500 BMC SoC. TiogaPass is a x86 server development kit with a ASPEED ast2500 BMC manufactured by Facebook. This adds an entry of Facebook in Documentation for vendor prefix Signed-off-by: Vijay Khemka --- Documentation

Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-28 Thread Vijay Khemka
On 5/28/20, 7:15 AM, "Manikandan Elumalai" wrote: The adm1278 temperature sysfs attribute need it for one of the our openbmc platform . This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it. There is no Signed-off-by.

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Vijay Khemka
On 5/29/20, 5:47 AM, "Manikandan Elumalai" wrote: The adm1278 temperature sysfs attribute need it for one of the openbmc platform . This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it. Signed-off-by : Manikandan Elumala

Re: [PATCH v2] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-05-29 Thread Vijay Khemka
On 5/29/20, 11:56 AM, "Guenter Roeck" wrote: On 5/29/20 10:57 AM, Vijay Khemka wrote: > > > On 5/29/20, 5:47 AM, "Manikandan Elumalai" wrote: > > The adm1278 temperature sysfs attribute need it for one of the openbmc platf

[PATCH] ARM: dts: aspeed: tiogapass: Remove vuart

2020-08-13 Thread Vijay Khemka
Removed vuart for facebook tiogapass platform as it uses uart2 and uart3 pin with aspeed uart routing feature. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook

[PATCH] soc: aspeed: lpc-ctrl: make parameter optional

2019-05-29 Thread Vijay Khemka
Makiing memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka --- drivers/soc/aspeed/aspeed-lpc-ctrl.c | 58 +--- 1 file changed, 36 insertions(+), 22

Re: [PATCH] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-29 Thread Vijay Khemka
On 5/24/19, 8:59 AM, "Greg Kroah-Hartman" wrote: On Wed, May 01, 2019 at 03:34:11PM -0700, Vijay Khemka wrote: > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need to d

Re: [PATCH] soc: aspeed: fix probe error handling

2019-06-21 Thread Vijay Khemka
On 6/20/19, 1:29 AM, "Joel Stanley" wrote: On Wed, 19 Jun 2019 at 12:56, Arnd Bergmann wrote: > > gcc warns that a mising "flash" phandle node leads to undefined > behavior later: > > drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': > driv

Re: [PATCH] soc: aspeed: lpc-ctrl: Fix probe error handling

2019-06-21 Thread Vijay Khemka
c/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized] Only set the flash base and size if we find a phandle in the device tree. Thanks for fixing this. Reviewed-by: Vijay Khemka R

Re: [PATCH v2] soc: aspeed: lpc-ctrl: make parameter optional

2019-06-14 Thread Vijay Khemka
Hi Andrew, Any update on this patch or do I need any more rework. Regards -Vijay On 6/6/19, 11:51 AM, "Vijay Khemka" wrote: Please update on this patch. On 5/30/19, 1:37 PM, "Vijay Khemka" wrote: Making memory-region and flash as optional

Re: [PATCH 1/2] hwmon: pmbus: Add Infineon PXE1610 VR driver

2019-05-30 Thread Vijay Khemka
On 5/29/19, 6:01 PM, "Guenter Roeck" wrote: On 5/29/19 3:35 PM, Vijay Khemka wrote: > Added pmbus driver for the new device Infineon pxe1610 > voltage regulator. It also supports similar family device > PXE1110 and PXM1310. > > Si

[PATCH v2] soc: aspeed: lpc-ctrl: make parameter optional

2019-05-30 Thread Vijay Khemka
Making memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka Reviewed-by: Andrew Jeffery --- drivers/soc/aspeed/aspeed-lpc-ctrl.c | 58 +--- 1 file

Re: [PATCH] soc: aspeed: lpc-ctrl: make parameter optional

2019-05-30 Thread Vijay Khemka
On 5/29/19, 9:02 PM, "Andrew Jeffery" wrote: On Thu, 30 May 2019, at 02:51, Vijay Khemka wrote: > Makiing Typo here, but I'd prefer to see this patch go in, so Corrected in next version v2. > memory-region and flash as optiona

  1   2   >