Re: Reiser4. BEST FILESYSTEM EVER.

2007-04-07 Thread Valdis . Kletnieks
On Fri, 06 Apr 2007 19:47:36 PDT, [EMAIL PROTECTED] said: > On Fri, 6 Apr 2007 11:21:19 -0400, "Jan Harkes" <[EMAIL PROTECTED]> > > With compression there is a pretty high probability that one corrupted > > byte or disk block will result in loss of a considerably larger amount > > of data. > > B

Re: [PATCH] Scheduler: Improving the scheduler performance.

2007-04-08 Thread Valdis . Kletnieks
On Sat, 07 Apr 2007 23:42:20 +0600, root said: > As we know that, linux scheduler use separate runqueue for every CPU of > a multiprocessor system, which having an active and an expired array.If > we use only one expired array, then the CPUs of a multiprocessor system > will be able to share their

Re: 2.6.21-rc5: Thinkpad X60 gets critical thermal shutdowns

2007-04-08 Thread Valdis . Kletnieks
On Mon, 02 Apr 2007 10:35:40 +0200, Rene Rebe said: (Sorry for the late reply..) > IIRC a MSI Megabook S270 (I formerly owned) BIOS notifies this > "Critical temperature reached (128C)" when the battery run empty > when the OS did no action due to battery low indications. I guess > the BIOS peopl

Re: Add a norecovery option to ext3/4?

2007-04-09 Thread Valdis . Kletnieks
On Sun, 08 Apr 2007 22:24:50 CDT, Eric Sandeen said: > Can you elaborate? Under what circumstances is log replay going to harm > data? Do you mean that the installer mounts partitions, looking for > what OS is installed? How is that harmful? Another usage case that really wants to avoid the l

Re: REISER4 FOR INCLUSION IN THE LINUX KERNEL.

2007-04-09 Thread Valdis . Kletnieks
On Sun, 08 Apr 2007 21:16:59 PDT, [EMAIL PROTECTED] said: > > I am not looking to defend Hans - he is likely to be in jail and no > > longer a factor for a long time. Nor am I looking to make or support > > claims for Reiser4. > > Why not defend Hans? He is in jail on what appear to be trumpe

Re: REISER4 FOR INCLUSION IN THE LINUX KERNEL.

2007-04-09 Thread Valdis . Kletnieks
On Sun, 08 Apr 2007 21:39:12 PDT, [EMAIL PROTECTED] said: > YOU GUYS WILL LAUGH ABOUT THIS: > > I forgot the all the statistics that might support the sase for REISER4 > inclusion. > > Well, here it all is: *plonk* - The sound of a sender address entering a procmail /dev/null filter. Come back

Re: Troll Of The Year

2007-04-09 Thread Valdis . Kletnieks
On Mon, 09 Apr 2007 18:41:08 +0200, Jan Engelhardt said: > On Apr 9 2007 12:55, Ronni Nielsen wrote: > > > > And the award as Troll Of The Year goes to: johnrobertbanks. > > > > The year is not even over and you already picked your favorite - > who bribed you? :-) The vast right-wing anti-Reise

Re: I give up

2007-04-09 Thread Valdis . Kletnieks
On Mon, 09 Apr 2007 16:08:34 EDT, Jeff Garzik said: > With current hard drive prices (200GB @ US$55, 500GB @ US$120) you can > just keep buying hard drives :) > > Surely tape price/GB is higher than hard drive price/GB... Erm. No. We're in the middle of installing an StorageTek SL8500 for backu

Re: If not readdir() then what?

2007-04-10 Thread Valdis . Kletnieks
On Tue, 10 Apr 2007 17:54:54 +0200, Jan Engelhardt said: > NFS server sends the whole directory contents on NFS client opendir, > so that the whole readdir/telldir/seekdir magic can happen on the > client only... which would perhaps also enable a cheap telldir/seekdir, > and would also give a 'fix

2.6.21-rc7-mm2 breaks 'lvm vgscan'.

2007-04-26 Thread Valdis . Kletnieks
On Wed, 25 Apr 2007 22:57:16 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc7/2.6.21-rc7-mm2/ This addition in -rc7-mm1 breaks my laptop (Dell Latitude D820, x86_64 kernel) gregkh-driver-sysfs-fix-i_ino-handling-in-sysfs.patch The initrd on my s

Re: 2.6.21-rc2-mm1 - build error with HOTPLUG_CPU=N, CPU_IDLE=Y

2007-03-02 Thread Valdis . Kletnieks
On Fri, 02 Mar 2007 03:00:26 PST, Andrew Morton said: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc2/2.6.21-rc2-mm1/ > git-acpi.patch Build dies if your config has CONFIG_HOTPLUG_CPU=N but CPU_IDLE=Y CC drivers/cpuidle/cpuidle.o drivers/cpuidle/cpuidle.c:

Re: 2.6.21-rc2-mm1 - fb_ddc_read() not defined

2007-03-02 Thread Valdis . Kletnieks
On Fri, 02 Mar 2007 03:00:26 PST, Andrew Morton said: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc2/2.6.21-rc2-mm1/ > nvidiafb-bring-back-generic-ddc-reading.patch Building with FB_DDC=N results in: Kernel: arch/x86_64/boot/bzImage is ready (#1) Building mod

Re: 2.6.21-rc2-mm1 - fb_ddc_read() not defined

2007-03-02 Thread Valdis . Kletnieks
On Fri, 02 Mar 2007 16:31:02 GMT, James Simmons said: > > > nvidiafb-bring-back-generic-ddc-reading.patch > To have a patch to cleans things up. Give it a try > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index b8f0a11..855a09e 100644 > --- a/drivers/video/Kconfig > +++ b/driv

Re: 2.6.21-rc5-mm3

2007-03-30 Thread Valdis . Kletnieks
On Fri, 30 Mar 2007 01:05:59 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm3/ Building with CONFIG_MAC80211_DEBUGFS=y but CONFIG_MAC80211_DEBUG_COUNTERS=n blows chunks on my box: CC [M] net/mac80211/debugfs.o net/mac80211/debug

2.6.21-rc5-mm3 - cpuidle, acpi, and C-states

2007-03-31 Thread Valdis . Kletnieks
On Fri, 30 Mar 2007 01:05:59 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm3/ Somebody is confused (possibly me). Running an x86_64 kernel, and I have: % cat /proc/acpi/processor/CPU0/power active state:C0 max_cstate:

Re: Performance Stats: Kernel patch

2007-04-03 Thread Valdis . Kletnieks
On Tue, 03 Apr 2007 16:54:43 +0400, Maxim Uvarov said: > What do you think about it? Patch is bellow. Was this patch actually compile and run tested? > Index: linux-2.6.18/fs/proc/array.c > === > --- linux-2.6.18.orig/fs/proc/array.

Re: 2.6.21-rc5-mm4

2007-04-03 Thread Valdis . Kletnieks
On Wed, 04 Apr 2007 00:58:26 +0200, "J.A. =?UTF-8?B?TWFnYWxsw7Nu?=" said: > Anyways, I have just remembered I use the (in)famous nVidia driver. > Will try to reproduce without it. This was more like a probe to see if > somebody else is suffering it... The nVidia driver will get some truly astound

Re: 2.6.21-rc5-mm4

2007-04-03 Thread Valdis . Kletnieks
On Mon, 02 Apr 2007 22:47:45 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm4/ So I was looking at a patch for ACPI_SLEEP that went around a moment ago, and ended up doing a 'make menuconfig'. I do a '/ACPI_SLEEP' inside that, and

Re: [PATCH] Stop pmac_zilog from abusing 8250's device numbers.

2007-04-03 Thread Valdis . Kletnieks
On Tue, 03 Apr 2007 16:09:08 PDT, Brad Boyer said: > an abstraction of "serial port" as far as the user is concerned. On > Solaris, I can say "/dev/term/a" and know that I will get the first > serial port if it is available without needing to care if it is the > zs, se or asy driver talking to the

Re: 2.6.21-rc5-mm4

2007-04-03 Thread Valdis . Kletnieks
On Tue, 03 Apr 2007 19:20:04 PDT, Randy Dunlap said: > On Tue, 03 Apr 2007 21:35:54 -0400 [EMAIL PROTECTED] wrote: > > I do a '/ACPI_SLEEP' inside that, and I get this output: > > > > x Symbol: ACPI_SLEEP [=n] x > > x Depends on: !X86_NUMAQ && !X

Re: 2.6.21-rc5-mm4

2007-04-04 Thread Valdis . Kletnieks
On Tue, 03 Apr 2007 20:37:42 PDT, Randy Dunlap said: > > Good luck. But the symbols are there. Just use left/right arrow keys > to scroll the display left/right and you can see them. Now if you just > had that indicator to tell you that you Need to scroll to see more text... Exactly. :) I had

Re: makefile question

2007-05-01 Thread Valdis . Kletnieks
On Tue, 01 May 2007 16:38:22 +0400, Mockern said: > I have 4 idedntical drivers, there are only 2 differences: major and minor > numbers of each driver. That's the *only* difference? You don't have different major/minor pairs that correspond to different PCI IDs, or something? I'm confused as

Re: assembly code in the loadable kernel module

2007-05-01 Thread Valdis . Kletnieks
On Fri, 27 Apr 2007 17:06:48 EDT, "linux-os (Dick Johnson)" said: > if(strchr(buf, 'Z'-64) || strchr(buf, 'D'-64)) This probably isn't UTF-8 safe... :) > Anything after ^D or ^Z doesn't get copied to the list. Something like > this needs to be done because it's gonna get a whole lot wors

Re: so ... what *are* candidates for removal?

2007-05-01 Thread Valdis . Kletnieks
On Tue, 01 May 2007 17:30:36 +0200, Andre Tomt said: > Robert P. J. Day wrote: > > http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed > Already documented in the kernel tarball, see > Documentation/feature-removal-schedule.txt Robert's point is that the file you cited is horrendously out

Re: [kernel-hardening] [PATCH v5 03/32] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-07-21 Thread Valdis . Kletnieks
On Mon, 11 Jul 2016 13:53:36 -0700, Andy Lutomirski said: > This avoids pointless races in which another CPU or task might see a > partially populated global pgd entry. These races should normally > be harmless, but, if another CPU propagates the entry via > vmalloc_fault and then populate_pgd fai

Re: [kernel-hardening] [PATCH v5 03/32] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-07-22 Thread Valdis . Kletnieks
On Thu, 21 Jul 2016 22:34:33 -0700, Andy Lutomirski said: > How much memory do you have and what's your config? My code is > obviously buggy, but I'm wondering why neither I nor the 0day bot caught > this. Probably because your devel box and the 0day bot both have 4-level page tables and the dua

[PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP

2016-09-20 Thread Valdis Kletnieks
ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Signed-off-by: Valdis Kletnieks diff --git a/sound/usb/l

Re: [kernel-hardening] [PATCH v5 03/32] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-07-28 Thread Valdis . Kletnieks
On Sat, 23 Jul 2016 16:58:16 +0200, Nicolai Stange said: > valdis.kletni...@vt.edu writes: > The reason the patch didn't work for Valdis might be that there is > another issue in next-20150722 with the same symptoms (provided you > don't watch the serial console). Valdis, did you apply the provide

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Valdis . Kletnieks
On Thu, 28 Jul 2016 09:45:12 +0200, Thomas Gleixner said: > On Tue, 26 Jul 2016, nick wrote: > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > > b/drivers/net/ethernet/intel/e1000/e1000_main.c > > index f42129d..e1830af 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c

PATCH - fix bitrotted value in tools/testing/radix-tree/linux/gfp.h

2016-07-28 Thread Valdis Kletnieks
Apparently, the tools/testing version dates to a few flags ago, and we've sprouted 4 new ones since. Keep in sync with the value in the main tree... Signed-off-by: Valdis Kletnieks --- diff --git a/tools/testing/radix-tree/linux/gfp.h b/tools/testing/radix-tree/linux/gfp.h index 0e37f7a

linux-next - modprobe causes BUG: sleeping function called from invalid context at mm/slab.h:393

2016-07-28 Thread Valdis Kletnieks
I've been seeing this several times per boot since next-20160708 or so, finally had a chance to reproduce it on a linux-next that wasn't horribly hand-hacked. Not every modprobe, maybe 5-8 out of 40 modules usually loaded, with no real rhyme/reason that I've spotted. I keep having a nagging suspi

Re: linux-next - modprobe causes BUG: sleeping function called from invalid context at mm/slab.h:393

2016-07-28 Thread Valdis . Kletnieks
On Thu, 28 Jul 2016 14:21:00 +0200, Nicolai Stange said: > Hi Valdis, > > Valdis Kletnieks writes: > > > This ring any bells for anybody? > Please see the thread rooted at > http://lkml.kernel.org/r/87d1lyiygu@gmail.com > > Herbert Xu has provided a fix for th

[PATCH] init/Kconfig - add clarification for out-of-tree modules

2016-07-29 Thread Valdis Kletnieks
come up lacking something... Hopefully this will save the next guy from a Homer Simpson "D'oh!" moment. Signed-off-by: Valdis Kletnieks --- diff --git a/init/Kconfig b/init/Kconfig index 55c07b855e90..b4c9eb8119c0 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -2083,7 +2083,7 @@ config TRIM

[PATCH] make compiling X86 syscall tables safe for W=1

2016-07-31 Thread Valdis Kletnieks
acro '__SYSCALL_I386' #define __SYSCALL_I386(nr, sym, qual) [nr] = sym, Since we intentionally build the syscall tables this way, ignore that one warning in the two files. Signed-off-by: Valdis Kletnieks --- diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile index fe91c2509

[PATCH] silence warnings when building kernel/bpf/core.c with W=1

2016-07-31 Thread Valdis Kletnieks
^~ kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]') Since they come from the way we intentionally build the table, silence that one specific warning. Signed-off-by: Valdis Kletnieks diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile index eed911d091d

[PATCH] Suppress warnings when compiling fs/proc/task_mmu.c with W=1

2016-07-31 Thread Valdis Kletnieks
r initialization for 'mnemonics[0]') They happen because of the way we intentionally build the table, so silence the warning when building with 'make W=1'. Signed-off-by: Valdis Kletnieks diff --git a/fs/proc/Makefile b/fs/proc/Makefile index 7151ea428041..a8c13605b434 100

[PATCH] silence warning in drivers/ata/libata-scsi.c when building W=1

2016-07-31 Thread Valdis Kletnieks
0xfb) { ~^ So give them the extra () and make things a bit clearer for both the compiler and programmer... Signed-off-by: Valdis Kletnieks diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index fa9d16fe295c..8ad4b237f342 100644 --- a/driv

[PATCH v2] bpf: silence warnings when building kernel/bpf/core.c with W=1

2016-07-31 Thread Valdis Kletnieks
^~ kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]') Since they come from the way we intentionally build the table, silence that one specific warning. Signed-off-by: Valdis Kletnieks Version 2: Add bpf: subsystem tag to subject line diff --git a/kernel/bpf/Ma

Re: [PATCH v2] bpf: silence warnings when building kernel/bpf/core.c with W=1

2016-07-31 Thread Valdis . Kletnieks
On Sun, 31 Jul 2016 21:42:22 -0700, Alexei Starovoitov said: > and at least 2 other such patches for other files... > Is there a single warning where -Woverride-init was useful? > May be worth disabling this warning for the whole build? There's a few other cases that *aren't* the "define the arra

Re: [PATCH] mm:Avoid soft lockup due to possible attempt of double locking object's lock in __delete_object

2016-08-31 Thread Valdis . Kletnieks
On Wed, 31 Aug 2016 08:54:21 +0100, Catalin Marinas said: > On Tue, Aug 30, 2016 at 02:35:12PM -0400, Nicholas Krause wrote: > > This fixes a issue in the current locking logic of the function, > > __delete_object where we are trying to attempt to lock the passed > > object structure's spinlock aga

Re: [lkp] [fs] 45ec18d5c7: BUG: KASAN: user-memory-access on address 00007f90291c7ec0

2016-08-08 Thread Valdis . Kletnieks
On Sun, 07 Aug 2016 22:02:42 +0800, kernel test robot said: > FYI, we noticed the following commit: > > https://github.com/0day-ci/linux > Nicholas-Krause/fs-Fix-kmemleak-leak-warning-in-getname_flags-about-working-on-unitialized-memory/20160804-055054 > commit 45ec18d5c713bccb9807782f0dca29b92ba9

Re: [lkp] [fs] 45ec18d5c7: BUG: KASAN: user-memory-access on address 00007f90291c7ec0

2016-08-08 Thread Valdis . Kletnieks
On Tue, 09 Aug 2016 09:17:58 +0800, Ye Xiaolong said: > On 08/08, valdis.kletni...@vt.edu wrote: > > In other words - how did this patch get into a tree that 0day listens to? > > 0Day has a service to automatically capture every patchset sent to LKML Something's wrong then. Nick has proven to be

linux-next: Kconfig warning in drivers/bluetooth/Kconfig

2017-11-14 Thread valdis . kletnieks
strings not supported Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index eb4101aee787..b44ab176418e 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -32,7 +32,7 @@ config BT_HCIBTUSB kernel or say M to

IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

2017-11-06 Thread valdis . kletnieks
I've hit this 6 times now, across 3 boots: Nov 3 11:04:54 turing-police kernel: [ 547.814748] BUG: sleeping function called from invalid context at mm/slab.h:422 Nov 3 20:24:11 turing-police kernel: [ 60.093793] BUG: sleeping function called from invalid context at mm/slab.h:422 Nov 4 20:

Module signing broken after SYSTEM_DATA_VERIFICATION commit?

2015-08-27 Thread Valdis Kletnieks
I build kernels with MODULE_SIG=y, MODULE_SIG_FORCE=n (for build and run coverage, but it shouldn't dork my system if it breaks). next-20150810 works just fine, but next-20150826 breaks modprobe - all calls to it drop this in the dmesg: [ 31.829322] PKCS7: Unknown OID: [32] 2.16.840.1.101.3.4.2.

Re: Module signing broken after SYSTEM_DATA_VERIFICATION commit?

2015-08-28 Thread Valdis . Kletnieks
On Fri, 28 Aug 2015 11:23:54 +0100, David Howells said: > Valdis Kletnieks wrote: > > > [ 31.829322] PKCS7: Unknown OID: [32] 2.16.840.1.101.3.4.2.3 > > [ 31.829328] PKCS7: Unknown OID: [180] 2.16.840.1.101.3.4.2.3 > > OID_sha1,

Silence compiler warning in arch/x86/kvm/emulate.c

2015-08-29 Thread Valdis Kletnieks
ported-by: Aruna Hewapathirane Tested-by: Aruna Hewapathirane Signed-off-by: Valdis Kletnieks --- a/arch/x86/kvm/emulate.c.dist 2015-08-11 14:10:05.366061993 -0400 +++ b/arch/x86/kvm/emulate.c2015-08-29 13:43:13.014163958 -0400 @@ -650,6 +650,7 @@ static __always_inline int __linearize(s

Re: [PATCH] PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them

2015-08-31 Thread Valdis . Kletnieks
ght get written to dmesg: > > > > [ 31.829322] PKCS7: Unknown OID: [32] 2.16.840.1.101.3.4.2.3 > > [ 31.829328] PKCS7: Unknown OID: [180] 2.16.840.1.101.3.4.2.3 > > [ 31.829330] Unsupported digest algo: 55 > > > > Where the 55 on the third line is OID__NR indi

Next-20151009 - crash during boot

2015-10-12 Thread Valdis Kletnieks
Next-20151009 crashes early in boot (right after I feed cryptsetup the passphrase for my root filesystem). (Yes, the kernel is 10 commits past linux-next - they're all cleanup patches for drivers/staging that shouldn't enter into it) It appears to possibly be the same one reported by the "Linux T

next-20151021 - compile error in fs/f2fs/checkpoint.c

2015-10-21 Thread Valdis Kletnieks
Building next-20151021 dies with this error: CC [M] fs/f2fs/checkpoint.o fs/f2fs/checkpoint.c: In function 'get_valid_checkpoint': fs/f2fs/checkpoint.c:707:3: error: too few arguments to function 'ra_meta_pages' ra_meta_pages(sbi, cp_blk_no + 1, cp_blks - 1, META_CP); ^ fs/f2fs/checkpoint

Re: [PATCH 11/11] ASoC: wm8994: Mark expected switch fall-through

2018-08-03 Thread valdis . kletnieks
On Wed, 01 Aug 2018 14:56:16 -0500, "Gustavo A. R. Silva" said: > diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c > index 7fdfdf3..62f8c5b 100644 > --- a/sound/soc/codecs/wm8994.c > +++ b/sound/soc/codecs/wm8994.c > @@ -2432,6 +2432,7 @@ static int wm8994_set_dai_sysclk(struct s

Re: [PATCH 11/11] ASoC: wm8994: Mark expected switch fall-through

2018-08-03 Thread valdis . kletnieks
On Fri, 03 Aug 2018 11:56:12 -0500, "Gustavo A. R. Silva" said: > On 08/03/2018 11:45 AM, Mark Brown wrote: > > Basically nobody ever uses OPCLK so I'd be susprised if anyone ever > > noticed. I wonder if nobody uses it because any attempts to do so get an error? :) > I see. I wonder what's the b

Re: [tools/perf] perf test LLVM failure on 4.9

2018-01-23 Thread valdis . kletnieks
On Tue, 23 Jan 2018 18:07:25 +0530, Pintu Kumar said: > My uname says: > 4.9--amd-x86-64 Literally 4.9-? No 3rd number? And why ''? (Hint - obfuscating doesn't help here, it's hard to debug when we don't see the *actual* string.) Some unames from my various machines: 4.15.0-rc7-nex

ip6tables - last base chain position %u doesn't match underflow %u (hook %u

2018-03-09 Thread valdis . kletnieks
Am hitting an issue with this commit: commit 0d7df906a0e78079a02108b06d32c3ef2238ad25 Author: Florian Westphal Date: Tue Feb 27 19:42:37 2018 +0100 netfilter: x_tables: ensure last rule in base chain matches underflow/policy This trips on my system: [ 64.402790] ip6_tables: last ba

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-11 Thread valdis . kletnieks
On Mon, 12 Mar 2018 14:08:34 +1100, "Tobin C. Harding" said: > removal patch that 768 was a lot of stack space. That comment did, > however say 'deep in some transfer call chain'. I don't know what a > 'transfer call chain' (the transfer bit) is but is there some heuristic > we can use to know h

linux-next 20180307 - UBSAN whine in lib/radix-tree.c

2018-03-12 Thread valdis . kletnieks
Seen in the dmesg: [0.00] [0.00] UBSAN: Undefined behaviour in lib/radix-tree.c:123:14 [0.00] member access within null pointer of type 'const struct radix_tree_node' [0.00] CPU: 0 PI

linux-next: ip6tables *broken* - last base chain position %u doesn't match underflow %u (hook %u

2018-03-20 Thread valdis . kletnieks
(Resending because I haven't heard anything) Am hitting an issue with this commit: commit 0d7df906a0e78079a02108b06d32c3ef2238ad25 Author: Florian Westphal Date: Tue Feb 27 19:42:37 2018 +0100 netfilter: x_tables: ensure last rule in base chain matches underflow/policy This trips on my s

Re: linux-next: ip6tables *broken* - last base chain position %u doesn't match underflow %u (hook %u

2018-03-20 Thread valdis . kletnieks
On Tue, 20 Mar 2018 16:48:42 +0100, Florian Westphal said: > valdis.kletni...@vt.edu wrote: > > (Resending because I haven't heard anything) > [ ip6tables broken ] > > Sorry, did not see this email before. > > I'll investigate asap, thanks for the detailed report. No problem, it reverts cleanly a

linux-next 20180320 compile failure - tools/lib/str_error_r.c

2018-03-20 Thread valdis . kletnieks
Not sure who to blame here, or what changed in gcc between 0.16 and 0.19, or what the proper fix is here next-20180307 with "gcc version 8.0.1 20180222 (Red Hat 8.0.1-0.16)" built and runs fine. next-20180320 with "gcc (GCC) 8.0.1 20180317 (Red Hat 8.0.1-0.19)" dies a horrid death early du

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

2018-03-20 Thread valdis . kletnieks
On Tue, 20 Mar 2018 18:39:47 +0200, Liran Alon said: > What is your opinion in regards if it's OK to put the flag enabling this > "fix" in /proc/sys/net/core? Do you think it's sufficient? Umm.. *which* /proc/sys/net/core? These could differ for things that are in different namespaces. Or are yo

Re: linux-next 20180320 compile failure - tools/lib/str_error_r.c

2018-03-21 Thread valdis . kletnieks
On Wed, 21 Mar 2018 10:29:38 -0300, Arnaldo Carvalho de Melo said: > Em Tue, Mar 20, 2018 at 12:43:32PM -0400, valdis.kletni...@vt.edu escreveu: > > next-20180320 with "gcc (GCC) 8.0.1 20180317 (Red Hat 8.0.1-0.19)" dies a > > horrid death early > > during the compile: > > > > CC /usr/sr

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

2018-06-16 Thread valdis . kletnieks
On Sat, 16 Jun 2018 15:00:31 +0900, Hyunil Kim said: > *fix checkpatch.pl warnings: > WARNING: line over 80 characters > + if (((ieee->wpa_ie[0] == 0xdd) && > + (!memcmp(&(ieee->wpa_ie[14]), ccmp_ie, 4))) || > + ((ieee->wpa_ie[0] == 0x30) && > +

Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters

2018-06-17 Thread valdis . kletnieks
On Sun, 17 Jun 2018 15:07:03 -0400, Nicolas Pitre said: > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index 1eb1a376a0..7b636638b3 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -317,6 +317,171 @@ void schedule_console_callback(void) > schedule_work(&console

Re: wmi: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)

2018-06-17 Thread valdis . kletnieks
On Sun, 17 Jun 2018 22:30:27 +0300, Mihai Donțu said: > Your patch works OK for me, thank you. The libsmbios tool, however, not > so much. It appears to be behind latest developments. > > # echo "+keyboard" >/sys/class/leds/dell\:\:kbd_backlight/start_triggers > > is all that is needed today. If

Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters

2018-06-17 Thread valdis . kletnieks
On Sun, 17 Jun 2018 19:17:51 -0400, Nicolas Pitre said: > On Sun, 17 Jun 2018, valdis.kletni...@vt.edu wrote: > > This preprocessor variable seems to be dangling in the breeze, with > > no way for it to get set? As a result, we pick up the #else define by > > default. > > That's actually what's i

Re: [PATCH] radix-tree: avoid NULL dereference

2018-07-06 Thread valdis . kletnieks
On Fri, 06 Jul 2018 14:41:44 +0100, Mark Rutland said: > I beleive this is what Valdis hit [1] back in March. I spotted this while > booting an arm64 machine. Yes, the stack trace is the same. The odd part is that I was consistently seeing it until next-20180626, but it evaporated in sometime be

Re: [PATCH v2 6/7] vmw_balloon: update copyright message

2018-06-15 Thread valdis . kletnieks
On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > >> In addition, updating the year and adding a license tag. > >> +// SPDX-License-Identifier: GPL-2.0 > > You still have a lot of boiler-plate text in here that can be removed. > > Please do so. > But what else do you want me to remove? Thi

Re: linux-next 20180515 - ACPI disabled..

2018-05-17 Thread valdis . kletnieks
On Wed, 16 May 2018 13:58:04 +0200, "Rafael J. Wysocki" said: > On Wednesday, May 16, 2018 12:25:30 AM CEST valdis.kletni...@vt.edu wrote: > > On Tue, 15 May 2018 15:49:15 -0600, Al Stone said: > > > > > Not off-hand. Could you please send me a copy of > > > /sys/firmware/acpi/tables/APIC > The

[BUG] ext4 null pointer crash in linux-next

2018-10-08 Thread valdis . kletnieks
I'm seeing a fairly replicable crash/hang with a traceback implicating ext4 (or possibly the block layer). next-20180918 seemed stable, but next-20180926 and -next-20181005 have a habit of crashing while dnf is updating software (so far, I've hit it 6 times with identical tracebacks while attemptin

Re: [PATCH] kernel/signal: Signal-based pre-coredump notification

2018-10-15 Thread valdis . kletnieks
On Mon, 15 Oct 2018 18:28:03 -0500, Eric W. Biederman said: > Enke Chen writes: > > > For simplicity and consistency, this patch provides an implementation > > for signal-based fault notification prior to the coredump of a child > > process. A new prctl command, PR_SET_PREDUMP_SIG, is defined that

Re: [PATCH v2] of: overlay: user space synchronization

2018-10-15 Thread valdis . kletnieks
On Mon, 15 Oct 2018 17:27:01 -0700, frowand.l...@gmail.com said: > From: Frank Rowand > > When an overlay is applied or removed, the live devicetree visible in > /proc/device-tree/, aka /sys/firmware/devicetree/base/, reflects the > changes. There is no method for user space to determine whether

Re: [PATCH v3 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-10-19 Thread valdis . kletnieks
On Wed, 17 Oct 2018 23:59:07 -0700, "Joel Fernandes (Google)" said: > This usecase cannot be implemented with the existing F_SEAL_WRITE seal. > To support the usecase, this patch adds a new F_SEAL_FUTURE_WRITE seal > which prevents any future mmap and write syscalls from succeeding while > keeping

Re: [PATCH v3 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-10-19 Thread valdis . kletnieks
On Fri, 19 Oct 2018 10:57:31 -0700, Joel Fernandes said: > On Fri, Oct 19, 2018 at 10:32 AM, wrote: > > What is supposed to happen if some other process has an already existing R/W > > mmap of the region? (For that matter, the test program doesn't seem to > > actually test that the existing mmap

Re: [patch 1/6] Linux Kernel Markers - Architecture Independent Code

2007-09-07 Thread Valdis . Kletnieks
On Fri, 07 Sep 2007 12:04:45 EDT, Theodore Tso said: > This was proposed by Andrew and discussed at the Kernel Summit; the > basic idea is that it is a formal indication that the person has done > a *full* review of the patch (a few random comments from the local > whitespace police don't count),

Re: AUTO LOGIN BUG

2007-09-06 Thread Valdis . Kletnieks
On Wed, 05 Sep 2007 04:48:05 MDT, Sean Robert McGuffee said: > machine. For those who make the argument that someone logged in as root > might break the machine by doing something they shouldn't, I would say > it's already broken without being root. Hint 1: If you're not smart enough to figure

Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc

2007-09-08 Thread Valdis . Kletnieks
On Thu, 30 Aug 2007 12:27:10 EDT, Chuck Ebbert said: > On 08/29/2007 07:15 PM, Andrew Morton wrote: > >>> The issue: vdso and gettimeofday seem to be having a quarrel. > >> This is also open as a Fedora bug: > >> https://bugzilla.redhat.com/show_bug.cgi?id=262481 > >> > > > > So it's an interacti

Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc

2007-09-08 Thread Valdis . Kletnieks
On Sat, 08 Sep 2007 10:57:50 +0200, Andi Kleen said: > vdso effectively only supports TSC and HPET (the other clock sources are not > accessible > from ring 3) Ahh.. that explains why acpi_pm clocksource doesn't trip over the problem pgpZ3U1saEbaH.pgp Description: PGP signature

Re: Broken mail setup

2007-09-10 Thread Valdis . Kletnieks
On Mon, 10 Sep 2007 14:39:34 BST, Alan Cox said: > On Mon, 10 Sep 2007 16:20:42 +0300 > Sami Farin <[EMAIL PROTECTED]> wrote: > > > On Mon, Sep 10, 2007 at 13:59:12 +0100, Alan Cox wrote: > > > Will RMK ([EMAIL PROTECTED]) please fix his email setup otherwise I > > > can't send serial/tty/arm stuf

Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc

2007-09-10 Thread Valdis . Kletnieks
he masking. > > Thanks to Chuck Ebbert for tracking down. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Confirming that does indeed fix it - booted with hpet clocksource and vdso=1, and the time didn't warp at the 5-minute mark. Tested-By: Valdis Kletnieks <[EMAIL PROTECTED]> pgpKiIz2yl9qH.pgp Description: PGP signature

Re: 2.6.23-rc7-mm1 - 'touch' command causes Oops.

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 13:05:08 BST, Christoph Hellwig said: > On Mon, Sep 24, 2007 at 06:35:50AM -0400, [EMAIL PROTECTED] wrote: > > On Mon, 24 Sep 2007 02:17:16 PDT, Andrew Morton said: > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/ > > > > It li

Re: [PATCH] Uninline kcalloc()

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 08:59:56 EDT, Kyle Moffett said: > Proper fix is to give __kmalloc a "void *caller" parameter and have > all of the various wrapper functions pass in the value of > __builtin_return_address() appropriately. I believe that even works > properly for inline functions which

Re: 2.6.23-rc7-mm1 - 'touch' command causes Oops.

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 08:45:32 PDT, Dave Hansen said: > Any idea which fs and distro this was? I'd like to add it to my tests. initscripts-8.56-1, from Fedora Rawhide, /etc/rc.sysinit, line 325: touch /dev/.in_sysinit >/dev/null 2>&1 Specific enough? :) pgp3OvCOFx0xa.pgp Description: PGP signa

Odd kprobes question...

2007-09-25 Thread Valdis . Kletnieks
2.6.23-rc8-mm1, x86_64. # ls -l /sys/kernel/debug/kprobes/ total 0 -rw--- 1 root root 0 2007-09-25 12:21 enabled -r--r--r-- 1 root root 0 2007-09-25 12:21 list Is there a reason 'enabled' is mod 0600 instead of 0644, when 'list' is 444 and allows you to figure out (indirectly) if it's enabled

Re: [RFC] QoS params patch

2007-09-26 Thread Valdis . Kletnieks
On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: (others here are probably better at spotting leaks and races than I am, so I'm skipping those and picking other nits. ;) > --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.0 -0700 > +++ linux-2.6.23-rc8-qos/kernel/Makefile 20

Re: try_module_get code understanding

2007-09-26 Thread Valdis . Kletnieks
On Thu, 27 Sep 2007 05:19:06 -, Shreyansh Jain said: > - > static inline int try_module_get(struct module *module){ > int ret = 1; <--- error case when !module > if (module) { > unsigned int cpu = get_cpu(); > if (likely(module_is_live(module))) >

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: > "CodingStyle" should be about the big issues, not about details. Yes, > we've messed that up over the years, but let's not continue that. > > In other words, I'd suggest *removing* lines from CodingStyle, not adding > them. The file has a

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Valdis . Kletnieks
On Thu, 27 Sep 2007 02:22:20 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Locks up hard at very early boot on my Dell Latitude - grub says loading kernel, the screen clears, and we lock up before we get penguins. -rc8-mm1 was

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 03:51:56 PDT, Andrew Morton said: > Printing something like > > bytes remaining: 0x12 (18) > > is a quite logical thing to do, although pretty darm pointless. On the other hand, printing this: magic number: 0x2710 probably doesn't ring any bells, but if you c

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 20:00:01 PDT, Linus Torvalds said: > On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I think there needs to be a "sense of fairness" attached here - CodingStyle > > should cover all the stuff maintainers/reviewers are allowed to whinge > > about. > > No. > > People whine to

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sun, 30 Sep 2007 04:27:24 BST, Al Viro said: > ... and no matter how many rules you put down, it's still possible to > write a code that will be awful stylistically while adhering to all of > them. Religiously. I've run into those sort of programmers. Unfortunately, there's no real cure for

Re: 2.6.23-rc8-mm2

2007-10-01 Thread Valdis . Kletnieks
On Sun, 30 Sep 2007 01:50:14 PDT, Andrew Morton said: > On Sat, 29 Sep 2007 22:26:21 -0400 [EMAIL PROTECTED] wrote: > > > On Thu, 27 Sep 2007 02:22:20 PDT, Andrew Morton said: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ > > > > Locks up hard at v

Re: 2.6.23-rc8-mm2

2007-10-01 Thread Valdis . Kletnieks
On Sun, 30 Sep 2007 22:01:43 +0200, "Rafael J. Wysocki" said: > On Sunday, 30 September 2007 10:50, Andrew Morton wrote: > > On Sat, 29 Sep 2007 22:26:21 -0400 [EMAIL PROTECTED] wrote: > > > > > On Thu, 27 Sep 2007 02:22:20 PDT, Andrew Morton said: > > > > ftp://ftp.kernel.org/pub/linux/kernel/peo

Re: 2.6.23-rc6-mm1

2007-09-18 Thread Valdis . Kletnieks
On Tue, 18 Sep 2007 01:18:41 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc6/2.6.23-rc6-mm1/ > +gregkh-driver-driver-core-add-config_uevent_helper_path.patch So I do a 'make silentoldconfig', and I get: * * Generic Driver Options * path to ueve

2.6.23-rc6-mm1 - Mostly working, with a kbuild oddity

2007-09-18 Thread Valdis . Kletnieks
On Tue, 18 Sep 2007 01:18:41 PDT, Andrew Morton said: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc6/2.6.23-rc6-mm1/ % uname -a Linux turing-police.cc.vt.edu 2.6.23-rc6-mm1 #1 SMP PREEMPT Tue Sep 18 12:32:13 EDT 2007 x86_64 x86_64 x86_64 GNU/Linux % uptime 15:11:48

Re: What can be done to reduce the huge number of build fixes required to release an MM tree?

2007-09-18 Thread Valdis . Kletnieks
On Tue, 18 Sep 2007 08:23:38 EDT, Miles Lane said: > and once in while causes trouble? And 3) Who is causing the most > cumulative trouble? Umm... Andrew's Vaio and my Latitude? :) Seriously though - one big chunk of the problem is almost certainly that Andrew and I run with .config's and hardw

Re: [PATCH] Combine instrumentation menus in kernel/Kconfig.instrumentation

2007-09-18 Thread Valdis . Kletnieks
On Tue, 18 Sep 2007 17:12:59 EDT, Mathieu Desnoyers said: > +++ linux-2.6-lttng/kernel/Kconfig.instrumentation2007-09-18 13:18:17.000 00 -0400 > @@ -0,0 +1,40 @@ > +menuconfig INSTRUMENTATION > + bool "Instrumentation Support" > + default y > + ---help--- > + Say Y here t

Re: 2.6.23-rc6-mm1 - Mostly working, with a kbuild oddity

2007-09-18 Thread Valdis . Kletnieks
On Tue, 18 Sep 2007 22:32:39 +0200, Sam Ravnborg said: > So the external module were fiddeling with CFLAGS which is wrong. > Yes - it worked before by accident. OK, I can deal with that diagnosis. ;) > Pelase ask the author of the module to either fix it or even better > submit the driver for in

Re: drivers/usb/misc/emi*.c have the biggest data objects in the whole tree

2007-09-18 Thread Valdis . Kletnieks
On Fri, 14 Sep 2007 11:35:34 BST, Denys Vlasenko said: > Hi Tapio, > > You are the author of these files. Are you still maintaining them? > If not, do you know who is the current maintainer? > These two object files hold the biggest data objects in the whole Linux kernel > after lockdep: > >

Re: [PATCH] Combine instrumentation menus in kernel/Kconfig.instrumentation

2007-09-18 Thread Valdis . Kletnieks
On Tue, 18 Sep 2007 21:06:28 EDT, Mathieu Desnoyers said: > * [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: > > OK, I'll bite - given the mention of 'debugging' there, do we want to go for > > broke and *also* suck in the 'Kernel Hacking' menu as well? > > Instrumentation primarity aims at debugg

Re: 2.6.23-rc6-mm1 - Mostly working, with a kbuild oddity

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 09:34:02 +0200, Sam Ravnborg said: > > I had a few issues with some other modules, but they're evil binaries so > > I'm taking those up directly with the companies involved.. ;) > > How annoying is this - and is this the CFLAGS thing again? The other issues were VMWare and th

<    2   3   4   5   6   7   8   9   10   11   >