On Wed, 01 Aug 2018 14:56:16 -0500, "Gustavo A. R. Silva" said: > diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c > index 7fdfdf3..62f8c5b 100644 > --- a/sound/soc/codecs/wm8994.c > +++ b/sound/soc/codecs/wm8994.c > @@ -2432,6 +2432,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai > *dai, > snd_soc_component_update_bits(component, > WM8994_POWER_MANAGEMENT_2, > WM8994_OPCLK_ENA, 0); > } > + /* fall through */ > > default: > return -EINVAL;
Wait, what? This looks like the sort of bug -Wimplicit-fallthrough is supposed to catch. Unless for 'case WM8994_SYSCLK_OPCLK:' we actually do want to do a whole bunch of snd_soc_component_update_bits() calls and then return -EINVAL whether or not that case succeeded?
pgpDgYKeTAoYz.pgp
Description: PGP signature
