> The user side of the list has been pretty quiet to be sure. Most of the
> discussion happens internal to the team. The primary KIS developer is out
> the office until next week but I'll try to make sure he addresses this as
> soon as he can. I agree entirely with the more eyes approach and none o
On Wed, Feb 27, 2013 at 10:13 AM, Stephen Hemminger
wrote:
>
> Have you looked at netmap? Seems like a cleaner user API for this.
>
That might be a bit orthogonal to this. I believe the intent it to
allow spin polling from socket calls without API change.
>
> There is a version for Linux, but it
> This is exactly the kind of approach that makes sense rather than
> trying to put entire TCP stacks in the network card firmware.
>
And should also obviate the need to put a full TCP stack in user space!
> Thanks again for doing this work and I look forward to applying
> this stuff once all the
On Thu, Aug 4, 2016 at 12:36 PM, wrote:
> From: Kan Liang
>
> To achieve better network performance, the key step is to distribute the
> packets to dedicated queues according to policy and system run time
> status.
>
> This patch provides an interface which can return the proper dedicated
> queu
On Thu, Aug 4, 2016 at 5:17 PM, Daniel Borkmann wrote:
> On 08/05/2016 12:54 AM, Andi Kleen wrote:
>>>
>>> +1, I tried to bring this up here [1] in the last spin. I think only very
>>> few changes would be needed, f.e. on eBPF side to add a queue setting
>>> helper function which is probably strai
On Fri, Aug 5, 2016 at 6:55 AM, Liang, Kan wrote:
>
>
>>
>> On Thu, Aug 4, 2016 at 12:36 PM, wrote:
>> > From: Kan Liang
>> >
>> > To achieve better network performance, the key step is to distribute
>> > the packets to dedicated queues according to policy and system run
>> > time status.
>> >
Please combine these related patches fixing BUG in rxrpc into a patch
set with proper annotation,
Also, can any of these BUG_ONs be replaced by WARN_ONs? Warnings are
generally preferable to crashing the system.
Tom
On Tue, Oct 24, 2017 at 9:20 AM, Gustavo A. R. Silva
wrote:
> Use BUG_ON inste
On Mon, Oct 30, 2017 at 2:44 PM, John Fastabend
wrote:
> On 10/24/2017 08:20 AM, syzbot wrote:
>> Hello,
>>
>> syzkaller hit the following crash on 73d3393ada4f70fa3df5639c8d438f2f034c0ecb
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
>> compiler: gcc (GCC) 7.1.1 20170
On Fri, Oct 23, 2015 at 11:40 PM, Jarod Wilson wrote:
> There are some netdev features that make little sense to toggle on and
> off in a stacked device setup on only one device in the stack. The prime
> example is a bonded connection, where it really doesn't make sense to
> disable LRO on the mas
On Thu, Jan 4, 2018 at 4:10 AM, syzbot
wrote:
> Hello,
>
> syzkaller hit the following crash on
> 6bb8824732f69de0f233ae6b1a8158e149627b38
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console output is at
On Tue, Jan 16, 2018 at 12:40 PM, syzbot
wrote:
> syzkaller has found reproducer for the following crash on
> a8750ddca918032d6349adbf9a4b6555e7db20da
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console
On Sun, Mar 11, 2018 at 2:34 PM, Eric Biggers wrote:
> On Wed, Feb 14, 2018 at 02:45:05PM +0100, 'Dmitry Vyukov' via syzkaller-bugs
> wrote:
>> On Wed, Dec 6, 2017 at 1:50 PM, Dmitry Vyukov wrote:
>> > On Fri, Oct 27, 2017 at 11:18 PM, Cong Wang
>> > wrote:
>> >> On Thu, Oct 26, 2017 at 11:00
On Thu, Dec 4, 2014 at 10:39 AM, Joe Stringer wrote:
> ndo_gso_check() was recently introduced to allow NICs to report the
> offloading support that they have on a per-skb basis. Add an
> implementation for this driver which checks for IPIP, GRE, UDP tunnels.
>
> Signed-off-by: Joe Stringer
> ---
On Thu, Jan 22, 2015 at 10:02 AM, Mohammad Jamal
wrote:
> This patch optimizes __skb_push function
>
> Signed-off-by: Mohammad Jamal
> ---
> include/linux/skbuff.h |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> inde
On Sun, Jun 14, 2015 at 11:12 PM, Huang Ying wrote:
> FYI, we noticed the below changes on
>
> git://flatbed.openfabrics.org/~amirv/linux.git for-upstream
> commit 6a74fcf426f51aaa569f0b973d10ac20468df238 ("flow_dissector: add support
> for dst, hop-by-hop and routing ext hdrs")
>
Fix was pushed
Are you pointing out a regressions in this?
On Thu, Jul 24, 2014 at 11:31 PM, Aaron Lu wrote:
> FYI, we noticed the below changes on
>
> commit 11ef7a8996d5d433c9cd75d80651297eccbf6d42 ("net: Performance fix for
> process_backlog")
>
> test case: lkp-t410/netperf/300s-200%-10K-SCTP_STREAM_MANY
>
On Thu, Jul 24, 2014 at 11:49 PM, Aaron Lu wrote:
> On 07/25/2014 02:48 PM, David Miller wrote:
>> From: Tom Herbert
>> Date: Thu, 24 Jul 2014 23:37:07 -0700
>>
>>> Are you pointing out a regressions in this?
>>
>> I think he's letting you know th
On Wed, Jun 25, 2014 at 12:51 PM, Eric Dumazet wrote:
> From: Tom Herbert
>
> Dave Jones reported that a crash is occurring in
>
> csum_partial
> tcp_gso_segment
> inet_gso_segment
> ? update_dl_migration
> skb_mac_gso_segment
> __skb_gso_segment
> dev_
>
> I assume this is the series "[PATCH 0/4] Checksum fixes"
> (marc.info/?l=linux-netdev&m=140261417832399&w=2)?
>
Yes.
> As I'm not subscribed to netdev, I cannot reply to that thread.
>
> "[PATCH 1/4] net: Fix save software checksum complete" fixes the issue
> for me.
> However, "[PATCH 2/4] ud
> Thanks, I applied the series "[PATCH 0/4] Checksum fixes", and the fix
> above, but it doesn't help.
>
> Note that I'm also using NFS root, which doesn't seem to be affected.
> I can happily run "ls -R /" on the serial console during the 10 s delay
in ssh.
>
Geert,
Thanks for your patience!
Ca
On Tue, May 6, 2014 at 11:32 AM, Andi Kleen wrote:
>> We simply can not compete with user space, as a programmer is free to
>> keep what he really wants/needs.
>
> Not true.
>
> With my patches and LTO Linux can be competive with LWIP+socket layer.
> (about 60K more text). And it's easier to use b
> tcp_gso_segment() makes sure that the headers are reachable in the linear
> area with the pskb_may_pull(skb, sizeof(*th)) call, and gso_make_checksum()
> is only working with the area up to SKB_GSO_CB()->csum_start which should
> be within this area for sure.
>
Seems likely that csum_start is not
I believe in the no scatter-gather case of skb_segment is not set
correctly. Will post a patch momentarily.
On Tue, Jun 24, 2014 at 8:05 PM, Tom Herbert wrote:
>> tcp_gso_segment() makes sure that the headers are reachable in the linear
>> area with the pskb_may_pull(skb, sizeof(*th
()->csum_start is
not set correctly when doing non-scatter gather. We are using
offset as opposed to doffset.
Reported-by: Dave Jones
Signed-off-by: Tom Herbert
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 9cd5
On Mon, Dec 16, 2013 at 11:26 PM, Zhi Yong Wu wrote:
> From: Zhi Yong Wu
>
> The flow cache is an extremely broken concept, and it usually brings up
> growth issues and DoS attacks, so this patch is trying to remove it from
> the tuntap driver, and insteadly use a simpler way for its flow control
>> Yes , in it's current state it's broken. But maybe we can try to fix
>> it instead of arbitrarily removing it. Please see my patches on
>> plumbing RFS into tuntap which may start to make it useful.
> Do you mean you patch [5/5] tun: Added support for RFS on tun flows?
> Sorry, can you say with
I posted an implementation of library functions for Toeplitz (see
[PATCH 1/2] net: Toeplitz library functions). This includes some
pre-computation of the table to get reasonable performance in the
host. Please take a look.
On the other hand, if you're computing a hash in the host, do you
really n
efficient, we precompute
the possible hash values for each inidividual byte of input. The input
length is up to 40 bytes, so we make an array of cache[40][256].
The implemenation was verified against MSDN "Verify RSS hash" sample
values.
Signed-off-by: Tom Herbert
---
include/li
On Thu, Dec 19, 2013 at 3:15 PM, Haiyang Zhang wrote:
>> -Original Message-
>> From: Tom Herbert [mailto:therb...@google.com]
>> Sent: Thursday, December 19, 2013 4:43 PM
>> To: Haiyang Zhang
>> Cc: Daniel Borkmann; Ben Hutchings; da...@davemloft.net;
psulation protocols where the format and size of the header
>> > may
>> > differ. This patch series implements ndo_gso_check() for these NICs,
>> > restricting the GSO handling to something that looks and smells like VXLAN.
>> >
>> > Implementation sham
On Wed, Nov 5, 2014 at 6:15 PM, David Miller wrote:
> From: Joe Stringer
> Date: Wed, 5 Nov 2014 17:06:46 -0800
>
>> My impression was that the changes are more likely to be
>> hardware-specific (like the i40e changes) rather than software-specific,
>> like changes that might be integrated into t
:
>> -Original Message-
>> From: Tom Herbert [mailto:therb...@google.com]
>>
>> On Wed, Nov 5, 2014 at 6:15 PM, David Miller
>> wrote:
>> > From: Joe Stringer
>> > Date: Wed, 5 Nov 2014 17:06:46 -0800
>> >
>> >> My impression was tha
e
> *queue,
> if (old_map)
> static_key_slow_dec(&rps_needed);
>
> - spin_unlock(&rps_map_lock);
> + mutex_unlock(&rps_map_mutex);
>
> if (old_map)
> kfree_rcu(old_map, rcu);
> --
> 1.7.10.4
>
On Thu, Jul 16, 2015 at 5:40 AM, Denys Vlasenko wrote:
> This patch deinlines jhash, jhash2 and __jhash_nwords.
>
> It also removes rhashtable_jhash2(key, length, seed)
> because it was merely calling jhash2(key, length, seed).
>
> With this .config: http://busybox.net/~vda/kernel_config,
> after
We've put considerable effort into cleaning up the checksum interface
to make it as unambiguous as possible, please be very careful to
follow it. Broken checksum processing is really hard to detect and
debug.
CHECKSUM_UNNECESSARY means that some number of _specific_ checksums
(indicated by csum_le
On Sat, Apr 30, 2016 at 1:59 PM, Ben Greear wrote:
>
> On 04/30/2016 12:54 PM, Tom Herbert wrote:
>>
>> We've put considerable effort into cleaning up the checksum interface
>> to make it as unambiguous as possible, please be very careful to
>> follow it. Broken
fdf1563 ("gre6: Cleanup GREv6 receive path, call common GRE
> functions")
> ---
Acked-by: Tom Herbert
> net/ipv6/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index 11e875ffd7ac..3f8411328de5 100644
> --- a/net/i
On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote:
> On 21 November 2014 at 09:59, Joe Stringer wrote:
>> On 20 November 2014 16:19, Jesse Gross wrote:
>>> I don't know if we need to have the check at all for IPIP though -
>>> after all the driver doesn't expose support for it all (actually it
On Mon, Dec 1, 2014 at 3:53 PM, Jesse Gross wrote:
> On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote:
>> On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote:
>>> On 21 November 2014 at 09:59, Joe Stringer wrote:
>>>> On 20 November 2014 16:19, Jesse Gross wrote:
I am looking at it.
On Mon, Nov 10, 2014 at 11:24 AM, David Miller wrote:
> From: Randy Dunlap
> Date: Mon, 10 Nov 2014 10:15:11 -0800
>
>> On 11/10/14 01:59, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20141106:
>>>
>>
>> on x86_64:
>> when CONFIG_NET_IP_TUNNEL=y and CONFIG_NET_FO
On Fri, May 1, 2015 at 11:42 AM, Eric Dumazet wrote:
> On Fri, 2015-05-01 at 13:43 -0400, Eric B Munson wrote:
>> In order to enable policy decisions in userspace, the data contained in
>> the SYN packet would be useful for tracking or identifying connections.
>> Only parts of this data are availa
On Mon, Mar 2, 2015 at 1:54 PM, Joe Stringer wrote:
> The goal of this series is to allow OVS to send packets through the Linux
> kernel connection tracker, and subsequently match on fields populated by
> conntrack.
>
> Sending this out as another RFC change as this is the first time IP fragment
>
- skb_gro_remcsum_process() sets offset before changing delta,
> - skb_gro_remcsum_cleanup() checks if delta is non-zero before
> accessing offset,
> it's safer to let the initialization function initialize all members.
>
Acked-by: Tom Herbert
> Signed-off-by: Geert Uytte
On Thu, Apr 7, 2016 at 11:52 PM, Herbert Xu wrote:
> On Wed, Apr 06, 2016 at 10:56:12AM -0700, Tadeusz Struk wrote:
>>
>> The intend is to enable HW acceleration of the TLS protocol.
>> The way it will work is that the user space will send a packet of data
>> via AF_ALG and HW will authenticate an
On Thu, Nov 5, 2015 at 7:52 PM, Jason A. Donenfeld wrote:
> Hi folks,
>
> When sending arbitrary SKBs with udp_tunnel_xmit_skb, the networking
> stack does not appear to be utilizing UFO on the outgoing UDP packets,
> which significantly caps the transmission speed. I see about 50% CPU
> usage in
On Sun, Nov 8, 2015 at 7:31 PM, Dexuan Cui wrote:
>> From: David Miller [mailto:da...@davemloft.net]
>> Sent: Monday, November 9, 2015 11:24
>> ...
>> > Thanks, David!
>> > I understand 1 TX queue is the bottleneck (however in Simon's
>> > test, TX=1 => 36.7Gb/s, TX=8 => 37.7 Gb/s, so it looks the
On Thu, Feb 14, 2019 at 5:00 PM Dominique Martinet
wrote:
>
> Dominique Martinet wrote on Wed, Oct 31, 2018:
> > Anyway, that probably explains I have no problem with bigger VM
> > (uselessly more memory available) or without KASAN (I guess there's
> > overhead?), but I'm sending at most 300k of d
On Thu, Feb 14, 2019 at 5:57 PM Dominique Martinet
wrote:
>
> Tom Herbert wrote on Thu, Feb 14, 2019:
> > > The best alternative I see is adding a proper helper to get
> > > "kcm_rx_msg(skb)->offset" from bpf and document it so users aren't as
> &g
On Thu, Feb 14, 2019 at 7:31 PM Dominique Martinet
wrote:
>
> Tom Herbert wrote on Thu, Feb 14, 2019:
> > > This second patch[2] (the current thread) now does an extra clone if
> > > there is an offset, but the problem really isn't in the clone but the
> > >
On Tue, Feb 19, 2019 at 8:12 PM Dominique Martinet
wrote:
>
> Dominique Martinet wrote on Fri, Feb 15, 2019:
> > With all that said I guess my patch should work correctly then, I'll try
> > to find some time to check the error does come back up the tcp socket in
> > my reproducer but I have no rea
On Thu, Feb 21, 2019 at 12:22 AM Dominique Martinet
wrote:
>
> Tom Herbert wrote on Wed, Feb 20, 2019:
> > > When the client closes the socket, some messages are obviously still "in
> > > flight", and the server will recv a POLLERR notification on the csock at
&
On Fri, Feb 22, 2019 at 12:28 PM Dominique Martinet
wrote:
>
> Tom Herbert wrote on Fri, Feb 22, 2019:
> > > > So basically it sounds like you're interested in supporting TCP
> > > > connections that are half closed. I believe that the error in half
> >
On Sat, May 5, 2018 at 2:43 AM, Herbert Xu wrote:
> On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote:
>> rhashtable_walk_prev() returns the object returned by
>> the previous rhashtable_walk_next(), providing it is still in the
>> table (or was during this grace period).
>> This works eve
On Mon, Jul 18, 2016 at 5:51 PM, Liang, Kan wrote:
>
>
>> >
>> > It is a big challenge to get good network performance. First, the
>> > network performance is not good with default system settings. Second,
>> > it is too difficult to do automatic tuning for all possible workloads,
>> > since workl
On Mon, Oct 24, 2016 at 2:28 AM, Jakub Sitnicki wrote:
> Same as for the transmit path, let's do our best to ensure that received
> ICMP errors that may be subject to forwarding will be routed the same
> path as flow that triggered the error, if it was going in the opposite
> direction.
>
Unfortun
On Fri, Oct 28, 2016 at 1:32 AM, Jakub Sitnicki wrote:
> On Thu, Oct 27, 2016 at 10:35 PM GMT, Tom Herbert wrote:
>> On Mon, Oct 24, 2016 at 2:28 AM, Jakub Sitnicki wrote:
>>> Same as for the transmit path, let's do our best to ensure that received
>>> IC
On Sat, Oct 22, 2016 at 8:57 AM, Eric Garver wrote:
> On Sat, Oct 22, 2016 at 12:16:29AM +0200, Arnd Bergmann wrote:
>> On Friday, October 21, 2016 11:05:45 PM CEST Arnd Bergmann wrote:
>> >
>> > Can you explain why "dissector_uses_key(flow_dissector,
>> > FLOW_DISSECTOR_KEY_VLAN) && skb_vlan_tag_
On Sun, Oct 30, 2016 at 6:03 AM, Jakub Sitnicki wrote:
> On Fri, Oct 28, 2016 at 02:25 PM GMT, Tom Herbert wrote:
>> On Fri, Oct 28, 2016 at 1:32 AM, Jakub Sitnicki wrote:
>>> On Thu, Oct 27, 2016 at 10:35 PM GMT, Tom Herbert wrote:
>>>> On Mon, Oct 24, 2016 at
On Tue, Nov 1, 2016 at 9:25 AM, Hannes Frederic Sowa
wrote:
> On 31.10.2016 20:25, Tom Herbert wrote:
>> The normal hash for TCP or UDP using ECMP is over > dstIP, srcPort, dstPort>. For an ICMP packet ECMP would most likely be
>> done over . There really is no way to e
On Wed, Dec 14, 2016 at 10:46 AM, Jason A. Donenfeld wrote:
> SipHash is a 64-bit keyed hash function that is actually a
> cryptographically secure PRF, like HMAC. Except SipHash is super fast,
> and is meant to be used as a hashtable keyed lookup function.
>
"super fast" is relative. My quick tes
On Wed, Dec 14, 2016 at 4:53 AM, Jason A. Donenfeld wrote:
> Hi David,
>
> On Wed, Dec 14, 2016 at 10:51 AM, David Laight
> wrote:
>> From: Jason A. Donenfeld
>>> Sent: 14 December 2016 00:17
>>> This gives a clear speed and security improvement. Rather than manually
>>> filling MD5 buffers, we
On Wed, Dec 14, 2016 at 12:55 PM, Jason A. Donenfeld wrote:
> Hey Tom,
>
> Just following up on what I mentioned in my last email...
>
> On Wed, Dec 14, 2016 at 8:35 PM, Jason A. Donenfeld wrote:
>> I think your suggestion for (2) will contribute to further
>> optimizations for (1). In v2, I had
On Wed, Dec 14, 2016 at 2:56 PM, Jason A. Donenfeld wrote:
> Hey Tom,
>
> On Wed, Dec 14, 2016 at 10:35 PM, Tom Herbert wrote:
>> Those look good, although I would probably just do 1,2,3 words and
>> then have a function that takes n words like jhash. Might want to c
On Fri, Dec 16, 2016 at 4:39 AM, Jason A. Donenfeld wrote:
> Hey JP,
>
> On Fri, Dec 16, 2016 at 9:08 AM, Jean-Philippe Aumasson
> wrote:
>> Here's a tentative HalfSipHash:
>> https://github.com/veorq/SipHash/blob/halfsiphash/halfsiphash.c
>>
>> Haven't computed the cycle count nor measured its s
On Fri, Dec 16, 2016 at 12:41 PM, George Spelvin
wrote:
> Tom Herbert wrote:
>> Tested this. Distribution and avalanche effect are still good. Speed
>> wise I see about a 33% improvement over siphash (20 nsecs/op versus 32
>> nsecs). That's about 3x of jhash speed (7 ns
On Wed, Mar 22, 2017 at 3:59 PM, R. Parameswaran
wrote:
>
> A new function, kernel_sock_ip_overhead(), is provided
> to calculate the cumulative overhead imposed by the IP
> Header and IP options, if any, on a socket's payload.
> The new function returns an overhead of zero for sockets
> that do n
On Tue, Jun 7, 2016 at 4:01 PM, David Miller wrote:
> From: John Crispin
> Date: Mon, 6 Jun 2016 08:43:13 +0200
>
>> i think one solution would be to add some code to have 2 devices share
>> the same dql instance. would that be an acceptable solution ?
>
> You still need to address the issue of s
On Wed, Mar 23, 2016 at 11:27 AM, David Miller wrote:
> From: Bjorn Helgaas
> Date: Wed, 23 Mar 2016 08:45:30 -0500
>
>> Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
>> indentation. No functional change intended; only comment and whitespace
>> changes.
>>
>> Signed-off-by
t sk_buff *skb,
> struct flow_dissector_key_ports *key_ports;
> struct flow_dissector_key_tags *key_tags;
> struct flow_dissector_key_keyid *key_keyid;
> - u8 ip_proto;
> + u8 ip_proto = 0;
>
> if (!data) {
> data = s
On Mon, Feb 1, 2016 at 11:41 AM, David Miller wrote:
> From: David Laight
> Date: Mon, 1 Feb 2016 16:37:41 +
>
>> From: Lucas Tanure
>>> Sent: 30 January 2016 13:18
>>> As suggested by checkpatch.pl:
>>> CHECK: Prefer kernel type 'uX' over 'uintX_t'
>>
>> One might ask why?
>
> We have consis
On Thu, Feb 4, 2016 at 2:56 AM, Ingo Molnar wrote:
>
> * Ingo Molnar wrote:
>
>> s/!CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>>
>> > +
>> > + /* Check length */
>> > +10:cmpl$8, %esi
>> > + jg 30f
>> > + jl 20f
>> > +
>> > + /* Exactly 8 bytes length */
>> > + addl
On Thu, Feb 4, 2016 at 1:46 PM, Linus Torvalds
wrote:
> I missed the original email (I don't have net-devel in my mailbox),
> but based on Ingo's quoting have a more fundamental question:
>
> Why wasn't that done with C code instead of asm with odd numerical targets?
>
The reason I did this in ass
On Wed, Feb 3, 2016 at 1:30 PM, Simon Xiao wrote:
> 1. Adding NETIF_F_IPV6_CSUM and NETIF_F_TSO6 feature flags which are
> supported by Hyper-V platform.
NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are being deprecated. Please
change to use NETIF_F_HW_CSUM (calling helper functions if need).
Thanks,
T
On Tue, Feb 13, 2018 at 12:15 PM, Dmitry Vyukov wrote:
>
> On Thu, Jan 4, 2018 at 8:36 PM, Tom Herbert wrote:
> > On Thu, Jan 4, 2018 at 4:10 AM, syzbot
> > wrote:
> >> Hello,
> >>
> >> syzkaller hit the following crash on
> >> 6bb8824732f6
On Tue, Dec 5, 2017 at 6:35 AM, Sven Eckelmann
wrote:
> The batman-adv unicast packets contain a full layer 2 frame in encapsulated
> form. The flow dissector must therefore be able to parse the batman-adv
> unicast header to reach the layer 2+3 information.
>
> ++
> | ip(v
Did you try the patch I posted?
On Wed, Dec 27, 2017 at 10:25 AM, Dmitry Vyukov wrote:
> On Wed, Dec 6, 2017 at 4:44 PM, Dmitry Vyukov wrote:
>>> wrote:
On 10/24/2017 08:20 AM, syzbot wrote:
> Hello,
>
> syzkaller hit the following crash on
> 73d3393ada4f70fa3df5639c8d438
On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote:
>
>
> 27.12.2017, 23:14, "Dmitry Vyukov" :
>> On Wed, Dec 27, 2017 at 9:08 PM, Ozgur wrote:
>>> 27.12.2017, 22:21, "Dmitry Vyukov" :
>>>> On Wed, Dec 27, 2017 at 8:09 PM, Tom Herbert wrot
On Thu, Dec 28, 2017 at 12:59 AM, Ozgur wrote:
>
>
> 28.12.2017, 04:19, "Tom Herbert" :
>> On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote:
>>> 27.12.2017, 23:14, "Dmitry Vyukov" :
>>>> On Wed, Dec 27, 2017 at 9:08 PM, Ozgur wrote:
>
tptr_t)&bpf_insns,
> .license = (uintptr_t)"",
> };
>
> int main(void)
> {
> int bpf_fd = syscall(__NR_bpf, BPF_PROG_LOAD,
> &bpf_attr, sizeof(bpf_attr));
> int inet_fd = socket(AF_INET, S
On Wed, Sep 27, 2017 at 4:25 PM, Willem de Bruijn
wrote:
>>> In the future, both simple and sophisticated policy like RSS or other guest
>>> driven steering policies could be done on top.
>>
>> IMHO there should be a more practical example before adding all this
>> indirection. And it would be nic
static inline u32 ila_locator_hash(struct ila_locator loc)
> {
> u32 *v = (u32 *)loc.v32;
>
> + __ila_hash_secret_init();
> return jhash_2words(v[0], v[1], hashrnd);
> }
>
> --
> 2.9.0
>
Thanks Arnd!
Acked-by: Tom Herbert
On Wed, Dec 6, 2017 at 8:54 AM, Willem de Bruijn
wrote:
> On Wed, Dec 6, 2017 at 5:26 AM, Sven Eckelmann
> wrote:
>> On Dienstag, 5. Dezember 2017 09:19:45 CET Tom Herbert wrote:
>> [...]
>>> Switch statements with cases having many LOC is hard to read and
>>>
On Mon, Sep 12, 2016 at 7:55 AM, wrote:
> From: Kan Liang
>
> When the device tries to transmit a packet, netdev_pick_tx is called to
> find the available tx queues. If the net policy is applied, it picks up
> the assigned tx queue from net policy subsystem, and redirect the
> traffic to the ass
83 matches
Mail list logo
