[PATCH v8 0/2] OV5645 camera sensor driver

2017-04-03 Thread Todor Tomov
r setting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media: Add a driver for the ov5645 camera sensor. .../devicetree/bindings/media/i2c/ov5645.txt | 54 +

Re: [PATCH v8 1/2] media: i2c/ov5645: add the device tree binding document

2017-04-04 Thread Todor Tomov
Hi Sakari, Thank you for the time to review this again. On 04/04/2017 12:31 PM, Sakari Ailus wrote: > Hi Todor, > > On Mon, Apr 03, 2017 at 05:02:28PM +0300, Todor Tomov wrote: >> Add the document for ov5645 device tree binding. >> >> Signed-off-by: Todor Tomov >&

[PATCH v9 0/2] OV5645 camera sensor driver

2017-04-11 Thread Todor Tomov
- s_power is now not called on open/close; - using assigned-clock-rates in dt for setting camera external clock rate; - correct api for gpio handling; - return values checks; - style fixes. Todor Tomov (2): media: i2c/ov5645: add the device tree binding document media: Add a driver for the

[PATCH v9 1/2] media: i2c/ov5645: add the device tree binding document

2017-04-11 Thread Todor Tomov
Add the document for ov5645 device tree binding. Signed-off-by: Todor Tomov Reviewed-by: Laurent Pinchart Acked-by: Sakari Ailus Acked-by: Rob Herring --- .../devicetree/bindings/media/i2c/ov5645.txt | 54 ++ 1 file changed, 54 insertions(+) create mode 100644

[PATCH v9 2/2] media: Add a driver for the ov5645 camera sensor.

2017-04-11 Thread Todor Tomov
The ov5645 sensor from Omnivision supports up to 2592x1944 and CSI2 interface. The driver adds support for the following modes: - 1280x960 - 1920x1080 - 2592x1944 Output format is packed 8bit UYVY. Signed-off-by: Todor Tomov Reviewed-by: Laurent Pinchart Acked-by: Sakari Ailus --- drivers

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

2017-05-18 Thread Todor Tomov
Hi Laurent, On 01/19/2017 12:43 PM, Todor Tomov wrote: > Hi Laurent, > > Thank you for the detailed review. > > On 12/05/2016 05:22 PM, Laurent Pinchart wrote: >> Hi Todor, >> >> Thank you for the patch. >> >> On Friday 25 Nov 2016 16:57:20 Todor

Re: [PATCH v2 01/19] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

2017-06-29 Thread Todor Tomov
Thank you for review, Rob. On 06/23/2017 11:41 PM, Rob Herring wrote: > On Mon, Jun 19, 2017 at 05:48:21PM +0300, Todor Tomov wrote: >> Add DT binding document for Qualcomm Camera subsystem driver. > > "dt-bindings: media: ..." for the subject please. I'll

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-29 Thread Todor Tomov
Hi Sakari, On 06/29/2017 12:34 AM, Sakari Ailus wrote: > Hi Todor, > > It's been a while --- how do you do? > > Thanks for the patchset! Thank you for the review. I'll focus more on this now, so let's see :) > > On Mon, Jun 19, 2017 at 05:48:24PM +030

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-30 Thread Todor Tomov
Hi Sakari, On 06/30/2017 02:53 AM, Sakari Ailus wrote: > Hi Todor, > > On Thu, Jun 29, 2017 at 07:36:47PM +0300, Todor Tomov wrote: >>>> +/* >>>> + * csiphy_link_setup - Setup CSIPHY connections >>>> + * @entity: Pointer to media entity st

[PATCH 1/3] [media] ov5645: Set media entity function

2017-07-05 Thread Todor Tomov
Set media entity function to MEDIA_ENT_F_CAM_SENSOR. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index d1e844f..bb3dd0d 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers

[PATCH 3/3] [media] ov5645: Add control to export CSI2 link frequency

2017-07-05 Thread Todor Tomov
-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index 4583f66..85622e4 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/media/i2c/ov5645.c

[PATCH 2/3] [media] ov5645: Add control to export pixel clock frequency

2017-07-05 Thread Todor Tomov
Add suport for standard V4L2_CID_PIXEL_RATE control. The pixel clock frequency value is specific for each sensor mode so the sensor mode structure is extended to add this. The control is read-only and its value is updated when the sensor mode is changed - on set_format. Signed-off-by: Todor Tomov

Re: [PATCH v2 08/19] media: camss: Add files which handle the video device nodes

2017-07-06 Thread Todor Tomov
Hello Hans, Thank you for the time spent to review. On 07/03/2017 02:32 PM, Hans Verkuil wrote: > On 06/19/2017 04:48 PM, Todor Tomov wrote: >> These files handle the video device nodes of the camss driver. >> >> Signed-off-by: Todor Tomov >> --- >> drive

[PATCH] [media] v4l2-mediabus: Add helper functions

2017-07-07 Thread Todor Tomov
Add helper functions for mbus to/from mplane pixel format conversion. Signed-off-by: Todor Tomov --- include/media/v4l2-mediabus.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h index 34cc99e..f97fd4a

Re: [PATCH] [media] v4l2-mediabus: Add helper functions

2017-07-07 Thread Todor Tomov
On 07/07/2017 11:23 AM, Hans Verkuil wrote: > On 07/07/2017 10:18 AM, Todor Tomov wrote: >> Add helper functions for mbus to/from mplane pixel format conversion. >> >> Signed-off-by: Todor Tomov >> --- >> include/media/v4l2-mediabus.h | 26 +

[PATCH v2] [media] v4l2-mediabus: Add helper functions

2017-07-07 Thread Todor Tomov
Add helper functions for mbus to/from mplane pixel format conversion. Signed-off-by: Todor Tomov --- include/media/v4l2-mediabus.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h index 34cc99e..125afcd

[PATCH v3 02/23] [media] v4l2-mediabus: Add helper functions

2017-07-17 Thread Todor Tomov
Add helper functions for mbus to/from mplane pixel format conversion. Signed-off-by: Todor Tomov --- include/media/v4l2-mediabus.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h index 34cc99e..125afcd

[PATCH v3 12/23] media: camms: Add core files

2017-07-17 Thread Todor Tomov
These files implement the platform driver code. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss.c | 705 + drivers/media/platform/qcom/camss-8x16/camss.h | 97 2 files changed, 802 insertions(+) create mode 100644 drivers/media/platform

[PATCH v3 15/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - PIX Interface

2017-07-17 Thread Todor Tomov
Update Qualcomm Camera Subsystem driver document for the PIX interface and format conversion support. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 41 +++--- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/Documentation

[PATCH v3 13/23] media: camss: Enable building

2017-07-17 Thread Todor Tomov
Add Makefile and update platform/Kconfig and platform/Makefile to enable building of the QCom CAMSS driver. Signed-off-by: Todor Tomov --- drivers/media/platform/Kconfig | 7 +++ drivers/media/platform/Makefile | 2 ++ drivers/media/platform/qcom/camss

[PATCH v3 19/23] camss: vfe: Add interface for cropping

2017-07-17 Thread Todor Tomov
Extend selection ioctls to handle cropping configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 191 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 150 insertions(+), 42 deletions(-) diff --git a

[PATCH v3 22/23] camss: Use optimal clock frequency rates

2017-07-17 Thread Todor Tomov
the CSID test generator usage. If VFE is already powered on by another pipeline, check that the current VFE clock rate is high enough for the new pipeline. If not return busy error code as VFE clock rate cannot be changed while VFE is running. Signed-off-by: Todor Tomov --- .../media/platform

[PATCH v3 20/23] camss: vfe: Configure crop module in VFE

2017-07-17 Thread Todor Tomov
Add crop module configuration support to be able to apply cropping. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 41 +- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c b

[PATCH v3 21/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Scale and crop

2017-07-17 Thread Todor Tomov
Update the Qualcomm Camera Subsystem driver document for VFE scale and crop modules support. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/media/v4l-drivers

[PATCH v3 23/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Media graph

2017-07-17 Thread Todor Tomov
Update the Qualcomm Camera Subsystem driver document with a media controller pipeline graph diagram. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 27 ++ .../media/v4l-drivers/qcom_camss_graph.dot | 41 ++ 2 files

[PATCH v3 17/23] camss: vfe: Add interface for scaling

2017-07-17 Thread Todor Tomov
Add compose selection ioctls to handle scaling configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 189 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 188 insertions(+), 2 deletions(-) diff --git

[PATCH v3 16/23] camss: vfe: Support for frame padding

2017-07-17 Thread Todor Tomov
Add support for horizontal and vertical frame padding. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 86 +- .../media/platform/qcom/camss-8x16/camss-video.c | 69 - .../media/platform/qcom/camss-8x16/camss-video.h

[PATCH v3 18/23] camss: vfe: Configure scaler module in VFE

2017-07-17 Thread Todor Tomov
Add scaler module configuration support to be able to apply scaling. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 59 +- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c

[PATCH v3 11/23] media: camss: Add files which handle the video device nodes

2017-07-17 Thread Todor Tomov
These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-video.c | 627 + .../media/platform/qcom/camss-8x16/camss-video.h | 66 +++ 2 files changed, 693 insertions(+) create mode 100644

[PATCH v3 10/23] media: camss: Add VFE files

2017-07-17 Thread Todor Tomov
memory. RDI interfaces are supported in this version. PIX interface is not supported. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 1913 drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 114 ++ 2 files changed, 2027 insertions

[PATCH v3 14/23] camss: vfe: Format conversion support using PIX interface

2017-07-17 Thread Todor Tomov
Use VFE PIX input interface and do format conversion in VFE. Supported input format is UYVY (single plane YUV 4:2:2) and its different sample order variations. Supported output formats are: - NV12/NV21 (two plane YUV 4:2:0) - NV16/NV61 (two plane YUV 4:2:2) Signed-off-by: Todor Tomov

[PATCH v3 08/23] media: camss: Add CSID files

2017-07-17 Thread Todor Tomov
These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csid.c| 1073 .../media/platform/qcom/camss-8x16/camss-csid.h| 82 ++ 2 files

[PATCH v3 09/23] media: camss: Add ISPIF files

2017-07-17 Thread Todor Tomov
These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-ispif.c | 1127 .../media/platform/qcom/camss-8x16/camss-ispif.h | 85

[PATCH v3 06/23] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-07-17 Thread Todor Tomov
Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 124 + 1 file changed, 124 insertions(+) create mode 100644 Documentation/media/v4l-drivers/qcom_camss.rst diff --git a

[PATCH v3 07/23] media: camss: Add CSIPHY files

2017-07-17 Thread Todor Tomov
These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csiphy.c | 816 + .../media/platform/qcom/camss-8x16/camss-csiphy.h | 77 ++ 2 files changed

[PATCH v3 01/23] [media] media: Make parameter of media_entity_remote_pad() const

2017-07-17 Thread Todor Tomov
The local pad parameter in media_entity_remote_pad() is not modified. Make that explicit by adding a const modifier. Signed-off-by: Todor Tomov Acked-by: Sakari Ailus --- drivers/media/media-entity.c | 2 +- include/media/media-entity.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH v3 05/23] MAINTAINERS: Add Qualcomm Camera subsystem driver

2017-07-17 Thread Todor Tomov
Add an entry for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5a9f0f6..4cb978a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10887,6 +10887,14 @@ T: git git

[PATCH v3 03/23] v4l: Add packed Bayer raw12 pixel formats

2017-07-17 Thread Todor Tomov
From: Sakari Ailus These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit variants. The formats added by this patch are V4L2_PIX_FMT_SBGGR12P V4L2_PIX_FMT_SGBRG12P V4L2_PIX_FMT_SGRBG12P V4L2_PIX_FMT_SRGGB

[PATCH v3 04/23] dt-bindings: media: Binding document for Qualcomm Camera subsystem driver

2017-07-17 Thread Todor Tomov
Add DT binding document for Qualcomm Camera subsystem driver. CC: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov --- .../devicetree/bindings/media/qcom,camss.txt | 191 + 1 file changed, 191 insertions(+) create mode 100644 Documentation

[PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

2017-07-17 Thread Todor Tomov
test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 46, Succeeded: 46, Failed: 0, Warnings: 0 --- Sakari Ailus (1): v4l: Add packed Bayer raw12 pixel formats Todor Tomo

Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

2017-07-21 Thread Todor Tomov
Hello Hans, On 19.07.2017 13:54, Hans Verkuil wrote: > On 17/07/17 12:33, Todor Tomov wrote: >> This patchset adds basic support for the Qualcomm Camera Subsystem found >> on Qualcomm MSM8916 and APQ8016 processors. >> >> The driver implements V4L2, Media controller

Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

2017-07-21 Thread Todor Tomov
Hello Sakari, Thank you for the review! On 20.07.2017 18:25, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:26PM +0300, Todor Tomov wrote: >> This patchset adds basic support for the Qualcomm Camera Subsystem found >> on Qualcomm MSM8916 and APQ8016

Re: [PATCH v3 22/23] camss: Use optimal clock frequency rates

2017-07-21 Thread Todor Tomov
> https://github.com/0day-ci/linux/commits/Todor-Tomov/Qualcomm-8x16-Camera-Subsystem-driver/20170718-055348 > base: git://linuxtv.org/media_tree.git master > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: >

[PATCH 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-02-08 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov --- .../devicetree/bindings/media/i2c/ov7251.txt | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 Documentation

[PATCH 2/2] media: Add a driver for the ov7251 camera sensor

2018-02-08 Thread Todor Tomov
gain; - horizontal and vertical flip; - test pattern. Signed-off-by: Todor Tomov --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov7251.c | 1523 3 files changed, 1537 insertions(+) create mode 100644 dri

[PATCH 1/2] media: ov5645: Fix write_reg return code

2018-02-08 Thread Todor Tomov
I2C transfer functions return number of successful operations (on success). Do not return the received positive return code but instead return 0 on success. The users of write_reg function already use this logic. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 6 -- 1 file

[PATCH 2/2] media: ov5645: Improve mode finding function

2018-02-08 Thread Todor Tomov
river. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index 9755562..6d06c50 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/medi

Re: [PATCH 2/2] media: Add a driver for the ov7251 camera sensor

2018-02-19 Thread Todor Tomov
8, 2018 at 10:53:38AM +0200, Todor Tomov wrote: >> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMOS Digital Image >> Sensor from Omnivision. >> >> The driver supports the following modes: >> - 640x480 30fps >> - 640x480 60fps >> - 640x480

Re: [PATCH v2] [media] Use common error handling code in 20 functions

2018-02-20 Thread Todor Tomov
n = readl_relaxed(csid->base + CAMSS_CSID_HW_VERSION); > @@ -357,6 +352,11 @@ static int csid_set_power(struct v4l2_subdev *sd, int on) > ret = regulator_disable(csid->vdda); > } > > + goto exit; I think it will be cleaner if you remove the exit label and return here instead. > + > +disable_regulator: > + regulator_disable(csid->vdda); > +exit: > return ret; > } -- Best regards, Todor Tomov

Re: [PATCH][media-next] media: qcom: camss: Make function vfe_set_selection static

2017-08-29 Thread Todor Tomov
t declared. Should it be static? > > Signed-off-by: Colin Ian King Thank you! Acked-by: Todor Tomov > --- > drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-28 Thread Todor Tomov
Hi Daniel, On 25.08.2017 17:10, Daniel Mack wrote: > Hi Todor, > > Thanks a lot for working on the upstream support for this! > > On 08/08/2017 03:30 PM, Todor Tomov wrote: >> +The Camera Subsystem hardware found on 8x16 processors and supported by the >> +drive

Re: [PATCH v4 12/21] camss: vfe: Format conversion support using PIX interface

2017-09-10 Thread Todor Tomov
Hi Geert, On 10.09.2017 12:58, Geert Uytterhoeven wrote: > Hi Todor, > > On Tue, Aug 8, 2017 at 3:30 PM, Todor Tomov wrote: >> Use VFE PIX input interface and do format conversion in VFE. >> >> Supported input format is UYVY (single plane YUV 4:2:2) and >> its

Re: [PATCH] [media] ov5645: I2C address change (fwd)

2017-10-04 Thread Todor Tomov
ate: Wed, 4 Oct 2017 05:59:09 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia Lawall > Subject: Re: [PATCH] [media] ov5645: I2C address change > > CC: kbuild-...@01.org > In-Reply-To: <1506950925-13924-1-git-send-email-todor.to...@linaro.org>

[PATCH] [media] ov5645: I2C address change

2017-10-02 Thread Todor Tomov
As soon as the sensor is powered on, change the I2C address to the one specified in DT. This allows to use multiple physical sensors connected to the same I2C bus. Signed-off-by: Todor Tomov --- drivers/media/i2c/ov5645.c | 42 ++ 1 file changed, 42

[PATCH 0/4] Qualcomm Camera Control Interface driver

2017-10-02 Thread Todor Tomov
://source.codeaurora.org/quic/la/kernel/msm-3.18/ Todor Tomov (4): dt-bindings: media: Binding document for Qualcomm Camera Control Interface driver i2c: Add Qualcomm Camera Control Interface driver MAINTAINERS: Add Qualcomm Camera Control Interface driver arm64: dts: qcom: Add Camera

[PATCH 4/4] arm64: dts: qcom: Add Camera Control Interface support

2017-10-02 Thread Todor Tomov
This commit adds the CCI node for the CCI controller that resides on the Qualcomm MSM8916 and MSM8996 platforms. CC: Andy Gross CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org CC: linux-...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Todor Tomov

[PATCH 3/4] MAINTAINERS: Add Qualcomm Camera Control Interface driver

2017-10-02 Thread Todor Tomov
Add an entry for Qualcomm Camera Control Interface driver. Signed-off-by: Todor Tomov --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6671f37..aa3484f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11158,6 +11158,13 @@ W: http

[PATCH 1/4] dt-bindings: media: Binding document for Qualcomm Camera Control Interface driver

2017-10-02 Thread Todor Tomov
Add DT binding document for Qualcomm Camera Control Interface driver CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov --- .../devicetree/bindings/i2c/i2c-qcom-cci.txt | 55 ++ 1 file changed, 55 insertions(+) create mode

[PATCH 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-02 Thread Todor Tomov
bus. Signed-off-by: Todor Tomov --- drivers/i2c/busses/Kconfig| 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-qcom-cci.c | 793 ++ 3 files changed, 804 insertions(+) create mode 100644 drivers/i2c/busses/i2c-qcom-cci.c diff

Re: [PATCH 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-12 Thread Todor Tomov
Hi Bjorn, Thank you for the review. There are a lot of important suggestions. On 6.10.2017 08:20, Bjorn Andersson wrote: > On Mon 02 Oct 07:13 PDT 2017, Todor Tomov wrote: >> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c >> b/drivers/i2c/busses/i2c-qcom-cci.c > [..] >>

Re: [PATCH 1/4] dt-bindings: media: Binding document for Qualcomm Camera Control Interface driver

2017-10-12 Thread Todor Tomov
Hi Bjorn, Thank you for the review. On 6.10.2017 08:29, Bjorn Andersson wrote: > On Mon 02 Oct 07:13 PDT 2017, Todor Tomov wrote: >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt >> b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt >> new file

[PATCH v2 1/4] dt-bindings: media: Binding document for Qualcomm Camera Control Interface driver

2017-10-13 Thread Todor Tomov
Add DT binding document for Qualcomm Camera Control Interface driver CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov --- .../devicetree/bindings/i2c/i2c-qcom-cci.txt | 46 ++ 1 file changed, 46 insertions(+) create mode

[PATCH v2 0/4] Qualcomm Camera Control Interface driver

2017-10-13 Thread Todor Tomov
cci_validate_queue(); - halt and reset CCI on timeout after run queue; - a fix for CCI reset after halt; - a lot of small code and style fixes. Todor Tomov (4): dt-bindings: media: Binding document for Qualcomm Camera

[PATCH v2 3/4] MAINTAINERS: Add Qualcomm Camera Control Interface driver

2017-10-13 Thread Todor Tomov
Add an entry for Qualcomm Camera Control Interface driver. Signed-off-by: Todor Tomov --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750..10d78cb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11171,6 +11171,13 @@ W: http

[PATCH v2 4/4] arm64: dts: qcom: Add Camera Control Interface support

2017-10-13 Thread Todor Tomov
This commit adds the CCI node for the CCI controller that resides on the Qualcomm MSM8916 and MSM8996 platforms. CC: Andy Gross CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org CC: linux-...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Todor Tomov

[PATCH v2 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-13 Thread Todor Tomov
bus. Signed-off-by: Todor Tomov --- drivers/i2c/busses/Kconfig| 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-qcom-cci.c | 789 ++ 3 files changed, 800 insertions(+) create mode 100644 drivers/i2c/busses/i2c-qcom-cci.c diff

Re: [PATCH] [media] ov5645: I2C address change

2017-10-09 Thread Todor Tomov
Hi Sakari, On 4.10.2017 13:47, Laurent Pinchart wrote: > CC'ing the I2C mainling list and the I2C maintainer. > > On Wednesday, 4 October 2017 13:30:08 EEST Sakari Ailus wrote: >> Hi Todor, >> >> On Mon, Oct 02, 2017 at 04:28:45PM +0300, Todor Tomov wrote: >

Re: [PATCH] [media] ov5645: I2C address change

2017-10-09 Thread Todor Tomov
Hi Laurent :) On 9.10.2017 15:52, Laurent Pinchart wrote: > Hello, > > On Monday, 9 October 2017 12:34:26 EEST Sakari Ailus wrote: >> On Mon, Oct 09, 2017 at 11:36:01AM +0300, Todor Tomov wrote: >>> On 4.10.2017 13:47, Laurent Pinchart wrote: >>>> CC&#

Re: Re: [RFC PATCH 0/4] PM / Domains: Add support for explicit control of PM domains

2017-10-09 Thread Todor Tomov
Hi, On 30.05.2017 06:41, Rajendra Nayak wrote: > [].. > I was proposing to have such a lower-layer by splitting the existing genpd framework so the drivers would have the option of calling the lower-level power control functions to look-up pm-domains and control them directly

Re: [PATCH v3 04/23] dt-bindings: media: Binding document for Qualcomm Camera subsystem driver

2017-08-04 Thread Todor Tomov
Hi Sakari, Thank you for the review. On 20.07.2017 13:13, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:30PM +0300, Todor Tomov wrote: >> Add DT binding document for Qualcomm Camera subsystem driver. >> >> CC: Rob Herring >> CC: devicet...

Re: [PATCH v3 10/23] media: camss: Add VFE files

2017-08-06 Thread Todor Tomov
Hi Sakari, On 4.08.2017 21:02, Sakari Ailus wrote: > Hi Todor, > > Todor Tomov wrote: >> Hi Sakari, >> >> Thank you for the review. >> >> On 20.07.2017 17:59, Sakari Ailus wrote: >>> Hi Todor, >>> >>> On Mon, Jul 17, 2017 at 01:

Re: [PATCH v3 10/23] media: camss: Add VFE files

2017-07-25 Thread Todor Tomov
Hi Sakari, Thank you for the review. On 20.07.2017 17:59, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:36PM +0300, Todor Tomov wrote: >> These files control the VFE module. The VFE has different input interfaces. >> The PIX input interface feeds the i

Re: [PATCH v3 17/23] camss: vfe: Add interface for scaling

2017-07-25 Thread Todor Tomov
Hi Sakari, Thank you for review. On 20.07.2017 18:20, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jul 17, 2017 at 01:33:43PM +0300, Todor Tomov wrote: >> Add compose selection ioctls to handle scaling configuration. >> >> Signed-off-by: Todor Tomov >> --- >

[PATCH v4 21/21] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Media graph

2017-08-08 Thread Todor Tomov
Update the Qualcomm Camera Subsystem driver document with a media controller pipeline graph diagram. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 27 ++ .../media/v4l-drivers/qcom_camss_graph.dot | 41 ++ 2 files

[PATCH v4 20/21] camss: Use optimal clock frequency rates

2017-08-08 Thread Todor Tomov
the CSID test generator usage. If VFE is already powered on by another pipeline, check that the current VFE clock rate is high enough for the new pipeline. If not return busy error code as VFE clock rate cannot be changed while VFE is running. Signed-off-by: Todor Tomov --- .../media/platform

[PATCH v4 02/21] dt-bindings: media: Binding document for Qualcomm Camera subsystem driver

2017-08-08 Thread Todor Tomov
Add DT binding document for Qualcomm Camera subsystem driver. CC: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Acked-by: Rob Herring --- .../devicetree/bindings/media/qcom,camss.txt | 197 + 1 file changed, 197 insertions(+) create mode

[PATCH v4 18/21] camss: vfe: Configure crop module in VFE

2017-08-08 Thread Todor Tomov
Add crop module configuration support to be able to apply cropping. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 41 +- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c b

[PATCH v4 19/21] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Scale and crop

2017-08-08 Thread Todor Tomov
Update the Qualcomm Camera Subsystem driver document for VFE scale and crop modules support. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/media/v4l-drivers

[PATCH v4 16/21] camss: vfe: Configure scaler module in VFE

2017-08-08 Thread Todor Tomov
Add scaler module configuration support to be able to apply scaling. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 59 +- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c

[PATCH v4 17/21] camss: vfe: Add interface for cropping

2017-08-08 Thread Todor Tomov
Extend selection ioctls to handle cropping configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 191 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 150 insertions(+), 42 deletions(-) diff --git a

[PATCH v4 14/21] camss: vfe: Support for frame padding

2017-08-08 Thread Todor Tomov
Add support for horizontal and vertical frame padding. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 85 +- .../media/platform/qcom/camss-8x16/camss-video.c | 53 ++ .../media/platform/qcom/camss-8x16/camss-video.h | 2

[PATCH v4 15/21] camss: vfe: Add interface for scaling

2017-08-08 Thread Todor Tomov
Add compose selection ioctls to handle scaling configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 184 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 183 insertions(+), 2 deletions(-) diff --git

[PATCH v4 01/21] v4l: Add packed Bayer raw12 pixel formats

2017-08-08 Thread Todor Tomov
From: Sakari Ailus These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit variants. The formats added by this patch are V4L2_PIX_FMT_SBGGR12P V4L2_PIX_FMT_SGBRG12P V4L2_PIX_FMT_SGRBG12P V4L2_PIX_FMT_SRGGB

[PATCH v4 11/21] media: camss: Enable building

2017-08-08 Thread Todor Tomov
Add Makefile and update platform/Kconfig and platform/Makefile to enable building of the QCom CAMSS driver. Signed-off-by: Todor Tomov --- drivers/media/platform/Kconfig | 7 +++ drivers/media/platform/Makefile | 2 ++ drivers/media/platform/qcom/camss

[PATCH v4 13/21] doc: media/v4l-drivers: Qualcomm Camera Subsystem - PIX Interface

2017-08-08 Thread Todor Tomov
Update Qualcomm Camera Subsystem driver document for the PIX interface and format conversion support. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/Documentation

[PATCH v4 12/21] camss: vfe: Format conversion support using PIX interface

2017-08-08 Thread Todor Tomov
Use VFE PIX input interface and do format conversion in VFE. Supported input format is UYVY (single plane YUV 4:2:2) and its different sample order variations. Supported output formats are: - NV12/NV21 (two plane YUV 4:2:0) - NV16/NV61 (two plane YUV 4:2:2) Signed-off-by: Todor Tomov

[PATCH v4 09/21] media: camss: Add files which handle the video device nodes

2017-08-08 Thread Todor Tomov
These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-video.c | 681 + .../media/platform/qcom/camss-8x16/camss-video.h | 64 ++ 2 files changed, 745 insertions(+) create mode 100644

[PATCH v4 10/21] media: camms: Add core files

2017-08-08 Thread Todor Tomov
These files implement the platform driver code. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss.c | 699 + drivers/media/platform/qcom/camss-8x16/camss.h | 97 2 files changed, 796 insertions(+) create mode 100644 drivers/media/platform

[PATCH v4 08/21] media: camss: Add VFE files

2017-08-08 Thread Todor Tomov
memory. RDI interfaces are supported in this version. PIX interface is not supported. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 1906 drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 114 ++ 2 files changed, 2020 insertions

[PATCH v4 03/21] MAINTAINERS: Add Qualcomm Camera subsystem driver

2017-08-08 Thread Todor Tomov
Add an entry for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bdde944..87d0c7f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10996,6 +10996,14 @@ W: http

[PATCH v4 06/21] media: camss: Add CSID files

2017-08-08 Thread Todor Tomov
These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csid.c| 1003 .../media/platform/qcom/camss-8x16/camss-csid.h| 82 ++ 2 files

[PATCH v4 05/21] media: camss: Add CSIPHY files

2017-08-08 Thread Todor Tomov
These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csiphy.c | 823 + .../media/platform/qcom/camss-8x16/camss-csiphy.h | 77 ++ 2 files changed

[PATCH v4 07/21] media: camss: Add ISPIF files

2017-08-08 Thread Todor Tomov
These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-ispif.c | 1164 .../media/platform/qcom/camss-8x16/camss-ispif.h | 85

[PATCH v4 00/21] Qualcomm 8x16 Camera Subsystem driver

2017-08-08 Thread Todor Tomov
test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 46, Succeeded: 46, Failed: 0, Warnings: 0 --- Sakari Ailus (1): v4l: Add packed Bayer raw12 pixel formats Todor Tomo

[PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-08-08 Thread Todor Tomov
Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 124 + 1 file changed, 124 insertions(+) create mode 100644 Documentation/media/v4l-drivers/qcom_camss.rst diff --git a

Re: [PATCH v2 09/19] media: camms: Add core files

2017-07-03 Thread Todor Tomov
Hi Sakari, Thank you for the review. On 06/29/2017 09:33 AM, Sakari Ailus wrote: > Hi Todor, > > On Mon, Jun 19, 2017 at 05:48:29PM +0300, Todor Tomov wrote: >> These files implement the platform driver code. >> >> Signed-off-by: Todor Tomov >> --- >>

Re: [PATCH v2 05/19] media: camss: Add CSID files

2017-07-03 Thread Todor Tomov
Hello Hans, Thank you for the review. On 07/03/2017 01:49 PM, Hans Verkuil wrote: > On 06/19/2017 04:48 PM, Todor Tomov wrote: >> These files control the CSID modules which handle the protocol and >> application >> layer of the CSI2 receivers. >> &g

Re: [PATCH v2 09/19] media: camms: Add core files

2017-07-03 Thread Todor Tomov
Hello Hans, Thank you for the review. On 07/03/2017 02:24 PM, Hans Verkuil wrote: > On 06/19/2017 04:48 PM, Todor Tomov wrote: >> These files implement the platform driver code. >> >> Signed-off-by: Todor Tomov >> --- >> drivers/media/platf

Re: [PATCH 01/10] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

2017-06-19 Thread Todor Tomov
Hi Rob, On 01/09/2017 04:33 PM, Todor Tomov wrote: > Hi Rob, > > Happy new year, > And thank you for the review. > > On 12/01/2016 12:03 AM, Rob Herring wrote: >> On Fri, Nov 25, 2016 at 04:56:53PM +0200, Todor Tomov wrote: >>> Add DT binding document for

[PATCH v2 14/19] camss: vfe: Add interface for scaling

2017-06-19 Thread Todor Tomov
Add compose selection ioctls to handle scaling configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/vfe.c | 189 ++- drivers/media/platform/qcom/camss-8x16/vfe.h | 1 + 2 files changed, 188 insertions(+), 2 deletions(-) diff --git a

<    1   2   3   >