This patch set fixes various whitespace checkpatch errors and warnings.
Tobin C. Harding (4):
net: Fix checkpatch WARNING: please, no space before tabs
net: Fix checkpatch whitespace errors
net: Fix checkpatch block comments warnings
net: Fix checkpatch, Missing a blank line after
On Tue, May 21, 2019 at 02:05:38AM +, Roman Gushchin wrote:
> On Tue, May 21, 2019 at 11:31:18AM +1000, Tobin C. Harding wrote:
> > On Tue, May 21, 2019 at 12:57:47AM +, Roman Gushchin wrote:
> > > On Mon, May 20, 2019 at 03:40:17PM +1000, Tobin C. Harding wrote:
> &
On Wed, May 15, 2019 at 12:55:55PM +0200, Greg Kroah-Hartman wrote:
> From: "Tobin C. Harding"
>
> [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ]
Greg you are not going to back port all of these kobject fixes are you?
There is going to be a _lot_ of t
principle of
least surprise.
Check return value of kobject_add_internal() and free previously
allocated memory on failure.
Signed-off-by: Tobin C. Harding
---
Hi Greg,
Pretty excited by this one, if this is correct it means that kobject
initialisation code, in the error path, can now use either
On Thu, May 16, 2019 at 08:40:29AM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 16, 2019 at 10:07:16AM +1000, Tobin C. Harding wrote:
> > Currently kobject_add_varg() calls kobject_set_name_vargs() then returns
> > the return value of kobject_add_internal(). kobject
On Wed, May 29, 2019 at 04:16:51PM +, Roman Gushchin wrote:
> On Wed, May 29, 2019 at 01:54:06PM +1000, Tobin C. Harding wrote:
> > On Tue, May 21, 2019 at 02:05:38AM +, Roman Gushchin wrote:
> > > On Tue, May 21, 2019 at 11:31:18AM +1000, Tobin C. Harding wrote:
>
It is advantageous to have all defragmentable slabs together at the
beginning of the list of slabs so that there is no need to scan the
complete list. Put defragmentable caches first when adding a slab cache
and others last.
Signed-off-by: Tobin C. Harding
---
mm/slab_common.c | 2 +-
mm/slub.c
to the
recently added function:
void kmem_cache_setup_mobility(struct kmem_cache *,
kmem_cache_isolate_func,
kmem_cache_migrate_func);
Signed-off-by: Tobin C. Harding
---
Documentation/ABI/testing/sysfs-kernel-s
-C lists caches that use a ctor.
-M lists caches that support object migration.
Add command line options to show caches with a constructor and caches
that are movable (i.e. have migrate function).
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 40
t verified that the migration works and does not appear to break
anything.
Patch #14 and #15 depend on
CONFIG_SLBU_DEBUG_ON or boot with 'slub_debug'
Thanks for taking the time to look at this.
Tobin
Tobin C. Harding (15):
slub: Add isolate() and migrate() methods
Add output line for NUMA remote node defrag ratio.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index cbfc56c44c2f..d2c22f9ee2d8 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm
ng with 'isolate' and 'migrate'
callbacks.
Signed-off-by: Tobin C. Harding
---
include/linux/slab.h | 70
include/linux/slub_def.h | 3 ++
mm/slub.c| 59 +
3 files changed, 126 i
Add output for the newly added defrag_used_ratio sysfs knob.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index d2c22f9ee2d8..ef4ff93df4cc 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm
ling movable objects ...
verified movable slabs are shrinkable
Removing module slub_defrag ...
Signed-off-by: Tobin C. Harding
---
tools/testing/slab/slub_defrag.c | 1 +
tools/testing/slab/slub_defrag.py | 451 ++
2 files changed, 452 insertions(+)
create mode 10075
remaining partial slab.
Signed-off-by: Tobin C. Harding
---
tools/testing/slab/Makefile | 2 +-
tools/testing/slab/slub_defrag_xarray.c | 211
2 files changed, 212 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/slab/slub_defrag_xarray.c
di
Matthew Wilcox and was modified to work
with slab object migration.
Cc: Matthew Wilcox
Signed-off-by: Tobin C. Harding
---
lib/xarray.c | 61
1 file changed, 61 insertions(+)
diff --git a/lib/xarray.c b/lib/xarray.c
index 861c042daa1d
g : Off Lpadd: 352
We can run the stress tests (with the default number of objects):
# cd /sys/kernel/debug/smo
# echo 'test' > callfn
[3.576617] smo: test using nr_objs: 1000 keep: 10
[3.580169] smo: Module tests completed successfully
Signed-off-by: Tobin
Wilcox
Signed-off-by: Tobin C. Harding
---
include/linux/xarray.h | 3 +++
init/main.c| 2 ++
lib/radix-tree.c | 2 +-
lib/xarray.c | 48 ++
4 files changed, 45 insertions(+), 10 deletions(-)
diff --git a/include/linux/xarray.h
no reallocation is done.
In order to enable SMO a call to kmem_cache_setup_mobility() must be
made, we do this during initialization of the dcache.
Implement isolate and 'migrate' functions for the dentry slab cache.
Enable SMO for the dcache during initialization.
Signed-of
rs balance, no other value accepted.
This feature relies on SMO being enable for the cache, this is done with
a call to, after the isolate/migrate functions have been defined.
kmem_cache_setup_mobility(s, isolate, migrate)
Signed-off-by: Tobin C. Harding
---
mm/sl
In order to support object migration on the dentry cache we need to have
a determined object state at all times. Without a constructor the object
would have a random state after allocation.
Provide a dentry constructor.
Signed-off-by: Tobin C. Harding
---
fs/dcache.c | 30
"N1 N1" > move
Signed-off-by: Tobin C. Harding
---
mm/Kconfig | 7 ++
mm/slub.c | 247 +
2 files changed, 254 insertions(+)
diff --git a/mm/Kconfig b/mm/Kconfig
index f0c76ba47695..c1438b9e578b 100644
--- a/mm/Kconfig
++
From: "Tobin C. Harding"
Hi Christopher,
Here is a trivial patchset to wet my toes. This is my first patchset to
mm, if there are some mm specific nuances in relation to when in the dev
cycle (if ever) that minor (*cough* trivial) pathsets are acceptable
please say so
This patc
From: "Tobin C. Harding"
SLUB include file contains spelling mistake.
Fix up spelling mistake.
Signed-off-by: Tobin C. Harding
---
include/linux/slub_def.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/slub_def.h b/include/linux/slub_d
From: "Tobin C. Harding"
SLUB include file uses a c99 comment style. In line with the rest of
the kernel lets use c89 comment style.
Use C89 comment style.
Signed-off-by: Tobin C. Harding
---
include/linux/slub_def.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
From: "Tobin C. Harding"
SLUB include file has particularly clean comments, one comment string is
holding us back.
Capitialize comment string.
Signed-off-by: Tobin C. Harding
---
include/linux/slub_def.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/inc
On Thu, Jan 31, 2019 at 01:10:21AM -0700, William Kucharski wrote:
>
>
> > On Jan 30, 2019, at 9:10 PM, Tobin C. Harding wrote:
> >
> > Signed-off-by: Tobin C. Harding
> > ---
> > include/linux/slub_def.h | 2 +-
> > 1 file changed, 1 insertion(+), 1
On Thu, Jan 31, 2019 at 08:06:31AM +0200, Pekka Enberg wrote:
> On 31/01/2019 6.10, Tobin C. Harding wrote:
> > From: "Tobin C. Harding"
> >
> > Hi Christopher,
> >
> > Here is a trivial patchset to wet my toes. This is my first patchset to
>
are longer than the cache names on this
machine, in which case the columns would still be unaligned.
Increase the width of the first column (cache name) in the output of
/proc/slabinfo from 17 to 30 characters.
Signed-off-by: Tobin C. Harding
---
This patch does not touch the heading row, and
On Fri, Feb 01, 2019 at 11:42:42AM +1100, Tobin C. Harding wrote:
[snip]
This applies on top of Linus' tree
commit e74c98ca2d6a ('gfs2: Revert "Fix loop in gfs2_rbm_find"')
For this patch I doubt very much that it matters but for the record I
can't find men
On Thu, Jan 31, 2019 at 05:13:06PM -0800, Andrew Morton wrote:
> On Fri, 1 Feb 2019 11:58:38 +1100 "Tobin C. Harding" wrote:
>
> > On Fri, Feb 01, 2019 at 11:42:42AM +1100, Tobin C. Harding wrote:
> > [snip]
> >
> > This applies on top of Linus'
On Thu, Jan 31, 2019 at 06:43:10PM -0800, Matthew Wilcox wrote:
> On Fri, Feb 01, 2019 at 11:42:42AM +1100, Tobin C. Harding wrote:
> > Currently when displaying /proc/slabinfo if any cache names are too long
> > then the output columns are not aligned. We could do something fancy
On Tue, Jun 16, 2020 at 02:53:33PM +1000, Stephen Rothwell wrote:
> Hi,
>
> I have removed the leaks tree
> (https://git.kernel.org/pub/scm/linux/kernel/git/tobin/leaks.git#leaks-next)
> from linux-next because it has not been updated in more than a year.
> If you would like it reinstated, please j
On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote:
> This is a patch to the ks_wlan_net.c file that fixes up the following warning
> found by the checkpatch.pl tool:
> WARNING: Block comments use a trailing */ on a separate line
Good work resubmitting this following Greg's comments. M
On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote:
> Fix the style of block comments.
> Move trailing */ to a separate line.
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
You are doing well Ilia. A few nitpicks
- Your first subject was bett
On Wed, Apr 26, 2017 at 01:00:23PM +0200, Ilia Sergachev wrote:
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
>
> Move trailing */ to a separate line.
>
> Signed-off-by: Ilia Sergachev
Reviewed-by: Tobin C. Harding
>
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote:
> Hi,
>
> > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
> > a SDW-823 and should use the ks7010 driver.
>
> Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for
> which no driver is known:
On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote:
> + linux-wireless
>
> "Tobin C. Harding" writes:
>
> > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote:
> >>
> >> > The code is untested, I have hardware in the mail.
>
On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote:
> seems we are missing out again?
Sorry, I don't understand what this comment means?
> On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote:
> > "Tobin C. Harding" writes:
> >
> >> Except on
On Tue, Apr 04, 2017 at 11:31:14PM +0200, Arend Van Spriel wrote:
> >> On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote:
> >>> "Tobin C. Harding" writes:
> >>>
> >>>> Except one: do you know off the top of your head of a canonical
> &g
On Tue, Apr 11, 2017 at 03:15:32PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 11 Apr 2017 14:54:35 +0200
>
> The use of the logging function "dev_err" was introduced here on 2016-09-26.
>
> I find the following implementation details worth for another look.
> * Reduce ex
. Replace driver calls to the custom implementation with calls
to the newly defined helper functions.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/Makefile | 2 +-
drivers/staging/ks7010/ks_hostif.c | 48 +++-
drivers/staging/ks7010/ks_wlan.h | 3 +
drivers
uld really like to
hear them. I am open to all suggestions (even down to trivial coding
style issues).
Thank you for taking the time to read this and for any tips you may be
able to give me.
thanks,
Tobin.
Tobin C. Harding (1):
staging: ks7010: remove custom Michael MIC implementation
drive
On Thu, Mar 30, 2017 at 10:16:05PM -0700, Joe Perches wrote:
> On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote:
> > ks7010 currently uses a custom implementation of the Michael MIC
> > algorithm. The kernel has an implementation of this algorithm
> > already, we s
On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote:
>
> > The code is untested, I have hardware in the mail.
>
> Cool!
The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
a SDW-823 and should use the ks7010 driver. I am going to attempt to
get it running on a Raspber
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote:
> Hi,
>
> > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
> > a SDW-823 and should use the ks7010 driver.
>
> Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for
> which no driver is known:
On Wed, Apr 12, 2017 at 12:27:10PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 12, 2017 at 08:39:15AM +1000, Tobin C. Harding wrote:
> > On Tue, Apr 11, 2017 at 03:15:32PM +0200, SF Markus Elfring wrote:
> > > From: Markus Elfring
> > > Date: Tue, 11 Apr 2017 14:5
On Tue, May 23, 2017 at 06:37:39PM +0530, Richa Jha wrote:
> Replace CamelCase variable names with underscores and remove
> hungarian prefixes to comply with the standard kernel coding style
Hi Richa,
Nice work. You may like to do all the camel case at the same
time. You could limit yourself to
On Wed, May 24, 2017 at 04:40:32PM +1200, Derek Robson wrote:
> Fixed block comment alignment, Style fix only
> Found using checkpatch
It's 'one thing per patch', this whole set does one thing. You may
like to submit it as a single patch. You won't need the file name in
the commit summary then als
On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote:
[snip]
Nice work so far. I'm having trouble with your patches. Here are a few
nitpicks to help you on your way.
There are 4 emails in the last few days with similar subjects but they
are not linked together. Also your email subject does n
On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
This driver is not in Greg KH's staging tree. You may like to work off
of that tree when doing staging patches.
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
To aid you future patches here are a couple of minor
On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote:
> Signed-off-by: Aliza Minkov
> ---
> drivers/staging/dgnc/dgnc_driver.c | 2 --
> 1 file changed, 2 deletions(-)
Hi Aliza,
Well done getting your patch together. I think you might get an
automated message from Greg's patch robot so
unsubscribe
On Wed, Feb 07, 2018 at 10:26:16AM -0700, Jonathan Corbet wrote:
> So once upon a time I set out to fix the problem reported by Tobin wherein
> a literal block within a kerneldoc comment would be corrupted in
> processing. On the way, though, I got annoyed at the way I have to learn
> how kernel-d
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote:
> Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now
> actually fits on a single screen. Delete an unused variable and add a
> couple of comments while I'm at it.
>
> Signed-off-by: Jonathan Corbet
> ---
>
On Wed, Feb 07, 2018 at 10:26:24AM -0700, Jonathan Corbet wrote:
[snip]
>if (desperate)
>run_in_circles();
this is gold :)
On Wed, Feb 07, 2018 at 06:11:12PM -0800, Matthew Wilcox wrote:
>
> Kirill and I were talking about trying to overflow page->_mapcount
> the other day and realised that the default settings of pid_max and
> max_map_count prevent it [1]. But there isn't even documentation to
> warn a sysadmin that
; Add mailing list, kernel.org hosted tree, and second
maintainer.
Signed-off-by: Tobin C. Harding
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3bdc260e36b7..e91b5ff1f5d5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7905,8 +7905,11
Hi Stephen,
Would it be possible to get the development tree for
scripts/leaking_addresses.pl included in Linux-next please.
The tree is hosted on kernel.org
https://git.kernel.org/pub/scm/linux/kernel/git/tobin/leaks.git/
I have created a branch called linux-next. This branch is not tagged or
On Mon, Feb 26, 2018 at 07:54:22AM +1100, Stephen Rothwell wrote:
> Hi Tobin,
>
> On Sun, 25 Feb 2018 18:59:07 +1100 "Tobin C. Harding" wrote:
> >
> > Would it be possible to get the development tree for
> > scripts/leaking_addresses.pl included in Linux-nex
On Sun, Feb 25, 2018 at 06:35:53PM +1100, Tobin C. Harding wrote:
Please drop this, v2 coming with different (improved) subject line.
As may be apparent, I have no idea whose tree MAINTAINER changes go in
through?
thanks,
Tobin.
; Add mailing list, kernel.org hosted tree, and second
maintainer.
Signed-off-by: Tobin C. Harding
---
v1 subject line: [PATCH] MAINTAINERS: Add list, tree, and maintainer
v2
- Improve subject line to include section
- Re-order items to conform to standards (suggested by Joe Perches)
MAINTA
On Sun, Feb 25, 2018 at 06:26:31PM -0700, Tycho Andersen wrote:
> Hi Tobin,
>
> On Mon, Feb 19, 2018 at 01:50:47PM +1100, Tobin C. Harding wrote:
> > -# Do not parse these files under any subdirectory.
> > -my @skip_parse_files_any = ('0',
On Sun, Feb 25, 2018 at 06:09:53PM -0700, Tycho Andersen wrote:
> Hi Tobin,
>
> On Mon, Feb 19, 2018 at 01:50:49PM +1100, Tobin C. Harding wrote:
> > +sub already_scanned
> > +{
> > + my ($filename) = @_;
> > + state %seen;
> > +
> > + foreach (
On Thu, Feb 01, 2018 at 02:43:28PM -0800, Linus Torvalds wrote:
> On Thu, Feb 1, 2018 at 12:45 PM, Tobin C. Harding wrote:
> >
> > It has just come to my attention that I should have pushed these changes
> > to Linux next before requesting you to pull them. Please feel
On Fri, Feb 02, 2018 at 08:48:10PM +1100, Tobin C. Harding wrote:
> On Thu, Feb 01, 2018 at 02:43:28PM -0800, Linus Torvalds wrote:
> > On Thu, Feb 1, 2018 at 12:45 PM, Tobin C. Harding wrote:
> > >
> > > It has just come to my attention that I should have pushed these
On Mon, Feb 05, 2018 at 10:44:38AM +0100, Petr Mladek wrote:
> Hi,
>
> I add people who actively commented on adding %px modifier,
> see the thread starting at
> https://lkml.kernel.org/r/1511921105-3647-5-git-send-email...@tobin.cc
>
> Just for reference. It seems to be related to the commit 9f3
On Tue, Feb 06, 2018 at 05:57:17AM +1100, Kees Cook wrote:
> On Mon, Feb 5, 2018 at 8:44 PM, Petr Mladek wrote:
> > Hi,
> >
> > I add people who actively commented on adding %px modifier,
> > see the thread starting at
> > https://lkml.kernel.org/r/1511921105-3647-5-git-send-email...@tobin.cc
> >
On Mon, Feb 05, 2018 at 09:36:03AM -0800, Randy Dunlap wrote:
> On 02/05/2018 08:49 AM, Steven Rostedt wrote:
> > On Mon, 5 Feb 2018 16:22:19 +0100
> > Adam Borowski wrote:
> >
> >> My change touches %px only, where your concern doesn't apply.
> >>
> >> You're right, though, when it comes to %pK:
On Fri, Feb 16, 2018 at 11:07:03PM +0200, Andy Shevchenko wrote:
...
Hi Andy,
What tree does this set apply to please? I tried mainline rc1 and
next-20180216. Happy to see some code duplication removal from
vsprintf.c :)
thanks,
Tobin.
mainline but is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/tobin/leaks.git leaks-testing
thanks,
Tobin.
Tobin C. Harding (4):
leaking_addresses: do not parse binary files
leaking_addresses: simplify path skipping
leaking_addresses: cache architecture name
leaking_addresses
scanned directory tree. There are also currently multiple
subroutines to handle the different arrays, we can reduce these to a
single subroutine also.
Simplify the path skipping code.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 90
There are files under /proc that have the same format for each PID, e.g
'smaps'. We need only scan these files a single time to verify that
they are not leaking addresses. This reduces the work the script must
do.
Add once_only array.
Signed-off-by: Tobin C. Harding
--
in under a minute.
Cache machine architecture in state variable.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index e7bf15a45a69
Currently script parses binary files. Since we are scanning for
readable kernel addresses there is no need to parse binary files. We
can use Perl to check if file is binary and skip parsing it if so.
Do not parse binary files.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl
On Tue, Feb 13, 2018 at 08:16:57AM +0100, Rasmus Villemoes wrote:
> On 13 February 2018 at 07:20, Shunyong Yang
> wrote:
>
> >
> > This patch replaces space with readable "=" when output needs padding.
> > Following is the output after applying the patch,
>
> > Suggested-by: Rasmus Villemoes
>
On Mon, Feb 26, 2018 at 10:28:43AM +1000, Andrew Cooks wrote:
> Family 16h Model 30h SMBus controller needs the same port selection fix
> as described and fixed in commit 0fe16195f891 ("i2c: piix4: Fix SMBus port
> selection for AMD Family 17h chips")
>
> commit 6befa3fde65f ("i2c: piix4: Support
On Mon, Feb 26, 2018 at 10:28:45AM +1000, Andrew Cooks wrote:
> Enable the i2c-piix4 SMBus controller driver to enumerate I2C slave
> devices using ACPI. It builds on the related I2C mux device work
> in commit 8eb5c87a92c0 ("i2c: add ACPI support for I2C mux ports")
>
> In the i2c-piix4 driver th
%px.
Have checkpatch emit a warning for usage of specifier %px.
Signed-off-by: Tobin C. Harding
Co-Developed-by: Joe Perches
Acked-by: Joe Perches
---
scripts/checkpatch.pl | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/scripts/checkpatch.pl b
Variables are declared and not used, we should remove them.
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 235a02f4f4e1..d505fa4ec20c 100755
--- a/scripts/checkpatch.pl
+++ b
checkpatch currently contains duplicate code. We can define a sub
routine and call that instead. This reduces code duplication and line
count.
Add subroutine get_stat_here()
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 52 ---
1
checkpatch currently contains duplicate code. We can define a sub
routine and call that instead. This reduces code duplication and line
count.
Add subroutine get_stat_real()
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 32
1 file changed, 16
add 'Acked-by' tag for Joe
- remove 'Suggested-by' tag for Andrew Morton
Tobin C. Harding (4):
checkpatch: add sub routine get_stat_real()
checkpatch: remove unused variable declarations
checkpatch: add sub routine get_stat_he
On Tue, Feb 27, 2018 at 01:24:19PM +1100, Tobin C. Harding wrote:
...
Please drop this set
Epic fail: did not test final patch series before submission.
Sorry for the noise,
Tobin.
Variables are declared and not used, we should remove them.
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 235a02f4f4e1..d505fa4ec20c 100755
--- a/scripts/checkpatch.pl
+++ b
checkpatch currently contains duplicate code. We can define a sub
routine and call that instead. This reduces code duplication and line
count.
Add subroutine get_stat_here()
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 52 ---
1
%px.
Have checkpatch emit a warning for usage of specifier %px.
Signed-off-by: Tobin C. Harding
Co-Developed-by: Joe Perches
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 48
1 file changed, 32 insertions(+), 16 deletions(-)
diff
ed variable' into it's own patch
v2:
- change new sub name stat_real() -> get_stat_real()
- add new sub get_stat_here()
- move the addition of new sub routines into separate patches
- add 'Acked-by' tag for Joe
- remove 'Suggested-by' tag for Andrew Morton
checkpatch currently contains duplicate code. We can define a sub
routine and call that instead. This reduces code duplication and line
count.
Add subroutine get_stat_real()
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 32
1 file changed, 16
Reported-by: Tycho Andersen
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index fb40e2828f43..ac84a164a528 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts
We have git now, we don't need a version number. This was originally
added because leaking_addresses.pl shamelessly (and mindlessly) copied
checkpatch.pl
Remove version number from script.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 2 --
1 file changed, 2 dele
/proc files that leak addresses but were not present during
a scan. For these two reasons we should exclude all PID directories
under /proc except '1/'
Exclude all /proc/PID except /proc/1.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 11 +++
1 file c
nux/kernel/git/tobin/leaks.git
thanks,
Tobin.
Tobin C. Harding (3):
leaking_addresses: skip all /proc/PID except /proc/1
leaking_addresses: skip '/proc/1/syscall'
leaking_addresses: remove version number
scripts/leaking_addresses.pl | 14 --
1 file changed,
On Mon, Feb 26, 2018 at 10:09:31PM -0700, Tycho Andersen wrote:
> Hi Tobin,
>
> On Tue, Feb 27, 2018 at 03:45:09PM +1100, Tobin C. Harding wrote:
> > When the system is idle it is likely that most files under /proc/PID
> > will be identical for various processes. Scanning
On Tue, Feb 27, 2018 at 09:15:03AM +0200, Alexander Kapshuk wrote:
> On Tue, Feb 27, 2018 at 6:45 AM, Tobin C. Harding wrote:
> > When the system is idle it is likely that most files under /proc/PID
> > will be identical for various processes. Scanning _all_ the PIDs und
On Fri, Dec 29, 2017 at 05:36:40PM +, Jonathan Cameron wrote:
> On Tue, 19 Dec 2017 17:17:50 +1100
> "Tobin C. Harding" wrote:
>
> > When building kernel documentation sphinx emits the following warning
> >
> > warning: No description found for param
On Tue, Dec 26, 2017 at 07:48:55AM +0530, Kaiwan N Billimoria wrote:
> The script attempts to detect the architecture it's running upon; as of now,
> we explicitly support x86_64, PPC64 and x86_32.
> If it's one of them, we proceed "normally". If we fail to detect the arch,
> we fallback to 64-bit
On Mon, Feb 05, 2018 at 09:58:17PM +0100, Adam Borowski wrote:
> On Tue, Feb 06, 2018 at 07:32:32AM +1100, Kees Cook wrote:
> > On Tue, Feb 6, 2018 at 7:15 AM, Tobin C. Harding wrote:
> > > On Tue, Feb 06, 2018 at 05:57:17AM +1100, Kees Cook wrote:
> > >> On Mon
espondence re kernel.org tree hosting.
On Tue, Nov 14, 2017 at 02:45:59PM -0800, Linus Torvalds wrote:
> On Tue, Nov 14, 2017 at 1:03 PM, Tobin C. Harding wrote:
> >
> > I did not sign the tag, it looks like you have not processed this yet.
> > Do you want me to re-do t
vious correspondence re kernel.org tree hosting.
On Tue, Nov 14, 2017 at 02:45:59PM -0800, Linus Torvalds wrote:
> On Tue, Nov 14, 2017 at 1:03 PM, Tobin C. Harding wrote:
> >
> > I did not sign the tag, it looks like you have not processed this yet.
> > Do you want me to re-do the pu
601 - 700 of 971 matches
Mail list logo
