[PATCH] mmc: core: Remove fixed voltage regulator logic

2014-07-22 Thread Tim Kryger
There is no need for regulator consumers to include special logic for fixed voltage regulators as they support regulator_set_voltage() just like their non-fixed regulator counterparts. Signed-off-by: Tim Kryger --- Since this eliminates logic that was concealing a bug in how the SDHCI driver

Re: [PATCH] regulator: Allow set voltage on fixed regulators

2014-04-22 Thread Tim Kryger
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown wrote: > On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: >> If a regulator consumer requests a voltage range that can be satisfied, >> the return value should indicate success even if that regulator has a >> fixed vol

Re: [PATCH] mmc: core: Try other signal levels during power up

2014-04-24 Thread Tim Kryger
On Thu, Apr 24, 2014 at 1:38 AM, Ulf Hansson wrote: > On 18 April 2014 20:58, Tim Kryger wrote: >> void mmc_power_up(struct mmc_host *host, u32 ocr) >> { >> + int err; >> + > > The variable err is not needed, since we don't plan on printing it

[PATCH v2] mmc: core: Try other signal levels during power up

2014-04-24 Thread Tim Kryger
but when that can't be set, 1.8v and 1.2v signalling also should be attempted. This is especially important when an external regulator with a limited range is used to supply VCCQ to an eMMC part. Signed-off-by: Tim Kryger --- Changes since v1: - Eliminated temporary err variable and added

Re: [PATCH 0/2] SDHCI should use more common MMC structs and functions

2014-04-24 Thread Tim Kryger
On Thu, Apr 24, 2014 at 1:34 AM, Ulf Hansson wrote: > On 18 April 2014 02:46, Tim Kryger wrote: >> This series updates SDHCI to use the common regulator infrastructure that mmc >> core provides. >> >> Tim Kryger (2): >> mmc: sdhci: Use supplies in common mmc

[PATCH] mmc: sdhci: Use mmc core regulator infrastucture

2014-04-24 Thread Tim Kryger
ltage ranges supported which ensures ocr_avail is set correctly while allowing the use of regulators that can't provide exactly 1.8v, 3.0v, or 3.3v. Signed-off-by: Tim Kryger --- This patch is the same as the following series only squashed together. https://lkml.org/lkml/2014/4/17/653 d

[RESEND PATCH] mmc: core: Remove fixed voltage regulator logic

2014-07-29 Thread Tim Kryger
There is no need for regulator consumers to include special logic for fixed voltage regulators as they support regulator_set_voltage() just like their non-fixed regulator counterparts. Signed-off-by: Tim Kryger --- Since this eliminates logic that was concealing a bug in how the SDHCI driver

[PATCH v6 RESEND 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-25 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

2014-04-25 Thread Tim Kryger
cient - Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm

[PATCH v6 RESEND 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-25 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v6 RESEND 1/5] Documentation: dt: Add Kona PWM binding

2014-04-25 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) c

[PATCH v6 RESEND 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-25 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v6 RESEND 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-25 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH RESEND] mmc: core: Improve support for deferred regulators

2014-04-25 Thread Tim Kryger
eturn value and may continue to use IS_ERR on the vmmc/vqmmc values to determine if those regulators are available. Furthermore, since all of these callers are capable of dealing with absent regulators, switch over to use the non-optional variety of the regulator get call. Signed-off-by: Tim K

Re: [PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

2014-04-28 Thread Tim Kryger
On Mon, Apr 28, 2014 at 4:07 AM, Thierry Reding wrote: > On Fri, Apr 25, 2014 at 11:31:10AM -0700, Tim Kryger wrote: >> This series introduces the driver for the Kona PWM controller found in >> Broadcom mobile SoCs like bcm281xx and updates the device tree and the >> defco

Re: [PATCH RESEND] mmc: core: Improve support for deferred regulators

2014-04-29 Thread Tim Kryger
On Fri, Apr 25, 2014 at 2:33 PM, Andrew Bresticker wrote: >> >> - if (IS_ERR(supply)) >> - return PTR_ERR(supply); >> + if (IS_ERR(mmc->supply.vmmc)) { >> + if (PTR_ERR(mmc->supply.vmmc) == -EPROBE_DEFER) >> + return -EPROBE_DEFER; >> +

Re: [PATCHv3 1/3] pwm: make the PWM_POLARITY flag in DTB optional

2014-04-08 Thread Tim Kryger
On Mon, Apr 7, 2014 at 10:02 PM, Lothar Waßmann wrote: > Thierry Reding wrote: >> No. You cannot emulate polarity inversion in software. >> > Why not? > > duty_ns = period_ns - duty_ns; Since I made the same mistake, I will pass along the pointer Thierry gave me. In include/linux/pwm.h the sec

Re: [rfc]pwm: add BCM2835 PWM driver

2014-04-08 Thread Tim Kryger
On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe wrote: > need some recommendation > the memory mapped io registers of the bcm2835 pwm hardware are spreaded > over the memory mapped io > gpio config 0x2024 - clk config 0x201010A0 - pwm configuration 0x2020C000 > to handle this, I've used the base a

Re: [rfc]pwm: add BCM2835 PWM driver

2014-04-09 Thread Tim Kryger
On Tue, Apr 8, 2014 at 6:27 PM, Stephen Warren wrote: > On 04/08/2014 05:02 PM, Tim Kryger wrote: >> On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe >> wrote: >>> need some recommendation >>> the memory mapped io registers of the bcm2835 pwm hardware are sprea

[RESEND PATCH v5 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-09 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[RESEND PATCH v5 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-09 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[RESEND PATCH v5 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-09 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[RESEND PATCH v5 1/5] Documentation: dt: Add Kona PWM binding

2014-04-09 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) c

[RESEND PATCH v5 0/5] Add Broadcom Kona PWM Support

2014-04-09 Thread Tim Kryger
//lkml.org/lkml/2014/2/14/451 Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx) ARM: dts: Enable the PWM for bcm28155 AP board ARM: bcm_defconfig: Enable PWM and Backlight .../de

[RESEND PATCH v5 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-09 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH] regulator: bcm590xx: Set n_voltages for linear reg

2014-04-10 Thread Tim Kryger
Fix the macro used to define linear range regulators to include the number of voltages. Signed-off-by: Tim Kryger --- drivers/regulator/bcm590xx-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c

[PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-10 Thread Tim Kryger
ed to relax the range checks but because it relied on setting capabilities as an intermediate step, ocr_avail could easily get a bit set that the host couldn't support. Signed-off-by: Tim Kryger --- drivers/mmc/host/sdhci.c | 107 +- 1 file c

[PATCH] gpio: bcm-kona: Add irq_set_wake method

2014-04-10 Thread Tim Kryger
If a consumer of a GPIO-based IRQ identifies itself as wanting to have the capability to wake up the system through that interrupt, update the flags to keep that interrupt enabled in suspend. Signed-off-by: Tim Kryger --- drivers/gpio/gpio-bcm-kona.c | 19 +++ 1 file changed

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-11 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > On 11 April 2014 01:31, Tim Kryger wrote: >> +static unsigned int sdhci_get_ocr_avail_from_vmmc(struct sdhci_host *host) >> +{ >> + unsigned int ocr_avail = 0; >> + struct regulator *vmmc = hos

[PATCH v5 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-03-26 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v5 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-03-26 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v5 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-03-26 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v5 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-26 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[PATCH v5 0/5] Add Broadcom Kona PWM Support

2014-03-26 Thread Tim Kryger
//lkml.org/lkml/2014/2/14/451 Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx) ARM: dts: Enable the PWM for bcm28155 AP board ARM: bcm_defconfig: Enable PWM and Backlight .../de

[PATCH v5 1/5] Documentation: dt: Add Kona PWM binding

2014-03-26 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) c

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-15 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > I have seen some patches around lately touching the code for handling > the regulators (vcc and vccq) in sdhci. Was it this patch you were thinking of or something else? http://www.spinics.net/lists/linux-mmc/msg25640.html > A few times I h

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Tim Kryger
On Mon, Apr 14, 2014 at 6:42 PM, Andrew Bresticker wrote: > If regulator_get_optional() returns EPROBE_DEFER, it indicates > that the regulator may show up later (e.g. the DT property is > present but the corresponding regulator may not have probed). > Instead of continuing without the regulator,

[PATCH] regulator: core: Return error in get optional stub

2014-04-17 Thread Tim Kryger
call regulator_is_supported_voltage. This improves efficiency as well as eliminates the possibility for a very subtle bug. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder --- This change was proposed here: https://lkml.org/lkml/2014/4/16/627 include/linux/regulator/consumer.h |4 ++-- 1

[PATCH] mmc: core: Improve support for deferred regulators

2014-04-17 Thread Tim Kryger
eturn value and may continue to use IS_ERR on the vmmc/vqmmc values to determine if those regulators are available. Furthermore, since all of these callers are capable of dealing with absent regulators, switch over to use the non-optional variety of the regulator get call. Signed-off-by: Tim K

[PATCH 2/2] mmc: sdhci: Use common mmc_regulator_get_supply

2014-04-17 Thread Tim Kryger
dress this by relaxing the range checks in the SDHCI driver but it set the capabilities as an intermediate step which meant ocr_avail could get bits set for unsupported voltages. Signed-off-by: Tim Kryger --- drivers/mmc/host/sdhci.c | 67 +- 1 file ch

[PATCH 0/2] SDHCI should use more common MMC structs and functions

2014-04-17 Thread Tim Kryger
This series updates SDHCI to use the common regulator infrastructure that mmc core provides. Tim Kryger (2): mmc: sdhci: Use supplies in common mmc_host struct mmc: sdhci: Use common mmc_regulator_get_supply drivers/mmc/host/sdhci.c | 96

[PATCH 1/2] mmc: sdhci: Use supplies in common mmc_host struct

2014-04-17 Thread Tim Kryger
Switch the common SDHCI code over to use mmc_host's regulator pointers and remove the ones in the sdhci_host structure. Signed-off-by: Tim Kryger --- drivers/mmc/host/sdhci.c | 71 - include/linux/mmc/sdhci.h |3 -- 2 files change

[PATCH v6 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-18 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v6 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-18 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v6 1/5] Documentation: dt: Add Kona PWM binding

2014-04-18 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) c

[PATCH v6 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-18 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v6 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-18 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[PATCH v6 0/5] Add Broadcom Kona PWM Support

2014-04-18 Thread Tim Kryger
cient - Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm

[PATCH] regulator: Allow set voltage on fixed regulators

2014-04-18 Thread Tim Kryger
with constraints that include a positive voltage. Signed-off-by: Tim Kryger --- drivers/regulator/of_regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index ea4f36f..a205d62 100644 --- a/drivers

[PATCH] mmc: core: Try other signal levels during power up

2014-04-18 Thread Tim Kryger
but when that can't be set, 1.8v and 1.2v signalling also should be attempted. This is especially important when an external regulator with a limited range is used to supply VCCQ to an eMMC part. Signed-off-by: Tim Kryger --- drivers/mmc/core/core.c | 10 +- 1 file changed, 9 inser

Re: [PATCH] regulator: Allow set voltage on fixed regulators

2014-04-18 Thread Tim Kryger
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown wrote: > On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: >> If a regulator consumer requests a voltage range that can be satisfied, >> the return value should indicate success even if that regulator has a >> fixed vol

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-18 Thread Tim Kryger
On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson wrote: > On 15 April 2014 19:09, Tim Kryger wrote: >> On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: >>> A few times I have suggested to switch to use the >>> mmc_regulator_get_supply() API to simplify and cons

[PATCH v2] mmc: core: Improve support for deferred regulators

2014-05-06 Thread Tim Kryger
callers check vmmc/vqmmc using IS_ERR and can deal with absent regulators, switch to devm_regulator_get_optional. This has the added benefit of allowing this function to behave correctly even in the !CONFIG_REGULATOR case such that the stub can be removed. Signed-off-by: Tim Kryger --- drivers

Re: [PATCH v2] mmc: core: Improve support for deferred regulators

2014-05-06 Thread Tim Kryger
On Tue, May 6, 2014 at 3:57 PM, Tim Kryger wrote: > Callers of mmc_regulator_get_supply could benefit from knowing if either > of the regulators are present but not yet available. Since callers do > not currently examine the return value, modify this function to return > zero or -EPR

Re: [PATCH] mmc: sdhci: Use mmc core regulator infrastucture

2014-05-06 Thread Tim Kryger
On Fri, Apr 25, 2014 at 1:15 AM, Ulf Hansson wrote: > On 25 April 2014 00:36, Tim Kryger wrote: >> Switch the common SDHCI code over to use mmc_host's regulator pointers >> and remove the ones in the sdhci_host structure. Additionally, use the >> common mmc_regulator_

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Tim Kryger
The probe method of this driver, on the other hand, performs several allocations and the error messages you intend to remove conveniently pinpoint which one failed. While the offsets in the trace could be used to derive the same information, I am skeptical that is enough to justify removing the messages. Thanks, Tim Kryger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Tim Kryger
On Mon, Jun 2, 2014 at 5:50 AM, Mark Brown wrote: > On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote: > >> The probe method of this driver, on the other hand, performs several >> allocations and the error messages you intend to remove conveniently >> pinpoint

[PATCH] mmc: sdhci: Improve external VDD regulator support

2014-06-25 Thread Tim Kryger
ff-by: Tim Kryger Tested-by: Sachin Kamat --- This change corrects a regression observed on Exynos platforms that was triggered by "mmc: sdhci: Use mmc core regulator infrastucture" https://www.mail-archive.com/linux-mmc@vger.kernel.org/msg27101.html drivers/mmc/host/sdhci.c | 16

[PATCH v2 1/5] Documentation: dt: Add Kona PWM binding

2014-02-04 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 24 ++ 1 file changed, 24 insertions(+) c

[PATCH v2 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-02-04 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v2 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-02-04 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v2 2/5] pwm: kona: Introduce Kona PWM controller support

2014-02-04 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-bcm-kona.c | 291

[PATCH v2 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-02-04 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi

[PATCH v2 0/5] Add Broadcom Kona PWM Support

2014-02-04 Thread Tim Kryger
spelling and punctuation mistakes - Added support for polarity - Made peripheral clock use more efficient - Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM

[PATCH v2] ARM: dts: Leave sdio1 as disabled on bcm28155-ap

2014-02-04 Thread Tim Kryger
The sdio1 interface pins are routed to an unpopulated daughter card connector on the bcm28155-ap board. Thus there is no need to mark this interface as enabled. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- Changes since v1: - Rebased on v3.14-rc1 arch/arm/boot/dts/bcm28155

[PATCH v2] clocksource: kona: Print warning rather than panic

2014-02-04 Thread Tim Kryger
Since there may be other clocksources available, this driver should not trigger a panic simply because it can not determine the frequency of an external clock. This change refactors the driver to allow a warning to be printed in this case instead. Signed-off-by: Tim Kryger Reviewed-by: Markus

[PATCH RESEND] mmc: sdhci-bcm-kona: Add basic use of clocks

2014-02-04 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter Reviewed-by: Christian Daudt --- This was dropped from "Update Kona drivers to use clocks" ser

Re: [PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround

2013-12-09 Thread Tim Kryger
p->membase + (UART_LCR << p->regshift)); Would you mind posting this for proper review so we can get the fix in? Thanks, Tim Kryger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351

2013-12-10 Thread Tim Kryger
On Mon, Dec 9, 2013 at 11:18 PM, Christian Daudt wrote: > Applied to armsoc/for-3.14/dt Could you wait till other maintainers provide their acks and then take the entire series into a branch that feeds into the arm-soc drivers-for-linus branch? Thanks, Tim Kryger -- To unsubscribe from t

Re: [PATCH] serial: 8250_dw: Fix LCR workaround regression

2013-12-11 Thread Tim Kryger
rce idle and rewrite the LCR register, causing delays and >> preventing any input from serial being received. >> >> This is fixed by masking out UART_LCR_SPAR before making the comparison. >> >> Signed-off-by: James Hogan >> Cc: Greg Kroah-Hartman >> Cc: Jiri Slaby

Re: [PATCH] serial: 8250_dw: Fix LCR workaround regression

2013-12-11 Thread Tim Kryger
On Wed, Dec 11, 2013 at 1:05 PM, James Hogan wrote: > On Wednesday 11 December 2013 13:00:33 Tim Kryger wrote: >> DT declared DW UARTs don't run autoconfig and don't see this issue as >> far as I know. > Thanks for the extra description. FYI, I was instantiating DW U

Re: [RESEND PATCH v2 2/6] ARM: dts: Specify clocks for UARTs on bcm11351

2013-10-21 Thread Tim Kryger
On Thu, Oct 17, 2013 at 6:56 AM, Mark Rutland wrote: > On Wed, Oct 16, 2013 at 10:47:06PM +0100, Tim Kryger wrote: >> Rather than declaring the frequency of the external clock, specify the >> label of the clock such that the driver may determine the frequency on >> its ow

Re: [RESEND PATCH v2 4/6] clocksource: kona: Add basic use of external clock

2013-10-21 Thread Tim Kryger
On Thu, Oct 17, 2013 at 7:05 AM, Mark Rutland wrote: > On Wed, Oct 16, 2013 at 10:47:08PM +0100, Tim Kryger wrote: >> When an clock handle is specified in the device tree, enable it and use >> it to determine the external clock frequency. > > I'd drop handle here and

Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-21 Thread Tim Kryger
On Thu, Oct 17, 2013 at 7:13 AM, Mark Rutland wrote: > On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: >> Enable the external clock needed by the host controller during the >> probe and disable it during the remove. > > This requires a biding document upda

[PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

2013-11-14 Thread Tim Kryger
The board schematic states that the "SD_CARD_DET_N gets pulled to GND when card is inserted" so the polarity has been updated to active low. Polarity is now specified with a GPIO define instead of a magic number. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- arch/ar

[PATCH v3 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-11-14 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/mmc/host/sdhci-bcm-kona.c | 28 +++- 1 file changed, 27 insertions(+), 1

[PATCH v3 8/8] ARM: dts: Specify clocks for timer on bcm11351

2013-11-14 Thread Tim Kryger
Specify the external clock label in the timer node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v3 0/8] Update Kona drivers to use clocks

2013-11-14 Thread Tim Kryger
change from SDHCI driver patch Changes in v2: - Renamed bsc4_clk to pmu_bsc_clk Tim Kryger (8): ARM: dts: Declare clocks as fixed on bcm11351 ARM: dts: Specify clocks for UARTs on bcm11351 Documentation: dt: kona-sdhci: Add clocks property ARM: dts: Specify clocks for SDHCIs on bcm11351 mmc

[PATCH v3 7/8] clocksource: kona: Add basic use of external clock

2013-11-14 Thread Tim Kryger
When an clock is specified in the device tree, enable it and use it to determine the external clock frequency. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/clocksource/bcm_kona_timer.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[PATCH v3 3/8] Documentation: dt: kona-sdhci: Add clocks property

2013-11-14 Thread Tim Kryger
The Kona SDHCI block requires a clock that must be specified in the device tree. Update the documentation to reflect this requirement. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- Documentation/devicetree/bindings/mmc/kona-sdhci.txt | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v3 4/8] ARM: dts: Specify clocks for SDHCIs on bcm11351

2013-11-14 Thread Tim Kryger
Specify the external clock label in each SDHCI node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi index

[PATCH v3 6/8] Documentation: dt: kona-timer: Add clocks property

2013-11-14 Thread Tim Kryger
The frequency for the Kona timer can either be specified through the device tree or determined by checking the rate of the clock specified in the device tree. Update the documentation to reflect both ways. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- Documentation/devicetree

[PATCH v3 2/8] ARM: dts: Specify clocks for UARTs on bcm11351

2013-11-14 Thread Tim Kryger
references to the relevant clocks following the common clock binding. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arc

[PATCH v3 1/8] ARM: dts: Declare clocks as fixed on bcm11351

2013-11-14 Thread Tim Kryger
Declare clocks that are enabled and configured by bootloaders as fixed rate clocks in the DTS such that device drivers may use standard clock function calls. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 97

[PATCH v2 1/5] Documentation: dt: Add i2c-bcm-kona binding

2013-11-14 Thread Tim Kryger
Add the binding description for the i2c-bcm-kona block found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- .../devicetree/bindings/i2c/i2c-bcm-kona.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Document

[PATCH v2 4/5] ARM: dts: bcm281xx: Add i2c busses

2013-11-14 Thread Tim Kryger
Add the DTS nodes for all the i2c busses in the SoC. Signed-off-by: Tim Kryger Reviewed-by: Christian Daudt Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi | 40 1 file changed, 40 insertions(+) diff --git a

[PATCH v2 5/5] ARM: dts: bcm28155-ap: Enable all the i2c busses

2013-11-14 Thread Tim Kryger
Enable all available i2c busses. Signed-off-by: Tim Kryger Reviewed-by: Christian Daudt Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch

[PATCH v2 0/5] Add-Broadcom-Kona-I2C-Support

2013-11-14 Thread Tim Kryger
This series adds support for the Kona I2C bus found on Broadcom mobile SoCs like the bcm11351 (aka bcm281xx) and enables it on the bcm28155-ap board. It depends upon the following commit: http://lkml.indiana.edu/hypermail/linux/kernel/1311.1/03583.html Tim Kryger (5): Documentation: dt: Add

[PATCH v2 2/5] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver

2013-11-14 Thread Tim Kryger
Introduce support for Broadcom Serial Controller (BSC) I2C bus found in the Kona family of Mobile SoCs. FIFO hardware is utilized but only standard mode (100kHz), fast mode (400kHz), and fast mode plus (1MHz) bus speeds are supported. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed

[PATCH v2 3/5] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-14 Thread Tim Kryger
Add support for I2C high-speed mode (3.4 MHz). Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- drivers/i2c/busses/i2c-bcm-kona.c | 115 +- 1 file changed, 114 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

Re: [PATCH v2 0/5] Add-Broadcom-Kona-I2C-Support

2013-11-15 Thread Tim Kryger
On Fri, Nov 15, 2013 at 2:52 PM, Wolfram Sang wrote: > Fixed Kconfig sorting, squashed broken out patches 1-3 into one and > applied to for-next, thanks! Let me know if I should take patches 4-5 > also, but usually they go via arm-soc. Also, please provide a "Changes > since V1" log which will sp

[PATCH 1/5] Documentation: dt: Add kona-pwm binding

2013-11-18 Thread Tim Kryger
Add the binding description for the kona-pwm block found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 24 ++ 1 file changed, 24 insertions(+) create

[PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-18 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-bcm-kona.c | 226

[PATCH 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2013-11-18 Thread Tim Kryger
Enable PWM drivers and the PWM-based baclight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH 0/5] Add Broadcom Kona PWM Support

2013-11-18 Thread Tim Kryger
This series introduces the driver for the Kona PWM controller found in Broadcom mobile SoCs like bcm281xx and updates the device tree and the defconfig to enable use of this hardware on the bcm28155 AP board. It depends on: https://lkml.org/lkml/2013/11/14/521 Tim Kryger (5): Documentation

[PATCH 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2013-11-18 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi

[PATCH 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2013-11-18 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

Re: [PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround

2013-12-04 Thread Tim Kryger
On Wed, Dec 4, 2013 at 5:01 AM, Ezequiel Garcia wrote: > On Thu, Nov 28, 2013 at 04:53:37PM -0300, Ezequiel Garcia wrote: >> On Thu, Nov 28, 2013 at 04:47:20PM -0300, Ezequiel Garcia wrote: >> > Changing the console port by setting "console=ttyS1,115200" gives this: >> > >> > [..] >> > Serial: 82

[PATCH v4 4/8] ARM: dts: Specify clocks for SDHCIs on bcm11351

2013-12-05 Thread Tim Kryger
Specify the external clock label in each SDHCI node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi index

[PATCH v4 7/8] clocksource: kona: Add basic use of external clock

2013-12-05 Thread Tim Kryger
When an clock is specified in the device tree, enable it and use it to determine the external clock frequency. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/clocksource/bcm_kona_timer.c | 14 +++--- 1 file changed, 11 insertions(+), 3

<    1   2   3   >