On Mon, Jun 2, 2014 at 5:50 AM, Mark Brown <broo...@kernel.org> wrote: > On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote: > >> The probe method of this driver, on the other hand, performs several >> allocations and the error messages you intend to remove conveniently >> pinpoint which one failed. While the offsets in the trace could be >> used to derive the same information, I am skeptical that is enough to >> justify removing the messages. > > On the other hand how likely is anyone to care which particular > allocation triggered the OOM?
I suppose you would only care if a failure was due to something unique about a specific allocation. For example, if someone made a foolish change to a structure that resulted in a request for substantially more memory, the messages would lead directly to the problem. The real question is whether this change improves the driver. To me, it seems like a draw. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
