Re: [PATCH] serial: 8250_dw: Improve unwritable LCR workaround

2013-10-01 Thread Tim Kryger
On Fri, Sep 27, 2013 at 12:49 AM, Heikki Krogerus wrote: > OK. The LCR issue is only a problem when the UART is configured with > the busy functionality (UART_16550_COMPATIBLE == NO). Otherwise LRC is > always accessible and this is not necessary. Reading through the latest DW databook, I believ

[PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround

2013-10-01 Thread Tim Kryger
3] serial8250: too much work for irq96 [ 27.73] serial8250: too much work for irq96 [ 27.74] serial8250: too much work for irq96 Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- Changes in v2: - Rebased on tty-next - Updated comm

[PATCH 0/6] Update Kona drivers to use clocks

2013-10-03 Thread Tim Kryger
://lkml.org/lkml/2013/9/18/409 https://lkml.org/lkml/2013/9/20/305 http://www.spinics.net/lists/arm-kernel/msg274973.html Tim Kryger (6): ARM: dts: Declare clocks as fixed on bcm11351 ARM: dts: Specify clocks for UARTs on bcm11351 ARM: dts: Specify clocks for SDHCIs on bcm11351 clocksource

[PATCH 1/6] ARM: dts: Declare clocks as fixed on bcm11351

2013-10-03 Thread Tim Kryger
Declare clocks that are enabled and configured by bootloaders as fixed rate clocks in the DTS such that device drivers may use standard clock function calls. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 97

[PATCH 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-03 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/mmc/host/sdhci-bcm-kona.c | 30 -- 1 file changed, 28 insertions

[PATCH 4/6] clocksource: kona: Add basic use of external clock

2013-10-03 Thread Tim Kryger
When an clock handle is specified in the device tree, enable it and use it to determine the external clock frequency. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/clocksource/bcm_kona_timer.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[PATCH 5/6] ARM: dts: Specify clocks for timer on bcm11351

2013-10-03 Thread Tim Kryger
Specify the external clock label in the timer node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH 2/6] ARM: dts: Specify clocks for UARTs on bcm11351

2013-10-03 Thread Tim Kryger
Rather than declaring the frequency of the external clock, specify the label of the clock such that the driver may determine the frequency on its own. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed

[PATCH 3/6] ARM: dts: Specify clocks for SDHCIs on bcm11351

2013-10-03 Thread Tim Kryger
Specify the external clock label in each SDHCI node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi index

[PATCH v2 1/6] ARM: dts: Declare clocks as fixed on bcm11351

2013-10-07 Thread Tim Kryger
Declare clocks that are enabled and configured by bootloaders as fixed rate clocks in the DTS such that device drivers may use standard clock function calls. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 97

[PATCH v2 5/6] ARM: dts: Specify clocks for timer on bcm11351

2013-10-07 Thread Tim Kryger
Specify the external clock label in the timer node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-07 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/mmc/host/sdhci-bcm-kona.c | 30 -- 1 file changed, 28 insertions

[PATCH v2 3/6] ARM: dts: Specify clocks for SDHCIs on bcm11351

2013-10-07 Thread Tim Kryger
Specify the external clock label in each SDHCI node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi index

[PATCH v2 0/6] Update Kona drivers to use clocks

2013-10-07 Thread Tim Kryger
://lkml.org/lkml/2013/9/18/409 https://lkml.org/lkml/2013/9/20/305 http://www.spinics.net/lists/arm-kernel/msg274973.html Changes in v2: - Renamed bsc4_clk to pmu_bsc_clk Tim Kryger (6): ARM: dts: Declare clocks as fixed on bcm11351 ARM: dts: Specify clocks for UARTs on bcm11351 ARM: dts

[PATCH v2 2/6] ARM: dts: Specify clocks for UARTs on bcm11351

2013-10-07 Thread Tim Kryger
Rather than declaring the frequency of the external clock, specify the label of the clock such that the driver may determine the frequency on its own. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed

[PATCH v2 4/6] clocksource: kona: Add basic use of external clock

2013-10-07 Thread Tim Kryger
When an clock handle is specified in the device tree, enable it and use it to determine the external clock frequency. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/clocksource/bcm_kona_timer.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[PATCH 1/4] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver

2013-10-07 Thread Tim Kryger
Introduce support for Broadcom Serial Controller (BSC) I2C bus found in the Kona family of Mobile SoCs. FIFO hardware is utilized but only standard mode (100kHz), fast mode (400kHz), and fast mode plus (1MHz) bus speeds are supported. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed

[PATCH 0/4] Add-Broadcom-Kona-I2C-Support

2013-10-07 Thread Tim Kryger
This series adds support for the Kona I2C bus found on Broadcom mobile SoCs like the bcm11351 (aka bcm281xx) and enables it on the bcm28155-ap board. It depends upon the following commits: https://lkml.org/lkml/2013/10/7/481 http://www.spinics.net/lists/arm-kernel/msg274964.html Tim Kryger

[PATCH 4/4] ARM: dts: bcm28155-ap: Enable all the i2c busses

2013-10-07 Thread Tim Kryger
Enable all available i2c busses. Signed-off-by: Tim Kryger Reviewed-by: Christian Daudt Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch

[PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-10-07 Thread Tim Kryger
Add support for I2C high-speed mode (3.4 MHz). Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- drivers/i2c/busses/i2c-bcm-kona.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b

[PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses

2013-10-07 Thread Tim Kryger
Add the DTS nodes for all the i2c busses in the SoC. Signed-off-by: Tim Kryger Reviewed-by: Christian Daudt Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi | 40 1 file changed, 40 insertions(+) diff --git a

[PATCH] serial: 8250_dw: Improve unwritable LCR workaround

2013-09-24 Thread Tim Kryger
oo much work for irq96 [ 27.72] serial8250: too much work for irq96 [ 27.72] serial8250: too much work for irq96 [ 27.73] serial8250: too much work for irq96 [ 27.73] serial8250: too much work for irq96 [ 27.74] serial8250: too much work for irq96 Signed-off-by: T

Re: [PATCH] serial: 8250_dw: Improve unwritable LCR workaround

2013-09-25 Thread Tim Kryger
On Wed, Sep 25, 2013 at 4:42 AM, Heikki Krogerus wrote: > Hi Tim, > > On Tue, Sep 24, 2013 at 05:39:09PM -0700, Tim Kryger wrote: >> The Designware UART has a limitation where it ignores writes into the >> LCR if the UART is busy. The current workaround stashes a copy of th

[PATCH] serial: 8250_dw: Report CTS asserted for auto flow

2013-08-16 Thread Tim Kryger
: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- drivers/tty/serial/8250/8250_dw.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 76a8daa

Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from BCM11351 BRT DTS file

2013-07-25 Thread Tim Kryger
On Mon, Jul 22, 2013 at 9:57 AM, Christian Daudt wrote: > it'd be nice to have something to point > people to as this being the best practice for kernel dev. Power.org's ePAPR exclusively omits the 0x in the unit-address of node names. https://www.power.org/wp-content/uploads/2012/06/Power_ePAP

Re: [PATCH v0 2/4] i2c: bcm-kona: Use complete() instead of complete_all()

2016-08-04 Thread Tim Kryger
ttern of the completion is: > > bcm_kona_send_i2c_cmd() > reinit_completion() > ... > bcm_kona_i2c_send_cmd_to_ctrl() > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner Reviewed-by: Tim Kryger > --- > drivers/i2c/busses/i2c-bcm-

Re: [PATCH 2/2] pwm: bcm-kona: apply pwm settings on enable

2018-11-08 Thread Tim Kryger
On Thu, Nov 8, 2018 at 2:59 AM Uwe Kleine-König wrote: > > Hello, > > adding Tim Kryger as the initial author of the bcm-kona driver to Cc:. > Maybe he can shed some light to the questions below? > > On Thu, Nov 08, 2018 at 11:47:17AM +0100, Clément Péron wrote: > >

Re: [PATCH v4 2/3] pwm: kona: Remove setting default smooth type and polarity for all channels

2015-01-04 Thread Tim Kryger
On Tue, Dec 30, 2014 at 2:43 PM, Jonathan Richardson wrote: > Setting the default polarity in probe to normal for all channels caused > the speaker pwm channel to click. The polarity does need to be set to > normal because the hw default is inversed whereas the pwm framework > defaults to normal.

[PATCH 0/2] Allow registration of default inversed polarity PWMs

2015-01-04 Thread Tim Kryger
This series alters the PWM core to allow the registration of controllers that begin with inversed polarity output. It also modifies the Broadcom Kona driver to take advantage of this new call. Arun Ramamurthy (1): drivers: pwm: bcm-kona: Dont set polarity in probe Tim Kryger (1): drivers

[PATCH 1/2] drivers: pwm: core: Add pwmchip_add_inversed

2015-01-04 Thread Tim Kryger
Add a new function to register a PWM chip with channels that have their initial polarity as inversed. This benefits drivers of controllers that by default operate with inversed polarity by removing the need to modify the polarity during initialization. Signed-off-by: Tim Kryger --- drivers/pwm

[PATCH 2/2] drivers: pwm: bcm-kona: Dont set polarity in probe

2015-01-04 Thread Tim Kryger
Signed-off-by: Scott Branden Signed-off-by: Tim Kryger --- This is based on Arun's patch (originally posted by Scott) https://lkml.org/lkml/2014/11/25/1019 I modified it to use the pwmchip_add_inversed function so the polarity could be safely left at the power on default and updated the c

Re: [PATCH v4 2/3] pwm: kona: Remove setting default smooth type and polarity for all channels

2015-01-04 Thread Tim Kryger
On Sun, Jan 4, 2015 at 5:12 PM, Tim Kryger wrote: > On Tue, Dec 30, 2014 at 2:43 PM, Jonathan Richardson > wrote: >> Setting the default polarity in probe to normal for all channels caused >> the speaker pwm channel to click. The polarity does need to be set to >> norma

Re: [PATCH 2/4] clk: iproc: add initial common clock support

2014-12-06 Thread Tim Kryger
On Thu, Dec 4, 2014 at 1:43 PM, Ray Jui wrote: > This adds basic and generic support for various iProc PLLs and clocks > including the ARMPLL, GENPLL, LCPLL, MIPIPLL, and ASIU clocks. > > SoCs under the iProc architecture can define their specific register > offsets and clock parameters for their

Re: [PATCH v2 1/4] pwm: kona: Remove setting default smooth type and polarity for all channels

2014-12-06 Thread Tim Kryger
riod) but > may get a non smooth transition. So it's important to follow the spec > here. We don't want non-smooth transitions. Please provide your rationale for requiring smooth transitions. Thanks, Tim Kryger -- To unsubscribe from this list: send the line "unsubscribe lin

Re: Possible regression with commit 52221610d

2015-01-13 Thread Tim Kryger
On Mon, Jan 5, 2015 at 11:52 AM, Bjorn Andersson wrote: > On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: >> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > [..] >>> Non-the-less, feel free to propose a patch and I will give it a test. >> >> Le

Re: Possible regression with commit 52221610d

2015-01-13 Thread Tim Kryger
On Mon, Jan 12, 2015 at 2:31 AM, Ulf Hansson wrote: > On 5 January 2015 at 20:52, Bjorn Andersson wrote: >> On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: >>> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: >> [..] >>>> Non-the-less, feel free t

Re: Possible regression with commit 52221610d

2015-01-13 Thread Tim Kryger
On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger wrote: > On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson wrote: > >> I'm somewhat puzzled to what benefit 52221610d brings after bringing >> back the write of BIT(0). Is it just that we don't hit the BUG() on >> n

[PATCH] mmc: sdhci: Set SDHCI_POWER_ON with external vmmc

2015-01-13 Thread Tim Kryger
Nvidia boards caused by 5222161 mmc: sdhci: Improve external VDD regulator support. Signed-off-by: Tim Kryger Tested-by: Bjorn Andersson --- drivers/mmc/host/sdhci.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ada1a3e..59a328a

Re: [PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed

2015-06-14 Thread Tim Kryger
On Fri, Jun 12, 2015 at 2:45 AM, Thierry Reding wrote: > On Tue, May 26, 2015 at 01:08:16PM -0700, Jonathan Richardson wrote: >> From: Tim Kryger >> >> Add a new function to register a PWM chip with channels that have their >> initial polarity as inversed. This bene

Re: [PATCH v8 3/5] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-30 Thread Tim Kryger
r 400ns. This corrects an issue where occasionally a requested change was not properly reflected in the PWM output. Otherwise, this patch looks reasonable so Reviewed-by: Tim Kryger > > Reviewed-by: Arun Ramamurthy > Reviewed-by: Scott Branden > Tested-by: Scott Branden

Re: [PATCH v8 4/5] pwm: kona: Add debug info to config function

2015-05-30 Thread Tim Kryger
On Tue, May 26, 2015 at 1:08 PM, Jonathan Richardson wrote: > Adds debugging info to config function where duty cycle and period > are calculated and verified. > > Signed-off-by: Jonathan Richardson > --- > drivers/pwm/pwm-bcm-kona.c | 25 +++-- > 1 file changed, 23 inserti

Re: [RESEND PATCH 1/4] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver

2013-11-01 Thread Tim Kryger
On Fri, Nov 1, 2013 at 5:49 AM, Wolfram Sang wrote: > On Wed, Oct 16, 2013 at 03:01:46PM -0700, Tim Kryger wrote: >> Introduce support for Broadcom Serial Controller (BSC) I2C bus found >> in the Kona family of Mobile SoCs. FIFO hardware is utilized but only >> standard mod

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Tim Kryger
On Fri, Nov 1, 2013 at 6:08 AM, Wolfram Sang wrote: > On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote: >> Add support for I2C high-speed mode (3.4 MHz). >> >> Signed-off-by: Tim Kryger >> Reviewed-by: Matt Porter >> Reviewed-by: Markus Mayer &g

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Tim Kryger
On Thu, Nov 7, 2013 at 12:13 PM, Wolfram Sang wrote: > OK. Then please change the error message for unsupported bus speeds to > contain the supported ones. I don't think it is good practice to force > users to look into the sourcecode to find this information. That works for me. Thanks. -Tim -

[PATCH v3 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-03-12 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v3 0/5] Add Broadcom Kona PWM Support

2014-03-12 Thread Tim Kryger
soc. See https://lkml.org/lkml/2014/2/14/451 Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx) ARM: dts: Enable the PWM for bcm28155 AP board ARM: bcm_defconfig: Enable PWM and Backlight

[PATCH v3 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-03-12 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi

[PATCH v3 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-03-12 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v3 1/5] Documentation: dt: Add Kona PWM binding

2014-03-12 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 24 ++ 1 file changed, 24 insertions(+) c

[PATCH v3 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-12 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-bcm-kona.c | 304

Re: [PATCH v3 1/5] Documentation: dt: Add Kona PWM binding

2014-03-18 Thread Tim Kryger
On Tue, Mar 18, 2014 at 2:18 PM, Thierry Reding wrote: > On Wed, Mar 12, 2014 at 01:15:42PM -0700, Tim Kryger wrote: >> @@ -0,0 +1,24 @@ >> +Broadcom Kona PWM controller device tree bindings >> + >> +This controller has 6 channels. >> + >> +Required Propert

Re: [PATCH v3 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-18 Thread Tim Kryger
On Tue, Mar 18, 2014 at 2:52 PM, Thierry Reding wrote: > On Wed, Mar 12, 2014 at 01:15:43PM -0700, Tim Kryger wrote: > [...] >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >> index 22f2f28..1fd42af 100644 >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/

Re: [PATCH v3 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-18 Thread Tim Kryger
On Tue, Mar 18, 2014 at 4:47 PM, Tim Kryger wrote: > On Tue, Mar 18, 2014 at 2:52 PM, Thierry Reding > wrote: >> On Wed, Mar 12, 2014 at 01:15:43PM -0700, Tim Kryger wrote: >>> + >>> + /* There is polarity support in HW but it is easier to manage in SW

[PATCH v4 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-03-19 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm

[PATCH v4 1/5] Documentation: dt: Add Kona PWM binding

2014-03-19 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 files changed, 21 insertions(

[PATCH v4 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-03-19 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs

[PATCH v4 0/5] Add Broadcom Kona PWM Support

2014-03-19 Thread Tim Kryger
Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Dependencies: The "ARM: dts: Declare the PWM for bcm11351 (bcm281xx)" patch depends upon "ARM: dts: bcm281xx: define real clocks" which is queued up in for-next of arm-soc. See https://lkml.or

[PATCH v4 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-19 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig| 10 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 295

[PATCH v4 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-03-19 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot

Re: [PATCH v3 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-20 Thread Tim Kryger
On Thu, Mar 20, 2014 at 8:57 AM, Thierry Reding wrote: > On Tue, Mar 18, 2014 at 04:47:36PM -0700, Tim Kryger wrote: > Perhaps the comment for enum pwm_polarity in include/linux/pwm.h makes > this more obvious. What you do here is invert the duty cycle, rather > than the polarity.

Re: [PATCH v3 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-20 Thread Tim Kryger
On Thu, Mar 20, 2014 at 8:57 AM, Thierry Reding wrote: > On Tue, Mar 18, 2014 at 04:47:36PM -0700, Tim Kryger wrote: >> On Tue, Mar 18, 2014 at 2:52 PM, Thierry Reding >> wrote: >> > On Wed, Mar 12, 2014 at 01:15:43PM -0700, Tim Kryger wrote: >> >&

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

2014-01-24 Thread Tim Kryger
On Tue, Jan 7, 2014 at 11:37 AM, Tim Kryger wrote: > On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt wrote: >> On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger wrote: >>> Enable the external clock needed by the host controller during the >>> probe and disable it during

Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

2014-01-24 Thread Tim Kryger
On Wed, Jan 8, 2014 at 4:54 PM, Christian Daudt wrote: > On Wed, Jan 8, 2014 at 4:28 PM, Tim Kryger wrote: >> On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt wrote: >>> On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger wrote: >>>> The board schematic states that the &qu

[PATCH] mmc: sdhci-bcm-kona: Add basic use of clocks

2014-01-24 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter Reviewed-by: Christian Daudt --- This was dropped from "Update Kona drivers to use clocks" ser

[RESEND PATCH v5 0/5] Add Broadcom Kona PWM Support

2014-04-02 Thread Tim Kryger
//lkml.org/lkml/2014/2/14/451 Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx) ARM: dts: Enable the PWM for bcm28155 AP board ARM: bcm_defconfig: Enable PWM and Backlight .../de

[RESEND PATCH v5 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-02 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[RESEND PATCH v5 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-02 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[RESEND PATCH v5 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-02 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[RESEND PATCH v5 1/5] Documentation: dt: Add Kona PWM binding

2014-04-02 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) c

[RESEND PATCH v5 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-02 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

Re: [PATCH 2/5] ARM: add SMP support for Broadcom mobile SoCs

2014-04-04 Thread Tim Kryger
On Thu, Apr 3, 2014 at 7:18 PM, Alex Elder wrote: > diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c > new file mode 100644 > index 000..46a64f2 > --- /dev/null > +++ b/arch/arm/mach-bcm/platsmp.c > +/* Size of mapped Cortex A9 SCU address space */ > +#define SCU_SIZE

[RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

2014-01-07 Thread Tim Kryger
The board schematic states that the "SD_CARD_DET_N gets pulled to GND when card is inserted" so the polarity has been updated to active low. Polarity is now specified with a GPIO define instead of a magic number. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- arch/ar

Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks

2014-01-07 Thread Tim Kryger
On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt wrote: > On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger wrote: >> Enable the external clock needed by the host controller during the >> probe and disable it during the remove. >> >> Signed-off-by: Tim Kryger &

Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

2014-01-08 Thread Tim Kryger
On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt wrote: > On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger wrote: >> The board schematic states that the "SD_CARD_DET_N gets pulled to GND >> when card is inserted" so the polarity has been updated to active low. >> >

Re: [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-25 Thread Tim Kryger
On Mon, Nov 25, 2013 at 3:08 AM, Thierry Reding wrote: > On Mon, Nov 18, 2013 at 10:54:58AM -0800, Tim Kryger wrote: > [...] >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > [...] >> +config PWM_BCM_KONA >> + tristate "Kona PWM support"

Re: [PATCH 1/5] Documentation: dt: Add kona-pwm binding

2013-11-25 Thread Tim Kryger
On Tue, Nov 19, 2013 at 5:56 AM, Mark Rutland wrote: > On Mon, Nov 18, 2013 at 06:54:57PM +0000, Tim Kryger wrote: >> +Required Properties : >> +- compatible: should be "brcm,kona-pwm" >> +- reg: physical base address and length of the controller's registers &

Re: [PATCH 1/5] Documentation: dt: Add kona-pwm binding

2013-11-25 Thread Tim Kryger
On Mon, Nov 25, 2013 at 3:17 AM, Thierry Reding wrote: > On Mon, Nov 18, 2013 at 10:54:57AM -0800, Tim Kryger wrote: >> +++ b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt >> @@ -0,0 +1,24 @@ >> +Broadcom's PWM Controller Device Tree bindings > > Th

Re: [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support

2013-11-26 Thread Tim Kryger
On Tue, Nov 26, 2013 at 1:45 AM, Thierry Reding wrote: > On Mon, Nov 25, 2013 at 05:38:44PM -0800, Tim Kryger wrote: > Okay, that's fine then. Do you have a pointer to that documentation? Unfortunately the documentation is not publicly available at the moment. >> The hardware

Re: [PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround

2013-11-26 Thread Tim Kryger
On Tue, Nov 26, 2013 at 10:36 AM, Ezequiel Garcia wrote: > Since v3.13-rc1, this commit seems to have introduced some oddities on > some of our boards. See this log snippet: > > Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > R�console [ttyS0] enabled > console [ttyS0] enabled > bo

Re: [PATCH] i2c: i2c-bcm-kona: Fix module build

2013-11-26 Thread Tim Kryger
On Tue, Nov 26, 2013 at 5:00 AM, Wolfram Sang wrote: > Have you also tried repeated module loading/unloading? I ran a loop of insmod + rmmod 1000 times and didn't see any issues. Thanks, Tim Kryger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround

2013-11-27 Thread Tim Kryger
On Wed, Nov 27, 2013 at 10:54 AM, Ezequiel Garcia wrote: > On Tue, Nov 26, 2013 at 03:03:03PM -0800, Tim Kryger wrote: >> An external device may be keeping the UART busy and preventing LCR >> from being written. >> >> What device is attached to ttyS1? > > Th

Re: [RESEND PATCH v2 1/6] ARM: dts: Declare clocks as fixed on bcm11351

2013-11-08 Thread Tim Kryger
ke it easier to avoid/manage conflicts. Christian, would that work for you? Thanks, Tim Kryger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

[PATCH] ARM: bcm_defconfig: Do not expect appended DTB

2013-10-16 Thread Tim Kryger
The bootloaders used with Broadcom mobile SoCs are capable of handling a device tree separately from the zImage so there is no need for this option to be enabled. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig | 1 - 1 file changed, 1 deletion(-) diff

[RESEND PATCH v2 5/6] ARM: dts: Specify clocks for timer on bcm11351

2013-10-16 Thread Tim Kryger
Specify the external clock label in the timer node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-16 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/mmc/host/sdhci-bcm-kona.c | 30 -- 1 file changed, 28 insertions

[RESEND PATCH v2 0/6] Update Kona drivers to use clocks

2013-10-16 Thread Tim Kryger
://lkml.org/lkml/2013/9/18/409 https://lkml.org/lkml/2013/9/20/305 http://www.spinics.net/lists/arm-kernel/msg274973.html Changes in v2: - Renamed bsc4_clk to pmu_bsc_clk Tim Kryger (6): ARM: dts: Declare clocks as fixed on bcm11351 ARM: dts: Specify clocks for UARTs on bcm11351 ARM: dts

[RESEND PATCH v2 2/6] ARM: dts: Specify clocks for UARTs on bcm11351

2013-10-16 Thread Tim Kryger
Rather than declaring the frequency of the external clock, specify the label of the clock such that the driver may determine the frequency on its own. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 8 1 file changed

[RESEND PATCH v2 4/6] clocksource: kona: Add basic use of external clock

2013-10-16 Thread Tim Kryger
When an clock handle is specified in the device tree, enable it and use it to determine the external clock frequency. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/clocksource/bcm_kona_timer.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[RESEND PATCH v2 1/6] ARM: dts: Declare clocks as fixed on bcm11351

2013-10-16 Thread Tim Kryger
Declare clocks that are enabled and configured by bootloaders as fixed rate clocks in the DTS such that device drivers may use standard clock function calls. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 97

[RESEND PATCH v2 3/6] ARM: dts: Specify clocks for SDHCIs on bcm11351

2013-10-16 Thread Tim Kryger
Specify the external clock label in each SDHCI node. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- arch/arm/boot/dts/bcm11351.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi index

[RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-10-16 Thread Tim Kryger
Add support for I2C high-speed mode (3.4 MHz). Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- drivers/i2c/busses/i2c-bcm-kona.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b

[RESEND PATCH 1/4] i2c: i2c-bcm-kona: Introduce Broadcom I2C Driver

2013-10-16 Thread Tim Kryger
Introduce support for Broadcom Serial Controller (BSC) I2C bus found in the Kona family of Mobile SoCs. FIFO hardware is utilized but only standard mode (100kHz), fast mode (400kHz), and fast mode plus (1MHz) bus speeds are supported. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter Reviewed

[RESEND PATCH 0/4] Add-Broadcom-Kona-I2C-Support

2013-10-16 Thread Tim Kryger
This series adds support for the Kona I2C bus found on Broadcom mobile SoCs like the bcm11351 (aka bcm281xx) and enables it on the bcm28155-ap board. It depends upon the following commits: https://lkml.org/lkml/2013/10/7/481 http://www.spinics.net/lists/arm-kernel/msg274964.html Tim Kryger

[RESEND PATCH 3/4] ARM: dts: bcm281xx: Add i2c busses

2013-10-16 Thread Tim Kryger
Add the DTS nodes for all the i2c busses in the SoC. Signed-off-by: Tim Kryger Reviewed-by: Christian Daudt Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi | 40 1 file changed, 40 insertions(+) diff --git a

[RESEND PATCH 4/4] ARM: dts: bcm28155-ap: Enable all the i2c busses

2013-10-16 Thread Tim Kryger
Enable all available i2c busses. Signed-off-by: Tim Kryger Reviewed-by: Christian Daudt Reviewed-by: Matt Porter Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch

Re: [RESEND PATCH v2 5/6] ARM: dts: Specify clocks for timer on bcm11351

2013-10-18 Thread Tim Kryger
On Thu, Oct 17, 2013 at 7:06 AM, Mark Rutland wrote: >> diff --git a/arch/arm/boot/dts/bcm11351.dtsi >> b/arch/arm/boot/dts/bcm11351.dtsi >> index 193659c..39c1395 100644 >> --- a/arch/arm/boot/dts/bcm11351.dtsi >> +++ b/arch/arm/boot/dts/bcm11351.dtsi >> @@ -95,7 +95,7 @@ >> compat

Re: Compile error in i2c-bcm-kona.c

2013-11-25 Thread Tim Kryger
On Sun, Nov 24, 2013 at 9:11 PM, Guenter Roeck wrote: > Upstream HEAD, arm allmodconfig: > > drivers/i2c/busses/i2c-bcm-kona.c:894:1: error: '__mod_of_device_table' > aliased to undefined symbol 'kona_i2c_of_match' > make[3]: *** [drivers/i2c/busses/i2c-bcm-kona.o] Error 1 > make[2]: *** [drivers/

[PATCH] i2c: i2c-bcm-kona: Fix module build

2013-11-25 Thread Tim Kryger
Correct a typo that prevented the driver from being built as a module. Signed-off-by: Tim Kryger --- drivers/i2c/busses/i2c-bcm-kona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c index 036cf03

[PATCH] ARM: bcm_defconfig: Run "make savedefconfig"

2013-10-14 Thread Tim Kryger
Several of the options in bcm_defconfig have gotten out of date so regenerate it with "make savedefconfig" to keep things fresh. Signed-off-by: Tim Kryger Reviewed-by: Matt Porter --- arch/arm/configs/bcm_defconfig | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) di

Re: [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351

2013-12-13 Thread Tim Kryger
On Thu, Dec 12, 2013 at 11:48 PM, Christian Daudt wrote: > I'll try to sync with other maintainers to pull it in together. I'll > leave this commit in as-is for now as it is harmless on its own. I'll > back it off before 3.14 merge if it poses a problem. Sounds great. Thank you. -- To unsubscri

  1   2   3   >