ui/browser.c
because of setting default values of actual variables for 'colors' config.
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Wang Nan
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 15 +++
tools/perf/util/con
: Masami Hiramatsu
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/util/config.h | 20
1 file changed, 20 insertions(+)
diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
index 1fd8e4c..613900f 100644
--- a/tools/perf/util/config.h
+++ b/tools
amatsu
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/util/config.h | 29 +
1 file changed, 29 insertions(+)
diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
index 6f813d4..1fd8e4c 100644
--- a/tools/perf/util/config.h
+++ b/too
of each two color
- introduce perf_default_config_init() that call all default_*_config_init()
for each config section
v2:
- rename 'ui_browser__config_gcolors' to 'ui_browser__config_colors' (Arnaldo)
- change 'ground colors' to '{back, fore}ground colors' (Arnaldo)
- use strtok +
annoate.c
because of setting default values of actual variables for 'annotate' config.
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Wang Nan
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 11 +++
tools/perf/util/config.h | 11 ++
Namhyung Kim
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Wang Nan
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/annotate.c | 16
tools/perf/util/config.h | 3 +++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/tools/perf
f values (as just one).
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Wang Nan
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/ui/browser.c | 53 +++--
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/too
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Wang Nan
Cc: Alexander Shishkin
Signed-off-by: Taeung Song
---
tools/perf/ui/browser.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index 31e2028..598f434 10
minate allocated config set
perf_config_finish()
# destroy existing config set and initialize a new config set.
perf_config_refresh()
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Wang Nan
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Masami Hiramatsu
Cc: Alexander Shishkin
Signed-off-by:
Lately config_set__for_each is added.
In order to let show_config() be short and clear,
remake this function using config_set__for_each macro
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Alexander Shishkin
Cc: Wang Nan
Signed-off-by: Taeung Song
---
tools/perf/builtin-config.c
included previous cache.h
need only config.h, remove including cache.h.
Cc: Alexander Shishkin
Cc: Jiri Olsa
Cc: Masami Hiramatsu
Cc: Namhyung Kim
Cc: Wang Nan
Signed-off-by: Taeung Song
---
tools/perf/builtin-help.c | 2 +-
tools/perf/builtin-kmem.c | 2 +-
tools/perf
bout the config set at cmd_config()
- add a patch about a global variable 'config_set'
v2:
- split a patch into several patches
- reimplement show_config() using new perf_config()
- modify perf_config_set__delete using global variable 'config_set'
- reset config set when only &
es
before a sub-command work. And the config set that is made
by perf_config_set__new() would be reused
when we initialize all actual config variables
and then if using is is finished, we could free the config set.
Thanks,
Taeung
On 06/10/2016 07:58 PM, Taeung Song wrote:
On 06/09/2016 10:34 P
Hi, Arnaldo :)
On 08/09/2016 03:58 AM, Arnaldo Carvalho de Melo wrote:
Em Tue, Aug 02, 2016 at 06:20:46PM +0900, Taeung Song escreveu:
To easily set default config values into actual variables for 'colors' config,
it would be better that actual variables for each 'colors' c
Hi Arnaldo,
On 08/18/2017 12:16 AM, Arnaldo Carvalho de Melo wrote:
Em Tue, Aug 15, 2017 at 05:06:31PM -0300, Arnaldo Carvalho de Melo escreveu:
Em Wed, Aug 16, 2017 at 12:13:09AM +0900, Taeung Song escreveu:
Add --show-nr-samples option to perf-annotate
so that it corresponds with perf
riod and nr-samples view can't be used at the same time (Arnaldo)
Taeung Song (5):
perf annotate stdio: Support --show-nr-samples option
perf annotate: Add a missing period option in documentation
perf annotate: Period and samples view can't be used at the same time
perf annotate
Add --show-nr-samples option to perf-annotate
so that it corresponds with perf-report.
Cc: Namhyung Kim
Cc: Milian Wolff
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-annotate.txt | 4
tools/perf/builtin-annotate.c | 2 ++
tools/perf/util
If users give two options --show-total-period
and --show-nr-samples, show their proper usage because
the two options can not be used at the same time.
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/builtin-annotate.c | 8 ++--
1 file changed, 6 insertions(+), 2
With a existing 't' hotkey, support the three view based on percent,
total period and number of samples on the annotate TUI browser,
circulating them like below:
Percent -> Period -> Samples -> Percent ...
Suggested-by: Namhyung Kim
Cc: Milian Wolff
Cc: Jiri Olsa
Signed-
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/annotate.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c
b/tools/perf/ui/browsers/annotate.c
index 80f38da..faca1b9 100644
--- a/tools
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-annotate.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/Documentation/perf-annotate.txt
b/tools/perf/Documentation/perf-annotate.txt
index 2a5975c..c635eab 100644
--- a/tools/perf
) conversion
The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to
change the return value in some place. It makes perf help print
annoying output even for sane config items like below:
$ perf help
'.root': unsupported man viewer sub key.
...
Fixes: 8e99b6d4533
Hi, Namhyung and Ingo
> On Oct 22, 2015, at 9:20 PM, Namhyung Kim wrote:
>
> On Thu, Oct 22, 2015 at 5:23 PM, Ingo Molnar wrote:
>>
>> * Namhyung Kim wrote:
>>
>>> Currently 'perf top --call-graph' option is same as 'perf record'. But
>>> 'perf top' also need to receive display options in '
If perf.data file is owned by some user,
it can't be read even if current user is root.
A 'st_uid' from fstat() is user ID of the file owner.
Therefore use getuid() instead of st_uid to check if
user of the calling 'perf' process is root or not.
Signed-off-by: Taeung S
> On Oct 1, 2015, at 6:10 PM, Ingo Molnar wrote:
>
>
> * Taeung Song wrote:
>
>> If perf.data file is owned by some user,
>> it can't be read even if current user is root.
>
> That's intentional: to keep a malicious local user from passing a pe
ggest this patchset of the perf-config
command
which can list, get, set, remove perf configs or list with default config
values as below.
Taeung Song (7):
[PATCH v7 1/7] perf tools: Add 'perf-config' command
[PATCH v7 2/7] perf config: Add '--system' and &#
A option 'remove' is to remove specific config variables.
For the syntax examples,
# perf config [] -r | --remove [section.name ...]
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 6 +
tools/perf/builtin-config.c
ff-by: Taeung Song
---
tools/perf/builtin-config.c | 48 -
1 file changed, 43 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index f034c19..680a655 100644
--- a/tools/perf/builtin-config.c
+++ b/tools
x27;perf-config' command with '--list' option and a document
for it.
perf config [options]
display current perf config variables.
# perf config
or
# perf config -l | --list
Signed-off-by: Taeung Song
---
tools/perf/Build | 1 +
config file or both are used, list is required
to keep and handle config variables and values.
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 14 ++-
tools/perf/builtin-config.c | 163 +--
tools/perf/util/cache.h
This patch consists of functions
which can get specific config variables.
For the syntax examples,
perf config [] [section.name ...]
display key-value pairs of specific config variables
# perf config report.queue-size report.children
Signed-off-by: Taeung Song
---
tools/perf
This patch consists of functions
which can set specific config variables.
For the syntax examples,
perf config [] [options] [section.name[=value] ...]
set specific config variables
# perf config report.queue-size=100M report.children=true
Signed-off-by: Taeung Song
---
tools/perf
A option 'list-all' is to display both current config variables and
all possible config variables with default values.
The syntax examples are like below
perf config [] [options]
display all perf config with default values.
# perf config -a | --list-all
Signed-off-by: T
f: add bpftool")
Reviewed-by: Jakub Kicinski
Reported-by: Taehee Yoo
Signed-off-by: Taeung Song
---
tools/bpf/bpftool/common.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c
index 32f9e397a6c0..3f140eff039f
For untracked things of tools/bpf, add this.
Reviewed-by: Quentin Monnet
Signed-off-by: Taeung Song
---
tools/bpf/.gitignore | 5 +
tools/bpf/bpftool/.gitignore | 2 ++
2 files changed, 7 insertions(+)
create mode 100644 tools/bpf/.gitignore
diff --git a/tools/bpf/.gitignore b
For untracked things of tools/bpf, add this.
Reviewed-by: Jakub Kicinski
Signed-off-by: Taeung Song
---
tools/bpf/.gitignore | 5 +
tools/bpf/bpftool/.gitignore | 2 ++
2 files changed, 7 insertions(+)
create mode 100644 tools/bpf/.gitignore
diff --git a/tools/bpf/.gitignore b
To smoothly test BTF supported binary on samples/bpf,
let samples/bpf/Makefile probe llc, pahole and
llvm-objcopy for BPF support and use them
like tools/testing/selftests/bpf/Makefile
changed from the commit c0fa1b6c3efc ("bpf: btf:
Add BTF tests")
Cc: Martin KaFai Lau
Signed-off-
Hi,
Building bpf programs with .BTF section,
I thought it'd be better to convert dwarf info to .BTF by
a new tool such as 'tools/bpf/bpf_dwarf2btf' instead of pahole
in the future.
Currently for bpf binary that have .BTF section,
we need to use pahole from https://github.com/iamkafai/pahole/tree
Hi Arnaldo,
On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu:
Hi,
Building bpf programs with .BTF section,
I thought it'd be better to convert dwarf info to .BTF by
a new tool such as 'tools/bpf/bpf_dwarf2btf&#
On 07/26/2018 03:27 AM, Taeung Song wrote:
Hi Arnaldo,
On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu:
Hi,
Building bpf programs with .BTF section,
I thought it'd be better to convert dwarf info to .BTF by
a new
Hi Steven,
I found a trivial typo "eee" on the commit log title
It seems better to change "lib traceeevent" to " lib traceevent",
if you want to do it..
Thanks,
Taeung
On 01/12/2018 09:47 AM, Steven Rostedt wrote:
-off-by: Taeung Song
---
samples/bpf/trace_event_user.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/samples/bpf/trace_event_user.c b/samples/bpf/trace_event_user.c
index 1fa1becfa641..d08046ab81f0 100644
--- a/samples/bpf/trace_event_user.c
v2:
- in error cases, do return; instead of break; in loop
Hello,
This patchset fixes trivial things that I found
when testing 'samples/bpf/' sample code.
I'd appreciate it, if you review this.
Thanks,
Taeung
Taeung Song (4):
samples/bpf: add missing
samples/bpf: Check the r
struct vlan_hdr' in sample code and include if_vlan.h
Signed-off-by: Taeung Song
---
samples/bpf/parse_varlen.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/samples/bpf/parse_varlen.c b/samples/bpf/parse_varlen.c
index 95c16324760c..0b6f22feb2c9 100644
--- a/sample
For untracked executables of samples/bpf, add this.
Untracked files:
(use "git add ..." to include in what will be committed)
samples/bpf/cpustat
samples/bpf/fds_example
samples/bpf/lathist
samples/bpf/load_sock_ops
...
Signed-off-by: T
Add 'get' option that can show value of a specific config variable
and 'set' and 'unset' option that can create or replace a config variable.
Signed-off-by: Taeung Song
---
tools/perf/builtin-config.c | 198
too
patch adds 'perf-config' command with '--list' option and a document
for it.
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
tools/perf/Documentation/perf-config.txt| 418
tools/perf/Documentation/perfcon
A option 'remove' is to remove specific config variables.
For the syntax examples,
# perf config -r | --remove [section.subkey ...]
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 6
tools/perf/builtin-config.c
This patch adds 'perf-config' command with '--list' option and a document
for it.
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
tools/perf/Documentation/perf-config.txt| 436
tools/perf/Documentation/perfcon
variables
# perf config report.queue-size=100M report.children=true
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 2 +
tools/perf/builtin-config.c | 276 ++-
tools/perf/util/cache.h | 17 ++
tools/perf/util
ned-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 6 +++
tools/perf/builtin-config.c | 49
tools/perf/util/PERFCONFIG-DEFAULT | 65
tools/perf/util/cache.h | 1 +
tools/perf/uti
key(section.subkey) and value
# perf config report.queue
set a specific key and value
# perf config report.queue=100M
remove a specific key
# perf config -r | --remove report.queue
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 8 ++
tools/perf
patch adds 'perf-config' command with '--all' option and a document for
it.
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
tools/perf/Documentation/perf-config.txt| 433
tools/perf/Documentation/perfcon
This patch adds 'perf-config' command with '--all' option and a document for
it.
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
tools/perf/Documentation/perf-config.txt| 433
tools/perf/Documentation/perfcon
config report.queue=100M
remove a specific key
# perf config -r | --remove report.queue
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 8 ++
tools/perf/builtin-config.c | 224 ++-
tools/perf/util/cache.h
x27;perf-config' command with '--list' option and a document
for it.
perf config [options]
display current perf config variables.
# perf config
or
# perf config -l | --list
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
# perf config report.queue-size=100M report.children=true
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 2 +
tools/perf/builtin-config.c | 543 ++-
tools/perf/util/cache.h | 17 +
tools/perf/util/config.c
A option 'remove' is to remove specific config variables.
For the syntax examples,
# perf config -r | --remove [section.name ...]
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 6 ++
tools/perf/builtin-config.c | 25 ++
A option 'list-all' is to display both current config variables and
all possible config variables with default values.
The syntax examples are like below
perf config [options]
display all perf config with default values.
# perf config -a | --list-all
Signed-off-by: T
Because perf_session__new() could fail for more reasons than just ENOMEM,
I modified error code(ENOMEM or EINVAL) into -1.
Signed-off-by: Taeung Song
---
tools/perf/builtin-annotate.c | 2 +-
tools/perf/builtin-diff.c | 2 +-
tools/perf/builtin-evlist.c| 2 +-
tools/perf/builtin
When 'perf top' is run, one can't easily find a difference
between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/hists.c | 38 ++
1 f
When 'perf top' is run, one can't easily find a difference
between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.
Signed-off-by: Taeung Song
---
tools/perf/PERF-FEATURES | 1 +
tools/perf/ui/browse
When 'perf top' is run, one can't easily find a difference
between -z option and normal output.
So I added a visual cue to know whether it is the zeroing or not.
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/hists.c | 34 --
1 file changed
below.
After:
Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z]
Overhead Shared Object Symbol
1.42% firefox [.] 0x00011e76
1.32% libpthread-2.17.so [.] pthread_mutex_lock
Signed-off-by
So far, it is difficult that the state of perf configs is looked through
and there's no knowing what kind of other variables except variables in
perfconfig.example.
Also perf configs can't be changed without manually modifying $HOME/.perfconfig
or
$(sysconfdir)/perfconfig file. So I suggest this
x27;perf-config' command with '--list' option and a document
for it.
perf config [options]
display current perf config variables.
# perf config
or
# perf config -l | --list
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
A option 'list-all' is to display both current config variables and
all possible config variables with default values.
The syntax examples are like below
perf config [options]
display all perf config with default values.
# perf config -a | --list-all
Signed-off-by: T
# perf config report.queue-size=100M report.children=true
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 2 +
tools/perf/builtin-config.c | 560 ++-
tools/perf/util/cache.h | 17 +
tools/perf/util/config.c
A option 'remove' is to remove specific config variables.
For the syntax examples,
# perf config -r | --remove [section.name ...]
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 6 ++
tools/perf/builtin-config.c | 25 ++
fault config file path is
$HOME/.perfconfig.
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 14 +-
tools/perf/builtin-config.c | 21 ++---
tools/perf/util/cache.h | 2 ++
tools/perf/util/config.c |
So far, it is difficult that the state of perf configs is looked through
and there's no knowing what kind of other variables except variables in
perfconfig.example.
Also perf configs can't be changed without manually modifying $HOME/.perfconfig
or
$(sysconfdir)/perfconfig file. So I suggest this
x27;perf-config' command with '--list' option and a document
for it.
perf config [options]
display current perf config variables.
# perf config
or
# perf config -l | --list
Signed-off-by: Taeung Song
---
tools/perf/Build| 1 +
A option 'list-all' is to display both current config variables and
all possible config variables with default values.
The syntax examples are like below
perf config [options]
display all perf config with default values.
# perf config -a | --list-all
Signed-off-by: T
A option 'remove' is to remove specific config variables.
For the syntax examples,
# perf config -r | --remove [section.name ...]
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 6 ++
tools/perf/builtin-config.c | 26 +++
This patch consists of functions
which can get specific config variables.
For the syntax examples,
perf config [options] [section.name ...]
display key-value pairs of specific config variables
# perf config report.queue-size report.children
Signed-off-by: Taeung Song
---
tools/perf
config file path is
$HOME/.perfconfig.
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perf-config.txt | 14 +-
tools/perf/builtin-config.c | 23 +--
tools/perf/util/cache.h | 2 ++
tools/perf/util/config.c |
This patch consists of functions
which can set specific config variables.
For the syntax examples,
perf config [options] [section.name[=value] ...]
set specific config variables
# perf config report.queue-size=100M report.children=true
Signed-off-by: Taeung Song
---
tools/perf
m
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 173 +++
tools/perf/util/config.h | 26 +++
2 files changed, 199 insertions(+)
create mode 100644 tools/perf/util/config.h
diff --git a/tools/perf/util/config.c b/tools
correct type of a config
variable in the near future.
Cc: Masami Hiramatsu
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/builtin-config.c | 11 +++
tools/perf/util/config.c| 39 ++-
tools/perf/util/config.h| 7
config --user --list
top.children=false
# perf config --system --list
top.children=true
# perf config --list
top.children=false
Cc: Masami Hiramatsu
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/builtin-config.c | 39
th config files)
and needless at this time, etc. (Namhyung)
- separate this patch as several patches (Namhyung)
- fix typing errors, etc.
Taeung Song (4):
perf config: Introduce perf_config_set class
perf config: Let show_config() work with perf_config_set
perf config: Prepare all default config
ed-by: Namhyung Kim
Cc: Masami Hiramatsu
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 110 ++-
tools/perf/util/config.h | 62 +-
2 files changed, 168 insertions(+), 4 deletions(-)
diff --git a/tools/perf
Hi, Arnaldo
On 04/14/2016 09:19 PM, Arnaldo Carvalho de Melo wrote:
Em Thu, Apr 14, 2016 at 04:53:20PM +0900, Taeung Song escreveu:
To precisely manage configs,
prepare all default perf's configs that contain
default section name, variable name, value
and correct type, not string type.
I
alue 'true'.
IMHO, I think it should be needed to use new default config arrays
to manage default perf config values more effectively.
And this pathset contains patchs for only 'colors' and 'annoate' section
because waiting for other opinions.
If you review this patchset,
: Namhyung Kim
Cc: Masami Hiramatsu
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 150 ++-
tools/perf/util/config.h | 46 ++-
2 files changed, 194 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/config.c b
Set default config values for 'colors' section with 'colors_config_items[]'
instead of actual const char * type values.
(e.g. using colors_config_item[CONFIG_COLORS_TOP].value
instead of "red, default" string value for 'colors.top')
Cc: Namhyung Kim
C
ui_browser__color_config() set foreground and background
colors values in ui_browser__colorsets.
But it can be reused by other functions so make ui_browser__config_gcolors()
bringing it from ui_browser__color_config().
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf
mhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/annotate.c | 12
tools/perf/util/config.h | 16
2 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c
b/tools/perf/ui/browsers/annota
iable
with the default_config_item arrays and etc.
Cc: Namhyung Kim
Cc: Masami Hiramatsu
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 150 ++-
tools/perf/util/config.h | 46 ++-
2 files changed, 194 insertions(
contains configs each section
instead of the single config list (Namhyung)
- exclude a patch for '--list-all' option from this patchset
v2:
- remove perf_config_kind (user, system or both config files)
and needless at this time, etc. (Namhyung)
- separate this patch as several pat
Hi, Arnaldo :)
On 05/10/2016 02:17 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, May 09, 2016 at 08:41:47PM +0900, Taeung Song escreveu:
ui_browser__color_config() set foreground and background
colors values in ui_browser__colorsets.
"ground colors" sounds strange, I guess referrei
Hi, Arnaldo, Namhyung and jirka :)
On 05/10/2016 02:17 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, May 09, 2016 at 08:41:46PM +0900, Taeung Song escreveu:
We currently use values of actual type(int, bool, char *, etc.)
when initializing default perf config values.
But I suggest using new
On 05/10/2016 02:19 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, May 09, 2016 at 08:41:48PM +0900, Taeung Song escreveu:
Set default config values for 'colors' section with 'colors_config_items[]'
instead of actual const char * type values.
(e.g. using colors_config_it
ui_browser__color_config() set foreground and background
colors values in ui_browser__colorsets.
But it can be reused by other functions so make ui_browser__config_colors()
bringing it from ui_browser__color_config().
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ui
Hi, Arnaldo
On 05/11/2016 12:05 AM, Arnaldo Carvalho de Melo wrote:
Em Tue, May 10, 2016 at 08:49:16PM +0900, Taeung Song escreveu:
Hi, Arnaldo, Namhyung and jirka :)
On 05/10/2016 02:17 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, May 09, 2016 at 08:41:46PM +0900, Taeung Song escreveu:
We
: Namhyung Kim
Cc: Masami Hiramatsu
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 150 ++-
tools/perf/util/config.h | 46 ++-
2 files changed, 194 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/config.c b
mhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/annotate.c | 12
tools/perf/util/config.h | 16
2 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c
b/tools/perf/ui/browsers/annota
Set default config values for 'colors' section with 'colors_config_items[]'
instead of actual const char * type values.
(e.g. using colors_config_item[CONFIG_COLORS_TOP].value
instead of "red, default" string value for 'colors.top')
Cc: Namhyung Kim
C
iew this patchset, I'd appreciate it :-)
Thanks,
Taeung
v2:
- rename 'ui_browser__config_gcolors' to 'ui_browser__config_colors' (Arnaldo)
- change 'ground colors' to '{back, fore}ground colors' (Arnaldo)
- use strtok + ltrim instead of strchr and while (isspace(*++
ui_browser__color_config() set foreground and background
colors values in ui_browser__colorsets.
But it can be reused by other functions so make ui_browser__config_colors()
bringing it from ui_browser__color_config().
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ui
1 - 100 of 884 matches
Mail list logo
