DA9063 driver development

2013-09-06 Thread Steve Twiss
? Regards, Steve Twiss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[RFC V1] COMMIT 1: DA9210 driver files

2013-06-20 Thread Steve Twiss
From: Steve Twiss This is the regulator driver for the Dialog DA9210 Multi-phase Buck. The patch is relative to linux-next next-20130620 The regulator implements the functions for .enable, .set_voltage, .get_voltage, .set_current_limit, and .get_current_limit. It uses the kernel standard

[RFC V1] DA9210 driver request for comments

2013-06-20 Thread Steve Twiss
From: Steve Twiss The following describes the driver DA9210 from Dialog Semiconductor Ltd. This is a request for comment relating to the Dialog DA9210 driver. The patches have been made relative to the following kernel version: linux-next next-20130620 This driver is for the Dialog DA9210

[RFC V2] DA9210 driver files

2013-07-01 Thread Steve Twiss
From: Steve Twiss This is the regulator driver for the Dialog DA9210 Multi-phase Buck. The patch is relative to linux-next next-20130701 and this is RFC attempt number 2 The main changes the previous RFC number 1 are as follows: (1) Kconfig - Entry for REGULATOR_DA9210 has now been

RE: [RFC V2] DA9210 driver files

2013-07-15 Thread Steve Twiss
>On 02 July 2013 22:06, Mark Brown wrote: >>On Mon, Jul 01, 2013 at 03:10:28PM +0100, Steve Twiss wrote: > >> The use of regmap_range is not being considered because I am not >> intending to use PAGE_CON register page selection in any of the driver >> development. &

[PATCH V1] DA9210 driver files

2013-07-15 Thread Steve Twiss
From: Steve Twiss This patch describes the regulator driver for the DA9210 Multi-phase Buck from Dialog Semiconductor Ltd. It has been made aginst kernel version linux-next next-20130715 This driver is for the Dialog DA9210 Multi-phase 12A DC-DC Buck Converter controlled only from the I2C bus

RE: [PATCH V1] DA9210 driver files

2013-08-06 Thread Steve Twiss
On Mon 15 July 2013 17:58 Mark Brown wrote: >Subject: Re: [PATCH V1] DA9210 driver files I should have named this PATCH V3 to follow on from previous versions from RFC that I submitted. >To repeat *again* you should submit patches in the format covered in >SubmittingPatches. This includes thin

[PATCH V4] DA9210 new driver files

2013-08-06 Thread Steve Twiss
From: Steve Twiss I2C driver for the Dialog DA9210 Multi-phase 12A DC-DC Buck. Signed-off-by: Steve Twiss Signed-off-by: David Dajun Chen --- Checks performed with next-20130806/scripts/checkpatch.pl Kconfig total: 0 errors, 36 warnings, 565 lines checked da9210

RE: [PATCH V4] DA9210 new driver files

2013-08-06 Thread Steve Twiss
On Tue 06 August 2013 15:31 Steve Twiss wrote: >Subject: [PATCH V4] DA9210 new driver files ... It has already been pointed out that I have put the wrong subject line into this patch. I thought that my previous submission attempts were drawing comments because of the body content of the e-m

[PATCH V1] regulator: da9053/52: Fix incorrectly stated minimum and maximum voltage limits

2016-07-20 Thread Steve Twiss
From: Steve Twiss This fix alters the minimum and maximum BUCK voltage limits for DA9052 and DA9053. It does so for the following cases: DA9052 - BUCK3 (MEM) min: 0.925V -> 0.950V max: 2.500V -> 2.525V DA9053 - BUCK3 (MEM) min: 0.925V -> 0.950V max: 2.500V -> 2.525V -

[RFC] regulator: da9052/53: da9052-i2c.txt binding document changes

2016-07-22 Thread Steve Twiss
Hi, The binding file for DA9052/53 exists in the kernel and was originally submitted by Ying-Chun Liu from Linaro way back in 2012. Documentation/devicetree/bindings/mfd/da9052-i2c.txt > git show 58d114b The patch adds support for the Dialog MFD and it lists the compatible strings "dlg,da9052",

[PATCH V2] documentation: da9052: Update regulator bindings names to match DA9052/53 driver expectations

2016-07-27 Thread Steve Twiss
From: Steve Twiss Buck and LDO binding name changes. The binding names for the regulators have been changed to match the current expectation from existing device tree source files. This fix rectifies the disparity between what currently exists in some .dts[i] board files and what is listed in

RE: [RFC] regulator: da9052/53: da9052-i2c.txt binding document changes

2016-07-28 Thread Steve Twiss
On 27 July 2016 19:24, Mark Brown wrote: > On Mon, Jul 25, 2016 at 11:31:27AM +0000, Steve Twiss wrote: > > > There are already several device tree files using a naming scheme different > > to that found > > in the binding text document. Since those have been used for r

RE: [PATCH V1] mfd: da9053: ensure the FAULT_LOG is cleared during MFD driver probe

2016-08-08 Thread Steve Twiss
On 05 August 2016 10:05, Lee Jones wrote: > To: Steve Twiss > Subject: Re: [PATCH V1] mfd: da9053: ensure the FAULT_LOG is cleared during > MFD driver probe > > On Wed, 06 Jul 2016, Steve Twiss wrote: > > From: Steve Twiss > > > > Clearance of any the persist

RE: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses

2016-08-08 Thread Steve Twiss
On 8 August 2016 12:25, Lee Jones wrote: > To: Steve Twiss > Cc: LINUXKERNEL > Subject: Re: [PATCH RFC V1] mfd: da9063: Update author information to remove > incorrect e-mail addresses > > On Mon, 11 Jul 2016, Steve Twiss wrote: > > From: Steve T

[PATCH V2] mfd: da9063: Update author information to remove incorrect e-mail addresses

2016-08-08 Thread Steve Twiss
From: Steve Twiss Remove incorrect e-mail addresses from the copyright header and MODULE_AUTHOR() macro. These e-mail addresses are no longer in use. The author names have not been changed, only the e-mail addresses have been deleted from the source files. Signed-off-by: Steve Twiss

[PATCH V1] MAINTAINERS: Add Dialog ONKEY search term for missing documentation

2016-08-08 Thread Steve Twiss
From: Steve Twiss Dialog Semiconductor support would like to follow files by adding to the existing MAINTAINERS search terms. The update will allow us to follow files for the ONKEY PMIC documentation bindings. Signed-off-by: Steve Twiss --- Hi Dmitry, This change to the MAINTAINERS file will

RE: MAINTAINERS without commits in the last 3 years

2016-08-25 Thread Steve Twiss
Hi Joe, The address "support.opensou...@diasemi.com" works. Thanks. On 25 August 2016 00:34 Joe Perches wrote: > Many email addresses in MAINTAINERS no longer work so many > sections in MAINTAINERS could likely be considered either > obsolete or unmaintained. [...] > The email addresses below a

RE: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Steve Twiss
Hi Pavel, On 20 June 2017 14:26, Pavel Machek wrote: > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote:

RE: [PATCH 14/51] rtc: da9063: stop using rtc deprecated functions

2017-06-20 Thread Steve Twiss
Hi Benjamin, On 20 June 2017 10:35, Benjamin Gaignard wrote: > Subject: [PATCH 14/51] rtc: da9063: stop using rtc deprecated functions Probably this subject should be "rtc: da9052" not 63. > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that wi

[PATCH V2] regulator: da9053: Update regulator for DA9053 BB silicon support

2015-10-13 Thread Steve Twiss
From: Steve Twiss Provide an additional case entry for DA9053_BC in the find_regulator_info() function in order to support BB type silicon for the DA9053 device. Signed-off-by: Steve Twiss --- Changes since PATCH V1 - No content change, just send this patch separately as requested This patch

[PATCH V3] regulator: da9053: Update regulator for DA9053 BC silicon support

2015-10-16 Thread Steve Twiss
From: Steve Twiss Provide an additional case entry for DA9053_BC in the find_regulator_info() function in order to support BC type silicon for the DA9053 device. Signed-off-by: Steve Twiss --- Changes since PATCH V2 - No content change to the patch - Typos replace references to BB with BC in

[PATCH V1] rtc: GPL copyright inconsistency fix

2015-10-02 Thread Steve Twiss
From: Steve Twiss Fix misleading and inconsistent copyright header wording. Alter the copyright header text and MODULE_LICENSE macro to ensure the GPL v2 licence description is correctly represented. It will remove the incorrectly LGPL worded text. Words such as "Library" from the

RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

2018-12-05 Thread Steve Twiss
Hi Paul, On 03 December 2018 04:23, Paul Gortmaker wrote: > Subject: [PATCH v2 00/22] mfd: demodularization of non-modular drivers > > [v1 --> v2: add some more commits as requested by Lee (MFD maintainer), > update the 00/NN text; re-do build and link testing on new linux-next. ] > > This gro

RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

2018-12-05 Thread Steve Twiss
Sorry typo. I meant modular. On 05 December 2018 12:02, Steve Twiss wrote: > Subject: RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers > > Hi Paul, > > On 03 December 2018 04:23, Paul Gortmaker wrote: > > > Subject: [PATCH v2 00/22] mfd: demodul

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-24 Thread Steve Twiss
Thanks Marek, > On 23 May 2018 12:43 Marek Vasut wrote, > > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; > Lee Jones ; Mark Brown ; Steve > Twiss ; > Wolfram Sang ; > linux-renesas-...@vger.kernel.org > Subject: [PATCH 6/6] mf

RE: [PATCH 1/6] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-05-24 Thread Steve Twiss
Hi Marek, On 23 May 2018 12:42 Marek Vasut wrote: > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: [PATCH 1/6] mfd: da9063: Ren

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-24 Thread Steve Twiss
Hi Marek, On 24 May 2018 @ 12:49 Steve Twiss wrote: > To: Marek Vasut ; linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: RE: [PATCH 6/6] mfd: d

RE: [PATCH 4/6] mfd: da9063: Disallow RTC on DA9063L

2018-05-24 Thread Steve Twiss
Thanks Marek, On 23 May 2018 12:42 Marek Vasut wrote, > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: [PATCH 4/6] mfd: da9063: Disallow RTC

RE: [PATCH 3/6] mfd: da9063: Add DA9063L type

2018-05-24 Thread Steve Twiss
On 23 May 2018 12:42 Marek Vasut wrote: > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: [PATCH 3/6] mfd: da9063: Add DA9063L type > &

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-24 Thread Steve Twiss
On 24 May 2018 15:51 Marek Vasut wrote: Hi Marek, > To: Steve Twiss ; linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Wolfram Sang ; > linux-renesas-...@vger.kernel.org > Subject: Re: [PATCH 6/6] mfd: da9063: Add DA9063L sup

RE: [PATCH] Input: add error handling for da9052_reg_write

2018-06-11 Thread Steve Twiss
On 11 June 2018 18:30 wrote Dmitry Torokhov > Subject: Re: [PATCH] Input: add error handling for da9052_reg_write > > Hi Zhouyang, > > On Mon, Jun 11, 2018 at 01:23:39PM +0800, Zhouyang Jia wrote: > > When da9052_reg_write fails, the lack of error-handling code may > > cause unexpected results.

RE: [PATCH 22/30] hwmon: (da9055-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

2018-12-11 Thread Steve Twiss
e-patches/hwmon/. > > This patch does not introduce functional changes. It was verified by > compiling the old and new files and comparing text and data sizes. > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Thanks, Same again. Acked-by: Ste

RE: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

2018-12-11 Thread Steve Twiss
E_ATTR(_name, 0444, _func##_show, NULL, _index) Acked-by: Steve Twiss Regards, Steve > --- > 1 file changed, 39 insertions(+), 66 deletions(-) > > diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c > index a973eb6a2890..8ec5bf4ce392 100644 > --- a/drivers

RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2019-01-07 Thread Steve Twiss
Hi Geert, On 04 January 2019 at 15:48, Geert Uytterhoeven wrote: > To: Steve Twiss > Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type > settings > > ()Hi Steve, > > On Wed, Jan 2, 2019 at 4:31 PM Steve Twiss > wrote: > > On 01 January 2

RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2019-01-08 Thread Steve Twiss
gmap-irq.c > > @@ -258,7 +258,7 @@ static int regmap_irq_set_type(struct irq_data *data, > unsigned int type) > > const struct regmap_irq_type *t = &irq_data->type; > > > > if ((t->types_supported & type) != type) > > - return

RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2019-01-02 Thread Steve Twiss
Hi Geert, On 01 January 2019 @17:36, Geert Uytterhoeven wrote: > Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type > settings > On Mon, Dec 31, 2018 at 8:14 PM Mark Brown wrote: > > On Sat, Dec 29, 2018 at 12:13:32PM +0100, Geert Uytterhoeven wrote: > > > > Geert, do you

[PATCH V1] mfd: da9063: Add device tree support

2015-01-14 Thread Steve Twiss
From: Steve Twiss Add device tree support for DA9063 regulators; Real-Time Clock and Watchdog. Signed-off-by: Steve Twiss --- Checks performed with linux-next/v3.19-rc4/scripts/checkpatch.pl da9063.txttotal: 0 errors, 0 warnings, 94 lines checked da9063-core.c

[PATCH V2 1/2] mfd: da9063: Add device tree support

2015-01-19 Thread Steve Twiss
From: Steve Twiss Add device tree support for DA9063 regulators; Real-Time Clock and Watchdog. This patch is dependent on PATCH V2 2/2 Signed-off-by: Steve Twiss --- This patch applies against linux-next and v3.19-rc4 drivers/mfd/da9063-core.c | 2 ++ drivers/mfd/da9063-i2c.c

[PATCH V2 2/2] devicetree: Add bindings for DA9063

2015-01-19 Thread Steve Twiss
From: Steve Twiss Add device tree bindings for DA9063 regulators; Real-Time Clock and Watchdog. This patch is dependent on PATCH V2 1/2 Signed-off-by: Steve Twiss --- This patch applies against linux-next and v3.19-rc4 Documentation/devicetree/bindings/mfd/da9063.txt | 94

[PATCH V1 0/2] Add OnKey support for DA9063

2015-04-08 Thread Steve Twiss
From: Steve Twiss This patch set adds OnKey driver support for the Dialog Semiconductor DA9063 PMIC. [PATCH V1 1/2]: kernel driver onkey support [PATCH V1 2/2]: device tree bindings document Thank you, Steve Twiss, Dialog Semiconductor Ltd. S Twiss (2): input: misc: da9063: OnKey driver

[PATCH V1 2/2] devicetree: Add bindings for DA9063 OnKey

2015-04-08 Thread Steve Twiss
From: Steve Twiss Add device tree bindings for the DA9063 OnKey driver This patch is dependent on PATCH V1 1/2 Signed-off-by: Steve Twiss --- This patch applies against linux-next and v4.0-rc6 Documentation/devicetree/bindings/mfd/da9063.txt | 22 -- 1 file changed

[PATCH V1 1/2] input: misc: da9063: OnKey driver

2015-04-08 Thread Steve Twiss
From: Steve Twiss Add OnKey driver support for DA9063 This patch is dependent on PATCH V1 2/2 Signed-off-by: Steve Twiss --- This patch applies against linux-next and v4.0-rc6 MAINTAINERS | 2 +- drivers/input/misc/Kconfig| 10 ++ drivers/input/misc

RE: [PATCH v4] watchdog: add SPDX identifiers for watchdog subsystem

2018-03-01 Thread Steve Twiss
On 28 February 2018 15:02, Marcus Folkesson wrote: > Subject: [PATCH v4] watchdog: add SPDX identifiers for watchdog subsystem > > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > licens

[PATCH V1] mfd: da9062: use core helper regmap_reg_range macros

2018-03-28 Thread Steve Twiss
From: Steve Twiss Replace multi-line entries in the regmap_range arrays with single line macros: regmap_reg_range(). This will leave the static structure array entries for regmap_range unaltered. It will significantly reduce the line count in the DA9062/61 core file. Signed-off-by: Steve Twiss

RE: [PATCH v3 03/10] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-06-05 Thread Steve Twiss
>> have to be made using DT or otherwise. > >> > >> Signed-off-by: Marek Vasut > >> Cc: Geert Uytterhoeven > >> Cc: Lee Jones > >> Cc: Mark Brown > >> Cc: Steve Twiss > >> Cc: Wolfram Sang > >> Cc: linux-renesas-...@vge

RE: [PATCH v3 07/10] mfd: da9063: Add custom IRQ map for DA9063L

2018-06-05 Thread Steve Twiss
-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Lee Jones > Cc: Mark Brown > Cc: Steve Twiss > Cc: Wolfram Sang > Cc: linux-renesas-...@vger.kernel.org > --- > V3: New patch > --- > drivers/mfd/da9063-irq.c | 55 >

RE: [PATCH 04/11] regulator: da9210: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
or_set_current_limit_regmap, > + .get_current_limit = regulator_get_current_limit_regmap, > }; Hi Axel, Thanks, Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 03/11] regulator: da9055: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
CK_LIM,\ > + .csel_mask = (mbits),\ Hi Axel, Thanks. Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 08/11] regulator: pv88060: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
On 28 February 2019 13:40, Axel Lin wrote: > Subject: [PATCH 08/11] regulator: pv88060: Convert to use > regulator_set/get_current_limit_regmap > > Use regulator_set/get_current_limit_regmap helpers to save some code. [...] Hi Axel, Looks good to me. Thanks again. Acked-by:

RE: [PATCH 09/11] regulator: pv88080: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
On 28 February 2019 13:40, Axel Lin wrote: > Subject: [PATCH 09/11] regulator: pv88080: Convert to use > regulator_set/get_current_limit_regmap > > Use regulator_set/get_current_limit_regmap helpers to save some code. [...] Hi Axel, Looks good to me. Thanks again. Acked-by:

RE: [PATCH 10/11] regulator: pv88090: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
.limit_mask = PV88090_##regl_name##_ILIM_MASK, \ > .conf = PV88090_REG_##regl_name##_CONF1, \ > .conf2 = PV88090_REG_##regl_name##_CONF2, \ Acked-by: Steve Twiss ; Thanks, Regards, Steve

RE: [PATCH 1/2] rtc: da9063: set range

2019-04-02 Thread Steve Twiss
Hi, > > > drivers/rtc/rtc-da9063.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c > > > index 1b792bcea3c7..53e690b0f3a2 100644 > > > --- a/drivers/rtc/rtc-da9063.c > > > +++ b/drivers/rtc/rtc-da9063.c > > > @@ -475,6 +4

RE: [PATCH 09/22] watchdog: da9052_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
he conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > Cc: Support Opensource > Signed-off-by: Guenter Roeck Acked-by: Steve Twiss Thanks! Regards, Steve

RE: [PATCH 10/22] watchdog: da9055_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
he conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > Cc: Support Opensource > Signed-off-by: Guenter Roeck Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 11/22] watchdog: da9062_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
https://github.com/groeck/coccinelle-patches > > Cc: Support Opensource > Signed-off-by: Guenter Roeck Acked-by: Steve Twiss Thanks for that, Regards, Steve

RE: [PATCH 12/22] watchdog: da9063_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
da9063 *da9063; > struct watchdog_device *wdd; > > - if (!pdev->dev.parent) > + if (!dev->parent) > return -EINVAL; None of my previous Acked e-mails in this patch set considered whether the dev->parent was NULL. But this DA9063 driver does. Logically, this is correct to check, but ... any thoughts? Otherwise, Acked-by: Steve Twiss Regards, Steve

[PATCH V1] regulator: da9063: Bug fix when setting max voltage on LDOs 5-11

2014-02-11 Thread Steve Twiss
From: Steve Twiss Bug fix to allow the setting of maximum voltage for certain LDOs. Signed-off-by: Steve Twiss --- Checks performed with next-20140211/scripts/checkpatch.pl da9063-regulator.ctotal: 0 errors, 0 warnings, 927 lines checked This patch applies against kernel version

[PATCH V2] regulator: da9063: Bug fix when setting max voltage on LDOs 5-11

2014-02-12 Thread Steve Twiss
From: Steve Twiss Bug fix to allow the setting of maximum voltage for certain LDOs. What the bug is: There is a problem caused by an invalid calculation of n_voltages in the driver. This n_voltages value has the potential to be different for each regulator. The value for linear_min_sel is set

[PATCH V1] da9063: mfd: Fix missing DA9063_M_DVC_RDY mask bit

2015-07-17 Thread Steve Twiss
From: Steve Twiss Fix a missing DVC_RDY interrupt mask in struct regmap_irq definition. The original submission of this driver did not contain all interrupt masking definitions in the struct regmap_irq contained in the file da9063-irq.c The solution is to add a DA9063_IRQ_DVC_RDY entry to enum

[PATCH V1] rtc: da9053: fix access ordering error during RTC interrupt at system power on

2016-04-14 Thread Steve Twiss
From: Steve Twiss This fix alters the ordering of the IRQ and device registrations in the RTC driver probe function. This change will apply to the RTC driver that supports both DA9052 and DA9053 PMICs. A problem could occur with the existing RTC driver if: A system is started from a cold boot

[PATCH V1] MAINTAINERS: Add Dialog PMIC search terms for missing documentation and header files

2016-05-11 Thread Steve Twiss
From: Steve Twiss Dialog Semiconductor support would like to follow files by adding to the existing MAINTAINERS search terms. The update will allow us to follow files for PMIC documentation bindings and header files. The full list is: DT bindings - Documentation/devicetree/bindings/input

[PATCH V2] MAINTAINERS: Add Dialog PMIC search terms for missing documentation and header files

2016-05-24 Thread Steve Twiss
From: Steve Twiss Dialog Semiconductor support would like to follow files by adding to the existing MAINTAINERS search terms. The update will allow us to follow files for PMIC documentation bindings and header files. The full list is: DT bindings - Documentation/devicetree/bindings/mfd/da9052

[PATCH V1] rtc: da9063: access ordering error during RTC interrupt system power on

2015-12-08 Thread Steve Twiss
From: Steve Twiss This fix alters the ordering of the IRQ and device registrations in the RTC driver probe function. This change will apply to the RTC driver that supports both DA9063 and DA9062 PMICs. A problem could occur with the existing RTC driver if: A system is started from a cold boot

[PATCH V1] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

2015-12-08 Thread Steve Twiss
From: Steve Twiss Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead This change applied to both DA9063 and DA9062 ONKEY drivers. Signed-off-by: Steve Twiss --- This patch applies against linux-next and v4.4-rc4 Regards, Steve drivers/input/misc/da9063_onkey.c

[PATCH V3 1/2] mfd: da9063: Add device tree support

2015-01-20 Thread Steve Twiss
From: Steve Twiss Add device tree support for DA9063 regulators; Real-Time Clock and Watchdog. This patch is dependent on PATCH V2 2/2 Signed-off-by: Steve Twiss --- This patch applies against linux-next and v3.19-rc4 drivers/mfd/da9063-core.c | 2 ++ drivers/mfd/da9063-i2c.c

[PATCH V3 2/2] devicetree: Add bindings for DA9063

2015-01-20 Thread Steve Twiss
From: Steve Twiss Add device tree bindings for DA9063 regulators; Real-Time Clock and Watchdog. This patch is dependent on PATCH V2 1/2 Signed-off-by: Steve Twiss --- This patch applies against linux-next and v3.19-rc4 Documentation/devicetree/bindings/mfd/da9063.txt | 93

[PATCH V3 0/2] Add device tree support for DA9063

2015-01-20 Thread Steve Twiss
From: Steve Twiss This patch set adds device tree support for the Dialog Semiconductor DA9063 PMIC. Support is provided for the Regulators; Real-Time Clock and Watchdog. [PATCH V2 1/2]: kernel driver device tree support [PATCH V2 2/2]: device tree bindings document Change History: [PATCH V3

[PATCH V1] mfd: da9063: remove unused struct da9063_irq_data and define EVENTS_BUF_LEN

2016-04-05 Thread Steve Twiss
From: Steve Twiss The structure da9063_irq_data and define EVENTS_BUF_LEN are not used, so remove the redundant entries. Signed-off-by: Steve Twiss --- This patch applies against linux-next and next-20160405 Regards, Steve drivers/mfd/da9063-irq.c | 6 -- 1 file changed, 6 deletions

[PATCH V1 2/2] regulator: da9053: Add regulator support for DA9053 BB silicon

2015-10-08 Thread Steve Twiss
From: Steve Twiss Provide an additional case entry for DA9053_BC in the find_regulator_info() function in order to support BB type silicon for the DA9053 device. Signed-off-by: Steve Twiss --- This patch applies against linux-next and v4.3-rc4 drivers/regulator/da9052-regulator.c | 1 + 1

[PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

2015-10-08 Thread Steve Twiss
From: Steve Twiss Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into the register header file. - DA9052_GPIO_8_9_REG25 - DA9052_GPIO_10_11_REG 26 - DA9052_GPIO_12_13_REG 27 A modification is also made to the MFD core code to define these registers as readable and

[PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

2015-10-08 Thread Steve Twiss
From: Steve Twiss Two patches to add missing registers and add support for DA9053-BB silicon in the regulators component. These patches modify existing files for the Dialog Power Management IC driver for the DA9052/53 devices. In this patch set the following is provided: - [PATCH V1 1/3

RE: [PATCH] regulator: da9052: Include linux/of.h to fix build warning for of_match_ptr

2019-03-18 Thread Steve Twiss
nings when !CONFIG_OF. > > Reported-by: kbuild test robot > Signed-off-by: Axel Lin Thanks! Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 2/2] regulator: da9055: Convert to regulator core's simplified DT parsing code

2019-03-18 Thread Steve Twiss
Hi Mark, For the DA9055, I have spoken with the management here. Dialog Semiconductor are "no longer building the DA9055"; the device doesn't appear on the support portal or website and; I have been told, "you can remove [it] from your list of supported products". But, as always: I realise that t

[PATCH] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
that case, -22 is expected as the return value, not 0. Fixes: 9243a195be7a ("regulator: core: Change voltage setting path") Signed-off-by: Steve Twiss --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regula

RE: [PATCH] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
Hi Dmitry, Thanks, On 18 March 2019 16:03, Dmitry Osipenko wrote: > Subject: Re: [PATCH] regulator: core: fix error path for > regulator_set_voltage_unlocked > > 18.03.2019 18:32, Steve Twiss пишет: > > During several error paths in the function > > regulator_set_volt

[PATCH v2] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
that case, -22 is expected as the return value, not 0. Fixes: 9243a195be7a ("regulator: core: Change voltage setting path") Cc: stable Signed-off-by: Steve Twiss --- drivers/regulator/core.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/regulator

RE: [PATCH v2] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
On 18 March 2019 16:41, Dmitry Osipenko wrote: > Subject: Re: [PATCH v2] regulator: core: fix error path for > regulator_set_voltage_unlocked [...] > Reviewed-by: Dmitry Osipenko Thanks Dmitry. Regards, Steve

[PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Steve Twiss
delays in this case). This patch fixes the network problems seen on the Freescale i.MX6Q/DL SABRE boards and makes a difference when correctly loading the NFS rootfs on startup. Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazz...@free-electrons.com Tested-by: Steve Tw

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Steve Twiss
Hi Fabio, On 20 March 2019 12:17, Fabio Estevam wrote: > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > Hi Steve, > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss > wrote: > > > > The PHY used on the Freescale i.MX6

RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Steve Twiss
gl->info; > int n, tval; > > - for (n = 0; n < rinfo->n_current_limits; n++) { > + for (n = rinfo->n_current_limits - 1; n >= 0; n--) { > tval = rinfo->current_limits[n]; > if (tval >= min_uA && tval <= max_uA) > return regmap_field_write(regl->ilimit, n); Acked-by: Steve Twiss

RE: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Steve Twiss
nfo = regl->info; > int n, tval; > > - for (n = 0; n < rinfo->n_current_limits; n++) { > + for (n = rinfo->n_current_limits - 1; n >= 0; n--) { > tval = rinfo->current_limits[n]; > if (tval >= min_ua && tval <=

RE: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions

2019-03-29 Thread Steve Twiss
--- > 1 file changed, 65 deletions(-) > delete mode 100644 include/linux/mfd/da9063/pdata.h > > diff --git a/include/linux/mfd/da9063/pdata.h Thanks! Acked-by: Steve Twiss Tested-by: Steve Twiss Regards, Steve

RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode

2019-04-01 Thread Steve Twiss
phy-mode = "rgmii-id"; > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > status = "okay"; > }; [...] This patch looks surprisingly similar to this one ;) https://lore.kernel.org/patchwork/patch/1052588/ Link: https://lkml.kernel.org/r/1397

[PATCH] mfd: da9063: Fix OTP control register names to match datasheets for DA9063/63L

2019-04-26 Thread Steve Twiss
of CONT (i.e. control). Cc: Stable Signed-off-by: Steve Twiss --- include/linux/mfd/da9063/registers.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/mfd/da9063/registers.h b/include/linux/mfd/da9063/registers.h index 5d42859..844fc29 100644 --- a

RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

2019-08-07 Thread Steve Twiss
Hi Paul, I will not be able to make these changes to support modularity any more. Although the support.opensou...@diasemi.com e-mail address for Support is still working, I will not be able to review your patches if you were to re-send them again. Regards, Stephen On 07 December 2018 20:30, Pa

RE: [PATCH] mfd: da9063: remove now unused platform_data

2019-07-23 Thread Steve Twiss
igned-off-by: Wolfram Sang > --- > include/Kbuild | 1 - > include/linux/mfd/da9063/pdata.h | 60 > 2 files changed, 61 deletions(-) > delete mode 100644 include/linux/mfd/da9063/pdata.h Acked-by: Steve Twiss Regards, Steve

RE: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value

2019-06-18 Thread Steve Twiss
Hi Felix, On 18 June 2019 12:08 Felix Riemann wrote: > Subject: AW: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum > value > > Hi Steve, > > A colleague told me that he saw our mail server mix-up whitespaces in text > mails > before, although the copy that got relayed back to

[PATCH V2] regulator: da9061/62: Adjust LDO voltage selection minimum value

2019-06-19 Thread Steve Twiss
orrect calculaton for the n_voltages value in the regulator LDO2. These fixes effect all LDO regulators for DA9061 and DA9062. Acked-by: Steve Twiss Tested-by: Steve Twiss Signed-off-by: Felix Riemann --- Hi Felix, I have taken your previous patch, fixed the whitespace like we discussed and u

[PATCH V3] regulator: da9061/62: Adjust LDO voltage selection minimum value

2019-06-19 Thread Steve Twiss
orrect calculaton for the n_voltages value in the regulator LDO2. These fixes effect all LDO regulators for DA9061 and DA9062. Acked-by: Steve Twiss Tested-by: Steve Twiss Signed-off-by: Steve Twiss Signed-off-by: Felix Riemann --- Hi Mark, I've added my signed-off tag to the commit

RE: [PATCH] regulator: da9062: Simplify the code iterating all regulators

2019-07-11 Thread Steve Twiss
On 11 July 2019 12:47, Axel Lin wrote: > To: Steve Twiss; Support Opensource; Liam Girdwood; > linux-kernel@vger.kernel.org > Cc: Axel Lin > Subject: [PATCH] regulator: da9062: Simplify the code iterating all regulators > > It's more straightforward to use for state

RE: [PATCH] regulator: da9063: Use struct_size() in devm_kzalloc()

2019-02-25 Thread Steve Twiss
ese open-coded and prone to type mistakes, we can > now use the new struct_size() helper: Acked-by: Steve Twiss Thanks, Regards, Steve

RE: [PATCH] regulator: da9062: Use struct_size() in devm_kzalloc()

2019-02-25 Thread Steve Twiss
ese open-coded and prone to type mistakes, we can > now use the new struct_size() helper: Acked-by: Steve Twiss Thanks, Regards, Steve > > instance = alloc(struct_size(instance, entry, count), GFP_KERNEL) > > Notice that, in this case, variable size is not necessary, hence i

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Steve Twiss
Hi Fabio, On 21 March 2019 11:17, Fabio Estevam, > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-22 Thread Steve Twiss
Here are my thoughts. On 22 March 2019 10:21, Michal Vokáč wrote: > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > On 22. 03. 19 3:24, Fabio Estevam wrote: > > On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo wrote: > > > >>> Unfortunately, just by looking at

RE: [PATCH 1/2] regulator: da9062: Convert to use regulator_set/get_current_limit_regmap

2019-03-05 Thread Steve Twiss
Hi Axel, On 04 March 2019 13:16, Axel Lin wrote: > Subject: [PATCH 1/2] regulator: da9062: Convert to use > regulator_set/get_current_limit_regmap > > Use regulator_set/get_current_limit_regmap helpers to save some code. Thanks again, Acked-by: Steve Twiss Regards, Steve ps.

RE: [PATCH 2/2] regulator: da9063: Convert to use regulator_set/get_current_limit_regmap

2019-03-05 Thread Steve Twiss
--- > drivers/regulator/da9063-regulator.c | 107 +++ > 1 file changed, 28 insertions(+), 79 deletions(-) Thanks again, Acked-by: Steve Twiss Regards, Steve ps. This patch applies to next-20190305. But doesn't cleanly apply cleanly to v5.0, I guess because t

[PATCH 11/13] regulator: wm831x: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: e4ee831f949a ("regulator: Add WM831x DC-DC buck convertor support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/wm831x-

[PATCH 00/13] Fix backtrace warnings from bad notifier chain calls

2019-03-05 Thread Steve Twiss
while, but the API I have used used here to fix it (i.e. regulator_lock()/regulator_unlock()) has only been in the kernel since v4.18. Therefore as this fix stands, the patches do not port back very far in kernel history. Regards, Steve Steve Twiss (13): regulator: da9055: Fix notifier mutex

[PATCH 12/13] regulator: wm831x isink: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: d4d6b722e780 ("regulator: Add WM831x ISINK support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/wm831x-isink.c | 2

  1   2   3   4   5   >