Re: [PATCHv3 linux-next] hrtimer: Add notifier when clock_was_set was called

2013-08-14 Thread Sergei Shtylyov
Hello. On 08/14/2013 12:52 PM, Fan Du wrote: From e3929d4fdfad5b40fd8cad0e217597670d1aef54 Mon Sep 17 00:00:00 2001 From: Fan Du Date: Wed, 14 Aug 2013 16:39:23 +0800 Subject: [PATCHv3 linux-next] hrtimer: Add notifier when clock_was_set was called This header is not needed. When cloc

Re: [PATCH] drivers/net/ethernet/via/via-velocity.c: update napi implementation

2013-08-14 Thread Sergei Shtylyov
Hello. On 08/14/2013 06:26 PM, Julia Lawall wrote: From: Julia Lawall Drivers supporting NAPI should use a NAPI-specific function for receiving packets. Hence netif_rx is changed to netif_receive_skb. Furthermore netif_napi_del should be used in the probe and remove function to clean up

Re: [PATCH v4 4/5] ARM: davinci: da850: add DT node for eth0.

2013-08-15 Thread Sergei Shtylyov
Hello. On 15-08-2013 10:01, Lad, Prabhakar wrote: From: "Lad, Prabhakar" Add eth0 device tree node information and pinmux for mii to da850 by providing interrupt details and local mac address of eth0. Signed-off-by: Lad, Prabhakar [...] @@ -226,6 +242,20 @@ #s

Re: [PATCH v4 5/5] ARM: davinci: da850: add OF_DEV_AUXDATA entry for eth0.

2013-08-15 Thread Sergei Shtylyov
Hello. On 15-08-2013 10:01, Lad, Prabhakar wrote: From: "Lad, Prabhakar" Add OF_DEV_AUXDATA for eth0 driver in da850 board dt file to use emac clock. Signed-off-by: Lad, Prabhakar [...] diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c index d172563..c

Re: [PATCH] bond: Don't set skb->queue_mapping in netpoll.

2013-08-15 Thread Sergei Shtylyov
On 08/15/2013 12:36 PM, Tao Ma wrote: From: Tao Ma When we are using netpoll, we don't go through the normal transmit process. In this case, bond_select_queue is not called and qdisc_skb_cb(skb)->slave_dev_queue_mapping isn't set. So when netpoll_send_skb_on_dev calls ndo_start_xmit and w

Re: [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet

2013-08-16 Thread Sergei Shtylyov
Hello. On 08/16/2013 06:11 PM, Lad, Prabhakar wrote: From: "Lad, Prabhakar" Add ethernet device tree node information and pinmux for mii to da850 by providing interrupt details and local mac address. Signed-off-by: Lad, Prabhakar --- arch/arm/boot/dts/da850-evm.dts |5 + arch

Re: [PATCH] USB: musb: Avoid null pointer dereference in debug logging

2013-08-18 Thread Sergei Shtylyov
Hello. On 18-08-2013 20:21, Maarten ter Huurne wrote: Since commit 511f3c53 usb_gadget_remove_driver will pass NULL for the Please also specify that commit's summary line in parens. driver argument. Signed-off-by: Maarten ter Huurne --- drivers/usb/musb/musb_gadget.c | 3 ++- 1 fi

Re: [PATCH 4/6 v2] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource

2013-08-19 Thread Sergei Shtylyov
Hello. On 08/19/2013 03:47 PM, Julia Lawall wrote: From: Julia Lawall Remove unneeded error handling on the result of a call to platform_get_resource_byname when the value is passed to devm_ioremap_resource. A simplified version of the semantic patch that makes this change is as follows:

Re: [PATCH] net: cpsw: Add support for wake-on-lan for cpsw

2013-08-19 Thread Sergei Shtylyov
Hello. On 08/19/2013 02:13 PM, ujhely...@gmail.com wrote: From: Matus Ujhelyi Signed-off-by: Matus Ujhelyi --- drivers/net/ethernet/ti/cpsw.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.

Re: [PATCH] Fix stack corruption on some architectures

2013-08-19 Thread Sergei Shtylyov
Hello. On 08/20/2013 12:37 AM, Daniel Gimpelevich wrote: There is no need to get an interface specification if we know it's the wrong one; trivial change. Is it related to stack corruption? If not, it's asking to be in a separate patch. The big thing, though, was explained in the #mips

Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces

2013-07-14 Thread Sergei Shtylyov
Hello. On 07/14/2013 12:12 PM, Lars-Peter Clausen wrote: And are you sure you want to control this through sysfs? There's no other better user/kernel apis for it? I found none, besides ioctl(), as the device driven is rather unique. But I thought that sysfs is "ioctl() today", so I we

Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-16 Thread Sergei Shtylyov
Hello. On 16-07-2013 9:18, Xiaotian Feng wrote: commit b29900e6 introuded a regression, which resulted Null pointer Please also specify that commit's summary in parens. dereference for achi host with dummy ports. For ahci ports, when the port is dummy port, its private_data will be NULL,

Re: [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree

2013-07-16 Thread Sergei Shtylyov
Hello. On 07/16/2013 03:34 PM, Oleksandr Kozaruk wrote: GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk --- arch/arm/boot/dts/twl6030.dtsi | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH v5 1/2] ARM: dts: twl: Add GPADC data to device tree

2013-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2013 15:12, Oleksandr Kozaruk wrote: GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk --- arch/arm/boot/dts/twl6030.dtsi | 6 ++ 1 file changed, 6 insertions(+) dif

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-27 Thread Sergei Shtylyov
On 27-07-2013 12:58, Prashant Shah wrote: It's also called managed device API. In fact, I've never heard it named devres API. If I understood it correctly it has to just calls devm_request_region() with the struct device pointer and there are no deallocation functions to call ? It manages

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Sergei Shtylyov
Hello. On 29-07-2013 16:17, Rafael J. Wysocki wrote: [...] @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de [] if (device->parent && (state < device->parent->power.state)) { - printk(KERN_WARNING PREFIX - "Cannot set device to

Re: [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options to the DTSI

2013-07-30 Thread Sergei Shtylyov
Hello. On 07/30/2013 06:59 PM, Maxime Ripard wrote: The UARTs on the A20 can be muxed to several pins. Add a few options to the DTSI so that we can start using them in the boards' DT. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun7i-a20.dtsi | 21 + 1 file cha

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Sergei Shtylyov
Hello. On 07/31/2013 09:42 PM, Tuomas Tynkkynen wrote: From: Mikko Perttunen Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. I would have done the board patch separately from the SoC one. Signed-off-by: Mikko Per

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Sergei Shtylyov
Hello. On 07/31/2013 11:31 PM, Tuomas Tynkkynen wrote: From: Mikko Perttunen Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. I would have done the board patch separately from the SoC one. Signed-off-by: Mikko

Re: [PATCH] dma: add driver for R-Car HPB-DMAC

2013-07-31 Thread Sergei Shtylyov
Hello. On 07/29/2013 07:05 PM, Vinod Koul wrote: +config RCAR_HPB_DMAE + tristate "Renesas R-Car HPB DMAC support" + depends on SH_DMAE_BASE you should select DMA stuff here CONFIG_DMAENGINE is already selected by CONFIG_SH_DMAE_BASE. +#define DSAR0 0x00 +#define

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Sergei Shtylyov
On 08/01/2013 02:06 AM, Stephen Warren wrote: Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index abf6c40..2905145 100644 --- a/arch/arm/boo

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-01 Thread Sergei Shtylyov
Hello. On 01-08-2013 3:29, Stephen Warren wrote: Don't they cause numerous resource conflicts while device nodes being instantiated as the platform devices? No; the driver knows that the HW is screwy and there's lots of register-range sharing going on, so it simply maps the registers, r

Re: [PATCH] macvlan: validate flags

2013-08-01 Thread Sergei Shtylyov
Hello. On 01-08-2013 14:48, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a Please also specify that commit's summary line in parens. This is the only way to uniquely identify the commit, and it's the requirement that came originally from Linus AFAIK. added a

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Sergei Shtylyov
Hello. On 08/01/2013 07:56 PM, Alan Stern wrote: What happens if uclk isn't found but it is needed? It will not fail but I guess the usb host won't work as the clock won't be correctly configured. I agree with you: this is not a good solution. Another option is to keep the previous ver

Re: [PATCH v2 3/5] devicetree: create a separate binding description for sata_highbank

2013-08-02 Thread Sergei Shtylyov
On 08/02/2013 08:28 PM, Mark Langsdorf wrote: The Calxeda sata_highbank driver has been adding its descriptions to the ahci driver. Separate them properly. Signed-off-by: Mark Langsdorf Acked-by: Rob Herring [...] diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Do

Re: [PATCH net-next v3] net: cpsw: Add support for wake-on-lan for cpsw

2013-08-20 Thread Sergei Shtylyov
Hello. On 20-08-2013 9:38, ujhely...@gmail.com wrote: From: Matus Ujhelyi Some phy's can be configured to enable wake on lan (e.g. at803x or marvell 88E1318S). There is no way how to enable wol on CPSW with such connected phys. This patch adds this support. It is provided by calling the ph

Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

2013-08-22 Thread Sergei Shtylyov
Hello. On 08/22/2013 08:38 PM, Rupesh Gujare wrote: Currently we call oz_pd_destroy() from softirq context, where we try to destroy relevant data structures, as well we kill a tasklet which always result in following kernel warning. [12279.262194] Attempt to kill tasklet from interrupt [1227

Re: [PATCH] ARM: dts: add AM33XX EDMA support

2013-08-24 Thread Sergei Shtylyov
Hello. On 08/23/2013 11:06 PM, Sebastian Andrzej Siewior wrote: From: Matt Porter Adds AM33XX EDMA support to the am33xx.dtsi as documented in Documentation/devicetree/bindings/dma/ti-edma.txt Joel: Drop DT entries that are non-hardware-description for now as discussed in [1] [1] htt

Re: [PATCH] ARM: dts: add AM33XX EDMA support

2013-08-24 Thread Sergei Shtylyov
Hello. On 08/24/2013 10:33 PM, Joel Fernandes wrote: Updating CC with Matt's current email address. From: Matt Porter Adds AM33XX EDMA support to the am33xx.dtsi as documented in Documentation/devicetree/bindings/dma/ti-edma.txt Joel: Drop DT entries that are non-hardware-description

[PATCH v3] dma: add driver for R-Car HPB-DMAC

2013-08-24 Thread Sergei Shtylyov
driver', fixed guard macro name in the header file, fixed #define ASYNCRSTR_ASRST20, added #define ASYNCRSTR_ASRST24, added the necessary runtime PM calls to the probe() and remove() methods, handled errors returned by dma_async_device_register(), beautified comments and #define's.] Signed-

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Sergei Shtylyov
Hello. On 08/06/2013 10:08 PM, Tuomas Tynkkynen wrote: The Tegra30 EHCI controller is mostly compatible with the Tegra20 controller, except Tegra30 includes the HOSTPC register extension. The has_hostpc capability bit must be set in the ehci_hcd structure if the controller has such extensions.

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Sergei Shtylyov
Hello. On 08/06/2013 11:16 PM, Tuomas Tynkkynen wrote: [...] + match = of_match_device(tegra_ehci_of_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } + soc_config = (struct t

Re: [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008

2013-08-08 Thread Sergei Shtylyov
Hello. On 08/08/2013 10:56 AM, Wei Ni wrote: Enable thermal sensor nct1008 for t114 dalmore. Signed-off-by: Wei Ni --- arch/arm/boot/dts/tegra114-dalmore.dts | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/a

Re: [PATCH] dma: add driver for R-Car HPB-DMAC

2013-07-18 Thread Sergei Shtylyov
, fixed #define ASYNCRSTR_ASRST20, added #define ASYNCRSTR_ASRST24, beautified some commets.] Signed-off-by: Sergei Shtylyov Please don't quote the text you're not replying to, else it makes me scroll and scroll and scroll in search of your remarks (and then remove the unanswered text myself).

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Sergei Shtylyov
Hello. On 19-07-2013 16:34, George Cherian wrote: Add phy nodes for AM33XX platform and split the musb nodes per instance. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: George Cherian --- arch/arm/boot/dts/am33xx.dtsi | 68 +-- 1 file ch

Re: [PATCH] sysctl net: Keep tcp_syn_retries inside the boundary

2013-07-19 Thread Sergei Shtylyov
Hello. On 19-07-2013 14:47, Michal Tesar wrote: Limit the min/max value passed to the /proc/sys/net/ipv4/tcp_syn_retries. Signed-off-by: Michal Tesar --- net/ipv4/sysctl_net_ipv4.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/net/ipv4/sysctl_net_ipv4.c

Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree

2013-07-19 Thread Sergei Shtylyov
Hello. On 19-07-2013 13:27, Oleksandr Kozaruk wrote: GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk --- arch/arm/boot/dts/twl6030.dtsi | 6 ++ 1 file changed, 6 insertions(+) dif

Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree

2013-07-19 Thread Sergei Shtylyov
Hello. On 07/19/2013 07:40 PM, Grygorii Strashko wrote: GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk --- arch/arm/boot/dts/twl6030.dtsi | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-19 Thread Sergei Shtylyov
Hello. On 07/19/2013 06:20 PM, Sebastian Andrzej Siewior wrote: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..e3890c4 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -326,21 +326,59 @@ status = "disable

Re: [PATCH] xen/arm and xen/arm64: update xen_restart after ff701306cd49

2013-07-21 Thread Sergei Shtylyov
Hello. On 21-07-2013 19:24, Stefano Stabellini wrote: Commit ff701306cd49 changes the prototype of arm_pm_restart. Please also specify the summary line of that commit in parens. Update xen_restart accordingly. Signed-off-by: Stefano Stabellini WBR, Sergei -- To unsubscribe from th

Re: [PATCH 15/16] dmaengine: add transfered member to dma_async_tx_descriptor

2013-07-22 Thread Sergei Shtylyov
On 07/22/2013 10:10 PM, Sebastian Andrzej Siewior wrote: In USB RX path it is possible that the we receive less bytes than requested. Take the following example: The driver for USB-to-UART submits an URB with 256 bytes in size and the dmaengine driver in turn programs a transfer of 256 bytes. Th

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Sergei Shtylyov
Hello. On 23-07-2013 11:15, Jason Wang wrote: Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: restore vlan header on user read). This patch adds hardware vlan tx support for tuntap. This is done by copying vlan header directly into userspace in tun_put_user() instead of do

Re: [PATCH net-next 2/2] sysctl: range checking in do_proc_dointvec_ms_jiffies_conv

2013-07-24 Thread Sergei Shtylyov
Hello. On 24-07-2013 12:39, Francesco Fusco wrote: When (integer) sysctl values are expressed in ms and have to be represented internally as jiffies. The msecs_to_jiffies function returns an unsigned long, which gets assigned to the integer. This patch prevents the value to be assigned if bigge

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Sergei Shtylyov
On 07/25/2013 08:26 PM, Ivan T. Ivanov wrote: From: "Ivan T. Ivanov" When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving th

Re: [PATCH] Change request_irq() to use struct net_device *dev->name

2013-07-25 Thread Sergei Shtylyov
Hello. On 07/25/2013 10:31 PM, Andy Shevchenko wrote: Andy, I can't find a single example of a devres_* call in drivers/net/ethernet/*. Does any networking code exist that we can look at as an example for conversion to the devres API? devres API usually means managed version of the functi

Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED

2013-08-09 Thread Sergei Shtylyov
Hello. On 08/09/2013 10:25 PM, Kumar Gaurav wrote: Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue of more than 80 chars on single line by sliting the line in two. That's clearly a material for 2 separate patches. Signed-off-by: Kumar Gaurav --- drivers/net/et

Re: [PATCH] usb: musb: am335x: Do not remove the session bin HOST-only mode

2013-08-09 Thread Sergei Shtylyov
Hello. On 08/09/2013 08:03 PM, Sebastian Andrzej Siewior wrote: This is what I observe: On the first connect, the musb starts with DEVCTL.Session set. On disconnect, musb_core calls try_idle. That functions removes the Session bit signalize that the session is over (something that only in OTG i

Re: [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

2013-08-12 Thread Sergei Shtylyov
Hello. On 08/12/2013 05:24 PM, Libo Chen wrote: Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/net/ethe

Re: [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()

2013-08-12 Thread Sergei Shtylyov
On 08/12/2013 05:24 PM, Libo Chen wrote: Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- .../net/ethernet/freesca

Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

2013-08-12 Thread Sergei Shtylyov
On 08/12/2013 05:25 PM, Libo Chen wrote: Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/net/ethernet/ti/

Re: [PATCH net-next 2/3] net/usb/r8152: enable tx checksum

2013-08-13 Thread Sergei Shtylyov
Hello. On 08/13/2013 11:28 AM, Hayes Wang wrote: Enable tx checksum. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 63 + 1 file changed, 58 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8

Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take a struct pointer.

2013-08-13 Thread Sergei Shtylyov
Hello. On 08/13/2013 09:29 PM, Rupesh Gujare wrote: oz_hcd_pd_departed() takes struct oz_port pointer instead of void *, change function declaration to avoid ambiguity. Reported-by: Dan Carpenter Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |4 ++-- drivers/stagin

Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take a struct pointer.

2013-08-13 Thread Sergei Shtylyov
On 08/13/2013 09:40 PM, Rupesh Gujare wrote: oz_hcd_pd_departed() takes struct oz_port pointer instead of void *, change function declaration to avoid ambiguity. Reported-by: Dan Carpenter Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |4 ++-- drivers/staging/ozwpan

Re: [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig

2013-03-01 Thread Sergei Shtylyov
Hello. On 01-03-2013 5:32, Aaron Lu wrote: ODD is not a common TLA for non-ATA people so they will get confused by its meaning when they are configuring the kernel. This patch fixed this problem by using ODD only after stating what it is. Signed-off-by: Aaron Lu --- drivers/ata/Kconfig |

Re: [PATCH] : fix compilation warnings with DT disabled

2013-03-01 Thread Sergei Shtylyov
help... Reported-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman Grant, could you consider taking this patch? Yes, I can, but I don't seem to have the original patch. Can you send it again. Nevermind. Found it. I'll apply it. Wil

Re: [PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread Sergei Shtylyov
Hello. On 04-03-2013 12:22, Hannes Reinecke wrote: xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. Cc: Bjorn Helgaas Cc: Oliver Neukum

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Sergei Shtylyov
Hello. On 03/04/2013 07:14 PM, Thomas Renninger wrote: From: Hannes Reinecke xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. v3: Be care

Re: [PATCH v2 7/8] ARM: dts: omap5: add dwc3 omap dt data

2013-03-05 Thread Sergei Shtylyov
Hello. On 05-03-2013 18:37, Kishon Vijay Abraham I wrote: Add dwc3 omap glue data to the omap5 dt data file. The information about the dt node added here is available @ Documentation/devicetree/bindings/usb/omap-usb.txt Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dts

Re: [PATCH] IDE: bugfix of IDE PIO size calculation

2013-05-10 Thread Sergei Shtylyov
Hello. On 05/10/2013 10:47 PM, Leonid Yegoshin wrote: IDE PIO calculates size wrong. Proven by test on MIPS Malta platform with multiple CPU types with bootparam flag "ide-core.nodma=0.0". It is still needed to test non-DMA IO. Change-Id: Id82c2bc5965d85960846db53d84846d9a05d75a3 Please

Re: [PATCH] igb: add a method to get the nic hw time stamping policy

2013-05-11 Thread Sergei Shtylyov
Hello. On 11-05-2013 18:02, Dong Zhu wrote: From e6a55411486de8a09b859e73140bf35c0ee36047 Mon Sep 17 00:00:00 2001 From: Dong Zhu Date: Sat, 11 May 2013 21:44:54 +0800 Subject: [PATCH] igb: add a method to get the nic hw time stamping policy Please, don't send this header with your patch

Re: [PATCH v6, part3 15/16] mm: report available pages as "MemTotal" for each NUMA node

2013-05-11 Thread Sergei Shtylyov
Hello. On 05/11/2013 09:34 PM, Jiang Liu wrote: I've noticed a small typo in the changelog. As reported by https://bugzilla.kernel.org/show_bug.cgi?id=53501, "MemTotal" from /proc/meminfo means memory pages managed by the buddy system (managed_pages), but "MemTotal" from /sys/.../node/nodex

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-11 Thread Sergei Shtylyov
Hello. On 05/10/2013 03:07 PM, Sergei Shtylyov wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang Acked-by: Sergei Shtylyov I was too fast, I'm now withdawing my ACK. WBR, Sergei

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-11 Thread Sergei Shtylyov
Hello. On 05/10/2013 12:17 PM, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/net/ethernet/renesas/sh_eth.c | 14 +- 1 file changed, 1 insertion(+), 13 deleti

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-12 Thread Sergei Shtylyov
Hello. On 12-05-2013 13:42, Wolfram Sang wrote: You should really compile-test your patches. Easier said than done with a cleanup series touching various platforms and architectures. If there are already solutions how to find a .config compiling the source file modified, I am all ears.

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-12 Thread Sergei Shtylyov
Hello. On 05/12/2013 08:32 PM, Wolfram Sang wrote: You can always try to do: $ make drivers/net/ethernet/renesas/sh_eth.o with a .config file you have. It will compile a file regardless of whether it's enabled in your .config or not... Been there. This mainly works for platform indepen

Re: [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

2013-05-12 Thread Sergei Shtylyov
Hello. On 05/12/2013 07:56 PM, Laurent Navet wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet --- drivers/net/ethernet/broa

Re: [GIT] Networking

2013-05-13 Thread Sergei Shtylyov
Hello. On 05/14/2013 12:08 AM, David Miller wrote: Several small bug fixes all over: [...] 13) Fix bogus PCI resource management in 3c59x driver, from Sergei Shtylyov. I must note that this coming August I will be celebrating 7 (!) years from the original posting of that patch

Re: [PATCH] usb: omap2430: fix memleak in err case

2013-05-15 Thread Sergei Shtylyov
Hello. On 15-05-2013 5:35, Libo Chen wrote: when omap_get_control_dev fail, we should release relational platform_device s/fail/fails/, s/relational/related/? Signed-off-by: Libo Chen You've posted this to the wrong mailing list, linux-mips; devicetree-discuss also seems hardly re

Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface

2013-05-15 Thread Sergei Shtylyov
Hello. On 15-05-2013 16:28, Schmiedl Christian wrote: /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number. Signed-off-by: Hans-Christoph Schemmel gemalto.com> Sign

Re: [PATCH] ARM: davinci: dma: Convert to devm_* api

2013-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2013 10:58, Lad Prabhakar wrote: From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar

Re: [PATCH v4, part3 08/15] mm: fix some trivial typos in comments

2013-04-06 Thread Sergei Shtylyov
Hello. On 06-04-2013 17:55, Jiang Liu wrote: Fix some trivial typos in comments. Signed-off-by: Jiang Liu Cc: Wen Congyang Cc: Tang Chen Cc: Jiang Liu Cc: Yasuaki Ishimatsu Cc: Mel Gorman Cc: Minchan Kim Cc: Marek Szyprowski Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org [.

Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-09 Thread Sergei Shtylyov
Hello. On 09-04-2013 13:21, Vivek Gautam wrote: 7edb3da makes ehci-s5p as a separate driver. But, Please also provide the summary line of that commit in parens. it raised an issue with its driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing

Re: [PATCH] net: mv643xx_eth: use managed devm_kzalloc

2013-04-10 Thread Sergei Shtylyov
Hello. On 04/10/2013 09:38 PM, Sebastian Hesselbarth wrote: This patch moves shared private data kzalloc to managed devm_kzalloc and cleans now unneccessary kfree and error handling. Signed-off-by: Sebastian Hesselbarth --- Note that there is also an ioremap call, that could be transferred to

Re: [PATCH] net: mv643xx_eth: use managed devm_kzalloc

2013-04-10 Thread Sergei Shtylyov
On 04/11/2013 12:17 AM, Sebastian Hesselbarth wrote: This patch moves shared private data kzalloc to managed devm_kzalloc and cleans now unneccessary kfree and error handling. Signed-off-by: Sebastian Hesselbarth --- Note that there is also an ioremap call, that could be transferred to dev

Re: [PATCH] drivers: mtd: nand: davinci: use devm_ioremap_resource()

2013-05-02 Thread Sergei Shtylyov
Hello. On 02-05-2013 17:22, Laurent Navet wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet --- drivers/mtd/nand/dav

Re: [PATCH] media: davinci: vpbe: fix layer availability for NV12 format

2013-05-03 Thread Sergei Shtylyov
Hello. On 03-05-2013 13:53, Prabhakar Lad wrote: From: Lad, Prabhakar For NV12 format, even if display data is single image, both VIDWIN0 and VIDWIN1 parameters must be used. The start address of Y data plane and C data plane is configured in VIDEOWIN0ADH/L and VIDEOWIN1ADH/L respectively.

Re: [GIT PULL] libata maintainership update

2013-05-07 Thread Sergei Shtylyov
Hello. On 07-05-2013 21:19, Tejun Heo wrote: As discussed earlier, Jeff is leaving for something more fun and I'm inheriting the maintainership of libata. Please pull from the following branch to receive MAINTAINERS update. git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-

Re: [PATCH] net: of_mdio: fix behavior on missing phy device

2013-05-07 Thread Sergei Shtylyov
Hello. On 07-05-2013 13:49, Sebastian Hesselbarth wrote: of_mdiobus_register creates a phy_device even if get_phy_device failed to create it previously. This causes indefinite polling on non-existent PHYs. This fix makes of_mdio_register rely on get_phy_device to properly create the device or f

Re: net: phy: realtek: add rtl8201f driver

2013-05-08 Thread Sergei Shtylyov
Hello. On 08-05-2013 14:10, Jongsung Kim wrote: This patch adds the minimal driver to manage the Realtek RTL8201F 10/100Mbps Transceivers. Signed-off-by: Jongsung Kim --- drivers/net/phy/realtek.c | 60 +++- 1 files changed, 53 insertions(+), 7 d

Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init()

2013-05-08 Thread Sergei Shtylyov
Hello. On 08-05-2013 19:51, Jiang Liu wrote: Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu Cc: Yoshinori Sato Cc: Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org --- arch/h8300/mm/init.c | 34 -- 1 file change

Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init()

2013-05-08 Thread Sergei Shtylyov
Hello. On 05/08/2013 08:26 PM, Sergei Shtylyov wrote: Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu Cc: Yoshinori Sato Cc: Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org --- arch/h8300/mm/init.c | 34 -- 1

Re: net: phy: realtek: add rtl8201f driver

2013-05-09 Thread Sergei Shtylyov
Hello. On 09-05-2013 6:35, Jongsung Kim wrote: Removal of unused #define's is a matter of a separate cleanup patch... Sorry. I won't touch them. +static int rtl8201f_ack_interrupt(struct phy_device *phydev) { + int err; + + err = phy_read(phydev, RTL8201F_ISR); Thi

Re: [RFC 17/42] drivers/net/ethernet/renesas: don't check resource with devm_ioremap_resource

2013-05-10 Thread Sergei Shtylyov
Hello. On 10-05-2013 12:17, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang Acked-by: Sergei Shtylyov WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 4/4] net: phy: realtek: cleanup code

2013-05-10 Thread Sergei Shtylyov
Hello. On 10-05-2013 11:29, Jongsung Kim wrote: This patch cleans up the drivers code by: - using a consistent way to reference functions - removing unused macro-definitions - removing unnecessary new-lines - making ack_interrupt functions shorter. Signed-off-by: Jongsung Kim --- drive

Re: [PATCH v3 08/10] usb: phy: tegra: Add error handling & clean up.

2013-05-10 Thread Sergei Shtylyov
Hello. On 05/10/2013 05:54 PM, Venu Byravarasu wrote: Check return values from all GPIO APIs and handle errors accordingly. Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. Signed-off-by: Venu

Re: [PATCH 04/10] usb: musb: ux500: harden checks for platform data

2013-04-23 Thread Sergei Shtylyov
Hello. On 04/23/2013 07:03 PM, Lee Jones wrote: In its current state, the ux500-musb driver uses platform data pointers blindly with no prior checking. If no platform data pointer is passed this will Oops the kernel. In this patch we ensure platform data and board data are present prior to usin

Re: [PATCH 04/10] usb: musb: ux500: harden checks for platform data

2013-04-24 Thread Sergei Shtylyov
Hello. On 24-04-2013 10:53, Lee Jones wrote: struct musb_hdrc_platform_data *plat = dev->platform_data; - struct ux500_musb_board_data *data = plat->board_data; + struct ux500_musb_board_data *data; - param_array = data->dma_rx_param_array; + param_array = (da

Re: [PATCH] AHCI: Make distinct names for ports in /proc/interrupts

2013-04-29 Thread Sergei Shtylyov
Hello. On 29-04-2013 14:12, Alexander Gordeev wrote: Currently all interrupts assigned to AHCI ports show up in '/proc/interrupts' as 'ahci'. This fix adds port numbers as suffixes and hence makes the descriptions distinct. Reported-by: Jan Beulich Signed-off-by: Alexander Gordeev --- dr

Re: [PATCH v2] media: davinci: vpif: align the buffers size to page page size boundary

2013-04-16 Thread Sergei Shtylyov
Hello. On 16-04-2013 14:54, Prabhakar lad wrote: From: Lad, Prabhakar with recent commit with id 068a0df76023926af958a336a78bef60468d2033 Please also specify the summary line of that commit in parens (or however you like). which adds add length check for mmap, the application were f

Re: [PATCH] media: davinci: vpbe: align the buffers size to page page size boundary

2013-04-16 Thread Sergei Shtylyov
On 16-04-2013 15:10, Prabhakar lad wrote: From: Lad, Prabhakar with recent commit with id 068a0df76023926af958a336a78bef60468d2033 Please also specify the summary line of that commit in parens (or however you like). which adds add length check for mmap, the application were failing t

Re: [PATCH 1/5] davinci: net: cpdma: remove unwanted header file incusion and sort thme alphabetically

2013-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2013 11:30, Lad Prabhakar wrote: s/incusion/inclusion/, s/thme/them/ in the subject. Though instead of "them" it would be better to write "headers". From: Lad, Prabhakar Changelog won't hurt here... which unwanted #include's you are removing and why are they unwante

Re: [PATCH 2/5] net: davinci_emac: remove unwanted header inclusion and sort the alphabetically

2013-05-16 Thread Sergei Shtylyov
On 16-05-2013 11:30, Lad Prabhakar wrote: From: Lad, Prabhakar This patch removes unwanted header inclusion Why are they unwanted? and sorts them alphabetically In the subject you typed "the" instead of "them". Signed-off-by: Lad, Prabhakar WBR, Sergei -- To unsubscribe fro

Re: [PATCH 5/5] net: davinci_mdio: trivial cleanup

2013-05-16 Thread Sergei Shtylyov
On 16-05-2013 11:30, Lad Prabhakar wrote: From: Lad, Prabhakar remove unwanted header inclusion and sort the alphabetically s/the/them/. also guard the davinci_mdio_of_mtable table and davinci_mdio_probe_dt() with CONFIG_OF. Saying "also" in the changelog is often a good sign the

Re: [PATCH] : fix compilation warnings with DT disabled

2013-05-16 Thread Sergei Shtylyov
help... Reported-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman Grant, could you consider taking this patch? Yes, I can, but I don't seem to have the original patch. Can you send it again. Nevermind. Found it. I'll apply it. Will you drop 'stru

Re: [PATCH 15/19] drivers/net/irda: add missing platform_driver owner

2013-05-21 Thread Sergei Shtylyov
Hello. On 21-05-2013 6:42, Libo Chen wrote: set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/irda/bfin_sir.c |1 + drivers/net/irda/sh_irda.c|1 + drivers/net/irda/sh_sir.c |1 +

Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

2013-05-21 Thread Sergei Shtylyov
Hello. On 21-05-2013 6:42, Libo Chen wrote: set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/marvell/mvneta.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Sergei Shtylyov
Hello. On 22-05-2013 11:10, Philip Avinash wrote: 1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash --- drivers/gpio/gpio-davinci.c | 182 +++

Re: [PATCH -resend 1/6] mISDN: Add support for group membership check

2013-05-22 Thread Sergei Shtylyov
Hello. On 22-05-2013 16:59, Jiri Slaby wrote: From: Jeff Mahoney This patch adds a module parameter to allow a group access to the mISDN devices. Otherwise, unpriviledged users on systems with ISDN hardware have the ability to dial out, potentially causing expensive bills. Based on a dif

Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread Sergei Shtylyov
Hello. On 23-05-2013 10:01, Ravi Babu wrote: removed unused nop xceiv (un_)register API's from all musb platform drivers Since when are they unused? Signed-off-by: Ravi Babu WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for multi instance

2013-05-23 Thread Sergei Shtylyov
On 23-05-2013 10:01, Ravi Babu wrote: In case of mutli instance support, use get-phy object using phandle to return to repsective phy xceiv object for each instance Only "respective" and s/xceiv/transceiver/. Signed-off-by: Ravi Babu WBR, Sergei -- To unsubscribe from this list: send

<    1   2   3   4   5   6   7   8   9   10   >