Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.

2015-10-05 Thread Sean O. Stalley
On Fri, Oct 02, 2015 at 03:37:54PM -0700, David Daney wrote: ... > +/* > + * Try to assign any resources marked as IORESOURCE_PCI_FIXED, as they > + * are skipped by pbus_assign_resources_sorted(). > + */ > +static void pdev_assign_fixed_resources(struct pci_dev *dev) > +{ > + int i; > + > +

Re: [PATCH v4 3/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.

2015-10-05 Thread Sean O. Stalley
On Fri, Oct 02, 2015 at 08:00:20PM -0700, Yinghai Lu wrote: > On Fri, Oct 2, 2015 at 4:38 PM, David Daney wrote: > > On 10/02/2015 04:14 PM, Yinghai Lu wrote: > >> > >> https://patchwork.kernel.org/patch/7304371/ > >> [v6,06/53] PCI: Claim fixed resource during remove/rescan path > > > > > > This

Re: [PATCH v4 5/5] PCI: Handle Enhanced Allocation (EA) capability for bridges

2015-10-05 Thread Sean O. Stalley
On Fri, Oct 02, 2015 at 03:37:56PM -0700, David Daney wrote: > From: David Daney > > PCI bridges may have their properties be specified via EA entries. > > Extend the EA parser to extract the bridge resources, and modify > pci_read_bridge_{io,mmio,mmio_pref}() to use resources previously > obtai

Re: [PATCH v4 0/5] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-10-05 Thread Sean O. Stalley
On Fri, Oct 02, 2015 at 08:16:48PM -0700, Yinghai Lu wrote: > On Fri, Oct 2, 2015 at 3:37 PM, David Daney wrote: > > From: David Daney > > > > PCI Enhanced Allocation is a new method of allocating MMIO & IO > > resources for PCI devices & bridges. It can be used instead > > of the traditional PCI

Re: [PATCH v4 0/5] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-10-06 Thread Sean O. Stalley
On Mon, Oct 05, 2015 at 06:17:20PM -0700, David Daney wrote: > On 10/05/2015 04:05 PM, Sean O. Stalley wrote: > >On Fri, Oct 02, 2015 at 08:16:48PM -0700, Yinghai Lu wrote: > >>On Fri, Oct 2, 2015 at 3:37 PM, David Daney wrote: > >>>From: David Daney > >>

Re: [PATCH v5 0/4] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-10-14 Thread Sean O. Stalley
Signed-off-by: Sean O. Stalley I tested it out with the QEMU EA Patches here: [https://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg00348.html] Also, I found 1 trivial typo in the commit message of PATCH 1/4: "Signed-off-by: Signed-off-by: David Daney " -Se

Re: [PATCH v6 0/5] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-10-21 Thread Sean O. Stalley
On Wed, Oct 21, 2015 at 10:14:59AM -0500, Bjorn Helgaas wrote: > > Applied to pci/enhanced-allocation for v4.4, thanks, David! > > I tweaked a couple trivial things and added a couple almost trivial patches > on top. Here are the additions; let me know if you see anything wrong. > > Bjorn > T

Re: [PATCH 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-02 Thread Sean O. Stalley
Thanks for taking a look Yinghai. On Tue, Sep 01, 2015 at 04:14:08PM -0700, Yinghai Lu wrote: > On Thu, Aug 20, 2015 at 9:59 AM, Sean O. Stalley > wrote: > > Add support for devices using Enhanced Allocation entries instead of BARs. > > This patch allows the kernel to par

Re: [PATCH 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-02 Thread Sean O. Stalley
On Wed, Sep 02, 2015 at 02:25:50PM -0500, Bjorn Helgaas wrote: > On Wed, Sep 2, 2015 at 12:46 PM, Sean O. Stalley > wrote: > > > Would it be better to modify pci_claim_resource() to support EA instead of > > adding pci_ea_claim_resource()? > > That way, EA entries w

Re: [PATCH 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-02 Thread Sean O. Stalley
On Wed, Sep 02, 2015 at 04:21:59PM -0500, Bjorn Helgaas wrote: > On Wed, Sep 02, 2015 at 01:01:27PM -0700, Sean O. Stalley wrote: > > On Wed, Sep 02, 2015 at 02:25:50PM -0500, Bjorn Helgaas wrote: > > > On Wed, Sep 2, 2015 at 12:46 PM, Sean O. Stalley > > > wrote:

Re: [PATCH 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-03 Thread Sean O. Stalley
On Thu, Sep 03, 2015 at 09:46:54AM -0500, Bjorn Helgaas wrote: > On Wed, Sep 02, 2015 at 05:29:38PM -0700, Sean O. Stalley wrote: > > On Wed, Sep 02, 2015 at 04:21:59PM -0500, Bjorn Helgaas wrote: > > > On Wed, Sep 02, 2015 at 01:01:27PM -0700, Sean O. Stalley wrote: > >

Re: [PATCH v4 0/5] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-10-02 Thread Sean O. Stalley
Hi David, I did a quick look through & overall I what you have done. I will try to find some time to do a full review early next week. Thanks Again, Sean On Fri, Oct 02, 2015 at 03:37:51PM -0700, David Daney wrote: > From: David Daney > > The original patches are from Sean O. St

[PATCH] Read ID & Pointer from PCI Capabilities List in 1 call

2015-04-02 Thread Sean O. Stalley
Reading both fields at the same time lets us parse the list with half the number of configspace reads. Signed-off-by: Sean O. Stalley --- drivers/pci/pci.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 5e3c8e9

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-22 Thread Sean O. Stalley
On Wed, Jul 22, 2015 at 11:55:32AM -0500, Jeremy White wrote: > I privately wrote to the Intel authors of that patch a week ago; I've > publicly included them in this thread as well. As far as I can tell, > they've been silent on this front since November; I fear that they may > have moved on, or

Re: [V2 PATCH 02/10] added media agnostic (MA) USB HCD roothubs

2014-11-12 Thread Sean O. Stalley
. Thanks, Sean O. Stalley On Wed, Nov 12, 2014 at 09:35:42AM +0100, Oliver Neukum wrote: > On Mon, 2014-11-10 at 18:09 -0800, Stephanie Wallick wrote: > > diff --git a/drivers/staging/mausb/drivers/mausb_hub.c > > b/drivers/staging/mausb/drivers/mausb_hub.c > > new file mode 100

Re: [PATCH 05/10] added media specific (MS) TCP drivers

2014-11-12 Thread Sean O. Stalley
ere are no physical MA USB ports in an MA USB host, the host must > > be > > notified via software when a device is connected. > > > > Lastly, the MS driver contains a number of ioctl functions that are used by > > a > > utility to adjust medium-related dr

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-12 Thread Sean O. Stalley
Thanks for reviewing. My responses are inline. Greg has asked that we clean up this code internally before we send out another patchset to the mailing list. I will address the issues you pointed out, but it may be a while before you see another patchset. Thanks Again, Sean On Tue, Nov 11, 2014 a

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-12 Thread Sean O. Stalley
Sorry, for got to respond to a couple comments. See responses below. On Wed, Nov 12, 2014 at 01:40:21PM -0800, Sean O. Stalley wrote: > Thanks for reviewing. My responses are inline. > > Greg has asked that we clean up this code internally before we > send out another patchset to

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-14 Thread Sean O. Stalley
On Wed, Nov 12, 2014 at 05:03:18PM -0500, Alan Stern wrote: > On Wed, 12 Nov 2014, Sean O. Stalley wrote: > > Our plan to support multiple MA devices is to have them all connected > > to the same virtual host controller, so only 1 would be needed. > > > > Woul

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread Sean O. Stalley
s. We won't resubmit the driver until a senior kernel developer has signed off on it. Sincerely, Sean O. Stalley Stephanie S. Wallick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-29 Thread Sean O. Stalley
On Mon, Sep 28, 2015 at 05:10:39PM -0700, David Daney wrote: > From: "Sean O. Stalley" > > Add support for devices using Enhanced Allocation entries instead of BARs. > This patch allows the kernel to parse the EA Extended Capability structure > in PCI configspac

Re: [PATCH v3 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-29 Thread Sean O. Stalley
More responses inline. Thanks again, Sean On Tue, Sep 29, 2015 at 01:25:59PM -0700, David Daney wrote: > Thanks for reviewing the new code. Expect a revised patch soon. Great! Let me know if I can help :) > > Other responses below... > > > On 09/29/2015 12:27 PM, Sea

Re: [PATCH v3 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-30 Thread Sean O. Stalley
On Tue, Sep 29, 2015 at 04:53:20PM -0700, David Daney wrote: > On 09/29/2015 03:47 PM, Sean O. Stalley wrote: > [...] > >>>>diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > >>>>index 6a9a111..7c60b16 100644 > >>>>--- a/drivers/pci/pci.c >

[PATCH v2 0/2] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-09-23 Thread Sean O. Stalley
ver from early testing. Sean O. Stalley (2): PCI: Add Enhanced Allocation register entries PCI: Add support for Enhanced Allocation devices drivers/pci/pci.c | 174 ++ drivers/pci/pci.h | 1 + drivers/pci/probe.c | 3 +

[PATCH v2 1/2] PCI: Add Enhanced Allocation register entries

2015-09-23 Thread Sean O. Stalley
Add registers defined in PCI-SIG's Enhanced allocation ECN. Signed-off-by: Sean O. Stalley --- include/uapi/linux/pci_regs.h | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_r

[PATCH v2 2/2] PCI: Add support for Enhanced Allocation devices

2015-09-23 Thread Sean O. Stalley
Add support for devices using Enhanced Allocation entries instead of BARs. This patch allows the kernel to parse the EA Extended Capability structure in PCI configspace and claim the BAR-equivalent resources. Signed-off-by: Sean O. Stalley --- drivers/pci/pci.c | 174

Re: [PATCH v2 0/2] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-09-23 Thread Sean O. Stalley
On Wed, Sep 23, 2015 at 04:26:56PM -0700, Yinghai Lu wrote: > On Wed, Sep 23, 2015 at 3:27 PM, Sean O. Stalley > wrote: > > PCI Enhanced Allocation is a new method of allocating MMIO & IO > > resources for PCI devices & bridges. It can be used instead > > of the

Re: [PATCH v2 0/2] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-09-24 Thread Sean O. Stalley
; > On 09/23/2015 03:27 PM, Sean O. Stalley wrote: > >PCI Enhanced Allocation is a new method of allocating MMIO & IO > >resources for PCI devices & bridges. It can be used instead > >of the traditional PCI method of using BARs. > > > >EA entries are hardw

[PATCH v2 0/4] mm: add dma_pool_zalloc() & pci_pool_zalloc()

2015-07-31 Thread Sean O. Stalley
s:7 After an hour: [ 3600.951031] alloc_calls:9566, page_allocs:12 After copying 1GB file onto a USB drive: [ 4260.657148] alloc_calls:17225, page_allocs:12 It doesn't look like dma_pool_alloc() calls down to the page allocator very often (at least on my system). Sean O. Sta

[PATCH v2 4/4] coccinelle: mm: scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci

2015-07-31 Thread Sean O. Stalley
add [pci|dma]_pool_zalloc coccinelle check. replaces instances of [pci|dma]_pool_alloc() followed by memset(0) with [pci|dma]_pool_zalloc(). Signed-off-by: Sean O. Stalley --- .../coccinelle/api/alloc/pool_zalloc-simple.cocci | 84 ++ 1 file changed, 84 insertions

[PATCH v2 1/4] mm: Add support for __GFP_ZERO flag to dma_pool_alloc()

2015-07-31 Thread Sean O. Stalley
Currently the __GFP_ZERO flag is ignored by dma_pool_alloc(). Make dma_pool_alloc() zero the memory if this flag is set. Signed-off-by: Sean O. Stalley --- mm/dmapool.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index fd5fe43

[PATCH v2 2/4] mm: Add dma_pool_zalloc() call to DMA API

2015-07-31 Thread Sean O. Stalley
Add a wrapper function for dma_pool_alloc() to get zeroed memory. Signed-off-by: Sean O. Stalley --- Documentation/DMA-API.txt | 7 +++ include/linux/dmapool.h | 6 ++ 2 files changed, 13 insertions(+) diff --git a/Documentation/DMA-API.txt b/Documentation/DMA-API.txt index 5208840

[PATCH v2 3/4] pci: mm: Add pci_pool_zalloc() call

2015-07-31 Thread Sean O. Stalley
Add a wrapper function for pci_pool_alloc() to get zeroed memory. Signed-off-by: Sean O. Stalley --- include/linux/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci.h b/include/linux/pci.h index 755a2cd..e6ec7d9 100644 --- a/include/linux/pci.h +++ b/include/linux

[PATCH 1/2] PCI: Add Enhanced Allocation register entries

2015-08-20 Thread Sean O. Stalley
Add registers defined in PCI-SIG's Enhanced allocation ECN. Signed-off-by: Sean O. Stalley --- include/uapi/linux/pci_regs.h | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_r

[PATCH 2/2] PCI: Add support for Enhanced Allocation devices

2015-08-20 Thread Sean O. Stalley
Add support for devices using Enhanced Allocation entries instead of BARs. This patch allows the kernel to parse the EA Extended Capability structure in PCI configspace and claim the BAR-equivalent resources. Signed-off-by: Sean O. Stalley --- drivers/pci/pci.c | 219

[PATCH 0/2] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-08-20 Thread Sean O. Stalley
entional/ECN_Enhanced_Allocation_23_Oct_2014_Final.pdf Sean O. Stalley (2): PCI: Add Enhanced Allocation register entries PCI: Add parsing of Enhanced Allocation entries drivers/pci/pci.c | 219 ++ drivers/pci/pci.h | 1 + drivers/pci

[PATCH 1/4] mm: Add support for __GFP_ZERO flag to dma_pool_alloc()

2015-07-15 Thread Sean O. Stalley
Currently the __GFP_ZERO flag is ignored by dma_pool_alloc(). Make dma_pool_alloc() zero the memory if this flag is set. Signed-off-by: Sean O. Stalley --- mm/dmapool.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index fd5fe43..449a5d09

[PATCH 4/4] coccinelle: mm: scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci

2015-07-15 Thread Sean O. Stalley
add [pci|dma]_pool_zalloc coccinelle check. replaces instances of [pci|dma]_pool_alloc() followed by memset(0) with [pci|dma]_pool_zalloc(). Signed-off-by: Sean O. Stalley --- .../coccinelle/api/alloc/pool_zalloc-simple.cocci | 84 ++ 1 file changed, 84 insertions

[PATCH 0/4] mm: add dma_pool_zalloc() & pci_pool_zalloc()

2015-07-15 Thread Sean O. Stalley
cing instances of dma_pool_alloc() followed by memset(0) with a single dma_pool_zalloc() call. Sean O. Stalley (4): mm: Add support for __GFP_ZERO flag to dma_pool_alloc() mm: Add dma_pool_zalloc() call to DMA API pci: mm: Add pci_pool_zalloc() call coccinelle: mm: scripts/coccinelle/api/a

[PATCH 3/4] pci: mm: Add pci_pool_zalloc() call

2015-07-15 Thread Sean O. Stalley
Add a wrapper function for pci_pool_alloc() to get zeroed memory. Signed-off-by: Sean O. Stalley --- include/linux/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci.h b/include/linux/pci.h index 755a2cd..e6ec7d9 100644 --- a/include/linux/pci.h +++ b/include/linux

[PATCH 2/4] mm: Add dma_pool_zalloc() call to DMA API

2015-07-15 Thread Sean O. Stalley
Add a wrapper function for dma_pool_alloc() to get zeroed memory. Signed-off-by: Sean O. Stalley --- Documentation/DMA-API.txt | 7 +++ include/linux/dmapool.h | 6 ++ 2 files changed, 13 insertions(+) diff --git a/Documentation/DMA-API.txt b/Documentation/DMA-API.txt index 5208840

Re: [PATCH 1/4] mm: Add support for __GFP_ZERO flag to dma_pool_alloc()

2015-07-15 Thread Sean O. Stalley
Thanks for the review Andrew, my responses are inline. -Sean On Wed, Jul 15, 2015 at 02:29:07PM -0700, Andrew Morton wrote: > On Wed, 15 Jul 2015 14:14:40 -0700 "Sean O. Stalley" > wrote: > > > Currently the __GFP_ZERO flag is ignored by dma_pool_alloc(). > >