[PATCH 0/3] power: bq2415x_charger: Some cleanup

2012-11-26 Thread Sachin Kamat
This series is build tested againt the linux-next tree (20121126) Sachin Kamat (3): power: bq2415x_charger: Remove unneeded version.h inclusion power: bq2415x_charger: Use module_i2c_driver power: bq2415x_charger: Use devm_kzalloc() drivers/power/bq2415x_charger.c | 28

[PATCH 1/3] power: bq2415x_charger: Remove unneeded version.h inclusion

2012-11-26 Thread Sachin Kamat
is not required here. Signed-off-by: Sachin Kamat --- drivers/power/bq2415x_charger.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c index ee842b3..2d1b568 100644 --- a/drivers/power/bq2415x_charger.c

[PATCH 2/3] power: bq2415x_charger: Use module_i2c_driver

2012-11-26 Thread Sachin Kamat
module_i2c_driver() makes the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Sachin Kamat --- drivers/power/bq2415x_charger.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power

[PATCH 3/3] power: bq2415x_charger: Use devm_kzalloc()

2012-11-26 Thread Sachin Kamat
devm_kzalloc is device managed and makes error handling and code cleanup a bit simpler. Signed-off-by: Sachin Kamat --- drivers/power/bq2415x_charger.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power

[PATCH 1/1] f2fs: remove unneeded version.h header file from f2fs.h

2012-11-27 Thread Sachin Kamat
Including is not necessary. Signed-off-by: Sachin Kamat --- fs/f2fs/f2fs.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 7aa70b5..d3f5a70 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -14,7 +14,6 @@ #include #include

Re: [PATCH 3/3] serial: tegra: Convert to devm_ioremap_resource()

2013-03-17 Thread Sachin Kamat
>> There's no need for me to take the patch I think; now that 3.9-rc1 is >> out, the serial and driver core trees all have whatever dependencies >> this series needed, so any patches can go through their usual trees, I >> think... (Sorry, the context of this discussion was little while ago). > > Ok

Re: [PATCH 2/2] extcon: max8997: add missing const

2013-03-18 Thread Sachin Kamat
On 19 March 2013 07:33, Jingoo Han wrote: > Fixed the checkpatch warning as below: > > WARNING: static const char * array should probably be static const char * > const > #163: FILE: drivers/extcon/extcon-max8997.c:163: > +static const char *max8997_extcon_cable[] = { > > Signed-off-by: Jin

[PATCH 1/1] extcon: max77693: Staticize default_init_data

2013-03-18 Thread Sachin Kamat
t_data' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/extcon/extcon-max77693.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c index 8f3c947..7b2e93d 100644 --- a/d

[PATCH 1/5] pinctrl: abx500: Staticize some symbols

2013-03-18 Thread Sachin Kamat
static? drivers/pinctrl/pinctrl-abx500.c:721:5: warning: symbol 'abx500_pin_config_set' was not declared. Should it be static? Signed-off-by: Sachin Kamat Cc: Patrice Chotard --- This series is compile tested against linux-next tree (20130319). --- drivers/pinctrl/pinctrl-abx500.c |

[PATCH 5/5] pinctrl: ab8505: Staticize some symbols

2013-03-18 Thread Sachin Kamat
atic? Signed-off-by: Sachin Kamat Cc: Patrice Chotard --- drivers/pinctrl/pinctrl-ab8505.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ab8505.c b/drivers/pinctrl/pinctrl-ab8505.c index 3a4238e..2841db7 100644 --- a/drivers/pinctrl/pinctrl-ab

[PATCH 2/5] pinctrl: ab8500: Staticize some symbols

2013-03-18 Thread Sachin Kamat
luster' was not declared. Should it be static? Signed-off-by: Sachin Kamat Cc: Patrice Chotard --- drivers/pinctrl/pinctrl-ab8500.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ab8500.c b/drivers/pinctrl/pinctrl-ab8500.c index 3b471d8..

[PATCH 3/5] pinctrl: ab9540: Staticize some symbols

2013-03-18 Thread Sachin Kamat
Fixes the following warnings: drivers/pinctrl/pinctrl-ab9540.c:382:28: warning: symbol 'ab9540alternate_functions' was not declared. Should it be static? drivers/pinctrl/pinctrl-ab9540.c:457:32: warning: symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static? S

[PATCH 4/5] pinctrl: ab8540: Staticize some symbols

2013-03-18 Thread Sachin Kamat
atic? Signed-off-by: Sachin Kamat Cc: Patrice Chotard --- drivers/pinctrl/pinctrl-ab8540.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c index 8ee1e8d..9867535 100644 --- a/drivers/pinctrl/pinctrl-ab

Re: [PATCH v2 1/2] Input: tegra-kbc- Convert to devm_ioremap_resource()

2013-02-03 Thread Sachin Kamat
Hi Greg, On 1 February 2013 15:37, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error

Re: [PATCH V3] regulator: add device tree support for s5m8767

2013-02-03 Thread Sachin Kamat
voltage set/get API's. > > Reviewed-by: Thomas Abraham > Signed-off-by: Amit Daniel Kachhap Tested this patch using [1] on Exynos4412 based Origen board and it works fine. Feel free to add Tested-by: Sachin Kamat if needed. [1] http://patches.linaro.org/14445/ -- With

Re: [PATCH 1/1] irqchip: irq-gic: Fix checkpatch errors

2013-04-02 Thread Sachin Kamat
On 2 April 2013 22:10, Olof Johansson wrote: > On Wed, Mar 13, 2013 at 03:05:15PM +0530, Sachin Kamat wrote: >> Fixes the following errors: >> ERROR: do not initialise statics to 0 or NULL >> ERROR: space required after that ',' (ctx:VxV) >> >> Sig

Re: [PATCH 1/5] pinctrl: abx500: Staticize some symbols

2013-04-03 Thread Sachin Kamat
Hi Linus, On 19 March 2013 13:58, Patrice CHOTARD wrote: > On 03/19/2013 07:31 AM, Sachin Kamat wrote: > >> These symbols are used only in this file. Without this patch >> we get the following warnings: >> drivers/pinctrl/pinctrl-abx500.c:520:5: warning: >> symbol

[PATCH 1/1] regmap: cache: Make regcache_sync_block_raw static

2013-04-04 Thread Sachin Kamat
regcache_sync_block_raw is used only in this file. Hence make it static. Silences the following warning: drivers/base/regmap/regcache.c:608:5: warning: symbol 'regcache_sync_block_raw' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/base/regmap/regcach

[PATCH 2/2] mfd: omap-usb-tll: Convert to devm_ioremap_resource()

2013-04-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/2] mfd: omap-usb-host: Convert to devm_ioremap_resource()

2013-04-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

Failure due to missing (Exynos related) pinctrl patch

2013-01-28 Thread Sachin Kamat
Hi Linus, Kukjin, Patch titled "pinctrl: exynos: change PINCTRL_EXYNOS option" (linux-next commit Id: 7452b64d) which is present in linux-next is missing in the mainline kernel. This patch is required along with the patch "gpio: samsung: fix pinctrl condition for exynos and exynos5440" (mainline c

[PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static

2013-01-29 Thread Sachin Kamat
'max8997_extcon_cable' is used only in this file. Hence make it static. Signed-off-by: Sachin Kamat --- drivers/extcon/extcon-max8997.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c ind

[PATCH 2/3] extcon: max8997: Remove unreachable code

2013-01-29 Thread Sachin Kamat
'break' after 'return' is never executed and hence can be deleted. Signed-off-by: Sachin Kamat --- drivers/extcon/extcon-max8997.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c in

[PATCH 3/3] extcon: max77693: Make max77693_extcon_cable static

2013-01-29 Thread Sachin Kamat
'max77693_extcon_cable' is used only in this file. Hence make it static. Signed-off-by: Sachin Kamat --- drivers/extcon/extcon-max77693.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c ind

Re: Failure due to missing (Exynos related) pinctrl patch

2013-01-29 Thread Sachin Kamat
>> This patch is required along with the >> patch "gpio: samsung: fix pinctrl condition for exynos and exynos5440" >> (mainline commit Id: e4a5da51) which has already made it into >> mainline. Without the missing patch we get the following boot up >> warnings and subsequent failures with dt boot on

Re: Failure due to missing (Exynos related) pinctrl patch

2013-01-29 Thread Sachin Kamat
On 30 January 2013 09:38, Kukjin Kim wrote: > Sachin Kamat wrote: >> >> >> This patch is required along with the >> >> patch "gpio: samsung: fix pinctrl condition for exynos and exynos5440" >> >> (mainline commit Id: e4a5da51) which has a

Re: Failure due to missing (Exynos related) pinctrl patch

2013-01-30 Thread Sachin Kamat
Hi Linus, On 30 January 2013 15:18, Linus Walleij wrote: > On Wed, Jan 30, 2013 at 5:08 AM, Kukjin Kim wrote: >> Sachin Kamat wrote: >>> >>> >> This patch is required along with the >>> >> patch "gpio: samsung: fix pinctrl condition

[PATCH 1/1] dma: pl330: Convert to devm_ioremap_resource()

2013-01-30 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. Signed-off-by: Sachin Kamat Cc: Vinod Koul Cc: Thierry Reding Cc: Greg Kroah-Hartman --- This change is based against linux-next tree (20130128). This change

Re: [PATCH 1/1] dma: pl330: Convert to devm_ioremap_resource()

2013-01-31 Thread Sachin Kamat
On 31 January 2013 12:58, Thierry Reding wrote: > On Thu, Jan 31, 2013 at 12:37:04PM +0530, Sachin Kamat wrote: >> Use the newly introduced devm_ioremap_resource() instead of >> devm_request_and_ioremap() which provides more consistent error handling. >> >> Signed-

[PATCH 1/3] video: exynos_mipi_dsi: Convert to devm_ioremap_resource()

2013-01-31 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. Signed-off-by: Sachin Kamat Cc: Donghwa Lee Cc: Florian Tobias Schandinat Cc: linux-fb...@vger.kernel.org --- drivers/video/exynos/exynos_mipi_dsi.c |7

[PATCH 2/3] Input: tegra-kbc- Convert to devm_ioremap_resource()

2013-01-31 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. Signed-off-by: Sachin Kamat Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org --- Compile tested with linux-next (20130128) --- drivers/input/keyboard/tegra

[PATCH 3/3] serial: tegra: Convert to devm_ioremap_resource()

2013-01-31 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. Signed-off-by: Sachin Kamat Cc: Laxman Dewangan Cc: linux-ser...@vger.kernel.org --- Compile tested with linux-next (20130128). --- drivers/tty/serial/serial

Re: [PATCH 1/3] video: exynos_mipi_dsi: Convert to devm_ioremap_resource()

2013-01-31 Thread Sachin Kamat
On 31 January 2013 16:12, Thierry Reding wrote: > On Thu, Jan 31, 2013 at 03:55:37PM +0530, Sachin Kamat wrote: >> Use the newly introduced devm_ioremap_resource() instead of >> devm_request_and_ioremap() which provides more consistent error handling. >> >> Signed-

Re: [PATCH 3/3] serial: tegra: Convert to devm_ioremap_resource()

2013-01-31 Thread Sachin Kamat
On 31 January 2013 22:30, Stephen Warren wrote: > On 01/31/2013 03:25 AM, Sachin Kamat wrote: >> Use the newly introduced devm_ioremap_resource() instead of >> devm_request_and_ioremap() which provides more consistent error handling. > > Presumably though that function isn&#

Re: [PATCH 3/3] serial: tegra: Convert to devm_ioremap_resource()

2013-02-01 Thread Sachin Kamat
On 1 February 2013 09:54, Stephen Warren wrote: >> >> The entire series is merged in Greg's driver-core tree [1] and I >> presume all other associated patches would also be picked up by him. >> Isn't it Greg? >> >> [1] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > The Te

[PATCH v2 1/2] Input: tegra-kbc- Convert to devm_ioremap_resource()

2013-02-01 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH v2 2/2] serial: tegra: Convert to devm_ioremap_resource()

2013-02-01 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/1] pinctrl: core: Make pinctrl_release static

2013-01-24 Thread Sachin Kamat
'pinctrl_release' is used only in this file. Hence make it static. Without this patch we get the following sparse error: drivers/pinctrl/core.c:815:6: warning: symbol 'pinctrl_release' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/pinctrl

Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API

2013-01-27 Thread Sachin Kamat
On 27 January 2013 05:52, Samuel Ortiz wrote: > Hi Sachin, > > On Thu, Jan 24, 2013 at 09:13:20AM +0530, Sachin Kamat wrote: >> Hi Samuel, >> >> On 8 January 2013 16:06, Mark Brown >> wrote: >> > On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kam

[PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

2013-03-13 Thread Sachin Kamat
Fixes the following warnings: WARNING: line over 80 characters WARNING: Prefer pr_warn(... to pr_warning(... Signed-off-by: Sachin Kamat --- drivers/irqchip/exynos-combiner.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/exynos-combiner.c b

[PATCH 1/1] irqchip: irq-gic: Fix checkpatch errors

2013-03-13 Thread Sachin Kamat
Fixes the following errors: ERROR: do not initialise statics to 0 or NULL ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Sachin Kamat --- Compile tested and based on linux-next tree (20130313). --- drivers/irqchip/irq-gic.c |4 ++-- 1 files changed, 2 insert

[PATCH 1/1] clk: Fix incorrect return type in clk.c

2013-03-13 Thread Sachin Kamat
Return type of function clk_propagate_rate_change is a pointer. But 0 was being returned. Change it to NULL. Silences the following warning: drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/clk/clk.c |2 +- 1 files changed, 1

[PATCH 1/1] pinctrl: generic: Fix compilation error

2013-03-13 Thread Sachin Kamat
c:726: undefined reference to `pinconf_generic_dump_config' Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinconf.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h index 1f7113e..92c7267 100644 --- a/drivers/pinctrl

[PATCH 1/1] pinctrl: pinctrl-nomadik-stn8815: Fix checkpatch error

2013-03-13 Thread Sachin Kamat
Fixes the following error: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-nomadik-stn8815.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/pinctrl-nomadik-stn8815.c b/drivers/pinct

Re: [PATCH] drivers: dma: Use devm_ioremap_resource

2013-03-13 Thread Sachin Kamat
On 14 March 2013 04:47, Alexandru Gheorghiu wrote: > Replaced call to devm_request_and_ioremap with devm_ioremap_resource which > provides better error handling. > > Signed-off-by: Alexandru Gheorghiu > --- Already sent a similar patch to do this: https://patchwork.kernel.org/patch/2211801/ -- T

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-13 Thread Sachin Kamat
Hi Linus, On 4 March 2013 22:38, Tony Prisk wrote: > On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote: >> Use the newly introduced devm_ioremap_resource() instead of >> devm_request_and_ioremap() which provides more consistent error handling. >> >> devm_ioremap_

Re: [PATCH] drivers: gpio: Use devm_ioremap_resource function

2013-03-14 Thread Sachin Kamat
On 14 March 2013 14:57, Alexandru Gheorghiu wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error > handling. > > Signed-off-by: Alexandru Gheorghiu Similar patch has already been submitted: https://lkml.org/lkml/20

[PATCH 1/1] sbs-battery: Use of_match_ptr() macro

2013-03-14 Thread Sachin Kamat
This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat --- drivers/power/sbs-battery.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c index 3960f0b

[PATCH 1/2] drivers: uio_dmem_genirq: Use of_match_ptr() macro

2013-03-14 Thread Sachin Kamat
This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat Cc: Damian Hobson-Garcia --- drivers/uio/uio_dmem_genirq.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio

[PATCH 2/2] drivers: uio_pdrv_genirq: Use of_match_ptr() macro

2013-03-14 Thread Sachin Kamat
This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat --- drivers/uio/uio_pdrv_genirq.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c index c122bca

[PATCH 1/2] pinctrl/nomadik-db8500: Fix checkpatch errors

2013-03-14 Thread Sachin Kamat
Silences the following type of checkpatch errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-nomadik-db8500.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-nomadik-d

[PATCH 2/2] pinctrl/nomadik: Fix checkpatch errors

2013-03-14 Thread Sachin Kamat
Fixes the following types of checkpatch errors: ERROR: space required after that ',' (ctx:VxV) ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-nomadik.c |6 +++--- 1 files changed, 3 insertions(+), 3 dele

[PATCH 1/2] pinctrl: at91: Remove duplicate const

2013-03-14 Thread Sachin Kamat
const declared twice. Fixes the following sparse warning: drivers/pinctrl/pinctrl-at91.c:815:21: warning: duplicate const drivers/pinctrl/pinctrl-at91.c:849:21: warning: duplicate const Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-at91.c |4 ++-- 1 files changed, 2 insertions

[PATCH 2/2] pinctrl: at91: Fix checkpatch errors

2013-03-14 Thread Sachin Kamat
pace required after that ',' (ctx:WxV) ERROR: "(foo*const*)" should be "(foo *const*)" ERROR: space required before that '*' (ctx:VxB) Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-at91.c | 17 + 1 files changed, 9 insertions(

[PATCH 1/2] pinctrl: generic: Make 'conf_items' static

2013-03-14 Thread Sachin Kamat
'conf_items' is used only in this file. Silences the below sparse warning: drivers/pinctrl/pinconf-generic.c:37:24: warning: symbol 'conf_items' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinconf-generic.c |2 +- 1 files c

[PATCH 2/2] pinctrl: generic: Fix checkpatch errors

2013-03-14 Thread Sachin Kamat
Fixes the following type of checkpatch errors: ERROR: space required before the open parenthesis '(' Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinconf-generic.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c

[PATCH 1/1] pinctrl: coh901: Fix checkpatch error

2013-03-14 Thread Sachin Kamat
Fixes the following checkpatch error: ERROR: space required before the open parenthesis '(' Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-coh901.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/pinctrl-coh901.c b/drivers/pinct

[PATCH Resend] dt: Fix incorrect reference in gpio-led documentation

2012-09-10 Thread Sachin Kamat
Path to gpio.txt (dt) document was broken. Signed-off-by: Sachin Kamat --- Documentation/devicetree/bindings/gpio/led.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/devicetree/bindings/gpio/led.txt b/Documentation/devicetree/bindings/gpio/led.txt

Re: linux-next: build failure after merge of the akpm tree

2012-09-13 Thread Sachin Kamat
On 13 September 2012 13:14, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/thermal/cpu_cooling.c: In function 'get_idr': > drivers/thermal/cpu_cooling.c:89:14: error: 'MAX_ID_MASK' undeclared (fir

[PATCH 1/1] pinctrl: Samsung: Fix return value

2012-09-14 Thread Sachin Kamat
am Signed-off-by: Sachin Kamat --- drivers/pinctrl/pinctrl-samsung.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c index 8a24223..824fda9 100644 --- a/drivers/pinctrl/pinctrl-samsung.c +++ b/drive

Re: [GIT PULL] PWM subsystem for v3.6

2012-07-27 Thread Sachin Kamat
ork, and Arnd Bergmann who was involved in > the review process. Other people such as Shawn Guo and Mark Brown have > also been reviewing these patches and new patches have been contributed > by Eric Bénard, Axel Lin, Sachin Kamat, Alexandre Courbot, Alexandre > Pereira da Silva and Phil

Re: [PATCH 4/5] drivers/video/da8xx-fb.c: use devm_ functions

2012-07-31 Thread Sachin Kamat
On 31 July 2012 19:24, Damien Cassou wrote: > From: Damien Cassou > > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > f

[PATCH] extcon: Fix return value in extcon_register_interest()

2012-09-25 Thread Sachin Kamat
Return the value obtained from extcon_find_cable_index() instead of -ENODEV. Fixes the following smatch info: drivers/extcon/extcon-class.c:478 extcon_register_interest() info: why not propagate 'obj->cable_index' from extcon_find_cable_index() instead of -19? Signed-off-by:

[PATCH] pinctrl: Fix potential memory leak in pinctrl_register_one_pin()

2012-09-25 Thread Sachin Kamat
'pindesc' was not freed when returning from an error induced exit path. Signed-off-by: Sachin Kamat --- drivers/pinctrl/core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index dc5c126..0f1ec9e 100644 ---

Re: [PATCH] extcon: Fix return value in extcon_register_interest()

2012-09-25 Thread Sachin Kamat
On 25 September 2012 14:45, anish singh wrote: > On Tue, Sep 25, 2012 at 12:28 PM, Sachin Kamat > wrote: >> Return the value obtained from extcon_find_cable_index() >> instead of -ENODEV. >> >> Fixes the following smatch info: >> drivers/extcon/extcon-class.c

Re: [PATCH] extcon: Fix return value in extcon_register_interest()

2012-09-25 Thread Sachin Kamat
On 25 September 2012 16:02, Chanwoo Choi wrote: > On 09/25/2012 03:58 PM, Sachin Kamat wrote: > >> Return the value obtained from extcon_find_cable_index() >> instead of -ENODEV. >> >> Fixes the following smatch info: >> drivers/extcon/extcon-class.c:478 ext

[PATCH Resend] extcon: Fix return value in extcon_register_interest()

2012-09-25 Thread Sachin Kamat
Propagate the value returned from extcon_find_cable_index() instead of -ENODEV. For readability, -EINVAL is returned in place of the variable. Signed-off-by: Sachin Kamat --- drivers/extcon/extcon-class.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/extcon

Re: [PATCH 1/1] pinctrl: Samsung: Fix return value

2012-09-25 Thread Sachin Kamat
Hi Thomas, Please provide your review comments. On 14 September 2012 19:37, Linus Walleij wrote: > On Fri, Sep 14, 2012 at 2:02 PM, Sachin Kamat wrote: > >> Return the value obtained from of_property_count_strings() >> instead of -EINVAL. >> >> Silences the follow

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Sachin Kamat
On 3 October 2013 10:07, Viresh Kumar wrote: > On 28 September 2013 17:38, Sachin Kamat wrote: >> The data structure of_match_ptr() protects is always compiled in. > > of_match_ptr() isn't a data structure.. Yes you are right. of_match_ptr() is a macro. The data structur

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Sachin Kamat
On 3 October 2013 12:37, Viresh Kumar wrote: > On 3 October 2013 12:36, Sachin Kamat wrote: >> On 3 October 2013 10:07, Viresh Kumar wrote: >>> On 28 September 2013 17:38, Sachin Kamat wrote: > Yeah I will Ack this.. but was waiting for your next version with fixed log.

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Sachin Kamat
On 3 October 2013 12:42, Viresh Kumar wrote: > On 3 October 2013 12:40, Sachin Kamat wrote: >> Do you really want a new one. If so, please let me know how you would >> like this to be re-worded. I have already used this for others and >> thought it was clear enough :) &

[PATCH 1/2] regulator: wm8994: Remove redundant break

2013-10-04 Thread Sachin Kamat
'break' after return has no effect. Remove it. Signed-off-by: Sachin Kamat --- drivers/regulator/wm8994-regulator.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/wm8994-regulator.c b/drivers/regulator/wm8994-regulator.c index 71c5911..ffc1b2f 100644 ---

[PATCH 2/2] regulator: gpio: Remove redundant break

2013-10-04 Thread Sachin Kamat
'break' after goto has no effect. Remove it. Signed-off-by: Sachin Kamat --- drivers/regulator/gpio-regulator.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 98a98ff..04406a9 100644 --- a/drivers

[PATCH 1/1] regulator: tps6524x: Remove redundant spi_set_drvdata

2013-09-19 Thread Sachin Kamat
Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/regulator/tps6524x-regulator.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/tps6524x-regulator.c b/drivers/regulator/tps6524x-regulator.c index 62e8d28..8b9ee39

[PATCH 1/1] mfd: Remove redundant dev_set_drvdata

2013-09-20 Thread Sachin Kamat
Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/mfd/mc13xxx-i2c.c |1 - drivers/mfd/rtsx_pcr.c|5 + drivers/mfd/ti-ssp.c |1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/mfd/mc13xxx-i2c.c b

[PATCH 1/9] regulator: max77686: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- This series is compile tested. --- drivers/regulator/max77686.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c index f563057

[PATCH 7/9] regulator: max8973-regulator: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max8973-regulator.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c index 0c5195a..04de63d 100644 --- a

[PATCH 6/9] regulator: max8907-regulator: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max8907-regulator.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/max8907-regulator.c b/drivers/regulator/max8907-regulator.c index 4568c15..0c5fe6c

[PATCH 8/9] regulator: max8997: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max8997.c | 38 ++ 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c index df20069..059e8ed 100644 --- a

[PATCH 9/9] regulator: max8998: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max8998.c | 35 --- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c index a4c53b2..ae3f065 100644 --- a

[PATCH 3/9] regulator: max77693: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max77693.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c index ce4b96c..2054ae1 100644 --- a/drivers

[PATCH 5/9] regulator: max8660: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max8660.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/regulator/max8660.c b/drivers/regulator/max8660.c index d428ef9..a057342 100644 --- a/drivers

[PATCH 2/9] regulator: max1586: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max1586.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c index 54af610..3abf76a 100644 --- a/drivers

[PATCH 4/9] regulator: max8649: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/max8649.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/regulator/max8649.c b/drivers/regulator/max8649.c index db6c9be..b2a808c 100644 --- a/drivers/regulator/max8649.c

[PATCH 1/7] regulator: anatop-regulator: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- This series is compile tested. --- drivers/regulator/anatop-regulator.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c index 0d4a8cc

[PATCH 2/7] regulator: isl6271a-regulator: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/isl6271a-regulator.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c index b99c49b

[PATCH 5/7] regulator: palmas: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/palmas-regulator.c | 38 ++ 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index d0c8785

[PATCH 6/7] regulator: rc5t583: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/rc5t583-regulator.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/rc5t583-regulator.c b/drivers/regulator/rc5t583-regulator.c index 5885b45..b58affb

[PATCH 7/7] regulator: ti-abb: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/ti-abb-regulator.c | 82 ++ 1 file changed, 23 insertions(+), 59 deletions(-) diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c index 3753ed0

[PATCH 4/7] regulator: mc13892: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/mc13892-regulator.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c index 1037e07..96c9f80

[PATCH 3/7] regulator: mc13783: Use devm_regulator_register

2013-09-03 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/mc13783-regulator.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c index 5ff99d2

[PATCH 1/1] regulator: s2mps11: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
Commit e398b51a ("regulator: s2mps11: Convert to devm_regulator_register()") intended to do this conversion. However the actual conversion to devm_* got missed out. Fix this. Signed-off-by: Sachin Kamat --- drivers/regulator/s2mps11.c |3 ++- 1 file changed, 2 insertions(+),

Re: [PATCH 1/4] ab8500-charger: Check return value of regulator_enable

2013-09-04 Thread Sachin Kamat
On 4 September 2013 15:11, Lee Jones wrote: > On Mon, 02 Sep 2013, Sachin Kamat wrote: > >> Check the return value of regulator_enable to silence the following >> type of warnings: >> drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value >> of ‘re

[PATCH 06/10] regulator: tps65217: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/tps65217-regulator.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c index 2df4616

[PATCH 09/10] regulator: tps65912: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/tps65912-regulator.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c index 17e994e

[PATCH 01/10] regulator: tps51632: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- This series is compile tested. --- drivers/regulator/tps51632-regulator.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tps51632

[PATCH 04/10] regulator: tps6507x: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/tps6507x-regulator.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c index 4117ff5

[PATCH 08/10] regulator: tps65910: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/tps65910-regulator.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 45c1644

[PATCH 03/10] regulator: tps65023: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/tps65023-regulator.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/regulator/tps65023-regulator.c b/drivers/regulator/tps65023-regulator.c index 9d053e2

[PATCH 10/10] regulator: tps80031: Use devm_regulator_register

2013-09-04 Thread Sachin Kamat
devm_* simplifies the code. Signed-off-by: Sachin Kamat --- drivers/regulator/tps80031-regulator.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/regulator/tps80031-regulator.c b/drivers/regulator/tps80031-regulator.c index 6511d0b

  1   2   3   4   5   6   7   >