On 3 October 2013 10:07, Viresh Kumar <viresh.ku...@linaro.org> wrote:
> On 28 September 2013 17:38, Sachin Kamat <sachin.ka...@linaro.org> wrote:
>> The data structure of_match_ptr() protects is always compiled in.
>
> of_match_ptr() isn't a data structure..
Yes you are right. of_match_ptr() is a macro. The data structure here
refers to its argument and not of_match_ptr() itself.
>And also what does "protects" mean here?
It just means that of_match_ptr() avoids an undefined reference error
had CONFIG_OF been used around the data structures definition by
making the pointer NULL.
>
>> Hence of_match_ptr() is not needed.
>>
>> Signed-off-by: Sachin Kamat <sachin.ka...@linaro.org>
>> Cc: Viresh Kumar <viresh.ku...@linaro.org>
>> ---
>> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c
>> b/drivers/pinctrl/spear/pinctrl-plgpio.c
>> index 0a7f0bdb..ff2940e 100644
>> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
>> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
>> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
>> .owner = THIS_MODULE,
>> .name = "spear-plgpio",
>> .pm = &plgpio_dev_pm_ops,
>> - .of_match_table = of_match_ptr(plgpio_of_match),
>> + .of_match_table = plgpio_of_match,
>> },
>> };
>
> Patch is okay otherwise.
Hope to have your ack on this :)
Thanks for reviewing.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
