RE: linux-next: build warning after merge of the wireless-drivers-next tree

2016-07-19 Thread Reizer, Eyal
Hi Stephen, > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) produced this warning: > > drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of': > drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [- > Wunused

[PATCHv8] wlcore: spi: add wl18xx support

2016-07-19 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the i

RE: [PATCHv8] wlcore: spi: add wl18xx support

2016-07-20 Thread Reizer, Eyal
> > > Add support for using with both wl12xx and wl18xx. > > > > - all wilink family needs special init command for entering wspi mode. > > extra clock cycles should be sent after the spi init command while the > > cs pin is high. > > - Use inverted chip select for sending a dummy 4 bytes comm

[PATCH] wlcore: spi: fix build warning caused by redundant variable

2016-07-20 Thread Reizer, Eyal
The ret variable is unused in wlcore_probe_of() Remove it for fixing build warning. Fixes: 01efe65aba65 ("wlcore: spi: add wl18xx support") Signed-off-by: Eyal Reizer --- drivers/net/wireless/ti/wlcore/spi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/spi.c

[PATCHv3] wlcore: spi: add wl18xx support

2016-06-21 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the i

RE: [PATCHv3] wlcore: spi: add wl18xx support

2016-06-21 Thread Reizer, Eyal
> > > > - all wilink family needs special init command for entering wspi mode. > > extra clock cycles should be sent after the spi init command while the > > cs pin is high. > > - Use inverted chip select for sending a dummy 4 bytes command that > > completes the init stage and puts the wilin

RE: [v7 wlcore: add missing nvs file name info for wilink8

2017-08-16 Thread Reizer, Eyal
> > > > + if (oui_addr == 0xdeadbe && nic_addr == 0xef) { > > + wl1271_warning("Detected unconfigured mac address in > nvs.\n" > > + "derive from fuse instead.\n" > > + "in case of using a wl12xx device, your " > > +

[v8] wlcore: add missing nvs file name info for wilink8

2017-08-17 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibil

RE: [PATCH 1/1] Documentation: Add dt-binding for TI-btwilink driver

2015-04-26 Thread Reizer, Eyal
Hi Marcel, > -Original Message- > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Monday, April 27, 2015 7:32 AM > To: Gigi Joseph > Cc: devicet...@vger.kernel.org; Rob Herring; Pawel Moll; Mark Rutland; Ian > Campbell; Kumar Gala; linux-kernel@vger.kernel.org; Gigi, Joseph > Su

RE: [PATCH] Bluetooth: Add tty HCI driver

2015-04-30 Thread Reizer, Eyal
Hi, > -Original Message- > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Thursday, April 30, 2015 5:25 PM > To: One Thousand Gnomes > Cc: Eyal Reizer; linux-kernel@vger.kernel.org; Reizer, Eyal; Pavan Savoy; > Mahaveer, Vishal; linux-blueto...@vger.kernel

RE: [EXTERNAL] [tiL4.14-CON PATCH v2] ARM: dts: am437x-sk-evm: add wilink8 support

2018-05-01 Thread Reizer, Eyal
Please discard. Wrong patch header. Will resend. Sorry about that. > > enable mmc3 used for wlan and uart1 used for bluetooth > configure the gpios used for wlan and bluetooth controls > add fixed voltage regulator used for wlan power control > > Signed-off-by: Eyal Reizer > --- > arch/arm/boo

RE: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support

2018-05-02 Thread Reizer, Eyal
> > ARM should be capitalized in subject line. OK, will be fixed in v2 > > > + > > +&mmc3 { > > + status = "okay"; > > + /* > > +* these are on the crossbar and are outlined in the > > +* xbar-event-map element > > +*/ > > + dmas = <&edma_xbar 30 0 1>, > > + <&edma_xb

RE: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support

2018-05-02 Thread Reizer, Eyal
> > * Eyal Reizer [180501 00:26]: > > enable mmc3 used for wlan and uart1 used for bluetooth > > configure the gpios used for wlan and bluetooth controls > > add fixed voltage regulator used for wlan power control > ... > > / { > > model = "TI AM437x SK EVM"; > > @@ -158,6 +159,22 @@ > >

RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power

2018-04-26 Thread Reizer, Eyal
> > > pm_runtime handles sdio power on and power off transitions. > > An old workaround for trying to control the power explicitly from the > > driver was in fact causing failures on suspend/resume as the mmc layer > > already power the module on resume. > > > > In case of resume pm_runtime_get sy

RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power

2018-04-26 Thread Reizer, Eyal
> > >> > >> > pm_runtime handles sdio power on and power off transitions. > >> > An old workaround for trying to control the power explicitly from the > >> > driver was in fact causing failures on suspend/resume as the mmc layer > >> > already power the module on resume. > >> > > >> > In case of r

RE: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-21 Thread Reizer, Eyal
> > > Thanks! Glad the illustration helped. > > I will try it out again as if i recall cotrectly, i did try that l, and it > > didnt produce > the correct waveform, but perhaps i didnt understand the usage of > .cs_change correctly. > > Will double check anyway. > > It could also be a bug in you

RE: [PATCH] wlcore: spi: add wl18xx support

2016-04-07 Thread Reizer, Eyal
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Thursday, April 07, 2016 3:25 PM > To: Eyal Reizer > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Reizer, Eyal; devicet...@vger.kernel.org >

[PATCHv2] wlcore: spi: add wl18xx support

2016-04-10 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - switch to controling the cs pin from the spi driver for achieveing the above. - t

RE: [PATCH] wlcore: spi: add wl18xx support

2016-04-06 Thread Reizer, Eyal
Ping on this patch > -Original Message- > From: Eyal Reizer [mailto:eyalrei...@gmail.com] > Sent: Wednesday, March 30, 2016 4:07 PM > To: kv...@codeaurora.org; linux-wirel...@vger.kernel.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Reizer, Eyal

RE: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-17 Thread Reizer, Eyal
> > > > - all wilink family needs special init command for entering wspi mode. > > extra clock cycles should be sent after the spi init command while the > > cs pin is high. > > - switch to controling the cs pin from the spi driver for achieveing the > > above. > > - the selected cs gpio is r

RE: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Reizer, Eyal
Arnd, > > > > > > > > - all wilink family needs special init command for entering wspi mode. > > > > extra clock cycles should be sent after the spi init command while the > > > > cs pin is high. > > > > - switch to controling the cs pin from the spi driver for achieveing the > > > > above.

RE: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Reizer, Eyal
> > > > It is also part of the generic spi.h (include/Linux/spi/spi.h), > > > > already part of " struct spi_device" So it seemed redundant adding > > > > another mechanism for implementing the same. > > > > Platform that interact with a wilink need to use it, and platforms > > > > that don't have

RE: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support

2018-05-06 Thread Reizer, Eyal
> > * Reizer, Eyal [180503 06:43]: > > > > > > * Eyal Reizer [180501 00:26]: > > > > enable mmc3 used for wlan and uart1 used for bluetooth > > > > configure the gpios used for wlan and bluetooth controls > > >

RE: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support

2018-05-06 Thread Reizer, Eyal
Hi Tony, > > Yeah my guess is that the reason for the separate GPIO interrupt was > that on omap3 we did not have SDIO interrupt working for years. This was > because of the issues related to padconf interrupts for off mode. > > We now have Linux generic wakeirq support working with SDIO and it

[PATCH v5] wlcore: spi: add wl18xx support

2016-07-16 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the i

[PATCH v6] wlcore: spi: add wl18xx support

2016-07-18 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the i

RE: [PATCH v7] wlcore: spi: add wl18xx support

2016-07-19 Thread Reizer, Eyal
> > From: Eyal Reizer > > > > Add support for using with both wl12xx and wl18xx. > > > > - all wilink family needs special init command for entering wspi mode. > > extra clock cycles should be sent after the spi init command while the > > cs pin is high. > > - Use inverted chip select for send

[PATCH v5] wlcore: spi: add wl18xx support

2016-07-10 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the i

[PATCH v4] wlcore: spi: add wl18xx support

2016-06-26 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the i

RE: [PATCH] wlcore: add missing nvs file name info for wilink8

2017-07-20 Thread Reizer, Eyal
> > > > On Wed, Jul 05, 2017 at 01:06:54AM -0700, Tony Lindgren wrote: > > > > > Not sure if this really is a regression as we've always had a bogus > > > > > wl1271-nvs.bin in linux-firmware.git. Sure would be nice to fix it, > > > > > but going back to using a generic wl1271-nvs.bin sure does not

[v3] wlcore: add missing nvs file name info for wilink8

2017-07-20 Thread Reizer, Eyal
The following commits: c815fde wlcore: spi: Populate config firmware data d776fc8 wlcore: sdio: Populate config firmware data Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibility when upgrading from older

RE: [v3] wl18xx: add missing nvs file name info for wilink8

2017-07-20 Thread Reizer, Eyal
> The following commits: > c815fde wlcore: spi: Populate config firmware data > d776fc8 wlcore: sdio: Populate config firmware data > > Populated the nvs entry for wilink6 and wilink7 only while it is > still needed for wilink8 as well. > This broke user space backward compatibility when upgrading

[v3] wl18xx: add missing nvs file name info for wilink8

2017-07-20 Thread Reizer, Eyal
The following commits: c815fde wlcore: spi: Populate config firmware data d776fc8 wlcore: sdio: Populate config firmware data Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibility when upgrading from older

RE: [v3] wl18xx: add missing nvs file name info for wilink8

2017-07-20 Thread Reizer, Eyal
Please ignore this patch. Wrong header. Submitted the correct one instead: https://patchwork.kernel.org/patch/9854809/ > -Original Message- > From: Reizer, Eyal > Sent: Thursday, July 20, 2017 3:13 PM > To: 'Kalle Valo'; ',Tony Lindgren'; 'linux-wir

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
> > > > Sorry for top posting (mobile...) > > I have verified with system design and the data sheet that every wilink 6/7 > chip has a mac address in fuse so probably the board you have (pretty old, > right?) has this mac address in fuse. Maybe it was from very early batches? > Anyway I see no reas

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > On Thu, Aug 10, 2017 at 4:35 PM, Reizer, Eyal wrote: > >> > > >> > Sorry for top posting (mobile...) > >> > I have verified with system design and the data sheet that every wilink > 6/7 > >> chip has a mac address in fuse so probably the

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > >> The fact that is old does not change a thing, we still need to > >> support it no matter what the data sheet and your system design > >> says. A fix that breaks other things is not really a fix :) > >> > > > > Sure, just want to make sure we are not trying to add work around just for > > A

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Reizer, Eyal
> > > > Sure, just want to make sure we are not trying to add work around just for > A couple of faulty devices. > > > > I have verified using a couple of com6 modules with an am335x-evm and > > they had mac addresses read ok. > > > > Sounds like there are multiple variants of the wl12xx > > avai

[v9] wlcore: add missing nvs file name info for wilink8

2017-08-20 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibil

RE: [v3] wlcore: add missing nvs file name info for wilink8

2017-07-25 Thread Reizer, Eyal
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Tuesday, July 25, 2017 1:22 PM > To: Reizer, Eyal > Cc: Kalle Valo; linux-wirel...@vger.kernel.org; linux-kernel@vger.kernel.org; > sebastian.reic...@collabora.co.uk > Subject: Re: [v3] wl

[v4] wlcore: add missing nvs file name info for wilink8

2017-07-31 Thread Reizer, Eyal
The following commits: c815fde wlcore: spi: Populate config firmware data d776fc8 wlcore: sdio: Populate config firmware data Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibility when upgrading from older ke

[v5] wlcore: add missing nvs file name info for wilink8

2017-08-07 Thread Reizer, Eyal
The following commits: c815fde wlcore: spi: Populate config firmware data d776fc8 wlcore: sdio: Populate config firmware data Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibility when upgrading from older ke

RE: [v4] wlcore: add missing nvs file name info for wilink8

2017-08-07 Thread Reizer, Eyal
> -Original Message- > From: Julian Calaby [mailto:julian.cal...@gmail.com] > Sent: Saturday, August 5, 2017 8:51 AM > To: Reizer, Eyal > Cc: Kalle Valo; ,Tony Lindgren; linux-wirel...@vger.kernel.org; linux- > ker...@vger.kernel.org; sebastian.reic...@collabora.co.uk

RE: [v5] wlcore: add missing nvs file name info for wilink8

2017-08-07 Thread Reizer, Eyal
Hi Tony, > > * Reizer, Eyal [170807 00:32]: > > The following commits: > > c815fde wlcore: spi: Populate config firmware data > > d776fc8 wlcore: sdio: Populate config firmware data > > > > Populated the nvs entry for wilink6 and wilink7 only while it is

RE: [v5] wlcore: add missing nvs file name info for wilink8

2017-08-08 Thread Reizer, Eyal
> Subject: Re: [v5] wlcore: add missing nvs file name info for wilink8 > > * Reizer, Eyal [170807 00:47]: > > Hi Tony, > > > > > > * Reizer, Eyal [170807 00:32]: > > > > The following commits: > > > > c815fde wlcore: spi: Populate co

RE: [v5] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
> > > Subject: Re: [v5] wlcore: add missing nvs file name info for wilink8 > > > > * Reizer, Eyal [170807 00:47]: > > > Hi Tony, > > > > > > > > * Reizer, Eyal [170807 00:32]: > > > > > The following commits: > > > &

[v6] wlcore: add missing nvs file name info for wilink8

2017-08-09 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well for specifying an alternate mac address. T

RE: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-13 Thread Reizer, Eyal
> > > > > > > > > > Sure, just want to make sure we are not trying to add work around just > for > > > A couple of faulty devices. > > > > > > > > I have verified using a couple of com6 modules with an am335x-evm > and > > > > they had mac addresses read ok. > > > > > > > > Sounds like there are mu

[v7 wlcore: add missing nvs file name info for wilink8

2017-08-14 Thread Reizer, Eyal
The following commits: commit c815fdebef44 ("wlcore: spi: Populate config firmware data") commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") Populated the nvs entry for wilink6 and wilink7 only while it is still needed for wilink8 as well. This broke user space backward compatibil

[PATCH] wlcore: add missing nvs file name info for wilink8

2017-07-03 Thread Reizer, Eyal
When working with wl18xx the nvs file is used for defining an alternate mac address and override the default mac address that is stored inside the wl18xx chip. update the structure field with the same default nvs file name that has been used in the past, otherwise userspace backward compatibility i

[v2] wlcore: add missing nvs file name info for wilink8

2017-07-03 Thread Reizer, Eyal
When working with wl18xx the nvs file is used for defining an alternate mac address and override the default mac address that is stored inside the wl18xx chip. The following commits: c815fde wlcore: spi: Populate config firmware data d776fc8 wlcore: sdio: Populate config firmware data Populated t

RE: [PATCH] wlcore: add missing nvs file name info for wilink8

2017-07-04 Thread Reizer, Eyal
Hi Tony, > > * Kalle Valo [170703 04:30]: > > "Reizer, Eyal" writes: > > > > > When working with wl18xx the nvs file is used for defining an alternate > > > mac address and override the default mac address that is stored inside > > > the

RE: [v2] wlcore: add missing nvs file name info for wilink8

2017-07-04 Thread Reizer, Eyal
Hi Tony, > > When working with wl18xx the nvs file is used for defining an alternate > > mac address and override the default mac address that is stored inside > > the wl18xx chip. > > > > The following commits: > > c815fde wlcore: spi: Populate config firmware data > > d776fc8 wlcore: sdio: Popul

[PATCH] wlcore: allow elp during wowlan suspend

2017-11-28 Thread Reizer, Eyal
when enabling wowlan and entering suspend the last write to the firmware allowing it to go into elp mode was not completing before suspend, leaving the firmware running in full active mode consuming high power. Use an immediate call instead of a work queue for this last access allowing the firmware