Replacing string compare with codec_dai->name instead of comparing with
codec_dai->component->name in hw_params.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp
-Original Message-
From: Mark Brown
Sent: Thursday, August 6, 2020 4:59 PM
To: RAVULAPATI, VISHNU VARDHAN RAO
Cc: Liam Girdwood ; Jaroslav Kysela ;
Takashi Iwai ; Agrawal, Akshu ; Kuninori
Morimoto ; YueHaibing
; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM
On Thu, Aug 06, 2020 at 03:44:12PM +0530, Ravulapati Vishnu vardhan rao wrote:
> Replacing string compare with codec_dai->name instead of comparing
> with codec_dai->component->name in hw_params.
>Why?
Here the component name for codec RT1015 is "i2c-10EC1015:00"
e.
So, strcmp() always compares and fails to set the
sysclk,pll,bratio for expected codec-dai="rt1015-aif1".
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp3x-
h issue is resolved.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/pci-acp3x.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
index 8c138e490f0c..d3536fd6a124 100644
--
ACP-PCI controller driver does not depends msi interrupts.
So removed msi related pci functions which have no
use and does not impact on existing functionality.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/pci-acp3x.c | 11 +--
1 file changed, 1 insertion(+), 10
Asoc: PCM DMA driver should only have dma ops.
So Removed all DAI related functionality.
Refactoring the PCM DMA diver code.
Added new file containing only DAI ops.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-i2s.c | 289
ACP3x I2S (CPU DAI) can act in normal I2S and TDM modes. Added support
for TDM mode. Desired mode can be selected from ASoC machine driver.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-i2s.c | 36 ++--
1 file changed, 26 insertions
This patch adds I2S SP support in ACP PCM DMA and DAI.
Added I2S support in DMA and DAI probe,its hw_params handling
its open and close functionalities.
This enable to open and close on the SP instance for
playback and capture.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd
for ACP3x PCM platform device. Device will be powered on/off based on
device is in use or not.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 160 +++-
sound/soc/amd/raven/acp3x.h | 7 ++
sound/soc/amd/raven/pci-acp3x.c
Whenever audio data equal to I2S-SP fifo watermark level is
produced/consumed, interrupt is generated.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b
Removed platform based endpoint registering in ACP-PCI driver.
Now Registering PCM DMA and multiple I2S instances: SP and BT endpoint
devices automatically by using MFD framework.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x.h | 8 +++
sound/soc/amd/raven
Removed platform based endpoint registering.
Now Registering DMA and multiple I2S BT playback
endpoint devices automatically by using MFD framework.
Signed-off-by: Ravulapati Vishnu vardhan rao
Reviewed-by: Vijendar Mukunda
---
sound/soc/amd/raven/acp3x.h | 54 ---
sound/soc
DMA driver should have only dma ops.Removed all DAI related.
Refactoring the code added new file contianing only DAI ops.
Signed-off-by: Ravulapati Vishnu vardhan rao
Reviewed-by: Vijendar Mukunda
---
sound/soc/amd/raven/Makefile| 2 +
sound/soc/amd/raven/acp3x-i2s.c | 289
ACP power gating should be handled by ACP-PCI driver.
This patch moves the power gating logic into ACP-PCI driver.
This Power gating helps ACP to enter into D3 when there
is no activity on I2S.
Signed-off-by: Ravulapati Vishnu vardhan rao
Signed-off-by: Vijendar Mukunda
---
sound/soc/amd
Runtime powermanagement is added for PCI driver.
When there is no activity for at least 10 secs driver
suspends automatically.Runtime- Suspend and resume Stub functions
are added.
Signed-off-by: Ravulapati Vishnu vardhan rao
Reviewed-by: Vijendar Mukunda
---
sound/soc/amd/raven/pci-acp3x.c
RAVEN has multiple I2S instances:BT and SP.But only BT is enabled.
Now I2S SP instance also gets enabled with this patch.
Signed-off-by: Ravulapati Vishnu vardhan rao
Reviewed-by: Vijendar Mukunda
---
sound/soc/amd/raven/acp3x-i2s.c | 216 +---
sound/soc/amd/raven
Fix for missing initialization of IRQFLAGS in
ACP-PCI driver and Missing Macro of ACP3x_DEVS.
Follow up to IDb33df346
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/pci-acp3x.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd
Creates Platform Device endpoints for multiple
I2S instances: SP and BT endpoints device.
Pass PCI resources like MMIO, irq to the platform devices.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x.h | 5 +++
sound/soc/amd/raven/pci-acp3x.c | 83
Asoc: PCM DMA driver should only have dma ops.
So Removed all DAI related functionality.
Refactoring the PCM DMA diver code.
Added new file containing only DAI ops.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/Makefile| 2 +
sound/soc/amd/raven/acp3x-i2s.c
This patch adds I2S SP support in ACP PCM DMA and DAI.
Added I2S support in DMA and DAI probe,its hw_params handling
its open and close functionalities.
This enable to open and close on the SP instance for
playback and capture.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd
ACP3x I2S (CPU DAI) can act in normal I2S and TDM modes. Added support
for TDM mode. Desired mode can be selected from ASoC machine driver.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-i2s.c | 51 +
sound/soc/amd/raven
enter into D3 state when there is no activity
on audio I2S lines.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/pci-acp3x.c | 48 -
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound
ACP power gating should be done by ACP-PCI.previous it was
handled in DMA driver which is not authorised to do.Moving
it to ACP-PCI.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 141 +--
sound/soc/amd/raven/acp3x.h
whenever audio data equal to I2S-SP fifo watermark level is
produced/consumed, interrupt is generated.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b
7;s most likely different from CPU physical address when AMD
IOMMU is not in passthrough mode.
Signed-off-by: Vijendar Mukunda
Tested-by: RAVULAPATI VISHNU VARDHAN RAO
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git
device doesn't have it set.
Signed-off-by: Vijendar Mukunda
Tested-by: Ravulapati, Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm
Reduced period size and offsets.
Signed-off-by:Ravulapati, Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x.h b/sound/soc/amd/raven/acp3x.h
index 4f2cadd..033e2a9 100644
--- a/sound/soc/
In DMA pointer the initialzation of instance is of no use.
In fact it will reinitialize the instance variable which is already
opened and functional.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 8
1 file changed, 8 deletions(-)
diff --git a
When snd_pci_acp3x driver loads we see:
WARNING kernel:snd_pci_acp3x :04:00.5: Unbalanced pm_runtime_enable!
at boot time.
same can be observed in /var/log/messages/.
Modifying pm runtime sequence for fixing unbalanced pm issue.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Mark Brown
Sent: Tuesday, May 5, 2020 5:21 PM
To: Agrawal, Akshu
Cc: RAVULAPATI, VISHNU VARDHAN RAO ; Liam
Girdwood ; Jaroslav Kysela ; Takashi Iwai
; Mukunda, Vijendar ; Colin Ian King
; Kuninori
As in future our machine driver supports multiple codecs
So changing naming convention of snd_soc_card struct and its fields.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions
Adding rt1015 hw_params which set Bit-clock ratio PLL and appropriate
sys clk specific with RTK1015.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 39
1 file changed, 39 insertions(+)
diff --git a/sound/soc/amd/acp3x
DAI link support for RTK 1015 and providing the codec details
depending on the snd_soc_card selected by ACPI ID.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 35
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git
Adding support for ALC1015 RTK codec in machine driver.
Passing specific card structure based on its ACPI ID.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/Kconfig| 1 +
sound/soc/amd/acp3x-rt5682-max9836.c | 63 ++--
2 files changed
Passing specific snd_soc_card structure depending on the ACPI ID.
In future we can add other IDs in the ACPI table and pass the structure.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 24 +++-
1 file changed, 19 insertions(+), 5
-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index e37cf72f2bab..77ffdb41bee5 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -29,7 +29,7 @@ config
flag and I expect to use
SND_SOC_RT5682 as it is still available.
Thanks,
Vishnu
-Original Message-
From: Mark Brown
Sent: Monday, July 27, 2020 9:40 PM
To: Pierre-Louis Bossart
Cc: RAVULAPATI, VISHNU VARDHAN RAO ;
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Pierre-Louis Bossart
Sent: Tuesday, July 28, 2020 5:48 PM
To: Mark Brown ; RAVULAPATI, VISHNU VARDHAN RAO
Cc: moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...
; Arnd Bergmann ; Liam Girdwood
I will drop this patch series and will send new series.
Thanks,
-Original Message-
From: Mark Brown
Sent: Tuesday, July 28, 2020 9:06 PM
To: RAVULAPATI, VISHNU VARDHAN RAO
Cc: Pierre-Louis Bossart ; moderated
list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...
; Arnd Bergmann
As in future our machine driver supports multiple codecs
So changing naming convention of snd_soc_card struct and its fields.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions
DAI link support for RTK 1015 and providing the codec details
depending on the snd_soc_card selected by ACPI ID.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 35
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git
Passing specific snd_soc_card structure depending on the ACPI ID.
In future we can add other IDs in the ACPI table and pass the structure.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 25 -
1 file changed, 20 insertions(+), 5
Adding support for ALC1015 RTK codec in machine driver.
Passing specific card structure based on its ACPI ID.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/Kconfig| 1 +
sound/soc/amd/acp3x-rt5682-max9836.c | 63 ++--
2 files changed
Adding rt1015 hw_params which set Bit-clock ratio,
PLL and appropriate sys clk specific with RTK1015.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/acp3x-rt5682-max9836.c | 29
1 file changed, 29 insertions(+)
diff --git a/sound/soc/amd/acp3x
In trigger we already get the selected instance details
from runtime->private_data.So, removing the local
initialization which may corrupt the instance selected
details and this leads to corrupt data.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-i2s.c
rectifies the issue reported.
Signed-off-by: Ravulapati Vishnu vardhan rao
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 30 ++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm-dma.c
index
47 matches
Mail list logo
