RE: [PATCH 3/6] dt-bindings: xilinx_dma: add required xlnx,lengthregwidth property

2018-06-20 Thread Radhey Shyam Pandey
> -Original Message- > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine- > ow...@vger.kernel.org] On Behalf Of Andrea Merello > Sent: Wednesday, June 20, 2018 2:07 PM > To: vk...@kernel.org; dan.j.willi...@intel.com; Michal Simek > ; Appana Durga Kedareswara Rao > ; dmaeng...@vger.

RE: [PATCH 3/6] dt-bindings: xilinx_dma: add required xlnx,lengthregwidth property

2018-06-20 Thread Radhey Shyam Pandey
> -Original Message- > From: Radhey Shyam Pandey > Sent: Wednesday, June 20, 2018 7:13 PM > To: Andrea Merello ; vk...@kernel.org; > dan.j.willi...@intel.com; Michal Simek ; Appana Durga > Kedareswara Rao ; dmaeng...@vger.kernel.org > Cc: linux-arm-ker...@lists.infrad

RE: [PATCH 5/6] dmaengine: xilinx_dma: autodetect whether the HW supports scatter-gather

2018-06-20 Thread Radhey Shyam Pandey
> -Original Message- > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine- > ow...@vger.kernel.org] On Behalf Of Andrea Merello > Sent: Wednesday, June 20, 2018 2:07 PM > To: vk...@kernel.org; dan.j.willi...@intel.com; Michal Simek > ; Appana Durga Kedareswara Rao > ; dmaeng...@vger.ke

RE: [PATCH v2 1/5] dmaengine: xilinx_dma: in axidma slave_sg and dma_cyclic mode align split descriptors

2018-06-21 Thread Radhey Shyam Pandey
h eventually adjusts the transfer size in order to make sure > all operations start from an aligned address. > > Signed-off-by: Andrea Merello > --- > Changes in v2: > - don't introduce copy_mask field, rather rely on already-esistent > copy_align fiel

RE: [PATCH 2/6] dmaengine: xilinx_dma: fix completion callback is not invoked for each DMA operation

2018-06-21 Thread Radhey Shyam Pandey
> -Original Message- > From: Andrea Merello [mailto:andrea.mere...@gmail.com] > Sent: Wednesday, June 20, 2018 7:02 PM > To: Radhey Shyam Pandey > Cc: vk...@kernel.org; dan.j.willi...@intel.com; Michal Simek > ; Appana Durga Kedareswara Rao > ; dmaeng...@vger.kernel.

RE: [PATCH 2/3] dmaengine: xilinx_dma: Refactor axidma channel validation

2018-08-28 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod > Sent: Tuesday, August 21, 2018 9:20 PM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; Appana > Durga Kedareswara Rao ; l...@metafoo.de; > dmaeng...@vger.kernel.org; linux-arm-ker...@lists.infrad

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-28 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod > Sent: Tuesday, August 21, 2018 9:26 PM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; Appana > Durga Kedareswara Rao ; l...@metafoo.de; > dmaeng...@vger.kernel.org; linux-arm-ker...@lists.infrad

RE: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-08-29 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod > Sent: Wednesday, August 29, 2018 9:31 AM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; Appana > Durga Kedareswara Rao ; l...@metafoo.de; > dmaeng...@vger.kernel.org; linux-arm-ker...@lists.infrad

RE: [PATCH] dmaengine: Add metadata_ops for dma_async_tx_descriptor

2018-08-30 Thread Radhey Shyam Pandey
> Vinod, > > On 2018-08-29 19:22, Vinod wrote: > + * 2. use dmaengine_desc_attach_metadata() to attach the buffer to > the > + * descriptor > + * 3. submit the transfer > + * - DMA_DEV_TO_MEM: > + * 1. prepare the descriptor (dmaengine_prep_*) > + * 2. u

[PATCH 0/3] dmaengine: xilinx_dma: Minor fix and refactoring

2018-07-27 Thread Radhey Shyam Pandey
This patchset fixes 64-bit simple CDMA transfer. It also does some trivial code refactoring. Radhey Shyam Pandey (3): dmaengine: xilinx_dma: Refactor axidma channel allocation dmaengine: xilinx_dma: Refactor axidma channel validation dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

[PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-07-27 Thread Radhey Shyam Pandey
In AXI CDMA simple mode also pass MSB bits of source and destination address to xilinx_write function. This fixes simple CDMA operation mode using 64-bit addressing. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/dma/xilinx/xilinx_dma.c |6 -- 1 files

[PATCH 2/3] dmaengine: xilinx_dma: Refactor axidma channel validation

2018-07-27 Thread Radhey Shyam Pandey
In axidma start_transfer, prefer checking channel states before other params i.e pending_list. Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx

[PATCH 1/3] dmaengine: xilinx_dma: Refactor axidma channel allocation

2018-07-27 Thread Radhey Shyam Pandey
In axidma alloc_chan_resources merge BD and cyclic BD allocation. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/dma/xilinx/xilinx_dma.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/dma/xilinx

[RFC PATCH 0/2] dmaengine: xilinx_dma: Add Xilinx AXI MCDMA Engine driver support

2018-07-31 Thread Radhey Shyam Pandey
pport/documentation/ip_documentation/axi_mcdma/v1_0/pg288-axi-mcdma.pdf Radhey Shyam Pandey (2): dt-bindings: dmaengine: xilinx_dma: Add binding for Xilinx MCDMA IP dmaengine: xilinx_dma: Add Xilinx AXI MCDMA Engine driver support .../devicetree/bindings/dma/xilinx/xilinx_dma.txt | 10 +- driver

[RFC PATCH 1/2] dt-bindings: dmaengine: xilinx_dma: Add binding for Xilinx MCDMA IP

2018-07-31 Thread Radhey Shyam Pandey
: Radhey Shyam Pandey --- Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index

[RFC PATCH 2/2] dmaengine: xilinx_dma: Add Xilinx AXI MCDMA Engine driver support

2018-07-31 Thread Radhey Shyam Pandey
receive channels. Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 449 +++- 1 file changed, 440 insertions(+), 9 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index c124423..f136e5a 100644

[PATCH v2 0/4] dmaengine: xilinx_dma: Minor fix and refactoring

2018-09-29 Thread Radhey Shyam Pandey
. Radhey Shyam Pandey (4): dmaengine: xilinx_dma: Refactor axidma channel allocation dmaengine: xilinx_dma: Refactor axidma channel validation dmaengine: xilinx_dma: Introduce helper macro for preparing dma address dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer drivers/dma

[PATCH v2 2/4] dmaengine: xilinx_dma: Refactor axidma channel validation

2018-09-29 Thread Radhey Shyam Pandey
In axidma start_transfer, prefer checking channel states before other params i.e pending_list. No functional change. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: Modified the commit message to mark it as non-functional change. --- drivers/dma/xilinx/xilinx_dma.c |4 ++-- 1 files

[PATCH v2 1/4] dmaengine: xilinx_dma: Refactor axidma channel allocation

2018-09-29 Thread Radhey Shyam Pandey
In axidma alloc_chan_resources merge BD and cyclic BD allocation. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- Changes for v2: None --- drivers/dma/xilinx/xilinx_dma.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff

[PATCH v2 3/4] dmaengine: xilinx_dma: Introduce helper macro for preparing dma address

2018-09-29 Thread Radhey Shyam Pandey
This patch introduces the xilinx_prep_dma_addr_t macro which prepares dma_addr_t from hardware buffer descriptor LSB and MSB fields. It will be used in simple dma 64-bit programming sequence. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: New patch- Preparatory change for 4/4 fix

[PATCH v2 4/4] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer

2018-09-29 Thread Radhey Shyam Pandey
In AXI CDMA simple mode also pass MSB bits of source and destination address to xilinx_write function. This fixes simple CDMA operation mode using 64-bit addressing. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- Changes for v2: Use helper macro for preparing dma_addr_t

RE: [PATCH] dmaengine: fix dmaengine_desc_callback_valid() doesn't check for callback_result

2018-11-20 Thread Radhey Shyam Pandey
> -Original Message- > From: Andrea Merello > Sent: Friday, November 16, 2018 7:26 PM > To: vk...@kernel.org; dan.j.willi...@intel.com; dmaeng...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Radhey Shyam Pandey > ; Andrea Merello > Subject: [

RE: [PATCH v2 2/4] dmaengine: xilinx_dma: Refactor axidma channel validation

2018-11-14 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod Koul > Sent: Sunday, November 11, 2018 2:30 AM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; Appana > Durga Kedareswara Rao ; dmaeng...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-k

RE: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-02 Thread Radhey Shyam Pandey
> -Original Message- > From: Peter Ujfalusi [mailto:peter.ujfal...@ti.com] > Sent: Friday, June 1, 2018 3:54 PM > To: Radhey Shyam Pandey ; vinod.k...@intel.com > Cc: l...@metafoo.de; michal.si...@xilinx.com; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.

[PATCH v2 5/5] net: emaclite: Remove unnecessary spaces

2018-06-28 Thread Radhey Shyam Pandey
This patch fixes below checkpatch checks- CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: No space is necessary after a cast Signed-off-by: Radhey Shyam Pandey --- Changes from v1: - None --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 27 +-

[PATCH v2 1/5] net: emaclite: Use __func__ instead of hardcoded name

2018-06-28 Thread Radhey Shyam Pandey
ot;xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n", WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write', this function's name, in a string + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n", Signed-off-by: Radhey

[PATCH v2 4/5] net: emaclite: Fix block comments style

2018-06-28 Thread Radhey Shyam Pandey
This patch fixes below checkpatch warnings- WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: networking block comments don't use an empty /* line, use /* Comment Signed-off-by: Radhey Shyam Pandey --- Changes fr

[PATCH 0/5] Fixes coding style in xilinx_emaclite.c

2018-06-18 Thread Radhey Shyam Pandey
This patchset fixes checkpatch and kernel-doc warnings in xilinx emaclite driver. No functional change. Radhey Shyam Pandey (5): net: emaclite: Use __func__ instead of hardcoded name net: emaclite: Balance braces in else statement net: emaclite: update kernel-doc comments net: emaclite

RE: [PATCH 1/6] dmaengine: xilinx_dma: fix splitting transfer causes misalignments

2018-06-20 Thread Radhey Shyam Pandey
> -Original Message- > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine- > ow...@vger.kernel.org] On Behalf Of Andrea Merello > Sent: Wednesday, June 20, 2018 2:07 PM > To: vk...@kernel.org; dan.j.willi...@intel.com; Michal Simek > ; Appana Durga Kedareswara Rao > ; dmaeng...@vger.ke

RE: [PATCH 2/6] dmaengine: xilinx_dma: fix completion callback is not invoked for each DMA operation

2018-06-20 Thread Radhey Shyam Pandey
> -Original Message- > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine- > ow...@vger.kernel.org] On Behalf Of Andrea Merello > Sent: Wednesday, June 20, 2018 2:07 PM > To: vk...@kernel.org; dan.j.willi...@intel.com; Michal Simek > ; Appana Durga Kedareswara Rao > ; dmaeng...@vger.ke

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-30 Thread Radhey Shyam Pandey
Hi, > -Original Message- > From: Peter Ujfalusi [mailto:peter.ujfal...@ti.com] > Sent: Tuesday, May 29, 2018 8:35 PM > To: Radhey Shyam Pandey ; Vinod Koul > > Cc: Lars-Peter Clausen ; michal.si...@xilinx.com; linux- > ker...@vger.kernel.org; dmaeng...@vger.kern

[PATCH 1/4] net: emaclite: Fix position of lp->mii_bus assignment

2018-06-12 Thread Radhey Shyam Pandey
To ensure MDIO bus is not double freed in remove() path assign lp->mii_bus after MDIO bus registration. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH 4/4] net: emaclite: Remove xemaclite_mdio_setup return check

2018-06-12 Thread Radhey Shyam Pandey
Errors are already reported in xemaclite_mdio_setup so avoid reporting it again. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/net/ethernet/xilinx/xilinx_emaclite.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet

[PATCH 1/2] dt-bindings: dmaengine: xilinx_dma: Add VDMA vertical flip property

2018-06-13 Thread Radhey Shyam Pandey
The AXI VDMA core supports Vertical flip in S2MM path when Enable Vertical Flip (Advanced tab) is selected. To allow vertical flip programming define an optional 'xlnx,enable-vert-flip' channel child node property. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Mi

[PATCH 2/2] dmaengine: xilinx_dma: Enable VDMA S2MM vertical flip support

2018-06-13 Thread Radhey Shyam Pandey
Vertical flip state is exported in xilinx_vdma_config and depending on IP configuration(c_enable_vert_flip) vertical flip state is programmed in hardware. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/dma/xilinx/xilinx_dma.c | 22 ++ include

[PATCH 0/2] Enable VDMA S2MM vertical flip support

2018-06-13 Thread Radhey Shyam Pandey
The AXI VDMA core supports Vertical Flip with S2MM as the path when Enable Vertical Flip (Advanced tab) is selected. This patch series add DT property for vertical flip and program its state in VDMA start_transfer. Radhey Shyam Pandey (2): dt-bindings: dmaengine: xilinx_dma: Add VDMA vertical

RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client

2018-05-16 Thread Radhey Shyam Pandey
Hi, > -Original Message- > From: Peter Ujfalusi [mailto:peter.ujfal...@ti.com] > Sent: Tuesday, April 24, 2018 3:21 PM > To: Vinod Koul > Cc: Lars-Peter Clausen ; Radhey Shyam Pandey > ; michal.si...@xilinx.com; linux- > ker...@vger.kernel.org; dmaeng...@vger.kern

RE: [RFC PATCH 1/2] dt-bindings: dmaengine: xilinx_dma: Add binding for Xilinx MCDMA IP

2018-08-16 Thread Radhey Shyam Pandey
Hi Rob, Thanks for the review. > -Original Message- > From: Rob Herring > Sent: Tuesday, August 14, 2018 9:43 PM > To: Radhey Shyam Pandey > Cc: vk...@kernel.org; mark.rutl...@arm.com; Michal Simek > ; dan.j.willi...@intel.com; Appana Durga Kedareswara > Rao ; l.

RE: [RFC] dmaengine: Add metadata_ops for dma_async_tx_descriptor

2018-08-16 Thread Radhey Shyam Pandey
> -Original Message- > From: Peter Ujfalusi > Sent: Wednesday, August 15, 2018 4:27 PM > To: dan.j.willi...@intel.com; vk...@kernel.org > Cc: dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; > l...@metafoo.de; Radhey Shyam Pandey > Subject: [RFC] dmaengine:

RE: [RFC PATCH 2/2] dmaengine: xilinx_dma: Add Xilinx AXI MCDMA Engine driver support

2018-10-06 Thread Radhey Shyam Pandey
Thanks for the review. > On 31-07-18, 23:16, Radhey Shyam Pandey wrote: > > struct xilinx_dma_config { > > @@ -402,6 +470,7 @@ struct xilinx_dma_config { > > int (*clk_init)(struct platform_device *pdev, struct clk **axi_clk, > > struct clk **t

[PATCH v2 3/3] dmaengine: xilinx_dma: fix mixed_enum_type coverity warning

2020-12-23 Thread Radhey Shyam Pandey
ned-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - Include fixes tag. - Keep typecasting changes in the same line to increase readability. --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xi

[PATCH v2 2/3] dmaengine: xilinx_dma: fix incompatible param warning in _child_probe()

2020-12-23 Thread Radhey Shyam Pandey
incompatible_param. Fixes: 1a9e7a03c761 ("dmaengine: vdma: Add support for mulit-channel dma mode") Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - Include fixes tag. --- drivers/dma/xilinx/xilinx_dma.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v2 1/3] dmaengine: xilinx_dma: check dma_async_device_register return value

2020-12-23 Thread Radhey Shyam Pandey
ccess Engine driver support") Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - Include fixes tag. --- drivers/dma/xilinx/xilinx_dma.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/

[PATCH v2 0/3] dmaengine: xilinx_dma: coverity fixes

2020-12-23 Thread Radhey Shyam Pandey
This patch series fix coverity warnings for xilinx_dma driver. No functional change. These patches are picked from xilinx linux tree and posted for upstream. Changes for v2: - Include fixes tag. - In 3/3 patch keep typecasting changes in the same line. Shravya Kumbham (3): dmaengine: xilinx_dma

RE: dmaengine : xilinx_dma two issues

2021-01-07 Thread Radhey Shyam Pandey
> -Original Message- > From: Radhey Shyam Pandey > Sent: Monday, January 4, 2021 10:50 AM > To: Paul Thomas ; Dan Williams > ; Vinod Koul ; Michal Simek > ; Matthew Murrian ; > Romain Perier ; Krzysztof Kozlowski > ; Marc Ferland ; Sebastian von Ohr > ; dmaeng...

RE: dmaengine : xilinx_dma two issues

2021-01-08 Thread Radhey Shyam Pandey
> -Original Message- > From: Paul Thomas > Sent: Friday, January 8, 2021 9:27 PM > To: Radhey Shyam Pandey > Cc: Dan Williams ; Vinod Koul > ; Michal Simek ; Matthew Murrian > ; Romain Perier > ; Krzysztof Kozlowski ; Marc > Ferland ; Sebastian von Ohr &g

[RFC v2 PATCH 0/7] Xilinx DMA enhancements and optimization

2021-04-09 Thread Radhey Shyam Pandey
irq-delay from DT. - Remove desc_callback_valid check. - Addressed RFC v1 comments[2]. - Minor code refactoring. Comments, suggestions are very welcome! [1] https://www.spinics.net/lists/dmaengine/msg16583.html [2] https://www.spinics.net/lists/dmaengine/msg15208.html Radhey Shyam Pandey (7

[RFC v2 PATCH 1/7] dt-bindings: dmaengine: xilinx_dma: Add xlnx,axistream-connected property

2021-04-09 Thread Radhey Shyam Pandey
by: Radhey Shyam Pandey --- Changes for v2: - Rename xlnx,axieth-connected to xlnx,axistream-connected to make it generic. --- Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_

[RFC v2 PATCH 2/7] dt-bindings: dmaengine: xilinx_dma: Add xlnx,irq-delay property

2021-04-09 Thread Radhey Shyam Pandey
urs. This property is useful when AXI DMA is connected to the streaming IP i.e axiethernet where inter packet latency is critical while still taking the benefit of interrupt coalescing. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - New patch. Introduce xlnx,irq-delay property for l

[RFC v2 PATCH 3/7] dmaengine: xilinx_dma: Pass AXI4-Stream control words to dma client

2021-04-09 Thread Radhey Shyam Pandey
Read DT property to check if AXI DMA is connected to streaming IP i.e axiethernet. If connected pass AXI4-Stream control words to dma client using metadata_ops dmaengine API. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - Use descriptor metadata API to pass control words to dma client

[RFC v2 PATCH 4/7] dmaengine: xilinx_dma: Increase AXI DMA transaction segment count

2021-04-09 Thread Radhey Shyam Pandey
Increase AXI DMA transaction segments count to ensure that even in high load we always get a free segment in prepare descriptor for a DMA_SLAVE transaction. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - None --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion

[RFC v2 PATCH 5/7] dmaengine: xilinx_dma: Freeup active list based on descriptor completion bit

2021-04-09 Thread Radhey Shyam Pandey
-off-by: Radhey Shyam Pandey --- - Check BD completion bit only for SG mode. - Modify the logic to have early return path. --- drivers/dma/xilinx/xilinx_dma.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index

[RFC v2 PATCH 6/7] dmaengine: xilinx_dma: Use tasklet_hi_schedule for timing critical usecase

2021-04-09 Thread Radhey Shyam Pandey
Schedule tasklet with high priority to ensure that callback processing is prioritized. It improves throughput for netdev dma clients. Signed-off-by: Radhey Shyam Pandey -- Changes for v2: - None --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RFC v2 PATCH 7/7] dmaengine: xilinx_dma: Program interrupt delay timeout

2021-04-09 Thread Radhey Shyam Pandey
merge it with frame completion interrupt. Since by default interrupt delay timeout is disabled this feature addition has no functional impact on VDMA and CDMA IP's. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: - Read irq delay timeout value from DT. - Merge interrupt processing for

[RFC PATCH 0/3] net: axienet: Introduce dmaengine support

2021-04-09 Thread Radhey Shyam Pandey
/kernel/1804.0/00367.html This series is based on dmaengine tree commit: #a38fd8748464 Radhey Shyam Pandey (3): dt-bindings: net: xilinx_axienet: convert bindings document to yaml dt-bindings: net: xilinx_axienet: Introduce dmaengine binding support net: axienet: Introduce dmaengine support

[RFC PATCH 1/3] dt-bindings: net: xilinx_axienet: convert bindings document to yaml

2021-04-09 Thread Radhey Shyam Pandey
Convert the bindings document for Xilinx AXI Ethernet Subsystem from txt to yaml. No changes to existing binding description. Signed-off-by: Radhey Shyam Pandey --- Pending: Fix below remaining dt_binding_check warning: ethernet@40c0: 'device_type' does not match any of t

[RFC PATCH 2/3] dt-bindings: net: xilinx_axienet: Introduce dmaengine binding support

2021-04-09 Thread Radhey Shyam Pandey
, remove axidma reg and interrupt properties from the ethernet node. Just to highlight that these DT changes are not backward compatible due to major driver restructuring/cleanup done in adopting the dmaengine framework. Signed-off-by: Radhey Shyam Pandey --- .../devicetree/bindings/net

[RFC PATCH 3/3] net: axienet: Introduce dmaengine support

2021-04-09 Thread Radhey Shyam Pandey
://lore.kernel.org/lkml/1522665546-10035-1-git-send-email-radh...@xilinx.com Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_axienet.h | 141 +-- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1050 - 2 files changed, 185 insertions(+), 1006

[PATCH 0/3] dmaengine: xilinx_dma: coverity fixes

2020-12-17 Thread Radhey Shyam Pandey
This patch series fix coverity warnings for xilinx_dma driver. No functional change. These patches are picked from xilinx linux tree and posted for upstream. Shravya Kumbham (3): dmaengine: xilinx_dma: check dma_async_device_register return value dmaengine: xilinx_dma: fix incompatible param

[PATCH 1/3] dmaengine: xilinx_dma: check dma_async_device_register return value

2020-12-17 Thread Radhey Shyam Pandey
From: Shravya Kumbham dma_async_device_register() can return non-zero error code. Add condition to check the return value of dma_async_device_register function and handle the error path. Addresses-Coverity: Event check_return. Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey

[PATCH 3/3] dmaengine: xilinx_dma: fix mixed_enum_type coverity warning

2020-12-17 Thread Radhey Shyam Pandey
From: Shravya Kumbham Typecast the fls(width -1) with (enum dmaengine_alignment) in xilinx_dma_chan_probe function to fix the coverity warning. Addresses-Coverity: Event mixed_enum_type. Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 3

[PATCH 2/3] dmaengine: xilinx_dma: fix incompatible param warning in _child_probe()

2020-12-17 Thread Radhey Shyam Pandey
incompatible_param. Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index e41435be5b79..cf75e2af6381 100644

RE: [PATCH net v2] net: emaclite: Add error handling for of_address_ and _mdio_setup functions

2020-12-17 Thread Radhey Shyam Pandey
> -Original Message- > From: Denis Kirjanov > Sent: Tuesday, November 17, 2020 6:43 PM > To: Radhey Shyam Pandey > Cc: da...@davemloft.net; net...@vger.kernel.org; k...@kernel.org; > Michal Simek ; mchehab+sams...@kernel.org; > gre...@linuxfoundation.org; nicola

RE: dmaengine : xilinx_dma two issues

2021-01-03 Thread Radhey Shyam Pandey
> -Original Message- > From: Paul Thomas > Sent: Monday, December 28, 2020 10:14 AM > To: Dan Williams ; Vinod Koul > ; Michal Simek ; Radhey Shyam > Pandey ; Matthew Murrian > ; Romain Perier > ; Krzysztof Kozlowski ; Marc > Ferland ; Sebastian von Ohr &g

RE: dmaengine : xilinx_dma two issues

2021-01-17 Thread Radhey Shyam Pandey
> -Original Message- > From: Paul Thomas > Sent: Saturday, January 16, 2021 1:00 AM > To: Radhey Shyam Pandey > Cc: Dan Williams ; Vinod Koul > ; Michal Simek ; Matthew Murrian > ; Romain Perier > ; Krzysztof Kozlowski ; Marc > Ferland ; Sebastian von Ohr &g

[PATCH net-next] MAINTAINERS: add myself as maintainer for xilinx axiethernet driver

2019-09-05 Thread Radhey Shyam Pandey
I am maintaining xilinx axiethernet driver in xilinx tree and would like to maintain it in the mainline kernel as well. Hence adding myself as a maintainer. Also Anirudha and John has moved to new roles, so based on request removing them from the maintainer list. Signed-off-by: Radhey Shyam

[PATCH -next 4/8] dmaengine: xilinx_dma: Add callback_result support

2019-09-05 Thread Radhey Shyam Pandey
number of bytes transferred. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index

[PATCH -next 3/8] dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue

2019-09-05 Thread Radhey Shyam Pandey
From: Nicholas Graumann Introduce a function that can calculate residues for IPs that support it: AXI DMA and CDMA. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 75 ++--- 1 file changed, 56

[PATCH -next 0/8] AXI DMA driver improvements

2019-09-05 Thread Radhey Shyam Pandey
: xilinx_dma: Remove residue from channel data dmaengine: xilinx_dma: Print debug message when no free tx segments dmaengine: xilinx_dma: Check for both idle and halted state in axidma stop_transfer dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset Radhey Shyam Pandey (1

[PATCH -next 5/8] dmaengine: xilinx_dma: Remove residue from channel data

2019-09-05 Thread Radhey Shyam Pandey
From: Nicholas Graumann Now that we track residues for each descriptor, there is no need to keep track of the residue for each channel. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH -next 2/8] dmaengine: xilinx_dma: Merge get_callback and _invoke

2019-09-05 Thread Radhey Shyam Pandey
From: Nicholas Graumann The dma api provides a single interface to get the appropriate callback and invoke it directly. Prefer using it. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH -next 1/8] dmaengine: xilinx_dma: Remove desc_callback_valid check

2019-09-05 Thread Radhey Shyam Pandey
In descriptor cleanup the call to desc_callback_valid can be safely removed as both callback pointers i.e callback_result and callback are anyway checked in invoke(). There is no much benefit in having redundant checks. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Nicholas Graumann

[PATCH -next 6/8] dmaengine: xilinx_dma: Print debug message when no free tx segments

2019-09-05 Thread Radhey Shyam Pandey
they are experiencing issues. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index bf3fa2e..b5dd62a 100644 --- a

[PATCH -next 7/8] dmaengine: xilinx_dma: Check for both idle and halted state in axidma stop_transfer

2019-09-05 Thread Radhey Shyam Pandey
From: Nicholas Graumann When polling for a stopped transfer in AXI DMA mode, in some cases the status of the channel may indicate IDLE instead of HALTED if the channel was reset due to an error. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx

[PATCH -next 8/8] dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset

2019-09-05 Thread Radhey Shyam Pandey
terminating pending transactions with xilinx_dma_terminate_all() and then submitting new transactions without releasing and requesting the channel. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a

RE: [PATCH -next 3/8] dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue

2019-10-01 Thread Radhey Shyam Pandey
> -Original Message- > From: Radhey Shyam Pandey > Sent: Friday, September 27, 2019 10:46 AM > To: Vinod Koul > Cc: dan.j.willi...@intel.com; Michal Simek ; > nick.graum...@gmail.com; andrea.mere...@gmail.com; Appana Durga > Kedareswara Rao ; mcg...@kernel.org; > d

RE: [PATCH] ethernet: Use devm_platform_ioremap_resource() in three functions

2019-09-18 Thread Radhey Shyam Pandey
> -Original Message- > From: Markus Elfring > Sent: Wednesday, September 18, 2019 7:01 PM > To: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; David S. > Miller ; Hans Ulli Kroll ; > Hauke Mehrtens ; Linus Walleij > ; Michal Simek ; Radhey >

RE: [PATCH v2] ethernet: axienet: Use devm_platform_ioremap_resource() in axienet_probe()

2019-09-20 Thread Radhey Shyam Pandey
> -Original Message- > From: Markus Elfring > Sent: Friday, September 20, 2019 5:01 PM > To: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; David S. > Miller ; Michal Simek ; > Radhey Shyam Pandey > Cc: LKML ; kernel-janit...@vger.kernel.org > Subj

RE: [PATCH -next 3/8] dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue

2019-09-25 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod Koul > Sent: Thursday, September 26, 2019 2:31 AM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; > nick.graum...@gmail.com; andrea.mere...@gmail.com; Appana Durga > Kedareswara Rao ; mcg...

[PATCH -next 0/4] dmaengine: xilinx_dma: Minor functional fixes

2019-09-26 Thread Radhey Shyam Pandey
This patchset fixes axidma simple mode 64-bit transfer. It clears vdma control registers before update, in probe use devm_platform API and remove clk_get error in case of EPROBE_DEFER. Radhey Shyam Pandey (4): dmaengine: xilinx_dma: Fix 64-bit simple AXIDMA transfer dmaengine: xilinx_dma

[PATCH -next 2/4] dmaengine: xilinx_dma: Fix control reg update in vdma_channel_set_config

2019-09-26 Thread Radhey Shyam Pandey
In vdma_channel_set_config clear the delay, frame count and master mask before updating their new values. It avoids programming incorrect state when input parameters are different from default. Signed-off-by: Radhey Shyam Pandey Acked-by: Appana Durga Kedareswara rao Signed-off-by: Michal Simek

[PATCH -next 1/4] dmaengine: xilinx_dma: Fix 64-bit simple AXIDMA transfer

2019-09-26 Thread Radhey Shyam Pandey
In AXI DMA simple mode also pass MSB bits of source and destination address to xilinx_write function. It fixes simple AXI DMA operation mode using 64-bit addressing. Signed-off-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH -next 4/4] dmaengine: xilinx_dma: Remove clk_get error message for probe defer

2019-09-26 Thread Radhey Shyam Pandey
In dma probe, the driver checks for devm_clk_get return and print error message in the failing case. However for -EPROBE_DEFER this message is confusing so avoid it. Signed-off-by: Radhey Shyam Pandey Signed-off-by: Michal Simek --- drivers/dma/xilinx/xilinx_dma.c | 19 ++- 1

[PATCH -next 3/4] dmaengine: xilinx_dma: use devm_platform_ioremap_resource()

2019-09-26 Thread Radhey Shyam Pandey
Replace the chain of platform_get_resource() and devm_ioremap_resource() with devm_platform_ioremap_resource(). It simplifies the flow and there is no functional change. Fixes below cocinelle warning- WARNING: Use devm_platform_ioremap_resource for xdev -> regs Signed-off-by: Radhey Shyam Pan

RE: [PATCH -next 3/8] dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue

2019-09-26 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod Koul > Sent: Thursday, September 26, 2019 10:48 PM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; > nick.graum...@gmail.com; andrea.mere...@gmail.com; Appana Durga > Kedareswara Rao ; mcg...

RE: [PATCH -next 7/8] dmaengine: xilinx_dma: Check for both idle and halted state in axidma stop_transfer

2019-09-26 Thread Radhey Shyam Pandey
> -Original Message- > From: Vinod Koul > Sent: Thursday, September 26, 2019 10:51 PM > To: Radhey Shyam Pandey > Cc: dan.j.willi...@intel.com; Michal Simek ; > nick.graum...@gmail.com; andrea.mere...@gmail.com; Appana Durga > Kedareswara Rao ; mcg...

RE: [PATCH -next 7/8] dmaengine: xilinx_dma: Check for both idle and halted state in axidma stop_transfer

2019-09-27 Thread Radhey Shyam Pandey
> -Original Message- > From: Nicholas Graumann > Sent: Friday, September 27, 2019 7:27 PM > To: Radhey Shyam Pandey > Cc: Vinod Koul ; dan.j.willi...@intel.com; Michal Simek > ; andrea.mere...@gmail.com; Appana Durga > Kedareswara Rao ; mcg...@kernel.org; > d

[PATCH -next 2/6] dt-bindings: dmaengine: xilinx_dma: Fix formatting and style

2019-10-22 Thread Radhey Shyam Pandey
Trivial formatting(keep compatible string one per line, caps change etc). It doesn't modify the content of the binding. Signed-off-by: Radhey Shyam Pandey --- Changes since RFC: New patch. Trivial formatting (compatible string one per line) as suggested by Rob in MCDMA RFC s

[PATCH -next 1/6] dt-bindings: dmaengine: xilinx_dma: Remove axidma multichannel support

2019-10-22 Thread Radhey Shyam Pandey
optional properties i.e xlnx,mcdma and dma-channels from the binding description. Signed-off-by: Radhey Shyam Pandey --- Changes since RFC: New patch. --- Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH -next 0/6] dmaengine: xilinx_dma: Add Xilinx AXI MCDMA Engine driver support

2019-10-22 Thread Radhey Shyam Pandey
chset is based on next and previous[3] axidma series. [1] https://www.xilinx.com/support/documentation/ip_documentation/axi_mcdma/v1_0/pg288-axi-mcdma.pdf [2] https://spinics.net/lists/devicetree/msg242427.html [3] https://www.spinics.net/lists/dmaengine/msg19910.html Radhey Shyam Pandey (6):

[PATCH -next 4/6] dmaengine: xilinx_dma: Remove axidma multichannel mode support

2019-10-22 Thread Radhey Shyam Pandey
-off-by: Radhey Shyam Pandey --- Changes since RFC: New patch. --- drivers/dma/xilinx/xilinx_dma.c | 155 +++- 1 file changed, 8 insertions(+), 147 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 41189b6

[PATCH -next 6/6] dmaengine: xilinx_dma: Add Xilinx AXI MCDMA Engine driver support

2019-10-22 Thread Radhey Shyam Pandey
receive channels. The driver supports device_prep_slave_sg slave transfer mode. Signed-off-by: Radhey Shyam Pandey --- Changes since RFC: Mention that xilinx_mcdma_start_transfer is called with lock held. Remove bogus empty lines. Fix xilinx_mcdma_prep_slave_sg indentation. In mcdma slave_sg

[PATCH -next 5/6] dmaengine: xilinx_dma: Extend dma_config struct to store irq routine handle

2019-10-22 Thread Radhey Shyam Pandey
Extend dma_config structure to store irq routine handle. It enables runtime handler selection based on xdma_ip_type and serves as preparatory patch for adding MCDMA IP support. Signed-off-by: Radhey Shyam Pandey Suggested-by: Vinod Koul --- Changes since RFC: New patch. It serve as a

[PATCH -next 3/6] dt-bindings: dmaengine: xilinx_dma: Add binding for Xilinx MCDMA IP

2019-10-22 Thread Radhey Shyam Pandey
independent configuration. Signed-off-by: Radhey Shyam Pandey --- Keep compatible string one per line. Suggested by Rob. Reuse the existing xlnx,axi-dma-* channel names. Suggested by Rob. --- .../devicetree/bindings/dma/xilinx/xilinx_dma.txt | 15 +++ 1 file changed, 11 insertions(+), 4

RE: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as supported platform

2019-10-23 Thread Radhey Shyam Pandey
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, October 22, 2019 11:00 PM > To: Michal Simek > Cc: Radhey Shyam Pandey ; da...@davemloft.net; > net...@vger.kernel.org; Anirudha Sarangi ; John Linn > ; mchehab+sams...@kernel.org; > gre...@linuxfo

[PATCH v2 -next 0/7] dmaengine: xilinx_dma: AXI DMA driver improvements

2019-10-15 Thread Radhey Shyam Pandey
dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue dmaengine: xilinx_dma: Add callback_result support dmaengine: xilinx_dma: Print debug message when no free tx segments dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset Radhey Shyam Pandey (2): dmaengine: xilinx_dma

[PATCH v2 -next 5/7] dmaengine: xilinx_dma: Add callback_result support

2019-10-15 Thread Radhey Shyam Pandey
number of bytes transferred. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- Changes for v2: Invoke xilinx_dma_get_residue only for valid combination. --- drivers/dma/xilinx/xilinx_dma.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff

[PATCH v2 -next 3/7] dmaengine: xilinx_dma: Remove residue from channel data

2019-10-15 Thread Radhey Shyam Pandey
There is no use of storing channel data residue field. So clean it up. In tx_status simply pass calculated residue to dma_set_residue. Signed-off-by: Radhey Shyam Pandey --- Changes for v2: New patch , derived from 5/7 dmaengine: xilinx_dma: Remove residue from channel data. --- drivers/dma

[PATCH v2 -next 6/7] dmaengine: xilinx_dma: Print debug message when no free tx segments

2019-10-15 Thread Radhey Shyam Pandey
they are experiencing issues. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- Changes for v2: None --- drivers/dma/xilinx/xilinx_dma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 932407a

[PATCH v2 -next 7/7] dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset

2019-10-15 Thread Radhey Shyam Pandey
terminating pending transactions with xilinx_dma_terminate_all() and then submitting new transactions without releasing and requesting the channel. Signed-off-by: Nicholas Graumann Signed-off-by: Radhey Shyam Pandey --- Changes for v2: None --- drivers/dma/xilinx/xilinx_dma.c | 1 + 1 file changed, 1

  1   2   >