Just thought it worth mentioning, this new patch that fixes sound
again, seems to have ressurected an old issue with PLL unlock. I'm
seeing journal entries after fresh boot ..
```
picard kernel: max98090 i2c-193C9890:00: PLL unlocked
picard systemd[462]: Started Sound Service.
picard kern
On 11/5/18 6:58 PM, He, Bo wrote:
Hi,
I submit the patch based on tag v4.19.
Please don't post on mailing lists.
-Original Message-
From: Pierre-Louis Bossart
Sent: Tuesday, November 6, 2018 1:02 AM
To: He, Bo ; alsa-de...@alsa-project.org;
linux-kernel@vger.kernel.o
On 11/2/18 6:24 AM, Arnd Bergmann wrote:
The skylake sound support is written to work both with or without
CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should
link against that. However, this fails with SND_SOC_ALL_CODECS=m or
SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH=m when th
ails.
yes indeed, good catch.
Acked-by: Pierre-Louis Bossart
Fixes: 9012c9544eea ("ASoC: Intel: mrfld - Add DSP load and management")
Signed-off-by: Arnd Bergmann
---
sound/soc/intel/atom/sst/sst_loader.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
On 11/2/18 5:03 PM, Arnd Bergmann wrote:
On 11/2/18, Pierre-Louis Bossart wrote:
On 11/2/18 6:24 AM, Arnd Bergmann wrote:
The skylake sound support is written to work both with or without
CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should
link against that. However
On 11/5/18 2:29 AM, He, Bo wrote:
skl->dais is allocated with devm_kcalloc, can't free with
the krealloc. Memory allocated with devm API is automatically freed
on driver detach, Like all other devres resources.
Refer to drivers/base/devres.c devm_kmalloc for more details.
What code are you l
We have this ("strange") lines over the drivers:
config BAR
depends on FOO || FOO=n
which guarantees that FOO will be not module when BAR is built-in.
That's what I normally use, but I could not figure this one out.
One problem is that SND_SOC_ALL_CODECS selects
SND_SOC_HDAC_HDA, and SND_SOC
+static const struct acpi_device_id privacy_acpi_device_ids[] = {
+ {"PNP0C09", 0},
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, privacy_acpi_device_ids);
+
+static struct platform_driver dell_privacy_platform_drv = {
+ .driver = {
+ .name = PRIVACY_PLATFORM_NAME,
+ .acpi_match_
On 05/22/2018 11:58 AM, Guenter Roeck wrote:
From: Guenter Roeck
Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE
DAI") introduced sound topology files version 5. Initially, this
change made the topology code incompatible with v4 topology files.
Backwards compatibility with v4
On 5/23/18 3:24 AM, Mark Brown wrote:
On Tue, May 22, 2018 at 02:59:35PM -0500, Pierre-Louis Bossart wrote:
I am also not convinced by the notion that maintaining topology files is
only a userspace/distro issue. This would mean some distros will have access
to the required topology files
ave any devices on which I can test but the code looks ok
compared to chromeos-3.18 (minor comments below).
Reviewed-by: Pierre-Louis Bossart
---
Tested on Caroline (Samsung Chromebook Pro) running v4.17-rc6 plus
this patch, with original (v4) configuration file. Also tested on
several other Chro
+static int skl_tplg_get_pvt_data_v4(struct snd_soc_tplg_dapm_widget
*tplg_w,
+ struct skl *skl, struct device *dev,
+ struct skl_module_cfg *mconfig)
+{
+ struct skl_dfw_v4_module *dfw =
+ (struct
'slave' in M4 files
but expand to 'codec_slave' in the .conf to avoid making this exception
visible).
Signed-off-by: Kirill Marinushkin
Cc: Mark Brown
Cc: Pierre-Louis Bossart
Cc: Pan Xiuli
Cc: Liam Girdwood
Cc: linux-kernel@vger.kernel.org
Cc: alsa-de...@alsa-project.org
On 04/03/2018 12:15 AM, Kirill Marinushkin wrote:
On 04/03/18 02:57, Pierre-Louis Bossart wrote:
On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
Hello Pierre-Louis,
I explicitly clarified with Takashi: to have this patch series merged, we need a
tag "Reviewed-by" from you.
On 4/3/18 1:16 PM, Kirill Marinushkin wrote:
On 04/03/18 19:21, Pierre-Louis Bossart wrote:
On 04/03/2018 12:15 AM, Kirill Marinushkin wrote:
On 04/03/18 02:57, Pierre-Louis Bossart wrote:
On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
Hello Pierre-Louis,
I explicitly clarified with
On 4/3/18 11:19 PM, Kirill Marinushkin wrote:
Hello Mark,
This patch series waits since 20th of February, because it modifies UAPI headers
and should be done in sync with ALSA. I see that previously there was no clear
understanding, how to do this in sync.
Two days ago I discussed with Takashi,
On 4/30/18 4:23 AM, Akshu Agrawal wrote:
Non-dts based systems can use ACPI DSDT to pass on the mclk
to da7219.
This enables da7219 mclk to be linked to system clock.
Enable/Disable of the mclk is already handled in the codec so
platform drivers don't have to explicitly do handling of mclk.
Sign
On 5/1/18 9:31 AM, Agrawal, Akshu wrote:
On 4/30/2018 9:54 PM, Pierre-Louis Bossart wrote:
On 4/30/18 4:23 AM, Akshu Agrawal wrote:
Non-dts based systems can use ACPI DSDT to pass on the mclk
to da7219.
This enables da7219 mclk to be linked to system clock.
Enable/Disable of the mclk is
for rt5640.
Acked-by: Pierre-Louis Bossart
Fixes: 02c0a3b3047f ("ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups")
Signed-off-by: Colin Ian King
---
sound/soc/intel/boards/bytcr_rt5651.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/so
On 06/01/2018 12:08 PM, Mark Brown wrote:
On Fri, Jun 01, 2018 at 10:19:58AM -0500, Pierre-Louis Bossart wrote:
I wanted to ack this patch but the Intel validation folks asked for a couple
of days to finish their tests on a variety of Chromebooks (e.g. Lars) and
double-check which models
ed
F: drivers/video/fbdev/i810/
-INTEL ASoC BDW/HSW DRIVERS
+INTEL ASoC DRIVERS
+M: Pierre-Louis Bossart
+M: Liam Girdwood
M: Jie Yang
L: alsa-de...@alsa-project.org (moderated for non-subscribers)
S: Supported
-F: sound/soc/intel/common/sst-dsp*
-F: sound/soc/intel/c
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index 19c8efb9a5ee..84876a74874f 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -4,7 +4,7 @@
menuconfig SOUNDWIRE
bool "SoundWire support"
- ---help---
+ help
Not sure if
On 4/17/19 10:11 AM, Yue Haibing wrote:
From: YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
sound/soc/intel/haswell/sst-haswell-ipc.c: In function 'hsw_stream_message':
sound/soc/intel/haswell/sst-haswell-ipc.c:669:29: warning: variable
'stage_type' set but not used [-Wunused-but-
set but not used [-Wunused-but-set-variable]
It is never used since introduction in
commit ba57f68235cf ("ASoC: Intel: create haswell folder and move haswell platform
files in")
Signed-off-by: YueHaibing
Acked-by: Pierre-Louis Bossart
Thanks!
---
v2: also remove the va
On 4/24/19 6:41 AM, Anders Roxell wrote:
When building bytcht_es8316 the following warning shows up:
../sound/soc/intel/boards/bytcht_es8316.c: In function
‘snd_byt_cht_es8316_mc_probe’:
../sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to
integer of different size [
On 1/24/19 11:16 PM, Mogens Jensen wrote:
‐‐‐ Original Message ‐‐‐
On Tuesday, January 22, 2019 7:27 PM, Pierre-Louis Bossart
wrote:
On 1/20/19 11:55 PM, Mogens Jensen wrote:
The only minor annoyance I'm experiencing now, is a large amount of debug
output from somethi
The only minor annoyance I'm experiencing now, is a large amount of debug
output from something in kernel log when audio is played on the system:
writing to lpe: : 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00
U...
writing to lpe: : 01 01 01 01 00 00 1a 00 ff ff
On 4/8/19 2:12 AM, Jan Kotas wrote:
On 5 Apr 2019, at 17:04, Pierre-Louis Bossart
wrote:
On 4/5/19 2:26 AM, Jan Kotas wrote:
ret = pm_runtime_get_sync(slave->bus->dev);
- if (ret < 0)
+ if (ret < 0 && ret != -EACCES)
There was a patch submitted
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.
Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.
Signed-off-by: Pierre-Louis Bossart
newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (4):
soundwire: fix style issues
soundwire: bus: remove useless initializations
soundwire: stream: remove useless initialization of local variable
soundwire: add missing newlines in dynamic debug logs
drivers/soundwire
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 74 +--
drivers/soundwire/cadence_master.c | 12 ++--
drivers/soundwire/intel.c | 12
no need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a
value that is never used.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
this.
Fix Kconfig help, spelling, SPDX format, alignment, spurious
parentheses, bool comparisons to true/false, macro argument
protection.
No new functionality added.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c
the number of elements and size are inverted, fix.
This probably only worked because the number of properties is
hard-coded to 1.
Fixes: 71bb8a1b059e ('soundwire: intel: Add Intel Master driver')
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 4 ++--
1 file
this.
Fix Kconfig help, spelling, SPDX format, alignment, spurious
parentheses, bool comparisons to true/false, macro argument
protection.
No new functionality added.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c
inversion of devm_kcalloc parameters, detected while rebasing
additional patches.
Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (5):
soundwire: intel: fix inversion in devm_kcalloc parameters
soundwire: fix style issues
soundwire: bus: remove
no need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a
value that is never used.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.
Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.
Signed-off-by: Pierre-Louis Bossart
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 74 +--
drivers/soundwire/cadence_master.c | 12 ++--
drivers/soundwire/intel.c | 12
On 2/17/21 6:47 AM, Perry Yuan wrote:
Hi Pierre:
On 2021/2/16 22:56, Pierre-Louis Bossart wrote:
+static const struct acpi_device_id privacy_acpi_device_ids[] = {
+ {"PNP0C09", 0},
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, privacy_acpi_device_ids);
+
+static struct platf
On 2/1/21 10:18 PM, Vinod Koul wrote:
On 01-02-21, 10:10, Pierre-Louis Bossart wrote:
On 2/1/21 4:14 AM, Vinod Koul wrote:
On 21-01-21, 17:23, Srinivas Kandagatla wrote:
On 21/01/2021 15:12, Pierre-Louis Bossart wrote:
On 1/21/21 6:03 AM, Srinivas Kandagatla wrote:
I totally agree!
If
On 2/1/21 10:39 PM, Vinod Koul wrote:
On 01-02-21, 10:18, Pierre-Louis Bossart wrote:
On 2/1/21 4:38 AM, Vinod Koul wrote:
On 01-02-21, 15:58, Vinod Koul wrote:
On 26-01-21, 16:37, Bard Liao wrote:
struct sdw_master_prop {
u32 revision;
@@ -421,8 +422,11 @@ struct
+ prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH;
Should this not be last 'enabling' the quirk patch in series :)
Sorry, I don't understand the comment. Do you mind clarifying Vinod?
Sure, I would like to series built as, first defining the quirk
along/followed by bus changes
generates interrupt after it successfully finishes. This is really
overhead, limiting and not really necessary unless we are doing
something special.
We can simply read/write the fifo that should also give exactly
what we need! This will also allow to read/write registers in
interrupt context,
struct qcom_swrm_port_config {
u8 si;
u8 off1;
u8 off2;
u8 bp_mode;
+ u8 hstart;
+ u8 hstop;
+ u8 word_length;
+ u8 bgp_count;
I couldn't figure out what 'bgp' was and had to search. Not sure how you
came up with this abbreviation of
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
version 1.5.1 and higher IPs of this controller required to set
continue execution on ingored command flag. This patch sets this flag.
typo: ignored.
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked. Each of these are using a special command id that
what does 'kinda blocked' mean?
generates interrupt after it successfully finishes. This is really
over
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
Add support to new interrupts and update irq routine in a way
to deal with multiple pending interrupts with in a single interrupt!
I can't parse the wording after 'update irq routine'.
+ swrm->reg_write(swrm, SWRM_INTERRUPT_CLEAR, intr
On 2/1/21 4:14 AM, Vinod Koul wrote:
On 21-01-21, 17:23, Srinivas Kandagatla wrote:
On 21/01/2021 15:12, Pierre-Louis Bossart wrote:
On 1/21/21 6:03 AM, Srinivas Kandagatla wrote:
On 19/01/2021 19:09, Pierre-Louis Bossart wrote:
currently we have
/sys/kernel/debug/soundwire/master
On 2/1/21 4:38 AM, Vinod Koul wrote:
On 01-02-21, 15:58, Vinod Koul wrote:
On 26-01-21, 16:37, Bard Liao wrote:
struct sdw_master_prop {
u32 revision;
@@ -421,8 +422,11 @@ struct sdw_master_prop {
u32 err_threshold;
u32 mclk_freq;
bool hw_disabled;
+
On 2/1/21 9:50 AM, Srinivas Kandagatla wrote:
On 29/01/2021 19:33, Pierre-Louis Bossart wrote:
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote:
In the existing code every soundwire register read and register write
are kinda blocked. Each of these are using a special command id that
struct qcom_swrm_port_config {
u8 si;
u8 off1;
u8 off2;
u8 bp_mode;
+ u8 hstart;
+ u8 hstop;
+ u8 word_length;
+ u8 bgp_count;
I couldn't figure out what 'bgp' was and had to search. Not sure how
you came up with this abbreviation of "qcom,ports-block-gr
* Set SCP_INT1_MASK register, typically bus clash and
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index f7ba1a77a1df..c1fdc85d0a74 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -1286,7 +1286,8 @@ static int sdw_master_read_intel_prop(s
On 2/1/21 4:42 AM, Vinod Koul wrote:
On 26-01-21, 16:37, Bard Liao wrote:
There is nothing we can do to handle the bus clash interrupt before
interrupt mask is enabled.
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2
On 2/8/21 2:12 AM, Shengjiu Wang wrote:
This log message should be a debug message, because it
doesn't return directly but continue next loop.
Signed-off-by: Shengjiu Wang
---
sound/soc/soc-pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-pcm.c b
On 2/9/21 4:23 PM, Mark Brown wrote:
On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote:
If you demote this to dev_dbg, we'll have to ask every single user who
reports 'sound is broken' to enable dynamic debug traces. I really don't see
the benefit, thi
On 2/26/21 9:58 AM, Srinivas Kandagatla wrote:
Some of the transport parameters derived from device tree
are not fully parsed by the driver.
This patch adds support to parse those missing parameters.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 99
+ pm_runtime_get_sync(ctrl->dev);
if this fails you've got to do a put_noidle().
we use this for Intel:
ret = pm_runtime_get_sync(cdns->dev);
if (ret < 0 && ret != -EACCES) {
dev_err_ratelimited(cdns->dev,
"pm_runtime
+static int qcom_swrm_enumerate(struct sdw_bus *bus)
+{
+ struct qcom_swrm_ctrl *ctrl = to_qcom_sdw(bus);
+ struct sdw_slave *slave, *_s;
+ struct sdw_slave_id id;
+ u32 val1, val2;
+ u64 addr;
+ int i;
+ char *buf1 = (char *)&val1, *buf2 = (char *)&val
.
Addresses-Coverity: ("Unchecked return value")
Fixes: f139546fb7d4 ("ASoC: Intel: boards: sof-wm8804: support for Hifiberry
Digiplus boards")
Signed-off-by: Colin Ian King
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/sof_wm8804.c | 6 +-
1 file c
On 6/1/20 12:38 AM, Greg KH wrote:
On Mon, Jun 01, 2020 at 01:28:07AM +0800, Bard Liao wrote:
From: Pierre-Louis Bossart
Change SPDX from GPL-2.0 to GPL-2.0-only for Intel-contributed
code. This was explicit before the transition to SPDX and lost in
translation.
It is also explicit in
ut I
maintain that we have to reach a point where configurations make sense
before we can clean them up. If we implicitly push issues under the rug
by not even being aware of them we'll never make progress.
Cc: Pierre-Louis Bossart
Signed-off-by: Jerome Brunet
---
Hi Mark,
Be
On 7/29/20 6:03 AM, Brent Lu wrote:
From: Yu-Hsuan Hsu
The CRAS server does not set the period size in hw_param so ALSA will
calculate a value for period size which is based on the buffer size
and other parameters. The value may not always be aligned with Atom's
dsp design so a constraint is
Is this patch required if you've already constrained the period sizes for the
platform driver in patch1?
Yes or alsa will select 320 as default period size for it.
ok, then that's a miss in your patch1. 320 samples is a multiple of 1ms
for 48kHz rates. I think it was valid only for the 16
On 7/30/20 10:27 AM, Pierre-Louis Bossart wrote:
Is this patch required if you've already constrained the period sizes
for the
platform driver in patch1?
Yes or alsa will select 320 as default period size for it.
ok, then that's a miss in your patch1. 320 samples is a multi
On 7/30/20 4:04 AM, Jerome Brunet wrote:
On Wed 29 Jul 2020 at 17:56, Pierre-Louis Bossart
wrote:
On 7/29/20 10:46 AM, Jerome Brunet wrote:
commit b73287f0b0745 ('ASoC: soc-pcm: dpcm: fix playback/capture checks')
changed dpcm_playback and dpcm_capture semantic by throwing a
On 5/21/20 8:47 AM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
snd_soc_dai_hw
has to apply a specific fixup for itself.
Best regards,
Lukasz
czw., 21 maj 2020 o 16:25 Pierre-Louis Bossart
napisał(a):
On 5/21/20 8:47 AM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_
On 5/21/20 11:25 AM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
snd_soc_dai_h
On 5/21/20 12:08 PM, Łukasz Majczak wrote:
don't add a new dailink, this is not right.
Can you advise a better solution how to assign different fixup
functions to mic and to speakers? I was looking at "dmic01" dailink in
skl_nau88l25_max98357a.c as an example.
I am not sure I follow. the
p1 fixup.
for SSP0, we have RT5514 for capture and max98927 for playback, but the
existing code does not explicitly deal with rate/channels/format for all
cases, so it's not clear what should happen.
Harsha, can you help here?
Best regards,
Lukasz
czw., 21 maj 2020 o 19:17 Pierre-Loui
cppcheck warnings: (new ones prefixed by >>)
sound/soc/codecs/max98373-sdw.c:325:4: warning: Variable 'i' is reassigned a
value before the old one has been used. [redundantAssignment]
i = 0;
^
sound/soc/codecs/max98373-sdw.c:313:4: note: Variable 'i' is reassigned a
value b
... Why only 240? That's the next logical question.
If you have a clarification for it, it may be the rigid reason to
introduce such a hw constraint.
According to Brent, the DSP is using 240 period regardless the
hw_param. If the period size is 256, DSP will read 256 samples each
time but o
After doing some experiments, I think I can identify the problem more precisely.
1. aplay can not reproduce this issue because it writes samples
immediately when there are some space in the buffer. However, you can
add --test-position to see how the delay grows with period size 256.
aplay -Dhw
On 8/12/20 9:55 AM, Takashi Iwai wrote:
On Wed, 12 Aug 2020 16:46:40 +0200,
Pierre-Louis Bossart wrote:
After doing some experiments, I think I can identify the problem more precisely.
1. aplay can not reproduce this issue because it writes samples
immediately when there are some space in
On 8/12/20 11:08 AM, Lu, Brent wrote:
I also wonder what's really missing, too :)
BTW, I took a look back at the thread, and CRAS seems using a very
large buffer, namely:
[ 52.434791] sound pcmC1D0p: PERIOD_SIZE [240:240]
[ 52.434802] sound pcmC1D0p: BUFFER_SIZE [204480:204480]
yes
On 8/3/20 8:00 AM, Lu, Brent wrote:
Again, is this fixed 240 is a must? Or is this also an alignment issue?
Hi Takashi,
I think it's a must for Chromebooks. Google found this value works
best with their CRAS server running on their BSW products. They
offered this patch for their own Chrome
On 8/20/20 6:39 PM, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc-fixes tree, today's linux-next build
(x86_64 allmodconfig) produced these warnings:
WARNING: modpost: module snd-sof-intel-hda-common uses symbol
sdw_intel_acpi_scan from namespace SOUNDWIRE_INTEL_INIT, but doe
On 8/9/20 3:56 AM, Dinghao Liu wrote:
When power_up_sst() fails, stream needs to be freed
just like when try_module_get() fails. However, current
code is returning directly and ends up leaking memory.
Fixes: 0121327c1a68b ("ASoC: Intel: mfld-pcm: add control for powering up/down
dsp")
Signed
On 8/7/20 8:21 PM, Randy Dunlap wrote:
Drop the repeated words {that, the} in comments.
Signed-off-by: Randy Dunlap
Cc: Liam Girdwood
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Acked-by: Pierre-Louis Bossart
Thanks Randy.
---
sound/soc/sof/intel/cnl.c |2 +-
sound/soc/sof
On 8/6/20 11:41 AM, Lu, Brent wrote:
I don't get this. If the platform driver already stated 240 and 960 samples why
would 432 be chosen? Doesn't this mean the constraint is not applied?
Hi Pierre,
Sorry for late reply. I used following constraints in V3 patch so any period
which
aligns 1
On 8/18/20 1:36 AM, Vinod Koul wrote:
On 18-08-20, 01:47, Bard Liao wrote:
From: Pierre-Louis Bossart
The existing code allocates memory for the total number of ports.
This only works if the ports are contiguous, but will break if e.g. a
Devices uses port0, 1, and 14. The port_ready
In addition, there's a WIP change to regmap to add support for SoundWire
1.2 MBQ-based register access, but this only affects regmap and ASoC
trees, all handled by Mark.
I have to take this comment back, the regmap change will depend on the
MBQ macro that should go in the SoundWire tree.
On 8/19/20 4:06 AM, Vinod Koul wrote:
On 18-08-20, 06:23, Bard Liao wrote:
From: Pierre-Louis Bossart
In system suspend stress cases, the SOF CI reports timeouts. The root
cause is that an alert is generated while the system suspends. The
interrupt handling generates transactions on the
On 12/15/20 10:16 PM, Chris Chiu wrote:
DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add
quirks to select the correct input map, jack-detect options to enable
jack sensing and internal/headset microphones.
Signed-off-by: Chris Chiu
You probably need to re-send and CC: ma
despite being
non CR does not work
3. Despite 1. and 2. still have their IPC IRQ at index 0 rather then 5
Add a DMI quirk table to check for the few known models with this issue,
so that the right IPC IRQ index is used on these systems.
Signed-off-by: Hans de Goede
Acked-by: Pierre-Louis
+ return ret;
+ }
+
+ ret = snd_soc_component_set_sysclk(codec_component, ARIZONA_CLK_OPCLK,
0,
+ rate * sr_mult, SND_SOC_CLOCK_OUT);
+ if (ret) {
+ dev_err(codec_component->dev, "Error setting OPCLK: %d\n",
On 1/5/21 1:07 PM, Arnd Bergmann wrote:
From: Arnd Bergmann
The SOF-ACPI driver is backwards from the normal Linux model, it has a
generic driver that knows about all the specific drivers, as opposed to
having hardware specific drivers that link against a common framework.
This requires ugl
@@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol
*kcontrol,
unsigned int reg2 = mc->rreg;
unsigned int reg = mc->reg;
unsigned int max = mc->max;
+ unsigned int val0, val1;
int err;
val = ucontrol->value.integer.value[0];
@@
On 12/6/20 10:43 PM, Vinod Koul wrote:
On 05-12-20, 08:59, Pierre-Louis Bossart wrote:
Thanks for the review Vinod.
On 12/5/20 1:45 AM, Vinod Koul wrote:
On 03-12-20, 04:46, Bard Liao wrote:
From: Pierre-Louis Bossart
When a Slave device is resumed, it may resume the bus and restart the
device uses IN1 for its internal MIC and JD2 for jack-detect.
Signed-off-by: Chris Chiu
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/bytcr_rt5640.c | 12
1 file changed, 12 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c
b/sound/soc/intel/boards
On 1/12/21 11:17 AM, Perry Yuan wrote:
From: Perry Yuan
add support for dell privacy driver for the dell units equipped
hardware privacy design, which protect users privacy of audio and
camera from hardware level. once the audio or camera privacy mode
enabled, any applications will not get a
On 1/12/21 2:32 PM, Arnd Bergmann wrote:
From: Arnd Bergmann
The Kconfig logic around SND_SOC_SOF_INTEL_SOUNDWIRE tries to
ensure that all sound modules can be built with the minimal
dependencies, but this fails in some configurations:
x86_64-linux-ld: sound/hda/intel-dsp-config.o: in funct
Since this is going to be a really invasive change, and past
experience shows that mucking with Kconfigs will invariably raise a
number of broken corner cases, if there is support from
Mark/Takashi/Jaroslav on this idea, we should first test it in the SOF
tree so that we get a good test coverag
uld
be a no-op. I agree with @Pierre-Louis Bossart in this case, we should just be
running it whether or not dell-privacy is compiled in. If another vendor
chooses to add LED support they'll just need to set up their ledtrig supported
backend and not change codec code.
Hi @Pierre-Louis Bos
On 1/19/21 8:52 AM, Vinod Koul wrote:
On 15-01-21, 16:25, Srinivas Kandagatla wrote:
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.
Using id should give a unique d
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.
Using id should give a unique debugfs directory entry and should fix
below
warning too.
"debugfs: Directory 'master-
On 1/14/21 9:09 AM, Arnd Bergmann wrote:
On Tue, Jan 12, 2021 at 9:32 PM Arnd Bergmann wrote:
---
v2: fix various build issues in the first version, now passes
all randconfig builds I tried
Please disregard this version, while I have a tree that passes
the randconfig builds now, t
On 1/14/21 3:19 PM, Arnd Bergmann wrote:
On Thu, Jan 14, 2021 at 7:07 PM Pierre-Louis Bossart
wrote:
On 1/14/21 9:09 AM, Arnd Bergmann wrote:
On Tue, Jan 12, 2021 at 9:32 PM Arnd Bergmann wrote:
---
v2: fix various build issues in the first version, now passes
all randconfig builds
I am using hw_params_fixup, but it's not enough. The first thing I do is
to not add the BE HW constraint rules in runtime->hw_constraints,
because this will potentially affect the FE HW params. If the FE does
sampling rate conversion, for example, applying the sampling rate
constrain rules from
101 - 200 of 1237 matches
Mail list logo
