Re: [PATCH v4 7/8] drm/i2c: tda998x: register as a drm bridge

2018-04-24 Thread Peter Rosin
On 2018-04-24 10:08, Russell King - ARM Linux wrote: > On Tue, Apr 24, 2018 at 08:58:42AM +0200, Peter Rosin wrote: >> On 2018-04-23 18:08, Russell King - ARM Linux wrote: >>> On Mon, Apr 23, 2018 at 09:23:00AM +0200, Peter Rosin wrote: >>>> static int tda998x_re

Re: [PATCH v4 7/8] drm/i2c: tda998x: register as a drm bridge

2018-04-24 Thread Peter Rosin
On 2018-04-24 12:14, Peter Rosin wrote: > On 2018-04-24 10:08, Russell King - ARM Linux wrote: >> On Tue, Apr 24, 2018 at 08:58:42AM +0200, Peter Rosin wrote: >>> On 2018-04-23 18:08, Russell King - ARM Linux wrote: >>>> On Mon, Apr 23, 2018 at 09:23:00AM +0200, Pe

[RFC PATCH 2/3] drm: bridge: panel: allow override of the bus format

2018-03-17 Thread Peter Rosin
Useful if the bridge does some kind of conversion of the bus format. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/panel.c | 22 +- include/drm/drm_bridge.h | 1 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/panel.c b

[RFC PATCH 1/3] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185

2018-03-17 Thread Peter Rosin
Start list of actual chips compatible with "lvds-encoder". Signed-off-by: Peter Rosin --- .../devicetree/bindings/display/bridge/lvds-transmitter.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmit

[RFC PATCH 0/3] allow override of bus format in bridges

2018-03-17 Thread Peter Rosin
tream) code... And maybe it should be fourcc codes or something instead of these "rgb565" names? I threw in the first patch, since that is the actual lvds encoder I have in this case. Suggestions welcome. Cheers, Peter Peter Rosin (3): dt-bindings: display: bridge: lvds-transmitter:

[RFC PATCH 3/3] drm: bridge: lvds-encoder: on request, override the bus format

2018-03-17 Thread Peter Rosin
If the bridge changes the bus format, allow this to be described in the bridge, instead of providing false information about the bus format of the panel itself. Signed-off-by: Peter Rosin --- .../bindings/display/bridge/lvds-transmitter.txt | 8 drivers/gpu/drm/bridge/lvds

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Peter Rosin
On 2018-03-19 10:17, Bartosz Golaszewski wrote: > Replace the GPL header with an SPDX identifier for GPL-2.0. Great care should be exercised when dealing with copyrights of others. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/misc/eeprom/at24.c | 7 ++- > 1 file changed, 2 insert

Re: [PATCH linux dev-4.16] drivers: i2c: master arbiter: create driver

2018-03-19 Thread Peter Rosin
Hi Ken, Thanks for the patch! I would have liked this subject: i2c: muxes: pca9641: new driver On 2018-03-19 12:38, Ken Chen wrote: > Initial PCA9641 2 chennel I2C bus master arbiter channel > with separate implementation. It has probe issue > and difference device hehavior between PCA9541 be

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Peter Rosin
On 2018-03-19 13:12, Bartosz Golaszewski wrote: > 2018-03-19 12:03 GMT+01:00 Peter Rosin : >> Also, use a // style comment for the SPDX line in C files. > > I'm seeing both /* */ and // style comments used for SPDX headers - is > there any reason not to use /* */ here?

Re: [RFC PATCH 1/2] i2c: Add i2c_verify_device_id() to verify device id

2018-03-19 Thread Peter Rosin
0? If not, an all zero struct i2c_device_identity could be used instead of manufacturer_id 0x and that would simplify the pca954x driver code a bit more. But I guess we can never know the answer to that question. And even if we did, the answer might change later. But it would be nice... > Cc: Peter

[PATCH 3/3] iio: wrapper: unit-converter: new driver

2018-03-19 Thread Peter Rosin
current through the resistor. This driver solves both problems by allowing to linearly scale a channel and by allowing changes to the type of the channel. Or both. Signed-off-by: Peter Rosin --- MAINTAINERS | 1 + drivers/iio/wrapper/Kconfig | 9

[PATCH 1/3] iio: rename the multiplexer category to wrapper

2018-03-19 Thread Peter Rosin
Paves the way for other wrappers. Signed-off-by: Peter Rosin --- .../bindings/iio/{multiplexer => wrapper}/io-channel-mux.txt | 0 MAINTAINERS | 4 ++-- drivers/iio/Kconfig

[PATCH 2/3] dt-bindings: iio: wrapper: add io-channel-unit-converter

2018-03-19 Thread Peter Rosin
current through it. This binding allows description of such hardware which is external to the ADC. Signed-off-by: Peter Rosin --- .../iio/wrapper/io-channel-unit-converter.txt | 84 ++ MAINTAINERS| 6 ++ 2 files changed, 90

[PATCH 0/3] iio: add unit converter

2018-03-19 Thread Peter Rosin
t of a voltage divider, and an ADC used to measure the current by looking at the voltage over a resistor. Comments? Cheers, Peter Peter Rosin (3): iio: rename the multiplexer category to wrapper dt-bindings: iio: wrapper: add io-channel-unit-converter iio: wrapper: unit-converter: new driver

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

2018-05-03 Thread Peter Rosin
On 2018-05-03 00:36, Wenwen Wang wrote: > In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, > which are used to save a series of messages, as mentioned in the comment. > According to the value of the variable "size", msgbuf0 is initialized to > various values. In contrast, m

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-03 Thread Peter Rosin
On 2018-05-03 11:06, Daniel Vetter wrote: > On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >> The more natural approach would perhaps be to add an drm_bridge_add, >> but there are several other bridges that never call drm_bridge_add. >> Just removing the drm

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

2018-05-03 Thread Peter Rosin
On 2018-05-04 06:08, Wenwen Wang wrote: > On Thu, May 3, 2018 at 3:34 PM, Peter Rosin wrote: >> On 2018-05-03 00:36, Wenwen Wang wrote: >>> In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, >>> which are used to save a series of messages,

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

2018-05-03 Thread Peter Rosin
On 2018-05-04 07:28, Wenwen Wang wrote: > On Fri, May 4, 2018 at 12:04 AM, Peter Rosin wrote: >> On 2018-05-04 06:08, Wenwen Wang wrote: >>> On Thu, May 3, 2018 at 3:34 PM, Peter Rosin wrote: >>>> On 2018-05-03 00:36, Wenwen Wang wrote: >>>>> In i2c

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

2018-05-04 Thread Peter Rosin
On 2018-05-04 09:17, Wenwen Wang wrote: > On Fri, May 4, 2018 at 1:49 AM, Peter Rosin wrote: >> On 2018-05-04 07:28, Wenwen Wang wrote: >>> On Fri, May 4, 2018 at 12:04 AM, Peter Rosin wrote: >>>> On 2018-05-04 06:08, Wenwen Wang wrote: >>>>> On Th

[PATCH v2 09/26] drm/bridge: nxp-ptn3460: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index d64a3283822a..fa832f32b518 100644 --- a

[PATCH v2 11/26] drm/bridge: ps8622: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/parade-ps8622.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c index 81198f5e9afa..957420a1c924 100644

[PATCH v2 18/26] drm/bridge: ti-tfp410: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index acb857030951..4745838fdf0e 100644 --- a/drivers

[PATCH v2 21/26] drm/msm: specify the owner .odev of the bridges

2018-05-04 Thread Peter Rosin
This will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 1 + drivers/gpu/drm/msm/edp/edp_bridge.c | 1 + drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers

[PATCH v2 16/26] drm/bridge: tc358767: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 0fd9cf27542c..75f93e1d0bf5 100644 --- a/drivers

[PATCH v2 24/26] drm/bridge: remove the .of_node member

2018-05-04 Thread Peter Rosin
It is unused. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 3 +-- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 -- include/drm/drm_bridge.h | 4 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers

[PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-04 Thread Peter Rosin
If the bridge supplier is unbound, this will bring the bridge consumer down along with the bridge. Thus, there will no longer linger any dangling pointers from the bridge consumer (the drm_device) to some non-existent bridge supplier. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c

[PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach

2018-05-04 Thread Peter Rosin
The .odev owner device will be handy to have around. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index df084db33494..78d186b6831b 100644 --- a/drivers/gpu/drm

[PATCH v2 23/26] drm/sti: provide an owner .odev device for the bridges

2018-05-04 Thread Peter Rosin
The .of_node member is going away and providing an .odev will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/sti/sti_dvo.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 1 + drivers/gpu/drm/sti/sti_hdmi.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 22/26] drm/rcar-du: lvds: provide an owner .odev device for the bridge

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 3d2d3bbd1342..efda02f55c95 100644 --- a

[PATCH v2 20/26] drm/mediatek: hdmi: provide an owner .odev device for the bridge

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 59a11026dceb..d8c7d93d0a87 100644 --- a

[PATCH v2 19/26] drm/exynos: mic: provide an owner .odev device for the bridge

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 2174814273e2..f9ff8d3ec937

[PATCH v2 17/26] drm/bridge: thc63lvd1024: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c index c8b9edd5a7f4..4765c9c45aef 100644

[PATCH v2 14/26] drm/bridge: sii8620: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index 7ab36042a822..8e35578b0488 100644 --- a

[PATCH v2 15/26] drm/bridge: synopsys: provide an owner .odev device for the bridges

2018-05-04 Thread Peter Rosin
It gets rid of two #ifdefs and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v2 13/26] drm/bridge: sii9234: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sii9234.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index c77000626c22..54326357b2ee 100644 --- a/drivers/gpu

[PATCH v2 12/26] drm/bridge: sii902x: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sii902x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 60373d7eb220..894525b05985 100644 --- a/drivers/gpu

[PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

2018-05-04 Thread Peter Rosin
It gets rid of an #ifdef and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/panel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 6d99d4a3beb3..f43d77b5ed20

[PATCH v2 07/26] drm/bridge: lvds-encoder: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/lvds-encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index 75b0d3f6e4de..a80eec17b13b 100644

[PATCH v2 06/26] drm/bridge: vga-dac: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 9837c8d69e69..95cce18e8943 100644

[PATCH v2 08/26] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdp-ge

[PATCH v2 02/26] drm/bridge: adv7511: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 2614cea538e2

[PATCH v2 05/26] drm/bridge: cdns-dsi: provide an owner .odev device

2018-05-04 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..e9be5c3f0284 100644 --- a/drivers

[PATCH v2 00/26] device link, bridge supplier <-> drm device

2018-05-04 Thread Peter Rosin
that this series removes) does not identify the port, so that problem seems orthogonal to me. Cheers, Peter [1] https://lkml.org/lkml/2018/4/23/769 [2] https://www.spinics.net/lists/dri-devel/msg174275.html Peter Rosin (26): drm/bridge: allow optionally specifying an owner .odev device drm/b

[PATCH v2 04/26] drm/bridge: analogix-anx78xx: provide an owner .odev device

2018-05-04 Thread Peter Rosin
It gets rid of an #if and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c

[PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

2018-05-04 Thread Peter Rosin
bridge drivers provide an owner device, that will become mandatory and the .of_node member will be removed. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 3 ++- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 +++- include/drm/drm_bridge.h | 2 ++ 3 files

[PATCH v2 03/26] drm/bridge/analogix: core: specify the owner .odev of the bridge

2018-05-04 Thread Peter Rosin
This will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 2bcbfadb6ac5

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

2018-05-04 Thread Peter Rosin
On 2018-05-04 16:59, Wenwen Wang wrote: > On Fri, May 4, 2018 at 2:27 AM, Peter Rosin wrote: >> On 2018-05-04 09:17, Wenwen Wang wrote: >>> On Fri, May 4, 2018 at 1:49 AM, Peter Rosin wrote: >>>> On 2018-05-04 07:28, Wenwen Wang wrote: >>>>> On Fri

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

2018-05-05 Thread Peter Rosin
On 2018-05-05 03:43, Wenwen Wang wrote: > In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, > which are used to save a series of messages, as mentioned in the comment. > According to the value of the variable "size", msgbuf0 is initialized to > various values. In contrast, m

[PATCH v3 1/7] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185

2018-04-19 Thread Peter Rosin
Start list of actual chips compatible with "lvds-encoder". Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Peter Rosin --- .../devicetree/bindings/display/bridge/lvds-transmitter.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) dif

[PATCH v3 2/7] dt-bindings: display: atmel: optional video-interface of endpoints

2018-04-19 Thread Peter Rosin
quot; issue (SAMA5D2, SAMA5D4), this is completely irrelevant. Signed-off-by: Peter Rosin --- .../devicetree/bindings/display/atmel/hlcdc-dc.txt | 26 ++ 1 file changed, 26 insertions(+) diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt b/Documentation

[PATCH v3 7/7] drm/i2c: tda998x: register as a drm bridge

2018-04-19 Thread Peter Rosin
goes away when connecting to the bridge interface of the driver and the equivalent of bind/unbind of the component is handled by bridge attach/detach. The lifetime requirements of a bridge and a component are slightly different, which is the reason for struct tda998x_bridge. Signed-off-by: Peter

[PATCH v3 0/7] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-19 Thread Peter Rosin
ries v2 https://lkml.org/lkml/2018/3/26/610 "Bridge" series v1 https://lkml.org/lkml/2018/3/17/221 Peter Rosin (7): dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 dt-bindings: display: atmel: optional video-interface of endpoints drm: of: introduce drm_of_media_

[PATCH v3 6/7] drm/i2c: tda998x: split encoder and component functions from the work

2018-04-19 Thread Peter Rosin
This enables reuse of the machinery for the case where a drm_bridge needs to do the same work via different interfaces. Signed-off-by: Peter Rosin --- drivers/gpu/drm/i2c/tda998x_drv.c | 46 ++- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a

[PATCH v3 5/7] drm/i2c: tda998x: find the drm_device via the drm_connector

2018-04-19 Thread Peter Rosin
This prepares for being a drm_bridge which will not register the encoder. That makes the connector the better choice. Signed-off-by: Peter Rosin --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers

[PATCH v3 4/7] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-19 Thread Peter Rosin
2, SAMA5D4), this is completely irrelevant. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 71 +--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 40 - 3 files changed,

[PATCH v3 3/7] drm: of: introduce drm_of_media_bus_fmt

2018-04-19 Thread Peter Rosin
Add a central function to parse a node according to the video interface binding and get a media bus format. Start with only supporting a very limited set of a few basic media bus formats. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_of.c | 38

Re: [PATCH v2 3/6] drm: of: introduce drm_of_media_bus_fmt

2018-04-19 Thread Peter Rosin
On 2018-04-19 18:22, Rob Herring wrote: > On Tue, Apr 17, 2018 at 8:10 AM, Peter Rosin wrote: >> Add a central function to parse a node according to the video >> interface binding and get a media bus format. >> >> Start with only supporting a very limited set of a few

Re: [PATCH v2] usb: chipidea: Hook into mux framework to toggle usb switch

2018-04-20 Thread Peter Rosin
On 2018-04-20 04:00, Peter Chen wrote: > > >> --- a/drivers/usb/chipidea/Kconfig >> +++ b/drivers/usb/chipidea/Kconfig >> @@ -3,6 +3,8 @@ config USB_CHIPIDEA >> depends on ((USB_EHCI_HCD && USB_GADGET) || (USB_EHCI_HCD >> && !USB_GADGET) || (!USB_EHCI_HCD && USB_GADGET)) && HAS_DMA >>

Re: [PATCH v3 7/7] drm/i2c: tda998x: register as a drm bridge

2018-04-20 Thread Peter Rosin
ase drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Peter-Rosin/Add-tda998x-HDMI-support-to-atmel-hlcdc/20180420-160131 > base: git://people.freedesktop.org/~airlied/linux.git drm-next > config: i386-randconfig-a0-201815 (atta

Re: [PATCH v3 0/7] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-20 Thread Peter Rosin
band wagon. >> >> On Thu, Apr 19, 2018 at 06:27:44PM +0200, Peter Rosin wrote: >>> Hi! >>> >>> I naively thought that since there was support for both nxp,tda19988 (in >>> the tda998x driver) and the atmel-hlcdc, things would be a smooth ride. >

Re: [PATCH v3 0/7] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-20 Thread Peter Rosin
On 2018-04-20 13:38, jacopo mondi wrote: > Hi Peter, > > On Fri, Apr 20, 2018 at 01:05:21PM +0200, Peter Rosin wrote: >> On 2018-04-20 12:18, Laurent Pinchart wrote: >>> Hello, >>> >>> On Friday, 20 April 2018 11:52:35 EEST jacopo mondi wrote: >>>

Re: [PATCH v3 7/7] drm/i2c: tda998x: register as a drm bridge

2018-04-20 Thread Peter Rosin
On 2018-04-20 12:53, Russell King - ARM Linux wrote: > On Fri, Apr 20, 2018 at 12:49:42PM +0200, Peter Rosin wrote: >> On 2018-04-20 12:41, kbuild test robot wrote: >>> Hi Peter, >>> >>> I love your patch! Yet something to improve: >> >> Yup, right y

Re: [PATCH v3 7/7] drm/i2c: tda998x: register as a drm bridge

2018-04-20 Thread Peter Rosin
On 2018-04-20 12:24, Russell King - ARM Linux wrote: > On Fri, Apr 20, 2018 at 01:06:49PM +0300, Laurent Pinchart wrote: >> Hi Peter, >> >> Thank you for the patch. >> >> On Thursday, 19 April 2018 19:27:51 EEST Peter Rosin wrote: >>> This makes this dr

Re: [PATCH v3 0/7] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-21 Thread Peter Rosin
On 2018-04-21 10:38, Laurent Pinchart wrote: > Hi Peter, > > On Friday, 20 April 2018 15:55:50 EEST Peter Rosin wrote: >> On 2018-04-20 13:38, jacopo mondi wrote: >>> On Fri, Apr 20, 2018 at 01:05:21PM +0200, Peter Rosin wrote: >>>> On 2018-04-20 12:18, Laurent

Re: [PATCH v3 4/7] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-21 Thread Peter Rosin
On 2018-04-21 18:19, Boris Brezillon wrote: > On Thu, 19 Apr 2018 18:27:48 +0200 > Peter Rosin wrote: > >> This beats the heuristic that the connector is involved in what format >> should be output for cases where this fails. >> >> E.g. if there is a bridg

Re: [PATCH 2/5] dt-bindings: display: atmel: add optional output-mode property

2018-04-14 Thread Peter Rosin
On 2018-04-13 19:46, Rob Herring wrote: > On Mon, Apr 09, 2018 at 12:59:15PM +0200, Peter Rosin wrote: >> Useful for beating cases where an output mode selection heuristic >> fails. >> >> Signed-off-by: Peter Rosin >> --- >> Documentation/devicetree/

Re: [PATCH v3 2/2] iio: afe: unit-converter: new driver

2018-04-16 Thread Peter Rosin
On 2018-04-15 19:31, Jonathan Cameron wrote: > On Tue, 10 Apr 2018 17:28:02 +0200 > Peter Rosin wrote: > >> If an ADC channel measures the midpoint of a voltage divider, the >> interesting voltage is often the voltage over the full resistance. >> E.g. if the full vol

Re: [PATCH 2/2] iio: afe: unit-converter: add support for adi,lt6106

2018-04-16 Thread Peter Rosin
On 2018-04-13 16:47, Andrew F. Davis wrote: > On 04/12/2018 05:31 PM, Peter Rosin wrote: >> On 2018-04-12 17:35, Andrew F. Davis wrote: >>> True, how about "current-sense-from-voltage" ? >> >> Doesn't cover "voltage-divider" (and we don'

Re: [PATCH 2/2] iio: afe: unit-converter: add support for adi,lt6106

2018-04-16 Thread Peter Rosin
On 2018-04-13 10:11, Lars-Peter Clausen wrote: > On 04/13/2018 12:31 AM, Peter Rosin wrote: >> On 2018-04-12 17:35, Andrew F. Davis wrote: >>> On 04/12/2018 09:29 AM, Peter Rosin wrote: >>>> But as I said in the cover letter, I didn't go with sense-gain since

Re: [PATCH v3 1/2] dt-bindings: iio: afe: add current-sense-shunt and voltage-divider

2018-04-16 Thread Peter Rosin
On 2018-04-10 17:28, Peter Rosin wrote: > +Example: > +The system voltage is circa 12V, but divided down with a 22/200 > +voltage divider to adjust it to the ADC range. > + > +SYSVADC GND > + + + + > + | .-. | .. | &

[PATCH v2 0/6] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-17 Thread Peter Rosin
ttps://lkml.org/lkml/2018/3/26/610 "Bridge" series v1 https://lkml.org/lkml/2018/3/17/221 Peter Rosin (6): dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 dt-bindings: display: atmel: optional video-interface of endpoints drm: of: introduce drm_of_media_bus_fmt

[PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints

2018-04-17 Thread Peter Rosin
quot; issue (SAMA5D2, SAMA5D4), this is completely irrelevant. Signed-off-by: Peter Rosin --- Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt b/Documentation/devicet

[PATCH v2 1/6] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185

2018-04-17 Thread Peter Rosin
Start list of actual chips compatible with "lvds-encoder". Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Peter Rosin --- .../devicetree/bindings/display/bridge/lvds-transmitter.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) dif

[PATCH v2 3/6] drm: of: introduce drm_of_media_bus_fmt

2018-04-17 Thread Peter Rosin
Add a central function to parse a node according to the video interface binding and get a media bus format. Start with only supporting a very limited set of a few basic media bus formats. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_of.c | 38

[PATCH v2 5/6] drm/atmel-hlcdc: add support for connecting to tda998x HDMI encoder

2018-04-17 Thread Peter Rosin
When the of-graph points to a tda998x-compatible HDMI encoder, register as a component master and bind to the encoder/connector provided by the tda998x driver. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 81 -- drivers/gpu/drm/atmel-hlcdc

[PATCH v2 6/6] drm/atmel-hlcdc: fix broken release date

2018-04-17 Thread Peter Rosin
Bump the minor version while at it. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 8523c40fac94

[PATCH v2 4/6] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-17 Thread Peter Rosin
2, SAMA5D4), this is completely irrelevant. Signed-off-by: Peter Rosin --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 85 -- 1 file changed, 65 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atme

Re: [PATCH v2] usb: chipidea: Hook into mux framework to toggle usb switch

2018-04-17 Thread Peter Rosin
On 2018-04-17 15:52, Yossi Mansharoff wrote: > On the db410c 96boards platform we have a TC7USB40MU on the board > to mux the D+/D- lines coming from the controller between a micro > usb "device" port and a USB hub for "host" roles[1]. During a > role switch, we need to toggle this mux to forward t

Re: [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

2018-05-09 Thread Peter Rosin
On 2018-05-09 17:08, Andrzej Hajda wrote: > On 04.05.2018 15:51, Peter Rosin wrote: >> Bridge drivers can now (temporarily, in a transition phase) select if >> they want to provide a full owner device or keep just providing an >> of_node. >> >> By providing a full

[PATCH 1/2] i2c: exynos5: remove some dead code

2018-05-09 Thread Peter Rosin
The else branch cannot be taken as i will always equal num. Get rid of the whole construct. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-exynos5.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c

[PATCH] i2c: hix5hd2: remove some dead code

2018-05-09 Thread Peter Rosin
The else branch cannot be taken as i will always equal num. Get rid of the whole construct. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-hix5hd2.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c

[PATCH 2/2] i2c: exynos5: remove pointless initializers

2018-05-09 Thread Peter Rosin
The variables are always assigned before use anyway. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-exynos5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c index a2cbc779c33a..185fba37e830 100644

[PATCH 2/2] i2c: robotfuzz-osif: drop pointless test

2018-05-09 Thread Peter Rosin
In the for-loop test, ret will be either 0 or 1. So, the comparison is pointless. Drop it, and drop the initializer which is then also pointless. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-robotfuzz-osif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 1/2] i2c: pmcmsp: return message count on master_xfer success

2018-05-09 Thread Peter Rosin
Returning zero is wrong in this case. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-pmcmsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 2aa0e83174c5..ec27e27e8d06 100644 --- a/drivers/i2c

[PATCH 2/2] i2c: pmcmsp: fix error return from master_xfer

2018-05-09 Thread Peter Rosin
Returning -1 (-EPERM) is not appropriate here, go with -EIO. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-pmcmsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index ec27e27e8d06..dae8ac618a52

[PATCH 1/2] i2c: robotfuzz-osif: remove pointless local variable

2018-05-09 Thread Peter Rosin
Just use the value directly instead of assigning it to a variable first. And then drop the unused variable. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-robotfuzz-osif.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH] i2c: synquacer: fix fence-post error in retry loop

2018-05-09 Thread Peter Rosin
There is a difference between attempts and retries. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-synquacer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c index a021f866d8c2..915f5edbab33

[PATCH] [media] saa7146: fix error return from master_xfer

2018-05-09 Thread Peter Rosin
Returning -1 (-EPERM) is not appropriate here, go with -EIO. Signed-off-by: Peter Rosin --- drivers/media/common/saa7146/saa7146_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/common/saa7146/saa7146_i2c.c b/drivers/media/common/saa7146/saa7146_i2c.c

[PATCH] i2c: viperboard: return message count on master_xfer success

2018-05-09 Thread Peter Rosin
Returning zero is wrong in this case. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-viperboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c index e4be86b3de9a..7235c7302bb7 100644 --- a

Re: [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

2018-05-09 Thread Peter Rosin
On 2018-05-09 17:53, Peter Rosin wrote: > On 2018-05-09 17:08, Andrzej Hajda wrote: >> On 04.05.2018 15:51, Peter Rosin wrote: >>> Bridge drivers can now (temporarily, in a transition phase) select if >>> they want to provide a full owner device or keep just providing

Re: [PATCH v2 2/2] i2c: core-smbus: fix a potential missing-check bug

2018-05-10 Thread Peter Rosin
On 2018-05-10 13:16, Wolfram Sang wrote: > On Sat, May 05, 2018 at 08:02:21AM -0500, Wenwen Wang wrote: >> In i2c_smbus_xfer_emulated(), the function i2c_transfer() is invoked to >> transfer i2c messages. The number of actual transferred messages is >> returned and saved to 'status'. If 'status' is

Re: [PATCH 2/2] i2c: exynos5: remove pointless initializers

2018-05-10 Thread Peter Rosin
On 2018-05-10 10:44, Andrzej Hajda wrote: > On 09.05.2018 21:45, Peter Rosin wrote: >> The variables are always assigned before use anyway. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/i2c/busses/i2c-exynos5.c | 2 +- >> 1 file changed, 1 inserti

Re: [PATCH 1/2] i2c: exynos5: remove some dead code

2018-05-10 Thread Peter Rosin
On 2018-05-10 10:36, Andrzej Hajda wrote: > On 09.05.2018 21:45, Peter Rosin wrote: >> The else branch cannot be taken as i will always equal num. >> Get rid of the whole construct. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/i2c/busses/i2c-exynos5

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-11 Thread Peter Rosin
On 2018-05-10 10:10, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (th

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-07 Thread Peter Rosin
On 2018-05-07 14:59, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (th

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-07 Thread Peter Rosin
On 2018-05-07 15:39, Daniel Vetter wrote: > On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: >> On 2018-05-03 11:06, Daniel Vetter wrote: >>> On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >>>> The more natural approach would perhaps be to a

Re: [PATCH v2 00/26] device link, bridge supplier <-> drm device

2018-05-07 Thread Peter Rosin
On 2018-05-07 15:56, Daniel Vetter wrote: > On Fri, May 04, 2018 at 03:51:46PM +0200, Peter Rosin wrote: >> Hi! >> >> It was noted by Russel King [1] that bridges (not using components) >> might disappear unexpectedly if the owner of the bridge was unbound. >> Jy

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

2018-05-07 Thread Peter Rosin
On 2018-05-07 15:59, Peter Rosin wrote: > On 2018-05-07 15:39, Daniel Vetter wrote: >> On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: >>> On 2018-05-03 11:06, Daniel Vetter wrote: >>>> On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >>

Re: [PATCH] i2c-mux-pca954x: Force reset on probe if available

2018-05-07 Thread Peter Rosin
On 2018-05-01 13:42, Mike Looijmans wrote: > Instead of just hogging the reset GPIO into deactivated state, activate and > then de-activate the reset. This allows for better recovery if the CPU was > reset halfway through an I2C transaction for example. I can't see any problems with this, and a re

Re: [PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

2018-05-08 Thread Peter Rosin
On 2018-05-08 08:51, Jyri Sarha wrote: > On 05/04/18 16:51, Peter Rosin wrote: >> It gets rid of an #ifdef and the .of_node member is going away. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/gpu/drm/bridge/panel.c | 4 +--- >> 1 file changed, 1 insert

<    5   6   7   8   9   10   11   12   13   14   >