[PATCH v7 19/24] i2c-mux: document i2c muxes and elaborate on parent-/mux-locked muxes

2016-04-20 Thread Peter Rosin
Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology | 370 + MAINTAINERS| 1 + 2 files changed, 371 insertions(+) create mode 100644 Documentation/i2c/i2c-topology diff --git a/Documentation/i2c/i2c-topology b

[PATCH v7 21/24] [media] si2168: change the i2c gate to be mux-locked

2016-04-20 Thread Peter Rosin
unlocked. But add a mutex so that firmware commands are still serialized. Signed-off-by: Antti Palosaari Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology| 2 +- drivers/media/dvb-frontends/si2168.c | 83 --- drivers/media/dvb-frontends

[PATCH v7 24/24] [media] rtl2832: regmap is aware of lockdep, drop local locking hack

2016-04-20 Thread Peter Rosin
Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832.c | 30 -- drivers/media/dvb-frontends/rtl2832_priv.h | 1 - 2 files changed, 31 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media

[PATCH v7 10/24] [media] rtl2830: convert to use an explicit i2c mux core

2016-04-20 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2830.c | 20

[PATCH v7 23/24] [media] rtl2832_sdr: get rid of empty regmap wrappers

2016-04-20 Thread Peter Rosin
Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832_sdr.c | 302 +- 1 file changed, 132 insertions(+), 170 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c

[PATCH v7 20/24] iio: imu: inv_mpu6050: change the i2c gate to be mux-locked

2016-04-20 Thread Peter Rosin
e very end (and grabs the newfangled i2c mux lock where it previously grabbed the i2c adapter lock). Acked-by: Jonathan Cameron Acked-by: Daniel Baluta Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology| 2 +- drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 52 ++-

[PATCH v7 12/24] [media] si2168: convert to use an explicit i2c mux core

2016-04-20 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/si2168.c | 25

[PATCH v7 14/24] of/unittest: convert to use an explicit i2c mux core

2016-04-20 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Acked-by: Rob Herring Signed-off-by: Peter Rosin --- drivers/of/unittest.c | 37 - 1 file changed

[PATCH v7 17/24] i2c: muxes always lock the parent adapter

2016-04-20 Thread Peter Rosin
Instead of checking for i2c parent adapters for every lock/unlock, simply override the locking for muxes to always lock/unlock the parent adapter directly. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 21 +++-- drivers/i2c/i2c-mux.c | 27

[PATCH v7 13/24] [media] cx231xx: convert to use an explicit i2c mux core

2016-04-20 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/media/usb/cx231xx/cx231xx-core.c | 6 ++-- drivers/media/usb/cx231xx/cx231xx-i2c.c | 47

[PATCH v7 09/24] [media] m88ds3103: convert to use an explicit i2c mux core

2016-04-20 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/m88ds3103.c | 19

[PATCH v7 07/24] i2c: i2c-mux-reg: convert to use an explicit i2c mux core

2016-04-20 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-reg.c | 69 +++-- 1 file

Re: [PATCH] iio: inv_mpu6050: Add support for auxiliary I2C master

2016-04-20 Thread Peter Rosin
Crestez Dan Leonard wrote: > The MPU has an auxiliary I2C bus for connecting external > sensors. This bus has two operating modes: > * pass-through, which connects the primary and auxiliary busses > together. This is already supported via an i2c mux. > * I2C master mode, where the mpu60x0 acts as a

Re: [PATCH] iio: inv_mpu6050: Add support for auxiliary I2C master

2016-04-21 Thread Peter Rosin
Crestez Dan Leonard wrote: > On 04/20/2016 11:31 PM, Peter Rosin wrote: > > Crestez Dan Leonard wrote: > >> Changes since that version: > >> * Nest the adapter in inv_mpu6050_state instead of making it static > >> * Explicitly forward of_node "i2c-aux-mast

[PATCH v4] ASoC: docs: add clocking examples for DAI formats

2016-04-21 Thread Peter Rosin
Provide *our* view of what the rules are for the different DAI formats, so that we do not have to trust external interpretations for this crucial bit of interoperability. Signed-off-by: Peter Rosin --- Documentation/sound/alsa/soc/clocking.txt | 195 ++ 1 file

Re: [PATCH v7 00/24] i2c mux cleanup and locking update

2016-04-22 Thread Peter Rosin
Hi Wolfram, Wolfram Sang wrote: > This was the diff of v6: > > > 32 files changed, 1277 insertions(+), 915 deletions(-) > > This is v7: > > > 32 files changed, 1225 insertions(+), 916 deletions(-) > > So, we gained a little overall. And while the individual drivers have a > few lines more no

Re: [PATCH] iio: inv_mpu6050: Add support for auxiliary I2C master

2016-04-22 Thread Peter Rosin
Crestez Dan Leonard wrote: > On 04/21/2016 04:56 PM, Peter Rosin wrote: > > Crestez Dan Leonard wrote: > >> On 04/20/2016 11:31 PM, Peter Rosin wrote: > >>> Crestez Dan Leonard wrote: > >>>> Changes since that version: > >>>> * Nest

[PATCH v8 08/24] iio: imu: inv_mpu6050: convert to use an explicit i2c mux core

2016-04-22 Thread Peter Rosin
Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Acked-by: Jonathan Cameron Signed-off-by: Peter Rosin --- drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 2 +- drivers/iio

Re: [PATCH v7 00/24] i2c mux cleanup and locking update

2016-04-22 Thread Peter Rosin
rtl2832: regmap is aware of lockdep, drop local locking hack (2016-04-22 12:18:45 +0200) Antti Palosaari (1): [media] si2168: change the i2c gate to be mux-locked Peter Rosin (23): i2c-mux: add common data for every i2

Re: [PATCH v4 00/18] i2c mux cleanup and locking update

2016-03-15 Thread Peter Rosin
Hi! On 2016-03-03 23:27, Peter Rosin wrote: > From: Peter Rosin > > Hi! > > I have a pair of boards with this i2c topology: > >GPIO ---| -- BAT1 > | v / >I2C

[PATCH] [media] m88ds3103: fix undefined division

2016-03-18 Thread Peter Rosin
From: Peter Rosin s32tmp in the below code may be negative, and dev->mclk_khz is an unsigned type. s32tmp = 0x1 * (tuner_frequency - c->frequency); s32tmp = DIV_ROUND_CLOSEST(s32tmp, dev->mclk_khz); This is undefined, as DIV_ROUND_CLOSEST is undefined for negative

Re: [PATCH v6 00/24] i2c mux cleanup and locking update

2016-04-11 Thread Peter Rosin
Hi! On 2016-04-11 14:39, Wolfram Sang wrote: Hi Peter, To summarize the series, there's some i2c-mux infrastructure cleanup work first (I think that part stands by itself as desireable regardless), the locking changes are in 16/24 and after with the real meat in 18/24. There is some documentat

Re: [PATCH v6 14/24] of/unittest: convert to use an explicit i2c mux core

2016-04-05 Thread Peter Rosin
On 2016-04-04 07:16, Rob Herring wrote: > On Sun, Apr 03, 2016 at 10:52:44AM +0200, Peter Rosin wrote: >> From: Peter Rosin >> >> Allocate an explicit i2c mux core to handle parent and child adapters >> etc. Update the select op to be in terms of the i2c mux core inst

Re: [PATCH v6 19/24] i2c-mux: document i2c muxes and elaborate on parent-/mux-locked muxes

2016-04-05 Thread Peter Rosin
On 2016-04-03 13:09, Jonathan Cameron wrote: > On 03/04/16 09:52, Peter Rosin wrote: >> From: Peter Rosin >> >> Signed-off-by: Peter Rosin > Very nice, one typo that I could see. Thanks! *snip* >> + and the actual transfer (e.g. if the child mux is auto-closi

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magn

2016-04-17 Thread Peter Rosin
303AGR device has the same problem: it's an >> accel+magn combo behind a single I2C address. How is that supposed to be >> instantiated? Other supported combo devices seem to have multiple I2C >> addresses. > Excellent question. I'd not picked up on this before. > I

[PATCH] ASoC: docs: add clocking examples for DAI formats

2016-04-18 Thread Peter Rosin
Provide *our* view of what the rules are for the different DAI formats, so that we do not have to trust external interpretations for this crucial bit of interoperability. Signed-off-by: Peter Rosin --- Documentation/sound/alsa/soc/clocking.txt | 110 +- 1 file

Re: [PATCH] ASoC: docs: add clocking examples for DAI formats

2016-04-18 Thread Peter Rosin
Mark Brown wrote: > On Mon, Apr 18, 2016 at 11:39:50AM +0200, Peter Rosin wrote: > > > +I2S > > + .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. .-. > > +-' '-' '-' '-' '-' '-' '-' &#x

SV: [PATCH] ASoC: docs: add clocking examples for DAI formats

2016-04-18 Thread Peter Rosin
Mark Brown wrote: > On Mon, Apr 18, 2016 at 12:55:23PM +0000, Peter Rosin wrote: > > Mark Brown wrote: > > > > There is an actual spec for I2S which is going to be clearer than ASCII > > > art: > > > >https://www.sparkfun.com/datasheets/BreakoutBoar

[PATCH v2] ASoC: docs: add clocking examples for DAI formats

2016-04-18 Thread Peter Rosin
Provide *our* view of what the rules are for the different DAI formats, so that we do not have to trust external interpretations for this crucial bit of interoperability. Signed-off-by: Peter Rosin --- Documentation/sound/alsa/soc/clocking.txt | 145 +- 1 file

Re: [PATCH] ASoC: docs: add clocking examples for DAI formats

2016-04-18 Thread Peter Rosin
On 2016-04-18 17:11, Mark Brown wrote: > On Mon, Apr 18, 2016 at 01:18:47PM +0000, Peter Rosin wrote: >> Mark Brown wrote: > >>> >>> There aren't any (beyond the usual references to the Wolfson datasheets >>> which I'd suggest should be in here

[PATCH v3] ASoC: docs: add clocking examples for DAI formats

2016-04-19 Thread Peter Rosin
Provide *our* view of what the rules are for the different DAI formats, so that we do not have to trust external interpretations for this crucial bit of interoperability. Signed-off-by: Peter Rosin --- Documentation/sound/alsa/soc/clocking.txt | 146 +- 1 file

Re: [PATCH v6 08/24] iio: imu: inv_mpu6050: convert to use an explicit i2c mux core

2016-04-19 Thread Peter Rosin
,Arnd Bergmann ,Tommi Rantala ,linux-...@vger.kernel.org,linux-...@vger.kernel.org,linux-...@vger.kernel.org,linux-me...@vger.kernel.org,devicet...@vger.kernel.org Message-ID: On April 19, 2016 5:58:11 PM CEST, Crestez Dan Leonard wrote: > On 04/03/2016 11:52 AM, Peter Rosin wrote: >

Re: [PATCH v4] ASoC: docs: add clocking examples for DAI formats

2016-04-25 Thread Peter Rosin
Hi! On 2016-04-21 22:58, Peter Rosin wrote: > +See the official I2S specification > +https://www.sparkfun.com/datasheets/BreakoutBoards/I2SBUS.pdf I've searched for a bit, and the best I can find is (IMHO) https://web.archive.org/web/20060702004954/http://www.semiconductors.

Re: [PATCH v4] ASoC: docs: add clocking examples for DAI formats

2016-04-25 Thread Peter Rosin
On 2016-04-25 19:36, Mark Brown wrote: > On Mon, Apr 25, 2016 at 04:15:40PM +0200, Peter Rosin wrote: > >> I've searched for a bit, and the best I can find is (IMHO) >> https://web.archive.org/web/20060702004954/http://www.semiconductors.philips.com/acrobat_download/various/

[PATCH v6 01/24] i2c-mux: add common data for every i2c-mux instance

2016-04-03 Thread Peter Rosin
From: Peter Rosin All i2c-muxes have a parent adapter and one or many child adapters. A mux also has some means of selection. Previously, this was stored per child adapter, but it is only needed to keep track of this per mux. Add an i2c mux core, that keeps track of this consistently. Also add

[PATCH v6 00/24] i2c mux cleanup and locking update

2016-04-03 Thread Peter Rosin
From: Peter Rosin Hi! I have a pair of boards with this i2c topology: GPIO ---| -- BAT1 | v / I2C -+--B---+ MUX | \ EEPROM -- BAT2 (B denotes the

[PATCH v6 04/24] i2c: i2c-arb-gpio-challenge: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 47

[PATCH v6 02/24] i2c: i2c-mux-gpio: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-gpio.c | 54

[PATCH v6 07/24] i2c: i2c-mux-reg: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-reg.c | 63

[PATCH v6 06/24] i2c: i2c-mux-pca954x: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Add a mask to handle the case where not all child adapters should cause a mux deselect to happen, now that

[PATCH v6 03/24] i2c: i2c-mux-pinctrl: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-pinctrl.c | 86

[PATCH v6 05/24] i2c: i2c-mux-pca9541: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-pca9541.c | 55

[PATCH v6 11/24] [media] rtl2832: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832.c

[PATCH v6 09/24] [media] m88ds3103: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/m88ds3103.c | 18

[PATCH v6 10/24] [media] rtl2830: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2830.c | 17

[PATCH v6 14/24] of/unittest: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/of/unittest.c | 40 +++- 1 file changed

[PATCH v6 13/24] [media] cx231xx: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select op to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/media/usb/cx231xx/cx231xx-core.c | 6 ++-- drivers/media/usb/cx231xx

[PATCH v6 12/24] [media] si2168: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/si2168.c

[PATCH v6 08/24] iio: imu: inv_mpu6050: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
From: Peter Rosin Allocate an explicit i2c mux core to handle parent and child adapters etc. Update the select/deselect ops to be in terms of the i2c mux core instead of the child adapter. Signed-off-by: Peter Rosin --- drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 2 +- drivers/iio/imu

[PATCH v6 19/24] i2c-mux: document i2c muxes and elaborate on parent-/mux-locked muxes

2016-04-03 Thread Peter Rosin
From: Peter Rosin Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology | 370 + MAINTAINERS| 1 + 2 files changed, 371 insertions(+) create mode 100644 Documentation/i2c/i2c-topology diff --git a/Documentation/i2c/i2c

[PATCH v6 18/24] i2c-mux: relax locking of the top i2c adapter during mux-locked muxing

2016-04-03 Thread Peter Rosin
From: Peter Rosin With a i2c topology like the following GPIO ---| -- BAT1 | v / I2C -+--+ MUX | \ EEPROM -- BAT2 there is a locking problem with the GPIO

[PATCH v6 20/24] iio: imu: inv_mpu6050: change the i2c gate to be mux-locked

2016-04-03 Thread Peter Rosin
From: Peter Rosin The root i2c adapter lock is then no longer held by the i2c mux during accesses behind the i2c gate, and such accesses need to take that lock just like any other ordinary i2c accesses do. So, declare the i2c gate mux-locked, and zap the code that makes the unlocked i2c

[PATCH v6 15/24] i2c-mux: drop old unused i2c-mux api

2016-04-03 Thread Peter Rosin
From: Peter Rosin All i2c mux users are using an explicit i2c mux core, drop support for implicit i2c mux cores. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-mux.c | 59 - include/linux/i2c-mux.h | 15 - 2 files changed, 74

[PATCH v6 17/24] i2c: muxes always lock the parent adapter

2016-04-03 Thread Peter Rosin
From: Peter Rosin Instead of checking for i2c parent adapters for every lock/unlock, simply override the locking for muxes to always lock/unlock the parent adapter directly. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 21 +++-- drivers/i2c/i2c-mux.c | 27

[PATCH v6 16/24] i2c: allow adapter drivers to override the adapter locking

2016-04-03 Thread Peter Rosin
From: Peter Rosin Add i2c_lock_bus() and i2c_unlock_bus(), which call the new lock_bus and unlock_bus ops in the adapter. These funcs/ops take an additional flags argument that indicates for what purpose the adapter is locked. There are two flags, I2C_LOCK_ADAPTER and I2C_LOCK_SEGMENT, but they

[PATCH v6 24/24] [media] rtl2832: regmap is aware of lockdep, drop local locking hack

2016-04-03 Thread Peter Rosin
From: Peter Rosin Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832.c | 30 -- drivers/media/dvb-frontends/rtl2832_priv.h | 1 - 2 files changed, 31 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c

[PATCH v6 21/24] [media] si2168: change the i2c gate to be mux-locked

2016-04-03 Thread Peter Rosin
unlocked. But add a mutex so that firmware commands are still serialized. Signed-off-by: Antti Palosaari Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology| 2 +- drivers/media/dvb-frontends/si2168.c | 85 --- drivers/media/dvb-frontends

[PATCH v6 22/24] [media] rtl2832: change the i2c gate to be mux-locked

2016-04-03 Thread Peter Rosin
From: Peter Rosin The root i2c adapter lock is then no longer held by the i2c mux during accesses behind the i2c gate, and such accesses need to take that lock just like any other ordinary i2c accesses do. So, declare the i2c gate mux-locked, and zap the regmap overrides that makes the i2c

[PATCH v6 23/24] [media] rtl2832_sdr: get rid of empty regmap wrappers

2016-04-03 Thread Peter Rosin
From: Peter Rosin Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832_sdr.c | 302 +- 1 file changed, 132 insertions(+), 170 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb

Re: [PATCH v6 08/24] iio: imu: inv_mpu6050: convert to use an explicit i2c mux core

2016-04-03 Thread Peter Rosin
On 2016-04-03 12:51, Jonathan Cameron wrote: > On 03/04/16 09:52, Peter Rosin wrote: >> From: Peter Rosin >> >> Allocate an explicit i2c mux core to handle parent and child adapters >> etc. Update the select/deselect ops to be in terms of the i2c mux core >

Re: [PATCH v6 01/24] i2c-mux: add common data for every i2c-mux instance

2016-04-13 Thread Peter Rosin
Hi! On 2016-04-11 22:46, Wolfram Sang wrote: > Hi Peter, > > first high-level review: > >> +int i2c_mux_reserve_adapters(struct i2c_mux_core *muxc, int adapters) > > I'd suggest to rename 'adapters' into 'num_adapters' throughout this > patch. I think it makes the code a lot easier to understan

Re: [PATCH v4 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Peter Rosin
On 2019-02-11 09:31, Federico Vaga wrote: > Miscellaneous style fixes from checkpatch > > Signed-off-by: Federico Vaga > Reviewed-by: Andrew Lunn > > --- > drivers/i2c/busses/i2c-ocores.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c

Re: [PATCH v4 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Peter Rosin
On 2019-02-11 11:16, Peter Rosin wrote: > On 2019-02-11 09:31, Federico Vaga wrote: >> Miscellaneous style fixes from checkpatch >> >> Signed-off-by: Federico Vaga >> Reviewed-by: Andrew Lunn >> >> --- >> drivers/i2c/busses/i2c-ocores.c | 19

Re: [PATCH v4 3/5] i2c:ocores: add polling interface

2019-02-11 Thread Peter Rosin
On 2019-02-11 09:31, Federico Vaga wrote: > This driver assumes that an interrupt line is always available for > the I2C master. This is not always the case and this patch adds support > for a polling version. > > Report from Andrew Lunn: > > I did some timing tests for this. On my box, we requ

Re: [PATCH v4 1/5] i2c:ocores: stop transfer on timeout

2019-02-11 Thread Peter Rosin
On 2019-02-11 09:31, Federico Vaga wrote: > Detecting a timeout is ok, but we also need to assert a STOP command on > the bus in order to prevent it from generating interrupts when there are > no on going transfers. > > Example: very long transmission. > > 1. ocores_xfer: START a transfer > 2. oc

Re: [PATCH v4 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Peter Rosin
On 2019-02-11 09:31, Federico Vaga wrote: > Miscellaneous style fixes from checkpatch > > Signed-off-by: Federico Vaga > Reviewed-by: Andrew Lunn > > --- > drivers/i2c/busses/i2c-ocores.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c

Re: [PATCH v4 3/5] i2c:ocores: add polling interface

2019-02-11 Thread Peter Rosin
>>> @@ -294,7 +427,7 @@ static int ocores_init(struct device *dev, struct >>> ocores_i2c *i2c) >> >>> >>> >>> /* Init the device */ >>> oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK); >>> >>> - oc_setreg(i2c, OCI2C_CONTROL, ctrl | OCI2C_CTRL_IEN | OCI2C_CTRL_EN); >>> + oc_setreg(i2c, OCI

Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Peter Rosin
On 2019-02-11 17:05, Federico Vaga wrote: > Miscellaneous style fixes from checkpatch > > Signed-off-by: Federico Vaga > --- > drivers/i2c/busses/i2c-ocores.c | 30 +++--- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ocores.

Re: [PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible

2019-09-02 Thread Peter Rosin
On 2019-09-02 12:11, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Add compatible for new Microchip SoC, sam9x60 > > Reviewed-by: Rob Herring > Signed-off-by: Eugen Hristev > --- > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-02 Thread Peter Rosin
On 2019-09-02 12:12, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Some i2c controllers have a built-in digital or analog filter. > This is specifically required depending on the hardware PCB/board. > Some controllers also allow specifying the maximum width of the > spikes that can

Re: [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-02 Thread Peter Rosin
On 2019-09-02 16:15, eugen.hris...@microchip.com wrote: > > > On 02.09.2019 13:49, Peter Rosin wrote: > >> On 2019-09-02 12:12, eugen.hris...@microchip.com wrote: >>> From: Eugen Hristev >>> >>> Some i2c controllers have a built-in digital or ana

Re: [RFC,v2 2/6] i2c: add I2C Address Translator (ATR) support

2019-09-04 Thread Peter Rosin
Hi! [ Sorry about my absence. I've been meaning to comment on this series for a long time, but work and family keep interfering... ] On 2019-09-03 09:31, Luca Ceresoli wrote: > Hi Jacopo, > > thanks for your feedback. > > On 01/09/19 16:31, jacopo mondi wrote: >> Hi Luca, >>thanks for kee

[PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup logos

2019-08-23 Thread Peter Rosin
Probably most useful if you only want one logo regardless of how many CPU cores you have. Signed-off-by: Peter Rosin --- Documentation/fb/fbcon.rst | 5 + drivers/video/fbdev/core/fbcon.c | 7 +++ drivers/video/fbdev/core/fbmem.c | 5 - include/linux/fb.h | 1

[PATCH 1/2] fbdev: fix numbering of fbcon options

2019-08-23 Thread Peter Rosin
Three shall be the number thou shalt count, and the number of the counting shall be three. Four shalt thou not count... One! Two! Five! Fixes: efb985f6b265 ("[PATCH] fbcon: Console Rotation - Add framebuffer console documentation") Signed-off-by: Peter Rosin --- Documentation/fb/fbc

[PATCH 0/2] Add possibility to specify the number of displayed logos

2019-08-23 Thread Peter Rosin
display to only one logo instead of one for each CPU core. Cheers, Peter Peter Rosin (2): fbdev: fix numbering of fbcon options fbdev: fbmem: allow overriding the number of bootup logos Documentation/fb/fbcon.rst | 13 + drivers/video/fbdev/core/fbcon.c | 7 +++ dri

Re: [PATCH v3 1/1] i2c: qcom-geni: Provide an option to disable DMA processing

2019-09-05 Thread Peter Rosin
On 2019-09-05 15:49, Wolfram Sang wrote: > Hi Lee, > > I understand you are in a hurry, but please double check before > sending... Linus indicated that an rc8 is coming up, which should provide an extra week. https://lwn.net/Articles/798152/ > On Thu, Sep 05, 2019 at 11:22:47AM +0100, Lee Jones

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

2019-09-17 Thread Peter Rosin
On 2019-09-17 12:13, Uwe Kleine-König wrote: > Hello Geert, > > On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: >> Hi Rob, Uwe, >> >> On Fri, Sep 13, 2019 at 11:58 PM Rob Herring wrote: >>> On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= >>> w

Re: [PATCH] of: restore old handling of cells_name=NULL in of_*_phandle_with_args()

2019-09-18 Thread Peter Rosin
oc.c > - drivers/soc/rockchip/pm_domains.c > - sound/soc/fsl/imx-audmix.c > - sound/soc/fsl/imx-audmix.c > - sound/soc/meson/axg-card.c > - sound/soc/samsung/tm2_wm5110.c > - sound/soc/samsung/tm2_wm5110.c > > Thanks to Geert Uytterhoeven for reporting the issue, Peter Ros

Re: [PATCH] i2c: pca954x: Add property to skip disabling PCA954x MUX device

2019-09-29 Thread Peter Rosin
On 2019-09-29 12:36, Biwen Li wrote: > On some Layerscape boards like LS2085ARDB and LS2088ARDB, > input pull-up resistors on PCA954x MUX device are missing on board, > So, if MUX are disabled after powered-on, input lines will float > leading to incorrect functionality. Hi! Are you saying that t

Re: [EXT] Re: [PATCH] i2c: pca954x: Add property to skip disabling PCA954x MUX device

2019-09-29 Thread Peter Rosin
On 2019-09-30 04:43, Biwen Li wrote: >> >> On 2019-09-29 12:36, Biwen Li wrote: >>> On some Layerscape boards like LS2085ARDB and LS2088ARDB, input >>> pull-up resistors on PCA954x MUX device are missing on board, So, if >>> MUX are disabled after powered-on, input lines will float leading to >>> i

Re: [PATCH] dt-bindings: at24: convert the binding document to yaml

2019-09-23 Thread Peter Rosin
On 2019-09-23 19:52, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Convert the binding document for at24 EEPROMs from txt to yaml. The > compatible property uses a regex pattern to address all the possible > combinations of "vendor,model" strings. > > Signed-off-by: Bartosz Golaszew

Re: [PATCH] dt-bindings: at24: convert the binding document to yaml

2019-09-23 Thread Peter Rosin
On 2019-09-23 20:34, Bartosz Golaszewski wrote: > pon., 23 wrz 2019 o 20:30 Peter Rosin napisał(a): >> >> which is no longer allowed. That might be a problem? The previous binding >> also allows less e.g. >> >> compatible = "atmel,24c00", &qu

Re: [EXT] Re: [v2,2/2] dt-bindings: i2c-mux-pca954x: Add optional property i2c-mux-never-disable

2019-10-14 Thread Peter Rosin
On 2019-10-14 06:16, Biwen Li wrote: >> >>> >>> On Mon, Sep 30, 2019 at 11:25:03AM +0800, Biwen Li wrote: The patch adds an optional property i2c-mux-never-disable Signed-off-by: Biwen Li --- Change in v2: - update documentation Documentation/devicetr

Re: [PATCH 1/2] dt-bindings: i2c: replace property i2c-mux-idle-disconnect

2019-10-14 Thread Peter Rosin
On 2019-10-14 13:25, Biwen Li wrote: > This replaces property i2c-mux-idle-disconnect with idle-state > > Signed-off-by: Biwen Li > --- > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetre

Re: [PATCH 2/2] i2c: mux: pca954x: replace property i2c-mux-idle-disconnect

2019-10-14 Thread Peter Rosin
On 2019-10-14 13:25, Biwen Li wrote: > This replaces property i2c-mux-idle-disconnect with idle-state > > Signed-off-by: Biwen Li > --- > drivers/i2c/muxes/i2c-mux-pca954x.c | 44 - > 1 file changed, 31 insertions(+), 13 deletions(-) > > diff --git a/drivers/i2c/muxe

Re: [v2,2/2] i2c: mux: pca954x: add property idle-state

2019-10-15 Thread Peter Rosin
On 2019-10-15 06:48, Biwen Li wrote: > This adds property idle-state > > Signed-off-by: Biwen Li > --- > Change in v2: > - update subject and description > - add property idle-state > > drivers/i2c/muxes/i2c-mux-pca954x.c | 47 ++--- > 1 file changed, 30 inse

Re: [v2,1/2] dt-bindings: i2c: add property idle-state

2019-10-15 Thread Peter Rosin
On 2019-10-15 06:48, Biwen Li wrote: > This adds property idle-state > > Signed-off-by: Biwen Li > --- > Change in v2: > - update subject and description > - add property idle-state > > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 1 + > 1 file changed, 1 insertion(+)

Re: [v3,1/2] dt-bindings: i2c: support property idle-state

2019-10-17 Thread Peter Rosin
On 2019-10-16 06:09, Biwen Li wrote: > This supports property idle-state > > Signed-off-by: Biwen Li > --- > Change in v3: > - update subject and description > - add some information for property idle-state > > Change in v2: > - update subject and description > - add prop

Re: [v3,2/2] i2c: mux: pca954x: support property idle-state

2019-10-17 Thread Peter Rosin
On 2019-10-16 06:09, Biwen Li wrote: > This supports property idle-state > > Signed-off-by: Biwen Li > --- > Change in v3: > - update subject and description > - add a helper function pca954x_calculate_chan() > > Change in v2: > - update subject and description > - add pr

Re: [v4,2/2] i2c: mux: pca954x: support property idle-state

2019-10-21 Thread Peter Rosin
On 2019-10-21 10:00, Biwen Li wrote: > This supports property idle-state > You should expand this a little bit to explain that idle-state, if present, overrides i2c-mux-idle-disconnect. You could also mention your use case where you need to avoid disconnects on probe/resume. > Signed-off-by: Biw

Re: [PATCH v5 3/9] i2c: add support for filters optional properties

2019-10-21 Thread Peter Rosin
On 2019-09-11 10:24, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > i2c-digital-filter-width-ns: > This optional timing property specifies the width of the spikes on the i2c > lines (in ns) that can be filtered out by built-in digital filters which are > embedded in some i2c control

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-21 Thread Peter Rosin
ter-width-ns as this >>> is applicable only to digital filter >>> - created new binding i2c-digital-filter-width-ns for analog filters. >> >> Hello Wolfram and Peter, >> >> Are you happy with the changes in this version? I haven't heard from you >&g

Re: [PATCH V15 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Peter Rosin
On 2019-02-08 13:46, Dmitry Osipenko wrote: > 08.02.2019 1:25, Dmitry Osipenko пишет: >>> 08.02.2019 1:16, Sowjanya Komatineni пишет:> > This is wrong, 65535 = 64 * 1024 - 1. > > Let's just use size-constants provided by kernel: > > static const struct i2c_adapter_quirks tegra_

Re: [PATCH v3 4/5] i2c:ocores: add SPDX tag

2019-02-08 Thread Peter Rosin
On 2019-02-08 17:12, Federico Vaga wrote: > It adds the SPDX tag and it removes the old text about the GPLv2. > > Signed-off-by: Federico Vaga > --- > drivers/i2c/busses/i2c-ocores.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ocores.c b

Re: [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support

2019-01-22 Thread Peter Rosin
On 2019-01-22 07:33, Alok Chauhan wrote: > Get the interconnect paths for I2C based Serial Engine device > and vote accordingly based on maximum supported I2C frequency. > > Signed-off-by: Alok Chauhan > --- > drivers/i2c/busses/i2c-qcom-geni.c | 13 + > 1 file changed, 13 insertions

Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option

2019-01-17 Thread Peter Rosin
On 2019-01-16 17:45, Bartlomiej Zolnierkiewicz wrote: > On 01/07/2019 11:35 AM, Peter Rosin wrote: >> Right. So, here's an update... >> >> Again, it would probably be best if this went in before 5.0 is released. >> >> Changes since v1: >> - rename

[PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks

2019-01-18 Thread Peter Rosin
The gpio API explicitly allows skipping the NULL check, precisely to allow for neat support for optional gpios. Which is exactly what is at play here. Reported-by: Andrzej Hajda Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/lvds-encoder.c | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH] i2c: iproc: Change driver to use 'BIT' macro

2019-04-18 Thread Peter Rosin
On 2019-04-18 19:25, Ray Jui wrote: > > > On 4/17/2019 11:21 PM, Peter Rosin wrote: >> On 2019-04-18 01:48, Ray Jui wrote: >>> >>> >>> On 4/14/2019 11:56 PM, Peter Rosin wrote: >>>> On 2019-04-13 00:59, Peter Rosin wrote: >>>>

Re: [PATCH] i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()

2019-04-21 Thread Peter Rosin
On 2019-01-04 19:06, Wolfram Sang wrote: > >> Instead of leaving these open-coded and prone to type mistakes, we can >> now use the new struct_size() helper: > > I am okay with this patch in general. However, I think the name of the > helper 'struct_size' is a bit unfortunate. I really wondered o

[PATCH 0/3] lib/string: search for NUL with strchr/strnchr

2019-05-06 Thread Peter Rosin
emset16/32/64 bug... Cheers, Peter Peter Rosin (3): lib/string: allow searching for NUL with strnchr lib/test_string: avoid masking memset16/32/64 failures lib/test_string: add some testcases for strchr and strnchr lib/string.c | 11 +++- lib/test_str

<    3   4   5   6   7   8   9   10   11   12   >