gt; Just that this 1s is here because of mdm uart.
Something like:
/*
* Spin waiting for TX fifo to have space available.
* When using the Microblaze Debug Module this can take up to 1s
*/
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
>>>>> "Wolfram" == Wolfram Sang writes:
> Warn users that class based instantiation is going away soon in favour
> of more robust probing and faster bootup times.
> Signed-off-by: Wolfram Sang
> Cc: Peter Korsgaard
> ---
> This patch is a su
drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
> Signed-off-by: Michal Simek
It would be good with a reference to the commit adding this to
platform_driver_register (9447057eaff8) - But Ok.
Acked-by: Peter K
t; err = -ENODEV;
> list_for_each_entry(rng, &rng_list, list) {
> -if (strcmp(rng->name, buf) == 0) {
> +
> +if (buf[len-1] == '\n')
> +snip = 1; /* Snip one character */
> +
How about using sysfs_streq() instead, whic
>>>>> "Maxime" == Maxime Ripard writes:
> The A33 has different a different gates array than the A23, add the node to
> the DT.
NIT: 2x different.
Shouldn't the a23 one then move from sun8i-a23-a33.dtsi to
sun8i-a23.dtsi?
--
Bye, Peter Korsgaard
--
To
>>>>> "Peter" == Peter Korsgaard writes:
>>>>> "Maxime" == Maxime Ripard writes:
>> The A33 has different a different gates array than the A23, add the node to
>> the DT.
> NIT: 2x different.
> Shouldn't the a23 o
c
configuration isn't critical to get something running.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
TIMO_DISABLED;
> +break;
> + case 40:
> +default:
> +value |= APCH_CFG_PRETIMO_40_MIN;
> +break;
> +}
> +
> +switch (charger->tolal_time_out) {
> +case 4:
> +value |= APCH_CFG_TOTTIMO_4_HOUR;
> +break;
> +case 5:
> +value |= APCH_CFG_TOTTIMO_5_HOUR;
> +break;
> +case 0:
> +value |= APCH_CFG_TOTTIMO_DISABLED;
> +break;
> +case 3:
> +default:
> +value |= APCH_CFG_TOTTIMO_3_HOUR;
> +break;
> +}
> +
> +return regmap_write(regmap, ACT8945A_APCH_CFG, value);
> +}
> +
> +static int act8945a_charger_probe(struct platform_device *pdev)
> +{
> +struct act8945a_dev *act8945a_dev = dev_get_drvdata(pdev->dev.parent);
> +struct act8945a_charger *charger;
> +struct power_supply_config psy_cfg = {};
> +int ret;
> +
> +charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
> +if (!charger)
> +return -ENOMEM;
> +
> +platform_set_drvdata(pdev, charger);
Never used, so you can drop this.
> +
> +charger->act8945a_dev = act8945a_dev;
Once again, why can't you just do something like:
charger->regmap = dev_get_regmap(pdev->dev.parent);
And drop this act8945_dev structure?
--
Bye, Peter Korsgaard
d in the logs
IN> without these error prints.
IN> This patch changes the error messages from these deferral cases
IN> to debug messages.
IN> Signed-off-by: Ionut Nicu
Acked-by: Peter Korsgaard
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This me
>>>>> "Fabian" == Fabian Frederick writes:
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
> Signed-off-by: Fabian Frederick
> ---
For this:
> drivers/tty/serial/uartlite.c | 2 +-
Ac
option. The
> original code did also continue
Ahh yes, you are right. Sorry, it's been a while since I wrote that code
(2008).
> If you still want to abort if no irq I can of course make the change.
No, it is fine.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: sen
; otherwise continue.
Indeed - Sorry, I must have been confused yesterday.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-in
the value of
> the clock assigned to this platform_device?
> The usual thing to do when 'clock-frequency' is not set is to default to
> 100kHz.
The confusion comes from the fact that the device tree bindings uses
clock-frequency for the clock frequency of the IP core and NOT
t_eeprom which tested good with ethtool
> utility.
Thanks for the patch. This sounds like 3 seperate changes, could you
please restructure it as 3 patches each doing one of the changes?
--
Bye, Peter Korsgaard
+gpio->regmap = axp20x->regmap;
This could just use dev_get_regmap(pdev.dev->parent, NULL) instead of
fiddling in the parent driver data.
> +
> +ret = gpiochip_add(&gpio->chip);
> + if (ret) {
> +dev_err(&pdev->dev, "Failed to register GPIO chip\n");
> +return ret;
> +}
> +
> +dev_info(&pdev->dev, "AXP209 GPIO driver loaded\n");
Any reason to be so noisy?
--
Bye, Peter Korsgaard
.
How common are these adapters without valid eeprom? What happens if the
eeprom content isn't fixed?
Do we need to reset the device once the eeprom is updated?
--
Bye, Peter Korsgaard
terrupt-interval */
> +dm_write_reg(dev, DM_USB_CTRL, USB_CTRL_EP3ACK);
Why would we want to do that instead of the current setup that afaik
only returns data when the link status changes?
--
Bye, Peter Korsgaard
o this
> patch the IRQ controller behind this device, and its driver, can have
> different implementations (nested threads). For this reason, it is safer
> to use `request_any_context_irq()` to avoid errors at probe time.
> Signed-off-by: Federico Vaga
Reviewed-by: Peter Korsgaard
--
Bye, Peter Korsgaard
On Tue, Aug 21, 2018 at 7:28 PM Peter Korsgaard wrote:
>
> For some use cases it is handy to use a different printk log level than the
> default (info) for the messages written to ttyprintk, so add a Kconfig
> option similar to what we have for default console loglevel.
Ping? Feedba
>>>>> "Joe" == Joe Perches writes:
> On Fri, 2018-09-07 at 09:50 +0200, Peter Korsgaard wrote:
>> On Tue, Aug 21, 2018 at 7:28 PM Peter Korsgaard wrote:
>> >
>> > For some use cases it is handy to use a different printk log level t
For some use cases it is handy to use a different printk log level than the
default (info) for the messages written to ttyprintk, so add a Kconfig
option similar to what we have for default console loglevel.
Signed-off-by: Peter Korsgaard
---
Changes since v1:
- Leave [U] prefix in printk
>>>>> "Wolfram" == Wolfram Sang writes:
>> Thanks! I'll take a look at the patches now.
> Ping :)
I'm terribly sorry. I didn't manage to review before leaving on
travel. I'm back next week and then I'll review, OK?
--
Bye, Peter Korsgaard
>>>>> "WS" == Wolfram Sang writes:
WS> This header only contains platform_data. Move it to the proper directory.
WS> Signed-off-by: Wolfram Sang
Thanks,
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
This message is subject to the following terms and co
ace executables
>>
>> So far i have not come across a toolchain (or a way to create toolchain)
>> to create !MMU user space executables for Cortex-A.
> Now able to reach prompt using buildroot initramfs, Thanks to
> Peter Korsgaard for suggesting the way to create
>>>>> "Corentin" == Corentin Labbe writes:
> Instead of ading more ifthen login for adding a new mac_device_info
s/login/logic/
--
Bye, Peter Korsgaard
>>>>> "Wolfram" == Wolfram Sang writes:
> The core will do this for us now.
> Signed-off-by: Wolfram Sang
> ---
> drivers/i2c/busses/i2c-ocores.c | 4 +---
For i2c-ocores.c:
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
t; +ret = PTR_ERR(dd->aclk);
It looks like it is the other way around. It should test
IS_ERR(dd->gclk) instead.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
list_for_each_entry(rng, &rng_list, list) {
> -if (strcmp(rng->name, buf) == 0) {
> + if (sysfs_streq(rng->name, buf)) {
Looks good.
Acked-by: Peter Korsgaard
--
Venlig hilsen,
Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscr
Changes v1->v2:
> - expand changelog with motivation for the change.
You should also document the big-endian property in
Documentation/devicetree/bindings/i2c/i2c-ocores.txt, otherwise it looks
good.
With that added:
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this
re common properties documented
> in the Documentation/devicetree/bindings/common-properties.txt
Ok, then it looks good to me.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More major
>>>>> "Samuel" == Samuel Thibault writes:
> Hello,
> Just to give an update to people who where Cc-ed at some point in the
> discussion: a version reworked by Dmitry got pulled into Linus' tree, so
> it should get into 4.2!
> Thanks to ever
an OF table will do nothing.
To add to the confusion, the regulator part of the chip is actually
identical to act8865, so it could use the existing regulator driver /
compatible, except that it binds to the platform bus instead of i2c.
--
Bye, Peter Korsgaard
devm. With that removed (and
the logic to devm_kzalloc it) you can add my:
Acked-by: Peter Korsgaard
> +static const struct mfd_cell act8945a_devs[] = {
> +{
> +.name = "act8945a-regulator",
> +.of_compatible = "ac
>>>>> "Cristian" == Cristian Ciocaltea writes:
> The PPI interrupts for cortex-a9 were incorrectly specified, fix them.
> Fixes: fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar")
> Signed-off-by: Cristian Ciocaltea
Reviewed-by: Peter Korsgaard
--
Bye, Peter Korsgaard
>>>>> "Cristian" == Cristian Ciocaltea writes:
> Add a Device Tree for the RoseapplePi SBC.
> Signed-off-by: Cristian Ciocaltea
Reviewed-by: Peter Korsgaard
On a related note: There is now an owl-mmc driver for the s900. From a
quick look at the datashe
re currently doesn't exist any other flags.
TYPE_SIFIVE_REV0 is also set for two compatibles:
{
.compatible = "sifive,fu540-c000-i2c",
.data = (void *)TYPE_SIFIVE_REV0,
},
{
.compatible = "sifive,i2c0",
.data = (void *)TYPE_SIFIVE_REV0,
},
Are both affected by this issue? if not, we will need to extend the code
to handle them differently.
Other than that, it looks OK to me.
--
Bye, Peter Korsgaard
"sifive,fu540-c000-i2c"))
> Please let me know if this is okay.
Yes, that sounds sensible. Thanks.
--
Bye, Peter Korsgaard
>>>>> "Cristian" == Cristian Ciocaltea writes:
> Hi Peter,
> Thanks for the review!
> On Thu, Aug 27, 2020 at 08:44:40AM +0200, Peter Korsgaard wrote:
>> >>>>> "Cristian" == Cristian Ciocaltea
>> >>>>
; +
> irq = platform_get_irq(pdev, 0);
> -if (irq == -ENXIO) {
> +if (i2c->flags & OCORES_FLAG_BROKEN_IRQ || irq == -ENXIO) {
Alternatively you can move it after the irq = platform_get_irq(pdev, 0)
line and just clear irq, E.G.:
irq = platform_get_irq(pdev, 0);
if (of_device_is_compatible(..)) {
i2c->flags |= OCORES_FLAG_BROKEN_IRQ;
irq = -ENXIO;
}
if (irq == -ENXIO) {
..
--
Bye, Peter Korsgaard
("i2c: ocores: add polling mode workaround
> for Sifive FU540-C000 SoC")
> Signed-off-by: Sagar Shrikant Kadam
LGTM, thanks.
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
ll out what DRC and SAT stands for in the driver source code,
perhaps it also makes sense to do it here?
Perhaps rewording it to something like this is clearer:
.. allows to dynamically adjust pixel brightness/contrast based on
histogram measurements for LCD content adaptive backlight control.
--
Bye, Peter Korsgaard
101 - 141 of 141 matches
Mail list logo
