>>>>> "Ricardo" == Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> writes:
> Hello Peter >> >> > - hwirq = irq_of_parse_and_map(np, 0); >> > - if (hwirq == NO_IRQ) >> > + mpc8xxx_gc->irqn = irq_of_parse_and_map(np, 0); >> > + if (mpc8xxx_gc->irqn == NO_IRQ) >> > return 0; >> >> >> With this return 0 converted to do of_mm_gpiochip_remove(): > Are you sure? The driver can still work as a normal gpio without the > irq domain part and the remove function consider this option. The > original code did also continue.... Ahh yes, you are right. Sorry, it's been a while since I wrote that code (2008). > If you still want to abort if no irq I can of course make the change. No, it is fine. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
