Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

2012-11-26 Thread Peter Korsgaard
e. As was discussed recently, there's several reasons why the pinctrl call might fail, and not all are fatal (E.G. pinmux already setup by bootloader): http://article.gmane.org/gmane.linux.kernel/1399756 -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-27 Thread Peter Korsgaard
then we can reasonably assume that Thierry> your second case can't happen, can't we? Well, peripherals only need pinmuxing if the bootloader didn't already set it up in advance. We could naturally enforce people to add "redundant" pinmux info to their .dts files, but

Re: [PATCH v2 3/3] ARM: davinci: da850: add EHRPWM & ECAP DT node

2013-03-20 Thread Peter Korsgaard
hanks for CC'ing me. I also think da850-* should be documented. See Documentation/devicetree/bindings/gpio/8xxx_gpio.txt for an similar (old) example. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] gpio: mpc8xxx: don't set IRQ_TYPE_NONE when creating irq mapping

2013-02-03 Thread Peter Korsgaard
wonder what was the point of adding it. Sorry, don't recall. It's been quite a while, and I've haven't worked on anything mpc8xxx for a few years by now. Most likely one of the other gpio drivers did it like this back then. I don't remember the details, but your description

Re: [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node

2013-02-01 Thread Peter Korsgaard
>>>>> "Philip" == Philip Avinash writes: Philip> DT field of "interrupts" was mentioned wrongly as "interrupt" in SPI Philip> node. This went unnoticed as spi-omap2 driver not making use of Philip> interrupt. Fixes the typo. Philip>

Re: [PATCH] mtd: devices: elm: Removes literals in elm DT node

2013-01-24 Thread Peter Korsgaard
>>>>> "Philip" == Philip Avinash writes: Philip> As part of removing generalized dependency, replace Philip> literal fields in DT compatible field with <52> for am335x Philip> platforms. Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To u

Re: [PATCH v3 3/8] input: touchscreen: ti_tsc: remove unwanted fifo flush

2013-01-27 Thread Peter Korsgaard
and not the more standard ~70 chars? It would be good with some more detailed commit text. Is the flush done somewhere else now? What happens on boards where you don't use the adc part? -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH v4 4/8] MFD: ti_am335x_tscadc: add device tree binding information

2013-01-27 Thread Peter Korsgaard
wires on touchscreen. ti,wires seems redundant given ti,wire-config (E.G. number of elements in array). It is not clear to me what the magic values in wire-config mean? P> + P> +adc: P> +- ti,adc-channels: Number of ADC channels used. Is there ever any use case for this being something e

Re: [PATCH] cpsw: Fix interrupt storm among other things

2013-01-28 Thread Peter Korsgaard
- mac-address : Specifies slave MAC address Pantelis> +- disable-napi : Disables driver NAPI napi is not a hardware feature, so it doesn't belong here (if anything, it should be linux,disable-napi). -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "un

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-26 Thread Peter Korsgaard
introduction mail: 1. ARMv7, 1.5GHz based board Kernel: linux 3.4 Uncompressed Kernel Size: 14MB Compressed Size Decompression Speed LZO 6.7MB21.1MB/s LZ4 7.3MB29.1MB/s, 45.6MB/s(UA) -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-12 Thread Peter Korsgaard
nterrupt-parent should be removed from the example as well to >> match am33xx.dtsi Matt> On second thought, I'm not sure we're going to get any direction Matt> on this one so let's just do what feels right and make it reflect Matt> common usage like you suggested. Soun

Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

2013-03-14 Thread Peter Korsgaard
hardware block is identical the dts should simply list: compatible = "ti,da850-ecap", "ti,am33xx-ecap" And the driver only bind to ti,am33xx-ecap (unless there ever needs to be a da850 specific workarounde. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] ARM: davinci: da850: add EHRPWM & ECAP DT node

2013-03-14 Thread Peter Korsgaard
status = "disabled"; P> }; P> + ehrpwm0: ehrpwm@01f0 { P> + compatible = "ti,da850-ehrpwm"; This should be: compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm"; P> + e

Re: [PATCH 050/193] drivers/i2c/muxes: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Peter Korsgaard
>>>>> "KC" == Kees Cook writes: KC> This config item has not carried much meaning for a while now and is KC> almost always enabled by default. As agreed during the Linux kernel KC> summit, remove it. Acked-by: Peter Korsgaard KC> CC: Stephen Warren KC&

Re: [PATCH 1/2] i2c: i2c-ocores: Add irq support for sparc

2012-10-23 Thread Peter Korsgaard
at internally Andreas> still uses platform_get_resource. I have no idea why sparc is being odd in this regard, but assuming this is how it's done, I'm fine with this change. A quick grep doesn't find any other drivers doing this though: git grep -l archdata.irqs drivers | xargs grep platform_ge

Re: [PATCH 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-10-23 Thread Peter Korsgaard
c-ocores.c Andreas> +++ b/drivers/i2c/busses/i2c-ocores.c Andreas> @@ -4,6 +4,9 @@ Andreas> * Andreas> * Peter Korsgaard Andreas> * Andreas> + * Support for the GRLIB port of the controller by Andreas> + * Andreas Larsson Andreas> + * Andreas> * This file

Re: [PATCH 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-10-24 Thread Peter Korsgaard
forms that Andreas> have ioread/write32, but not ioread/write32be are frv and mn10300. Do Andreas> you know if those platforms are using i2c-ocores? Not to my knowledge, no. In that case: Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the li

Re: [PATCH 1/2] i2c: busses: i2c-ocores: Fix documentation filename

2012-09-23 Thread Peter Korsgaard
>>>>> "Maxin" == Maxin B John writes: Maxin> Fixes the wrong filename. Maxin> Signed-off-by: Maxin B. John Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 2/2] i2c: busses: i2c-ocores: switch to devm_request_and_ioremap

2012-09-23 Thread Peter Korsgaard
>>>>> "Maxin" == Maxin B John writes: Maxin> This drops a few lines of code and allows common APIs to handle Maxin> those for us. Maxin> Signed-off-by: Maxin B. John Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list

Re: [PATCH] i2c-mux-gpio: use deferred probing with the device tree

2013-10-08 Thread Peter Korsgaard
another error code. This error should be passed further IN> instead of being ignored. Two different fixes, so should be 2 separate patches. Other that that, it looks good. Acked-by: Peter Korsgaard -- Sorry about disclaimer - It's out of my control. Bye, Peter Korsgaard This message is sub

Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree

2013-10-08 Thread Peter Korsgaard
>>>>> "IN" == Ionut Nicu writes: IN> If the i2c-parent bus driver is not loaded, returning IN> -EINVAL will force people to unload and then reload the IN> module again to get it working. IN> Signed-off-by: Ionut Nicu Acked-by: Peter Korsgaard -- So

Re: [PATCH 2/2] i2c-mux-gpio: don't ignore of_get_named_gpio errors

2013-10-08 Thread Peter Korsgaard
>>>>> "IN" == Ionut Nicu writes: IN> of_get_named_gpio could return -E_PROBE_DEFER or another IN> error code. This error should be passed further instead IN> of being ignored. Acked-by: Peter Korsgaard -- Sorry about disclaimer - It's out of my contro

Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree

2013-10-08 Thread Peter Korsgaard
>> >> Signed-off-by: Ionut Nicu WS> Doesn't the non-DT case need fixing, too? Arguably yes. -- Bye, Peter Korsgaard This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer> -- To unsubscribe from this li

Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing

2013-10-09 Thread Peter Korsgaard
>>>>> "IN" == Ionut Nicu writes: IN> If the i2c-parent bus driver is not loaded, returning IN> -ENODEV will force people to unload and then reload the IN> module again to get it working. IN> Signed-off-by: Ionut Nicu Acked-by: Peter Korsgaard -- So

Re: [PATCH 2/2] i2c: busses: i2c-ocores: switch to devm_request_and_ioremap

2012-10-09 Thread Peter Korsgaard
>>>>> "Maxin" == Maxin B John writes: Maxin> Hi Peter, Maxin> This drops a few lines of code and allows common APIs to handle Maxin> those for us. Maxin> Signed-off-by: Maxin B. John >> Acked-by: Peter Korsgaard Maxin> Is there any upda

Re: [PATCH v3 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-11-13 Thread Peter Korsgaard
/ TYPE_GRLIB) and a 2nd of_device_id entry with .data = TYPE_GRLIB, and then using that in the probe routine would be nicer. Have a look at i2c-at91.c for an example of a driver doing something like that. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v3 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
>> example of a driver doing something like that. Andreas> Yes, that is a good idea. Do you think casting to and from Andreas> void * in the following solution is too ugly and rather have a Andreas> struct pointed to, or do you think that would be unnecessary? I find the castin

Re: [PATCH v4 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
; + Andreas> + match = of_match_node(ocores_i2c_match, pdev->dev.of_node); Andreas> + if (match) Andreas> + return (int)match->data; Can this ever fail? If not, you might as well do the of_match_node inline in the probe instead of this helper. Other than that

Re: [PATCH v5 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
could even move to a single ops structure), so it would be shorter to assign them at the same time: if (!i2c->setreg || !i2c->getreg) { switch (i2c->reg_io_width) { case 1: i2c->setreg = oc_setreg_8; i2c->getreg = oc_getreg_8; break; case 2:

Re: [PATCH 1/2] ASoC: tlv320aic326x: Support for TI TLV320AIC3262 audio driver

2012-12-19 Thread Peter Korsgaard
gt; + aic3xxx_free_irq(aic3xxx, Mehar> +AIC3XXX_IRQ_HEADSET_DETECT, codec); Mehar> + destroy_workqueue(aic3262->workqueue); Mehar> +work_err: Mehar> + kfree(aic3262->cfw_p); Mehar> + return ret; Mehar> +} --

Re: [PATCH v6 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
om Andreas> grlib functions by setting the setreg and getreg function Andreas> pointers. Andreas> Signed-off-by: Andreas Larsson Acked-by: Peter Korsgaard Thanks! -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] spi: omap2-mcspi: Fix the redifine warning

2012-11-19 Thread Peter Korsgaard
327:12: originally declared Shubhrajyoti> here Shubhrajyoti> So delete the u8 tx as it is assigned and not Shubhrajyoti> used(resigned afterwards). Shubhrajyoti> Signed-off-by: Shubhrajyoti D Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send t

Re: [PATCH 1/1] net: add dm9620 net usb driver

2013-06-23 Thread Peter Korsgaard
usbnet_resume, Joseph> + .disable_hub_initiated_lpm = 1, Joseph> +}; Joseph> + Joseph> +module_usb_driver(dm9620_driver); Joseph> + Joseph> +MODULE_AUTHOR("Peter Korsgaard "); I'm not the author of this file. -- Bye, Peter Korsgaard -- To unsubscribe from t

Re: [PATCH 1/1] net: add dm9620 net usb driver

2013-07-05 Thread Peter Korsgaard
nt compare to DM9601 & DM9620. And will get the same Joseph> issue. If you can provide me with a dm9633 datasheet and a sample device then I can look into writing a driver for it / extending dm9601.c. Please contact me off list for that. Thanks! -- Bye, Peter Korsgaard -- To unsubscribe

Re: [PATCH 1/2] pwm: pwm-tiecap: Update device-tree binding document

2013-03-25 Thread Peter Korsgaard
>>>>> "Philip" == Philip Avinash writes: Philip> Update binding document of pwm-tiecap to reflect the usage of similar Philip> modules in da850 and am3xx SOCs. Acked-by: Peter Korsgaard Philip> Signed-off-by: Philip Avinash Philip> Cc: Grant Likely

Re: [PATCH 2/2] pwm: pwm-tiehrpwm: Update device-tree binding document

2013-03-25 Thread Peter Korsgaard
>>>>> "Philip" == Philip Avinash writes: Philip> Update binding document of pwm-tiehrpwm to reflect the usage of similar Philip> modules in da850 and am3xx SOCs. Acked-by: Peter Korsgaard Philip> Signed-off-by: Philip Avinash Philip> Cc: Grant Like

Re: [PATCH v3] gpio: mcp23s08: convert driver to DT

2013-03-25 Thread Peter Korsgaard
any significant work on that driver since David.. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Caps lock XOR on multiple keyboards?

2013-03-26 Thread Peter Korsgaard
issue for Xorg, but it'd still be a good Samuel> thing to at last apply it :) Agreed. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH] Route kbd LEDs through the generic LEDs layer

2013-07-15 Thread Peter Korsgaard
d-off-by: Evan Broder Looks good to me. Samuel, thanks for picking this up again. Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH] i2c: busses: i2c-ocores: Fix PM-related warning

2013-03-04 Thread Peter Korsgaard
t; -#else >> -#define OCORES_I2C_PM NULL >> -#endif >> >> static struct platform_driver ocores_i2c_driver = { >> .probe = ocores_i2c_probe, >> @@ -490,7 +487,7 @@ static struct platform_driver ocores_i2c_driver = { >> .owner = THIS_MODULE, >

Re: [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver

2013-04-16 Thread Peter Korsgaard
master is supported"? Also there's a typo: s/use the claim/use to claim/ -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] dts: am33xx: Correct properties on gpmc node

2013-05-28 Thread Peter Korsgaard
he properties in the dts to provide the right values for the Lars> gpmc driver. Lars> Signed-off-by: Lars Poeschel Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-06 Thread Peter Korsgaard
t; + Matt> +edma: edma@4900 { Matt> +reg = <0x4900 0x1>; Matt> +interrupt-parent = <&intc>; Matt> +interrupts = <12 13 14>; Probably interrupt-parent should be removed from the example as well to match am33xx.dtsi -- Bye, Pe

Re: [PATCH 1/3] ARM: dts: AM33XX: Add ELM node

2013-01-21 Thread Peter Korsgaard
Philip>mac-address = [ 00 00 00 00 00 00 ]; Philip>}; Philip>}; Philip> + Philip> + elm: elm@4808 { Philip> + compatible = "ti,am33xx-elm"; Please d

Re: [PATCH 2/3] ARM: dts: AM33XX: Add GPMC node

2013-01-21 Thread Peter Korsgaard
ing 7 cs signals, I just realized the difference in compatible string between the gpmc and elm. The gpmc refers to a real device (which is afaik how it should be done), but the elm compatible is simply ti,am33xx-elm. Presumably it should have been ti,am3352-elm in the binding instead? Other than that

Re: [PATCH 1/2] tty: serial: uartlite: Fix sparse and checkpatch warnings

2013-02-16 Thread Peter Korsgaard
>>>>> "Michal" == Michal Simek writes: Michal> Clean coding style and sparse warnings. Michal> Signed-off-by: Michal Simek Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH 2/2] tty: serial: uartlite: Support uartlite on big and little endian systems

2013-02-16 Thread Peter Korsgaard
>>>>> "Michal" == Michal Simek writes: Michal> Use big and little endian accessors function to reflect system Michal> configuration. Detection is done via control register in Michal> ulite_request_port. Acked-by: Peter Korsgaard -- Bye, Peter Korsgaar

Re: [PATCH 1/4] mtd: nand: omap2: Update nerrors using ecc.strength

2012-10-15 Thread Peter Korsgaard
t 'correctable' misspelled. I don't personally think these defines improve readability very much compared to to just using 4/8, though. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme

2012-10-15 Thread Peter Korsgaard
oob 2..53): http://www.ti.com/litv/pdf/spruh73f I see the driver in the u-boot-am33x tree (ti81xx_nand.c) seems to use 4x14 bytes as well though, so perhaps that's a bug in the documentation instead? -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 2/4] mtd: devices: elm: Add support for ELM error correction

2012-10-15 Thread Peter Korsgaard
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + */ > + > +#ifndef __ELM_H > +#define __ELM_H > + > +enum bch_ecc {

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Peter Korsgaard
er) - Pinmux specified in dt - Some kind of misconfiguration in dt You could argue that devm_pinctrl_get_select_default() shouldn't return an error for the first situation, but how should it be able to know the difference between 2 and 4? -- Bye, Peter Korsgaard -- To unsubscribe from thi

Re: [PATCH 3/3] drivers/serial/uartlite.c: Add missing of_node_put

2007-12-04 Thread Peter Korsgaard
ff-by: Julia Lawall <[EMAIL PROTECTED]> Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] net/smc911x: Match up spin lock/unlock

2007-02-01 Thread Peter Korsgaard
smc911x_phy_configure's error handling unconditionally unlocks the spinlock even if it wasn't locked. Patch fixes it. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/smc911x.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-t

Re: [PATCH] two more device ids for dm9601 usbnet driver

2007-03-11 Thread Peter Korsgaard
owland <[EMAIL PROTECTED]> Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> -- Bye, Peter Korsgaard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [linux-sunxi] [PATCH v2 4/9] drm/sun4i: Add a DRC driver

2016-09-06 Thread Peter Korsgaard
y. > Add a minimal driver for it that just claim the needed resources for the > pipeline to operate properly. > Signed-off-by: Maxime Ripard Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH] i2c: ocores: add missed clk_disable_unprepare() on failure paths

2016-08-04 Thread Peter Korsgaard
>>>>> "Alexey" == Alexey Khoroshilov writes: > clk_disable_unprepare() is missed on failure paths in ocores_i2c_probe(). > Found by Linux Driver Verification project (linuxtesting.org). > Signed-off-by: Alexey Khoroshilov Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read

2015-10-21 Thread Peter Korsgaard
ss > pointers). As the serial number is available on a separate i2c address, wouldn't it be simpler to handle these as special (read only) device variants and instantiate E.G. a 24c64 (for the normal data) and a 24cs64 (for the serial)? -- Bye, Peter Korsgaard -- To unsubscribe from this

Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read

2015-10-21 Thread Peter Korsgaard
t; both memory blocks share the same address pointer. > I'll resend the series. But we're protected by the i2c bus lock, right? You do a single i2c_transfer to read the serial number. -- Venlig hilsen, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscrib

Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read

2015-10-21 Thread Peter Korsgaard
my bad. It needs to be fixed as >> > both memory blocks share the same address pointer. >> >> > I'll resend the series. >> >> But we're protected by the i2c bus lock, right? You do a single >> i2c_transfer to read the serial number. > Wh

Re: [PATCH V2] i2c: ocores: update HDL sources URL

2018-06-21 Thread Peter Korsgaard
hanks! > @Peter: since the patch is trivial and nice to have in 4.17 already, I > took the liberty to apply it right away. Hope this is fine with you. Sorry for the slow response - Yes it is indeed. -- Bye, Peter Korsgaard

[PATCH] ttyprintk: make the printk log level configurable

2018-08-21 Thread Peter Korsgaard
For some use cases it is handy to use a different printk log level than the default (info) for the messages written to ttyprintk, so add a Kconfig option similar to what we have for default console loglevel. Signed-off-by: Peter Korsgaard --- drivers/char/Kconfig | 8 drivers/char

Re: i2c:ocores: fixes and polling mechanism

2018-08-22 Thread Peter Korsgaard
it or not. > Adding Peter to CC using his latest EMail address. Thanks! I'll take a look at the patches now. > Peter, you said you wanted to update MAINTAINERs with the new address? Sorry, I forgot about it when I left on holidays. Will send now. -- Bye, Peter Korsgaard

Re: [PATCH v2 2/2] arm64: dts: meson: add libretech aml-s805x-ac board

2018-11-16 Thread Peter Korsgaard
/* > + * This is controlled by GPIOAO_9 we reserve this but > + * claiming it as done bellow reset the board anyway The 'bellow' typo is still here? -- Bye, Peter Korsgaard

Re: [PATCH RESEND v2 2/2] arm64: dts: meson: add libretech aml-s805x-ac board

2018-11-16 Thread Peter Korsgaard
>>>>> "Jerome" == Jerome Brunet writes: > From: Neil Armstrong > Add Libretech aml-s805x-ac board (aka 'La Frite') support > Signed-off-by: Neil Armstrong > Signed-off-by: Jerome Brunet Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH RESEND 2/2] arm64: dts: meson: add libretech aml-s805x-ac board

2018-11-14 Thread Peter Korsgaard
we reserve this but > + * claiming it as done bellow reset the board anyway s/bellow/below/ > +&spifc { > +status = "okay"; > +pinctrl-0 = <&nor_pins>; > +pinctrl-names = "default"; > + > +w25q32: spi-fla

[PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-05 Thread Peter Korsgaard
cryptsetup luksOpen. As the change was purely cosmetical, revert it to fix such breakage. Signed-off-by: Peter Korsgaard --- drivers/firmware/dmi_scan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-05 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: > This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. > The output of dmi_save_uuid() is exposed to user space as > /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility, > E.G. I

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-06 Thread Peter Korsgaard
>>>>> "Jean" == Jean Delvare writes: > On Wed, 2018-12-05 at 22:13 +0100, Peter Korsgaard wrote: >> This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7. >> >> The output of dmi_save_uuid() is exposed to user space as >> /sys/dev

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-06 Thread Peter Korsgaard
4.19 has only recently become >> LTS. > I can't see how this is related with kernel 4.19 becoming LTS. Only in the sense that that LTS kernels see wider use than non-LTS kernels (E.G. I discovered this when moving from 4.14.x to 4.19.x). > Look, you can imagine that I was perfectly aware of what I was doing > when I made that change, and that I pondered the decision carefully at > that time. And my decision was that the change should be made. As far > as I'm concerned, this ship has sailed already, sorry. Sorry, what is the perceived risk of reverting this change? Just the minor inconsistency between the dmidecode and sysfs output? As stated above, the RFC requires conforming parsers to handle upper case as well. -- Bye, Peter Korsgaard

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-11 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Hi Jean, >> Look, you can imagine that I was perfectly aware of what I was doing >> when I made that change, and that I pondered the decision carefully at >> that time. And my decision was that the change

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

2018-12-11 Thread Peter Korsgaard
>>>>> "Jean" == Jean Delvare writes: > On Tue, 2018-12-11 at 13:06 +0100, Peter Korsgaard wrote: >> > > > > > "Peter" == Peter Korsgaard writes: >> >> Hi Jean, >> >> >> Look, you can imagine

[RESEND PATCH v2] ttyprintk: make the printk log level configurable

2018-10-10 Thread Peter Korsgaard
For some use cases it is handy to use a different printk log level than the default (info) for the messages written to ttyprintk, so add a Kconfig option similar to what we have for default console loglevel. Signed-off-by: Peter Korsgaard --- Changes since v1: - Leave [U] prefix in printk

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-29 Thread Peter Korsgaard
s may run in > atomic context where we can't sleep at all. Great! BTW I noticed that your sleep_min calculation looked odd: int sleep_min = (8/i2c->bus_clock_khz) * 1000; /* us for 8bits bus_clock_khz almost certainly will be bigger than 8 (E.G. likely 100KHz), so the above set sleep_min to 0. Please move the * 1000 before the division. -- Bye, Peter Korsgaard

[RESEND PATCH v2] ttyprintk: make the printk log level configurable

2018-11-06 Thread Peter Korsgaard
For some use cases it is handy to use a different printk log level than the default (info) for the messages written to ttyprintk, so add a Kconfig option similar to what we have for default console loglevel. Signed-off-by: Peter Korsgaard --- Changes since v1: - Leave [U] prefix in printk

[RESEND PATCH v2] ttyprintk: make the printk log level configurable

2018-10-25 Thread Peter Korsgaard
For some use cases it is handy to use a different printk log level than the default (info) for the messages written to ttyprintk, so add a Kconfig option similar to what we have for default console loglevel. Signed-off-by: Peter Korsgaard --- Changes since v1: - Leave [U] prefix in printk

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-26 Thread Peter Korsgaard
tion that the hardware is alive and what we read from > oc_getreg() is correct. With this assumption, when there is a timeout this > will happen: > 1. STOP command (previous patch) > 2. both TIP and BUSY will become zero at some point and we get out from the > loop > I can see now that there are cases when it may loop forever: for example if > the device is broken and it does answer always with 0x: we should not > break the host as well :) > I can fix this. Thanks! -- Bye, Peter Korsgaard

Re: [PATCH 1/3] i2c:ocores: stop transfer on timeout

2018-10-26 Thread Peter Korsgaard
>>>>> "Federico" == Federico Vaga writes: Hi, > I had another look at the HDL code and apparently my assumption was wrong, > and > STOP just do stop, and IACK is still necessary. > So, yes, without try is better because we save an extra, useless,

Re: [PATCH 1/3] i2c:ocores: stop transfer on timeout

2018-10-21 Thread Peter Korsgaard
ng - But I still don't quite understand this trylock logic. If we end up here with the lock taken, then that must mean that we are on SMP system. We still need to ack the interrupt, so just spinning until the other CPU releases the lock seems more sensible? -- Bye, Peter Korsgaard

Re: [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set

2018-10-21 Thread Peter Korsgaard
ction > expects it to be read by the caller. > > Signed-off-by: Federico Vaga Looks good. Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-21 Thread Peter Korsgaard
_CTRL_IEN); > + oc_setreg(i2c, OCI2C_CONTROL, ctrl); This looks unrelated to $SUBJECT > > prescale = (i2c->ip_clock_khz / (5 * i2c->bus_clock_khz)) - 1; > prescale = clamp(prescale, 0, 0x); > @@ -277,12 +332,16 @@ static int ocores_init(struct device *dev, struct > ocores_i2c *i2c) > return -EINVAL; > } > > + Here as well. > @@ -538,6 +600,8 @@ static int ocores_i2c_remove(struct platform_device *pdev) > { > struct ocores_i2c *i2c = platform_get_drvdata(pdev); > > + flush_scheduled_work(); > + Why not cancel_work_sync(&i2c->xfer_work)? -- Bye, Peter Korsgaard

Re: [PATCH v2] ttyprintk: make the printk log level configurable

2018-09-16 Thread Peter Korsgaard
On Fri, Sep 7, 2018 at 10:18 AM Peter Korsgaard wrote: > > For some use cases it is handy to use a different printk log level than the > default (info) for the messages written to ttyprintk, so add a Kconfig > option similar to what we have for default console loglevel. > > Si

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-12-09 Thread Peter Korsgaard
iew since April 2014! Hah, I'm pretty sure it dates back to 2010 atleast. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] i2c-ocores: add common clock support

2015-01-22 Thread Peter Korsgaard
the history, the device tree patch originally used a custom "clock_khz" property until some guy told him to use clock-frequency ;) https://lists.ozlabs.org/pipermail/devicetree-discuss/2010-November/003650.html As far as I can see I wasn't CC'ed on that patch. -- Bye, Peter Korsg

Re: [PATCH] i2c-ocores: add common clock support

2015-01-16 Thread Peter Korsgaard
>>>>> "Max" == Max Filippov writes: > Allow bus clock specification as a common clock handle. This makes this > controller easier to use in a setup based on common clock framework. > Signed-off-by: Max Filippov Looks sensible to me - Thanks. Acked-by

Re: [PATCH 7/8] gpio/mpc8xxx: Convert to platform device interface.

2015-01-19 Thread Peter Korsgaard
>>>>> "Ricardo" == Ricardo Ribalda Delgado writes: > This way we do not need to transverse the device tree manually. > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Grant Likely > Cc: Rob Herring > Cc: Peter Korsgaard > Cc: device

Re: [PATCH 7/8] gpio/mpc8xxx: Convert to platform device interface.

2015-01-19 Thread Peter Korsgaard
>>>>> "Ricardo" == Ricardo Ribalda Delgado writes: > This way we do not need to transverse the device tree manually. > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Grant Likely > Cc: Rob Herring > Cc: Peter Korsgaard > Cc: device

Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-19 Thread Peter Korsgaard
Walleij > Cc: Alexandre Courbot > Cc: Peter Korsgaard > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/gpio/gpio-mpc8xxx.c | 28 +++- > 1 file changed, 23 insertions(+), 5 deletions(-) > diff --git a/drivers/gpio/gpio-mpc8xxx.c b/

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

2015-04-02 Thread Peter Korsgaard
message when a driver >> requests probe deferral, so this can be traced in the logs >> without these error prints. >> >> This patch removes the error messages for these deferral cases. >> >> Signed-off-by: Ionut Nicu AS> Acked-by: Alexander Sverdlin Acked-by:

Re: [PATCH 08/17] uartlite: remove IRQF_SAMPLE_RANDOM which is now a no-op

2012-07-17 Thread Peter Korsgaard
The IRQF_SAMPLE_RANDOM Theodore> flag was scheduled to be removed in 2009 on the Theodore> feature-removal-schedule, so this patch is preparation for the final Theodore> removal of this flag. Theodore> Signed-off-by: "Theodore Ts'o" Theodore> Cc: Peter K

Re: ARC no console output (was Re: [PATCH 1/2] init/console: Use ttynull as a fallback when there is no console)

2021-01-13 Thread Peter Korsgaard
gt; is defined on the command line. > What happens in my case is console_on_rootfs() doesn't find > /dev/console and switching to ttynull. /dev is not present because > devtmpfs doesn't automount for initramfs. But our initramfs/cpio logic ensures that the initramfs has a static /dev/console device node, so how can that be? https://git.buildroot.net/buildroot/tree/fs/cpio/cpio.mk#n25 -- Bye, Peter Korsgaard

Re: [PATCH 1/5] hwrng: atmel - Use devm_clk_get()

2014-02-27 Thread Peter Korsgaard
>>>>> "Jingoo" == Jingoo Han writes: > Use devm_clk_get() to make cleanup paths simpler. > Signed-off-by: Jingoo Han Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH 1/2] hwrng: atmel - Use devm_ioremap_resource()

2014-02-11 Thread Peter Korsgaard
>>>>> "Jingoo" == Jingoo Han writes: > Use devm_ioremap_resource() in order to make the code simpler, > and remove redundant return value check of platform_get_resource() > because the value is checked by devm_ioremap_resource(). > Signed-off-by: J

Re: [PATCH] Make the mtdblock read/write skip the bad nand sector

2013-11-25 Thread Peter Korsgaard
ashfs/cramfs/readonly ext2/.. on a NOR flash? -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

2013-10-11 Thread Peter Korsgaard
ta.n_gpios; i++) IN> - gpio_set_value(mux->gpio_base + mux->data.gpios[i], IN> - val & (1 << i)); IN> + gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i], IN> + val & (1 << i

Re: [PATCH 2/6] hwrng: atmel: use clk_prepapre_enable/_disable_unprepare

2014-09-30 Thread Peter Korsgaard
>>>>> "Boris" == Boris Brezillon writes: > Use clk_prepapre_enable/_disable_unprepare instead of clk_enable/disable > to work properly with the CCF. s/prepapre/prepare/ Other than that, looks fine to me. Acked-by: Peter Korsgaard > Signed-off-by: Boris

Re: [PATCH 3/6] hwrng: atmel: add DT support

2014-09-30 Thread Peter Korsgaard
>>>>> "Boris" == Boris Brezillon writes: > Add DT support. > Make the driver depend on CONFIG_OF as at91sam9g45 was the only SoC making > use of the TRNG block and this SoC is now fully migrated to DT. > Signed-off-by: Boris Brezillon Acked-by: Peter

Re: [PATCH 4/6] hwrng: atmel: Add TRNG DT binding doc

2014-09-30 Thread Peter Korsgaard
h of the register set of this block > +- interrupts : the interrupt number for the TRNG block The interrupt isn't strictly speaking required as it isn't used by the driver, but as 9G45 has the signal wired up I guess it makes sense. Acked-by: Peter Korsgaard -- Bye, Peter Korsg

Re: [PATCH 4/6] hwrng: atmel: Add TRNG DT binding doc

2014-09-30 Thread Peter Korsgaard
der to wait for data as > requested by hwrng code when the wait argument is true). > Thus I prefer to keep it as required. Ok, fine by me. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [PATCH 09/16] i2c: i2c-ocores: Drop class based scanning to improve bootup time

2014-07-10 Thread Peter Korsgaard
eak after some time. > Signed-off-by: Wolfram Sang Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] tty: serial: uartlite: Specify time for sending chars

2014-05-05 Thread Peter Korsgaard
= 0; i < 10; i++) { It would be good to add a note about the slow jtag variant here. Otherwise: Acked-by: Peter Korsgaard > +timeout = jiffies + msecs_to_jiffies(1000); > +while (1) { > val = uart_in32(ULITE_STATUS, port); >

  1   2   >