>>>>> "Anatolij" == Anatolij Gustschin <ag...@denx.de> writes:
Hi, Anatolij> Thomas renamed the old set_irq_type() call to Anatolij> irq_set_irq_type(), but this line setting the IRQ_TYPE_NONE Anatolij> type was there before renaming. It was added by commit Anatolij> 345e5c8a. At this time set_irq_type() checked its type Anatolij> argument and returned 0 if the type argument didn't specify Anatolij> some meaningful type in its type sense bits (and thus was Anatolij> equal to IRQ_TYPE_NONE). Effectively this line was a nop and Anatolij> I wonder what was the point of adding it. Sorry, don't recall. It's been quite a while, and I've haven't worked on anything mpc8xxx for a few years by now. Most likely one of the other gpio drivers did it like this back then. I don't remember the details, but your description makes sense so if nobody disagrees you can have my: Acked-by: Peter Korsgaard <jac...@sunsite.dk> -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
