Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads

2013-02-09 Thread Pavel Machek
Hi! > > The only way to *reliably* freeze fuse filesystems is to let it freeze > > even if there are outstanding requests. But that's the hardest to > > implement, because then it needs to allow freezing of tasks waiting on > > i_mutex, for example, which is currently not possible. But this is >

Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-10 Thread Pavel Machek
Hi! > > > For shutdown in userspace there is the sendsigs.omit.d/ to avoid the > > > problem of halting/killing processes of the fuse filesystems (or other > > > services) prematurely. I guess something similar needs to be done for > > > freeze. The fuse filesystem has to tell the kernel what is u

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-10 Thread Pavel Machek
Hi! > > > > The whole memory shrinking we do for hibernation is now done by > > > > allocating > > > > memory, so the freezer is not necessary for *that* and there's *zero* > > > > difference between suspend and hibernation with respect to why the > > > > freezer is > > > > used. > > > > > > Fu

Re: PAE problems was [RFC] Reproducible OOM with just a few sleeps

2013-02-10 Thread Pavel Machek
On Wed 2013-02-06 16:28:08, Dave Hansen wrote: > On 02/01/2013 02:25 AM, Pavel Machek wrote: > > Ouch, and... IIRC (hpa should know for sure), PAE is neccessary for > > R^X support on x86, thus getting more common, not less. If it does not > > work, that's bad news. >

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-11 Thread Pavel Machek
Hi! > > > > > > The whole memory shrinking we do for hibernation is now done by > > > > > > allocating > > > > > > memory, so the freezer is not necessary for *that* and there's > > > > > > *zero* > > > > > > difference between suspend and hibernation with respect to why the > > > > > > freezer

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-12 Thread Pavel Machek
Hi! > > That's potentially deeadlock-prone, because a task waiting for mutex X may > > very well be holding mutex Y, so if there's another task waiting for mutex > > Y, > > it needs to be frozen at the same time. > > > >> The only little detail is how do we implement that... > > > > This means th

Re: Freescale FEC: fall back to random address

2013-04-02 Thread Pavel Machek
Hi! > I think it is okay. Ok, now... is there someone maintianing Freescale FEC? Or, Dave, can you merge the patch? Thanks, Pavel > 2013/4/1 Pavel Machek : > > If there's no valid ethernet address, fall back to r

Re: UIO device tree bindings.

2013-04-02 Thread Pavel Machek
On Mon 2013-04-01 19:42:12, Guenter Roeck wrote: > On Mon, Apr 01, 2013 at 05:40:08PM +0200, Pavel Machek wrote: > > On Mon 2013-04-01 16:23:36, Pavel Machek wrote: > > > Hi! > > > > > > I'd like to get uio device tree bindings to work -- with recent FPGA

Re: UIO device tree bindings.

2013-04-02 Thread Pavel Machek
re's updated patch, if you can please test this one. [You can just pass "uio_of_genirq.of_id=generic-uio" to get previous behaviour. But don't tell anyone :-)] Signed-off-by: Pavel Machek Pavel diff --git

Re: UIO device tree bindings.

2013-04-02 Thread Pavel Machek
behaviour. But don't tell anyone :-)] Actually, looking at it some more, perhaps even solution is possible? (This will need uio_pdrv_genirq.of_id=generic-uio .) Unfortunately, I don't have easy way to test this :-(. So feedback is essential. Signed-off-by: Pavel Machek diff --git

Re: UIO device tree bindings.

2013-04-02 Thread Pavel Machek
I tested that much: it works ok. And... yes, this should work for you. You'll simply put compatible="generic-uio" into the dts. (Ok, ugly part is that this is probably not acceptable for upstream.) Then you'll use this patch, with uio_pdrv_genirq.of_id=generic-uio commandline. It

Re: Announcement: STEC EnhanceIO SSD caching software for Linux kernel

2013-01-30 Thread Pavel Machek
Hi! > EnhanceIO driver is based on EnhanceIO SSD caching software product developed > by STEC Inc. EnhanceIO was derived from Facebook's open source Flashcache > project. EnhanceIO uses SSDs as cache devices for traditional rotating hard > disk drives (referred to as source volumes throughout t

Re: [RFC] Reproducible OOM with just a few sleeps

2013-01-30 Thread Pavel Machek
Hi! > > I understand that more RAM leaves less lowmem. What is unacceptable is > > that PAE crashes or freezes with OOM: it should gracefully handle the > > issue. Noting that (for a machine with 4GB or under) PAE fails where the > > HIGHMEM4G kernel succeeds and survives. > > You have found a de

Re: Bug#695182: [RFC] Reproducible OOM with just a few sleeps

2013-02-01 Thread Pavel Machek
On Thu 2013-01-31 23:38:27, Phil Turmel wrote: > On 01/31/2013 10:13 PM, paul.sz...@sydney.edu.au wrote: > > [trim /] Does not that prove that PAE is broken? > > Please, Paul, take *yes* for an answer. It is broken. You've received > multiple dissertations on why it is going to stay that way. U

PAE problems was [RFC] Reproducible OOM with just a few sleeps

2013-02-01 Thread Pavel Machek
On Fri 2013-02-01 11:20:44, Pavel Machek wrote: > On Thu 2013-01-31 23:38:27, Phil Turmel wrote: > > On 01/31/2013 10:13 PM, paul.sz...@sydney.edu.au wrote: > > > [trim /] Does not that prove that PAE is broken? > > > > Please, Paul, take *yes* for an answer.

Re: [PATCH 8/9] Thermal: Add ABI Documentation for sysfs interfaces

2013-02-19 Thread Pavel Machek
On Mon 2013-01-07 12:43:25, Durgadoss R wrote: > This patch adds Documentation for ABI's introduced > for thermal subsystem (under /sys/class/thermal/). So... we have deciCelsius and deciKelvin in ACPI (IIRC) and miliCelsius here. Perhaps using deciCelsius to be consistent with ACPI would be nice

Re: [PATCH] vt: add init_hide parameter to suppress boot output

2013-02-19 Thread Pavel Machek
Hi! > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -165,6 +165,9 @@ module_param(global_cursor_default, int, S_IRUGO | > S_IWUSR); > static int cur_default = CUR_DEFAULT; > module_param(cur_default, int, S_IRUGO | S_IWUSR); > > +static int init_hide; > +module_param(init_hide, i

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-19 Thread Pavel Machek
Hi! > > > > > Well, I suppose that information is available to user space. > > > > > > > > > > Do we need an interface for a process to mark itself as > > > > > PF_FREEZE_LATE or > > > > > do we need an interface for one process to mark another process as > > > > > PF_FREEZE_LATE, or both? > > >

Re: [PATCH v2] vt: add init_hide parameter to suppress boot output

2013-02-20 Thread Pavel Machek
Hi! > > How could there be any other users at startup, you "own" the system > > here, there should not be anyone to race with. > > Tell that to the display hardware. :) > > Seriously, every Linux box with a display (to first approximation, > obviously I didn't test them all while writing this me

Re: [PATCH v2] vt: add init_hide parameter to suppress boot output

2013-02-20 Thread Pavel Machek
On Wed 2013-02-20 14:08:25, Andy Ross wrote: > On 02/20/2013 12:57 PM, Pavel Machek wrote: > >I'm sure something creative can be done with fake init that shuts > >the console up then execs previous init. No need to add more kernel > >knobs, I'd say. >

Re: [PATCH] freezer: configure user space process frozen along with kernel threads

2013-02-20 Thread Pavel Machek
On Wed 2013-02-20 05:51:49, Eric W. Biederman wrote: > Li Fei writes: > > > There is well known issue that freezing will fail in case that fuse > > daemon is frozen firstly with some requests not handled, as the fuse > > usage task is waiting for the response from fuse daemon and can't be > > fro

Re: [PATCH] freezer: configure user space process frozen along with kernel threads

2013-02-20 Thread Pavel Machek
On Wed 2013-02-20 13:36:19, Eric W. Biederman wrote: > Alan Stern writes: > > > On Wed, 20 Feb 2013, Eric W. Biederman wrote: > > > >> >> Why can't the fuse filesystem freeze when there are requests pending? > >> > > >> > It _can_ freeze (that is, the fuse daemon can). The problem is that > >> >

Re: sleepy linux self-test

2008-01-30 Thread Pavel Machek
Hi! > > This version should work, at least it did not fail in my testing. It > > does one test 5 second after bootup, then periodically once per 500 > > seconds. Different parameters are trivial to tweak. > > the x86.git qa mix produced this spontaneous reboot failure: Is it reproducible, or i

Re: [PATCH] ipwireless: driver for 3G PC Card

2008-01-30 Thread Pavel Machek
On Thu 2008-01-31 10:29:30, Stephen Blackheath [to Foxconn] wrote: > Pavel & all, > > > Pavel Machek wrote: > > >> +/* I/O ports and bit definitions for version 2 of the hardware */ > >> + > >> +struct MEMCCR { > >> + unsigned

Re: hibernate/suspend-to-disk: to turn power or not?

2008-01-31 Thread Pavel Machek
Hi! > o 2.6.24 kernel fails to suspend properly. It "saves pages", >prints "Suspending console", when prints "Sl" and nothing >more happens. At this time, I can manually poweroff the >machine, and resume works. The same happens when running >32bits or 64bits kernel (it's an amd

Re: swsusp on an AMD x2-64, 2.6.24: regression?

2008-01-31 Thread Pavel Machek
On Fri 2008-02-01 00:41:06, Michael Tokarev wrote: > Since I upgraded from 2.6.23 to 2.6.24, suspend to > disk does not work anymore on this machine. I'm > trying to debug this now, for several hours already, > without much luck so far. > > The machine is based on AMD X2-64 (BE-2400) CPU and > NV

how to tell i386 from x86-64 kernel

2008-01-31 Thread Pavel Machek
Hi! Quiz: on a booted system, how do you tell 32bit from 64bit kernel? A1: zcat /proc/config.gz | grep CONFIG_64 ...but config.gz is optional A2: cat /proc/meminfo | grep High ...but i386 kernel could have highmem disabled What is _your_ answer? ;-)>

kill misleading comments in trampoline_*.S

2008-01-31 Thread Pavel Machek
Both trampolines actually *do* set up stack. (Is the "we jump into compressed/head.S" comment still true?) Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S index 9bcc1c6..5398547 100644 --- a

Re: how to tell i386 from x86-64 kernel

2008-01-31 Thread Pavel Machek
On Thu 2008-01-31 16:46:57, Ray Lee wrote: > On Jan 31, 2008 4:42 PM, Pavel Machek <[EMAIL PROTECTED]> wrote: > > Quiz: on a booted system, how do you tell 32bit from 64bit kernel? > > Uhm, is this a trick question? What's wrong with uname(2)? No, it is a tricky questio

Re: kill misleading comments in trampoline_*.S

2008-01-31 Thread Pavel Machek
On Thu 2008-01-31 17:02:29, Yinghai Lu wrote: > On Jan 31, 2008 4:54 PM, Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > > > Both trampolines actually *do* set up stack. (Is the "we jump into > > compressed/head.S" comment still true?) > >

Re: swsusp on an AMD x2-64, 2.6.24: regression?

2008-02-01 Thread Pavel Machek
On Fri 2008-02-01 13:16:08, Michael Tokarev wrote: > Pavel Machek wrote: > > On Fri 2008-02-01 00:41:06, Michael Tokarev wrote: > [] > >> With 2.6.24, it tries to suspend, saves pages to disk, > >> when prints this: > >> > >> ..Saving pages..

Re: [PATCH] ipwireless: driver for 3G PC Card

2008-02-01 Thread Pavel Machek
Hi! > > > +static irqreturn_t ipwireless_handle_v1_interrupt(int irq, > > > + struct ipw_hardware *hw) > > > +{ > > > + unsigned short irqn; > > > + unsigned short ack; > > > + > > > + irqn = inw(hw->base_port + IOIR); > > > + > > > + /* Check if card is p

Re: x86/.../trampoline_64.S racy?

2008-02-01 Thread Pavel Machek
On Fri 2008-02-01 23:07:16, Pavel Machek wrote: > Hi! > > I'm trying to reuse trampoline_64.S for wakeup from ACPI s3... but I'm > getting some badness: If I insert delay loops into trampoline_64.S, > machine fails to boot; but I already increased cpu bootup delay to 20

x86/.../trampoline_64.S racy?

2008-02-01 Thread Pavel Machek
Hi! I'm trying to reuse trampoline_64.S for wakeup from ACPI s3... but I'm getting some badness: If I insert delay loops into trampoline_64.S, machine fails to boot; but I already increased cpu bootup delay to 200 seconds... Is it possible that bootup is subtly racy somewhere? diff --git a/arch/

Re: how to tell i386 from x86-64 kernel

2008-02-02 Thread Pavel Machek
On Fri 2008-02-01 11:47:29, Rik Bobbaers wrote: > hi there, > > since i'm not on the list... how about: > > tail /proc/1/smaps and check the address size... > on 32 bit: e000-f000 r-xp 00:00 0 [vdso] > > on 64 bit: ff60-ff601000 r-xp 00:00 0

Re: [PATCH] Allow NBD to be used locally

2008-02-02 Thread Pavel Machek
On Fri 2008-02-01 14:25:32, Laurent Vivier wrote: > This patch allows Network Block Device to be mounted locally. What is local nbd good for? Use loop instead... > It creates a kthread to avoid the deadlock described in NBD tools > documentation. > So, if nbd-client hangs waiting pages, the kblo

Re: sleepy linux self-test

2008-02-02 Thread Pavel Machek
G_PM_SLEEP) += process.o console.o sleepy.o obj-$(CONFIG_HIBERNATION) += swsusp.o disk.o snapshot.o swap.o user.o obj-$(CONFIG_MAGIC_SYSRQ) += poweroff.o diff --git a/kernel/power/sleepy.c b/kernel/power/sleepy.c new file mode 100644 index 000..222d22d --- /dev/null ++

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Pavel Machek
Hi! > > --- a/drivers/rtc/rtc-cmos.c > > +++ b/drivers/rtc/rtc-cmos.c > > @@ -78,7 +78,7 @@ static inline int is_intr(u8 rtc_intr) > > > > /**/ > > > > -static int cmos_read_time(struct device *dev, struct rtc_time *t) > > +int c

Re: [RFC] ext3 freeze feature

2008-02-02 Thread Pavel Machek
On Fri 2008-01-25 11:42:29, Theodore Tso wrote: > On Fri, Jan 25, 2008 at 10:34:25AM -0600, Eric Sandeen wrote: > > > But it was this concern which is why ext3 never exported freeze > > > functionality to userspace, even though other commercial filesystems > > > do support this. It wasn't that it

Re: [PATCH] Introduce softpanic

2008-02-02 Thread Pavel Machek
On Fri 2008-01-25 16:01:28, Andi Kleen wrote: > Bodo Eggert <[EMAIL PROTECTED]> writes: > > > Enabling this option changes a hard panic on boot errors to a > > soft panic, which does not stop the system completely. > > You can still scroll the screen and read the messages. > > I don't think it's

Re: [PATCH 2.6.24-rc8-mm1 00/15] IPC: code rewrite + new functionalities

2008-02-02 Thread Pavel Machek
Hi! > * Patches 9 to 15 propose to add some functionalities, and thus are > submitted here for RFC, about both the interest and their implementation. > These functionalities are: > - Two new control-commands: > . IPC_SETID: to change an IPC's id. > . IPC_SETALL: behaves as IPC_SET,

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Pavel Machek
On Sat 2008-02-02 11:13:21, David Brownell wrote: > On Saturday 02 February 2008, Ingo Molnar wrote: > > > > > > Yep, you are right, but that is the easy issue to fix. > > > > > > Which is why I was puzzled that you didn't start out doing it the > > > "right" way ... even just hard-wiring the dub

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Pavel Machek
On Sat 2008-02-02 20:38:43, Ingo Molnar wrote: > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > It would have been easier to just use the public interface and > > > hard-wire "rtc0". But going directly to the hardware was dirtier, > >

Re: [PATCH] Allow NBD to be used locally

2008-02-02 Thread Pavel Machek
Hi! > > > This patch allows Network Block Device to be mounted locally. ... > Correct. The patch improves the NBD behavior even if it is not perfect. > And I think if no other page can be freed your system is in very bad > move ;-) So the description should be "This patch lowers probability of

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
recent version (I have slightly cleaner one, but it got obscured by 2.6.24-git merge), I eventually got it to work on 64-bit, by reusing trampoline.S code. Pavel Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/ar

Re: [PATCH 0/4] x86 PM: Consolidate suspend and hibernation code

2008-02-03 Thread Pavel Machek
On Sun 2008-02-03 21:41:56, Rafael J. Wysocki wrote: > Hi, > > This series of patches consolidates the x86 suspend and hibernation code. > It does the following: > - move 64-bit hibernation/suspend files to arch/x86/power (under different > names) > - rename 32-bit files in arch/x86/power in lin

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
On Sun 2008-02-03 19:49:31, Sam Ravnborg wrote: > On Sun, Feb 03, 2008 at 07:16:48PM +0100, Pavel Machek wrote: > > Hi! > > > > > > This version works on 32-bit, and builds on 64-bit (but I'm pretty > > > > sure it does not wo

Re: [linux-pm] sleepy linux self-test

2008-02-03 Thread Pavel Machek
Hi! > > The changes look good to me. > > They feel unfinished to me though. :) > > Like using "jiffies" instead of a clocksource, which makes trouble > since the timing covers periods with IRQs disabled. And the test > mode parameter needs work. Well, I'd say that timing has bigger problem, r

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
On Mon 2008-02-04 00:20:14, Rafael J. Wysocki wrote: > On Sunday, 3 of February 2008, Rafael J. Wysocki wrote: > > On Sunday, 3 of February 2008, Pavel Machek wrote: > > > Hi! > > > > > > > > This version works on 32-bit, and builds on 64-bit (but I&#x

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
Hi! > Below is the arch/x86/kernel/acpi/sleep.c part without the warnings > (untested). > > It still contains some hardcoded magic numbers and extern declarations, so > I guess the #include list is not complete or another header is necessary. > > BTW: > 1) why exactly is acpi_wakeup_address not

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
Hi! > - Could the real mode directory be called just "real-mode" or something like > this ("rm" is not very meaningful :-))? > > Apart from the above and the _WAKEUP hacks mentioned elsewhere, it looks okay > (from a very high orbit). Wakeup hacks? You mean those #ifdef WAKEUP in video code?

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
> it looks okay > (from a very high orbit). It should look better from closer look. Reusing trampoline_64.S instead of cut©&paste gets us rid of some really nasty assembly ;-). Pavel -- (english) http://www.livejournal.com/~p

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
Hi! > BTW, I don't like the way in which the 'struct wakeup_header' fields are > reproduced in rm/wakeup.S very much, because it makes the code fragile. > It might be better to define the offsets in asm-offsets*.c and refer to them > relative to wakeup_header (if possible). If you can do that.. y

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
ng64; + saved_magic = 0x123456789abcdef0; +#endif /* CONFIG_64BIT */ return 0; } @@ -56,15 +111,20 @@ void acpi_restore_state_mem(void) */ void __init acpi_reserve_bootmem(void) { - if ((&wakeup_end - &wakeup_start) > PAGE_SIZE*2) { + if ((&wakeup_code_e

Re: wakeup code translated to .c

2008-02-03 Thread Pavel Machek
On Mon 2008-02-04 00:59:38, Rafael J. Wysocki wrote: > On Monday, 4 of February 2008, Pavel Machek wrote: > > Hi! > > > > > BTW, I don't like the way in which the 'struct wakeup_header' fields are > > > reproduced in rm/wakeup.S very much, beca

Re: wakeup code translated to .c

2008-02-04 Thread Pavel Machek
On Sun 2008-02-03 23:27:20, Sam Ravnborg wrote: > On Sun, Feb 03, 2008 at 11:24:07PM +0100, Pavel Machek wrote: > > On Sun 2008-02-03 19:49:31, Sam Ravnborg wrote: > > > On Sun, Feb 03, 2008 at 07:16:48PM +0100, Pavel Machek wrote: > > > > Hi! > > > > >

Re: brk randomization breaks columns

2008-02-04 Thread Pavel Machek
Hi! > > Hmm, code in binfmt_elf is really strange. > > > > elf_bss += load_bias; > > elf_brk += load_bias; > > start_code += load_bias; > > end_code += load_bias; > > start_data += load_bias; > > end_data += load_bias; > > > > /* Calling se

Re: [PATCH 23/37] Suspend: Clean up Kconfig (V2)

2008-02-04 Thread Pavel Machek
accordingly. > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> > Acked-by: Russell King <[EMAIL PROTECTED]> > Acked-by: Paul Mackerras <[EMAIL PROTECTED]> > Acked-by: Ralf Baechle <[EMAIL PROTECTED]> > Acked-by: Paul Mundt <[EMAIL PROTEC

brk randomization breaks columns

2008-02-04 Thread Pavel Machek
Hi! Columns is very popular game of year about 1993, and brk randomization breaks it. (Along with my boot, but who cares about boot when game is broken?) echo 1 > /proc/sys/kernel/randomize_va_space breaks columns echo 0 > /proc/sys/kernel/randomize_va_space fixes them. [EMAIL PROTECTED]:~# l

Re: Fwd: brk randomization breaks columns

2008-02-04 Thread Pavel Machek
> > > > > I still don't seem to fully understand what is happening here -- > > > aparently this is triggerable only with old programs linked against > > > libc.so.5, and I am not able to trigger it with my trivial program when > > > I link it against old libc.so.5, which just basically does brk() a

Re: [PATCH] per-process securebits

2008-02-04 Thread Pavel Machek
On Fri 2008-02-01 20:07:01, James Morris wrote: > On Fri, 1 Feb 2008, Andrew Morton wrote: > > > Really? I'd feel a lot more comfortable if yesterday's version 1 had led > > to a stream of comments from suitably-knowledgeable kernel developers which > > indicated that those developers had scrutin

Re: [PATCH 2.6.24-rc8-mm1 00/15] IPC: code rewrite + new functionalities

2008-02-04 Thread Pavel Machek
Hi! >>> As the namespaces and the "containers" are being integrated in the >>> kernel, these functionalities may be a first step to implement the >>> checkpoint/restart of an application: in fact the existing API does not >>> allow >>> to specify or to change an ID when creating an IPC, when

Re: brk randomization breaks columns

2008-02-04 Thread Pavel Machek
Hi! > > Not sure this helps... If I only randomize _end_ of heap, it still > > works. If I try to randomize beggining of heap, too, it will not even > > start recent binaries :-(. > > I don't uderstand this, sorry. Ehen the mapping for the new process is > being established during loading of t

small cleanups

2008-02-04 Thread Pavel Machek
These are small cleanups all over the tree. Please apply, Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/fs/select.c b/fs/select.c index 47f4792..c414aed 100644 --- a/fs/select.c +++ b/fs/select.c @@ -260,7 +260,7 @@ int do_select(int n, fd_set_bits *fds, s

Re: brk randomization breaks columns

2008-02-04 Thread Pavel Machek
On Mon 2008-02-04 17:12:43, Jiri Kosina wrote: > On Mon, 4 Feb 2008, Jiri Kosina wrote: > > > I still don't seem to fully understand what is happening here -- > > aparently this is triggerable only with old programs linked against > > libc.so.5, and I am not able to trigger it with my trivial pr

Timer cleanups

2008-02-04 Thread Pavel Machek
Add anotations, so that timertop produces nicer results. Relative expiry time can get negative, so it should be signed. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 429d084..235fd6c 100644 --- a/arch/x86/kernel/hpet.c

Small pm documentation cleanups

2008-02-04 Thread Pavel Machek
Small documentation fixes/additions that accumulated in my tree. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index cf38689..3be3328 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documen

Re: Fwd: brk randomization breaks columns

2008-02-04 Thread Pavel Machek
Hi! > > Abel, I actually don't think you have chance to have any issues with > > randomization, as the mentioned post talks about 2.6.22.10, which doesn't > > randomize the brk start at all. > > You are rigth, my kernel just randomizes stack top. > > I've got a bit sick with this crash in the la

CodingStyle: provide good example

2008-02-04 Thread Pavel Machek
if (!buffer) is actually prefered style, so lets use it in example. Pavel Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 6caa146..9bb2d8a 100644

[regression] Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
[some more CCs added] > > Feb 4 12:29:32 amd kernel: columns-bin[4535]: segfault at 8052000 ip > > b7f08a9a sp bfb79628 error 6 in > > libc.so.5.4.33[b7e99000+87000] > > Just before death, > > [EMAIL PROTECTED]:~# cat /proc/4537/maps > > 08048000-0805 r-xp 08:04 246209 /usr/local/

Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
Hi! > Still, it will probably not fix your particular program crashes, just > because it will always assume that brk starts immediately after the end of > the bss, which is plain wrong and has never been assured. Could you please > check whether there is any compat-* package available for you

Re: [regression] Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
On Tue 2008-02-05 13:50:51, Jiri Kosina wrote: > On Tue, 5 Feb 2008, Pavel Machek wrote: > > > > Actually, this clearly shows that either prehistoric libc.so.5 or the > > > program itself are broken. > > I believe it shows clear regression in latest 2.6.25 kernel.

Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
On Tue 2008-02-05 16:49:04, Jiri Kosina wrote: > On Tue, 5 Feb 2008, Pavel Machek wrote: > > > uemacs ... broken with randomization > > colums, sss ... local programs, broken with randomization > > procinfo ... broken, randomization makes it die sooner. > > mikmod

Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
On Tue 2008-02-05 16:49:53, Ingo Molnar wrote: > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > Hi! > > > > > > In my usual dither, I'm rather hoping Arjan will have a clear answer. > > > > > > > > > setarch works. If

Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
Hi! > > In my usual dither, I'm rather hoping Arjan will have a clear answer. > > > setarch works. If the apps come in source form they need fixing anyway (since > I'd not be > surprised of current gcc reorders variables), if not.. we only have 2 cases, > the other case was the build process of

Re: [regression] Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
On Tue 2008-02-05 08:05:46, Jakub Jelinek wrote: > On Tue, Feb 05, 2008 at 01:54:26PM +0100, Ingo Molnar wrote: > > * Jiri Kosina <[EMAIL PROTECTED]> wrote: > > > > > On Tue, 5 Feb 2008, Pavel Machek wrote: > > > > > > > > Actually, this

Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
On Tue 2008-02-05 08:58:41, Arjan van de Ven wrote: > On Tue, 5 Feb 2008 16:46:48 +0100 > Pavel Machek <[EMAIL PROTECTED]> wrote: > > > Hi! > > > > > > In my usual dither, I'm rather hoping Arjan will have a clear > > > > answer. > >

Re: brk randomization breaks columns

2008-02-05 Thread Pavel Machek
Hi! > diff --git a/mm/mmap.c b/mm/mmap.c > index 8295577..1c3b48f 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -241,7 +241,7 @@ asmlinkage unsigned long sys_brk(unsigned long brk) > > down_write(&mm->mmap_sem); > > - if (brk < mm->end_code) > + if (brk < mm->start_brk) >

Re: [linux-pm] Re: Small pm documentation cleanups

2008-02-05 Thread Pavel Machek
Hi! >> On Tuesday, 5 of February 2008, Pavel Machek wrote: >>> Small documentation fixes/additions that accumulated in my tree. >>> >>> Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> >> >> Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]

[rft] s2ram wakeup moves to .c, could fix few machines

2008-02-05 Thread Pavel Machek
This rewrites wakeup code to .c, and it fixes stack (should use movl ,%esp, not movw). Testers wanted. Makefile infrastructure was done by hpa, cleanups by rjw. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 8978e98..949b8eb 100644

Re: [PATCH] ACPI suspend: Execute _WAK with the right argument

2008-02-12 Thread Pavel Machek
On Wed 2008-02-13 00:32:16, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > The _WAK global ACPI control method has to be called with the > argument representing the sleep state being exited. Make it happen. > > Special thanks to Mirco Tischler <[EMAIL PROTECTED]> for

Re: [patch] move wakeup code to .c

2008-02-15 Thread Pavel Machek
Hi! > scripts/checkpatch.pl > ERROR: do not initialise externals to 0 or NULL > #113: FILE: arch/x86/boot/video-mode.c:29: > +int do_restore = 0;/* Screen contents changed during mode flip */ We were doing file move with minimal changes. > ERROR: need a space before the open parenthesis '('

Re: [2.6.25-rc1] jerky mouse cursor and randoooom key repeats

2008-02-15 Thread Pavel Machek
Hi! > > In general 2.6.25 if looking quite good on my desktop, but there's one > > important issue: the system no longer powers off after shutdown. > > This works fine with 2.6.24. > > I was wrong :-( > > I'd not really done any real wor under 2.6.25 yet, but now while running > a kernel co

Re: [PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-10-31 Thread Pavel Machek
Hi! > Linux kernel doesn't like decimals, say so. ?! Linux surely supports decimal constants, like "100". Did you mean "octal"? If you wanted to add warning for something... I never want to see #define CRAPPY_EMBEDDED_REGISTER ((0x1) << (0)) again

Re: [PATCH] add some drop_caches documentation and info messsge

2012-10-31 Thread Pavel Machek
On Mon 2012-10-29 10:58:19, Borislav Petkov wrote: > On Mon, Oct 29, 2012 at 09:59:59AM +0100, Jiri Kosina wrote: > > You might or might not want to do that. Dropping caches around suspend > > makes the hibernation process itself faster, but the realtime response > > of the applications afterwards

Re: 'git describe' is very slow on development trees with lots of commits

2012-10-31 Thread Pavel Machek
Hi! > (Cc:-ed the Git development list.) > > * David Ahern wrote: > > > PERF-VERSION-GEN and specifically the git commands are the > > cause of more delay than the config checks, especially when > > doing the build in a VM with the kernel source on an NFS > > mount. > > Yes, I have noticed

Re: [PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-11-01 Thread Pavel Machek
Hi! > > > Linux kernel doesn't like decimals, say so. > > > > ?! > > > > Linux surely supports decimal constants, like "100". Did you mean > > "octal"? > > > > If you wanted to add warning for something... I never want to see > > > > #define CRAPPY_EMBEDDED_REGISTER ((0x1) << (0)) > > > > aga

Re: [PATCH] add some drop_caches documentation and info messsge

2012-11-01 Thread Pavel Machek
Hi! > > > hmpf. This patch worries me. If there are people out there who are > > > regularly using drop_caches because the VM sucks, it seems pretty > > > obnoxious of us to go dumping stuff into their syslog. What are they > > > supposed to do? Stop using drop_caches? > > > > People use drop

Re: [RFC] Second attempt at kernel secure boot support

2012-11-01 Thread Pavel Machek
Hi! > > But that doesn't really help me: untrusted root is an oxymoron. > > Imagine you run windows and you've never heard of Linux. You like > that only windows kernels can boot on your box and not those mean > nasty hacked up malware kernels. Now some attacker manages to take > over your box

Re: [RFC] Second attempt at kernel secure boot support

2012-11-02 Thread Pavel Machek
On Thu 2012-11-01 15:02:25, Chris Friesen wrote: > On 11/01/2012 02:27 PM, Pavel Machek wrote: > > >Could someone write down exact requirements for Linux kernel to be signed by > >Microsoft? > >Because thats apparently what you want, and I don't think crippling

Re: [RFC] Second attempt at kernel secure boot support

2012-11-04 Thread Pavel Machek
On Sun 2012-11-04 04:28:02, Matthew Garrett wrote: > On Sat, Nov 03, 2012 at 10:56:40PM +, James Bottomley wrote: > > On Sat, 2012-11-03 at 13:46 +, Matthew Garrett wrote: > > > I... what? Our signed bootloader will boot our signed kernel without any > > > physically present end-user invol

Re: [sqlite] light weight write barriers

2012-11-05 Thread Pavel Machek
On Thu 2012-10-25 14:29:48, Theodore Ts'o wrote: > On Thu, Oct 25, 2012 at 11:03:13AM -0700, da...@lang.hm wrote: > > I agree, this is why I'm trying to figure out the recommended way to > > do this without needing to do full commits. > > > > Since in most cases it's acceptable to loose the last f

Re: Tracking down suspend/resume ext3/mmc issues on imx233

2012-09-22 Thread Pavel Machek
Hi! On Wed 2012-09-19 20:01:10, Theodore Ts'o wrote: > On Thu, Sep 20, 2012 at 01:23:49AM +0200, Pavel Machek wrote: > > > > I'm not sure I agree. > > > > If you treat root fs as removable, you'll get "crash". You'll need to > > re

Re: Initial report on F2FS filesystem performance

2012-10-30 Thread Pavel Machek
Hi! > >> * buffered write (1GB file), 4KByte write > > > > Ok, f2fs is bit faster on desktop PC and a bit slower on S3. Good. > > > > > >> * write + fsync (100MB file), 4KByte write > > > > Ok, random access on VFAT is a lot faster on S3 (and only very > > a bit on PC). Any idea why results ar

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

2013-08-25 Thread Pavel Machek
Hi! > Use the name_to_dev_t call to parse the device name echo'd to > to /sys/power/resume. This imitates the method used in hibernate.c > in software_resume, and allows the resume partition to be specified > using other equivalent device formats as well. By allowing > /sys/debug/resume to accep

Re: [PATCH 02/18] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-08-25 Thread Pavel Machek
On Thu 2013-08-22 19:01:41, Lee, Chun-Yi wrote: > Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the > first step of signature generation operation > (RSASSA-PKCS1-v1_5-SIGN). Is this your own code, or did you copy it from somewhere? > + if (!T) > + goto error_T

Re: [PATCH 03/18] asymmetric keys: separate the length checking of octet string from RSA_I2OSP

2013-08-25 Thread Pavel Machek
On Thu 2013-08-22 19:01:42, Lee, Chun-Yi wrote: > Due to RSA_I2OSP is not only used by signature verification path but also used > in signature generation path. So, separate the length checking of octet string > because it's not for generate 0x00 0x01 leading string when used in signature > generat

Re: [PATCH 06/18] asymmetric keys: support parsing PKCS #8 private key information

2013-08-25 Thread Pavel Machek
On Thu 2013-08-22 19:01:45, Lee, Chun-Yi wrote: > Add ASN.1 files and parser to support parsing PKCS #8 noncompressed private > key information. It's better than direct parsing pure private key because > PKCS #8 has a privateKeyAlgorithm to indicate the algorithm of private > key, e.g. RSA from PKC

Re: [PATCH 07/18] asymmetric keys: explicitly add the leading zero byte to encoded message

2013-08-25 Thread Pavel Machek
On Thu 2013-08-22 19:01:46, Lee, Chun-Yi wrote: > Per PKCS1 spec, the EMSA-PKCS1-v1_5 encoded message is leading by 0x00 0x01 in > its first 2 bytes. The leading zero byte is suppressed by MPI so we pass a > pointer to the _preceding_ byte to RSA_verify() in original code, but it has > risk for the

Re: [PATCH 08/18] Secure boot: Add new capability

2013-08-25 Thread Pavel Machek
On Thu 2013-08-22 19:01:47, Lee, Chun-Yi wrote: > From: Matthew Garrett > > Secure boot adds certain policy requirements, including that root must not > be able to do anything that could cause the kernel to execute arbitrary code. > The simplest way to handle this would seem to be to add a new ca

  1   2   3   4   5   6   7   8   9   10   >