Here's is the trace of a nautilus process in D state.
I'm rebooting now in 2.4.3-ac2 to see if it still happens.
Pau
trace.bz2
ou still have to unload the card and reload it again to get back
the network working. I'm using hotplug.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-i
1
soundcore 3952 2 [maestro]
uhci 18672 0 (unused)
usbcore52304 2 [uhci]
Thanks for your help
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Error 1
make[2]: Leaving directory `/usr/src/linux/drivers/md'
make[1]: *** [_modsubdir_md] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_mod_drivers] Error 2
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messa
p;& ifconfig eth0 -promisc
Any hints?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
I want to plug a linux box as a router for the ADSL line I've got at home.
My provider uses IP over ATM (not pppoe). I'd like to buy a suitable and
cheap ATM/ADSL card, up to 2Mb (no need for 155 Mbps speeds :) and an
advice about the kernel to use. Any hints?
Thx for your help
I've compiled and installed test10-pre4 in my laptop and I have had to
reboot 4 times in less than a day.
sysrq key is working so I attach some traces.
If something more is needed just tell me.
Pau
Oct 19 11:02:45 pau kernel: kernel BUG at vmscan.c:102!
Oct 19 11:02:45 pau kernel: in
On Thu, 19 Oct 2000, Pau wrote:
> I've compiled and installed test10-pre4 in my laptop and I have had to
> reboot 4 times in less than a day.
>
> sysrq key is working so I attach some traces.
Sorry to follow up my self but... definately it happens when it starts
swapping.
On 14 Dec 2000, Linus Torvalds wrote:
> if we figure out why apparently some people have trouble with external
> modules (at least one person has trouble with loading alsa modules).
I cannot load the xircom_tulip_cb module using the latest modutils 2.3.22.
I think it's a modutils pr
May I ask which PDA do you have running Linux and worth a few bucks?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Have a nice and happy new year's eve everybody.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
what do you see after the system 'hangs' and
> you type sysrq-T, sysrq-M and/or sysrq-P ?
I wrote a message yesterday with the same problem. test8 works ok but
test9-pre? hang when quickly keying while expunging a mailbox.
Only sysrq-o (power down) responds. No oops.
Pau
-
To unsub
I've been running 2.4.3-pre4 for a few days now and today I've got this
message in the logs a couple of times. Is it harmless?
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More maj
you have
> CONFIG_SERIAL enabled, along with hotplugging support etc.
In fact it does. I discovered it last weekend when my modem -them same one
than Alessandro's- stopped working.
Removing "alias char-major-4 serial_cb" from modules.conf did the trick
and the serial driver worked
Tx hang basically with NFS, but also when moving high
amount of Mb in the LAN.
I've moved from pcmcia-cs to hotplug and it works too :)
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info a
On Mon, Nov 19, 2012 at 9:08 PM, Sasha Levin wrote:
> The code that works with routing_algo assumes that the string passed is non
> empty, this assumption is wrong:
Why isn't this patch part of Linux 3.7? It seems to be a bugfix and it
was sent early enough?
--
To unsubscribe from this list: send
On Mon, Dec 24, 2012 at 3:38 PM, Marek Lindner wrote:
> On Monday, December 24, 2012 22:18:52 Pau Koning wrote:
>> On Mon, Nov 19, 2012 at 9:08 PM, Sasha Levin wrote:
>> > The code that works with routing_algo assumes that the string passed is
>> > non
>>
>
/bin/galeon-bin
This didn't happen neither with 2.4.2 nor with 2.4.3-pre7; I'm not sure
about pre8.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majord
I use:
alias eth0 xircom_tulip_cb
and when this happens -90% if times when I boot and 100% of time when I
awake after a sleep- I just do the following:
ifconfig eth0 -promisc
and it works again.
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
depmod: *** Unresolved symbols in
/lib/modules/2.4.0-prerelease/kernel/drivers/net/irda/toshoboe.o
depmod: __bad_udelay
depmod: *** Unresolved symbols in
/lib/modules/2.4.0-prerelease/kernel/drivers/video/atyfb.o
depmod: __bad_udelay
Pau
-
To unsubscribe from this list: send
I've tried 2.4.2-ac26 to test the new xircom_cb driver but I have had to
reboot on 2.4.3-pre7 as some processes got stuck on D state.
The processes were large apps: once nautilus and once mozilla.
I couldn't get any other information.
Pau
-
To unsubscribe from this list: sen
register_netdev
/lib/modules/2.4.3-pre8/kernel/drivers/net/pcmcia/xircom_tulip_cb.o:
insmod
/lib/modules/2.4.3-pre8/kernel/drivers/net/pcmcia/xircom_tulip_cb.o
failed
/lib/modules/2.4.3-pre8/kernel/drivers/net/pcmcia/xircom_tulip_cb.o:
insmod xircom_tulip_cb failed
Pau
-
To unsubscribe from this
are statically linked.
I've been sent this patch by Eran Mann that adds net_init.o to the
exported objects in the net Makefile.
Still untested ;)
Pau
--- linux/kernel/nous_kernels/linux/drivers/net/Makefile.oldWed Mar 28 16:21:20
2001
+++ linux/kernel/nous_kernels/linux/drivers/net/Ma
uld this be the reason for the reported slowdown in the last six months?
--
Pau
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
2.6 detailed in this thread:
http://kerneltrap.org/node/4940
I don't want at all to justify it with the change you talk about in gas,
but maybe it is worth to check if it has anything to do with it. The
slowdown happened in this last six months.
--
Pau
-
To unsubscribe from this list: send t
This series contains the cleanups and fixes found in my previous
indirect descriptors series, that are aimed for linux 3.9.
Available in the git repository at:
git://xenbits.xen.org/people/royger/linux.git blk-for-3.9
Roger Pau Monne (5):
xen-blkback: don't store dev_bus_addr
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page, there's no need to store it in the persistent grant
entry, since we can always get it provided that we have the page.
This reduces the memory overhead of persistent grants in blkback.
Signed-off-by: Roge
We may use foreach_grant_safe in the future with empty lists, so make
sure we can handle them.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkback/blkback.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
We already have the frame (pfn of the grant page) stored inside struct
grant, so there's no need to keep an aditional list of mapped frames
for a specific request. This reduces memory usage in blkfront.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xe
prevents us from having to call
alloc_page, thus preventing possible failures.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
Changes since RFC:
* Move page buffer initialization to setup_blkring
---
drivers/block/xen-blkfront.c | 120
sed previously is safe to use
concurrently without additional locking).
Should be backported to 3.8 stable.
Signed-off-by: Roger Pau Monné
[Part of the description]
Signed-off-by: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-
On 05/03/13 22:49, Konrad Rzeszutek Wilk wrote:
>>> This could be written a bit differently to also run outside the
>>> xen_blkif_schedule
>>> (so a new thread). This would require using the lock mechanism and
>>> converting
>>> this big loop to two smaller loops:
>>> 1) - one quick that holds t
On 28/02/13 11:28, Roger Pau Monne wrote:
> Indirect descriptors introduce a new block operation
> (BLKIF_OP_INDIRECT) that passes grant references instead of segments
> in the request. This grant references are filled with arrays of
> blkif_request_segment_aligned, this way we c
On 19/03/13 13:51, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 18, 2013 at 05:49:34PM +0100, Roger Pau Monne wrote:
>> Replace the use of llist with list.
>>
>> llist_for_each_entry_safe can trigger a bug in GCC 4.1, so it's best
>> to remove it and use a d
On 19/03/13 16:10, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
>>>>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk
>>>>> wrote:
>>> On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
>&
_safe
macro remove it from llist.h.
Signed-off-by: Roger Pau Monné
Reported-by: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkfront.c |5 ++---
include/linux/llist.h| 25 -
2 files changed, 2 inser
On 25/01/13 18:32, Konrad Rzeszutek Wilk wrote:
> We want to be able to exit if the difference between the request
> produced (what the frontend tells us) and the requests consumed
> (what we have so far processed) is greater than the ring size.
>
> If so, we should terminate the loop as the reque
On 25/02/13 17:49, Konrad Rzeszutek Wilk wrote:
> On Fri, Feb 15, 2013 at 08:12:52PM +0100, Roger Pau Monné wrote:
>> On 15/02/13 19:56, Konrad Rzeszutek Wilk wrote:
>>>> Should be backported to 3.8 stable.
>>>
>>> Lets do one thing at a time.
>>>
On 27/02/13 05:52, Chen Gang wrote:
>
> if call xen_vbd_translate failed, the preq.dev will be not initialized.
> so use blkif->vbd.pdevice instead (still better to print relative info).
preq.dev is initialized a a couple of lines prior to calling
xen_vbd_translate:
preq.dev = req-
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page, there's no need to store it in the persistent grant
entry, since we can always get it provided that we have the page.
This reduces the memory overhead of persistent grants in blkback.
Signed-off-by: Roge
Moving grant ref handles from blkbk to pending_req will allow us to
get rid of the shared blkbk structure.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 16
1 files changed, 4 insertions(+), 12
the ring and
in the queue and split the bios in them if they are bigger than the
new maximum number of segments.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 129 +++---
drivers/block/xen-blkback/common.h
grants without needing
to pass a pending_req.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 134 ++-
1 files changed, 85 insertions(+), 49 deletions(-)
diff --git a/drivers/block/xen
Remove the last dependency from blkbk by moving the list of free
requests to blkif. This change reduces the contention on the list of
available requests.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 123
meter (max_buffer_pages) has been added in order to tune
the maximum number of free pages each blkback instance will keep in
it's buffer.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkback/blkbac
of persistent grants to remove when executing
the LRU.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 207 +++
drivers/block/xen-blkback/common.h |4 +
drivers/block/xen
This series contains the initial implementation of indirect
descriptors for Linux blkback/blkfront.
Patches 1, 2, 3, 4 and 5 are bug fixes and minor optimizations.
Patch 6 contains a LRU implementation for blkback that will be needed
when using indirect descriptors (since we are no longer able
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkback/blkback.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkback/blkback.c
b/drivers/block/xen-blkback/blkback.c
index c14b736
prevents us from having to call
alloc_page, thus preventing possible failures.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkfront.c | 120 +++--
1 files changed, 79 insertions(+), 41 deletions
We already have the frame (pfn of the grant page) stored inside struct
grant, so there's no need to keep an aditional list of mapped frames
for a specific request. This reduces memory usage in blkfront.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xe
sed previously is safe to use
concurrently without additional locking).
Should be backported to 3.8 stable.
Signed-off-by: Roger Pau Monné
[Part of the description]
Signed-off-by: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-
We may use foreach_grant_safe in the future with empty lists, so make
sure we can handle them.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkback/blkback.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
On 28/02/13 11:49, Jan Beulich wrote:
>>>> On 28.02.13 at 11:28, Roger Pau Monne wrote:
>> This series contains the initial implementation of indirect
>> descriptors for Linux blkback/blkfront.
>>
>> Patches 1, 2, 3, 4 and 5 are bug fixes and minor optimiz
On 28/02/13 12:35, Jan Beulich wrote:
>>>> On 28.02.13 at 12:25, Roger Pau Monné wrote:
>> This is the expanded graph that also contains indirect descriptors
>> without persistent grants:
>>
>> http://xenbits.xen.org/people/royger/plot_indirect_nopers.png
>
On 28/02/13 12:19, Jan Beulich wrote:
>>>> On 28.02.13 at 11:28, Roger Pau Monne wrote:
>> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t;
>> */
>> #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11
>>
>> +#define BLKIF_MAX_IN
On 22/10/12 15:47, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 18, 2012 at 01:22:01PM +0200, Roger Pau Monne wrote:
>> This patch implements persistent grants for the xen-blk{front,back}
>> mechanism. The effect of this change is to reduce the number of unmap
>> operations
On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote:
diff --git a/drivers/block/xen-blkback/blkback.c
b/drivers/block/xen-blkback/blkback.c
index c6decb9..2b982b2 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -78,6 +78,7 @@ s
On 23/10/12 20:50, Konrad Rzeszutek Wilk wrote:
> On Tue, Oct 23, 2012 at 08:09:27PM +0200, Roger Pau Monné wrote:
>> On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote:
>>>>>> diff --git a/drivers/block/xen-blkback/blkback.c
>>>>>> b/drivers/block/xen-bl
On 24/10/12 14:40, liuxiaolei1124 wrote:
> Dear Roger:
>
> i have put the patch "Persistent grant maps for xen blk drivers"
> (https://lkml.org/lkml/2012/10/18/191) into my Dom0 which is 2.6.32.36.
> And when i start a vm, sometimes the blkback go to the BUG_ON.
I'm working on top of the ne
ional cost to the guest of using persistent grants. There is
perhaps a small saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick
Signed-off-by: Roger Pau Monne
Cc:
Cc:
---
Changes since v1:
* Changed the unmap_seg arr
sure we don't try to
access segments that have not been set.
Signed-off-by: Roger Pau Monne
Cc:
Cc:
---
drivers/block/xen-blkback/blkback.c | 15 +--
drivers/block/xen-blkback/xenbus.c |2 +-
drivers/block/xen-blkfront.c|3 ++-
3 files changed, 12 insertions(+), 8
On 02/11/12 18:05, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 02, 2012 at 04:43:04PM +0100, Roger Pau Monne wrote:
>> This patch contains fixes for persistent grants implementation v2:
>>
>> * handle == 0 is a valid handle, so initialize grants in blkback
>&g
On 01/08/13 16:18, Roger Pau Monné wrote:
> On 01/08/13 14:30, David Vrabel wrote:
>> On 01/08/13 13:08, Roger Pau Monne wrote:
>>> Right now the maximum number of grant operations that can be batched
>>> in a single request is BLKIF_MAX_SEGMENTS_PER_REQUEST (11). This
On 04/08/13 16:56, Stefano Stabellini wrote:
> On Thu, 1 Aug 2013, Roger Pau Monne wrote:
>> The new GNTTABOP_unmap_and_duplicate operation doesn't zero the
>> mapping passed in new_addr, allowing us to perform batch unmaps in p2m
>> code without requiring the use of a m
The new GNTTABOP_unmap_and_duplicate operation doesn't zero the
mapping passed in new_addr, allowing us to perform batch unmaps in p2m
code without requiring the use of a multicall.
Signed-off-by: Roger Pau Monné
Cc: Stefano Stabellini
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
---
Ch
array of grant_ref_t once the indirect pages
are mapped. This prevents us from introducing a new request struct,
since we re-use the same struct from the indirect operation.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkback/blkback.c | 108
ere callback == callback->next.
Replace this check with a proper one that iterates over the list to
see if the callback has already been added.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
---
drivers/xen/grant-table.c | 13 +++--
1 files changed, 11 insertions(+), 2 del
Improve the calculation of required grants to process a request by
using nr_phys_segments instead of always assuming a request is going
to use all posible segments.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkfront.c | 11 +++
1 files changed, 7
The following patches prevent blkfront from hoarding all grants in the
system by allowing blkfront to request blkback to unmap certain grants
so they can be freed by blkfront. This is done periodically by
blkfront, unmapping a certain amount of unused persistent grants.
This series also include
Prevent blkfront from hoarding all grants by adding a minimum number
of grants that must be free at all times. We still need a way to free
unused grants in blkfront, but this patch will mitigate the problem
in the meantime.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
---
drivers
On 08/07/13 21:41, Konrad Rzeszutek Wilk wrote:
> On Mon, Jul 08, 2013 at 03:03:27PM +0200, Roger Pau Monne wrote:
>> Right now blkfront has no way to unmap grant refs, if using persistent
>> grants once a grant is used blkfront cannot assure if blkback will
>> have this gr
On 08/07/13 21:41, Konrad Rzeszutek Wilk wrote:
> On Mon, Jul 08, 2013 at 03:03:27PM +0200, Roger Pau Monne wrote:
>> Right now blkfront has no way to unmap grant refs, if using persistent
>> grants once a grant is used blkfront cannot assure if blkback will
>> have this gr
On 10/07/13 15:54, Egger, Christoph wrote:
> On 10.07.13 11:19, Roger Pau Monné wrote:
>> On 08/07/13 21:41, Konrad Rzeszutek Wilk wrote:
>>> On Mon, Jul 08, 2013 at 03:03:27PM +0200, Roger Pau Monne wrote:
>>>> Right now blkfront has no way to unmap grant refs, i
On 11/07/13 15:20, David Vrabel wrote:
> On 08/07/13 14:03, Roger Pau Monne wrote:
>> Improve the calculation of required grants to process a request by
>> using nr_phys_segments instead of always assuming a request is going
>> to use all posible segments.
>
> This is
On 11/07/13 15:32, David Vrabel wrote:
> On 08/07/13 14:03, Roger Pau Monne wrote:
>> Prevent blkfront from hoarding all grants by adding a minimum number
>> of grants that must be free at all times. We still need a way to free
>> unused grants in blkfront, but this patch will
On 11/07/13 15:48, David Vrabel wrote:
> On 10/07/13 10:19, Roger Pau Monné wrote:
>>
>> >From 1ede72ba10a7ec13d57ba6d2af54e86a099d7125 Mon Sep 17 00:00:00 2001
>> From: Roger Pau Monne
>> Date: Wed, 10 Jul 2013 10:22:19 +0200
>> Subject: [PATCH RFC] xen-blkfro
On 11/07/13 17:26, David Vrabel wrote:
> On 11/07/13 16:12, Roger Pau Monné wrote:
>> On 11/07/13 15:48, David Vrabel wrote:
>>> On 10/07/13 10:19, Roger Pau Monné wrote:
>>>>
>>>> >From 1ede72ba10a7ec13d57ba6d2af54e86a099d7125 Mon Sep 17 00:00:00 20
On 11/07/13 15:17, David Vrabel wrote:
> On 08/07/13 14:03, Roger Pau Monne wrote:
>> With the current implementation, the callback in the tail of the list
>> can be added twice, because the check done in
>> gnttab_request_free_callback is bogus, callback->next can be N
On 24/09/12 13:36, Jan Beulich wrote:
On 21.09.12 at 17:52, Oliver Chick wrote:
>> Changes since v1:
>>
>> * Maximum number of persistent grants per device now 64, rather than
>>256, as this is the actual maxmimum request in a (1 page) ring.
>
> As said previously, I don't see why this
Change foreach_grant iterator to a safe version, that allows freeing
the element while iterating. Also move the free code in
free_persistent_gnts to prevent freeing the element before the rb_next
call.
Reported-by: Dan Carpenter
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen
Implement a safe version of llist_for_each_entry, and use it in
blkif_free. Previously grants where freed while iterating the list,
which lead to dereferences when trying to fetch the next item.
Reported-by: Dan Carpenter
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de
here is
perhaps a small saving, from the reduced number of hypercalls
performed in granting, and ending foreign access.
Signed-off-by: Oliver Chick
Signed-off-by: Roger Pau Monne
Cc:
Cc:
---
Benchmarks showing the impact of this patch in blk performance can be
found at:
http://xenbits.xens
On 19/10/12 03:34, James Harper wrote:
>>
>> This patch implements persistent grants for the xen-blk{front,back}
>> mechanism. The effect of this change is to reduce the number of unmap
>> operations performed, since they cause a (costly) TLB shootdown. This allows
>> the I/O performance to scale b
Signed-off-by: Roger Pau Monné
Cc: linux-kernel@vger.kernel.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkfront.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index df21b05..860f76d 100644
On 07/12/12 21:20, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 04, 2012 at 03:21:53PM +0100, Roger Pau Monne wrote:
>> Implement a safe version of llist_for_each_entry, and use it in
>> blkif_free. Previously grants where freed while iterating the list,
>> which lead to derefe
On 10/12/12 16:15, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 10, 2012 at 01:15:50PM +0100, Roger Pau Monné wrote:
>> On 07/12/12 21:20, Konrad Rzeszutek Wilk wrote:
>>> On Tue, Dec 04, 2012 at 03:21:53PM +0100, Roger Pau Monne wrote:
>>>> Implement a safe version of
Signed-off-by: Roger Pau Monné
Cc: Huang Ying
Cc: Konrad Rzeszutek Wilk
---
include/linux/llist.h | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/include/linux/llist.h b/include/linux/llist.h
index a5199f6..f611cd8 100644
--- a/include/linux
Change foreach_grant iterator to a safe version, that allows freeing
the element while iterating. Also move the free code in
free_persistent_gnts to prevent freeing the element before the rb_next
call.
Reported-by: Dan Carpenter
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen
Use llist_for_each_entry_safe in blkif_free. Previously grants where
freed while iterating the list, which lead to dereferences when trying
to fetch the next item.
Reported-by: Dan Carpenter
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block
Signed-off-by: Roger Pau Monné
Cc: Huang Ying
Cc: Konrad Rzeszutek Wilk
---
Changes since v2:
* Allow to pass a NULL node as the first entry of deleted list
entries.
---
include/linux/llist.h | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git
On 12/12/12 01:37, Huang Ying wrote:
> On Tue, 2012-12-11 at 12:25 +0100, Roger Pau Monne wrote:
>> Signed-off-by: Roger Pau Monné
>> Cc: Huang Ying
>> Cc: Konrad Rzeszutek Wilk
>> ---
>> Changes since v2:
>> * Allow to pass a NULL node as the fi
Free the page allocated for the persistent grant.
Signed-off-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index f1de806..96e9b00 100644
--- a/drivers
Move the code that frees persistent grants from the red-black tree
to a function. This will make it easier for other consumers to move
this to a common place.
Signed-off-by: Roger Pau Monné
---
drivers/block/xen-blkback/blkback.c | 68 +++
1 files changed, 37
On 17/04/13 16:25, Konrad Rzeszutek Wilk wrote:
>>> Perhaps the xen-blkfront part of the patch should be just split out to make
>>> this easier?
>>>
>>> Perhaps what we really should have is just the 'max' value of megabytes
>>> we want to handle on the ring.
>>>
>>> As right now 32 ring requests *
Moving grant ref handles from blkbk to pending_req will allow us to
get rid of the shared blkbk structure.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 16
1 files changed, 4 insertions(+), 12
Implementation of indirect descriptors v2, addressing Konrad's
comments. A graph on performance can be found at:
http://xenbits.xen.org/people/royger/plot_indirect_read4k.png
Thanks for the review, Roger.
Roger Pau Monne (7):
xen-blkback: print stats about persistent grants
meter (max_buffer_pages) has been added in order to tune
the maximum number of free pages each blkback instance will keep in
it's buffer.
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
Changes since RFC:
* Fix typos in commit message.
* Minor fix
Signed-off-by: Roger Pau Monné
Cc: xen-de...@lists.xen.org
Cc: Konrad Rzeszutek Wilk
---
drivers/block/xen-blkback/blkback.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkback/blkback.c
b/drivers/block/xen-blkback/blkback.c
index dd5b2fe
the ring and
in the queue and split the bios in them if they are bigger than the
new maximum number of segments.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
Changes since v1:
* Added padding to make the indirect request 64bit aligned.
* Added some
grants without needing
to pass a pending_req.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xen.org
---
drivers/block/xen-blkback/blkback.c | 141 +--
1 files changed, 86 insertions(+), 55 deletions(-)
diff --git a/drivers/block/xen
1 - 100 of 553 matches
Mail list logo
