On 24/09/12 13:36, Jan Beulich wrote: >>>> On 21.09.12 at 17:52, Oliver Chick <oliver.ch...@citrix.com> wrote: >> Changes since v1: >> >> * Maximum number of persistent grants per device now 64, rather than >> 256, as this is the actual maxmimum request in a (1 page) ring. > > As said previously, I don't see why this needs to have a separate > #define at all - it's simply __RING_SIZE(). No adding this would > also imply that - apart from perhaps documenting the new xenstore > nodes - io/blkif.h would need changing at all (which otherwise would > require a hypervisor side patch to be submitted too).
I've been working on this a little bit more, and __RING_SIZE returns 32 for all ring types (blkif, blkif_x86_32 and blkif_x86_64), any specific reason to choose __RING_SIZE()*2? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
