Re: [PATCH 0/6] add generic round_up_pow2() macro

2005-04-08 Thread P
Andrew Morton wrote: Nick Wilson <[EMAIL PROTECTED]> wrote: The first patch adds a generic round_up_pow2() macro to kernel.h. The remaining patches modify a few files to make use of the new macro. We already have ALIGN() and roundup_pow_of_two(). cool. It doesn't handle x={0,1} though. Maybe we sh

Re: [PATCH 0/6] add generic round_up_pow2() macro

2005-04-08 Thread P
[EMAIL PROTECTED] wrote: Andrew Morton wrote: Nick Wilson <[EMAIL PROTECTED]> wrote: The first patch adds a generic round_up_pow2() macro to kernel.h. The remaining patches modify a few files to make use of the new macro. We already have ALIGN() and roundup_pow_of_two(). cool. It doesn't handle x

Re: RT 45-01: CF Card read: High latency?

2005-04-11 Thread P
I handled this issue by precaching all my files (15MB), from my readonly root filesystem. find / -type f | grep -v ^/boot | #kernel is > 1MB and never read so don't put in cache while read file; do dd bs=32k if="$file" of=/dev/null 2>/dev/null done Pádraig. - To unsubscribe from this list: send

Re: How do you accurately determine a process' RAM usage?

2005-07-12 Thread P
Andrew Morton wrote: OK, please let us know how it goes. It went very well. I could find no problems at all. I've updated my script to use the new method, so please merge smaps :) http://www.pixelbeat.org/scripts/ps_mem.py Usually the shared mem reported by /proc/$$/statm is the same as summin

Re: How do you accurately determine a process' RAM usage?

2005-07-20 Thread P
gt;anon_rss yes But in smaps output you can have anonymous area like: b6e0e000-b6e13000 rw-p Size:20 KB Rss: 4 KB Shared_Clean: 0 KB Shared_Dirty: 4 KB Private_Clean:0 KB Private_Dirty:0 KB Look that it presents 4 KB of shared value i

Re: How do you accurately determine a process' RAM usage?

2005-07-20 Thread P
Mauricio Lin wrote: Hi Brady, On 7/20/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: The following shell gets the shared values for the first httpd process: FIRST_HTTPD=`ps -C httpd -o pid= | head -1 | tr -d ' '` HTTPD_STATM_SHARED=$(expr 4 '*' `cut -f3 -d' ' /proc/$FIRST_HTTPD/statm`) HTTP

Re: [OT] util-linux 2.13-pre1

2005-08-09 Thread P
Adrian Bunk wrote: util-linux 2.13-pre1 is available at ftp://ftp.kernel.org/pub/linux/utils/util-linux/testing/util-linux-2.13-pre1.tar.gz You missed my fixes to cal to fix a possible crash bug for certain terminal types, and to fix date alignment issues for certain dates. I've rediffed the

How do you accurately determine a process' RAM usage?

2005-07-06 Thread P
I wrote a tool to report how much RAM a particular program (apache for e.g.) was using: http://www.pixelbeat.org/scripts/ps_mem.py I was then pointed at the following: http://wiki.apache.org/spamassassin/TopSharedMemoryBug which describes how copy-on-write pages are not counted as shared since 2.

How do you accurately determine a process RAM usage

2005-07-06 Thread P
I wrote a tool to (try to) report how much RAM a particular program (apache for e.g.) was using: http://www.pixelbeat.org/scripts/ps_mem.py I was then pointed at the following: http://wiki.apache.org/spamassassin/TopSharedMemoryBug which describes how copy-on-write pages are not counted as shared

Re: How do you accurately determine a process' RAM usage?

2005-07-07 Thread P
Andrew Morton wrote: Calculating this stuff accurately is very expensive. You'll get a better answer using proc-pid-smaps.patch from -mm, but even that won't tell you things about sharing levels of the pages. Great, thanks! I'll play around with this: http://kernel.org/pub/linux/kernel/people/

Re: [WATCHDOG] support of motherboards with ICH6]

2005-02-07 Thread P
Pasi Kärkkäinen wrote: On Mon, Feb 07, 2005 at 10:00:03AM +0100, P.O. Gaillard wrote: Hi, I am replying to myself so that people googling for similar problems can find the answer. Supermicro says that the internal driver of the southbridge (and also the W83627HF chip) are not useable because the

Re: [RFT] Preliminary w83627ehf hardware monitoring driver

2005-02-28 Thread P
Jean Delvare wrote: I am not familiar with watchdogs. I'd invite you to get in touch with the author and/or maintainer of the w83627hf_wdt driver, or possibly try to debug it yourself. Datasheets are freely available from Winbond for both the W83627HF and W83627THF: http://www.winbond.com/e-winbo

Re: x86 TSC time warp puzzle

2005-04-04 Thread P
Jonathan Lundell wrote: Well, not actually a time warp, though it feels like one. I'm doing some real-time bit-twiddling in a driver, using the TSC to measure out delays on the order of hundreds of nanoseconds. Because I want an upper limit on the delay, I disable interrupts around it. The logic

Re: Loopback mounting from a file with a partition table?

2005-01-24 Thread P
Dan Stromberg wrote: Has anyone tried loopback mounting individual partitions from within a file that contains a partition table? When I mount -o loop the file, I seem to get the first partition in the file, but I don't see anything in the man page for mount that indicates a way of getting any othe

[PATCH] To add NULL pointer check

2013-04-02 Thread P J P
Hello, Commit - fa9150a84c - replaces a call to generic_writepages() in f2fs_write_data_pages() with write_cache_pages(), with a function pointer argument pointing to routine: __f2fs_writepage. -> https://git.kernel.org/linus/fa9150a84ca333f68127097c4fa1eda4b3913a22 The patch below adds

Re: [PATCH] To add NULL pointer check

2013-04-02 Thread P J P
Hello Jaegeuk, +-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | Therefore, I think f2fs_write_data_pages() is better to handle this. Please | review the modified patch. Thanks, | | diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c | index 47a2d7c..cf9ff5f 100644 | --- a/fs/f2fs/data.c | +++ b/fs/f2fs

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread P J P
+-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c | index 47a2d7c..cf9ff5f 100644 | --- a/fs/f2fs/data.c | +++ b/fs/f2fs/data.c | @@ -559,6 +559,10 @@ static int f2fs_write_data_pages(struct | address_space *mapping, | int ret; | long excess_nr

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread P J P
+-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | I'm confusing the question because f2fs doesn't use generic_writepages(), | since f2fs_write_data_pages() is linked to a_ops->writepages. In | do_writepages(), always f2fs_write_data_pages() is triggered instead of | generic_writepages(). Isn't it?

Re: [PATCH] To add NULL pointer check

2013-04-03 Thread P J P
+-- On Thu, 4 Apr 2013, Jaegeuk Kim wrote --+ | Why should we take unnecessary locks and an f2fs_submit_bio call? Yep, we should not. I wasn't sure if these are unnecessary when a_ops->writepage = NULL. Thank you. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C9

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-10-25 Thread P J P
Hello Kees, +-- On Wed, 24 Oct 2012, Kees Cook wrote --+ | What should the code here _actually_ be doing? The _script and _misc | handlers expect to rewrite the bprm contents and recurse, but the module | loader want to try again. It's not clear to me what the binfmt module | handler is even

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-10-25 Thread P J P
Hello Tetsuo, +-- On Thu, 25 Oct 2012, Tetsuo Handa wrote --+ | Excuse me, but why do you change definition of printable(c) ? | Looks like a regression. #define printable(c) (((c)=='\t') || ((c)=='\n') || (0x20<=(c) && (c)<=0x7e)) Earlier definition of printable() as above was used to - bre

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-10-26 Thread P J P
+-- On Thu, 25 Oct 2012, Al Viro wrote --+ | * every bleeding script will have bogus execution of modprobe done | at execve time (and you'd better pray that /sbin/modprobe isn't a shell | script wrapper around the actual binary, or you *will* get loop prevention | kick in) | * none of t

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-10-27 Thread P J P
+-- On Fri, 26 Oct 2012, Al Viro wrote --+ | > not. Module alias could dodge this though, I guess. | "Could"? Can you show a single module that would have name matching | binfmt-[0-9a-f]*? In other words, are they ever loaded _not_ via an | alias? I understand. I was wondering if alias informa

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-10-27 Thread P J P
+-- On Sat, 27 Oct 2012, Kees Cook wrote --+ | Al showed a list of them earlier in the thread. Yeah, the list Al showed and I came across mostly has - binfmt_aout - entry. Do people still use - a.out - format? (considering ELF has been the default standard for so many years) | I don't have an

Re: [PATCH 1/2] Fix NULL pointer dereference while loading initramfs

2013-10-05 Thread P J P
Hello Andrew, Just to check, did you have chance to review an updated patch? -- Prasad J Pandit / Red Hat Security Response Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-10-05 Thread P J P
Hello Andrew, Just to check, did you have a chance to review it further? Are you waiting on me for something? -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 1/2] Fix NULL pointer dereference while loading initramfs

2013-10-06 Thread P J P
Hi, +-- On Sat, 5 Oct 2013, Andrew Morton wrote --+ | On Sun, 6 Oct 2013 02:12:15 +0530 (IST) P J P wrote: | Not yet, but it's in the queue. I see; Thank you for an update. I appreciate it. Please let me know if there are changes to be done. Or if you think I could send similar pa

[PATCH 1/2] Fix NULL pointer dereference while loading initramfs

2013-09-15 Thread P J P
nic("VFS: Unable to mount root fs on %s", b); Could someone please review this patch? Thank you. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602BFrom 4ff1ddae358dff002080d753e45721a89d07b3af Mon Sep 17 00:00:00 2001 From: P J P Date

[PATCH 2/2] Export initial ramdisk compression config

2013-09-15 Thread P J P
on Sep 17 00:00:00 2001 From: P J P Date: Sun, 15 Sep 2013 13:37:43 +0530 Subject: [PATCH 2/2] Export initial ramdisk compression config option Make menuconfig allows one to choose compression format of an initial ramdisk image. But this choice does not result in duly compressed ramdisk image

Need patch review

2013-09-20 Thread P J P
Hello, NULL pointer dereference while loading initramfs -> https://lkml.org/lkml/2013/9/15/20 Export initial ramdisk compression config option -> https://lkml.org/lkml/2013/9/15/22 Could someone have a look at these patches please? Thank you. -- Prasad J Pandit / Red Hat Security Respon

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-10-10 Thread P J P
Hello Andrew, +-- On Wed, 9 Oct 2013, Andrew Morton wrote --+ | It would be better to make the change in one place, rather than for each | architecture. That would appear to involve moving a hunk from | arch/x86/Makefile into init/Makefile, or perhaps ./Makefile. Right, I was trying to fi

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-10-10 Thread P J P
updated patch which adds the export snippet to the top level ./Makefile. I tried init/Makefile too, but it does not seem to work. Thank you! -- Prasad J Pandit / Red Hat Security Response TeamFrom 2bb603f666371289ee660be5cf7a6f87740edd8e Mon Sep 17 00:00:00 2001 From: P J P Date: Thu, 10 Oct 2013 19

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-10-10 Thread P J P
version, I missed to include init/do_mounts_rd.c changes in the previous one. Thank you. -- Prasad J Pandit / Red Hat Security Response TeamFrom 14dccee98f12f2dbca224510bcfedd1a397ed177 Mon Sep 17 00:00:00 2001 From: P J P Date: Thu, 10 Oct 2013 20:37:48 +0530 Subject: Export initial ramdisk

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-09-26 Thread P J P
+-- On Wed, 25 Sep 2013, Rob Landley wrote --+ | Ah, so it's an out of tree bespoke Red Hat tool. No wonder I couldn't find it. It is not Red Hat tool. | You're reimplemented the posix "pax" command? Ummn, not sure. Didn't see anything about 'pax'. | Is this what you're currently doing, or

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-09-30 Thread P J P
Hello Andrew, I was wondering if you had a chance to review this patch further? Should I send similar patches for other architectures too? As in you aren't waiting on me for that, are you? Thank you. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860

Re: [PATCH 1/2] Fix NULL pointer dereference while loading initramfs

2013-09-30 Thread P J P
Hello Andrew, I was wondering if you had a chance to review the updated patch that I sent. You aren't waiting on me for something, are you? Thank you. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B -- To unsubscribe from this list: send t

Re: [PATCH 1/2] Fix NULL pointer dereference while loading initramfs

2013-09-24 Thread P J P
Hello Andrew, Thank you so much for reviewing these patches. +-- On Mon, 23 Sep 2013, Andrew Morton wrote --+ | A few things here. | - the coding style is very unconventional. We'd do it like this: | if (!deco) { | pr_emerg("Invalid decompression routine add

Re: [PATCH 1/2] Fix NULL pointer dereference while loading initramfs

2013-09-24 Thread P J P
Hello Rob, +-- On Mon, 23 Sep 2013, Rob Landley wrote --+ | I've been building kernels, including with initramfs, and I don't have | dracut(8) installed? In today's git: dracut(8) is a separate tool installed from package dracut. -> dracut-029-2.fc19.x86_64 -> https://dracut.wiki.kernel.or

Re: [PATCH 2/2] Export initial ramdisk compression config

2013-09-24 Thread P J P
Hello Andrew, Thank you so much for reviewing these patches. +-- On Mon, 23 Sep 2013, Andrew Morton wrote --+ | It's a bit confusing whether all this appiles to initrd, to initramfs | or to both. Can you please clarify all this and be sure that it's all | consistent? IIUC, we no longer use

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-06 Thread P J P
Hello Kees, Al, +-- On Sat, 27 Oct 2012, Kees Cook wrote --+ | If we change binfmt_script to not make a recursive call, then we still | need to keep the interp change somewhere off the stack. I still think | my patchset is the least bad. | | Al, do you have something else in mind? Guys, are

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-16 Thread P J P
Hello folks, +-- On Mon, 12 Nov 2012, Kees Cook wrote --+ | > Al, what's your take on the *rare* extra call to request_module? | | Without any other feedback, I'd like to use my minimal allocation | patch, since it fixes the problem and doesn't change any of the | semantics of how/when loadi

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-18 Thread P J P
+-- On Fri, 16 Nov 2012, Kees Cook wrote --+ | Hrm? It should be showing only the live heap-allocated interp -- are | you seeing uninitialized contents? I don't see uninitialised content; I see interpreter names from previous iterations. Which was the case earlier as well. The - interp - array i

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-18 Thread P J P
+-- On Sun, 18 Nov 2012, Kees Cook wrote --+ | This is the second problem. I view this as less critical because it's only | 64 instead of 4, but it certainly should be solved as well. I don't mean to be rude, but the patch I had sent solves both of these problems with much less performance hit

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-19 Thread P J P
+-- On Mon, 19 Nov 2012, Kees Cook wrote --+ | I don't think you're being rude at all. You're defending your solution. :) Thank you Kees, really appreciate it. | However, it also changes the conditions for when a module is loaded | (i.e. 0x7f no longer triggers a module_load, so anything needi

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-19 Thread P J P
+-- On Mon, 19 Nov 2012, Linus Torvalds wrote --+ | isn't your patch the one that does a request_module even without trying | without it? There was a discussion about why that isn't valid. Don't do it. Yep, okay. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939

Re: [patch] cciss: info leak in cciss_ioctl32_passthru()

2013-06-04 Thread P J P
Hello Dan, === diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 6374dc1..34971aa 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -1201,6 +1201,7 @@ static int cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode, int err; u32 cp; +

Re: [patch] cciss: info leak in cciss_ioctl32_passthru()

2013-06-04 Thread P J P
| No no. Vasily patched cciss_ioctl32_big_passthru() and this patch | changes cciss_ioctl32_passthru(). Oops, yeah, I missed the `big' part! Thanks. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B -- To unsubscribe from this list: send the l

About perf,arm -- oops in validate_event

2013-08-20 Thread P J P
Hello, -> https://lkml.org/lkml/2013/8/7/259 I wanted to confirm if this above fix should also go into ARM64 build Or is ARM64 platform not vulnerable? === $ git diff diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 9ba33c4..cbed82f 100644 --- a/arch/arm64

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-22 Thread P J P
+-- On Mon, 19 Nov 2012, Kees Cook wrote --+ | I think to avoid the explosion of request_module calls in the abusive | case, we could simply return ELOOP instead of ENOEXEC on max | recursion. -> http://www.spinics.net/lists/mm-commits/msg92433.html 1. returning -ELOOP has a side effect of not r

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-23 Thread P J P
Hello Kees, all, Please have a look at a *NEW* patch at the end of this mail. It seems to fix both the issues, stack disclosure + undue recursions. It uses modprobe "--first-time" option which returns an error code when trying to load a module which is already present or unload one which is

Re: [PATCH] exec: do not leave bprm->interp on stack

2012-11-25 Thread P J P
+-- On Sat, 24 Nov 2012, Kees Cook wrote --+ | Well, "ever" meaning "if depth is hit, always fail out", yes. This is | intentional. We do not want to attempt module loading if we hit a recursion | limit. Ah yes, that's right! Thanks so much! :) -- Prasad J Pandit / Red Hat Security Response T

[PATCH 1/1] Drop INITRAMFS_COMPRESSION_GZIP option

2013-11-24 Thread P J P
nfig file with the CONFIG_RD_GZIP=y, for INITRAMFS_COMPRESSION_GZIP is not set. Also removed the corresponding Kconfig choice text for all INITRAMFS_COMPRESSION_* options. Signed-off-by: P J P diff --git a/arch/mips/configs/nlm_xlr_defconfig b/arch/mips/configs/nlm_xlr_defconfig index 44b4734..

[Patch] Read CONFIG_RD_ variables for initramfs compression

2013-10-15 Thread P J P
y are not used, it could be better to remove their description/references from usr/Kconfig and other places. Thank you. -- Prasad J Pandit / Red Hat Security Response TeamFrom 0304fb400c27227106c1f9a57fe3de13ca03cca2 Mon Sep 17 00:00:00 2001 From: P J P Date: Tue, 15 Oct 2013 19:28:40 +053

Re: [Patch] Read CONFIG_RD_ variables for initramfs compression

2013-10-30 Thread P J P
Hello Andrew, +-- On Tue, 29 Oct 2013, Andrew Morton wrote --+ | On Tue, 15 Oct 2013 20:25:57 +0530 (IST) P J P wrote: | This patch breaks my x86_64 allmodconfig build, because I don't have | the lz4 executable installed: | | /usr/src/25/scripts/gen_initramfs_list.sh: line 307: lz4: co

Re: [Patch] Read CONFIG_RD_ variables for initramfs compression

2013-10-31 Thread P J P
/ Red Hat Security Response TeamFrom 352781fd2846c54e92ae0c37dd972dc5fcdfb695 Mon Sep 17 00:00:00 2001 From: P J P Date: Thu, 31 Oct 2013 12:03:00 +0530 Subject: Read CONFIG_RD_ variables for initramfs compression When expert configuration option(CONFIG_EXPERT) is enabled, menuconfig offers a

Re: [PATCH] initramfs: allow again choice of the embedded compression algorithm

2014-09-29 Thread P J P
using lzo | INITRAMFS_COMPRESSION_LZ4 Compress using lz4 I haven't tested the patch yet, but does it preserve the CONFIG_RD_* options' functionality? Would unifying the two options into one be a good idea? -- - P J P 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F -- To unsubscribe from this list: send t

Re: [PATCH] initramfs: remove "compression mode" choice

2014-04-08 Thread P J P
Please see -> https://lkml.org/lkml/2013/11/25/21 @Andrew: is it queued to be merged upstream? Thank you. -- - P J P -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: [PATCH] initramfs: remove "compression mode" choice

2014-04-08 Thread P J P
+-- On Tue, 8 Apr 2014, Paul Bolle wrote --+ | lkml.org shows nothing for me, currently, but I think it's the same one as | http://marc.info/?l=linux-kernel&m=138536209816822&w=2 . Yes, that's the one. -- - P J P -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] initramfs: remove "compression mode" choice

2014-04-11 Thread P J P
t be better. I don't get it. You mean one option for build time compression and another for run time compression? Shouldn't those two be exactly same? -- - P J P -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [Patch] Read CONFIG_RD_ variables for initramfs compression

2013-12-11 Thread P J P
Hello Simon, Andrew +-- On Wed, 11 Dec 2013, Simon Guinot wrote --+ | IIUC this patch, the INITRAMFS_COMPRESSION_* options are now | ignored/useless. Don't you think we should remove them from the | usr/Kconfig file ? -> https://lkml.org/lkml/2013/11/25/21 I'v pushed a patch from Mr Hristo t

Re: Broken initrd compression settings in 3.13

2013-12-23 Thread P J P
Hi, +-- On Fri, 20 Dec 2013, Linus Torvalds wrote --+ | So commit 1bf49dd4be0b ("./Makefile: export initial ramdisk | compression config option") seems to be totally broken. | | And I'm not saying that because Jan fixed a make-3.80 incompatibility | in commit 7ac181568342 ("fix build with make

Re: [PATCH] KVM: x86: fix out-of-bounds accesses of rtc_eoi map

2016-11-23 Thread P J P
+-- On Wed, 23 Nov 2016, Paolo Bonzini wrote --+ | On 23/11/2016 21:15, Radim Krčmář wrote: | > KVM was using arrays of size KVM_MAX_VCPUS with vcpu_id, but ID can be | > bigger that the maximal number of VCPUs, resulting in out-of-bounds | > access. | > | > Found by syzkaller: | > | > BUG: KAS

Re: [Part2 Patch v4.2] crypto: ccp: Add Platform Security Processor (PSP) device support

2017-10-03 Thread P J P
err; | + | + sp->psp_data = psp; | ... | +e_err: | + sp->psp_data = NULL; Needs to kfree(sp->psp_data) before setting to NULL. -- - P J P 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Part2 PATCH v4.1 07/29] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-03 Thread P J P
SEV_CMD_RECEIVE_UPDATE_VMSA:return sizeof(struct sev_data_receive_update_vmsa); | + case SEV_CMD_LAUNCH_UPDATE_SECRET:return sizeof(struct sev_data_launch_secret); | + default:return 0; | + } Each return above needs to be on its own line. -- - P J P 47AF CE69

Re: [Part2 PATCH v4.1 07/29] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-04 Thread P J P
+-- On Wed, 4 Oct 2017, Borislav Petkov wrote --+ | On Wed, Oct 04, 2017 at 12:26:11PM +0530, P J P wrote: | > Each return above needs to be on its own line. | | ... because? It appears to cross 80 columns limit, checkpatch.pl throws warnings. Adding new line would be consistent with cod

Re: [Part2 PATCH v4.1 07/29] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-04 Thread P J P
. Quick glance would work if it is readable. Currently it is not if one is viewing it in 80 cols screen/window. They do that. Writing return on the same line does not add specific value IMO. Up to you; I pointed it out as 80 columns rule makes sense to me. -- - P J P 47AF CE69 3A90 54AA 9045

write(2) and page cache

2013-07-28 Thread dmi p
Hi, When I write(2) on a file such that the size of the buffer being written is less than the page size, and the page is not in the page cache, does the write syscall block until the page is brought into the page cache from disk (to modify it and eventually write back), or is the page reading part

Re: Bug#321442: kernel-source-2.6.8: fails to compile on powerpc (drivers/ide/ppc/pmac.c)

2005-08-16 Thread LT-P
> to be enabled. It should patch cleanly against Debian's 2.6.8 and > Linus' current Git tree. It seems to solve the problem, thanks. Sometimes, I feel like I am the only person in the world to compile the kernel on powerpc... :) LT-P -- Seals are cute, kiss them - To unsubscrib

Re: kernel panic and then oops

2005-04-22 Thread P Lavin
kernel was crashing. After decoding the oops i found out that i was tryng to free some invalid memory !! Once i fixed this bug my module was working fine. Regards, Lavin Aaron P. Martinez wrote: I am running Centos 4 with the latest kernel (updated yesterday) 2.6.9-5.0.5.EL on a P4 2.4 machine

Re: Linux kernel TI TLAN driver

2005-04-22 Thread P Lavin
Can you send me the oops capture ?? Atro Tossavainen wrote: Hi, I got my hands on a Texas Instruments ThunderLAN PCI 100 Mbit card (PCI ID 104c:0500), which is what SGI are supplying if you want a second NIC in your O2. It appears that this card is not supported by the tlan driver in the Linux ker

wireless lan, defragmentation in driver module.

2005-07-04 Thread P Lavin
Hi, I need help in the following issue, i'll explain the mechanisum & the problem i'm facing, 1) In the existing wireless lan driver we've MPDU's & MSDU's, all the MPDU's are handled by the firmware where as all the MSDU's by the driver. Now i need to implement 802.11E protocol based block a

wireless lan, defragmentation in driver module.

2005-07-05 Thread P Lavin
Hi, I need help in the following issue, i'll explain the mechanisum & the problem i'm facing, 1) In the existing wireless lan driver we've MPDU's & MSDU's, all the MPDU's are handled by the firmware where as all the MSDU's by the driver. Now i need to implement 802.11E protocol based block a

I/O error propagation

2005-03-03 Thread V P
Hi, I have a question on how disk errors get propagated to the file systems. >From looking at the SCSI/IDE drivers, it looks like there could be many reasons for an I/O to fail. It could be bus timeout, media errors, and so on. Does all these errors get reported to the file system ? It looks lik

Re: I/O error propagation

2005-03-03 Thread V P
o the filesystem from the driver and let the file system handle them as it thinks appropriate ? thanks, On Thu, 3 Mar 2005 15:20:55 -0500 (EST), linux-os <[EMAIL PROTECTED]> wrote: > On Thu, 3 Mar 2005, V P wrote: > > > Hi, > > > > I have a question on how disk errors get

Re: no need to check for NULL before calling kfree() -fs/ext2/

2005-03-29 Thread P Lavin
TECTED]> --- Index: 2.6/include/linux/slab.h === --- 2.6.orig/include/linux/slab.h 2005-03-22 14:31:30.0 +0200 +++ 2.6/include/linux/slab.h2005-03-30 09:08:13.0 +0300 @@ -105,8 +105,14 @@ return __kmalloc(size, flags); } +static inli

Re: no need to check for NULL before calling kfree() -fs/ext2/

2005-03-30 Thread P Lavin
as happening was 201 sndpkt->buf_list->start_addr = buf; was not getting initailised & wn we try to access this variable latter this was crashing. Actally i'm not checking for return value from kmalloc thatz a mistake, I'll fix this but why is it not crashing in line # 201 ??

REQ_HARDBARRIER and REQ_SOFTBARRIER

2007-02-24 Thread V P
Hi, I'm trying to modify the ordering of I/O requests in Linux kernel, and came across the barrier flags REQ_HARDBARRIER and REQ_SOFTBARRIER. One thing I noticed (which might be wrong) is that all the requests have both these flags set. What is the significance of these flags? Is it a must for a

DONATION FOR YOU

2015-10-21 Thread P . A
Good Day, I am Mrs. Gloria C. Mackenzie, the Power-Ball Lottery winner and I have donated $2,000,000.00 USD to you. I saw your email in Kreditmarket were you were searching for a loan so i decided to get your email so i can help you with some amount so that you can start up a business on your o

[PATCH V2] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops

2018-05-12 Thread sumeet p
Correct the typecast with const to struct thermal_cooling_device_ops. It is the last argument to the function thermal_of_cooling_device_register and this argument is of type const. So, declare this structure thermal_cooling_device_ops as constant. Signed-off-by: sumeet p --- Changes in V2

BUG: unable to handle kernel NULL pointer dereference at virtual address 00000008

2007-09-25 Thread Hendrik P.
Maybe you know what bringt this box down: regards, Hendrik P. [263322.356816] BUG: unable to handle kernel NULL pointer dereference at virtual address 0008 [263322.459908] printing eip: [263322.493267] c014e09c [263322.520391] *pde = [263322.554795] Oops: [#1] [263322.589188

Re: [PATCH] Cleanup: snprintf() always NUL-terminates: depend on it

2015-01-12 Thread Aleksandr P
> len = snprintf(fname, 99, "%s", buf); > - fname[len-1] = '\0'; > I just deleted that "really, really" NUL-termination line because > it was based on a misunderstanding of snprintf()'s postcondition. Are you sure this code can be simple deleted? It does not only terminate the string but delete

Re: [PATCH v6 2/6] dt-bindings: Add the rzn1-clocks.h file

2018-05-22 Thread M P
On Tue, 22 May 2018 at 19:44, Geert Uytterhoeven wrote: > Hi Michel, > On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > wrote: > > This adds the constants necessary to use the renesas,rzn1-clocks driver. > > > > Signed-off-by: Michel Pollet > Thanks for your patch! > > --- > > include/dt-b

Re: [PATCH v6 3/6] dt-bindings: clock: renesas,rzn1-clocks: document RZ/N1 clock driver

2018-05-22 Thread M P
Hi Rob, On Tue, 22 May 2018 at 17:09, Rob Herring wrote: > On Tue, May 22, 2018 at 11:01:23AM +0100, Michel Pollet wrote: > > The Renesas RZ/N1 Family (Part #R9A06G0xx) requires a driver > > to provide the SoC clock infrastructure for Linux. > > > > This documents the driver bindings. > > > > Si

Re: [PATCH v6 2/6] dt-bindings: Add the rzn1-clocks.h file

2018-05-23 Thread M P
Morning Geert, On Wed, 23 May 2018 at 08:26, Geert Uytterhoeven wrote: > Hi Michel, > On Wed, May 23, 2018 at 8:44 AM, M P wrote: > > On Tue, 22 May 2018 at 19:44, Geert Uytterhoeven > > wrote: > >> On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > >> w

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread M P
Hi Geert, On Wed, 23 May 2018 at 10:12, Geert Uytterhoeven wrote: > Hi Michel, > On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > wrote: > > This adds the Renesas RZ/N1D (Part #R9A06G032) SoC bare > > bone support. > > > > This currently only handles generic parts (gic, architected timer) > >

Re: [PATCH v6 4/6] ARM: dts: Renesas RZ/N1 SoC base device tree file

2018-05-23 Thread M P
Hi Geert, On Wed, 23 May 2018 at 12:18, Geert Uytterhoeven wrote: > Hi Michel, > On Wed, May 23, 2018 at 11:20 AM, M P wrote: > > On Wed, 23 May 2018 at 10:12, Geert Uytterhoeven > > wrote: > >> On Tue, May 22, 2018 at 12:01 PM, Michel Pollet > >> wrote

[PATCH] staging: iio: fix coding style

2014-06-12 Thread Jimmy P
This patch fixes coding style errors reported by checkpatch.pl for lines that was over 80 chars long. The macro value shoud be put in () as well. Signed-off-by: Jimmy P --- drivers/staging/iio/frequency/ad5930.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a

Inode entry of a process in /proc/pid changes

2014-02-06 Thread navin p
Hi, I am running RHEL 6.4 on 2.6 linux x64 on one of our customer server. When there is a stress or the server is highly loaded by one of the backup agents the inode number (got from ls -i /proc/ or ls -i /proc//task/ ) changes. If you don't put any stress/load on the system , the inode nu

Re: [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk

2014-08-16 Thread Hema .p
On Sat, Aug 16, 2014 at 4:51 AM, Greg KH wrote: > On Fri, Aug 15, 2014 at 11:48:05PM +0530, Hema Prathaban wrote: >> This patch fixes the following warning using checkpatch.pl >> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then >> dev_warn(dev, ... then pr_warn(... to printk(K

Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c

2014-11-05 Thread P. Christeas
On Wednesday 05 November 2014, Vlastimil Babka wrote: > I see. I've tried to reproduce such issues with 3.18-rc3 but wasn't > successful. But I noticed a possible issue that could lead to your problem. > Can you please try the following patch? OK, I can give it a try. FYI, the "stability canary"

Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c

2014-11-06 Thread P. Christeas
ytes still pinned. SysRq : HELP : loglevel(0-9) reboot(b) crash(c) terminate-all-tasks(e) memory-full-oom-kill(f) kill-all-tasks(i) thaw-filesystems(j) sak(k) show-backtrace-all-active-cpus(l) show-memory-usage(m) nice-all-RT-tasks(n) poweroff(o) show-registers(p) show-all-timers(q) unraw(r) sync(s) sho

Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c

2014-11-08 Thread P. Christeas
6 e8 89 84 0a 00 85 c0 74 0a 48 98 INFO: NMI handler (arch_trigger_all_cpu_backtrace_handler) took too long to run: 76.962 msecs SysRq : HELP : loglevel(0-9) reboot(b) crash(c) terminate-all-tasks(e) memory-full-oom-kill(f) kill-all-tasks(i) thaw-filesystems(j) sak(k) show-backtrace-all-active-cp

Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c

2014-11-09 Thread P. Christeas
On Sunday 09 November 2014, Hillf Danton wrote: > - return COMPACT_CONTINUE; > + return COMPACT_SKIPPED; I guess this one would mitigate against Vlastmil's migration scanner issue, wouldn't it? In that case, I should wait a bit[1] to try the first patch, then revert, try

Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c

2014-11-10 Thread P. Christeas
On Saturday 08 November 2014, Vlastimil Babka wrote: > >From fbf8eb0bcd2897090312e23da6a31bad9cc6b337 Mon Sep 17 00:00:00 2001 > > From: Vlastimil Babka > Date: Sat, 8 Nov 2014 22:20:43 +0100 > Subject: [PATCH] mm, compaction: prevent endless loop in migrate scanner After 30hrs uptime, I also ma

Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c

2014-11-04 Thread P. Christeas
On Tuesday 04 November 2014, Vlastimil Babka wrote: > Please do keep testing (and see below what we need), and don't try > another tree - it's 3.18 we need to fix! Let me apologize/warn you about the poor quality of this report (and debug data). It is on a system meant for everyday desktop usage,

Why is SECTOR_SIZE = 512 inside kernel ?

2015-08-17 Thread Navin P
Hi, Why is SECTOR_SIZE 512 ? http://lxr.free-electrons.com/source/include/linux/ide.h#L118 http://lxr.free-electrons.com/source/include/linux/device-mapper.h#L548 548 #define SECTOR_SHIFT 9 I was looking at disks with hw_sector_size . Most of them i looked at had 512 bytes except for one whic

Hi linux

2016-04-14 Thread S P
Hi linux http://nextavailablespace.com/supper.php?ring=yc1gu3uw6zqv38ka S

Question: read-only file access in kernel module (verify checksums)

2017-01-05 Thread Marvin P.
Good day, I'm going over some code in a kernel module to implement file access functionality in an LKM. I've gone through Grek KH's lengthy article on it, and noted the pitfalls (interpreting data, how one should go through sysfs instead, etc): all good points and duly noted. I have also o

BUG: oops and lock with rfcomm, while connecting

2016-11-29 Thread P. Christeas
Hi, I would appreciate if somebody can take a quick look and tell me if the attached trace makes any sense. Story is, this happened while trying to connect ppp over BT, with USB external dongle and device (bt phone) in range. Kernel is Linus's latest, but I suspect the bug is a one-off probab

[v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-04 Thread Harigovindan P
ti-sn65dsi86 bridge is enumerated as a runtime device. Adding sleep ops to force runtime_suspend when PM suspend is requested on the device. Signed-off-by: Harigovindan P --- Changes in v2: - Include bridge name in the commit message and remove dependent patchwork link from the

  1   2   3   4   5   6   7   8   9   10   >