[rfc][patch] reimplement nopfn callers with fault

2008-01-08 Thread Nick Piggin
ey will be easier to fix. More problematic is actually testing the things; I'm not even sure I'm covering all bases with drm testing. So, if I could trouble you for a quick review and/or test at some time the patch is against latest -mm. Thanks, Nick --- From: Nick Piggin <[EMAIL P

Re: [patch 1/3] drm: nopage

2008-01-08 Thread Nick Piggin
hat you mean? Thanks, Nick > > Dave. > > > > > Anyway, please apply. > > > > -- > > > > drm: nopage > > > > Convert drm from nopage to fault. > > Remove redundant vma range checks. > > > > Signed-off-by: Nick Piggin <[

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-08 Thread Nick Piggin
On Wednesday 09 January 2008 10:51, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > No. I mean call the bit PG_private2. That way non-pagecache and > > > > filesystems that don&

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-09 Thread Nick Piggin
On Thursday 10 January 2008 02:45, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > It is to make everybody happy. Especially in code that everyone works > > on like mm/ and fs/, you can't just have everybody following their own > > slightly differ

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Nick Piggin
On Wednesday 09 January 2008 19:52, Jens Axboe wrote: > So how does it work? Instead of punting IO to a thread and passing it > through the page cache, we instead attempt to send the IO directly to the > filesystem block that it maps to. You told Christoph that just using direct-IO from kernel st

Re: [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head

2007-12-06 Thread Nick Piggin
On Thursday 06 December 2007 20:33, Li Zefan wrote: > The casting is safe only when the list_head member is the > first member of the structure. Even so, I don't think too safe :) It might technically work, but it could break more easily. So even if you find places where list_head is the first me

Re: [patch] ext2: xip check fix

2007-12-06 Thread Nick Piggin
On Thu, Dec 06, 2007 at 10:17:39PM -0600, Rob Landley wrote: > On Thursday 06 December 2007 21:22:25 Jared Hulbert wrote: > > > > I have'nt looked at it yet. I do appreciate it, I think it might > > > > broaden the user-base of this feature which is up to now s390 only due > > > > to the fact that

Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

2007-12-06 Thread Nick Piggin
On Friday 07 December 2007 12:19, Stefano Brivio wrote: > This patch fixes a regression introduced by: > > commit bb29ab26863c022743143f27956cc0ca362f258c > Author: Ingo Molnar <[EMAIL PROTECTED]> > Date: Mon Jul 9 18:51:59 2007 +0200 > > This caused the jiffies counter to leap back and forth on

Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

2007-12-07 Thread Nick Piggin
On Friday 07 December 2007 19:45, Ingo Molnar wrote: > * Stefano Brivio <[EMAIL PROTECTED]> wrote: > > This patch fixes a regression introduced by: > > > > commit bb29ab26863c022743143f27956cc0ca362f258c > > Author: Ingo Molnar <[EMAIL PROTECTED]> > > Date: Mon Jul 9 18:51:59 2007 +0200 > > > > T

Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

2007-12-07 Thread Nick Piggin
On Saturday 08 December 2007 11:50, Nick Piggin wrote: > I guess your patch is fairly complex but it should work I should also add that although complex, it should have a much smaller TSC delta window in which the wrong scaling factor can get applied to it (I guess it is about as good as you

Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

2007-12-07 Thread Nick Piggin
On Friday 07 December 2007 22:17, Ingo Molnar wrote: > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > ah, printk_clock() still uses sched_clock(), not jiffies. So it's > > > not the jiffies counter that goes back and forth, it's sched_clock() > > >

Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

2007-12-07 Thread Nick Piggin
On Saturday 08 December 2007 03:48, Nick Piggin wrote: > On Friday 07 December 2007 22:17, Ingo Molnar wrote: > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > ah, printk_clock() still uses sched_clock(), not jiffies. So it's > > > > not the ji

Re: [patch] mm: fix XIP file writes

2007-12-11 Thread Nick Piggin
flush_dcache_page(page); > > I asked myself why this problem never happened before. So I asked our testers > to reproduce this problem on 2.6.23 and service levels. As the testcase did > not trigger, I looked into the 2.6.23 code. This problem was introduced by >

Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

2007-12-11 Thread Nick Piggin
.24? I'd feel a > lot better about this that way :-) I do have the feeling that it makes > printk printout a lot more robust in general, independently of the > cpu_clock() change - especially with more complex consoles like > netconsole or fbcon. Reviewed-by: Nick Piggin <[EMA

Re: [rfc] lockless get_user_pages for dio (and more)

2007-12-11 Thread Nick Piggin
On Tuesday 11 December 2007 08:30, Dave Kleikamp wrote: > On Mon, 2007-10-15 at 22:25 +1000, Nick Piggin wrote: > > On Monday 15 October 2007 04:19, Siddha, Suresh B wrote: > > > On Sun, Oct 14, 2007 at 11:01:02AM +1000, Nick Piggin wrote: > > > > This is just a r

Re: [PATCH 36/42] VFS: export drop_pagecache_sb

2007-12-11 Thread Nick Piggin
On Monday 10 December 2007 13:42, Erez Zadok wrote: > Needed to maintain cache coherency after branch management. > Hmm, I'd much prefer to be able to sleep in invalidate_mapping_pages before this function gets exported. As it is, it can cause massive latencies on preemption and the inode_lock so

Re: [rfc] lockless get_user_pages for dio (and more)

2007-12-11 Thread Nick Piggin
On Wednesday 12 December 2007 16:11, Dave Kleikamp wrote: > On Wed, 2007-12-12 at 15:57 +1100, Nick Piggin wrote: > > On Tuesday 11 December 2007 08:30, Dave Kleikamp wrote: > > > Nick, > > > I've played with the fast_gup patch a bit. I was able to find a >

Re: [PATCH 36/42] VFS: export drop_pagecache_sb

2007-12-13 Thread Nick Piggin
On Friday 14 December 2007 02:24, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, Nick Piggin writes: > > On Monday 10 December 2007 13:42, Erez Zadok wrote: > > > Needed to maintain cache coherency after branch management. > > > > Hmm, I&

Re: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:39, David Howells wrote: > The attached patch causes read_cache_pages() to release page-private data > on a page for which add_to_page_cache() fails or the filler function fails. > This permits pages with caching references associated with them to be > cleaned up. >

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:39, David Howells wrote: > Recruit a couple of page flags to aid in cache management. The following > extra flags are defined: > > (1) PG_fscache (PG_owner_priv_2) > > The marked page is backed by a local cache and is pinning resources in > the cache driver. >

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:40, David Howells wrote: > Add a function - cancel_rejected_write() - to excise a rejected write from > the pagecache. This function is related to the truncation family of > routines. It permits the pages modified by a network filesystem client > (such as AFS) to b

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-18 Thread Nick Piggin
On Thu, Jan 17, 2008 at 08:39:23PM -0600, Matt Mackall wrote: > > On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote: > > On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote: > > > > > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the > > > boot tags.

Re: [RFC PATCH 12/23 -v4] Use RCU algorithm for monotonic cycles.

2008-01-21 Thread Nick Piggin
On Tuesday 22 January 2008 02:22, Steven Rostedt wrote: > From: john stultz <[EMAIL PROTECTED]> > static inline cycle_t > -clocksource_get_cycles(struct clocksource *cs, cycle_t now) > +clocksource_get_basecycles(struct clocksource *cs) > { > - cycle_t offset = (now - cs->cycle_last) & cs->m

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-01-21 Thread Nick Piggin
On Tuesday 22 January 2008 07:58, Frederik Himpe wrote: > With Linux 2.6.24-rc8 I often have the problem that the pan usenet > reader starts using 100% of CPU time after some time. When this happens, > kill -9 does not work, and strace just hangs when trying to attach to > the process. The same wit

Re: what's up for v2.6.25 in x86.git

2008-01-21 Thread Nick Piggin
On Tuesday 22 January 2008 07:14, Ingo Molnar wrote: > Nick Piggin (5): > mm: fix PageUptodate memory ordering bug This should actually be named differently. It should be called x86: don't unconditionally enable expensive SMP ppro workaround I actually had a more complete

Re: what's up for v2.6.25 in x86.git

2008-01-21 Thread Nick Piggin
On Tuesday 22 January 2008 12:13, Nick Piggin wrote: > On Tuesday 22 January 2008 07:14, Ingo Molnar wrote: > > Nick Piggin (5): > > mm: fix PageUptodate memory ordering bug > > This should actually be named differently. It should be > called > > x86: don'

[patch] mm: fix PageUptodate data race

2008-01-21 Thread Nick Piggin
dit of all filesystems and at least some would need reworking. That's great you're interested, I'm eagerly awaiting your patches. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/include/linux/highmem.h ===

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-01-21 Thread Nick Piggin
On Tuesday 22 January 2008 16:03, Mike Galbraith wrote: > On Tue, 2008-01-22 at 11:05 +1100, Nick Piggin wrote: > > On Tuesday 22 January 2008 07:58, Frederik Himpe wrote: > > > With Linux 2.6.24-rc8 I often have the problem that the pan usenet > > > reader starts using

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-01-22 Thread Nick Piggin
On Tuesday 22 January 2008 21:37, Ingo Molnar wrote: > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > Well I've twice tried to submit a patch to print stacks for running > > tasks as well, but nobody seems interested. It would at least give a > > chance to see somethi

Re: [PATCH RESEND] Minimal fix for private_list handling races

2008-01-22 Thread Nick Piggin
On Wednesday 23 January 2008 04:10, Jan Kara wrote: > Hi, > > as I got no answer for a week, I'm resending this fix for races in > private_list handling. Andrew, do you like them more than the previous > version? FWIW, I reviewed this, and it looks OK although I think some comments would be in

Re: [patch] x86: test case for the RODATA config option

2008-01-22 Thread Nick Piggin
On Wednesday 23 January 2008 09:44, Arjan van de Ven wrote: > From: Arjan van de Ven <[EMAIL PROTECTED]> > Subject: x86: test case for the RODATA config option > > This patch adds a test module for the DEBUG_RODATA config > option to make sure change_page_attr() did indeed make > "const" data read

Re: [PATCH RESEND] Minimal fix for private_list handling races

2008-01-23 Thread Nick Piggin
On Thursday 24 January 2008 00:30, Jan Kara wrote: > On Wed 23-01-08 12:00:02, Nick Piggin wrote: > > On Wednesday 23 January 2008 04:10, Jan Kara wrote: > > > Hi, > > > > > > as I got no answer for a week, I'm resending this fix for races in > &g

Re: [PATCH -v8 3/4] Enable the MS_ASYNC functionality in sys_msync()

2008-01-23 Thread Nick Piggin
On Thursday 24 January 2008 04:05, Linus Torvalds wrote: > On Wed, 23 Jan 2008, Anton Salikhmetov wrote: > > + > > + if (pte_dirty(*pte) && pte_write(*pte)) { > > Not correct. > > You still need to check "pte_present()" before you can test any other > bits. For a non-present pte, none of

Re: [PATCH 3/4] firewire: enforce access order between generation and node ID

2008-01-23 Thread Nick Piggin
On Thursday 24 January 2008 11:54, Stefan Richter wrote: > fw_device.node_id and fw_device.generation are accessed without mutexes. > We have to ensure that all readers will get to see node_id updates > before generation updates. > > An earlier incarnation of this patch fixes an inability to recogn

Re: [rfc] lockless get_user_pages for dio (and more)

2008-01-23 Thread Nick Piggin
4.o memset_64.o copy_user_64.o rwlock_64.o copy_user_nocache_64.o gup.o Index: linux-2.6/arch/x86/lib/gup.c === --- /dev/null +++ linux-2.6/arch/x86/lib/gup.c @@ -0,0 +1,189 @@ +/* + * Lockless fast_gup for x86 + * + * Copyright (C) 20

Re: [PATCH UPDATE] x86: ignore spurious faults

2008-01-24 Thread Nick Piggin
On Friday 25 January 2008 06:21, Jeremy Fitzhardinge wrote: > Matt Mackall wrote: > > There's perhaps an opportunity to do this lazy TLB trick in the mmap > > path as well, where RW mappings are initially mapped as RO so we can > > catch processes dirtying them and then switched to RW. If the mappi

Re: [RFC] some page can't be migrated

2008-01-24 Thread Nick Piggin
On Wednesday 23 January 2008 17:22, Shaohua Li wrote: > Anonymous page might have fs-private metadata, the page is truncated. As > the page hasn't mapping, page migration refuse to migrate the page. It > appears the page is only freed in page reclaim and if zone watermark is > low, the page is neve

Re: [RFC] some page can't be migrated

2008-01-24 Thread Nick Piggin
it is OK by me. Acked-by: Nick Piggin <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC] some page can't be migrated

2008-01-24 Thread Nick Piggin
On Friday 25 January 2008 14:09, Shaohua Li wrote: > On Fri, 2008-01-25 at 14:03 +1100, Nick Piggin wrote: > > On Wednesday 23 January 2008 17:22, Shaohua Li wrote: > > > Anonymous page might have fs-private metadata, the page is truncated. > > > As the page hasn'

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-10-02 Thread Nick Piggin
On Tuesday 02 October 2007 07:01, Christoph Lameter wrote: > On Sat, 29 Sep 2007, Peter Zijlstra wrote: > > On Fri, 2007-09-28 at 11:20 -0700, Christoph Lameter wrote: > > > Really? That means we can no longer even allocate stacks for forking. > > > > I think I'm running with 4k stacks... > > 4k st

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-10-02 Thread Nick Piggin
On Tuesday 02 October 2007 06:50, Christoph Lameter wrote: > On Fri, 28 Sep 2007, Nick Piggin wrote: > > I thought it was slower. Have you fixed the performance regression? > > (OK, I read further down that you are still working on it but not > > confirmed yet...) > > Th

Re: [PATCH 05/12] mm: trylock_page

2007-10-02 Thread Nick Piggin
On Sunday 30 September 2007 01:01, Peter Zijlstra wrote: > On Fri, 2007-09-28 at 13:11 +1000, Nick Piggin wrote: > > On Friday 28 September 2007 17:42, Peter Zijlstra wrote: > > > Replace raw TestSetPageLocked() usage with trylock_page() > > > > I have such a thing q

Re: [PATCH] Add ability to dump mapped pages with /proc/sys/vm/drop_caches

2007-10-02 Thread Nick Piggin
On Monday 01 October 2007 04:03, Soeren Sandmann wrote: > This patch adds the ability to drop mapped pages with > /proc/sys/vm/drop_caches. This is useful to get repeatable > measurements of startup time for applications. > > Without it, pages that are mapped in already-running applications will >

Re: kswapd min order, slub max order [was Re: -mm merge plans for 2.6.24]

2007-10-02 Thread Nick Piggin
On Wednesday 03 October 2007 02:06, Hugh Dickins wrote: > On Mon, 1 Oct 2007, Andrew Morton wrote: > > # > > # slub && antifrag > > # > > have-kswapd-keep-a-minimum-order-free-other-than-order-0.patch > > only-check-absolute-watermarks-for-alloc_high-and-alloc_harder-allocation > >s.patch slub-expl

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-02 Thread Nick Piggin
On Tuesday 02 October 2007 21:40, Peter Zijlstra wrote: > On Tue, 2007-10-02 at 13:21 +0200, Kay Sievers wrote: > > How about adding this information to the tree then, instead of > > creating a new top-level hack, just because something that you think > > you need doesn't exist. > > So you suggest

Re: [PATCH] mark read_crX() asm code as volatile

2007-10-02 Thread Nick Piggin
On Wednesday 03 October 2007 04:27, Chuck Ebbert wrote: > On 10/02/2007 11:28 AM, Arjan van de Ven wrote: > > On Tue, 02 Oct 2007 18:08:32 +0400 > > > > Kirill Korotaev <[EMAIL PROTECTED]> wrote: > >> Some gcc versions (I checked at least 4.1.1 from RHEL5 & 4.1.2 from > >> gentoo) can generate inco

Re: wibbling over the cpuset shed domain connnection

2007-10-02 Thread Nick Piggin
On Tuesday 02 October 2007 07:34, Paul Jackson wrote: > In -mm merge plans for 2.6.24, Andrew wrote: > > cpuset-remove-sched-domain-hooks-from-cpusets.patch > > > > Paul continues to wibble over this. Hold, I guess. > > Oh dear ... after looking at the following to figure out what > a wibble is,

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-02 Thread Nick Piggin
On Monday 01 October 2007 13:42, Paul Jackson wrote: > Nick wrote: > > Moreover, sched_load_balance doesn't really sound like a good name > > for asking for a partition. > > Yup - it's not a good name for asking for a partition. > > That's because it isn't asking for a partition. > > It's asking fo

Re: wibbling over the cpuset shed domain connnection

2007-10-02 Thread Nick Piggin
On Wednesday 03 October 2007 15:21, Paul Jackson wrote: > > In the meantime, that patch should be merged though, shouldn't it? > > Which patch do you refer to: > 1) the year old patch to disconnect cpusets and sched domains: > cpuset-remove-sched-domain-hooks-from-cpusets.patch > 2) my patc

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-02 Thread Nick Piggin
On Tuesday 02 October 2007 04:15, Paul Jackson wrote: > Nick wrote: > > which you could equally achieve by adding > > a second set of sched domains (and the global domains could keep > > globally balancing). > > Hmmm ... this could be the key to this discussion. > > Nick - can two sched domains ove

Re: [patch] sched: fix sched-domains partitioning by cpusets

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 16:56, Paul Jackson wrote: > I must NAQ this patch, and I'm surprised to see Nick propose it > again, as I thought he had already agreed that it didn't suffice. Sorry for the confusion: I only meant the sched.c part of that patch, not the full thing. - To unsubscribe

Re: [PATCH] mark read_crX() asm code as volatile

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 16:18, H. Peter Anvin wrote: > Nick Piggin wrote: > >> This should work because the result gets used before reading again: > >> > >> read_cr3(a); > >> write_cr3(a | 1); > >> read_cr3(a); > >> > >>

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 16:58, Paul Jackson wrote: > > > Yup - it's asking for load balancing over that set. That is why it is > > > called that. There's no idea here of better or worse load balancing, > > > that's an internal kernel scheduler subtlety -- it's just a request > > > that load

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 17:25, Paul Jackson wrote: > Nick wrote: > > BTW. as far as the sched.c changes in your patch go, I much prefer > > the partition_sched_domains API: http://lkml.org/lkml/2006/10/19/85 > > > > The caller should manage everything itself, rather than > > partition_sched_do

Re: [patch] sched: fix sched-domains partitioning by cpusets

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 19:21, Paul Jackson wrote: > Nick wrote: > > Sorry for the confusion: I only meant the sched.c part of that > > patch, not the full thing. > > Ah - ok. We're getting closer then. Good. > > Let me be sure I've got this right then. > > You prefer the interface from your

Re: [patch] sched: fix sched-domains partitioning by cpusets

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 19:39, Paul Jackson wrote: > > in any case i'd like to see the externally visible API get in foremost - > > and there now seems to be agreement about that. (yay!) Any internal > > shaping of APIs can be done flexibly between cpusets and the scheduler. > > Yup - though N

remove zero_page (was Re: -mm merge plans for 2.6.24)

2007-10-03 Thread Nick Piggin
On Tuesday 02 October 2007 07:22, Andrew Morton wrote: > remove-zero_page.patch > > Linus dislikes it. Probably drop it. I don't know if Linus actually disliked the patch itself, or disliked my (maybe confusingly worded) rationale? To clarify: it is not zero_page that fundamentally causes a p

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 19:55, Paul Jackson wrote: > > > Yeah -- cpusets are hierarchical. And some of the use cases for > > > which cpusets are designed are hierarchical. > > > > But partitioning isn't. > > Yup. We've got a square peg and a round hole. An impedance mismatch. > That's the r

Re: pgd_none_or_clear_bad strangeness?

2007-10-03 Thread Nick Piggin
On Tue, Oct 02, 2007 at 05:20:03PM -0500, Matt Mackall wrote: > In lib/pagewalk.c, I've been using the various forms of > {pgd,pud,pmd}_none_or_clear_bad while walking page tables as that > seemed the canonical way to do things. Lately (eg with -rc7-mm1), > these have been triggering messages like

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 21:38, Paul Jackson wrote: > > OK, so to really do anything different (from a non-partitioned setup), > > you would need to set sched_load_balance=0 for the root cpuset? > > Suppose you do that to hard partition the machine, what happens to > > newly created tasks like

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 22:14, Paul Jackson wrote: > > These are what I'm worried about, and things like kswapd, pdflush, > > could definitely use a huge amount of CPU. > > > > If you are interested in hard partitioning the system, you most > > definitely want these things to be balanced acros

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 22:41, Paul Jackson wrote: > > pdflush > > is not pinned at all and can be dynamically created and destroyed. Ditto > > for kjournald, as well as many others. > > Whatever is not pinned is moved out of the top cpuset, on the kind of > systems I'm most familiar with. Th

Re: [PATCH] cpuset and sched domains: sched_load_balance flag

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 22:17, Paul Jackson wrote: > Nick wrote: > > OK, so I don't exactly understand you either. To make it simple, can > > you give a concrete example of a cpuset hierarchy that wouldn't > > work? > > It's more a matter of knowing how my third party batch scheduler > coders

[rfc][patch 1/3] x86_64: fence nontemproal stores

2007-10-03 Thread Nick Piggin
o maybe we need sfences _before_ movnt* everywhere too? ] Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Index: linux-2.6/arch/x86_64/lib/copy_user_nocache.S === --- linux-2.6.orig/arch/x86_64/lib/copy_user_nocache.S +++ linu

[rfc][patch 2/3] x86: fix IO write barriers

2007-10-03 Thread Nick Piggin
wmb() on x86 must always include a barrier, because stores can go out of order in many cases when dealing with devices (eg. WC memory). Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Index: linux-2.6/include/asm-i386/sy

[rfc][patch 3/3] x86: optimise barriers

2007-10-03 Thread Nick Piggin
cture. smp_rmb on buggy pentium pros remains a locked op, which is apparently required. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/include/asm-i386/system.h === --- linux-2.6.orig/include/asm-i386/system.

Re: [BUG] kernel BUG at arch/i386/mm/highmem.c:15! on 2.6.23-rc8/rc9

2007-10-04 Thread Nick Piggin
On Thursday 04 October 2007 16:37, gurudas pai wrote: > Hi, > > While running Oracle database test on x86/6GB RAM machine panics with > following messages. Hi, Hmm, seems like something in sys_remap_file_pages might have broken. It's a bit hard to work out from the backtrace, though. Is it possi

Re: [BUG] kernel BUG at arch/i386/mm/highmem.c:15! on 2.6.23-rc8/rc9

2007-10-04 Thread Nick Piggin
On Thursday 04 October 2007 00:53, Nick Piggin wrote: > On Thursday 04 October 2007 16:37, gurudas pai wrote: > > Hi, > > > > While running Oracle database test on x86/6GB RAM machine panics with > > following messages. > > Hi, > > Hmm, seems like somet

Re: [13/18] x86_64: Allow fallback for the stack

2007-10-07 Thread Nick Piggin
On Friday 05 October 2007 07:20, Christoph Lameter wrote: > On Thu, 4 Oct 2007, Rik van Riel wrote: > > > Well we can now address the rarity. That is the whole point of the > > > patchset. > > > > Introducing complexity to fight a very rare problem with a good > > fallback (refusing to fork more ta

Re: [DEBUG PATCH] demonstration of hang in sched domain partitioning code

2007-10-07 Thread Nick Piggin
On Friday 05 October 2007 19:24, Paul Jackson wrote: > Nick, > > I'm running into a problem trying to use your suggested > partition_sched_domains(cpumask_t *partition) routine the way > I thought I was supposed to be able to use it. > > If I ask to set up the same partition twice in a row having >

Re: race with page_referenced_one->ptep_test_and_clear_young and pagetable setup/pulldown

2007-10-07 Thread Nick Piggin
On Friday 05 October 2007 12:44, Andrew Morton wrote: > On Thu, 04 Oct 2007 18:43:32 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > David's change 10a8d6ae4b3182d6588a5809a8366343bc295c20, "i386: add > > ptep_test_and_clear_{dirty,young}" has introduced an SMP race which > > affects the

[patch] fs: restore nobh

2007-10-07 Thread Nick Piggin
Hi, This is overdue, sorry. Got a little complicated, and I've been away from my filesystem test setup so I didn't want ot send it (lucky, coz I found a bug after more substantial testing). Anyway, RFC? --- Implement nobh in new aops. This is a bit tricky. FWIW, nobh_truncate is now implemented

Re: [PATCH] mm: set_page_dirty_balance() vs ->page_mkwrite()

2007-10-08 Thread Nick Piggin
On Tuesday 09 October 2007 02:54, Peter Zijlstra wrote: > It seems that with the recent usage of ->page_mkwrite() a little detail > was overlooked. > > .22-rc1 merged OCFS2 usage of this hook > .23-rc1 merged XFS usage > .24-rc1 will most likely merge NFS usage > > Please consider this for .23 fina

Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages

2007-10-08 Thread Nick Piggin
instead of failing. I doubt anybody will be using nonlinear mappings on anything but regular files for the time being, but as a trivial fix, I think this probably should go into 2.6.23. Thanks for spotting this problem Acked-by: Nick Piggin <[EMAIL PROTECTED]> > I hope Nick or Miklos

Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages

2007-10-08 Thread Nick Piggin
On Tuesday 09 October 2007 03:04, Andrew Morton wrote: > On Mon, 8 Oct 2007 19:45:08 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote: > > Hi all > > > > The test for VM_CAN_NONLINEAR always fails > > > > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]> > > > > diff -ur linux-2.6.23-rc9/mm/fremap.c linu

Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages

2007-10-08 Thread Nick Piggin
On Tuesday 09 October 2007 03:51, Andrew Morton wrote: > On Mon, 8 Oct 2007 10:28:43 -0700 > > I'll now add remap_file_pages soon. > > Maybe those other 2 tests aren't strong enough (?). > > Or maybe they don't return a non-0 exit status even when they fail... > > (I'll check.) > > Perhaps Yan Zhe

Re: [PATCH] mm: set_page_dirty_balance() vs ->page_mkwrite()

2007-10-08 Thread Nick Piggin
On Tuesday 09 October 2007 09:36, David Chinner wrote: > On Mon, Oct 08, 2007 at 04:37:00PM +1000, Nick Piggin wrote: > > On Tuesday 09 October 2007 02:54, Peter Zijlstra wrote: > > > Force a balance call if ->page_mkwrite() was successful. > > > > Would it b

Re: [13/18] x86_64: Allow fallback for the stack

2007-10-08 Thread Nick Piggin
On Tuesday 09 October 2007 03:36, Christoph Lameter wrote: > On Sun, 7 Oct 2007, Nick Piggin wrote: > > > The problem can become non-rare on special low memory machines doing > > > wild swapping things though. > > > > But only your huge systems will be using hu

Re: [PATCH] mm: set_page_dirty_balance() vs ->page_mkwrite()

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 12:12, Mark Fasheh wrote: > On Mon, Oct 08, 2007 at 05:47:52PM +1000, Nick Piggin wrote: > > > block_page_mkwrite() is just using generic interfaces to do this, > > > same as pretty much any write() system call. The idea was to make it > >

Re: remove zero_page (was Re: -mm merge plans for 2.6.24)

2007-10-09 Thread Nick Piggin
On Thursday 04 October 2007 01:21, Linus Torvalds wrote: > On Wed, 3 Oct 2007, Nick Piggin wrote: > > I don't know if Linus actually disliked the patch itself, or disliked > > my (maybe confusingly worded) rationale? > > Yes. I'd happily accept the patch, but

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 16:40, Huang, Ying wrote: > +unsigned long copy_from_phys(void *to, unsigned long from_phys, > + unsigned long n) > +{ > + struct page *page; > + void *from; > + unsigned long remain = n, offset, trunck; > + > + while (remain) { >

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 18:22, Huang, Ying wrote: > On Tue, 2007-10-09 at 01:25 +1000, Nick Piggin wrote: > > On Tuesday 09 October 2007 16:40, Huang, Ying wrote: > > > +unsigned long copy_from_phys(void *to, unsigned long from_phys, > > > + unsi

Re: [PATCH -mm -v4 1/3] i386/x86_64 boot: setup data

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 18:55, Huang, Ying wrote: > On Tue, 2007-10-09 at 02:06 +1000, Nick Piggin wrote: > > I'm just wondering whether you really need to access highmem in > > boot code... > > Because the zero page (boot_parameters) of i386 boot protocol has 4k &

Re: [13/18] x86_64: Allow fallback for the stack

2007-10-09 Thread Nick Piggin
On Wednesday 10 October 2007 04:39, Christoph Lameter wrote: > On Mon, 8 Oct 2007, Nick Piggin wrote: > > The tight memory restrictions on stack usage do not come about because > > of the difficulty in increasing the stack size :) It is because we want > > to k

Re: remove zero_page (was Re: -mm merge plans for 2.6.24)

2007-10-09 Thread Nick Piggin
On Wednesday 10 October 2007 00:52, Linus Torvalds wrote: > On Tue, 9 Oct 2007, Nick Piggin wrote: > > I have done some tests which indicate a couple of very basic common tools > > don't do much zero-page activity (ie. kbuild). And also combined with > > some logical arg

Re: [13/18] x86_64: Allow fallback for the stack

2007-10-09 Thread Nick Piggin
On Wednesday 10 October 2007 11:26, Christoph Lameter wrote: > On Tue, 9 Oct 2007, Nick Piggin wrote: > > > We already use 32k stacks on IA64. So the memory argument fail there. > > > > I'm talking about generic code. > > The stack size is set in arch code not

Re: remove zero_page (was Re: -mm merge plans for 2.6.24)

2007-10-09 Thread Nick Piggin
On Wednesday 10 October 2007 12:22, Linus Torvalds wrote: > On Tue, 9 Oct 2007, Nick Piggin wrote: > > Where do you suggest I go from here? Is there any way I can > > convince you to try it? Make it a config option? (just kidding) > > No, I'll take the damn patch, but q

Re: howto boost write(2) performance?

2007-10-09 Thread Nick Piggin
On Tuesday 09 October 2007 23:50, Michael Stiller wrote: > Hi list, > > i'm developing an application (in C) which needs to write about > 1Gbit/s (125Mb/s) to a disk array attached via U320 SCSI. > It runs on Dual Core 2 Xeons @2Ghz utilizing kernel 2.6.22.7. > > I buffer the data in (currently 4)

Re: remove zero_page (was Re: -mm merge plans for 2.6.24)

2007-10-10 Thread Nick Piggin
On Wednesday 10 October 2007 15:20, Linus Torvalds wrote: > On Wed, 10 Oct 2007, Hugh Dickins wrote: > > On Tue, 9 Oct 2007, Nick Piggin wrote: > > > by it ;) To prove my point: the *first* approach I posted to fix this > > > problem was exactly a patch to special-cas

Re: 2.6.23 spinlock hang in kswapd under heavy disk write loads

2007-10-10 Thread Nick Piggin
On Thursday 11 October 2007 01:33, Berkley Shands wrote: > 2.6.23 with CONFIG_DEBUG_SPINLOCK on does not hang under very high write > loads to either an LSIELP (write rate 1.1GB/Sec) or to a highpoint > RR2340 (write rate 1.0GB/Sec). With CONFIG_DEBUG_SPINLOCK off however, the > system hangs wi

Re: 2.6.23 spinlock hang in kswapd under heavy disk write loads

2007-10-10 Thread Nick Piggin
On Friday 12 October 2007 10:56, Berkley Shands wrote: > 100% reproducible on the two motherboards in question. > Does not happen on any other motherboard I have in my possession > (not tyan, not uniwide, not socket 940...) > > No errors, no dmesg, nothing with debug_spinlock set. > shows lots (wh

Re: Linux 2.6.23

2007-10-11 Thread Nick Piggin
On Wednesday 10 October 2007 20:14, Ingo Molnar wrote: > * Nicholas Miell <[EMAIL PROTECTED]> wrote: > > Does CFS still generate the following sysbench graphs with 2.6.23, or > > did that get fixed? > > > > http://people.freebsd.org/~kris/scaling/linux-pgsql.png > > http://people.freebsd.org/~kris/

Re: 2.6.23 spinlock hang in kswapd under heavy disk write loads

2007-10-11 Thread Nick Piggin
On Friday 12 October 2007 02:23, Mr. Berkley Shands wrote: > With DEBUG_SLAB on, I can run only a very short time under 2.6.23 > before a kernel panic. > > [ 626.028180] eth0: too many iterations (6) in nv_nic_irq. > [ 626.167583] eth0: too many iterations (6) in nv_nic_irq. > [ 626.206729] eth0

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 05:33, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > I'd much prefer if you would handle this in the filesystem, and have > > > > it set PG_private whenever fscache needs to receive a callback, and > >

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 05:49, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > This reintroduces the fault vs truncate race window, which must be > > > > fixed. > > > &g

Re: [Bug 9182] Critical memory leak (dirty pages)

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 06:24, Linus Torvalds wrote: > On Thu, 20 Dec 2007, Jan Kara wrote: > > As I wrote in my previous email, this solution works but hides the > > fact that the page really *has* dirty data in it and *is* pinned in > > memory until the commit code gets to writing it. So in

Re: [patch 17/20] non-reclaimable mlocked pages

2007-12-21 Thread Nick Piggin
On Friday 21 December 2007 07:56, Rik van Riel wrote: > On Wed, 19 Dec 2007 11:04:26 -0500 > > Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > > On Wed, 2007-12-19 at 08:45 -0500, Rik van Riel wrote: > > > On Wed, 19 Dec 2007 11:56:48 +1100 > > > >

Re: [patch 17/20] non-reclaimable mlocked pages

2007-12-23 Thread Nick Piggin
On Saturday 22 December 2007 01:17, Rik van Riel wrote: > On Fri, 21 Dec 2007 21:52:19 +1100 > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > BTW. if you have any workloads that are limited by page reclaim, > > especially unmapped file backed pagecache reclaim, then I

Re: 2.6.24-rc6-mm1: __raw_spin_is_contended undefined

2007-12-26 Thread Nick Piggin
On Wed, Dec 26, 2007 at 09:21:58PM -0500, Joseph Fannin wrote: > On Sat, Dec 22, 2007 at 11:30:56PM -0800, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/ > > > > This doesn't build on powerpc with my .config: > > In file inclu

Re: 2.6.24-rc6-mm1

2008-01-02 Thread Nick Piggin
On Monday 31 December 2007 00:10, Ingo Molnar wrote: > * Herbert Xu <[EMAIL PROTECTED]> wrote: > > > Ingo, it's not good that we have cond_resched() definitions > > > conditionally duplicated in kernel.h - that's increasing the risk of > > > bugs like this one. > > > > Actually, why do we even have

<    1   2   3   4   5   6   7   8   9   10   >