Re: sctp: hang in sctp_remaddr_seq_show

2013-03-18 Thread Neil Horman
On Fri, Mar 15, 2013 at 12:34:00PM -0400, Sasha Levin wrote: > Hi all, > > While fuzzing with trinity inside a KVM tools guest running latest -next > kernel, > I've stumbled on an interesting hang related to sctp. > > After some fuzzing, I get a hang message about procfs not able to grab a hold

Re: sctp: hang in sctp_remaddr_seq_show

2013-03-18 Thread Neil Horman
On Mon, Mar 18, 2013 at 11:31:06AM -0400, Vlad Yasevich wrote: > On 03/18/2013 11:25 AM, Eric Dumazet wrote: > >On Mon, 2013-03-18 at 07:04 -0400, Neil Horman wrote: > > > >>I'm not sure why the process would never get back to the schedule, but > >>lo

Re: [PATCH] [char] random: fix priming of last_data

2013-03-19 Thread Neil Horman
eas only touched when when booted in fips mode. > > This change should also go into 3.8-stable, to make the myriads of fips > users on 3.8.x happy. > > Tested-by: Jan Stancek > Tested-by: Jan Stodola > CC: Herbert Xu > CC: Neil Horman > CC: "David S. Miller&

Re: [PATCH] net: remove redundant ifdef CONFIG_CGROUPS

2013-03-21 Thread Neil Horman
> -#endif > > /** > * sk_alloc - All socket objects are allocated here > -- > 1.8.0.2 > > Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 60/62] sctp: convert to idr_alloc()

2013-02-03 Thread Neil Horman
On Sat, Feb 02, 2013 at 05:21:01PM -0800, Tejun Heo wrote: > Convert to the much saner new idr interface. > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Vlad Yasevich > Cc: Sridhar Samudrala > Cc: Neil Horman > Cc: linux-s...@vger.kernel.org >

Re: [PATCH v2 60/62] sctp: convert to idr_alloc()

2013-02-05 Thread Neil Horman
d a comment > explaining @idr_low never becomes zero. > > Signed-off-by: Tejun Heo > Acked-by: Neil Horman > Cc: Vlad Yasevich > Cc: Sridhar Samudrala > Cc: linux-s...@vger.kernel.org > --- > net/sctp/associola.c | 31 +++ > 1 file c

Re: [PATCH 76/77] sctp: convert to idr_alloc()

2013-02-07 Thread Neil Horman
d a comment > explaining @idr_low never becomes zero. > > Signed-off-by: Tejun Heo > Acked-by: Neil Horman > Cc: Vlad Yasevich > Cc: Sridhar Samudrala > Cc: linux-s...@vger.kernel.org > --- > net/sctp/associola.c | 31 +++ > 1 file ch

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Wed, Apr 03, 2013 at 05:53:27PM -0600, Bjorn Helgaas wrote: > [+cc David and iommu list, Yinghai, Jiang] > > On Mon, Mar 4, 2013 at 12:04 PM, Neil Horman wrote: > > A few years back intel published a spec update: > > http://www.intel.com/content/dam/doc/specification

[PATCH v3] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn He

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Thu, Apr 04, 2013 at 03:27:29PM +0100, David Woodhouse wrote: > On Wed, 2013-04-03 at 17:53 -0600, Bjorn Helgaas wrote: > > ); > > > + > > > + if ((revision == 0x13) && irq_remapping_enabled) { > > > +pr_warn(HW_ERR "This system BIOS has enabled interrupt > > > remapping\n

[PATCH v4] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn He

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Thu, Apr 04, 2013 at 08:57:06AM -0600, Bjorn Helgaas wrote: > On Thu, Apr 4, 2013 at 8:50 AM, Neil Horman wrote: > > On Thu, Apr 04, 2013 at 03:27:29PM +0100, David Woodhouse wrote: > >> On Wed, 2013-04-03 at 17:53 -0600, Bjorn Helgaas wrote: > >> > ); > >&g

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Thu, Apr 04, 2013 at 11:14:30AM -0600, Bjorn Helgaas wrote: > On Thu, Apr 4, 2013 at 9:39 AM, Neil Horman wrote: > > On Thu, Apr 04, 2013 at 08:57:06AM -0600, Bjorn Helgaas wrote: > >> On Thu, Apr 4, 2013 at 8:50 AM, Neil Horman wrote: > >> > On Thu, Apr 04, 2

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Thu, Apr 04, 2013 at 12:41:27PM -0600, Bjorn Helgaas wrote: > On Thu, Apr 4, 2013 at 11:51 AM, Neil Horman wrote: > > > Oh, you want the bug report that I'm fixing this against? Sure, I can do > > that. > > I thought you wanted me to include a url in th

Re: [PATCH v4] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Thu, Apr 04, 2013 at 10:40:07AM -0700, Yinghai Lu wrote: > On Thu, Apr 4, 2013 at 10:27 AM, Don Dutile wrote: > >> You need to move the quirk to early_quirk to append nointremap to > >> avoid extra rebooting. > >> > > The pci-dev's of all the (minimally, root, 5500-chipset) pci-dev's are > > kn

Re: [PATCH v4] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Neil Horman
On Thu, Apr 04, 2013 at 02:11:54PM -0700, Yinghai Lu wrote: > On Thu, Apr 4, 2013 at 1:33 PM, Bjorn Helgaas wrote: > >> See my last email to Bjorn. Doing this in early-quirks in such a way that > >> we > >> can detect an iommu that has interrupt remapping enabled (so we don't just > >> unilatera

[PATCH v5] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-05 Thread Neil Horman
that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn He

Re: [PATCH v5] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-05 Thread Neil Horman
On Fri, Apr 05, 2013 at 03:25:54PM -0400, Neil Horman wrote: > A few years back intel published a spec update: > http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf > > For the 5520 and 5500 chipsets which contained an errata (s

[PATCH v6] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-05 Thread Neil Horman
that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn He

Re: [PATCH v6] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-05 Thread Neil Horman
eil Yinghai Lu wrote: >On Fri, Apr 5, 2013 at 12:31 PM, Neil Horman wrote: >> A few years back intel published a spec update: >> http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf >> >> For the 5520 a

Re: [PATCH v2] sctp: set association state to established in dupcook_a handler

2013-01-24 Thread Neil Horman
oc)); > - sctp_add_cmd_sf(commands, SCTP_CMD_REPLY, SCTP_CHUNK(repl)); > sctp_add_cmd_sf(commands, SCTP_CMD_EVENT_ULP, SCTP_ULPEVENT(ev)); > + sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE, > + SCTP_STATE(SCTP_STATE_ESTABLISHED)); > + sctp_add_cmd_sf(comm

Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-01-25 Thread Neil Horman
On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote: > From: Andy King > > VM Sockets allows communication between virtual machines and the hypervisor. > User level applications both in a virtual machine and on the host can use the > VM Sockets API, which facilitates fast and effici

Re: [Pv-drivers] [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-01-26 Thread Neil Horman
On Fri, Jan 25, 2013 at 04:15:19PM -0800, Dmitry Torokhov wrote: > Hi Neil, > > On Friday, January 25, 2013 06:59:53 PM Neil Horman wrote: > > On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote: > > > + > > > +config VMWARE_VSOCK > >

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

2013-02-26 Thread Neil Horman
ently soon that we > >can just wait for it? > > I don't, and actually couldn't tell you if I did. The codename usage is > consistent with how we deal with all products since the patches have to go in > well in advance of product launch. > Meh, ok, I guess we cal al

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

2013-02-21 Thread Neil Horman
On Thu, Feb 21, 2013 at 02:30:43PM -0800, Seth Heasley wrote: > This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton SOC. > > Signed-off-by: Seth Heasley Is there a part number (I.e. S1200) that we can use in the name, rather than the project code name? That would seem to be

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

2013-02-21 Thread Neil Horman
On Thu, Feb 21, 2013 at 10:19:48PM +, Heasley, Seth wrote: > Hi Neil, > > >> This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton > >SOC. > >> > >> Signed-off-by: Seth Heasley > >Is there a part number (I.e. S1200) that we can use in the name, rather than > >the project co

Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport

2013-03-12 Thread Neil Horman
On Tue, Mar 12, 2013 at 10:24:02AM +0800, Xufeng Zhang wrote: > >> > >> Thanks for your review, Neil! > >> > >> I know what you mean, yes, it's most probably that the searched TSN was > >> transmitted in the currently active_path, but what should we do if not. > >> > >> Check the comment in sctp_as

Re: [PATCH 18/18] net: sctp: remove cast for kmalloc/kzalloc return value

2013-03-12 Thread Neil Horman
On Tue, Mar 12, 2013 at 01:39:47PM +0800, Zhang Yanfei wrote: > remove cast for kmalloc/kzalloc return value. > > Signed-off-by: Zhang Yanfei > Cc: Vlad Yasevich > Cc: Sridhar Samudrala > Cc: Neil Horman > Cc: Andrew Morton > Cc: linux-s...@vger.kernel.org > ---

Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport

2013-03-12 Thread Neil Horman
On Tue, Mar 12, 2013 at 08:11:34AM -0400, Vlad Yasevich wrote: > On 03/11/2013 09:31 AM, Neil Horman wrote: > >On Mon, Mar 11, 2013 at 10:14:50AM +0800, Xufeng Zhang wrote: > >>On 3/8/13, Neil Horman wrote: > >>>On Fri, Mar 08, 2013 at 03:39:

Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport

2013-03-13 Thread Neil Horman
> 1.7.0.2 > Based on discussion with Vlad, it seems theres arguably some work to do on access to the transport_addr_list before my solution is viable, so until I get to that I'm acking this patch. Acked-by: Neil Horman -- To unsubscribe from this list: send the line &q

Re: [PATCH 2/2] netprio_cgroup: Optimize the priomap copy loop slightly

2012-09-11 Thread Neil Horman
On Tue, Sep 11, 2012 at 12:42:23PM +0100, David Laight wrote: > > - for (i = 0; > > -old_priomap && (i < old_priomap->priomap_len); > > -i++) > > - new_priomap->priomap[i] = old_priomap->priomap[i]; > > + if (old_priomap) { > > + old_len = old_priomap->prioma

Re: [PATCH -mm] coredump: add support for %d=__get_dumpable() in core name

2012-09-13 Thread Neil Horman
it_code, struct > pt_regs *regs) >*/ > clear_thread_flag(TIF_SIGPENDING); > > - ispipe = format_corename(&cn, signr); > + ispipe = format_corename(&cn, &cprm); > > if (ispipe) { > int dump_count; > -- > 1.5.5.1 &g

Re: [PATCH], issue EOI to APIC prior to calling crash_kexec in die_nmi path

2008-02-12 Thread Neil Horman
> [EMAIL PROTECTED] > http://lists.infradead.org/mailman/listinfo/kexec -- /**** * Neil Horman <[EMAIL PROTECTED]> * Software Engineer, Red Hat / -- To unsubscribe from this list: send th

Re: [PATCH 2/7] netpoll: make __netpoll_cleanup non-block

2012-07-27 Thread Neil Horman
On Fri, Jul 27, 2012 at 11:37:59PM +0800, Cong Wang wrote: > Like the previous patch, slave_disable_netpoll() and __netpoll_cleanup() > may be called with read_lock() held too, so we should make them > non-block, by moving the cleanup and kfree() to call_rcu_bh() callbacks. > > Cc: "David S. Mille

[PATCH v2] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-26 Thread Neil Horman
after pci_acpi_scan_root_completes, the acpi code never sees that pcie slots are hotplug capable and configures them all to use acpi instead. Fix is pretty simple, just defer the scan until after the osc flags have been set on the device. Tested by myself and it seems to work well. Signed-off-by: Neil Horman CC: Len Brow

Re: [PATCH v2] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-26 Thread Neil Horman
On Mon, Aug 26, 2013 at 11:36:21AM -0400, Neil Horman wrote: > From: root > > Somewhere between 3.9 and 3.10 it seems the order in which pcie and acpi > probed > slots for hotplug capabilites got reversed. While this isn't a big deal, it > did > uncover a bug

[PATCH v3] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-26 Thread Neil Horman
acpi code never sees that pcie slots are hotplug capable and configures them all to use acpi instead. Fix is pretty simple, just defer the scan until after the osc flags have been set on the device. Tested by myself and it seems to work well. Signed-off-by: Neil Horman CC: Len Brown CC: &quo

Re: [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent

2013-08-27 Thread Neil Horman
> Remove memset from the static inline dma_zalloc_coherent > and add just one use of __GFP_ZERO instead. > > Trivially reduces the size of the existing uses of > dma_zalloc_coherent. > > Realign arguments as appropriate. > > Signed-off-by: Joe Perches Acked-by: Neil Horma

Re: [PATCH v3] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-27 Thread Neil Horman
On Tue, Aug 27, 2013 at 03:34:11PM -0600, Bjorn Helgaas wrote: > [+cc Stefan] > > On Mon, Aug 26, 2013 at 9:39 AM, Neil Horman wrote: > > Somewhere between 3.9 and 3.10 it seems the order in which pcie and acpi > > probed > > slots for hotplug capabilites got revers

Re: [PATCH v3] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-28 Thread Neil Horman
On Wed, Aug 28, 2013 at 07:04:47AM -0600, Bjorn Helgaas wrote: > On Tue, Aug 27, 2013 at 5:43 PM, Neil Horman wrote: > > On Tue, Aug 27, 2013 at 03:34:11PM -0600, Bjorn Helgaas wrote: > >> [+cc Stefan] > >> > >> On Mon, Aug 26, 2013 at 9:39 AM, Neil Horman wro

Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning

2013-10-03 Thread Neil Horman
On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote: > The warning for the irq remapping broken check in intel_irq_remapping.c is > pretty pointless. We need the warning, but we know where its comming from, > the > stack trace will always be the same, and it needlessly tri

Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning

2013-10-03 Thread Neil Horman
On Thu, Oct 03, 2013 at 10:08:24PM +0200, Joerg Roedel wrote: > On Thu, Oct 03, 2013 at 01:21:42PM -0400, Neil Horman wrote: > > On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote: > > > The warning for the irq remapping broken check in intel_irq_remapping.c is > >

[PATCH] iommu/vt-d: Expand interrupt remapping quirk to cover x58 chipset

2013-07-09 Thread Neil Horman
Recently we added an early quirk to detect 5500/5520 chipsets with early revisions that had problems with irq draining with interrupt remapping enabled: commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 Author: Neil Horman Date: Tue Apr 16 16:38:32 2013 -0400 iommu/vt-d: add quirk for

Re: [PATCH] iommu/vt-d: Expand interrupt remapping quirk to cover x58 chipset

2013-07-11 Thread Neil Horman
On Wed, Jul 10, 2013 at 01:31:36PM -0400, Don Dutile wrote: > On 07/09/2013 03:11 PM, Neil Horman wrote: > >Recently we added an early quirk to detect 5500/5520 chipsets with early > >revisions that had problems with irq draining with interrupt remapping > >e

[PATCH] firmware: Be a bit more verbose about direct firmware loading failure

2013-09-06 Thread Neil Horman
errors get logged, so in the event that you expect the direct firmware loader to work (like if CONFIG_FW_LOADER_USER_HELPER is enabled), and something goes wrong, you can figure out what happened. Signed-off-by: Neil Horman CC: Ming Lei CC: Greg Kroah-Hartman --- drivers/base/firmware_class.c

Re: race condition in crypto larval handling

2013-09-07 Thread Neil Horman
On Fri, Sep 06, 2013 at 04:20:50PM -0700, Kees Cook wrote: > Hi, > > I've tracked down a race condition and ref counting problem in the > crypto API internals. We've been seeing it under Chrome OS, but it > seems it's not isolated to just us: > > https://code.google.com/p/chromium/issues/detail?i

Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure

2013-09-11 Thread Neil Horman
On Wed, Sep 11, 2013 at 07:54:28PM +0800, Ming Lei wrote: > On Sat, Sep 7, 2013 at 3:36 AM, Neil Horman wrote: > > The direct firmware loading interface is a bit quiet about failures. > > Failures > > Because there are several pre-defined search paths, and generally the

Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure

2013-09-12 Thread Neil Horman
On Thu, Sep 12, 2013 at 10:25:58AM +0800, Ming Lei wrote: > On Wed, Sep 11, 2013 at 10:19 PM, Neil Horman wrote: > > On Wed, Sep 11, 2013 at 07:54:28PM +0800, Ming Lei wrote: > >> On Sat, Sep 7, 2013 at 3:36 AM, Neil Horman wrote: > >> > The direct firmware loading

Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure

2013-09-12 Thread Neil Horman
On Thu, Sep 12, 2013 at 10:30:59PM +0800, Ming Lei wrote: > On Thu, Sep 12, 2013 at 9:16 PM, Neil Horman wrote: > >> > > Please re-read the patch, then point out to me which printk the above action > > will trigger, because its not happening in my testing. If yo

Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure

2013-09-12 Thread Neil Horman
On Thu, Sep 12, 2013 at 03:46:30PM -0300, Henrique de Moraes Holschuh wrote: > On Thu, 12 Sep 2013, Neil Horman wrote: > > Both of these execptions should be rare, and are something the administrator > > will want to know about, so as not to confuse the real error with the > >

Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure

2013-09-13 Thread Neil Horman
On Fri, Sep 13, 2013 at 10:56:39AM -0300, Henrique de Moraes Holschuh wrote: > On Thu, 12 Sep 2013, Neil Horman wrote: > > On Thu, Sep 12, 2013 at 03:46:30PM -0300, Henrique de Moraes Holschuh wrote: > > > On Thu, 12 Sep 2013, Neil Horman wrote: > > > > Both of these

Re: [PATCH v3] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-29 Thread Neil Horman
On Thu, Aug 29, 2013 at 11:47:13AM -0600, Bjorn Helgaas wrote: > On Mon, Aug 26, 2013 at 11:39:13AM -0400, Neil Horman wrote: > > Somewhere between 3.9 and 3.10 it seems the order in which pcie and acpi > > probed > > slots for hotplug capabilites got reversed. While

[PATCH v4] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-29 Thread Neil Horman
he scan is complete, allowing us to properly handle old pcie 1.1 devices aspm settings properly, as b8178f130e documents. Tested successfully by myself. Signed-off-by: Neil Horman CC: Len Brown CC: "Rafael J. Wysocki" CC: linux-a...@vger.kernel.org CC: linux-...@vger.kernel.org --- dri

Re: [PATCH v4] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-30 Thread Neil Horman
On Thu, Aug 29, 2013 at 05:40:52PM -0600, Bjorn Helgaas wrote: > On Thu, Aug 29, 2013 at 04:17:05PM -0400, Neil Horman wrote: > > This is a fix for: > > https://bugzilla.kernel.org/show_bug.cgi?id=60736 > > > > During the 3.8 devel cycle: > > > > commit 8

Re: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()

2013-09-26 Thread Neil Horman
On Thu, Sep 26, 2013 at 02:25:52PM +0200, Veaceslav Falico wrote: > On Wed, Sep 25, 2013 at 05:35:54PM -0600, Bjorn Helgaas wrote: > >On Wed, Sep 25, 2013 at 5:23 PM, Neil Horman wrote: > >>On Wed, Sep 25, 2013 at 03:08:05PM -0600, Bjorn Helgaas wrote: > >>>[+

Re: [PATCH 1/1] i2c-ismt: add Initialize DMA buffer code ismt_access()

2013-09-26 Thread Neil Horman
On Thu, Sep 26, 2013 at 10:40:32AM +0200, Wolfram Sang wrote: > On Tue, Sep 24, 2013 at 04:47:55PM -0700, James Ralston wrote: > > This patch adds code to Initialize the DMA buffer to compensate for > > possible hardware data corruption. > > Take care of the line width here. > > > Signed-off-by:

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-09-26 Thread Neil Horman
cts attached. > > Also, remove the same functionality from populate_msi_sysfs(), cause on > failure we anyway call free_msi_irqs(), which will take care of all the > kobjects properly. > > And add the forgotten pci_dev_put(pdev) in case of failure to register the > kobje

Re: [PATCH v2 1/3] pci: remove redundant pci_dev_get/put() on kobject (un)register

2013-09-26 Thread Neil Horman
dev, and is > not a user of it. > > CC: Bjorn Helgaas > CC: Neil Horman > CC: Greg Kroah-Hartman > CC: linux-...@vger.kernel.org > CC: linux-kernel@vger.kernel.org > Signed-off-by: Veaceslav Falico Acked-by: Neil Horman -- To unsubscribe from this list: send the line

Re: [PATCH v2 2/3] msi: always unregister ->msi_kset within free_msi_irqs()

2013-09-26 Thread Neil Horman
we've > failed to allocate irqs and try it again. > > To fix that, move the unregister part to free_msi_irqs() and remove already > existing ones. Also, verify if it was actually created - we don't always > call free_msi_irqs() after populate_msi_sysfs(). > > CC: Bj

[PATCH] iommu: Remove stack trace from broken irq remapping warning

2013-09-27 Thread Neil Horman
BIOS being broken, without the stack trace, then sets the appropriate taint bit. Since we automatically disable irq remapping, theres no need to contiue making Abrt jump at this problem Signed-off-by: Neil Horman CC: Joerg Roedel CC: Bjorn Helgaas CC: Andy Lutomirski CC: Konrad Rzeszutek Wilk

Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning

2013-09-27 Thread Neil Horman
On Fri, Sep 27, 2013 at 12:24:10PM -0700, Andy Lutomirski wrote: > On Fri, Sep 27, 2013 at 9:53 AM, Neil Horman wrote: > > The warning for the irq remapping broken check in intel_irq_remapping.c is > > pretty pointless. We need the warning, but we know where its comming from, &g

Re: [PATCH 12/12] sctp: Remove extern from function prototypes

2013-09-23 Thread Neil Horman
struct sctp_association *asoc); > extern struct percpu_counter sctp_sockets_allocated; > -extern int sctp_asconf_mgmt(struct sctp_sock *, struct sctp_sockaddr_entry > *); > +int sctp_asconf_mgmt(struct sctp_sock *, struct sctp_sockaddr_entry *); > > /* > * sctp/primitive.c

Re: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()

2013-09-25 Thread Neil Horman
t does look redundant. Harmless, but redundant. > Also, I think it is incorrect that free_msi_irqs() does this: > > if (entry->kobj.parent) { > kobject_del(&entry->kobj); > kobject_put(&entry->kobj);

Re: [PATCH] net, cgroup: Fix boot failure due to iteration of uninitialized list

2012-09-10 Thread Neil Horman
On Mon, Sep 10, 2012 at 02:59:18PM +0530, Srivatsa S. Bhat wrote: > On 07/23/2012 05:10 PM, Neil Horman wrote: > > On Mon, Jul 23, 2012 at 09:15:05AM +0800, Gao feng wrote: > >> 于 2012年07月20日 00:27, Srivatsa S. Bhat 写道: > >>> After commit ef209f15 (net: cgroup: fix ac

[RFC PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-04 Thread Neil Horman
www.spinics.net/lists/linux-containers/msg21531.html It seems there was some modicum of consensus as to how this should work, but there was no action taken on it. Signed-off-by: Neil Horman Reported-by: Daniel Berrange CC: Alexander Viro CC: Andrew Morton CC: Serge Hallyn CC: contain

Re: net,sctp: oops in sctp_do_sm

2012-10-22 Thread Neil Horman
On Thu, Oct 18, 2012 at 10:33:29PM -0400, Sasha Levin wrote: > Hi all, > > While fuzzing with trinity inside a KVM tools (lkvm) guest running today's > linux-next, I've > stumbled on the following: > > [ 439.574039] BUG: unable to handle kernel paging request at 88001b9f40c8 > [ 439.576486

Re: [PATCH 2/4] net: remove obsolete simple_strto

2012-12-07 Thread Neil Horman
On Fri, Dec 07, 2012 at 05:19:58PM +0530, Abhijit Pawar wrote: > This patch replace the obsolete simple_strto with kstrto > > Signed-off-by: Abhijit Pawar > --- > net/core/netpoll.c |9 +++-- > net/ipv4/netfilter/ipt_CLUSTERIP.c |9 +++-- > net/mac80211/debugfs_st

Re: [PATCH RESEND] net: remove obsolete simple_strto

2012-12-10 Thread Neil Horman
On Mon, Dec 10, 2012 at 02:42:28PM +0530, Abhijit Pawar wrote: > This patch replace the obsolete simple_strto with kstrto > > Signed-off-by: Abhijit Pawar Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-11 Thread Neil Horman
www.spinics.net/lists/linux-containers/msg21531.html It seems there was some modicum of consensus as to how this should work, but there was no action taken on it. Signed-off-by: Neil Horman Reported-by: Daniel Berrange CC: Daniel Berrange CC: Alexander Viro CC: Andrew Morton CC: Serge Hall

Re: [PATCH] random: prime last_data value per fips requirements

2012-11-06 Thread Neil Horman
t; then pass along the value after that to the requester, so that consistency > checks aren't being run against stale and possibly known data. > > CC: Herbert Xu > CC: "David S. Miller" > CC: Neil Horman > CC: Matt Mackall > CC: linux-cry...@vger.kernel.org

Re: [PATCH v3] random: prime last_data value per fips requirements

2012-11-06 Thread Neil Horman
he extra primer bits. > > v3: extract_buf() can't be called with spinlock already held, so bring > back some extra lock/unlock calls. > > CC: Herbert Xu > CC: "David S. Miller" > CC: Neil Horman > CC: Matt Mackall > CC: linux-cry...@vger.kernel.o

Re: [PATCH 28/29] net/: rename net_random() to prandom_u32()

2012-12-25 Thread Neil Horman
On Tue, Dec 25, 2012 at 08:47:26PM +0900, Akinobu Mita wrote: > 2012/12/25 Neil Horman : > > On Mon, Dec 24, 2012 at 11:14:15AM +0900, Akinobu Mita wrote: > >> Use more preferable function name which implies using a pseudo-random > >> number generator. > >&

Re: [PATCH] netprio_cgroup: define sk_cgrp_prioidx only if NETPRIO_CGROUP is enabled

2012-12-26 Thread Neil Horman
On Wed, Dec 26, 2012 at 02:48:24PM +0800, Li Zefan wrote: > sock->sk_cgrp_prioidx won't be used at all if CONFIG_NETPRIO_CGROUP=n. > > Signed-off-by: Li Zefan Acked-by: Neil Horman > --- > include/net/sock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree

2012-12-18 Thread Neil Horman
On Tue, Dec 18, 2012 at 09:06:04PM +0100, Oleg Nesterov wrote: > On 12/17, Neil Horman wrote: > > > > On Mon, Dec 17, 2012 at 05:04:08PM +0100, Oleg Nesterov wrote: > > > > > > > Is there a way to switch all namespaces, except for the pid > > > > nam

Re: + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree

2012-12-18 Thread Neil Horman
On Tue, Dec 18, 2012 at 12:45:18PM -0800, Eric W. Biederman wrote: > Neil Horman writes: > > > On Tue, Dec 18, 2012 at 09:06:04PM +0100, Oleg Nesterov wrote: > >> On 12/17, Neil Horman wrote: > >> > > >> > On Mon, Dec 17, 2012 at 05:04:08PM +0100

Re: + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree

2012-12-19 Thread Neil Horman
On Wed, Dec 19, 2012 at 05:22:30PM +0100, Oleg Nesterov wrote: > On 12/18, Neil Horman wrote: > > > > On Tue, Dec 18, 2012 at 09:06:04PM +0100, Oleg Nesterov wrote: > > > > Perhaps its best just to restrict this patch to adjusting the root fs > > > &g

Re: [PATCH 28/29] net/: rename net_random() to prandom_u32()

2012-12-24 Thread Neil Horman
On Mon, Dec 24, 2012 at 11:14:15AM +0900, Akinobu Mita wrote: > Use more preferable function name which implies using a pseudo-random > number generator. > > Signed-off-by: Akinobu Mita > Cc: Jesse Gross > Cc: Venkat Venkatsubra > Cc: Vlad Yasevich > Cc: Sridhar Samu

Re: [PATCHSET cgroup/for-3.8] netprio_cgroup: implement hierarchy support

2012-11-19 Thread Neil Horman
Documentation/cgroups/net_prio.txt | 21 +- > include/linux/cgroup.h |2 > include/net/netprio_cgroup.h | 21 +- > kernel/cgroup.c| 15 + > net/core/netprio_cgroup.c | 376 > +++-- > 5 files c

Re: [PATCHSET cgroup/for-3.8] netcls_cgroup: implement hierarchy support

2012-11-19 Thread Neil Horman
> review-netcls_cgroup-hierarchy > > diffstat follows. > > include/net/cls_cgroup.h |1 > net/sched/cls_cgroup.c | 102 > --- > 2 files changed, 88 insertions(+), 15 deletions(-) > > Thanks. > > -- > tejun > > [1] http://t

[PATCH v10] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-16 Thread Neil Horman
g.cgi?id=887006 Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn Helgaas CC: Asit Mallick CC: David Woodhouse CC: linux-...@vger.kernel.org CC: Joerg Roedel CC: Konrad Rzeszutek Wilk CC: Arkadiusz Miśkiewicz --- Change notes: v2) * Moved the qui

Re: [PATCH v10] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-18 Thread Neil Horman
On Thu, Apr 18, 2013 at 05:02:39PM +0200, Joerg Roedel wrote: > On Tue, Apr 16, 2013 at 04:38:32PM -0400, Neil Horman wrote: > > A few years back intel published a spec update: > > http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specifica

[PATCH] libcxgbi: supress warning when we request to much space from kmalloc

2013-04-23 Thread Neil Horman
igned-off-by: Neil Horman Reported-by: Honggang LI CC: "James E.J. Bottomley" CC: linux-kernel@vger.kernel.org --- drivers/scsi/cxgbi/libcxgbi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.h b/drivers/scsi/cxgbi/libcxgbi.h index 8

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-24 Thread Neil Horman
d > Signed-off-by: Michael S. Tsirkin > --- > > I haven't figured out why do we get failures, > but recovery is clearly wrong. > > This is also -stable material. > > drivers/net/tun.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by:

Re: [PATCH] iommu/vt-d: Expand interrupt remapping quirk to cover x58 chipset

2013-07-16 Thread Neil Horman
On Thu, Jul 11, 2013 at 06:59:52AM -0400, Neil Horman wrote: > On Wed, Jul 10, 2013 at 01:31:36PM -0400, Don Dutile wrote: > > On 07/09/2013 03:11 PM, Neil Horman wrote: > > >Recently we added an early quirk to detect 5500/5520 chipsets with early > > >revisions that had

[PATCH] iommu/vt-d: Expand interrupt remapping quirk to cover x58 chipset

2013-07-17 Thread Neil Horman
Recently we added an early quirk to detect 5500/5520 chipsets with early revisions that had problems with irq draining with interrupt remapping enabled: commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 Author: Neil Horman Date: Tue Apr 16 16:38:32 2013 -0400 iommu/vt-d: add quirk for

Re: [PATCH 089/145] iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets

2013-07-18 Thread Neil Horman
On Thu, Jul 18, 2013 at 11:02:00AM +0300, Thomas Backlund wrote: > 18.07.2013 01:47, Kamal Mostafa skrev: > >3.8.13.5 -stable review patch. If anyone has any objections, please let me > >know. > > > >------ > > &g

Re: [PATCH 03/23] netprio_cgroup: pass around @css instead of @cgroup and kill struct cgroup_netprio_state

2013-08-02 Thread Neil Horman
While at it, kill struct cgroup_netprio_state which only contained > struct cgroup_subsys_state without serving any purpose. All functions > are converted to deal with @css directly. > > This patch shouldn't cause any behavior differences. > > Signed-off-by: Tejun Heo

[PATCH] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-23 Thread Neil Horman
acpi code never sees that pcie slots are hotplug capable and configures them all to use acpi instead. Fix is pretty simple, just defer the scan until after the osc flags have been set on the device. Tested by myself and it seems to work well. Signed-off-by: Neil Horman CC: Len Brown CC: &quo

Re: [PATCH] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-23 Thread Neil Horman
e more to this? Neil > On Friday, August 23, 2013 01:19:39 PM Neil Horman wrote: > > Somewhere between 3.9 and 3.10 it seems the order in which pcie and acpi > > probed > > slots for hotplug capabilites got reversed. While this isn't a big deal, > > i

Re: [PATCH] ACPI: Fix osc flag setup ordering to allow pcie hotplug use when available

2013-08-23 Thread Neil Horman
y, August 23, 2013 04:05:11 PM Neil Horman wrote: > >> >> On Fri, Aug 23, 2013 at 09:38:18PM +0200, Rafael J. Wysocki wrote: > >> >> > [CCs added] > >> >> > > >> >> > Please always send PCI-related material to linux-pci in the first

Re: [PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-07 Thread Neil Horman
] Code: 1f 44 00 00 0f 1f 44 00 00 55 48 89 e5 48 83 ec 30 4c 89 > 65 e0 48 89 5d d8 49 89 fc 4c 89 6d e8 4c 89 75 f0 4c 89 7d f8 48 8 > [52608.609559] RIP [] __netpoll_cleanup+0x27/0xe0 > [52608.609563] RSP > [52608.609564] CR2: 03e0 > [52608.609567] ---[ end trace d25

Re: [PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-08 Thread Neil Horman
On Thu, Aug 08, 2013 at 09:14:31AM +0300, Dan Aloni wrote: > On Thu, Aug 8, 2013 at 8:50 AM, Neil Horman wrote: > > > > On Wed, Aug 07, 2013 at 12:02:44PM +0300, Dan Aloni wrote: > [..] > > > > > When my 'ifup eth' script was fired multiple times and

Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues

2013-07-25 Thread Neil Horman
On Thu, Jul 25, 2013 at 09:14:25AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2013-07-25 at 08:34 +1000, Anton Blanchard wrote: > > > Apart from the annoying colors, is there anything specific I should > > > be looking for? Some sort of error message, or output that actually > > > makes sense?

Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues

2013-07-26 Thread Neil Horman
anted to check, and don't currently have access to a > > powerpc system to do so. Neil > > I tested a relocatable kernel forced to run at a non zero physical > address (ie basically kdump). I verified CRCs were bad with your > original patch backed out, and were good with th

[PATCH] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-03-01 Thread Neil Horman
that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn He

Re: [PATCH] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-03-01 Thread Neil Horman
On Fri, Mar 01, 2013 at 10:20:35AM -0800, Yinghai Lu wrote: > On Fri, Mar 1, 2013 at 9:17 AM, Neil Horman wrote: > > A few years back intel published a spec update: > > http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf

Re: [PATCH] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-03-02 Thread Neil Horman
On Sat, Mar 02, 2013 at 11:21:29AM -0500, Prarit Bhargava wrote: > On 03/01/2013 12:17 PM, Neil Horman wrote: > > A few years back intel published a spec update: > > http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf > &

[PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-03-04 Thread Neil Horman
that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. Signed-off-by: Neil Horman CC: Prarit Bhargava CC: Don Zickus CC: Don Dutile CC: Bjorn He

Re: [PATCH 0/6] coredump: format_corename() fixes/cleanups

2013-05-16 Thread Neil Horman
r-free. > Plus some cleanups. > > Oleg. > > fs/coredump.c | 120 +++- > 1 files changed, 58 insertions(+), 62 deletions(-) > > For the series Acked-by: Neil Horman -- To unsubscribe from this list: send the line "

Re: net_dropmon usage documentation/examples?

2013-04-06 Thread Neil Horman
On Fri, Apr 05, 2013 at 07:38:55PM +, Eric Wong wrote: > Hi Neil, I'm wondering if you have or know of any public > documentation/examples for using net_dropmon. > > If not, I'll figure it out on my own at some point. > > Thanks in advance! > > (Not a very high priority project for me, my ne

  1   2   3   4   5   6   7   >