[PATCH v7 11/11] xfstests: fsx: Add fallocate insert range operation

2015-01-02 Thread Namjae Jeon
This commit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- ltp/fsx.c | 96 +-- 1 file changed, 94 insertions(+), 2 deletions(-) diff --git a/ltp/fsx.c b/ltp/fsx.c

[PATCH v7 8/11] xfstests: generic/042: Delayed allocation multi insert

2015-01-02 Thread Namjae Jeon
This testcase(042) tries to test various corner cases with delayed extents and pre-existing holes for finsert range functionality over different type of extents. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- tests/generic/042 | 65

[PATCH v7 10/11] xfstests: fsstress: Add fallocate insert range operation

2015-01-02 Thread Namjae Jeon
This commit adds insert operation support for fsstress, which is meant to exercise fallocate FALLOC_FL_INSERT_RANGE support. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- ltp/fsstress.c | 19 --- src/global.h | 4 2 files changed, 20 insertions(+), 3

[PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls

2015-01-02 Thread Namjae Jeon
This testcase(043) tries to test finsert range a single alternate block mulitiple times and test merge code of collase range. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan Cc: Brian Foster --- tests/generic/043 | 107 ++ tests

[PATCH v7 7/11] xfstests: generic/041: Multi insert range tests

2015-01-02 Thread Namjae Jeon
This testcase(041) tries to test various corner cases with pre-existing holes for finsert range functionality over different type of extents. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- tests/generic/041 | 65 + tests/generic/041.out

RE: [PATCH v6 2/10] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2014-12-04 Thread Namjae Jeon
> > Hi Namjae, Hi Brian, > > Here are some review notes. I haven't got to any of the test code or > played around with it just yet... Thanks for your reivew :) > > > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > > index 79c9819..da01890 100644 > > --- a/fs/xfs/libxfs/xfs_

RE: [PATCH v6 2/10] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2014-12-04 Thread Namjae Jeon
> > > > > > > > That said, I wonder whether we even care about a merge in the right > > > shift case since we haven't punched a hole in the file and thus have not > > > changed the "neighbors" of any of the extents we're shuffling around. I > > > would think any extents that are already contiguous

[PATCH v8 0/11] fs: Introduce FALLOC_FL_INSERT_RANGE for fallocate

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon In continuation of the work of making the process of non linear editing of media files faster, we introduce here the new flag FALLOC_FL_INSERT_RANGE for fallocate. This flag will work opposite to the FALLOC_FL_COLLAPSE_RANGE flag. As such, specifying FALLOC_FL_INSERT_RANGE

[PATCH v8 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This testcase(043) tries to test finsert range a single alternate block mulitiple times and test merge code of collase range. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan Cc: Brian Foster --- Changelog v8: - use MKFS_OPTION to use blocksize in configuration and

[PATCH v8 2/11] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS. 1) Make sure that both offset and len are block size aligned. 2) Update the i_size of inode by len bytes. 3) Compute the file's logical block number against offset. If the computed block number

[PATCH v8 1/11] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon FALLOC_FL_INSERT_RANGE command is the opposite command of FALLOC_FL_COLLAPSE_RANGE that is needed for advertisers or someone who want to add some data in the middle of file. FALLOC_FL_INSERT_RANGE will create space for writing new data within a file after shifting extents to

[PATCH v8 11/11] xfstests: fsx: Add fallocate insert range operation

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This commit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan Cc: Brian Foster --- Changelog v8: - create TRIM_OFF() and TRIM_LEN() and redeine redefine TRIM_OFF_LEN(). ltp/fsx.c | 122

[PATCH v8 3/11] ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This patch implements fallocate's FALLOC_FL_INSERT_RANGE for Ext4. 1) Make sure that both offset and len are block size aligned. 2) Update the i_size of inode by len bytes. 3) Compute the file's logical block number against offset. If the computed block number

[PATCH v8 5/11] xfstests: generic/039: Standard insert range tests

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This testcase(039) tries to test various corner cases for finsert range functionality over different type of extents. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- common/punch |5 common/rc |2 +- tests/generic/039

[PATCH v8 10/11] xfstests: fsstress: Add fallocate insert range operation

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This commit adds insert operation support for fsstress, which is meant to exercise fallocate FALLOC_FL_INSERT_RANGE support. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan Reviewed-by: Brian Foster --- ltp/fsstress.c | 19 --- src/global.h

[PATCH v8 7/11] xfstests: generic/041: Multi insert range tests

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This testcase(041) tries to test various corner cases with pre-existing holes for finsert range functionality over different type of extents. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- tests/generic/041 | 65

[PATCH v8 6/11] xfstests: generic/040: Delayed allocation insert range

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This testcase(040) tries to test various corner cases with delayed extents for finsert range functionality over different type of extents. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- tests/generic/040 | 65

[PATCH v8 8/11] xfstests: generic/042: Delayed allocation multi insert

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon This testcase(042) tries to test various corner cases with delayed extents and pre-existing holes for finsert range functionality over different type of extents. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- tests/generic/042 | 65

[PATCH v8 4/11] xfsprogs: xfs_io: add finsert command for insert range

2015-01-13 Thread Namjae Jeon
From: Namjae Jeon Add finsert command for fallocate FALLOC_FL_INSERT_RANGE flag. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan Reviewed-by: Brian Foster --- io/prealloc.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a

RE: [PATCH v8 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls

2015-01-15 Thread Namjae Jeon
n > > + status=1 > > + exit > > +fi > > + > > +umount $SCRATCH_MNT > > + > > The scratch device is unmounted and checked after each test that uses it > so the above is unnecessary. I checked your each review points. and updated patch. Could you plea

RE: [PATCH v8 11/11] xfstests: fsx: Add fallocate insert range operation

2015-01-15 Thread Namjae Jeon
mit adds fallocate FALLOC_FL_INSERT_RANGE support for fsx. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- ltp/fsx.c | 124 - 1 files changed, 114 insertions(+), 10 deletions(-) diff --git a/ltp/fsx.c b/ltp/fsx.c index 3709419

[RFC PATCH] fs: file freeze support

2015-01-15 Thread Namjae Jeon
stcase for file freeze. Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- fs/btrfs/inode.c| 1 + fs/buffer.c | 1 + fs/ext4/inode.c | 1 + fs/f2fs/file.c | 1 + fs/gfs2/file.c | 1 + fs/inode.c | 19 +++

RE: [PATCH v7 2/11] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-01-06 Thread Namjae Jeon
> > On Fri, Jan 02, 2015 at 06:40:54PM +0900, Namjae Jeon wrote: > > This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS. > > > > 1) Make sure that both offset and len are block size aligned. > > 2) Update the i_size of inode by len bytes. >

RE: [PATCH v7 1/11] fs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-01-06 Thread Namjae Jeon
> On Fri, Jan 02, 2015 at 06:40:33PM +0900, Namjae Jeon wrote: > > FALLOC_FL_INSERT_RANGE command is the opposite command of > > FALLOC_FL_COLLAPSE_RANGE that is needed for advertisers or someone who want > > to > > add some data in the middle of file. FALLOC_

RE: [PATCH v7 10/11] xfstests: fsstress: Add fallocate insert range operation

2015-01-06 Thread Namjae Jeon
> > On Fri, Jan 02, 2015 at 06:42:51PM +0900, Namjae Jeon wrote: > > This commit adds insert operation support for fsstress, which is > > meant to exercise fallocate FALLOC_FL_INSERT_RANGE support. > > > > Signed-off-by: Namjae Jeon > > Signed-off-by: Ashi

RE: [PATCH v7 11/11] xfstests: fsx: Add fallocate insert range operation

2015-01-06 Thread Namjae Jeon
> > } > > break; > > + case OP_INSERT_RANGE: > > + if (!insert_range_calls) { > > + log4(OP_SKIPPED, OP_INSERT_RANGE, offset, size); > > + goto out; > > + } > > + break; > > } > > > > switch (op) { >

RE: [PATCH v7 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls

2015-01-06 Thread Namjae Jeon
> > + > > +for (( BSIZE = 1024; BSIZE <= 4096; BSIZE *= 2 )); do > > + > > + length=$(($BLOCKS * $BSIZE)) > > + case $FSTYP in > > + xfs) > > + _scratch_mkfs -b size=$BSIZE >> $seqres.full 2>&1 > > + ;; > > + ext4) > > + _scratch_mkfs -b $BSIZE >> $seqres.full 2>&1 > > + ;; > > +

RE: [RFC PATCH] fs: file freeze support

2015-01-15 Thread Namjae Jeon
> > For implementation purpose, initially we tried to keep percpu usage counters > > inside struct inode just like there is struct sb_writers in super_block. > > But considering that it will significantly bloat up struct inode when > > actually > > the usage of file write freeze will be infrequen

RE: [RFC PATCH] fs: file freeze support

2015-01-15 Thread Namjae Jeon
> > Hello, Hi Jan, > > > + > > +int file_write_unfreeze(struct inode *inode) > > +{ > > + struct super_block *sb = inode->i_sb; > > + > > + if (!S_ISREG(inode->i_mode)) > > + return -EINVAL; > > + > > + spin_lock(&inode->i_lock); > > + > > + if (!(inode->i_state & I_WRITE_FR

RE: [PATCH v8 2/11] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate

2015-01-15 Thread Namjae Jeon
> On Wed, Jan 14, 2015 at 01:05:17AM +0900, Namjae Jeon wrote: > > From: Namjae Jeon > > > > This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS. > > > > 1) Make sure that both offset and len are block size aligned. > > 2) Update the i_si

RE: [PATCH v8 11/11] xfstests: fsx: Add fallocate insert range operation

2015-01-15 Thread Namjae Jeon
> Reviewed-by: Brian Foster Thanks you. If you find any issue, Please share with me. > > > Thanks! > > > > ------ > > Subject: [PATCH v9 11/11] xf

RE: [PATCH v8 9/11] xfstests: generic/043: Test multiple fallocate insert/collapse range calls

2015-01-15 Thread Namjae Jeon
> On Thu, Jan 15, 2015 at 07:14:26PM +0900, Namjae Jeon wrote: > > > > > > +_require_scratch > > > > +_require_xfs_io_command "fiemap" > > > > +_require_xfs_io_command "finsert" > > > > +_require_xfs_io_command "fcol

RE: [RFC PATCH] fs: file freeze support

2015-01-19 Thread Namjae Jeon
> Hello, Hi Jan. > > On Fri 16-01-15 15:48:04, Namjae Jeon wrote: > > > > +int file_write_unfreeze(struct inode *inode) > > > > +{ > > > > + struct super_block *sb = inode->i_sb; > > > > + > > > > +

RE: [RFC PATCH] fs: file freeze support

2015-01-19 Thread Namjae Jeon
> On Thu, Jan 15, 2015 at 08:36:55PM +0900, Namjae Jeon wrote: > > We introduce per-file freeze feature for unifying defrag ext4 and xfs > > as first ingredient. We get the idea courtesy of Dave Chinner > > (https://lkml.org/lkml/2014/7/14/759) Hi Dave, > > /m

Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-16 Thread Namjae Jeon
Hi Vinayak. > + * ufshcd_pltfrm_remove - remove platform driver routine > + * @pdev: pointer to platform device handle > + * > + * Returns 0 on success, non-zero value on failure > + */ > +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev) > +{ > + struct resource *mem_res;

Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-19 Thread Namjae Jeon
2012/7/17 vinayak holikatti : > On Mon, Jul 16, 2012 at 7:19 PM, Namjae Jeon wrote: >> Hi Vinayak. >>> + * ufshcd_pltfrm_remove - remove platform driver routine >>> + * @pdev: pointer to platform device handle >>> + * >>> + * Returns 0 on success, n

[PATCH 0/3] driver: core: add security label to devtmpfs nodes

2015-06-05 Thread Namjae Jeon
Allow drivers to set security label(e.g. smack, selinux) to be used for their device nodes on devtmpfs. In this manner, some systems (e.g. Android, tizen etc.) can allow setting of security label on devtmpfs nodes even if there is no udev. Namjae Jeon (3): driver: core: add uid gid to class

[PATCH 2/3] driver: core: add security labels to devtmpfs

2015-06-05 Thread Namjae Jeon
Add support for setting security labels(e.g. smack or selinux labels) to devtmpfs device nodes. In this manner, drivers can specify desired security label in their device_type->devnode or class->devnode method. Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- arch/x86/kernel/c

[PATCH 1/3] driver: core: add uid gid to class devnode

2015-06-05 Thread Namjae Jeon
driver core: add uid and gid to devtmpfs" Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- arch/x86/kernel/cpuid.c| 3 ++- arch/x86/kernel/msr.c | 3 ++- block/bsg.c| 3 ++- drivers/base/core.c

[PATCH 3/3] driver: core: add security labels to misc class devnode

2015-06-05 Thread Namjae Jeon
Add support for setting security labels on devtmpfs nodes created by misc class drivers using misc_register. Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- drivers/char/misc.c| 5 + include/linux/miscdevice.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a

RE: [PATCH 1/3] driver: core: add uid gid to class devnode

2015-06-05 Thread Namjae Jeon
> On Fri, Jun 05, 2015 at 07:10:21PM +0900, Namjae Jeon wrote: > > Add support for setting uid gid to devtmpfs device nodes. > > In this manner, drivers can specify desired uid gid in their > > class->devnode method. > > > > This is extension of existing

RE: [PATCH 3/3] driver: core: add security labels to misc class devnode

2015-06-05 Thread Namjae Jeon
> On Fri, Jun 05, 2015 at 07:10:24PM +0900, Namjae Jeon wrote: > > Add support for setting security labels on devtmpfs nodes created > > by misc class drivers using misc_register. > > > > Signed-off-by: Namjae Jeon > > Signed-off-by: Vivek Trivedi > > Ag

RE: [PATCH 2/3] driver: core: add security labels to devtmpfs

2015-06-05 Thread Namjae Jeon
> On Fri, Jun 05, 2015 at 07:10:23PM +0900, Namjae Jeon wrote: > > Add support for setting security labels(e.g. smack or selinux labels) to > > devtmpfs device nodes. In this manner, drivers can specify desired security > > label in their device_type->devnode or class-&g

[ANNOUNCE] exfatprogs-1.1.0 version released

2021-02-09 Thread Namjae Jeon
Hi folk, We have released exfatprogs 1.1.0 version. In this release, exfatlabel has been added to print or re-write volume label and volume serial value. Also, A new dump.exfat util has been added to display statistics from a given device(Requested by Mike Fleetwood(GParted Developer)). Any feedb

RE: [ANNOUNCE] exfatprogs-1.1.0 version released

2021-02-09 Thread Namjae Jeon
> On Wed, Feb 10, 2021 at 12:50 AM Namjae Jeon wrote: > > > > Hi folk, > > > > We have released exfatprogs 1.1.0 version. In this release, exfatlabel > > has been added to print or re-write volume label and volume serial value. > > Also, A new dump.exfat ut

[PATCH] exfat: remove unnecessary reassignment of p_uniname->name_len

2020-06-01 Thread Namjae Jeon
kbuild test robot reported : fs/exfat/nls.c:531:22: warning: Variable 'p_uniname->name_len' is reassigned a value before the old one has been used. The reassignment of p_uniname->name_len is not needed and remove it. Reported-by: kbuild test robot Signed-off

RE: [PATCH v2] exfat: integrates dir-entry getting and validation

2020-07-29 Thread Namjae Jeon
> Add validation for num, bh and type on getting dir-entry. > ('file' and 'stream-ext' dir-entries are pre-validated to ensure success) > Renamed > exfat_get_dentry_cached() to exfat_get_validated_dentry() due to a change in > functionality. > > Integrate type-validation with simplified. > This

RE: [PATCH] exfat: retain 'VolumeFlags' properly

2020-07-29 Thread Namjae Jeon
> Ping.. Hi Tetsuhiro, > > On 2020/07/15 19:06, Tetsuhiro Kohada wrote: > >> It looks complicated. It would be better to simply set/clear VOLUME DIRTY > >> bit. > > > > I think exfat_set_vol_flags() gets a little complicated, because it > > needs the followings (with bit operation) > > a) Set/

exfatprogs-1.0.4 version released

2020-07-31 Thread Namjae Jeon
Hi folk, In this release, The performance of fsck have been much improved and the new option in mkfs have been added to adjust boundary alignment. As the result below, The fsck performance is improved close to windows's fsck and much faster than the one in exfat-utils package. We measured the pe

[PATCH] exfat: add the dummy mount options to be backward compatible with staging/exfat

2020-05-21 Thread Namjae Jeon
-by: Linus Torvalds Signed-off-by: Namjae Jeon --- fs/exfat/super.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/fs/exfat/super.c b/fs/exfat/super.c index 0565d5539d57..26b0db5b20de 100644 --- a/fs/exfat/super.c +++ b/fs/exfat/super.c @@ -203,6 +203,

[PATCH v2] exfat: add the dummy mount options to be backward compatible with staging/exfat

2020-05-21 Thread Namjae Jeon
-by: Linus Torvalds Signed-off-by: Namjae Jeon --- v2: - fix checkpatch.pl warning(Missing Signed-off-by). fs/exfat/super.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/fs/exfat/super.c b/fs/exfat/super.c index 0565d5539d57..26b0db5b20de 100644 --- a/fs/exfat/sup

[PATCH v3] exfat: add the dummy mount options to be backward compatible with staging/exfat

2020-05-21 Thread Namjae Jeon
-by: Linus Torvalds Signed-off-by: Namjae Jeon --- v2: - fix checkpatch.pl warning(Missing Signed-off-by). v3: - use fs_param_deprecated instead of printing deprecated warning(Matthew Wilcox). fs/exfat/super.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/fs/exf

RE: [PATCH] exfat: add the dummy mount options to be backward compatible with staging/exfat

2020-05-21 Thread Namjae Jeon
> On Thu, May 21, 2020 at 09:20:34PM +0900, Namjae Jeon wrote: > > As Ubuntu and Fedora release new version used kernel version equal to > > or higher than v5.4, They started to support kernel exfat filesystem. > > > > Linus Torvalds reported mount error with new

RE: [PATCH] exfat: add the dummy mount options to be backward compatible with staging/exfat

2020-05-21 Thread Namjae Jeon
> On Thu, May 21, 2020 at 10:44:28AM -0500, Eric Sandeen wrote: > > On 5/21/20 9:05 AM, Namjae Jeon wrote: > > > As Ubuntu and Fedora release new version used kernel version equal > > > to or higher than v5.4, They started to support kernel exfat filesystem. > >

[GIT PULL] exfat update for 5.9-rc1

2020-08-12 Thread Namjae Jeon
Hi Linus, This is exfat update pull request for v5.9-rc1. I add description of this pull request on below. Please pull exfat with following ones. Thanks! The following changes since commit bcf876870b95592b52519ed4aafcf9d95999bc9c: Linux 5.8 (2020-08-02 14:21:45 -0700) are available in the Gi

RE: [PATCH 1/2] exfat: add NameLength check when extracting name

2020-08-12 Thread Namjae Jeon
> Thank you for your reply. > > >> -static void exfat_get_uniname_from_ext_entry(struct super_block *sb, > >> - struct exfat_chain *p_dir, int entry, unsigned short *uniname) > >> +static int exfat_get_uniname_from_name_entries(struct > >> exfat_entry_set_cache *es, > >> + struc

RE: [PATCH v3] exfat: remove EXFAT_SB_DIRTY flag

2020-08-12 Thread Namjae Jeon
> Thanks for thinking on this complicated issue. > > > > Most of the NAND flash devices and HDDs have wear leveling and bad sector > > replacement algorithms > applied. > > So I think that the life of the boot sector will not be exhausted first. > > I'm not too worried about the life of the boo

Re: exfatprogs-1.0.4 version released

2020-08-01 Thread Namjae Jeon
2020-07-31 18:56 GMT+09:00, Sedat Dilek : > On Fri, Jul 31, 2020 at 9:16 AM Namjae Jeon > wrote: >> >> Hi folk, >> >> In this release, The performance of fsck have been much improved and >> the new option in mkfs have been added to adjust boundary alignment.

RE: [PATCH v3] exfat: integrates dir-entry getting and validation

2020-08-09 Thread Namjae Jeon
> > +#define TYPE_PRIMARY (TYPE_CRITICAL_PRI | TYPE_BENIGN_PRI) > +#define TYPE_SECONDARY (TYPE_CRITICAL_SEC | TYPE_BENIGN_SEC) > + > #define MAX_CHARSET_SIZE 6 /* max size of multi-byte character */ > #define MAX_NAME_LENGTH 255 /* max len of file name exc

RE: [PATCH 1/2] exfat: add NameLength check when extracting name

2020-08-09 Thread Namjae Jeon
> The current implementation doesn't care NameLength when extracting the name > from Name dir-entries, so > the name may be incorrect. > (Without null-termination, Insufficient Name dir-entry, etc) Add a NameLength > check when extracting > the name from Name dir-entries to extract correct name.

RE: [PATCH 1/2] exfat: add dir-entry set checksum validation

2020-08-09 Thread Namjae Jeon
> Add checksum validation for dir-entry set when getting it. > exfat_calc_dir_chksum_with_entry_set() also validates entry-type. > > ** This patch depends on: > '[PATCH v3] exfat: integrates dir-entry getting and validation' > > Signed-off-by: Tetsuhiro Kohada > --- > fs/exfat/dir.c | 34

[GIT PULL] exfat update for 5.11-rc1

2020-12-21 Thread Namjae Jeon
Hi Linus, This is exfat update pull request for v5.11-rc1. I add description of this pull request on below. Please pull exfat with following ones. Thanks! The following changes since commit 2c85ebc57b3e1817b6ce1a6b703928e113a90442: Linux 5.10 (2020-12-13 14:41:30 -0800) are available in the

RE: [PATCH] exfat: improve performance of exfat_free_cluster when using dirsync mount option

2021-01-07 Thread Namjae Jeon
> > There are stressful update of cluster allocation bitmap when using > > dirsync mount option which is doing sync buffer on every cluster bit > > clearing. > > This could result in performance degradation when deleting big size file. > > Fix to update only when the bitmap buffer index is changed

RE: linux-next: Tree for Mar 18 (cifsd: Kconfig)

2021-03-18 Thread Namjae Jeon
> On 3/18/21 3:08 AM, Stephen Rothwell wrote: > > Hi all, > > > > News: there will be no linux-next release on Friday this week. > > > > Warning: Some of the branches in linux-next are still based on > > v5.12-rc1, so please be careful if you are trying to bisect a bug. > > > > News: if your -next

RE: [PATCH] exfat: improve write performance when dirsync enabled

2021-03-19 Thread Namjae Jeon
> > Degradation of write speed caused by frequent disk access for cluster > > bitmap update on every cluster allocation could be improved by > > selective syncing bitmap buffer. Change to flush bitmap buffer only > > for the directory related operations. > > > > Signed-off-by: Hyeongseok Kim > >

RE: [PATCH 2/5] cifsd: add server-side procedures for SMB3

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 02:13:41PM +0900, Namjae Jeon wrote: > > +static unsigned char > > +asn1_octet_decode(struct asn1_ctx *ctx, unsigned char *ch) { > > + if (ctx->pointer >= ctx->end) { > > + ctx->error = ASN1_ERR_DEC_EMPTY; > >

RE: [PATCH 2/5] cifsd: add server-side procedures for SMB3

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 09:47:13AM +0300, Dan Carpenter wrote: > > On Mon, Mar 22, 2021 at 02:13:41PM +0900, Namjae Jeon wrote: > > > +static unsigned char > > > +asn1_octet_decode(struct asn1_ctx *ctx, unsigned char *ch) { > > > + if (ctx->pointer &g

RE: [PATCH 3/5] cifsd: add file operations

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 02:13:42PM +0900, Namjae Jeon wrote: > > This adds file operations and buffer pool for cifsd. > > Some random notes: > > > +static void rollback_path_modification(char *filename) { > > + if (filename) { > > + f

RE: [PATCH 3/5] cifsd: add file operations

2021-03-22 Thread Namjae Jeon
> > > -Original Message- > > From: Namjae Jeon > > Sent: Sunday, March 21, 2021 10:14 PM > > To: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > c...@vger.kernel.org > > Cc: linux-cifsd-de...@lists.sourceforge.net; smfre...@

RE: [PATCH 1/5] cifsd: add server handler and tranport layers

2021-03-22 Thread Namjae Jeon
> On Mon, Mar 22, 2021 at 02:13:40PM +0900, Namjae Jeon wrote: > > +#define RESPONSE_BUF(w)((void *)(w)->response_buf) > > +#define REQUEST_BUF(w) ((void *)(w)->request_buf) > > Why do you do this obfuscation? I don't remember exactly,

RE: [PATCH 1/5] cifsd: add server handler and tranport layers

2021-03-22 Thread Namjae Jeon
> On Tue, Mar 23, 2021 at 12:01:22PM +0900, Namjae Jeon wrote: > > > On Mon, Mar 22, 2021 at 02:13:40PM +0900, Namjae Jeon wrote: > > > > +#define RESPONSE_BUF(w)((void *)(w)->response_buf) > > > > +#define REQUEST_BUF(w) ((void *)(w)-

RE: [PATCH v3] exfat: speed up iterate/lookup by fixing start point of traversing cluster chain

2021-03-23 Thread Namjae Jeon
> > When directory iterate and lookup is called, there's a buggy rewinding > > of start point for traversing cluster chain to the parent directory > > entry's first cluster. This caused repeated cluster chain traversing > > from the first entry of the parent directory that would show worse > > perf

RE: [PATCH v2] exfat: fix erroneous discard when clear cluster bit

2021-03-03 Thread Namjae Jeon
> If mounted with discard option, exFAT issues discard command when clear > cluster bit to remove file. > But the input parameter of cluster-to-sector calculation is abnormally added > by reserved cluster size > which is 2, leading to discard unrelated sectors included in target+2 cluster. > With

RE: [PATCH v4 0/2] Add FITRIM ioctl support for exFAT filesystem

2021-03-03 Thread Namjae Jeon
> This is for adding FITRIM ioctl functionality to exFAT filesystem. > Firstly, because the fstrim is long operation, introduce bitmap_lock to > narrow the lock range to > prevent read operation stall. > After that, add generic ioctl function and FITRIM handler. > > Changelog > = > v3->v4

[PATCH 0/5] cifsd: introduce new SMB3 kernel server

2021-03-21 Thread Namjae Jeon
;t included in any toctree (Stephen Rothwell) - fix WARNING: Title overline too short (Stephen Rothwell) - fix incorrect function comments Namjae Jeon (5): cifsd: add server handler and tranport layers cifsd: add server-side procedures for SMB3 cifsd: add file operations cif

[PATCH 4/5] cifsd: add Kconfig and Makefile

2021-03-21 Thread Namjae Jeon
This adds the Kconfig and Makefile for cifsd. Signed-off-by: Namjae Jeon Signed-off-by: Sergey Senozhatsky Signed-off-by: Hyunchul Lee Acked-by: Ronnie Sahlberg Signed-off-by: Steve French --- fs/Kconfig| 1 + fs/Makefile | 1 + fs/cifsd/Kconfig | 64

[PATCH 5/5] MAINTAINERS: add cifsd kernel server

2021-03-21 Thread Namjae Jeon
Add myself, Steve French, Sergey Senozhatsky and Hyunchul Lee as cifsd maintainer. Signed-off-by: Namjae Jeon Signed-off-by: Sergey Senozhatsky Signed-off-by: Hyunchul Lee Acked-by: Ronnie Sahlberg Signed-off-by: Steve French --- MAINTAINERS | 12 +++- 1 file changed, 11 insertions

[PATCH 3/5] cifsd: add file operations

2021-03-21 Thread Namjae Jeon
This adds file operations and buffer pool for cifsd. Signed-off-by: Namjae Jeon Signed-off-by: Sergey Senozhatsky Signed-off-by: Hyunchul Lee Acked-by: Ronnie Sahlberg Signed-off-by: Steve French --- fs/cifsd/buffer_pool.c | 292 ++ fs/cifsd/buffer_pool.h | 28 + fs/cifsd/vfs.c

Re: [Linux-cifsd-devel] [PATCH][next] cifsd: remove redundant assignment to variable err

2021-03-26 Thread Namjae Jeon
2021-03-26 2:35 GMT+09:00, Colin King : > From: Colin Ian King > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by

RE: [PATCH] cifsd: fix memory leak when loop ends

2021-04-01 Thread Namjae Jeon
> > Memory is being allocated and if veto_list is zero, the loop breaks without > cleaning up the allocated > memory. In this patch, the length check has been moved before allocation. If > loop breaks, the memory > isn't allocated in the first place. Thus the memory is being protected from > le

RE: [PATCH] cifsd: use kfree to free memory allocated by kmalloc or kzalloc

2021-04-01 Thread Namjae Jeon
> > kfree should be used to free memory allocated by kmalloc or kzalloc to avoid > any overhead and for > maintaining consistency. > > Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small allocations") > Signed-off-by: Muhammad Usama Anjum Looks good. I will apply. Thanks for your patch!

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Namjae Jeon
2021-04-01 21:50 GMT+09:00, Ralph Boehme : > Am 4/1/21 um 2:43 PM schrieb Namjae Jeon: >> 2021-04-01 20:50 GMT+09:00, Dan Carpenter : >>> On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote: >>>> kfree should be used to free memory allocated by kzal

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Namjae Jeon
2021-04-01 20:50 GMT+09:00, Dan Carpenter : > On Thu, Apr 01, 2021 at 04:39:33PM +0500, Muhammad Usama Anjum wrote: >> kfree should be used to free memory allocated by kzalloc to avoid >> any overhead and for maintaining consistency. >> >> Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small allocati

Re: [Linux-cifsd-devel] [PATCH] cifsd: use kfree to free memory allocated by kzalloc

2021-04-01 Thread Namjae Jeon
2021-04-01 22:14 GMT+09:00, Ralph Boehme : > Am 4/1/21 um 2:59 PM schrieb Namjae Jeon: >> 2021-04-01 21:50 GMT+09:00, Ralph Boehme : >>> fwiw, while at it what about renaming everything that still references >>> "cifs" to "smb" ? This is not the 90&

RE: [PATCH 30/32] Documentation: net: dsa: update configuration.rst reference

2021-04-01 Thread Namjae Jeon
> Em Thu, 1 Apr 2021 14:41:15 +0200 > Andrew Lunn escreveu: > > > On Thu, Apr 01, 2021 at 02:17:50PM +0200, Mauro Carvalho Chehab wrote: > > > The file name: Documentation/configuration.txt should be, instead: > > > Documentation/networking/dsa/configuration.rst. > > > > > > Update its cross-refe

RE: linux-next: build warning after merge of the cifsd tree

2021-03-17 Thread Namjae Jeon
Hi Stephen, > Hi all, > > After merging the cifsd tree, today's linux-next build (htmldocs) produced > this warning: > > Documentation/filesystems/cifs/cifsd.rst:3: WARNING: Title overline too short. > > = > CIFSD - SMB3 Kernel Server > = > Docum

RE: linux-next: build failure after merge of the cifsd tree

2021-03-17 Thread Namjae Jeon
Hi Stephen, > Hi all, > > After merging the cifsd tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > ld: fs/cifsd/misc.o:(.opd+0xc0): multiple definition of `extract_sharename'; > fs/cifs/unc.o:(.opd+0x18): > first defined here > ld: fs/cifsd/misc.o: in function `.extr

Re: [PATCH][next] cifsd: Fix a handful of spelling mistakes

2021-03-17 Thread Namjae Jeon
2021-03-17 18:36 GMT+09:00, Colin King : > From: Colin Ian King > > There are several spelling mistakes in various ksmbd_err and > ksmbd_debug messages. Fix these. > > Signed-off-by: Colin Ian King Applied. Thanks for your patch!

[GIT PULL] exfat update for 5.12-rc1

2021-02-21 Thread Namjae Jeon
. Hyeongseok Kim (1): exfat: improve performance of exfat_free_cluster when using dirsync mount option Namjae Jeon (1): exfat: fix shift-out-of-bounds in exfat_fill_super() fs/exfat/balloc.c| 4 ++-- fs/exfat/exfat_fs.h | 2 +- fs/exfat/exfat_raw.h | 4 fs/exfat

RE: [PATCH v2] exfat: Avoid allocating upcase table using kcalloc()

2020-12-06 Thread Namjae Jeon
> The table for Unicode upcase conversion requires an order-5 allocation, which > may fail on a highly- > fragmented system: > > pool-udisksd: page allocation failure: order:5, > mode:0x40dc0(GFP_KERNEL|__GFP_COMP|__GFP_ZERO), > nodemask=(null),cpuset=/,mems_allowed=0 > CPU: 4 PID: 3756880 Com

RE: UBSAN: shift-out-of-bounds in exfat_fill_super

2021-01-26 Thread Namjae Jeon
> On Mon, Jan 25, 2021 at 09:33:14AM -0800, syzbot wrote: > > UBSAN: shift-out-of-bounds in fs/exfat/super.c:471:28 shift exponent > > 4294967294 is too large for 32-bit type 'int' > > This is an integer underflow: > > sbi->dentries_per_clu = 1 << > (sbi->cluster_size_bits

RE: UBSAN: shift-out-of-bounds in exfat_fill_super

2021-01-26 Thread Namjae Jeon
> > On Mon, Jan 25, 2021 at 09:33:14AM -0800, syzbot wrote: > > > UBSAN: shift-out-of-bounds in fs/exfat/super.c:471:28 shift exponent > > > 4294967294 is too large for 32-bit type 'int' > > > > This is an integer underflow: > > > > sbi->dentries_per_clu = 1 << > > (sbi->clu

RE: UBSAN: shift-out-of-bounds in exfat_fill_super

2021-01-26 Thread Namjae Jeon
> On 1/25/21 10:39 AM, Matthew Wilcox wrote: > > On Mon, Jan 25, 2021 at 09:33:14AM -0800, syzbot wrote: > >> UBSAN: shift-out-of-bounds in fs/exfat/super.c:471:28 shift exponent > >> 4294967294 is too large for 32-bit type 'int' > > > > This is an integer underflow: > > > > sbi->dentries_p

Re: [PATCH v5 2/10] xfs: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

2014-02-23 Thread Namjae Jeon
2014-02-24 6:22 GMT+09:00, Dave Chinner : > On Wed, Feb 19, 2014 at 01:37:55AM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for XFS. >> >> The semantics of this flag are following: >> 1)

Re: [PATCH v6] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

2014-02-23 Thread Namjae Jeon
2014-02-23 2:09 GMT+09:00, Theodore Ts'o : > On Fri, Feb 21, 2014 at 12:07:41AM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for Ext4. >> >> The semantics of this flag are following:

Re: [PATCH v5 0/10] fs: Introduce new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate

2014-02-23 Thread Namjae Jeon
2014-02-24 9:57 GMT+09:00, Dave Chinner : > On Wed, Feb 19, 2014 at 01:37:16AM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> This patch series is in response of the following post: >> http://lwn.net/Articles/556136/ >> "ext4: introduce two new ioc

Re: [PATCH v6] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

2014-02-26 Thread Namjae Jeon
2014-02-27 1:48 GMT+09:00, Theodore Ts'o : > On Mon, Feb 24, 2014 at 10:22:10AM +0900, Namjae Jeon wrote: >> >> + ret = ext4_es_remove_extent(inode, punch_start, >> >> + EXT_MAX_BLOCKS - punch_start - 1); >> >> + if (r

[PATCH v4 0/6] fat: additions to support fat_fallocate

2014-03-02 Thread Namjae Jeon
From: Namjae Jeon This patch set provides support for doing fallocate operation on FAT filesystem. After series of review for the the feature The complete functionality is broken down into smaller subsets. v4: - ->i_disksize is aligned by block size in fill_inode. - use i_disksize w

[PATCH v4 3/6] fat: zero out seek range on _fat_get_block

2014-03-02 Thread Namjae Jeon
From: Namjae Jeon For normal buffered write operations, normally if we try to write to an offset > than file size, it does a cont_expand_zero till that offset. Now, in case of fallocated regions, since the blocks are already allocated. So, make it zero out that buffers for those blocks till

[PATCH v4 5/6] fat: permit to return phy block number by fibmap in fallocated region

2014-03-02 Thread Namjae Jeon
From: Namjae Jeon Make the fibmap call the return the proper physical block number for any offset request in the fallocated range. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/fat/cache.c | 64 ++ fs/fat/fat.h | 3

<    2   3   4   5   6   7   8   9   10   >