Re: mkfs.f2fs gets stuck with "blk_update_request: bio idx 0 >= vcnt 0" on 3.8

2013-04-06 Thread Namjae Jeon
2013/4/7, Max Filippov : > On Sun, Apr 7, 2013 at 4:36 AM, Namjae Jeon wrote: >> >> >> 2013/4/6 Max Filippov >>> >>> Hi Namjae, >>> >>> On Fri, Apr 5, 2013 at 11:57 AM, Namjae Jeon >>> wrote: >>> > Hi. Max. >>&g

Re: [PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem

2013-04-08 Thread Namjae Jeon
2013/4/9, Steven Rostedt : > On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> Add tracepoints in f2fs filesystem for tracing the filesystem >> operations for information/debugging purpose if needed. All the >> tracepoints are clubbe

Re: [PATCH] f2fs: move f2fs_balance_fs from truncate to punch_hole

2013-04-08 Thread Namjae Jeon
2013/4/9, Jason Hrycay : > From: Jason Hrycay > > Move the f2fs_balance_fs out of the truncate_hole function and only > perform that in punch_hole use case. The commit: > > ed60b1644e7f7e5dd67d21caf7e4425dff05dad0 > > intended to do this but moved it into truncate_hole to cover more > cases. H

Re: [PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem

2013-04-09 Thread Namjae Jeon
2013/4/9 Jaegeuk Kim : > 2013-04-09 (화), 10:04 +0900, Namjae Jeon: >> 2013/4/9, Steven Rostedt : >> > On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote: >> >> From: Namjae Jeon >> >> >> >> Add tracepoints in f2fs filesystem for tracing the

Re: [PATCH] Documentation: cfq-iosched: update documentation help for cfq tunnables

2013-04-09 Thread Namjae Jeon
2013/4/9 Jens Axboe : > On Sun, Mar 31 2013, Namjae Jeon wrote: >> From: Namjae Jeon >> >> Add the documentation text for latency, target_latency & group_idle >> tunnable parameters in the block/cfq-iosched.txt. >> Also fix few typo(spelling) mistakes. >

Re: [PATCH] f2fs: fix typo mistakes

2013-04-09 Thread Namjae Jeon
ping ? 2013/4/6 Namjae Jeon : > From: Namjae Jeon > > Fix typo mistakes. > 1. I think that it should be 'L' instead of 'V'. > 2. and try to fix 'Front' instead of 'Frone' > > Signed-off-by: Namjae Jeon > Signed-off-by: Amit Sah

Re: [PATCH RESEND v5] fat: editions to support fat_fallocate

2013-04-30 Thread Namjae Jeon
2013/4/29, OGAWA Hirofumi : > Namjae Jeon writes: > Hi OGAWA. > I couldn't review fully though. > >> +if (mmu_private_ideal < MSDOS_I(inode)->mmu_private && >> +filp->f_dentry->d_count == 1) >> +fat_truncate_blocks(i

Re: [PATCH RESEND v5] fat: editions to support fat_fallocate

2013-05-01 Thread Namjae Jeon
2013/5/1, OGAWA Hirofumi : > Namjae Jeon writes: > >> Hi OGAWA. > > Hi, > >>> I couldn't review fully though. >>> >>>> + if (mmu_private_ideal < MSDOS_I(inode)->mmu_private && >>>> + filp->f_dentry->

Re: [PATCH RESEND v5] fat: editions to support fat_fallocate

2013-05-01 Thread Namjae Jeon
2013/5/2, OGAWA Hirofumi : > Namjae Jeon writes: > >>>>> Hm, why d_count == 1 check is needed? Feel strange and racy. >>>> Since, fat_file_release() is called on every close for the file. >>> >>> What is wrong? IIRC, it is what you choose (i

Re: [PATCH RESEND v5] fat: editions to support fat_fallocate

2013-05-02 Thread Namjae Jeon
2013/5/2, OGAWA Hirofumi : > OGAWA Hirofumi writes: > >> Namjae Jeon writes: >> >>>> Then, per-file discard fallocate space sounds like wrong. fallocate >>>> space probably is inode attribute. >>> Since, our preallocation will not be persistent

Re: [PATCH RESEND v5] fat: editions to support fat_fallocate

2013-05-02 Thread Namjae Jeon
2013/5/2, OGAWA Hirofumi : > Namjae Jeon writes: > >>>> AFAIK, preallocation != fallocate. ext*'s preallocation was there at >>>> before fallocation to optimize block allocation for user data blocks. >> yes, this is correct , preallocation!= fallocate,

Re: [PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem

2013-04-23 Thread Namjae Jeon
l the gaps :) I checked all updated patches. Looks good to me ~. Thanks again. > > 2013-04-20 (토), 01:28 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> Add tracepoints in f2fs filesystem for tracing the filesystem >> operations for information/debugging purpose if ne

Re: [PATCH] block: fix max discard sectors limit

2013-04-23 Thread Namjae Jeon
2013/4/23, James Bottomley : > On Tue, 2013-04-23 at 22:06 +0900, Namjae Jeon wrote: >> From: Namjae Jeon > > Hey, it's very impolite to send a patch I just gave you as a suggestion > to fix the issue under your own authorship. > > What we need to know is has th

Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

2013-04-23 Thread Namjae Jeon
>>> >>> + if (type == META) >> >> Should be if (btype == META). >> Thanks, > Yes, Right :) > Thanks for fixing. Hi. Jaegeuk. Should I resend the fixed patch as above your comment ? Thanks. >> >>> + rw |= REQ_META; >>> + >>> if (sbi->bio[btype]) { >>> struct bio_private

[PATCH] block: fix max discard sectors limit

2013-04-24 Thread Namjae Jeon
io df3840c0, biotail df3848c0, buffer (null), len 1526726656 This patch fixes this issue. Reported-by: Max Filippov Signed-off-by: Namjae Jeon Signed-off-by: James Bottomley Tested-by: Max Filippov Cc: --- include/linux/blkdev.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [PATCH] f2fs: avoid frequent background GC

2013-04-24 Thread Namjae Jeon
Hi Jaegeuk, With the change in the value of GC_THREAD_NOGC_SLEEP_TIME to 60, we will need to rewrite the gc_thread_func(). As there will be several paths which will not be reached or will have no meaning after this change. Considering the cases: /* if return value is not zero, no victim was s

Re: [PATCH] f2fs: give a chance to merge IOs by IO scheduler

2013-04-24 Thread Namjae Jeon
[0] > ... > > Note that this issue should be addressed in checkpoint, and some readahead > flows too. > > Signed-off-by: Jaegeuk Kim Looks reasonable to me :) Reviewed-by: Namjae Jeon Thanks~ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v2] f2fs: avoid frequent background GC

2013-04-25 Thread Namjae Jeon
ere is no victim segments selected by background GC, let's wait > a little bit longer time to collect dirty segments. > By default, let's give 5 minutes. > > Signed-off-by: Jaegeuk Kim Looks good! Reviewed-by: Namjae Jeon Thanks~ -- To unsubscribe from this list: se

Re: [PATCH 1/3] f2fs: check nid == 0 in add_free_nid

2013-04-25 Thread Namjae Jeon
2013/4/25, Jaegeuk Kim : > It is more obvious that add_free_nid checks whether the free nid is zero or > not. > > Signed-off-by: Jaegeuk Kim Looks reasonable to me. Reviewed-by: Namjae Jeon Thanks~. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH 3/3] f2fs: enhnace alloc_nid and build_free_nids flows

2013-04-25 Thread Namjae Jeon
Jaegeuk Kim I can't find any issues in this patch. Reviewed-by: Namjae Jeon Thanks. > --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/3] f2fs: add a tracepoint on f2fs_new_inode

2013-04-25 Thread Namjae Jeon
2013/4/25, Jaegeuk Kim : > This can help when debugging the free nid allocation flows. > > Signed-off-by: Jaegeuk Kim Yes, Agreed also. Reviewed-by: Namjae Jeon Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[PATCH 1/2] f2fs: reorganize f2fs_vm_page_mkwrite

2013-04-27 Thread Namjae Jeon
From: Namjae Jeon Few things can be changed in the default mkwrite function 1) Make file_update_time at the start before acquiring any lock 2) the condition page_offset(page) >= i_size_read(inode) should be changed to page_offset(page) > i_size_read 3) Move wait_on_page_writeback. Sign

[PATCH 2/2] f2fs: wait for page writeback to provide stable pages

2013-04-27 Thread Namjae Jeon
From: Namjae Jeon When stable pages are required, we have to wait if the page is just going to disk and we want to modify it. Add proper callback to f2fs_vm_page_mkwrite. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat Cc: Darrick J. Wong --- fs/f2fs/file.c |2 +- 1 file

[PATCH] mmc: fix refcount leak in power_ro_lock_show

2013-04-27 Thread Namjae Jeon
From: Namjae Jeon when user does cat /sys/block/mmcblk0boot0/ro_lock_until_next_power_on power_ro_lock_show increments md->usage by calling mmc_blk_get but it forgets to call mmc_blk_put to restore md->usage Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- drivers/mm

[PATCH RESEND v5] fat: editions to support fat_fallocate

2013-04-27 Thread Namjae Jeon
From: Namjae Jeon Implement preallocation via the fallocate syscall on VFAT partitions. Change Log: v5: change to avoid compilation warning: fs/fat/inode.c: In function 'fat_zero_falloc_area': >> fs/fat/inode.c:169:11: warning: comparison of distinct pointer types lacks a

Re: [PATCH 1/2] f2fs: reorganize f2fs_vm_page_mkwrite

2013-04-29 Thread Namjae Jeon
2013/4/29, Jaegeuk Kim : > Hi, Hi. Jaegeuk. > > 2013-04-28 (일), 09:04 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> Few things can be changed in the default mkwrite function >> 1) Make file_update_time at the start before acquiring any lock >> 2) the con

Re: [PATCH -next] f2fs: fix error return code in f2fs_fill_super()

2013-04-11 Thread Namjae Jeon
y: Wei Yongjun Acked-by: Namjae Jeon Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 0/8] fix max discard sectors limit

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 (block: add plug for blkdev_issue_discard ) For example, 1) DISCARD rq-1 with size size 4GB 2) DISCARD rq-2 with size size 1GB If these 2 discard requests

[PATCH 1/8] block: fix max discard sectors limit

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon https://lkml.org/lkml/2013/4/1/292 As per above discussion, it has been oberved that few drivers are setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9) If multiple discard requests get merged, merged discard request's size exceeds 4GB, there

[PATCH 2/8] mmc: fix max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon https://lkml.org/lkml/2013/4/1/292 As per above discussion, there is possibility that request's __data_len field may overflow when max_discard_sectors greater than UINT_MAX >> 9 If multiple discard requests get merged, merged discard request's size excee

[PATCH 3/8] mtd: use generic helper to set max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH 4/8] loop: use generic helper to set max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH 5/8] nbd: use generic helper to set max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH 6/8] brd: use generic helper to set max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH 7/8] dm thin: use generic helper to set max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH 8/8] bcache: use generic helper to set max_discard_sectors

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon It is better to use blk_queue_max_discard_sectors helper function to set max_discard_sectors as it checks max_discard_sectors upper limit UINT_MAX >> 9 similar issue was reported for mmc in below link https://lkml.org/lkml/2013/4/1/292 If multiple discard requests get

[PATCH RESEND v4] fat: editions to support fat_fallocate

2013-04-13 Thread Namjae Jeon
From: Namjae Jeon Implement preallocation via the fallocate syscall on VFAT partitions. Change Log: v4: Rework based on review comments. Add check in fat_setattr to release fallocated blocks on a truncate v3: Release preallocated blocks at file release. With FALLOC_FL_KEEP_SIZE, there is no

Re: [PATCH 2/8] mmc: fix max_discard_sectors

2013-04-15 Thread Namjae Jeon
2013/4/15, Adrian Hunter : > On 13/04/13 16:38, Namjae Jeon wrote: >> From: Namjae Jeon >> >> https://lkml.org/lkml/2013/4/1/292 >> As per above discussion, there is possibility that request's __data_len >> field may overflow when max_discard_sectors greate

[PATCH 1/4] f2fs: push some variables to debug part

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon Some, counters are needed only for the statistical information while debugging. So, those can be controlled using CONFIG_F2FS_STAT_FS, pushing the usage for few variables under this flag. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/checkpoint.c

[PATCH 2/4] f2fs: remove unneeded initializations in f2fs_parent_dir

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon There is no need to initialize few pointers in f2fs_parent_dir as the values are not checked and instead directly initialized values are used. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/dir.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 3/4] f2fs: return proper error from start_gc_thread

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon when there is an error from kthread_run, then return proper error rather than returning -ENOMEM. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/gc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index

[PATCH 4/4] f2fs: optimize several routines in node.h

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon There are various functions with common code which could be separated out to make common routines. So, made new routines and in order to retain the same call path and no major changes, written some macros to access those routines. Signed-off-by: Namjae Jeon Signed-off-by

Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread

2013-05-23 Thread Namjae Jeon
2013/5/23, Jason Hrycay : > On 5/23/2013 8:58 AM, Namjae Jeon wrote: >> From: Namjae Jeon >> >> when there is an error from kthread_run, then return proper error >> rather than returning -ENOMEM. >> >> Signed-off-by: Namjae Jeon >> Signed-off-by:

[PATCH v2 1/2] f2fs: return proper error from start_gc_thread

2013-05-25 Thread Namjae Jeon
From: Namjae Jeon when there is an error from kthread_run, then return proper error rather than returning -ENOMEM. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/gc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/gc.c b/fs

[PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-25 Thread Namjae Jeon
From: Namjae Jeon Add sysfs entries to control the timing parameters for f2fs gc thread and also provide a control flag, which will allow the user to forcefully start a FG garbage collection if required. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/f2fs.h |6

Re: [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-26 Thread Namjae Jeon
2013/5/27, Jaegeuk Kim : > Hi Namjae, Hi Jaegeuk. First, Thanks for your interest. > > This is an interesting functionality. > Could you describe why and when we need to do this? > What are pros and cons? > How can we use this? As the default size of the F2FS parameter can vary as per the storage

Re: [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-28 Thread Namjae Jeon
2013/5/28, Jaegeuk Kim : > Hi, > > 2013-05-27 (월), 13:45 +0900, Namjae Jeon: >> 2013/5/27, Jaegeuk Kim : >> > Hi Namjae, >> Hi Jaegeuk. >> >> First, Thanks for your interest. >> > >> > This is an interesting functionality. >> > C

Re: [PATCH 2/4] f2fs: do not skip writing file meta during fsync

2013-03-26 Thread Namjae Jeon
2013/3/27, Jaegeuk Kim : > 2013-03-26 (화), 09:48 +0900, Namjae Jeon: >> 2013/3/25, Jaegeuk Kim : >> > This patch removes data_version check flow during the fsync call. >> > The original purpose for the use of data_version was to avoid writng >> > inode >&

Re: [PATCH 2/4] f2fs: do not skip writing file meta during fsync

2013-03-26 Thread Namjae Jeon
2013/3/27, Jaegeuk Kim : > 2013-03-27 (수), 09:57 +0900, Namjae Jeon: >> 2013/3/27, Jaegeuk Kim : >> > 2013-03-26 (화), 09:48 +0900, Namjae Jeon: >> >> 2013/3/25, Jaegeuk Kim : >> >> > This patch removes data_version check flow during the fsync call

Re: [PATCH 4/4] f2fs: fix to give correct parent inode number for roll forward

2013-03-26 Thread Namjae Jeon
> */ > -static inline void set_cold_file(struct f2fs_sb_info *sbi, struct inode > *inode, > +static inline void set_cold_files(struct f2fs_sb_info *sbi, struct inode > *inode, > const unsigned char *name) > { > int i; > @@ -108,7 +109,7 @@ static inline void set_cold_file(str

Re: [PATCH] fs: f2fs: Use kmemdup

2013-03-27 Thread Namjae Jeon
2013/3/28, Alexandru Gheorghiu : > Used kmemdup instead of kzalloc followed by memcpy. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu > --- > fs/f2fs/segment.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment

Re: [PATCH] fs: f2fs: Use kmemdup

2013-03-27 Thread Namjae Jeon
2013/3/28, Alexandru Gheorghiu : > Used kmemdup instead of kzalloc and memcpy. > > Signed-off-by: Alexandru Gheorghiu > --- > fs/f2fs/node.c| 11 --- > fs/f2fs/segment.c |3 +-- > 2 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c >

Re: [PATCH] fs: f2fs: Use kmemdup

2013-03-28 Thread Namjae Jeon
2013/3/28, Alexandru Gheorghiu : > Use kmemdup instead of kzalloc and memcpy. > > Signed-off-by: Alexandru Gheorghiu Looks good to me. Acked-by: Namjae Jeon Thanks~ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

[PATCH v4] fat: editions to support fat_fallocate

2013-03-30 Thread Namjae Jeon
From: Namjae Jeon Implement preallocation via the fallocate syscall on VFAT partitions. Change Log: v4: Rework based on review comments. Add check in fat_setattr to release fallocated blocks on a truncate v3: Release preallocated blocks at file release. With FALLOC_FL_KEEP_SIZE, there is no

[PATCH] f2fs-tools: mkfs: fix to avoid format of device when already mounted

2013-03-30 Thread Namjae Jeon
From: Namjae Jeon In case of embedded devices, where /etc/ is mounted as 'read-only'. We donot have the /etc/mtab file. So, checking if the device is already mounted from this file is not sufficient. Try to read /proc/mounts in case of failure from /etc/mtab. Issue logs: /dev/sdb4 /m

[PATCH] Documentation: cfq-iosched: update documentation help for cfq tunnables

2013-03-30 Thread Namjae Jeon
From: Namjae Jeon Add the documentation text for latency, target_latency & group_idle tunnable parameters in the block/cfq-iosched.txt. Also fix few typo(spelling) mistakes. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- Documentation/block/cfq-iosched.txt |

[PATCH v3] fat: editions to support fat_fallocate

2013-03-07 Thread Namjae Jeon
From: Namjae Jeon Implement preallocation via the fallocate syscall on VFAT partitions. Change Log: v3: Release preallocated blocks at file release. With FALLOC_FL_KEEP_SIZE, there is no way to distinguish if the mismatch between i_size and no. of clusters allocated is a consequence of

Re: [PATCH 3/5] f2fs: move f2fs_balance_fs to correct place in unlink

2013-03-07 Thread Namjae Jeon
2013/3/8, Jaegeuk Kim : > 2013-03-04 (월), 15:10 +0900, Namjae Jeon: >> 2013/3/3, Jaegeuk Kim : >> > 2013-03-02 (토), 12:41 +0900, Namjae Jeon: >> >> From: Namjae Jeon >> >> >> >> Actual dirty of pages will occur in f2fs_delete_entry

Re: [PATCH 4/5] f2fs: align f2fs maximum name length to linux based filesystem

2013-03-07 Thread Namjae Jeon
2013/3/8, Jaegeuk Kim : > 2013-03-04 (월), 15:25 +0900, Namjae Jeon: >> 2013/3/3, Jaegeuk Kim : >> > We should not change the on-disk layout. >> > Instead, simply we can deal with it by changing original condition >> > check >> > like below. >> &

Re: [PATCH v3] fat: editions to support fat_fallocate

2013-03-11 Thread Namjae Jeon
Hi. Andrew. >> >> static int fat_file_release(struct inode *inode, struct file *filp) >> { >> +struct super_block *sb = inode->i_sb; >> +loff_t mmu_private_ideal = (inode->i_size + (sb->s_blocksize-1)) & >> +~(sb->s_blocksize-1); > > Stylistically, it looks

Re: [PATCH v3] fat: editions to support fat_fallocate

2013-03-11 Thread Namjae Jeon
2013/3/9, OGAWA Hirofumi : > Namjae Jeon writes: > >> static int fat_file_release(struct inode *inode, struct file *filp) >> { >> +struct super_block *sb = inode->i_sb; >> +loff_t mmu_private_ideal = (inode->i_size + (sb->s_blocksize-1)) &am

Re: [PATCH v3] fat: editions to support fat_fallocate

2013-03-12 Thread Namjae Jeon
2013/3/12, OGAWA Hirofumi : > Namjae Jeon writes: > >>> This choose ->release(). BTW, we would also be able to do this only >>> ->evict_inode(), although I'm not thinking yet which one is better. >>> >>> If you had conclusion, it would be nic

Re: [PATCH v3] fat: editions to support fat_fallocate

2013-03-12 Thread Namjae Jeon
2013/3/12, OGAWA Hirofumi : > Namjae Jeon writes: > >>> If so, probably, I didn't clear my opinion/suggestion, or misled >>> you. Sorry about it. >>> >>> My opinion/suggestion is, "it should be before umount()". >>> I.e. fallocate

Re: [PATCH v4 00/17] vfs: add the ability to retry on ESTALE to several syscalls

2012-07-31 Thread Namjae Jeon
2012/7/27, Jeff Layton : > On Fri, 27 Jul 2012 11:15:23 +0900 > Namjae Jeon wrote: > >> Hi Jeff. >> >> Which testcase(or test method) do I use to know improved point from >> ESTALE error ? >> I want to know before & after using testcase with this patch-

[PATCH 1/3] Documentation: update missing index files in block/00-INDEX

2012-08-04 Thread Namjae Jeon
Update missing index files in block/00-INDEX. Signed-off-by: Namjae Jeon --- Documentation/block/00-INDEX | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/block/00-INDEX b/Documentation/block/00-INDEX index d111e3b..d18ecd8 100644 --- a

[PATCH 3/3] Documentation: update sysfs files in block/queue-sysfs.txt

2012-08-04 Thread Namjae Jeon
Update sysfs files in block/queue-sysfs.txt Signed-off-by: Namjae Jeon --- Documentation/block/queue-sysfs.txt | 64 +++ 1 file changed, 64 insertions(+) diff --git a/Documentation/block/queue-sysfs.txt b/Documentation/block/queue-sysfs.txt index d8147b3

[PATCH 2/3] Documentation: update tunable options in block/cfq-iosched.txt

2012-08-04 Thread Namjae Jeon
Update tunable options in block/cfq-iosched.txt. Signed-off-by: Namjae Jeon --- Documentation/block/cfq-iosched.txt | 77 +++ 1 file changed, 77 insertions(+) diff --git a/Documentation/block/cfq-iosched.txt b/Documentation/block/cfq-iosched.txt index 6d670f5

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-21 Thread Namjae Jeon
2012/8/21, Fengguang Wu : > On Tue, Aug 21, 2012 at 03:00:13PM +0900, Namjae Jeon wrote: >> 2012/8/20, Fengguang Wu : >> > On Mon, Aug 20, 2012 at 09:48:42AM +0900, Namjae Jeon wrote: >> >> 2012/8/19, Fengguang Wu : >> >> > On Sat, Aug 18, 2012 at 05:50

Re: [PATCH RESEND] udf: extent cache implementation for manipulating block map

2012-08-22 Thread Namjae Jeon
2012/8/21, Jan Kara : > Hello, > > first, I'm sorry for a late reply. I was on a long vacation and then it > took me a while to catch up with stuff. > > On Sat 18-08-12 05:58:22, Namjae Jeon wrote: >> From: Namjae Jeon >> >> While mapping logical b

Re: [PATCH RESEND] udf: extent cache implementation for manipulating block map

2012-08-22 Thread Namjae Jeon
2012/8/22, Jan Kara : > On Wed 22-08-12 19:02:26, Namjae Jeon wrote: >> 2012/8/21, Jan Kara : >> Hi. Jan. >> Okay, We are trying to do it from your comment. >> 1. Change udf_ext_cache structure to following which would also include >> *bh. >> struct udf_ext_

Re: [PATCH 1/3] writeback: change nr_pages_dirtied argument into local variable

2012-08-23 Thread Namjae Jeon
2012/8/19, Fengguang Wu : > On Sat, Aug 18, 2012 at 05:48:29AM -0400, Namjae Jeon wrote: >> There is no reason nr_pages_dirtied is argument anymore. >> because nr_pages_dirtied value from caller is not used in >> balance_dirty_pages_ratelimited_nr function. > >

[PATCH 1/2] fat: kill unused macros

2012-08-25 Thread Namjae Jeon
Remove unused macros. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- include/linux/msdos_fs.h | 12 1 file changed, 12 deletions(-) diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h index 11cc2ac..be3dc72 100644 --- a/include/linux/msdos_fs.h +++ b

[PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

2012-08-25 Thread Namjae Jeon
#define FAT_ENT_EOF(EOF_FAT32) there is no need to reset value of 'new' for FAT32 as the values is already correct Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/fat/fatent.c |2 -- 1 file changed, 2 deletions(-) diff --git a/fs/fat/fatent.c b/fs/fat/fate

[PATCH 3/3] fat: simplify writeback_inode function.

2012-08-25 Thread Namjae Jeon
Simplify writeback_inode function. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/fat/inode.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 973296b..4bbb24e 100644 --- a/fs/fat/inode.c +++ b/fs/fat

[PATCH] writeback: backing-dev: replace simple_strtoul to kstrto*

2012-08-25 Thread Namjae Jeon
fix checkpatch warnings: WARNING: consider using kstrto* in preference to simple_strtoul for below sys entry parsers: /sys/block//bdi/read_ahead_kb /sys/block//bdi/max_ratio /sys/block//bdi/min_ratio Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- mm/backing-dev.c | 50

Re: [PATCH 1/2] fat: kill unused macros

2012-08-26 Thread Namjae Jeon
2012/8/26, OGAWA Hirofumi : > Namjae Jeon writes: > >> Remove unused macros. > > Those are for userland. Are you sure userland doesn't use those anymore? Hi. OGAWA. I missed this point. I will repost if I can be sure. Thanks a lot. > >> Signed-off-by: Namjae Jeon

Re: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32

2012-08-26 Thread Namjae Jeon
2012/8/26, OGAWA Hirofumi : > Namjae Jeon writes: > >> #define FAT_ENT_EOF(EOF_FAT32) >> >> there is no need to reset value of 'new' for FAT32 as the values is >> already correct >> >> Signed-off-by: Namjae Jeon >> Signed-off-by: Amit

[PATCH 1/2] writeback: add dirty_background_time per bdi variable

2012-08-27 Thread Namjae Jeon
From: Namjae Jeon This patch is based on suggestion by Wu Fengguang: https://lkml.org/lkml/2011/8/19/19 kernel has mechanism to do writeback as per dirty_ratio and dirty_background ratio. It also maintains per task dirty rate limit to keep balance of dirty pages at any given instance by doing

[PATCH 2/2] Documentation: add description of dirty_background_time

2012-08-27 Thread Namjae Jeon
From: Namjae Jeon This commit adds dirty_background_time description in bdi sysfs documentation. Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- Documentation/ABI/testing/sysfs-class-bdi | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/ABI

[PATCH v3 0/5] fat: make persistent inode numbers and stablize for NFS.

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon This patch-set eliminates the client side ESTALE errors when a FAT partition exported over NFS has its dentries evicted from the cache. One of the reasons for this error is lack of permanent inode numbers on FAT which makes it difficult to construct persistent file handles

[PATCH v3 1/5] fat: modify nfs mount option

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon Provide two possible values 'full_unstable' and 'limited_stable' for the -o nfs mount option.The first one allows all file operations but does not reduce ESTALE errors on memory constrained systems. The second one eliminates ESTALE errors but mounts the fil

[PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon All the files on a FAT partition have an on-disk directory entry. The location of these entries, i_pos, is unique and is constructed by the fat_make_i_pos() function.We can use this as the inode number making it persistent across remounts. Signed-off-by: Namjae Jeon Signed

[PATCH v3 3/5] fat (exportfs): rebuild inode if ilookup() fails

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon Since the previous patch in this patch-set uses i_pos as the inode number, we can use it to find the directory entry of the inode and subsequently rebuild the inode if the cache lookups fail. Since this involves accessing the FAT media,it is better to do this only if the 

[PATCH v3 4/5] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon This patch enables rebuilding of directory inodes which are not present in the cache.This is done by traversing the disk clusters to find the directory entry of the parent directory and using its i_pos to build the inode. Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar

[PATCH v3 5/5] Documentation: update nfs option in filesystem/vfat.txt

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon update nfs option in filesystem/vfat.txt Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar N Signed-off-by: Amit Sahrawat --- Documentation/filesystems/vfat.txt | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/Documentation

[PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon This patch is based on suggestion by Wu Fengguang: https://lkml.org/lkml/2011/8/19/19 kernel has mechanism to do writeback as per dirty_ratio and dirty_background ratio. It also maintains per task dirty rate limit to keep balance of dirty pages at any given instance by doing

[PATCH v3 2/2] Documentation: add description of dirty_background_centisecs

2012-09-16 Thread Namjae Jeon
From: Namjae Jeon This commit adds dirty_background_centisecs description in bdi sysfs documentation. Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi --- Documentation/ABI/testing/sysfs-class-bdi | 25 + 1 file changed, 25 insertions(+) diff --git a

Re: [PATCH v3 0/5] fat: make persistent inode numbers and stablize for NFS.

2012-09-17 Thread Namjae Jeon
2012/9/17 OGAWA Hirofumi : > Namjae Jeon writes: > >> From: Namjae Jeon >> >> This patch-set eliminates the client side ESTALE errors when a FAT partition >> exported over NFS has its dentries evicted from the cache. >> >> One of the reasons for this e

Re: [PATCH v3 5/5] Documentation: update nfs option in filesystem/vfat.txt

2012-09-17 Thread Namjae Jeon
2012/9/17, J. Bruce Fields : > On Sun, Sep 16, 2012 at 08:23:20AM -0400, Namjae Jeon wrote: >> From: Namjae Jeon >> >> update nfs option in filesystem/vfat.txt >> >> Signed-off-by: Namjae Jeon >> Signed-off-by: Ravishankar N >> Signed-off-by: Amit S

Re: [PATCH v5 00/19] vfs: add the ability to retry on ESTALE to several syscalls

2012-08-09 Thread Namjae Jeon
Hi Jeff. I still found ESTALE error although patching these patch-set. Is test method correct that I try to run estale_test on each nfs server and client at the same time ? ./estale_test chmod: Stale NFS[ 281.72] # send signal from USER, SIG : 2, estale_test(107)->estale_test(102) sys_ki

[PATCH] fat: use accessor function for msdos_dir_entry 'start'

2012-08-11 Thread Namjae Jeon
Use accessor function for msdos_dir_entry 'start' Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/fat/dir.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/fat/dir.c b/fs/fat/dir.c index 7b1b9c1..2f3e66e 100644 --- a/fs/fat/dir.c ++

Re: [PATCH] udf: extent cache implementation for manipulating block map

2012-08-11 Thread Namjae Jeon
Hi Jan. Would you check this patch if you return from vacation ? Thanks. 2012/7/29, Namjae Jeon : > From: Namjae Jeon > > While mapping logical blocks of a file to physical blocks on the partition, > everytime UDF read file metadata from the begining which decrease > pre

Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize

2012-08-11 Thread Namjae Jeon
ng rescan. > > Signed-off-by: Ashish Sangwan > Signed-off-by: Namjae Jeon > > --- > fs/udf/super.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/udf/super.c b/fs/udf/super.c > index ac8a348..4a95c56 100644 > --- a/fs/udf/super.c &

Re: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Namjae Jeon
Hi. Ian. known issue ? Would you explain more ? Thanks. 2012/8/13 IAN CHEN : > From 5c60eb8be04c7440d6e33b8f72ea2046a3657ac4 Mon Sep 17 00:00:00 2001 > From: ian.cy.chen > Date: Mon, 13 Aug 2012 10:53:55 +0900 > Subject: [PATCH] mmc: card: Skip secure option for MoviNAND. > > For several MoviNA

Re: [PATCH] mmc: card: Skip secure option for MoviNAND.

2012-08-13 Thread Namjae Jeon
s/21pTYfTsCkB > > Regards, > Ian > > -Original Message- > From: Namjae Jeon [mailto:linkinj...@gmail.com] > Sent: Monday, August 13, 2012 10:03 PM > To: IAN CHEN > Cc: c...@laptop.org; adrian.hun...@intel.com; subha...@codeaurora.org; > linus.wall...@linaro.org;

Re: [PATCH v3] mmc: card: Skip secure option for MoviNAND.

2012-08-14 Thread Namjae Jeon
://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB > > Signed-off-by: Ian Chen > --- Looks good. Reviewed-by: Namjae Jeon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

[PATCH 0/4] fat: fix ESTALE errors

2012-08-18 Thread Namjae Jeon
From: Namjae Jeon This patch-set eliminates the client side ESTALE errors when a FAT partition exported over NFS has its dentries evicted from the cache. One of the reasons for this error is lack of permanent inode numbers on FAT which makes it difficult to construct persistent file

[PATCH 2/4] fat (exportfs): rebuild inode if ilookup() fails

2012-08-18 Thread Namjae Jeon
From: Namjae Jeon Since the previous patch in this patch-set uses i_pos as the inode number, we can use it to find the directory entry of the inode and subsequently rebuild the inode if the cache lookups fail. Since this involves accessing the FAT media,it is better to do this only if the 

[PATCH 1/4] fat: allocate persistent inode numbers

2012-08-18 Thread Namjae Jeon
From: Namjae Jeon All the files on a FAT partition have an on-disk directory entry. The location of these entries, i_pos, is unique and is constructed by the fat_make_i_pos() function.We can use this as the inode number making it peristent across remounts. Signed-off-by: Namjae Jeon Signed-off

[PATCH 3/4] fat (exportfs): rebuild directory-inode if fat_dget()

2012-08-18 Thread Namjae Jeon
From: Namjae Jeon This patch enables rebuilding of directory inodes which are not present in the cache.This is done by traversing the disk clusters to find the directory entry of the parent directory and using its i_pos to build the inode. Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar

<    1   2   3   4   5   6   7   8   9   10   >