On Thu, Jun 27, 2013 at 04:54:05PM +0300, Mika Westerberg wrote:
> I think that we can get this working so that we add a new flag to struct
> pci_dev, something like 'no_additional_hotplug_bus_space' and in this quirk
> set that.
>
> Then in __pci
On Thu, Jun 27, 2013 at 04:02:29PM +0300, Mika Westerberg wrote:
> On Wed, Jun 26, 2013 at 05:37:58PM -0600, Bjorn Helgaas wrote:
> > > @@ -707,8 +702,11 @@ static int __ref enable_device(struct acpiphp_slot
> > > *slot)
> > > dev->hd
On Thu, Jun 27, 2013 at 02:27:01PM +0200, Rafael J. Wysocki wrote:
> Hi All,
>
> Below is a summary of my current queue for the v3.11 merge window.
>
> I will be very reluctant to add anything that is not a fix for a serious
> problem to it from now on. If you have such a fix, please let me know
On Thu, Jun 27, 2013 at 09:15:50PM +0200, Rafael J. Wysocki wrote:
> On Thursday, June 27, 2013 10:08:42 PM Mika Westerberg wrote:
> > On Thu, Jun 27, 2013 at 02:27:01PM +0200, Rafael J. Wysocki wrote:
> > > Hi All,
> > >
> > > Below is a summary of my curr
On Fri, Jun 28, 2013 at 11:43:07AM -0700, H Hartley Sweeten wrote:
> This driver supports 16 to 4 bits per work. Set the bits_per_word_mask
> to allows the spi core to handle validation.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Mika Westerberg
> Cc: Ma
set it appropriately for each transfer.
> >
> > Signed-off-by: H Hartley Sweeten
> > Cc: Ryan Mallon
> > Cc: Mika Westerberg
> > Cc: Mark Brown
> > Cc: Grant Likely
> > ---
> > drivers/spi/spi-ep93xx.c | 16 +---
> > 1 file c
>
> Just pass the t->bits_per_word directly to ep93xx_spi_chip_setup() in
> ep93xx_spi_process_transfer() and remove 'dss' from the per chip private
> data.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Mika Westerberg
> Cc: Mark Brown
>
PI
> device.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Mika Westerberg
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:/
Cc: Ryan Mallon
> Cc: Mika Westerberg
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
eason
> keep them in the per chip data.
>
> Move the ep93xx_spi_calc_divisors() call into ep93xx_spi_chip_setup()
> and return the dividers thru pointers. Remove the divider values from
> the per chip data structure.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
&g
On Fri, Jun 28, 2013 at 11:45:56AM -0700, H Hartley Sweeten wrote:
> The SPI core provides infrastructure for standard message queueing. Use
> that instead of handling it in the driver.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Mika Westerberg
> Cc: Ma
On Fri, Jun 28, 2013 at 08:54:45PM +0200, Rafael J. Wysocki wrote:
> On Friday, June 28, 2013 11:00:31 AM Bjorn Helgaas wrote:
> > On Fri, Jun 28, 2013 at 3:51 AM, Kirill A. Shutemov
> > wrote:
> > > Bjorn Helgaas wrote:
> > >> On Tue, Jun 25, 2013 at 10:
On Sat, Mar 23, 2013 at 01:57:01PM -0400, Corey Richardson wrote:
> With the attached config, I get the following build failure:
>
> LD init/built-in.o
> drivers/built-in.o:clk-lpt.c:function v4l2_device_unregister: error:
> undefined reference to 'i2c_unregister_device'
I get following wi
On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> Without MODULE_LICENSE set, I get the following with modprobe:
>
> acpi_i2c: module license 'unspecified' taints kernel.
> acpi_i2c: Unknown symbol i2c_new_device (err 0)
> acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
>
Sorry for the slooow response, I've been on vacation.
On Tue, Jul 16, 2013 at 01:16:18PM +0200, Christian Ruppert wrote:
> > Second step is that if current i2c_dw_scl_hcnt and i2c_dw_scl_lcnt
> > calculations don't suit with later DW I2C cores, then it would be
> > nice for someone who can access
],
ACPI requires [Package] (20130517/nsarguments-95)
Fix this by passing an empty package to the _DSM method. The HID over I2C
specification doesn't require any specific values to be passed with this
parameter.
Signed-off-by: Mika Westerberg
---
drivers/hid/i2c-hid/i2c-hid.c | 5 +++--
1
On Fri, Aug 16, 2013 at 11:15:12AM +0900, Shinya Kuribayashi wrote:
> >Actually, the I2C specification clearly defines f_SCL;max (and thus
> >implies t_SCL;min), both in the tables and the timing diagrams. Why can
> >we ignore this constraint while having to meet all the others?
>
> If we meet t_r
makes it possible for the platform code to pass more optimal
HCNT/LCNT values to the core driver if they are known beforehand. If these
are not set we use the calculated and more conservative values.
Signed-off-by: Mika Westerberg
---
Changes to the previous version:
* Updated changelog
* Reduce
structure for core to use.
Signed-off-by: Mika Westerberg
---
Changes to the previous version:
* Combined SDA hold time and *CNT value setting to be in a single patch
drivers/i2c/busses/i2c-designware-platdrv.c | 34 +
1 file changed, 34 insertions(+)
diff --git a
On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > On Monday, August 19, 2013 09:
On Tue, Aug 20, 2013 at 01:00:08AM -0700, Jerry Snitselaar wrote:
> On Tue Aug 20 13, Mika Westerberg wrote:
> > On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > On Monday, August 19, 2013 04:3
On Tue, Aug 20, 2013 at 11:14:42AM +0300, Mika Westerberg wrote:
> On Tue, Aug 20, 2013 at 01:00:08AM -0700, Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Mika Westerberg wrote:
> > > On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > > > On Tu
me but I don't know the HW details. Anyway, I reviewed
the code so:
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
hen?
Here is the ACPI version based on the current patch from Wolfram (there is
a compile error because of missing dummy implementation of
of_i2c_register_devices())
From: Mika Westerberg
Subject: [PATCH] i2c: move ACPI helpers into the core
This follows what has already been done for the D
On Tue, Aug 20, 2013 at 01:47:57AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Bad things happen if ACPI hotplug events are handled during system
> PM transitions, especially if devices are removed as a result.
> To prevent those bad things from happening, acquire acpi_scan_lock
ASK(4, 32);
^
This is due the fact that when the max range is specified as 32
SPI_BIT_MASK() expands to ~0UL which doesn't fit to the u32 type that the
master->bits_per_word_mask is.
Fix this by using ~0U instead.
Signed-off-by: Mika Westerberg
---
include/linux/spi/spi.h | 2 +-
1 f
I2C controller device. The
adapter device is handled along with the I2C controller device (it uses
pm_runtime_no_callbacks()).
Signed-off-by: Aaron Lu
Signed-off-by: Mika Westerberg
---
drivers/i2c/i2c-core.c | 48 +++-
1 file changed, 47 insertions(
that's the case, attach it to the ACPI power domain. In
addition we make sure that the device is fully powered when its ->probe()
function gets called.
For non-ACPI devices this patch is a no-op.
Signed-off-by: Lv Zheng
Signed-off-by: Mika Westerberg
---
drivers/i2c/i2c-core.c | 9
Hi all,
With the advent of ACPI 5.0 we are starting to see I2C client devices
described in ACPI namespace that support power management by the means of
standard ACPI _PSx-methods. For example Intel Haswell based platforms might
have touch screen or sensor-hub connected to the I2C bus that can be
p
On Tue, Aug 20, 2013 at 10:37:34AM -0600, Stephen Warren wrote:
> On 08/20/2013 06:15 AM, Mika Westerberg wrote:
> > When building a 64-bit kernel we get the following warning from the
> > compiler:
> >
> > drivers/spi/spi-pxa2xx.c: In function ‘pxa2xx_spi_probe’:
&g
On Tue, Aug 20, 2013 at 04:30:43PM +0200, Wolfram Sang wrote:
> On Tue, Aug 20, 2013 at 12:28:13PM +0300, Mika Westerberg wrote:
> > [Added Jerry as he found out a problem when acpi_i2c is being build as a
> > module, this should solve it as well.]
> >
> > On Tue, Aug 2
comprehensive anyway.
>
> Signed-off-by: Andy Shevchenko
> Cc: Mika Westerberg
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.
ff-by: Mika Westerberg
Acked-by: Rafael J. Wysocki
---
This is rebased on top of Wolfram's V2 patch here:
http://marc.info/?l=linux-acpi&m=137709287521491&w=2
Changed to use #if IS_ENABLED(CONFIG_ACPI) as is done in the DeviceTree
version.
Documentation/acpi/enumeration.
The function returns 0 on success and negative errno in case of failure.
Fix this.
Signed-off-by: Mika Westerberg
---
drivers/spi/spi-pxa2xx-pci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
index 364964d
Intel LPSS SPI controllers need to have bit 0 (disable_ssp_dma_finish) set
in SSP_REG in order to properly perform DMA transfers spanning over
multiple blocks.
Signed-off-by: Mika Westerberg
---
drivers/spi/spi-pxa2xx.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/spi/spi
ACPI Timer() opcode should return monotonically increasing clock with 100ns
granularity. Implement this with the help of ktime_get().
Signed-off-by: Mika Westerberg
---
drivers/acpi/osl.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/acpi/osl.c b
pointer from integer
without a cast [enabled by default]
Fix this by returning NULL as it was done previously (error printing is
already done by devm_ioremap_resource()).
Signed-off-by: Mika Westerberg
Cc: Sachin Kamat
---
drivers/spi/spi-pxa2xx.c |2 +-
1 file changed, 1 insertion(+), 1
Now that we have these nice DMA API helper functions we can take advantage
of those instead of open-coding the channel/request line extraction from
ACPI. Use the _compat version which still allows passing the
channel/request line from platform data.
Signed-off-by: Mika Westerberg
---
drivers
Intel BayTrail has one general purpose SPI controller that is compatible
with Intel Low Power Subsystem SPI. The controller is enumerated from ACPI
namespace with ACPI ID 80860F0E.
Signed-off-by: Mika Westerberg
---
drivers/spi/spi-pxa2xx.c |1 +
1 file changed, 1 insertion(+)
diff --git a
detected bit in its status register causing the driver to fail
subsequent transfers.
Fix this by always clearing all interrupts before we start a transfer.
Signed-off-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-core.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
This is the same controller as on Intel Lynxpoint but the ACPI ID is
different (8086F41). Add support for this.
Signed-off-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-platdrv.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
b
If the device is using autosuspend we should honor that and call
pm_runtime_autosuspend() instead of pm_runtime_suspend(). Failing to do so
causes the device to be suspended immediately even though it expects to be
suspended only when the autosuspend delay is expired.
Signed-off-by: Mika
On Mon, May 13, 2013 at 01:38:46PM +0200, Rafael J. Wysocki wrote:
> On Monday, May 13, 2013 01:27:51 PM Mika Westerberg wrote:
> > ACPI Timer() opcode should return monotonically increasing clock with 100ns
> > granularity. Implement this with the help of ktime_get().
> >
&g
.
Signed-off-by: Mika Westerberg
---
drivers/acpi/acpi_lpss.c | 88 +
drivers/clk/x86/clk-lpt.c |4 +--
2 files changed, 82 insertions(+), 10 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 652fd5c..f6d7605 100644
On Tue, Apr 09, 2013 at 12:59:54PM +0200, Christian Ruppert wrote:
> This patch makes the SDA hold time configurable through device tree.
>
> Signed-off-by: Christian Ruppert
> Signed-off-by: Pierrick Hascoet
Hi Wolfram,
What happened to this patch? I don't see it merged for 3.10.
The reason
Hi Wolfram,
Any comments on this series? Could you consider merging these for 3.10?
Thanks.
On Thu, Mar 21, 2013 at 02:09:54PM +0200, Mika Westerberg wrote:
> From: Andy Shevchenko
>
> This makes the error handling much more simpler than open-coding everything
> and in additi
On Tue, Apr 09, 2013 at 11:00:32AM +0200, Wolfram Sang wrote:
>
> > @@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev)
> > return irq; /* -ENXIO */
> > }
> >
> > - ioarea = request_mem_region(mem->start, resource_size(mem),
> > - pdev-
On Tue, Apr 09, 2013 at 11:06:05AM +0200, Wolfram Sang wrote:
> On Thu, Mar 21, 2013 at 02:09:57AM -0000, Mika Westerberg wrote:
> > It is not good idea to mix static and dynamic I2C adapter numbering. In
> > this particular case on Lynxpoint we had graphics I2C adapter which too
On Tue, Apr 09, 2013 at 11:09:14AM +0200, Wolfram Sang wrote:
>
> > +static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable)
> > +{
> > + int timeout = 100;
> > +
> > + do {
> > + dw_writel(dev, enable, DW_IC_ENABLE);
> > + if ((dw_readl(dev, DW_IC_ENABLE_STATUS) &
On Tue, Apr 09, 2013 at 11:29:24AM +0200, Wolfram Sang wrote:
> On Tue, Apr 09, 2013 at 12:23:19PM +0300, Mika Westerberg wrote:
> > On Tue, Apr 09, 2013 at 11:06:05AM +0200, Wolfram Sang wrote:
> > > On Thu, Mar 21, 2013 at 02:09:57AM -0000, Mika Westerberg wrote:
> > &g
On Tue, Apr 09, 2013 at 11:28:57AM +0200, Wolfram Sang wrote:
> On Tue, Apr 09, 2013 at 12:28:36PM +0300, Mika Westerberg wrote:
> > On Tue, Apr 09, 2013 at 11:09:14AM +0200, Wolfram Sang wrote:
> > >
> > > > +static void __i2c_dw_enable(struc
On Tue, Apr 09, 2013 at 03:57:25PM +0200, Rafael J. Wysocki wrote:
> +void acpi_gpiochip_free_interrupts(struct gpio_chip *chip)
> +{
> + acpi_handle handle;
> + acpi_status status;
> + struct list_head *evt_pins;
> + struct acpi_gpio_evt_pin *evt_pin, *ep;
> +
> + if (!chip->de
On Wed, Apr 10, 2013 at 11:17:57AM +0300, Mathias Nyman wrote:
> On 04/10/2013 10:53 AM, Mika Westerberg wrote:
> >On Tue, Apr 09, 2013 at 03:57:25PM +0200, Rafael J. Wysocki wrote:
> >>+void acpi_gpiochip_free_interrupts(struct gpio_chip *chip)
> >>+{
This is not an atomic context so there is no need to use mdelay() but
instead use usleep_range().
Signed-off-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-core.c
b
Using autosuspend helps to reduce the resume latency in situations where
another I2C message is going to be started soon. For example with HID over
I2C touch panels we get several messages in a short period of time while
the touch panel is in use.
Signed-off-by: Mika Westerberg
---
drivers/i2c
there is no hardware available
outside Intel we can fix this by switching to use dynamic adapter numbering
instead of static.
Signed-off-by: Mika Westerberg
---
Changes to v1:
- Updated commit message to mention that this change should not
cause regressions as there are no real users
From: Andy Shevchenko
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller an tidier.
Signed-off-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 68
From: Andy Shevchenko
With dev_err() we can get the device instance printed as well and is pretty
much standard to use dev_* macros in the drivers anyway. In addition
correct the indentation of probe() arguments.
Signed-off-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
---
drivers/i2c
the function returns.
Signed-off-by: Mika Westerberg
---
Changes to v1:
- Added comment about why we sleep 25us after each iteration.
- } while (timeout--); instead of } while (timeout-- > 0);
drivers/i2c/busses/i2c-designware-core.c | 34 --
1 f
From: Andy Shevchenko
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko
Signed-off-by: Mika Westerberg
---
Changes to v1:
- dropped redundant dev_err() after
On Wed, Apr 10, 2013 at 12:39:21PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, April 10, 2013 12:17:47 PM Mika Westerberg wrote:
> > On Wed, Apr 10, 2013 at 11:17:57AM +0300, Mathias Nyman wrote:
> > > On 04/10/2013 10:53 AM, Mika Westerberg wrote:
> > > >On T
On Wed, Apr 10, 2013 at 05:13:57PM +0530, Shubhrajyoti Datta wrote:
> Hi Mika,
>
>
>
> On Wed, Apr 10, 2013 at 4:06 PM, Mika Westerberg <
> mika.westerb...@linux.intel.com> wrote:
>
> > Using autosuspend helps to reduce the resume latency in situations where
&g
ot needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
d.
>
> This patch tells gpio_langwell to not ignore irq_base if != 0 and
> preferably use it to avoid the conflict.
>
> If DT is used, irq_base can safely be 0.
>
> Signed-off-by: David Cohen
Presuming that you have tested this on Medfield and it still works there.
Acked-by:
On Wed, Apr 03, 2013 at 01:04:26PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, April 03, 2013 01:56:54 PM Mika Westerberg wrote:
> > Instead of open-coding ACPI GPIO resource lookup in each driver, we provide
> > a helper function analogous to Device Tree version that al
On Fri, Apr 12, 2013 at 12:35:05AM +0200, Linus Walleij wrote:
> On Thu, Apr 11, 2013 at 9:29 AM, Mika Westerberg
> wrote:
>
> > Grant and Linus W,
> >
> > Do you have any comments on this patch? Could it still be merged for 3.10?
>
> No and yes.
>
>
On Fri, May 17, 2013 at 10:29:28AM +0200, Wolfram Sang wrote:
> On Tue, May 14, 2013 at 02:07:45PM +0300, Mika Westerberg wrote:
> > On Tue, Apr 09, 2013 at 12:59:54PM +0200, Christian Ruppert wrote:
> > > This patch makes the SDA hold time configurable through device tree.
>
On Mon, May 13, 2013 at 02:44:32PM +0300, Mika Westerberg wrote:
> On Mon, May 13, 2013 at 01:38:46PM +0200, Rafael J. Wysocki wrote:
> > On Monday, May 13, 2013 01:27:51 PM Mika Westerberg wrote:
> > > ACPI Timer() opcode should return monotonically increasing clock
(200)
[ 11.912170] ACPI: Sleep(1300)
[ 13.211577] ACPI: Sleep(1300)
That is much more closer to the values we expected.
Signed-off-by: Mika Westerberg
---
drivers/acpi/osl.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/acpi/osl.c b
that acpi_get_override_irq() gets only called when
we are dealing with legacy IRQ() or IRQNoFlags() descriptors.
While we are there correct pr_warning() to print the right triggering
value.
Signed-off-by: Mika Westerberg
---
drivers/acpi/resource.c | 16 +++-
1 file changed, 11
d-off-by: EunBong Song
Thanks for fixing this!
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
imple+0x47/0x60
> [] lnw_gpio_probe+0x119/0x217
> [] pci_device_probe+0x5a/0x92
> ...
>
> Signed-off-by: Andy Shevchenko
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.
On Wed, May 22, 2013 at 10:47:37AM +0300, Andy Shevchenko wrote:
> We better to use readl() function instead of bad looking direct access.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo
On Wed, May 22, 2013 at 10:47:38AM +0300, Andy Shevchenko wrote:
> This makes the error handling much more simpler than open-coding everything
> and
> in addition makes the probe function smaller an tidier.
>
> Signed-off-by: Andy Shevchenko
In general this change looks good. Getting rid of 61
On Wed, May 22, 2013 at 10:47:39AM +0300, Andy Shevchenko wrote:
> There is no need to use hardcoded device name in the error messages, because
> dev_err() prefixes the message with the device name anyway.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Mika Westerberg
--
To unsubscri
On Wed, May 22, 2013 at 11:36:15AM +0300, Andy Shevchenko wrote:
> On Wed, May 22, 2013 at 11:05 AM, Mika Westerberg
> wrote:
> > On Wed, May 22, 2013 at 10:47:38AM +0300, Andy Shevchenko wrote:
> >> This makes the error handling much more simpler than open-coding
> &
be aborted) I2C drivers aren't supposed to abort
transactions on signals.
To prevent this switch to use wait_for_completion_timeout() instead of
wait_for_completion_interruptible_timeout() in the designware I2C driver.
Signed-off-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-c
On Wed, May 22, 2013 at 01:20:12PM +0300, Andy Shevchenko wrote:
> This makes the error handling much more simpler than open-coding everything
> and
> in addition makes the probe function smaller an tidier.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Mika Westerberg
--
To u
y Shevchenko
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
(200)
[ 11.912170] ACPI: Sleep(1300)
[ 13.211577] ACPI: Sleep(1300)
That is much more closer to the values we expected.
Signed-off-by: Mika Westerberg
---
Difference to the previous version is that now we use do_div() instead so
that i386 build won't break. This was fou
v, NULL) in drivers.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
On Thu, May 23, 2013 at 02:07:54PM +0300, Andy Shevchenko wrote:
> On Thu, May 23, 2013 at 1:19 PM, Vinod Koul wrote:
> > On Tue, May 21, 2013 at 12:29:39PM +0300, Andy Shevchenko wrote:
> >> On Tue, 2013-05-14 at 10:24 +0530, Vinod Koul wrote:
> >> > On Wed, May 08, 2013 at 11:55:47AM +0300, Andy
On Tue, May 28, 2013 at 02:53:47PM +0200, Rafael J. Wysocki wrote:
> On Monday, May 13, 2013 01:50:18 PM Rafael J. Wysocki wrote:
> > On Monday, May 13, 2013 02:05:27 PM Mika Westerberg wrote:
> > > If the device is using autosuspend we should honor that and call
> >
c | 12 +++++---
> drivers/i2c/i2c-core.c |2 +-
i2c-core runtime PM idle still works with this patch :-)
You can add my
Tested-by: Mika Westerberg
for the i2c parts if you like.
> drivers/mmc/core/sdio_bus.c|2 +-
> drivers/pci/pci-driver.
On Sat, Mar 30, 2013 at 02:05:43AM +0530, Vinod Koul wrote:
> On Wed, Mar 27, 2013 at 10:57:57AM +0200, Andy Shevchenko wrote:
> > + * @dev: struct device to get DMA request from
> > + * @index: index of FixedDMA descriptor for @dev
> > + *
> > + * Returns pointer to appropriate dma channel on su
side ACPI DMA helpers code.
> >
> > Signed-off-by: Andy Shevchenko
> > Signed-off-by: Mika Westerberg
> > Acked-by: Rafael J. Wysocki
> for such a patch git format-patch -M is your friend. It generates patch to
> show
> file movement. It helps review greatly if you
struct spi_master's ACPI handle (which should be NULL).
>
> Make that happen and modify the spi-pxa2xx driver, which currently is
> the only driver for ACPI-enumerated SPI controller chips, not to set
> the ACPI handle for the struct spi_master it creates.
>
> Signed-off-
> struct i2c_adapter's ACPI handle (which should be NULL).
>
> Make that happen and modify the i2c-designware-platdrv driver,
> which currently is the only driver for ACPI-enumerated I2C
> controller chips, not to set the ACPI handle for the
> struct i2c_adapter it creates.
On Thu, Mar 07, 2013 at 04:23:56AM +0100, Linus Walleij wrote:
> Hi Mika,
>
> On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg
> wrote:
>
> > -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
> > +static bool ichx_gpio_check_available(struct g
It is more readable for humans to use double-bang (!!) to convert the value
to pure boolean before it is returned.
Signed-off-by: Mika Westerberg
---
drivers/gpio/gpio-ich.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
On Fri, Mar 08, 2013 at 02:38:12PM +0200, Mathias Nyman wrote:
> Lynxpoint gpio driver uses X86 specific io-ports to control gpios
>
> Signed-off-by: Mathias Nyman
Reviewed-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
or Safety Timer Expiration.
> This interrupt is helpful in debugging the cause for charger fault.
>
> Signed-off-by: Ramakrishna Pallala
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
or Safety Timer Expiration.
> This interrupt is helpful in debugging the cause for charger fault.
>
> Resending this patch because previous patch missed Anton's attention
>
> Signed-off-by: Ramakrishna Pallala
Acked-by: Mika Westerberg
--
To unsubscribe from this list: send the
On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init':
> drivers/net/ethernet/i825xx/znet.c:868:2: error:
On Fri, Jul 20, 2012 at 07:22:48PM +0530, Ramakrishna Pallala wrote:
> This patch checks for charger status register for determining the
> battery charging status and reports Discharing/Charging/Not Charging/Full
> accordingly.
>
> This patch also adds the interrupt support for Safety Timer Expira
On Thu, Jun 28, 2012 at 01:59:19PM +0300, Mika Westerberg wrote:
> This is similar than what is done for other busses before (PCI, I2C, SPI,
> platform). It reduces a lot of unnecessary boilerplate code from modules.
>
> We also remove following redundant check on few drivers:
&
Intel Lynxpoint PCH Low Power Subsystem has two general purpose SPI
controllers that are LPSS_SSP compatible. These controllers are enumerated
from ACPI namespace with ACPI IDs INT33C0 and INT33C1.
Signed-off-by: Mika Westerberg
---
drivers/spi/Kconfig |2 +-
drivers/spi/spi-pxa2xx.c
usage of any DMA controller that implements DMA engine API.
Signed-off-by: Mika Westerberg
---
This patch was already acked by Linus W but since I changed this by
breaking out the PXA private implementation into a separate file, I'm
hoping to get new ack from him ;-)
drivers/spi/Kc
Drivers should put the device into low power states proactively whenever the
device is not in use. Thus implement support for runtime PM and use the
autosuspend feature to make sure that we can still perform well in case we see
lots of SPI traffic within short period of time.
Signed-off-by: Mika
The SPI core provides infrastructure for standard message queueing so use
that instead of handling everything in the driver. This simplifies the
driver.
Signed-off-by: Mika Westerberg
Acked-by: Linus Walleij
---
drivers/spi/spi-pxa2xx.c | 212 +++---
1
301 - 400 of 2936 matches
Mail list logo
