Re: [PATCH V2] scripts: objdiff: detect object code changes between two commits

2014-03-29 Thread Michal Marek
Dne 24.3.2014 03:14, Jason Cooper napsal(a): > > objdiff can be used in conjunction with a git rebase to confirm that > each commit made no changes to the resulting object code. It has the > same return values as diff(1). This looks nice. Just a few comments below: > +# usage example: > +# > +

Re: [mtd/sbc_gxx] kernel BUG at include/linux/mtd/map.h:148!

2014-03-31 Thread Michal Marek
blem we run into is, how to select one of the above > CONFIG_MTD_MAP_BANK_WIDTH_xx in "make randconfig". You can't enforce this in Kconfig. What you can do is to make the logic more fool-proof and fall back to some sensible default if none of the CONFIG_MTD_MAP_BANK_WIDTH_* opt

Re: [PATCH 2/2 v3] initramfs: print error and shell out for unsupported content

2014-03-31 Thread Michal Marek
Dne 22.3.2014 19:22, Alexander Holler napsal(a): > Am 22.03.2014 13:29, schrieb Alexander Holler: >> The initramfs generation is broken for file and directory names which >> contain >> colons, spaces and other unusual characters. Print an error and don't >> try to >> continue. > > (...) >> +#

Re: [PATCH] kbuild: create a build directory automatically for out-of-tree build

2014-03-31 Thread Michal Marek
Dne 31.3.2014 22:36, Sam Ravnborg napsal(a): > On Mon, Mar 31, 2014 at 04:41:36PM +0900, Masahiro Yamada wrote: >> Kbuild supports saving output files in a separate directory. >> But the build directory must be created beforehand. For example, >> >> $ mkdir -p dir/to/store/output/files >> $ mak

Re: [PATCH 2/2 v3] initramfs: print error and shell out for unsupported content

2014-04-01 Thread Michal Marek
On 2014-04-01 13:23, Alexander Holler wrote: > But as I already said, trying to use arbitrary filenames in a Makefile > doesn't really work. There are still other problems, e.g. filenames with > a / (directory separator), *, or some of the special make variables like $<. > > So the really workin

Re: [PATCH 1/5] firmware: Simplify directory creation

2014-05-05 Thread Michal Marek
On 2014-04-30 18:12, Sam Ravnborg wrote: > On Tue, Apr 29, 2014 at 04:08:09PM +0200, Michal Marek wrote: >> When building the firmware blobs, use a simple loop to create >> directories in $(objtree), like in Makefile.build. This simplifies the >> rules and also makes it poss

Re: [PATCH 0/5] kbuild: Use relative paths if possible

2014-05-05 Thread Michal Marek
On 2014-04-30 18:13, Sam Ravnborg wrote: > On Tue, Apr 29, 2014 at 04:08:08PM +0200, Michal Marek wrote: >> Hi, >> >> This series changes the Makefile to use relative paths for $(objtree), >> always setting it to '.', and for $(srctree) setting either to '

Re: [PATCH v2 3/5] kbuild: Use relative path for $(objtree)

2014-06-04 Thread Michal Marek
On 2014-06-04 11:03, Richard Weinberger wrote: > On Fri, May 9, 2014 at 2:52 PM, Michal Marek wrote: >> The main Makefile sets its working directory to the object tree and >> never changes it again. Therefore, we can use '.' instead of the >> absolute path.

Re: [PATCH v2 3/5] kbuild: Use relative path for $(objtree)

2014-06-04 Thread Michal Marek
On 2014-06-04 11:43, Michal Marek wrote: > On 2014-06-04 11:03, Richard Weinberger wrote: >> On Fri, May 9, 2014 at 2:52 PM, Michal Marek wrote: >>> The main Makefile sets its working directory to the object tree and >>> never changes it again. Therefore, we

Re: Regression: make O=... deb-pkg broken in 3.16

2014-06-16 Thread Michal Marek
On 2014-06-15 12:51, Ilya Dryomov wrote: > Hi Michal, > > Your relative path changes in the first kbuild pull request for 3.16 > broke make O=... deb-pkg. > > /home/ubuntu/foo/linux-a/scripts/package/builddeb: line 291: > ./debian/hdrsrcfiles: No such file or directory > > 290 # Build header pa

[PATCH] deb-pkg: Fix for relative paths

2014-06-16 Thread Michal Marek
When $srctree or $objtree are relative paths, we cannot change directory and refer to them in the same subshell. Do the redirection outside of the subshell to fix this. Reported-by: Ilya Dryomov Signed-off-by: Michal Marek --- scripts/package/builddeb | 10 +- 1 file changed, 5

Re: MANY errors while building media docbooks

2014-06-17 Thread Michal Marek
On 2014-06-16 19:28, Randy Dunlap wrote: > on Linux v3.16-rc1, building docbooks to a separate build directory > (mkdir DOC; make O=DOC htmldocs) gives me more than 12,000 lines like this: > > grep: ./Documentation/DocBook//vidioc-subdev-g-fmt.xml: No such file or > directory > grep: ./Documentat

Re: relative objtree change broke tar builds?

2014-06-18 Thread Michal Marek
Dne 18.6.2014 00:38, J. Bruce Fields napsal(a): > The scripts I use for my kernel testing rely on the targz-pkg make > target. After updating to 3.16-rc1 my scripts started failing. In > scripts/package/buildtar: > > tmpdir="${objtree}/tar-install" > tarball="${objtree}/linux-${KERNELRELEASE

Re: [PATCH 03/11] bin2c: Move bin2c in scripts/basic

2014-01-27 Thread Michal Marek
Dne 27.1.2014 19:57, Vivek Goyal napsal(a): > Kexec wants to use bin2c and it wants to use it really early in the build > process. See arch/x86/purgatory/ code in later patches. > > So move bin2c in scripts/basic so that it can be built very early and > be usable by arch/x86/purgatory/ > > Signed

Re: [PATCH 03/11] bin2c: Move bin2c in scripts/basic

2014-01-27 Thread Michal Marek
Dne 27.1.2014 22:18, Vivek Goyal napsal(a): > On Mon, Jan 27, 2014 at 10:12:10PM +0100, Michal Marek wrote: >> Dne 27.1.2014 19:57, Vivek Goyal napsal(a): >>> Kexec wants to use bin2c and it wants to use it really early in the build >>> process. See arch/x86/purga

Re: [PATCH v3] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-27 Thread Michal Marek
Dne 25.1.2014 12:07, Chen Gang napsal(a): > On 01/21/2014 12:55 PM, Vineet Gupta wrote: >> Hi Mike, >> >> On Saturday 18 January 2014 03:14 PM, Chen Gang wrote: >>> Hello Maintainers: >>> >>> Please help check this patch when you have time. >>> >>> Thanks. >> >> Do you know whose tree this is goona

Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

2014-01-27 Thread Michal Marek
On 14.1.2014 22:46, Greg KH wrote: > On Tue, Jan 14, 2014 at 01:40:15PM -0800, Josh Triplett wrote: >> On Tue, Jan 14, 2014 at 09:56:53PM +0100, Michal Marek wrote: >>> Dne 3.1.2014 22:00, Josh Triplett napsal(a): >>>> On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal

[GIT] kbuild changes for v3.14-rc1

2014-01-29 Thread Michal Marek
Hi Linus, please pull these kbuild bits for v3.14-rc1: - Fix make -s detection with make-4.0 - Fix for scripts/setlocalversion when the kernel repository is a submodule - Do not hardcode ';' in macros that expand to assembler code, as some architectures' assemblers use a different character fo

[GIT] kbuild: nuke remaining occurences of __TIME__/__DATE__

2014-01-29 Thread Michal Marek
Hi Linus, this series by Josh finishes the removal of __DATE__ and __TIME__ from the kernel. The last patch adds -Werror=date-time to KBUILD_CFLAGS to stop these from reappearing. Part of the series went through Greg's trees during this merge window, which is why this pull request is not based on

[GIT] kbuild misc changes for v3.14-rc1

2014-01-29 Thread Michal Marek
linux-headers package deb-pkg: Fix building for MIPS big-endian or ARM OABI Michal Marek (1): Merge commit v3.13-rc1 into kbuild/misc Nishanth Menon (1): scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR_VALUE scripts/coccinelle/api/pm_runtime.cocci | 109

Re: [PATCH] Makefile, CONFIG_MODVERSIONS, ignore *.mod.c files

2014-02-05 Thread Michal Marek
On 2014-02-05 16:01, Prarit Bhargava wrote: > Add *.mod.c to the RCS_FIND_IGNORE in the top-level Makefile and to the ignore > list in scripts/tags.sh. This breaks make clean, which is supposed to remove the *.mod.c files. Michal -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] Makefile, CONFIG_MODVERSIONS, ignore *.mod.c files

2014-02-05 Thread Michal Marek
On 2014-02-05 16:08, Prarit Bhargava wrote: > > > On 02/05/2014 10:05 AM, Michal Marek wrote: >> On 2014-02-05 16:01, Prarit Bhargava wrote: >>> Add *.mod.c to the RCS_FIND_IGNORE in the top-level Makefile and to the >>> ignore >>> list in scripts/tags.

Re: [PATCH 1/1] x86: boot: support minigzip bzImage compression

2013-10-23 Thread Michal Marek
On 23.10.2013 04:53, Guenter Roeck wrote: > On 10/22/2013 05:26 PM, H. Peter Anvin wrote: >> Wouldn't it be better to fix gzip than hacking around this in the kernel? >> > Or just change the build system to have /bin/gzip point to minigzip if so > desired. I have done the same to replace it with pi

Re: [PATCH][resend]scripts/tags.sh: Increase identifier list

2013-10-23 Thread Michal Marek
f-by: Kirill Tkhai > CC: Michal Marek > CC: Andrew Morton > --- > scripts/tags.sh |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) I took the patch from the mm tree and applied to kbuild.git#misc now. Sorry for the delay. Michal -- To unsubscribe from this list: send

Re: [PATCH RFC] kbuild: prevent git private tag altering kernelrelease

2013-10-23 Thread Michal Marek
Hi Afzal, sorry for the late feedback. On 13.9.2013 23:49, Afzal Mohammed wrote: > If a private tag is created after the most recent kernelversion tag, a > commit after this private tag would feed kernelrelease with commits > after private tag and kernelversion tag. This may confuse user relying

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

2013-10-23 Thread Michal Marek
On Wed, Oct 23, 2013 at 03:15:54PM +0200, Frank Haverkamp wrote: > Hi Marek, > > it took a little while, but here are the requested changes to our > driver: > > Rework comments: > o Removed __DATE__ macros as suggested by Michal Marek Hi Frank, did you send an old versio

Re: [PATCH] scripts/coccinelle/api: remove devm_request_and_ioremap.cocci

2013-10-23 Thread Michal Marek
On 6.10.2013 15:53, Julia Lawall wrote: > On Sun, 6 Oct 2013, Wolfram Sang wrote: > >> On Thu, Aug 15, 2013 at 12:30:25PM +0200, Wolfram Sang wrote: >>> Use of this function is discouraged in favour of >>> devm_ioremap_resource(). Don't advertise it. >>> >>> Signed-off-by: Wolfram Sang > > Acked

Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

2013-10-23 Thread Michal Marek
On 23.10.2013 16:14, Frank Haverkamp wrote: > of course you are right. Let me try again. > > I hope this looks better now: > + dev_info(&pci_dev->dev, "GenWQE driver version: %s %s%u\n", > + DRV_VERS_STRING, GENWQE_DEVNAME, cd->card_idx); > ... There is no __TIME__/__DATE__ macro now, which is go

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-24 Thread Michal Marek
On 24.10.2013 07:23, Michael Opdenacker wrote: > + count = subprocess.check_output('git grep ' + param + '| grep -v > defconfig | wc -l', shell=True) Python 2.6 does not have subprocess.check_output: $ ./scripts/checkkconfig.py INFO: processing Kconfig files... INFO: checking kconfig param

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-25 Thread Michal Marek
On 25.10.2013 15:38, Michael Opdenacker wrote: > Hi Joe, > > Thank you very much for your review! > > On 10/24/2013 09:30 AM, Joe Perches wrote: >> On Thu, 2013-10-24 at 07:23 +0200, Michael Opdenacker wrote: >> >>> +def count_param(param): >>> + >>> +global source_file, bad_params_in_file >>

Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length

2013-11-13 Thread Michal Marek
On 12.11.2013 22:55, Joe Mario wrote: > Given there are 5 other locations in the code that need to be changed > from [128] to [KSYM_NAME_LEN], and that we still haven't found Fengguang's > problem yet, I'd be in favor of letting Michal's revert patch 2/2 go > forward. It's in kbuild.git#kbu

[GIT] kbuild changes for v3.13-rc1

2013-11-15 Thread Michal Marek
ges in the size of linux_banner scripts/bloat-o-meter: use .startswith rather than fragile slicing Kees Cook (1): kbuild: replace unbounded sprintf call in modpost Michal Marek (1): kallsyms: Revert back to 128 max symbol length Sergei Trofimovich (1): Makefile: enab

[GIT] kconfig changes for v3.13-rc1

2013-11-15 Thread Michal Marek
or conflicting types kconfig: remove unused definition from scanner kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len Michal Marek (2): MAINTAINERS: New kconfig maintainer Merge branch 'yem/kconfig-for-next' of git://gitorious.o

[GIT] kbuild misc changes for v3.13-rc1

2013-11-15 Thread Michal Marek
Hi Linus, please pull these script updates for v3.13-rc1: - make tags fixes again - scripts/show_delta fix for newer python - scripts/kernel-doc does not fail on unknown function prototype - One less coccinelle check this time Thanks, Michal The following changes since commit 272b98c6455f00884f0

[PATCH] mfd: Make MFD_AS3722 depend on I2C=y

2013-11-18 Thread Michal Marek
r' drivers/built-in.o: In function `as3722_i2c_driver_exit': drivers/mfd/as3722.c:444: undefined reference to `i2c_del_driver' Signed-off-by: Michal Marek --- drivers/mfd/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/

Re: [PATCH] mfd: Make MFD_AS3722 depend on I2C=y

2013-11-18 Thread Michal Marek
On 19.11.2013 00:19, Stephen Warren wrote: > On 11/18/2013 10:25 AM, Michal Marek wrote: >> MFD_AS3722 can only be builtin, so it needs I2C builtin as well. >> With I2C=m, we get: >> >> drivers/mfd/as3722.c:372: undefined reference to `devm_regmap_init_i2c' &g

Re: [PATCH] Makefile, CONFIG_MODVERSIONS, export RCS_FIND_IGNORE and ignore *.mod.c files in tags creation

2014-02-06 Thread Michal Marek
On 2014-02-06 13:51, Prarit Bhargava wrote: > CONFIG_MODVERSIONS=y results in a .mod.c for every compiled file in the > kernel. > Issuing a 'make cscope' on a compiled kernel tree results in the cscope files > containing *.mod.c files. > > [prarit@prarit linux]# make cscope > [prarit@prarit linux

Re: [PATCH RFC] kernel build: enable use of password-protected signing keys

2014-02-10 Thread Michal Marek
On 9.2.2014 23:38, Emily Maier wrote: > Currently, the module signing script assumes that the private key is > not password-protected. This patch makes it slightly more secure by > allowing it to be passed in on the command line as "make > modules_install MOD_PASSWORD=abc". It's vulnerable to sn

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-03 Thread Michal Marek
On 2013-11-21 10:58, Vineet Gupta wrote: > On 11/01/2013 11:15 AM, Vineet Gupta wrote: >> +CC Sam, Tim, Joe, Michal, David >> >> Guys can you please take a look at this patch and suggest the best way to >> merge. >> >> The root cause is some gas ports (including ARC) use ';' for comment (vs. >> n

Re: [PATCH resend] scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR_VALUE

2014-01-03 Thread Michal Marek
On 2013-12-02 14:39, Nishanth Menon wrote: > As indicated by Sekhar in [1], there seems to be a tendency to use > IS_ERR_VALUE to check the error result for pm_runtime_* functions which > make no sense considering commit c48cd65 (ARM: OMAP: use consistent > error checking) - the error values can ei

Re: [PATCH resend] scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR_VALUE

2014-01-03 Thread Michal Marek
On Fri, Jan 03, 2014 at 02:29:35PM +0100, Julia Lawall wrote: > > On Fri, 3 Jan 2014, Michal Marek wrote: > > > On 2013-12-02 14:39, Nishanth Menon wrote: > > > As indicated by Sekhar in [1], there seems to be a tendency to use > > > IS_ERR_VALUE to check

Re: [PATCH] Fix detectition of kernel git repository in setlocalversion script [take #2]

2014-01-03 Thread Michal Marek
On Mon, Dec 02, 2013 at 04:34:29PM +0100, Franck Bui-Huu wrote: > setlocalversion script was testing the presence of .git directory in order to > find out > if git is used as SCM to track the current kernel project. However in some > cases, .git > is not a directory but can be a file: when the ke

Re: [PATCH] kbuild: Fix silent builds with make-4

2014-01-03 Thread Michal Marek
On 2013-12-05 22:56, Emil Medve wrote: > make-4 changed the way/order it presents the command line options > into MAKEFLAGS > > In make-3.8x, '-s' would always be first into a group of options > with the '-'/hyphen removed > > $ make -p -s 2>/dev/null | grep ^MAKEFLAGS > MAKEFLAGS = sp > > In ma

Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

2014-01-03 Thread Michal Marek
date-time if available, to keep it that way. Nice, I didn't know about -Wdate-time. Do you want me to merge the entire series, or do you want individual maintainers merge the patches? In the latter case, I'd wait with applying 7/7 in order not to break the build. At any rate, you can add

Re: [PATCH] scripts/gcc-version.sh: handle CC="gcc -m32"

2014-01-03 Thread Michal Marek
On 2013-12-10 08:13, Rusty Russell wrote: > Without it we get ugly warnings (though build still succeeds). > > $ make -j8 CC="gcc -m32" > In file included from :0:0: > /usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file > or directory > #include >

Re: [PATCH] scripts/gcc-version.sh: handle CC="gcc -m32"

2014-01-03 Thread Michal Marek
On 3.1.2014 18:10, Michal Marek wrote: > On 2013-12-10 08:13, Rusty Russell wrote: >> Without it we get ugly warnings (though build still succeeds). >> >> $ make -j8 CC="gcc -m32" >> In file included from :0:0: >> /usr/include/stdc-predef.h:30:26: fatal

Re: [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it

2014-01-03 Thread Michal Marek
On 3.1.2014 21:29, Josh Triplett wrote: > Please feel free to take the entire series through your tree; I received > some maintainer acks, but no indications that the patches are going > through their trees. OK. I will wait until mid next week and commit with any acks received. Michal -- To unsu

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-06 Thread Michal Marek
On 2014-01-06 06:36, Vineet Gupta wrote: > Hi Michal, > > On Friday 03 January 2014 06:08 PM, Michal Marek wrote: >> On 2013-11-21 10:58, Vineet Gupta wrote: >>> On 11/01/2013 11:15 AM, Vineet Gupta wrote: >>>> +CC Sam, Tim, Joe, Michal, David >>>&

Re: #pragma once?

2014-01-07 Thread Michal Marek
On 2014-01-07 10:48, Geert Uytterhoeven wrote: > Furthermore some userspace may rely on doing #define XXX to avoid > including a specific kernel header (yes, it's ugly). This pattern is also sometimes used: $ head -6 include/linux/spinlock_up.h #ifndef __LINUX_SPINLOCK_UP_H #define __LINUX_SPINLOC

Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly

2014-08-22 Thread Michal Marek
Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a): > CC kbuild > > On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang wrote: >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index c49a775..0510a5d 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -199,6 +199,11 @@ config NEED_DMA_MA

Re: [RFC PATCH 2/4 v2] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

2014-08-22 Thread Michal Marek
Dne 20.8.2014 02:54, J. German Rivera napsal(a): > + pr_info("MC bus (built " __DATE__ " " __TIME__ ") registered\n"); This won't build with gcc 4.9: # Prohibit date/time macros, which would make the build non-deterministic KBUILD_CFLAGS += $(call cc-option,-Werror=date-time) Michal -- To

Re: [PATCH] builddeb: put the dbg files into the correct directory

2014-08-22 Thread Michal Marek
On Mon, Aug 18, 2014 at 10:49:28PM -0700, Darrick J. Wong wrote: > Since the conversion of objtree to use relative pathnames (commit > 7e1c04779e, "kbuild: Use relative path for $(objtree)"), the debug > info files have been ending up in /debian/dbgtmp/ in the regular > linux-image package instead

Re: [PATCH] Makefile: One last adjustment to relative paths

2014-08-25 Thread Michal Marek
On 2014-08-25 10:50, Boaz Harrosh wrote: > the simple fix is to have "Entering directory" print full path. > > [Stable needed for 3.16] > CC: Stable Tree > Signed-off-by: Boaz Harrosh > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile

Re: [PATCH] builddeb: put the dbg files into the correct directory

2014-08-26 Thread Michal Marek
On 2014-08-22 19:10, Darrick J. Wong wrote: > On Fri, Aug 22, 2014 at 03:56:07PM +0200, Michal Marek wrote: >> On Mon, Aug 18, 2014 at 10:49:28PM -0700, Darrick J. Wong wrote: >>> Since the conversion of objtree to use relative pathnames (commit >>> 7e1c04779e, &qu

[PATCH] builddeb: put the dbg files into the correct directory

2014-08-26 Thread Michal Marek
files end up in the -dbg package. This is based on a similar patch by Darrick. Reported-and-tested-by: "Darrick J. Wong" Signed-off-by: Michal Marek --- scripts/package/builddeb | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/script

Re: [PATCH 4/4] Documentation: kbuild: Improve grammar

2014-08-19 Thread Michal Marek
On 2014-08-13 13:42, Michal Marek wrote: > On 2014-08-12 19:03, Randy Dunlap wrote: >> On 08/08/14 08:23, Geert Uytterhoeven wrote: >>> - singular versus plural, >>> - "by" versus "of", >>> - missing "if", "it

Re: [PATCH 0/4] kbuild: Fix the dependency handling of multi-objs targets

2014-08-19 Thread Michal Marek
On 2014-08-19 09:34, Masahiro Yamada wrote: > 1/4 and 2/4 fix the core scripts. > > 3/4 and 4/4 refactors scripts/kconfig/Makefile based on 2/4. > > > > Masahiro Yamada (4): > kbuild: handle multi-objs dependency appropriately > kbuild: handle the dependency of multi-objs hostprogs appropri

[PATCH] kbuild: Make scripts executable

2014-08-20 Thread Michal Marek
The Makefiles call the respective interpreter explicitly, but this makes it easier to use the scripts manually. Signed-off-by: Michal Marek --- scripts/bootgraph.pl | 0 scripts/export_report.pl | 0 scripts/gcc-goto.sh| 0 scripts

Re: [PATCH] kbuild: Make scripts executable

2014-08-21 Thread Michal Marek
On 2014-08-21 05:25, Masahiro Yamada wrote: > Hi Michal, > > > On Wed, 20 Aug 2014 16:10:48 +0200 > Michal Marek wrote: > >> The Makefiles call the respective interpreter explicitly, but this makes >> it easier to use the scripts manually. >> >> Sig

Re: [PATCH] kbuild: Use symbolic link to the source tree for out-of-tree build

2014-08-05 Thread Michal Marek
On 2014-07-09 11:25, Masahiro Yamada wrote: > Hi Michal, > > > On Wed, 09 Jul 2014 10:59:59 +0200 > Michal Marek wrote: > >> On 2014-07-09 08:27, Masahiro Yamada wrote: >>> Since commit 9da0763bd, the variable 'srctree' is set as follo

Re: [PATCH] scripts: sortextable: change type and initialise variable

2014-08-05 Thread Michal Marek
On 2014-07-15 11:12, Klemen Jan Enova wrote: > Change the type of 'relocs_size' from 'int' to 'Elf32_Word' and > initialize it to 0, to fix the "maybe uninitialised variable" compiler > warning. Please include the verbatim warning in the commit message. > Signed-off-by: Klemen Jan Enova > --

Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON

2014-08-06 Thread Michal Marek
On 2014-08-05 20:16, Julia Lawall wrote: > > > On Tue, 5 Aug 2014, Michal Marek wrote: > >> On 2014-07-20 23:36, Himangi Saraogi wrote: >>> This script detects cases where BUG() follows an if condition on an >>> expression and replaces the if condition an

Re: [PATCH] kbuild: escape single backslashes in macro make-cmd

2014-08-06 Thread Michal Marek
On 2014-07-26 18:35, Konstantin Khlebnikov wrote: > This already has been fixed in commit c353acba28fb3fa1fd05fd > ("kbuild: make: fix if_changed when command contains backslashes") > but escaping still isn't perfect and triggers false-positive rebuilds. > > For x86 problem happens every time, bec

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

2014-08-06 Thread Michal Marek
On 2014-07-18 22:44, Shuah Khan wrote: > Add a new devtest make target to enable developer testing. This > new target does full build (make all) and then runs selftests. I agree with Sam that the name is rather ambiguous, but I can't suggest a better alternative right now. > Signed-off-by: Shuah

Re: [PATCH] kbuild: devtest - new make target for build all and run tests

2014-08-06 Thread Michal Marek
On 2014-08-06 16:04, Shuah Khan wrote: > On 08/06/2014 07:51 AM, Michal Marek wrote: >> On 2014-07-18 22:44, Shuah Khan wrote: >>> Add a new devtest make target to enable developer testing. This >>> new target does full build (make all) and then runs selftests. >>

Re: [PATCH] kbuild: escape single backslashes in macro make-cmd

2014-08-06 Thread Michal Marek
On 2014-08-06 14:19, Konstantin Khlebnikov wrote: > On Wed, Aug 6, 2014 at 3:45 PM, Michal Marek wrote: >> On 2014-07-26 18:35, Konstantin Khlebnikov wrote: >>> This already has been fixed in commit c353acba28fb3fa1fd05fd >>> ("kbuild: make: fix if_changed w

Re: [PATCH] kbuild: escape single backslashes in macro make-cmd

2014-08-07 Thread Michal Marek
On Wed, Aug 06, 2014 at 05:01:57PM +0200, Michal Marek wrote: > On 2014-08-06 14:19, Konstantin Khlebnikov wrote: > > On Wed, Aug 6, 2014 at 3:45 PM, Michal Marek wrote: > >> On 2014-07-26 18:35, Konstantin Khlebnikov wrote: > >>> This already has been fixed in

[PATCH] kbuild: Fix handling of backslashes in *.cmd files

2014-08-07 Thread Michal Marek
ebnikov Reviewed-by: Sam Ravnborg Signed-off-by: Michal Marek --- scripts/Kbuild.include | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index 122f95c..8a9a4e1 100644 --- a/scripts/Kbuild.include +++ b/sc

Re: [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests

2014-08-07 Thread Michal Marek
On Thu, Aug 07, 2014 at 01:07:46PM -0600, Shuah Khan wrote: > Add a new make target "kselftest" to enable kernel testing. This > new target builds and runs kernel selftests. Running as root is > recommended for a complete test run as some tests don't run when > run by non-root user. Build, install,

[GIT] kbuild for 3.17-rc1

2014-08-11 Thread Michal Marek
library support from Makefile.host kbuild: clean up scripts/Makefile.host kbuild: clean-up and bug fix of scripts/Makefile.host kbuild: allow to override Python command name Michal Marek (1): kbuild: Fix handling of backslashes in *.cmd files .gitignore

[GIT] kbuild misc changes for 3.17-rc1

2014-08-11 Thread Michal Marek
detect cast after memory allocation Coccinelle: Script to use ARRAY_SIZE instead of division of two sizeofs Coccinelle: Script to detect incorrect argument to sizeof Coccinelle: Script to replace if and BUG with BUG_ON Michal Marek (1): kbuild: make -s should be used with

Re: [PATCH 4/4] Documentation: kbuild: Improve grammar

2014-08-13 Thread Michal Marek
On 2014-08-12 19:03, Randy Dunlap wrote: > On 08/08/14 08:23, Geert Uytterhoeven wrote: >> - singular versus plural, >> - "by" versus "of", >> - missing "if", "it", "the", >> - consistent use of "xxx-specific" versus "xxx specific". >> >> Signed-off-by: Geert Uytterhoeven >> --- >> Docume

Re: [PATCH 1/1] kbuild: use $(srctree) to locate config headers from external modules

2014-08-04 Thread Michal Marek
On 2014-08-01 21:47, Devin J. Pohly wrote: > When making modules_install for an out-of-tree module, the current > directory is $(KBUILD_OUTPUT), and the Makefile recipe which verifies > the existence of files in include/config is unable to find them using a > relative path. This leads to a spuriou

Re: [PATCH 1/1] kbuild: use $(srctree) to locate config headers from external modules

2014-08-04 Thread Michal Marek
On 2014-08-04 16:43, Devin J. Pohly wrote: > On Mon, Aug 04, 2014 at 04:10:20PM +0200, Michal Marek wrote: >> include/generated is located in $(KBUILD_OUTPUT), which is different >> from $(srctree) when using O=. Can you post a sequence of commands that >> leads to the

Re: [PATCH v3] kbuild, LLVMLinux: Supress warnings unless W=1-3

2014-08-05 Thread Michal Marek
On 2014-08-01 06:08, beh...@converseincode.com wrote: > From: Behan Webster > > clang has more warnings enabled by default. Turn them off unless W is set. > This patch fixes a logic bug where warnings in clang were disabled when W was > set. > > Signed-off-by: Behan Webster > Signed-off-by: Ja

Re: [PATCHv1 1/2] Documentation: headers_install.txt is part of kbuild

2014-08-05 Thread Michal Marek
make/ directory has only one file, it will be removed >> as a consequence of moving 'headers_install.txt'. >> >> Cc: Kirill A. Shutemov >> Cc: Michal Marek >> Cc: David Woodhouse >> Cc: Rob Landley >> Cc: Sam Ravnborg >> Signed-off-by: Yan

Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON

2014-08-05 Thread Michal Marek
On 2014-07-20 23:36, Himangi Saraogi wrote: > This script detects cases where BUG() follows an if condition on an > expression and replaces the if condition and BUG() with a BUG_ON having > the conditional expression of the if statement as argument. > > Signed-off-by: Himangi Saraogi > Acked-by:

Re: [PATCH] kbuild: Fix output of make kernelrelease

2014-10-22 Thread Michal Marek
was ktest.pl which resides in the kernel. Can you please apply this patch? Thanks, Michal >From c660b235e25eee053337e0e6c952e87f39839c63 Mon Sep 17 00:00:00 2001 From: Michal Marek Date: Wed, 22 Oct 2014 21:25:39 +0200 Subject: [PATCH] ktest: Use make -s kernelrelease The previous tail -

Re: [PATCH] kbuild: Fix output of make kernelrelease

2014-10-23 Thread Michal Marek
On 2014-10-22 22:35, Steven Rostedt wrote: > On Wed, 22 Oct 2014 21:44:08 +0200 > Michal Marek wrote: > >> Dne 22.10.2014 v 16:19 Steven Rostedt napsal(a): >>> >>> Commit 7ff525712acf "kbuild: fake the "Entering directory ..." message >>&g

Re: [PATCH] kbuild: Fix output of make kernelrelease

2014-10-23 Thread Michal Marek
On 2014-10-23 03:11, Steven Rostedt wrote: > On Wed, 22 Oct 2014 21:44:08 +0200 > Michal Marek wrote: > >> Dne 22.10.2014 v 16:19 Steven Rostedt napsal(a): >>> >>> Commit 7ff525712acf "kbuild: fake the "Entering directory ..." message >>&g

[GIT PULL] kbuild changes for v3.18-rc1

2014-10-13 Thread Michal Marek
obj- := dummy.o" trick kbuild: remove unnecessary variable initializaions kbuild: remove obj-n and lib-n handling kbuild: arm: Do not define "comma" twice kbuild: simplify build, clean, modbuiltin shorthands Michal Marek (2): kbuild: Make scripts executable

Re: [GIT PULL] kbuild changes for v3.18-rc1

2014-10-13 Thread Michal Marek
Dne 13.10.2014 v 21:55 Michal Marek napsal(a): > Hi Linus, > > please pull the following for v3.18-rc1: > > * Fix for handling dependencies of *-objs targets by Masahiro Yamada > * Lots of cleanups in the kbuild machinery, also by Masahiro > * Fixes for the kconfig build to

[GIT PULL] kbuild misc changes for v3.17-rc1

2014-10-13 Thread Michal Marek
tle endian Michal Marek (1): builddeb: put the dbg files into the correct directory Documentation/kbuild/makefiles.txt | 94 ++- scripts/coccinelle/misc/simple_return.cocci | 180 scripts/package/builddeb| 26 ++-- scrip

Re: [PATCH] deb-pkg: remove obsolete -isp option to dpkg-gencontrol

2014-10-07 Thread Michal Marek
On 2014-10-05 19:43, Asbjoern Sloth Toennesen wrote: > The -isp option has been deprecated, after it became the default > behaviour back in 2006. > > Since dpkg 1.17.11, dpkg-gencontrol emits a warning on -isp usage. > > References: https://bugs.debian.org/215233 > Signed-off-by: Asbjoern Sloth T

Re: [PATCH] Kbuild: Check for CONFIG_READABLE_ASM when building .s targets

2014-10-07 Thread Michal Marek
On 2014-10-05 17:58, Borislav Petkov wrote: > On Sun, Oct 05, 2014 at 05:32:34PM +0200, Borislav Petkov wrote: >> From: Borislav Petkov >> >> We do need to look at the asm output of c files for various reasons. In >> order to do so, we do make .s. >> >> However, it can happen that the Kconfig opti

Re: [PATCH] Kbuild: Check for CONFIG_READABLE_ASM when building .s targets

2014-10-07 Thread Michal Marek
On 2014-10-07 14:27, Borislav Petkov wrote: > On Tue, Oct 07, 2014 at 02:13:56PM +0200, Michal Marek wrote: >> This violates the principle of least surprise: >> >> make $file.s >> as -o $file.o $file.s >> >> should be equivalent to >> >> make

Re: [PATCH 2/3] limit _shipped to c,h and S files

2014-10-01 Thread Michal Marek
On 2014-10-01 15:36, Nicholas Mc Guire wrote: > > limit _shipped to c,h and S files > > _shipped targets are intended for generated source files which should > not permit .o binary blobs which is currently the case. This patch > simply restricts _shipped targets to .c, .h and .S files. Patches 1

Re: [PATCH v8] checkkconfigsymbols.sh: reimplementation in python

2014-10-01 Thread Michal Marek
On 2014-09-29 19:05, Valentin Rothberg wrote: > The scripts/checkkconfigsymbols.sh script searches Kconfig features > in the source code that are not defined in Kconfig. Such identifiers > always evaluate to false and are the source of various kinds of bugs. > However, the shell script is slow and

Re: [PATCH 1/3] kbuild: fake the "Entering directory ..." message more simply

2014-10-01 Thread Michal Marek
Dne 9.9.2014 13:02, Masahiro Yamada napsal(a): > Commit c2e28dc975ea87feed84415006ae143424912ac7 > (kbuild: Print the name of the build directory) > added a gimmick to show the "Entering directory ...". > > Instead of echoing the hard-coded message (that is, we need to know > the exact message), m

Re: [PATCH 3/3] kbuild: handle C=... and M=... after entering into build directory

2014-10-01 Thread Michal Marek
Dne 9.9.2014 13:02, Masahiro Yamada napsal(a): > sub-make: FORCE > $(Q)$(MAKE) -C $(KBUILD_OUTPUT) KBUILD_SRC=$(CURDIR) \ > - KBUILD_EXTMOD="$(KBUILD_EXTMOD)" -f $(CURDIR)/Makefile \ > - $(filter-out _all sub-make,$(MAKECMDGOALS)) > + -f $(CURDIR)/Makefile $(filter-out _all sub-m

Re: [PATCH 3/3] kbuild: remove obj-n and lib-n handling

2014-10-02 Thread Michal Marek
On 2014-09-09 12:26, Masahiro Yamada wrote: > Kconfig never defines CONFIG_* as 'n'. > Now obj-n is only used in firmware/Makefile and it can be > replaced with obj-. No makefile uses lib-n. A possible usecase would be overriding CONFIG_ options on the commandline: make CONFIG_FOOBAR=n but CONF

Re: [PATCH 3/3] kbuild: remove obj-n and lib-n handling

2014-10-02 Thread Michal Marek
On 2014-09-09 12:26, Masahiro Yamada wrote: > Kconfig never defines CONFIG_* as 'n'. > Now obj-n is only used in firmware/Makefile and it can be > replaced with obj-. No makefile uses lib-n. BTW, there are a few more instances of *-n, none of which seem useful: $ git --no-pager grep -e '[a-z]-n\

Re: [PATCH] kbuild: simplify build, clean, modbuiltin shorthands

2014-10-02 Thread Michal Marek
On 2014-09-09 13:03, Masahiro Yamada wrote: > $(if $(KBUILD_SRC),$(srctree)/) was a useful strategy > to omit a long absolute path for in-source-tree build > prior to commit 890676c65d699db3ad82e70cf8fb449031af > (kbuild: Use relative path when building in the source tree). I think it was quit

[PATCH] kbuild: Do not reference *-n variables in the Makefile

2014-10-02 Thread Michal Marek
Kconfig options are either 'y', 'm', or undefined. Signed-off-by: Michal Marek --- Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index efbd2cb..106f300 100644 --- a/Makefile +++ b/Makefile @@ -868,9 +8

Re: [PATCH] kbuild: Do not reference *-n variables in the Makefile

2014-10-02 Thread Michal Marek
On 2014-10-02 15:33, Michal Marek wrote: > Kconfig options are either 'y', 'm', or undefined. > > Signed-off-by: Michal Marek > --- > Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile >

[PATCH] IXP4xx: Makefile cleanup

2014-10-02 Thread Michal Marek
obj-pci-n will never be assigned or used. obj-pci-y does not need to be initialized, because each Kbuild file is processed separately. Signed-off-by: Michal Marek --- arch/arm/mach-ixp4xx/Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-ixp4xx/Makefile b/arch/arm

[PATCH] powerpc/boot: Makefile cleanup

2014-10-02 Thread Michal Marek
The $(image-n) variable will never exist, because unset Kconfig options are '' and not 'n'. Signed-off-by: Michal Marek --- arch/powerpc/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Ma

Re: [PATCH] Makefile: Force gzip and xz on module install

2015-07-22 Thread Michal Marek
Dne 7.7.2015 v 20:26 Jason A. Donenfeld napsal(a): > Running `make modules_install` ordinarily will overwrite existing > modules. This is the desired behavior, and is how pretty much every > other `make install` target works. > > However, if CONFIG_MODULE_COMPRESS is enabled, modules are passed >

Re: [PATCH] fallback to hostname in scripts/package/builddeb

2015-08-04 Thread Michal Marek
On Sun, Aug 02, 2015 at 08:03:26PM -0700, Christian Kujau wrote: > Hi, > > I happened to build a kernel with "make deb-pkg" on a machine with no > network connectivity, but this failed with: > > [...] > INSTALL debian/headertmp/usr/include/asm/ (65 files) > hostname: Name or service not known

Re: [PATCH] kbuild: document recursive dependency limitation / resolution

2015-08-04 Thread Michal Marek
Dne 29.7.2015 v 22:34 Randy Dunlap napsal(a): > On 07/29/15 13:09, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" >> >> Recursive dependency issues with kconfig are unavoidable due to >> some limitations with kconfig, since these issues are recurring >> provide a hint to the user how they c

<    2   3   4   5   6   7   8   9   10   11   >